[jira] [Updated] (NIFI-4105) support the specified Maximum value column and CSV Stream for Cassandra
[ https://issues.apache.org/jira/browse/NIFI-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-4105: --- Affects Version/s: (was: 1.3.0) Status: Patch Available (was: Open) > support the specified Maximum value column and CSV Stream for Cassandra > --- > > Key: NIFI-4105 > URL: https://issues.apache.org/jira/browse/NIFI-4105 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Yoonwon Ko >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > I'm trying to find a CassandraProcessor to fetch rows whose values in the > specified Maximum Value columns are larger than the previously-seen maximum > like QueryDatabaseTable. > But I found only QueryCassandra. It just executes same CQL everytime without > keeping maximum value. > and I think we also need convertToCsvStream option. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12532) Possible memory leak in ConnectionLoadBalanceServer
[
https://issues.apache.org/jira/browse/NIFI-12532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799645#comment-17799645
]
ASF subversion and git services commented on NIFI-12532:
Commit c670161cb09855b28e444a4d32d37427b31e8422 in nifi's branch
refs/heads/main from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c670161cb0 ]
NIFI-12532: This closes #8179. Ensure that when CommunicateAction completes
(exceptionally or otherwise) that it gets removed from the list of all
CommunicationActions
Signed-off-by: Joseph Witt
> Possible memory leak in ConnectionLoadBalanceServer
> ---
>
> Key: NIFI-12532
> URL: https://issues.apache.org/jira/browse/NIFI-12532
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Stijn Caerts
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The ConnectionLoadBalanceServer possibly contains a memory leak.
> When analyzing a heap dump of a NiFi node in our clustered setup with version
> 1.16.3, a large part of the used memory was related to the
> {{ConnectionLoadBalanceServer}}.
> It had a retained size of 1,770,787,761 B (25.1%), with 106,710
> {{CommunicationAction}} objects taking up most of that size 1,770,787,608 B
> (25.1%).
> I checked the code of the {{ConnectionLoadBalanceServer}} to try to
> understand why it uses this much memory. This is when I noticed that
> {{CommunicationAction}} objects are only removed when the
> {{ConnectionLoadBalanceServer}} is stopped, creating a possible memory leak.
> Although we're not running the most recent version of NiFi, this is still
> present in the current version of the code.
> https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server/ConnectionLoadBalanceServer.java#L110
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-12532) Possible memory leak in ConnectionLoadBalanceServer
[
https://issues.apache.org/jira/browse/NIFI-12532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt resolved NIFI-12532.
-
Fix Version/s: 2.0.0
Resolution: Fixed
> Possible memory leak in ConnectionLoadBalanceServer
> ---
>
> Key: NIFI-12532
> URL: https://issues.apache.org/jira/browse/NIFI-12532
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Stijn Caerts
>Priority: Major
> Fix For: 2.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The ConnectionLoadBalanceServer possibly contains a memory leak.
> When analyzing a heap dump of a NiFi node in our clustered setup with version
> 1.16.3, a large part of the used memory was related to the
> {{ConnectionLoadBalanceServer}}.
> It had a retained size of 1,770,787,761 B (25.1%), with 106,710
> {{CommunicationAction}} objects taking up most of that size 1,770,787,608 B
> (25.1%).
> I checked the code of the {{ConnectionLoadBalanceServer}} to try to
> understand why it uses this much memory. This is when I noticed that
> {{CommunicationAction}} objects are only removed when the
> {{ConnectionLoadBalanceServer}} is stopped, creating a possible memory leak.
> Although we're not running the most recent version of NiFi, this is still
> present in the current version of the code.
> https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server/ConnectionLoadBalanceServer.java#L110
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12532: Ensure that when CommunicateAction completes (exceptional… [nifi]
asfgit closed pull request #8179: NIFI-12532: Ensure that when CommunicateAction completes (exceptional… URL: https://github.com/apache/nifi/pull/8179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799644#comment-17799644
]
Joe Witt commented on NIFI-12535:
-
Congrats and thanks for your first PR [~aethier]
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
> Labels: backport-needed
> Fix For: 1.25.0, 2.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document Table 14 is incorrectly named ??PadLeft Examples?? instead of
> ??PadRight Examples?? and the last example in that table incorrectly says
> padLeft when it should be padRight.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-12535:
Fix Version/s: 1.25.0
2.0.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
> Labels: backport-needed
> Fix For: 1.25.0, 2.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document Table 14 is incorrectly named ??PadLeft Examples?? instead of
> ??PadRight Examples?? and the last example in that table incorrectly says
> padLeft when it should be padRight.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799642#comment-17799642
]
ASF subversion and git services commented on NIFI-12535:
Commit 77093671e0ff90379ffc0fdf5be502cdf6988868 in nifi's branch
refs/heads/main from Alex Ethier
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=77093671e0 ]
NIFI-12535: This closes #8181. Fixed documentation for 'PadRight Examples'
table name in the Expression Language Guide as well as the last example in the
table.
Signed-off-by: Joseph Witt
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
> Labels: backport-needed
> Time Spent: 20m
> Remaining Estimate: 0h
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document Table 14 is incorrectly named ??PadLeft Examples?? instead of
> ??PadRight Examples?? and the last example in that table incorrectly says
> padLeft when it should be padRight.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799643#comment-17799643
]
ASF subversion and git services commented on NIFI-12535:
Commit 29821f6e71a5d763863e191d223c8fb7fda519c0 in nifi's branch
refs/heads/support/nifi-1.x from Alex Ethier
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=29821f6e71 ]
NIFI-12535: Fixed documentation for 'PadRight Examples' table name in the
Expression Language Guide as well as the last example in the table.
Signed-off-by: Joseph Witt
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
> Labels: backport-needed
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document Table 14 is incorrectly named ??PadLeft Examples?? instead of
> ??PadRight Examples?? and the last example in that table incorrectly says
> padLeft when it should be padRight.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12535: Fixed documentation for 'PadRight Examples' table name in… [nifi]
asfgit closed pull request #8181: NIFI-12535: Fixed documentation for 'PadRight Examples' table name in… URL: https://github.com/apache/nifi/pull/8181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12526) QueryCassandra should not output FlowFiles as soon as the "available rows without fetching" is reached
[ https://issues.apache.org/jira/browse/NIFI-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12526: Status: Patch Available (was: In Progress) > QueryCassandra should not output FlowFiles as soon as the "available rows > without fetching" is reached > -- > > Key: NIFI-12526 > URL: https://issues.apache.org/jira/browse/NIFI-12526 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 1.25.0, 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > NIFI-5642 introduced the Max Rows Per Flow File and Output Batch Size > properties to QueryCassandra, but still uses the internal > "rowsAvailableWithoutFetching" variable (whose value comes from the Cassandra > ResultSet and defaults to 5000) as a trigger to stop processing rows for a > FlowFile. This can cause unexpected behavior, such as getting multiple > FlowFiles when only one is expected. > Also since those properties were added, the fragment.* attributes should be > added and populated accordingly (such as ExecuteSQL does). > NIFI-5642 also removes the Compression Type property, which might be ok for > 2.x but will cause all flows using this property in 1.x to become invalid. On > the support (1.x) branch we need to add the property back in, perhaps we can > keep it removed for 2.x but we'd want to remove the Cassandra Connect Points > property and such to force the user to use a Cassandra Connection controller > service. The reason to add the property back is if the Cassandra Contact > Points property is used instead of the Cassandra Connection controller > service, there is no way to set the Compression Type. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12526: Fixed handling of Fetch Size in QueryCassandra, added fragment attributes [nifi]
mattyb149 opened a new pull request, #8183: URL: https://github.com/apache/nifi/pull/8183 # Summary [NIFI-12526](https://issues.apache.org/jira/browse/NIFI-12526) This PR fixes a logic error in how Fetch Size was being used to determine the number of rows in a FlowFile rather than the Max Rows Per FlowFile property. Since we do have the latter property, I added the `fragment.*` attributes with the same behavior as the ExecuteSQL(Record) processors. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-12526` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-12526` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12526) QueryCassandra should not output FlowFiles as soon as the "available rows without fetching" is reached
[ https://issues.apache.org/jira/browse/NIFI-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12526: Description: NIFI-5642 introduced the Max Rows Per Flow File and Output Batch Size properties to QueryCassandra, but still uses the internal "rowsAvailableWithoutFetching" variable (whose value comes from the Cassandra ResultSet and defaults to 5000) as a trigger to stop processing rows for a FlowFile. This can cause unexpected behavior, such as getting multiple FlowFiles when only one is expected. Also since those properties were added, the fragment.* attributes should be added and populated accordingly (such as ExecuteSQL does). NIFI-5642 also removes the Compression Type property, which might be ok for 2.x but will cause all flows using this property in 1.x to become invalid. On the support (1.x) branch we need to add the property back in, perhaps we can keep it removed for 2.x but we'd want to remove the Cassandra Connect Points property and such to force the user to use a Cassandra Connection controller service. The reason to add the property back is if the Cassandra Contact Points property is used instead of the Cassandra Connection controller service, there is no way to set the Compression Type. was: NIFI-5642 introduced the Max Rows Per Flow File and Output Batch Size properties to QueryCassandra, but still uses the internal "rowsAvailableWithoutFetching" variable (whose value comes from the Cassandra ResultSet and defaults to 5000) as a trigger to stop processing rows for a FlowFile. This can cause unexpected behavior, such as getting multiple FlowFiles when only one is expected. NIFI-5642 also removes the Compression Type property, which might be ok for 2.x but will cause all flows using this property in 1.x to become invalid. On the support (1.x) branch we need to add the property back in, perhaps we can keep it removed for 2.x but we'd want to remove the Cassandra Connect Points property and such to force the user to use a Cassandra Connection controller service. The reason to add the property back is if the Cassandra Contact Points property is used instead of the Cassandra Connection controller service, there is no way to set the Compression Type. > QueryCassandra should not output FlowFiles as soon as the "available rows > without fetching" is reached > -- > > Key: NIFI-12526 > URL: https://issues.apache.org/jira/browse/NIFI-12526 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 1.25.0, 2.0.0 > > > NIFI-5642 introduced the Max Rows Per Flow File and Output Batch Size > properties to QueryCassandra, but still uses the internal > "rowsAvailableWithoutFetching" variable (whose value comes from the Cassandra > ResultSet and defaults to 5000) as a trigger to stop processing rows for a > FlowFile. This can cause unexpected behavior, such as getting multiple > FlowFiles when only one is expected. > Also since those properties were added, the fragment.* attributes should be > added and populated accordingly (such as ExecuteSQL does). > NIFI-5642 also removes the Compression Type property, which might be ok for > 2.x but will cause all flows using this property in 1.x to become invalid. On > the support (1.x) branch we need to add the property back in, perhaps we can > keep it removed for 2.x but we'd want to remove the Cassandra Connect Points > property and such to force the user to use a Cassandra Connection controller > service. The reason to add the property back is if the Cassandra Contact > Points property is used instead of the Cassandra Connection controller > service, there is no way to set the Compression Type. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12526) QueryCassandra should not output FlowFiles as soon as the "available rows without fetching" is reached
[ https://issues.apache.org/jira/browse/NIFI-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-12526: --- Assignee: Matt Burgess > QueryCassandra should not output FlowFiles as soon as the "available rows > without fetching" is reached > -- > > Key: NIFI-12526 > URL: https://issues.apache.org/jira/browse/NIFI-12526 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 1.25.0, 2.0.0 > > > NIFI-5642 introduced the Max Rows Per Flow File and Output Batch Size > properties to QueryCassandra, but still uses the internal > "rowsAvailableWithoutFetching" variable (whose value comes from the Cassandra > ResultSet and defaults to 5000) as a trigger to stop processing rows for a > FlowFile. This can cause unexpected behavior, such as getting multiple > FlowFiles when only one is expected. > NIFI-5642 also removes the Compression Type property, which might be ok for > 2.x but will cause all flows using this property in 1.x to become invalid. On > the support (1.x) branch we need to add the property back in, perhaps we can > keep it removed for 2.x but we'd want to remove the Cassandra Connect Points > property and such to force the user to use a Cassandra Connection controller > service. The reason to add the property back is if the Cassandra Contact > Points property is used instead of the Cassandra Connection controller > service, there is no way to set the Compression Type. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
Lehel44 commented on PR #8094: URL: https://github.com/apache/nifi/pull/8094#issuecomment-1867062046 @joewitt I added the discussion link to the Jira, thanks for pointing out. The main issue here was that the SEND event used the size of the incoming FlowFile but instead of a copy of this FlowFile an external file was uploaded and sent to the external system, therefore its size should have been represented instead of the FlowFile's size. From the documentation: "SEND: Emits a Provenance Event of type that indicates that a copy of the given FlowFile was sent to an external destination.". The UPLOAD event would describe an external resource being uploaded to an external destination. While the SEND event automatically uses the size of the FlowFile argument when creating the event, the UPLOAD takes a FlowFile for necessary event attributes (flowfile UUID etc.), but also takes a FileResource object which represents the external resource and uses its attributes when constructing the event: for instance the size and the path are will be displayed in the provenance event. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12270) PuAzureBlobStorage with FileResourceService sends 0 byte PROVENANCE event
[ https://issues.apache.org/jira/browse/NIFI-12270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lehel Boér updated NIFI-12270: -- Description: There'a a need for a new provanace event type which can be emitted in case of uploading an external resource to an external system without storing it in a FlowFile. There's an example for the need in PutAzureBlobStorage when transferring files from the local file system. See discussion: [https://lists.apache.org/thread/hwt87hz4679vbmtv9yg78dw38jrwc861] was: There'a a need for a new provanace event type which can be emitted in case of uploading an external resource to an external system without storing it in a FlowFile. There's an example for the need in PutAzureBlobStorage when transferring files from the local file system. [See discussion|[https://lists.apache.org/thread/hwt87hz4679vbmtv9yg78dw38jrwc861]] > PuAzureBlobStorage with FileResourceService sends 0 byte PROVENANCE event > - > > Key: NIFI-12270 > URL: https://issues.apache.org/jira/browse/NIFI-12270 > Project: Apache NiFi > Issue Type: Bug >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > There'a a need for a new provanace event type which can be emitted in case of > uploading an external resource to an external system without storing it in a > FlowFile. There's an example for the need in PutAzureBlobStorage when > transferring files from the local file system. > See discussion: > [https://lists.apache.org/thread/hwt87hz4679vbmtv9yg78dw38jrwc861] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12270) PuAzureBlobStorage with FileResourceService sends 0 byte PROVENANCE event
[ https://issues.apache.org/jira/browse/NIFI-12270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lehel Boér updated NIFI-12270: -- Description: There'a a need for a new provanace event type which can be emitted in case of uploading an external resource to an external system without storing it in a FlowFile. There's an example for the need in PutAzureBlobStorage when transferring files from the local file system. [See discussion|[https://lists.apache.org/thread/hwt87hz4679vbmtv9yg78dw38jrwc861]] was:There'a a need for a new provanace event type which can be emitted in case of uploading an external resource to an external system without storing it in a FlowFile. There's an example for the need in PutAzureBlobStorage when transferring files from the local file system. > PuAzureBlobStorage with FileResourceService sends 0 byte PROVENANCE event > - > > Key: NIFI-12270 > URL: https://issues.apache.org/jira/browse/NIFI-12270 > Project: Apache NiFi > Issue Type: Bug >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > There'a a need for a new provanace event type which can be emitted in case of > uploading an external resource to an external system without storing it in a > FlowFile. There's an example for the need in PutAzureBlobStorage when > transferring files from the local file system. > [See > discussion|[https://lists.apache.org/thread/hwt87hz4679vbmtv9yg78dw38jrwc861]] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
markap14 commented on code in PR #8094: URL: https://github.com/apache/nifi/pull/8094#discussion_r1434525927 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml: ## @@ -468,6 +468,11 @@ org.glassfish.jaxb jaxb-runtime + +org.apache.nifi +nifi-data-provenance-utils +2.0.0-SNAPSHOT + Review Comment: We should probably eliminate this newly introduced `UploadContext`. While it does keep the `ProvenanceReporter` cleaner by avoiding introducing several potential overrides, it introduces more complexity into the Processors that might want to call the method. I.e., the overrides make the ProvenanceReporter more complex but make the Processors simpler. This is one of those situations where I could go either way. But the fact that interface already is laid out to use several overrides means it's cleaner to keep consistent. Additionally, it eliminates the need for something like this in data-provenance-utils and also avoids introducing something like this into the nifi-api -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
markap14 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1434523863
##
nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/upload/StandardFileResource.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.provenance.upload;
+
+public class StandardFileResource implements FileResource {
+
+private final String path;
+private final Long size;
+
+public StandardFileResource(final String path, final Long size) {
+this.path = path;
+this.size = size;
+}
+
+public String getLocation() {
+return path;
+}
+
+public Long getSize() {
+return size;
+}
+
+@Override
+public String toString() {
+return "location=" + path + ", " +
+"size=" + size;
Review Comment:
The toString() should include the fact that it's a StandardFileResource.
E.g., `return "StandardFileResource[location=" + location + ", size=" + size +
"]";`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
markap14 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1434523320
##
nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/upload/StandardUploadContext.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.provenance.upload;
+
+public class StandardUploadContext implements UploadContext {
+private String transitUri;
+private String details;
+private long transmissionMillis;
+private boolean force;
+
+private StandardUploadContext() {
+// Private constructor to enforce the use of the builder
+}
+
+@Override
+public String getTransitUri() {
+return transitUri;
+}
+
+public String getDetails() {
+return details;
+}
+
+@Override
+public long getTransmissionMillis() {
+return transmissionMillis;
+}
+
+@Override
+public boolean isForce() {
+return force;
+}
+
+public static class Builder {
+private final String transitUri;
+private String details;
+private long transmissionMillis;
+private boolean force;
+
+public Builder(String transitUri) {
+this.transitUri = transitUri;
+}
+
+public Builder details(String details) {
+this.details = details;
+return this;
+}
+
+public Builder transmissionMillis(long transmissionMillis) {
+this.transmissionMillis = transmissionMillis;
+return this;
+}
+
+public Builder force(boolean force) {
+this.force = force;
+return this;
+}
+
+public StandardUploadContext build() {
+StandardUploadContext event = new StandardUploadContext();
+event.transitUri = transitUri;
+event.details = details;
+event.transmissionMillis = transmissionMillis;
+event.force = force;
+return event;
Review Comment:
Preferred method here would be to pass the Builder to the constructor of
StandardUploadContext and mark all member variables in StandardUploadContext as
final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
markap14 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1434522640
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##
@@ -119,7 +122,7 @@ public void receiveMigration(final
Set events) {
* be created by the session itself, as well as by the Processor
*
* @param parents parents
- * @param child child
+ * @param child child
Review Comment:
This whitespace shouldn't be added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
markap14 commented on code in PR #8094: URL: https://github.com/apache/nifi/pull/8094#discussion_r1434522521 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml: ## @@ -468,6 +468,11 @@ org.glassfish.jaxb jaxb-runtime + +org.apache.nifi +nifi-data-provenance-utils +2.0.0-SNAPSHOT + Review Comment: Processors should not need to have a dependency on nifi-data-provenance-utils. The API should include anything necessary in order to emit the provenance event. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Ethier updated NIFI-12535:
---
Status: Patch Available (was: Open)
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 1.24.0, 2.0.0-M1
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
> Labels: backport-needed
> Time Spent: 20m
> Remaining Estimate: 0h
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document Table 14 is incorrectly named ??PadLeft Examples?? instead of
> ??PadRight Examples?? and the last example in that table incorrectly says
> padLeft when it should be padRight.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12531 Parameter references are removed after property migration [nifi]
markap14 commented on code in PR #8176: URL: https://github.com/apache/nifi/pull/8176#discussion_r1434518754 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java: ## @@ -2110,7 +2110,7 @@ private void migrateProperties(final Map originalPropertyValues, final List servicesCreated = propertyConfig.getCreatedServices(); servicesCreated.forEach(serviceFactory::create); -overwriteProperties(propertyConfig.getProperties()); +overwriteProperties(propertyConfig.getRawProperties()); Review Comment: Good catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12531 Parameter references are removed after property migration [nifi]
markap14 commented on code in PR #8176:
URL: https://github.com/apache/nifi/pull/8176#discussion_r1434518322
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java:
##
@@ -225,7 +225,7 @@ public class InvokeHTTP extends AbstractProcessor {
.build();
public static final PropertyDescriptor SOCKET_CONNECT_TIMEOUT = new
PropertyDescriptor.Builder()
-.name("Connection Timeout")
+.name("Socket Connection Timeout")
Review Comment:
Why is this rename happening here? I think the original name of 'Connection
Timeout' is more concise but also equally clear. But if it were to be renamed,
it would to be done so in the migrateProperties method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799579#comment-17799579
]
Daniel Stieglitz commented on NIFI-12535:
-
[~aethier] Change the status from 'Open' to 'Patch Available' by clicking
'Submit Patch'
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
> Labels: backport-needed
> Time Spent: 20m
> Remaining Estimate: 0h
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document Table 14 is incorrectly named ??PadLeft Examples?? instead of
> ??PadRight Examples?? and the last example in that table incorrectly says
> padLeft when it should be padRight.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-12535:
Labels: backport-needed (was: )
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
> Labels: backport-needed
> Time Spent: 20m
> Remaining Estimate: 0h
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document Table 14 is incorrectly named ??PadLeft Examples?? instead of
> ??PadRight Examples?? and the last example in that table incorrectly says
> padLeft when it should be padRight.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12535: Fixed documentation for 'PadRight Examples' table name in… [nifi]
alexethier commented on PR #8181: URL: https://github.com/apache/nifi/pull/8181#issuecomment-1866891835 > LGTM +1. Good catch! @alexethier I am curious why is the PR 'Draft'? @dan-s1 thanks for reviewing Dan! This is my first PR for NiFi so I made it a draft because I wanted to make sure I was following the PR process correctly before submitting. I also wanted to run and verify that `mvn clean install -P contrib-check` works before marking it as ready. I know my documentation based commit may not need as rigorous testing but I wanted to do things by the book this time . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12538) Add map Record Standalone Function
[
https://issues.apache.org/jira/browse/NIFI-12538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard updated NIFI-12538:
--
Status: Patch Available (was: Open)
> Add map Record Standalone Function
> --
>
> Key: NIFI-12538
> URL: https://issues.apache.org/jira/browse/NIFI-12538
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Adding a function that can be used to create a map of Strings.
> For example, if we have the following record:
>
> {code:java}
> {
> "firstName": "John",
> "lastName": "Snow"
> }{code}
>
> We could use the {{UpdateRecord}} processor with
> {code:java}
> /fullName => map("firstName", /firstName, "lastName", /lastName){code}
> And that would give us something like:
> {code:java}
> {
> "firstName": "John",
> "lastName": "Snow",
> "fullName": {"firstName": "John", "lastName": "Snow"}
> }{code}
> This function requires an even number of arguments and the record paths must
> represent simple field values.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12538 - Add map Record Standalone Function [nifi]
pvillard31 opened a new pull request, #8182: URL: https://github.com/apache/nifi/pull/8182 # Summary [NIFI-12538](https://issues.apache.org/jira/browse/NIFI-12538) - Add map Record Standalone Function # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12538) Add map Record Standalone Function
Pierre Villard created NIFI-12538:
-
Summary: Add map Record Standalone Function
Key: NIFI-12538
URL: https://issues.apache.org/jira/browse/NIFI-12538
Project: Apache NiFi
Issue Type: Improvement
Components: Core Framework
Reporter: Pierre Villard
Assignee: Pierre Villard
Adding a function that can be used to create a map of Strings.
For example, if we have the following record:
{code:java}
{
"firstName": "John",
"lastName": "Snow"
}{code}
We could use the {{UpdateRecord}} processor with
{code:java}
/fullName => map("firstName", /firstName, "lastName", /lastName){code}
And that would give us something like:
{code:java}
{
"firstName": "John",
"lastName": "Snow",
"fullName": {"firstName": "John", "lastName": "Snow"}
}{code}
This function requires an even number of arguments and the record paths must
represent simple field values.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12535: Fixed documentation for 'PadRight Examples' table name in… [nifi]
alexethier opened a new pull request, #8181: URL: https://github.com/apache/nifi/pull/8181 … the Expression Language Guide as well as the last example in the table. # Summary [NIFI-12535](https://issues.apache.org/jira/browse/NIFI-12535) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12528) Funnels bug
[ https://issues.apache.org/jira/browse/NIFI-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12528: Fix Version/s: 2.0.0 > Funnels bug > --- > > Key: NIFI-12528 > URL: https://issues.apache.org/jira/browse/NIFI-12528 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.23.2 > Environment: NiFi cluster >Reporter: Giovanni >Priority: Critical > Fix For: 2.0.0 > > Attachments: image001.png > > Time Spent: 20m > Remaining Estimate: 0h > > I've notice a bug in our working cluster of 4 nodes. > When two funnels are connected, with no other connections as themselves, like > in attached image, is not possible to delete them. > After trying to modify one of their connections, the Node where the action is > performed crashes, and will not turn on unless the entire cluster gets > restarted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12528) Funnels bug
[ https://issues.apache.org/jira/browse/NIFI-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt resolved NIFI-12528. - Resolution: Fixed > Funnels bug > --- > > Key: NIFI-12528 > URL: https://issues.apache.org/jira/browse/NIFI-12528 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.23.2 > Environment: NiFi cluster >Reporter: Giovanni >Priority: Critical > Fix For: 2.0.0 > > Attachments: image001.png > > Time Spent: 20m > Remaining Estimate: 0h > > I've notice a bug in our working cluster of 4 nodes. > When two funnels are connected, with no other connections as themselves, like > in attached image, is not possible to delete them. > After trying to modify one of their connections, the Node where the action is > performed crashes, and will not turn on unless the entire cluster gets > restarted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12528) Funnels bug
[ https://issues.apache.org/jira/browse/NIFI-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799538#comment-17799538 ] ASF subversion and git services commented on NIFI-12528: Commit c41b273e82c69466d4e518b814964883289edba7 in nifi's branch refs/heads/main from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c41b273e82 ] NIFI-12528: This closes #8180. Fixed bug that resulted in StackOverflowError when deleting loop containing only funnels Signed-off-by: Joseph Witt > Funnels bug > --- > > Key: NIFI-12528 > URL: https://issues.apache.org/jira/browse/NIFI-12528 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.23.2 > Environment: NiFi cluster >Reporter: Giovanni >Priority: Critical > Attachments: image001.png > > Time Spent: 10m > Remaining Estimate: 0h > > I've notice a bug in our working cluster of 4 nodes. > When two funnels are connected, with no other connections as themselves, like > in attached image, is not possible to delete them. > After trying to modify one of their connections, the Node where the action is > performed crashes, and will not turn on unless the entire cluster gets > restarted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12528: Fixed bug that resulted in StackOverflowError when deleti… [nifi]
asfgit closed pull request #8180: NIFI-12528: Fixed bug that resulted in StackOverflowError when deleti… URL: https://github.com/apache/nifi/pull/8180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12420: Add Sawmill transformation processors [nifi]
exceptionfactory commented on PR #8071: URL: https://github.com/apache/nifi/pull/8071#issuecomment-1866753429 As mentioned earlier, I'm hesitant on bringing in this component and bundle, even optionally, given the number of outdated dependencies. These findings still show up in reviews, even if not included in standard convenience binaries. It may be possible to address the old dependencies through overrides, but that is something that should be evaluated first, before going forward. If we can override old dependencies, then it seems like we would be in a better place to consider bringing this into the repository as an optional module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
joewitt commented on PR #8094: URL: https://github.com/apache/nifi/pull/8094#issuecomment-1866733000 Ahh that discussion context is helpful - would make sense to have that already linked in either the JIRA itself or this PR. If it was there and I missed it sorry about that. Otherwise, we need to put links to such good/useful discussions on these to help others who might review later. To the issue at hand, I do not share the view we should create a different event type here. The meaning of 'SEND' is that NiFi is responsible for having taken the bits of a thing and sent it to some external system. That is precisely what is happening here. Now there is value in knowing as well then that NiFi itself never actually stored the bits. This is known though already from the provenance trail of this object. Presumably it never had a CREATE/RECEIVE and the bytes will of course have never been populated other than perhaps a link/reference. Given there was already a decent discussion and some apparent consensus and clearly this was a lot of work I am not saying I am a -1 on this but it does add more code/more maintenance/more semantics and I'm not clear what the value add will be in that sense. If the issue of size is being worked around here then ideally we'd have a different/simpler answer. If we continue with this as-is the description of a SEND should ensure devs use that when sending content from within NiFi to an external system and an upload only when sending external content to an external system. Because as written in teh docs/guide right now UPLOAD looks like a subcase of SEND which it is not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12505) System Diagnostics
[ https://issues.apache.org/jira/browse/NIFI-12505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reassigned NIFI-12505: -- Assignee: Rob Fellows > System Diagnostics > -- > > Key: NIFI-12505 > URL: https://issues.apache.org/jira/browse/NIFI-12505 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12481) UI error when listing registry clients and not authorized
[
https://issues.apache.org/jira/browse/NIFI-12481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rob Fellows updated NIFI-12481:
---
Fix Version/s: 1.25.0
> UI error when listing registry clients and not authorized
> -
>
> Key: NIFI-12481
> URL: https://issues.apache.org/jira/browse/NIFI-12481
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Bryan Bende
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 1.25.0, 2.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the authorization for registry clients is based on READ to
> /controller (this is a separate issue that should be addressed).
> Steps:
> * Run a secure instance locally
> * Use initial admin to create a registry client
> * Remove initial admin from controller policies
> * Create a new PG and choose Import from Registry
> * Notice nothing happens
> UI Error in dev tools:
> {code:java}
> nf-canvas-all.js?2.0.0-SNAPSHOT:47 Uncaught TypeError: Cannot read properties
> of undefined (reading 'name')
> at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3678)
> at Function.each (jquery.min.js:2:3003)
> at b.each (jquery.each.js:1:96)
> at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3610)
> at c (jquery.min.js:2:28447)
> at Object.fireWith [as resolveWith] (jquery.min.js:2:29192)
> at l (jquery.min.js:2:80176)
> at XMLHttpRequest. (jquery.min.js:2:82630) {code}
> The issue is that the listing of registry clients will optionally fill in the
> DTO in the entity based on the user's permissions for the entity, but the
> permissions are always based on /controller, so if they don't have
> /controller the DTO will be null.
> The UI should still be able to load a screen with an empty list of registry
> clients.
> cc [~mcgilman]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
pvillard31 commented on PR #8094: URL: https://github.com/apache/nifi/pull/8094#issuecomment-1866718524 This PR is following @markap14 's recommendation in this email thread: https://lists.apache.org/thread/hwt87hz4679vbmtv9yg78dw38jrwc861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12481) UI error when listing registry clients and not authorized
[
https://issues.apache.org/jira/browse/NIFI-12481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799530#comment-17799530
]
ASF subversion and git services commented on NIFI-12481:
Commit e8e547a00c2e000be345434ad90b855cf0e330d9 in nifi's branch
refs/heads/support/nifi-1.x from Matt Gilman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e8e547a00c ]
NIFI-12481: Filtering out unauthorized registry clients to avoid unhandled
error (#8147)
* NIFI-12481:
- Filtering out unauthorized registry clients to avoid unhandled error.
* NIFI-12481:
- Using es5 syntax.
This closes #8147
> UI error when listing registry clients and not authorized
> -
>
> Key: NIFI-12481
> URL: https://issues.apache.org/jira/browse/NIFI-12481
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Bryan Bende
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 2.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the authorization for registry clients is based on READ to
> /controller (this is a separate issue that should be addressed).
> Steps:
> * Run a secure instance locally
> * Use initial admin to create a registry client
> * Remove initial admin from controller policies
> * Create a new PG and choose Import from Registry
> * Notice nothing happens
> UI Error in dev tools:
> {code:java}
> nf-canvas-all.js?2.0.0-SNAPSHOT:47 Uncaught TypeError: Cannot read properties
> of undefined (reading 'name')
> at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3678)
> at Function.each (jquery.min.js:2:3003)
> at b.each (jquery.each.js:1:96)
> at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3610)
> at c (jquery.min.js:2:28447)
> at Object.fireWith [as resolveWith] (jquery.min.js:2:29192)
> at l (jquery.min.js:2:80176)
> at XMLHttpRequest. (jquery.min.js:2:82630) {code}
> The issue is that the listing of registry clients will optionally fill in the
> DTO in the entity based on the user's permissions for the entity, but the
> permissions are always based on /controller, so if they don't have
> /controller the DTO will be null.
> The UI should still be able to load a screen with an empty list of registry
> clients.
> cc [~mcgilman]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12420: Add Sawmill transformation processors [nifi]
joewitt commented on PR #8071: URL: https://github.com/apache/nifi/pull/8071#issuecomment-1866715722 I'd avoid adding to default build for now. I also think the dependencies need further review from a L point of view. The L is updated but seems pretty light compared to the deps involved here. Are we sure we checked? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
joewitt commented on PR #8094: URL: https://github.com/apache/nifi/pull/8094#issuecomment-1866711876 Similar to Matt's comment why does a SEND event not cover this case sufficiently? In this case it is that NiFi is effectively being used to take a given external reference and send that data to another system all without having stored locally (within nifi) the bytes. Never the less NiFi is the system that sends the data it seems and that is the purpose of the SEND event. A send without having had a CREATE/RECEIVE is fair game now given this paradigm... that is ok. I think we should avoid adding an event type unless the need/case is really strong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12536) ParseDocument incorrectly converts byte array to String, result in text like b'...' instead of just ...
[
https://issues.apache.org/jira/browse/NIFI-12536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-12536:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> ParseDocument incorrectly converts byte array to String, result in text like
> b'...' instead of just ...
> ---
>
> Key: NIFI-12536
> URL: https://issues.apache.org/jira/browse/NIFI-12536
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Trivial
> Fix For: 2.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Documents that are produced from ParseDocument use
> {{{}str(flowfile.getContentsAsBytes(){}}}) when it should use
> {{{}flowfile.getContentsAsBytes().decode('utf-8'){}}}.
> This results in text such as {{One Two Three}} to be produces as {{b'One Two
> Three'}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12536) ParseDocument incorrectly converts byte array to String, result in text like b'...' instead of just ...
[
https://issues.apache.org/jira/browse/NIFI-12536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799523#comment-17799523
]
ASF subversion and git services commented on NIFI-12536:
Commit 28976186351fca90178a3c6e4c125568a270cba2 in nifi's branch
refs/heads/main from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2897618635 ]
NIFI-12536: This closes #8178. Used proper method for converting byte array to
String
Signed-off-by: Joseph Witt
> ParseDocument incorrectly converts byte array to String, result in text like
> b'...' instead of just ...
> ---
>
> Key: NIFI-12536
> URL: https://issues.apache.org/jira/browse/NIFI-12536
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Trivial
> Fix For: 2.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Documents that are produced from ParseDocument use
> {{{}str(flowfile.getContentsAsBytes(){}}}) when it should use
> {{{}flowfile.getContentsAsBytes().decode('utf-8'){}}}.
> This results in text such as {{One Two Three}} to be produces as {{b'One Two
> Three'}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12536: Used proper method for converting byte array to String [nifi]
asfgit closed pull request #8178: NIFI-12536: Used proper method for converting byte array to String URL: https://github.com/apache/nifi/pull/8178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799515#comment-17799515
]
Alex Ethier commented on NIFI-12535:
Thanks [~dstiegli1]! I updated the description.
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document Table 14 is incorrectly named ??PadLeft Examples?? instead of
> ??PadRight Examples?? and the last example in that table incorrectly says
> padLeft when it should be padRight.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Ethier updated NIFI-12535:
---
Description: On the NiFi docs:
[!https://nifi.apache.org/assets/images/nifi16.ico!Apache NiFi
Documentation|https://nifi.apache.org/project-documentation.html] in the
{{Expression Language Guide}} section in the {{PadRight}} sub section of the
document Table 14 is incorrectly named ??PadLeft Examples?? instead of
??PadRight Examples?? and the last example in that table incorrectly says
padLeft when it should be padRight. (was: On the NiFi docs:
[!https://nifi.apache.org/assets/images/nifi16.ico!Apache NiFi
Documentation|https://nifi.apache.org/project-documentation.html] in the
{{Expression Language Guide}} section in the {{PadRight}} sub section of the
document the {{14. PadRight}} table incorrectly uses the PadLeft examples when
it should be using PadRight examples.)
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document Table 14 is incorrectly named ??PadLeft Examples?? instead of
> ??PadRight Examples?? and the last example in that table incorrectly says
> padLeft when it should be padRight.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) * Counters (NIFI-12415) * Bulletin Board * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Flow Analysis Rules * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * Prevent navigate to Service when configuration form is dirty * Introduce header in new pages to unify with canvas and offer better navigation. * Prompt user to save Parameter Context when Edit form is dirty [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12504) * Counters (NIFI-12415) * Bulletin Board * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Flow Analysis Rules * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * Prevent navigate to Service when configuration form is dirty * Introduce header in new pages to unify with canvas and offer better navigation. * Prompt user to save Parameter Context when Edit form is dirty [1] [https://github.com/apache/nifi/pull/8053] > Remaining items to migrate UI to currently supported/active framework >
[jira] [Created] (NIFI-12537) Update Summary screen to be cluster-aware
Rob Fellows created NIFI-12537: -- Summary: Update Summary screen to be cluster-aware Key: NIFI-12537 URL: https://issues.apache.org/jira/browse/NIFI-12537 Project: Apache NiFi Issue Type: Sub-task Reporter: Rob Fellows Assignee: Rob Fellows Update the summary screen to support clustered nifi. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12504) Remaining Summary Pages (tabs)
[ https://issues.apache.org/jira/browse/NIFI-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12504: --- Description: The initial effort was getting quite large, so this story was meant to capture the remaining work: * input ports * output ports * remote process groups * process groups * connections * -support for cluster-specific ui elements- NIFI-12537 was: The initial effort was getting quite large, so this story was meant to capture the remaining work: * input ports * output ports * remote process groups * process groups * connections * support for cluster-specific ui elements > Remaining Summary Pages (tabs) > -- > > Key: NIFI-12504 > URL: https://issues.apache.org/jira/browse/NIFI-12504 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > The initial effort was getting quite large, so this story was meant to > capture the remaining work: > * input ports > * output ports > * remote process groups > * process groups > * connections > * -support for cluster-specific ui elements- NIFI-12537 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12481) UI error when listing registry clients and not authorized
[
https://issues.apache.org/jira/browse/NIFI-12481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rob Fellows updated NIFI-12481:
---
Fix Version/s: 2.0.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> UI error when listing registry clients and not authorized
> -
>
> Key: NIFI-12481
> URL: https://issues.apache.org/jira/browse/NIFI-12481
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Bryan Bende
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 2.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the authorization for registry clients is based on READ to
> /controller (this is a separate issue that should be addressed).
> Steps:
> * Run a secure instance locally
> * Use initial admin to create a registry client
> * Remove initial admin from controller policies
> * Create a new PG and choose Import from Registry
> * Notice nothing happens
> UI Error in dev tools:
> {code:java}
> nf-canvas-all.js?2.0.0-SNAPSHOT:47 Uncaught TypeError: Cannot read properties
> of undefined (reading 'name')
> at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3678)
> at Function.each (jquery.min.js:2:3003)
> at b.each (jquery.each.js:1:96)
> at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3610)
> at c (jquery.min.js:2:28447)
> at Object.fireWith [as resolveWith] (jquery.min.js:2:29192)
> at l (jquery.min.js:2:80176)
> at XMLHttpRequest. (jquery.min.js:2:82630) {code}
> The issue is that the listing of registry clients will optionally fill in the
> DTO in the entity based on the user's permissions for the entity, but the
> permissions are always based on /controller, so if they don't have
> /controller the DTO will be null.
> The UI should still be able to load a screen with an empty list of registry
> clients.
> cc [~mcgilman]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12481) UI error when listing registry clients and not authorized
[
https://issues.apache.org/jira/browse/NIFI-12481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799494#comment-17799494
]
ASF subversion and git services commented on NIFI-12481:
Commit 1f54d5d1fc6a2c8c956b3426f6d5d12d2c547966 in nifi's branch
refs/heads/main from Matt Gilman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1f54d5d1fc ]
NIFI-12481: Filtering out unauthorized registry clients to avoid unhandled
error (#8147)
* NIFI-12481:
- Filtering out unauthorized registry clients to avoid unhandled error.
* NIFI-12481:
- Using es5 syntax.
This closes #8147
> UI error when listing registry clients and not authorized
> -
>
> Key: NIFI-12481
> URL: https://issues.apache.org/jira/browse/NIFI-12481
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Bryan Bende
>Assignee: Matt Gilman
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the authorization for registry clients is based on READ to
> /controller (this is a separate issue that should be addressed).
> Steps:
> * Run a secure instance locally
> * Use initial admin to create a registry client
> * Remove initial admin from controller policies
> * Create a new PG and choose Import from Registry
> * Notice nothing happens
> UI Error in dev tools:
> {code:java}
> nf-canvas-all.js?2.0.0-SNAPSHOT:47 Uncaught TypeError: Cannot read properties
> of undefined (reading 'name')
> at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3678)
> at Function.each (jquery.min.js:2:3003)
> at b.each (jquery.each.js:1:96)
> at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3610)
> at c (jquery.min.js:2:28447)
> at Object.fireWith [as resolveWith] (jquery.min.js:2:29192)
> at l (jquery.min.js:2:80176)
> at XMLHttpRequest. (jquery.min.js:2:82630) {code}
> The issue is that the listing of registry clients will optionally fill in the
> DTO in the entity based on the user's permissions for the entity, but the
> permissions are always based on /controller, so if they don't have
> /controller the DTO will be null.
> The UI should still be able to load a screen with an empty list of registry
> clients.
> cc [~mcgilman]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12481: Filtering out unauthorized registry clients to avoid unhandled error [nifi]
rfellows merged PR #8147: URL: https://github.com/apache/nifi/pull/8147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799480#comment-17799480
]
Daniel Stieglitz edited comment on NIFI-12535 at 12/21/23 4:32 PM:
---
[~aethier] Thank you for catching that error. Can I suggest slightly different
wording for the description which I feel better captures the issue?
On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
{{Expression Language Guide}} section in the {{PadRight}} sub section of the
document Table 14 is incorrectly named ??PadLeft Examples?? instead of PadRight
Examples and the last example in that table incorrectly says padLeft when it
should be padRight.
was (Author: JIRAUSER294662):
[~aethier] Thank you for catching that error. Can I suggest slightly different
wording for the description which I feel better captures the issue?
On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
{{Expression Language Guide}} section in the {{PadRight}} sub section of the
document Table 14 is incorrectly named ??PadLeft Examples?? and the last
example in that table incorrectly says padLeft when it should be padRight.
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document the {{14. PadRight}} table incorrectly uses the PadLeft examples
> when it should be using PadRight examples.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799480#comment-17799480
]
Daniel Stieglitz edited comment on NIFI-12535 at 12/21/23 4:32 PM:
---
[~aethier] Thank you for catching that error. Can I suggest slightly different
wording for the description which I feel better captures the issue?
On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
{{Expression Language Guide}} section in the {{PadRight}} sub section of the
document Table 14 is incorrectly named ??PadLeft Examples?? instead of
??PadRight Examples?? and the last example in that table incorrectly says
padLeft when it should be padRight.
was (Author: JIRAUSER294662):
[~aethier] Thank you for catching that error. Can I suggest slightly different
wording for the description which I feel better captures the issue?
On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
{{Expression Language Guide}} section in the {{PadRight}} sub section of the
document Table 14 is incorrectly named ??PadLeft Examples?? instead of PadRight
Examples and the last example in that table incorrectly says padLeft when it
should be padRight.
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document the {{14. PadRight}} table incorrectly uses the PadLeft examples
> when it should be using PadRight examples.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12485) Lineage Graph
[ https://issues.apache.org/jira/browse/NIFI-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799484#comment-17799484 ] ASF subversion and git services commented on NIFI-12485: Commit e6d09c3b3d5174c5877480728901ece2849d3f4b in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e6d09c3b3d ] NIFI-12485: Lineage Graph (#8173) * NIFI-12485: - Lineage. * NIFI-12485: - Adding context menu to lineage graph. - Refactoring canvas context menu to promote reuse. * NIFI-12485: - Lineage timeline slider. * NIFI-12485: - Addressing review feedback. * NIFI-12485: - Addressing review feedback. This closes #8173 > Lineage Graph > - > > Key: NIFI-12485 > URL: https://issues.apache.org/jira/browse/NIFI-12485 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Implement the lineage graph that is opened from a Provenance event. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12485) Lineage Graph
[ https://issues.apache.org/jira/browse/NIFI-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12485: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Lineage Graph > - > > Key: NIFI-12485 > URL: https://issues.apache.org/jira/browse/NIFI-12485 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Implement the lineage graph that is opened from a Provenance event. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12485: Lineage Graph [nifi]
rfellows merged PR #8173: URL: https://github.com/apache/nifi/pull/8173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12528: Fixed bug that resulted in StackOverflowError when deleti… [nifi]
markap14 opened a new pull request, #8180: URL: https://github.com/apache/nifi/pull/8180 …ng loop containing only funnels # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12531 Parameter references are removed after property migration [nifi]
krisztina-zsihovszki commented on code in PR #8176: URL: https://github.com/apache/nifi/pull/8176#discussion_r1434258904 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java: ## @@ -2110,7 +2110,7 @@ private void migrateProperties(final Map originalPropertyValues, final List servicesCreated = propertyConfig.getCreatedServices(); servicesCreated.forEach(serviceFactory::create); -overwriteProperties(propertyConfig.getProperties()); +overwriteProperties(propertyConfig.getRawProperties()); Review Comment: You are right, I changed those as well, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12535) Error in expression language guide page
[
https://issues.apache.org/jira/browse/NIFI-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799480#comment-17799480
]
Daniel Stieglitz commented on NIFI-12535:
-
[~aethier] Thank you for catching that error. Can I suggest slightly different
wording for the description which I feel better captures the issue?
On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
{{Expression Language Guide}} section in the {{PadRight}} sub section of the
document Table 14 is incorrectly named ??PadLeft Examples?? and the last
example in that table incorrectly says padLeft when it should be padRight.
> Error in expression language guide page
> ---
>
> Key: NIFI-12535
> URL: https://issues.apache.org/jira/browse/NIFI-12535
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation Website
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Minor
>
> On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
> NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
> {{Expression Language Guide}} section in the {{PadRight}} sub section of the
> document the {{14. PadRight}} table incorrectly uses the PadLeft examples
> when it should be using PadRight examples.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12532: Ensure that when CommunicateAction completes (exceptional… [nifi]
markap14 opened a new pull request, #8179: URL: https://github.com/apache/nifi/pull/8179 …ly or otherwise) that it gets removed from the list of all CommunicationActions # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12536) ParseDocument incorrectly converts byte array to String, result in text like b'...' instead of just ...
[
https://issues.apache.org/jira/browse/NIFI-12536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-12536:
--
Status: Patch Available (was: Open)
> ParseDocument incorrectly converts byte array to String, result in text like
> b'...' instead of just ...
> ---
>
> Key: NIFI-12536
> URL: https://issues.apache.org/jira/browse/NIFI-12536
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Trivial
> Fix For: 2.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Documents that are produced from ParseDocument use
> {{{}str(flowfile.getContentsAsBytes(){}}}) when it should use
> {{{}flowfile.getContentsAsBytes().decode('utf-8'){}}}.
> This results in text such as {{One Two Three}} to be produces as {{b'One Two
> Three'}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12536: Used proper method for converting byte array to String [nifi]
markap14 opened a new pull request, #8178: URL: https://github.com/apache/nifi/pull/8178 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12536) ParseDocument incorrectly converts byte array to String, result in text like b'...' instead of just ...
Mark Payne created NIFI-12536:
-
Summary: ParseDocument incorrectly converts byte array to String,
result in text like b'...' instead of just ...
Key: NIFI-12536
URL: https://issues.apache.org/jira/browse/NIFI-12536
Project: Apache NiFi
Issue Type: Bug
Components: Extensions
Affects Versions: 2.0.0-M1
Reporter: Mark Payne
Assignee: Mark Payne
Fix For: 2.0.0
Documents that are produced from ParseDocument use
{{{}str(flowfile.getContentsAsBytes(){}}}) when it should use
{{{}flowfile.getContentsAsBytes().decode('utf-8'){}}}.
This results in text such as {{One Two Three}} to be produces as {{b'One Two
Three'}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12535) Error in expression language guide page
Alex Ethier created NIFI-12535:
--
Summary: Error in expression language guide page
Key: NIFI-12535
URL: https://issues.apache.org/jira/browse/NIFI-12535
Project: Apache NiFi
Issue Type: Bug
Components: Documentation Website
Affects Versions: 1.24.0, 2.0.0-M1
Reporter: Alex Ethier
Assignee: Alex Ethier
On the NiFi docs: [!https://nifi.apache.org/assets/images/nifi16.ico!Apache
NiFi Documentation|https://nifi.apache.org/project-documentation.html] in the
{{Expression Language Guide}} section in the {{PadRight}} sub section of the
document the {{14. PadRight}} table incorrectly uses the PadLeft examples when
it should be using PadRight examples.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] MINIFICPP-2273 Update minifi documentation [nifi-site]
martinzink commented on PR #79: URL: https://github.com/apache/nifi-site/pull/79#issuecomment-1866466115 Thanks for quick and thorough reviews and merge @exceptionfactory @szaszm I will keep an eye on the redesign and do any further improvements based on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12533 : allow usage of NIFI_CLUSTER_LOAD_BALANCE_HOST [nifi]
djeanprost opened a new pull request, #8177: URL: https://github.com/apache/nifi/pull/8177 # Summary [NIFI-12533](https://issues.apache.org/jira/browse/NIFI-12533) : No environment variable is available to define `nifi.cluster.load.balance.host` # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Tested on my NIFI instance and checked `nifi.cluster.load.balance.host` is updated ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-2273) Update minifi cpp docs on nifi site
[ https://issues.apache.org/jira/browse/MINIFICPP-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved MINIFICPP-2273. - Resolution: Fixed > Update minifi cpp docs on nifi site > --- > > Key: MINIFICPP-2273 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2273 > Project: Apache NiFi MiNiFi C++ > Issue Type: Documentation >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12534) Prepare New Website Design for Production
David Handermann created NIFI-12534: --- Summary: Prepare New Website Design for Production Key: NIFI-12534 URL: https://issues.apache.org/jira/browse/NIFI-12534 Project: Apache NiFi Issue Type: Improvement Components: Documentation Website Reporter: David Handermann Assignee: James Elliott Following completion of initial project website redesign and deployment to staging, the following items should be reviewed and addressed to prepare the new design for deployment to production: # Adjust navigation bar behavior for small screens # Correct Developer Guide page visibility on small screens # Add deep-linking for each section of the Download page and remove separate downloads # Incorporate updated documentation for MiNiFi Java and C++ components # Review Apache project guidelines for compliance with required links # Add rewrite rules for popular pages, including the Security Reporting page, to maintain published links This issue can cover a number of these items, and separate related issues can be created and tracked as needed for individual tasks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2273 Update minifi documentation [nifi-site]
exceptionfactory closed pull request #79: MINIFICPP-2273 Update minifi documentation URL: https://github.com/apache/nifi-site/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12533) No environment variable is available to define nifi.cluster.load.balance.host
Dominique Jean-Prost created NIFI-12533:
---
Summary: No environment variable is available to define
nifi.cluster.load.balance.host
Key: NIFI-12533
URL: https://issues.apache.org/jira/browse/NIFI-12533
Project: Apache NiFi
Issue Type: Improvement
Reporter: Dominique Jean-Prost
There should be a env variable something like
{{NIFI_CLUSTER_LOAD_BALANCE_HOST}} to populate
{{nifi.cluster.load.balance.host}}.
Currently there is no one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12530: Support CREATE TABLE in Oracle database adapters [nifi]
mattyb149 commented on PR #8175: URL: https://github.com/apache/nifi/pull/8175#issuecomment-1866377704 I didn't add the unit test to the older OracleDatabaseAdapter because it was basically copy/paste, but since the new code is too, I will add that test to it. The only reason for using the List instead of the StringBuilder was for the join(), I felt it awkward to have to use a `for` loop and add a comma if `i != 0`. If there are performance-related concerns I can change that as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12504] Remaining views on Summary page [nifi]
rfellows commented on code in PR #8174:
URL: https://github.com/apache/nifi/pull/8174#discussion_r1434145848
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/common/port-status-table/port-status-table.component.ts:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, EventEmitter, Input, Output } from '@angular/core';
+import { CommonModule } from '@angular/common';
+import { MatSortModule, Sort, SortDirection } from '@angular/material/sort';
+import { MultiSort } from '../index';
+import { MatTableDataSource, MatTableModule } from '@angular/material/table';
+import { PortStatusSnapshot, PortStatusSnapshotEntity } from
'../../../state/summary-listing';
+import { SummaryTableFilterModule } from
'../summary-table-filter/summary-table-filter.module';
+import {
+SummaryTableFilterArgs,
+SummaryTableFilterColumn
+} from '../summary-table-filter/summary-table-filter.component';
+import { ComponentType } from '../../../../../state/shared';
+import { RouterLink } from '@angular/router';
+import { NiFiCommon } from '../../../../../service/nifi-common.service';
+
+export type SupportedColumns = 'name' | 'runStatus' | 'in' | 'out';
+
+@Component({
+selector: 'port-status-table',
+standalone: true,
+imports: [CommonModule, SummaryTableFilterModule, MatSortModule,
MatTableModule, RouterLink],
+templateUrl: './port-status-table.component.html',
+styleUrls: ['./port-status-table.component.scss',
'../../../../../../assets/styles/listing-table.scss']
+})
+export class PortStatusTable {
+private _initialSortColumn: SupportedColumns = 'name';
+private _initialSortDirection: SortDirection = 'asc';
+private _portType!: 'input' | 'output';
+
+filterableColumns: SummaryTableFilterColumn[] = [{ key: 'name', label:
'name' }];
+
+totalCount: number = 0;
+filteredCount: number = 0;
+
+multiSort: MultiSort = {
+active: this._initialSortColumn,
+direction: this._initialSortDirection,
+sortValueIndex: 0,
+totalValues: 2
+};
+
+displayedColumns: string[] = [];
+
+dataSource: MatTableDataSource = new
MatTableDataSource();
+
+constructor(private nifiCommon: NiFiCommon) {}
+
+@Input() set portType(type: 'input' | 'output') {
+if (type === 'input') {
+this.displayedColumns = ['moreDetails', 'name', 'runStatus', 'in',
'actions'];
+} else {
+this.displayedColumns = ['moreDetails', 'name', 'runStatus',
'out', 'actions'];
+}
+this._portType = type;
+}
+
+get portType() {
+return this._portType;
+}
+
+@Input() selectedPortId!: string;
+
+@Input() set initialSortColumn(initialSortColumn: SupportedColumns) {
+this._initialSortColumn = initialSortColumn;
+this.multiSort = { ...this.multiSort, active: initialSortColumn };
+}
+
+get initialSortColumn() {
+return this._initialSortColumn;
+}
+
+@Input() set initialSortDirection(initialSortDirection: SortDirection) {
+this._initialSortDirection = initialSortDirection;
+this.multiSort = { ...this.multiSort, direction: initialSortDirection
};
+}
+
+get initialSortDirection() {
+return this._initialSortDirection;
+}
+
+@Input() set ports(ports: PortStatusSnapshotEntity[]) {
+if (ports) {
+this.dataSource.data = this.sortEntities(ports, this.multiSort);
+this.dataSource.filterPredicate = (data: PortStatusSnapshotEntity,
filter: string) => {
+const filterArray: string[] = filter.split('|');
Review Comment:
Good catch. I'll come up with a solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-12532) Possible memory leak in ConnectionLoadBalanceServer
Stijn Caerts created NIFI-12532:
---
Summary: Possible memory leak in ConnectionLoadBalanceServer
Key: NIFI-12532
URL: https://issues.apache.org/jira/browse/NIFI-12532
Project: Apache NiFi
Issue Type: Bug
Reporter: Stijn Caerts
The ConnectionLoadBalanceServer possibly contains a memory leak.
When analyzing a heap dump of a NiFi node in our clustered setup with version
1.16.3, a large part of the used memory was related to the
{{ConnectionLoadBalanceServer}}.
It had a retained size of 1,770,787,761 B (25.1%), with 106,710
{{CommunicationAction}} objects taking up most of that size 1,770,787,608 B
(25.1%).
I checked the code of the {{ConnectionLoadBalanceServer}} to try to understand
why it uses this much memory. This is when I noticed that
{{CommunicationAction}} objects are only removed when the
{{ConnectionLoadBalanceServer}} is stopped, creating a possible memory leak.
Although we're not running the most recent version of NiFi, this is still
present in the current version of the code.
https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server/ConnectionLoadBalanceServer.java#L110
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12485: Lineage Graph [nifi]
rfellows commented on code in PR #8173:
URL: https://github.com/apache/nifi/pull/8173#discussion_r1434124896
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html:
##
@@ -18,7 +18,9 @@
-Displaying {{ filteredCount }} of {{
totalCount }}
+
+Displaying {{ filteredCount }} of {{ totalCount }}
Review Comment:
This is still not very intuitive IMO. Maybe something like
"Filter matched {{filterCount}} of {{totalCount}}"
Since we still aren't displaying all of the matches if they span more than 1
page.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/lineage/lineage.component.ts:
##
@@ -46,11 +46,13 @@ export class LineageComponent implements OnInit {
this.addLineage(lineage.results.nodes, lineage.results.links);
}
}
+
@Input() eventId: string | null = null;
+
@Input() set eventTimestampThreshold(eventTimestampThreshold: number) {
if (this.previousEventTimestampThreshold >= 0) {
-let nodes: any = this.lineageContainerElement.selectAll('g.node');
-let links: any =
this.lineageContainerElement.selectAll('path.link');
+let nodes: any =
this.lineageContainerElement.selectAll('g.node.rendered');
+let links: any =
this.lineageContainerElement.selectAll('path.link.rendered');
Review Comment:
when showing/hiding these items we should also turn on/of pointer-events.
Otherwise, you can still get to the context menus for the hidden items if you
mouse over them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12504] Remaining views on Summary page [nifi]
mcgilman commented on code in PR #8174:
URL: https://github.com/apache/nifi/pull/8174#discussion_r1434084192
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html:
##
@@ -0,0 +1,205 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+Name
+
+
+{{ formatName(item) }}
+
+
+
+
+
+
+
+Queue
+(Size)
+5 min
+
+
+
+{{ formatQueue(item) }}
+
+
+
+
+
+
Review Comment:
This title is not accurate
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/common/port-status-table/port-status-table.component.ts:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, EventEmitter, Input, Output } from '@angular/core';
+import { CommonModule } from '@angular/common';
+import { MatSortModule, Sort, SortDirection } from '@angular/material/sort';
+import { MultiSort } from '../index';
+import { MatTableDataSource, MatTableModule } from '@angular/material/table';
+import { PortStatusSnapshot, PortStatusSnapshotEntity } from
'../../../state/summary-listing';
+import { SummaryTableFilterModule } from
'../summary-table-filter/summary-table-filter.module';
+import {
+SummaryTableFilterArgs,
+SummaryTableFilterColumn
+} from '../summary-table-filter/summary-table-filter.component';
+import { ComponentType } from '../../../../../state/shared';
+import { RouterLink } from '@angular/router';
+import { NiFiCommon } from '../../../../../service/nifi-common.service';
+
+export type SupportedColumns = 'name' | 'runStatus' | 'in' | 'out';
+
+@Component({
+selector: 'port-status-table',
+standalone: true,
+imports: [CommonModule, SummaryTableFilterModule, MatSortModule,
MatTableModule, RouterLink],
+templateUrl: './port-status-table.component.html',
+styleUrls: ['./port-status-table.component.scss',
'../../../../../../assets/styles/listing-table.scss']
+})
+export class PortStatusTable {
+private _initialSortColumn: SupportedColumns = 'name';
+private _initialSortDirection: SortDirection = 'asc';
+private _portType!: 'input' | 'output';
+
+filterableColumns: SummaryTableFilterColumn[] = [{ key: 'name', label:
'name' }];
+
+totalCount: number = 0;
+filteredCount: number = 0;
+
+multiSort: MultiSort = {
+active: this._initialSortColumn,
+direction: this._initialSortDirection,
+sortValueIndex: 0,
+totalValues: 2
+};
+
+displayedColumns: string[] = [];
+
+dataSource: MatTableDataSource = new
MatTableDataSource();
+
+constructor(private nifiCommon: NiFiCommon) {}
+
+@Input() set portType(type: 'input' | 'output') {
+if (type === 'input') {
+this.displayedColumns = ['moreDetails', 'name', 'runStatus', 'in',
'actions'];
+} else {
+this.displayedColumns = ['moreDetails', 'name', 'runStatus',
'out', 'actions'];
+}
+this._portType = type;
+}
+
+get portType() {
+return this._portType;
+}
+
+@Input() selectedPortId!: string;
+
+@Input() set initialSortColumn(initialSortColumn: SupportedColumns) {
+this._initialSortColumn = initialSortColumn;
+this.multiSort = { ...this.multiSort, active: initialSortColumn };
+}
+
+get initialSortColumn() {
+return this._initialSortColumn;
+}
+
+@Input() set initialSortDirection(initialSortDirection:
[jira] [Updated] (NIFI-11389) Controller Services's link to referencing Controller Services components not always working
[ https://issues.apache.org/jira/browse/NIFI-11389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman updated NIFI-11389: - Labels: backport-needed (was: ) > Controller Services's link to referencing Controller Services components not > always working > --- > > Key: NIFI-11389 > URL: https://issues.apache.org/jira/browse/NIFI-11389 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M1, 1.20.0, 1.19.1 >Reporter: Nissim Shiman >Assignee: Nissim Shiman >Priority: Major > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Controller Services' Setting tab has a _Referencing Components_ section on > the right side. > There are hyperlinks to the Processors and/or Controller Services which > reference this controller service. These links do not always work when > referencing controller services. > To reproduce: > Create StandardRestrictedSSLContextService on top level nifi graph (i.e. > right click top level grid -> Configure -> Controller Services) > Create Process Group > Inside Process Group create DistributedMapCacheServer > and point _SSL Context Service_ to StandardRestrictedSSLContextService just > created > Go to StandardRestrictedSSLContextService's Setting's tab and verify > DistributedMapCacheServer appears in the _Referencing Components_ section. > Clicking on the link to DistributedMapCacheServer will not take us to that > controller service. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12531 Parameter references are removed after property migration [nifi]
turcsanyip commented on code in PR #8176: URL: https://github.com/apache/nifi/pull/8176#discussion_r1434029850 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java: ## @@ -2110,7 +2110,7 @@ private void migrateProperties(final Map originalPropertyValues, final List servicesCreated = propertyConfig.getCreatedServices(); servicesCreated.forEach(serviceFactory::create); -overwriteProperties(propertyConfig.getProperties()); +overwriteProperties(propertyConfig.getRawProperties()); Review Comment: Thanks for the fix @krisztina-zsihovszki! It looks good, however I don't know all the details around property migration. One note here: `StandardControllerServiceNode` and `AbstractReportingTaskNode` use the same `getProperties()` method so it needs to be fixed there too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12525) Add property migration for the removed Consumer Hostname property in ConsumeAzureEventHub
[ https://issues.apache.org/jira/browse/NIFI-12525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12525: -- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Add property migration for the removed Consumer Hostname property in > ConsumeAzureEventHub > - > > Key: NIFI-12525 > URL: https://issues.apache.org/jira/browse/NIFI-12525 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12525) Add property migration for the removed Consumer Hostname property in ConsumeAzureEventHub
[ https://issues.apache.org/jira/browse/NIFI-12525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799408#comment-17799408 ] ASF subversion and git services commented on NIFI-12525: Commit 02d563eefc0aaa23a15778a5cc15b5d549ed01c1 in nifi's branch refs/heads/main from Peter Turcsanyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=02d563eefc ] NIFI-12525: Added property migration for the removed Consumer Hostname property in ConsumeAzureEventHub Signed-off-by: Pierre Villard This closes #8171. > Add property migration for the removed Consumer Hostname property in > ConsumeAzureEventHub > - > > Key: NIFI-12525 > URL: https://issues.apache.org/jira/browse/NIFI-12525 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12525: Added property migration for the removed Consumer Hostnam… [nifi]
asfgit closed pull request #8171: NIFI-12525: Added property migration for the removed Consumer Hostnam… URL: https://github.com/apache/nifi/pull/8171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12515) Remove deprecated Client Auth property from AMQP processors
[ https://issues.apache.org/jira/browse/NIFI-12515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799403#comment-17799403 ] ASF subversion and git services commented on NIFI-12515: Commit ca4ee2407cb01e23fba9ad5ae72151aa1fd8d10a in nifi's branch refs/heads/main from Peter Turcsanyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ca4ee2407c ] NIFI-12515 Removed deprecated Client Auth property from AMQP processors Signed-off-by: Pierre Villard This closes #8162. > Remove deprecated Client Auth property from AMQP processors > --- > > Key: NIFI-12515 > URL: https://issues.apache.org/jira/browse/NIFI-12515 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > PublishAMQP and ConsumeAMQP processors' Client Auth property is not used / > has no effect. It was marked as deprecated and can be removed in 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12515) Remove deprecated Client Auth property from AMQP processors
[ https://issues.apache.org/jira/browse/NIFI-12515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12515: -- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Remove deprecated Client Auth property from AMQP processors > --- > > Key: NIFI-12515 > URL: https://issues.apache.org/jira/browse/NIFI-12515 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > PublishAMQP and ConsumeAMQP processors' Client Auth property is not used / > has no effect. It was marked as deprecated and can be removed in 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12515 Removed deprecated Client Auth property from AMQP processors [nifi]
asfgit closed pull request #8162: NIFI-12515 Removed deprecated Client Auth property from AMQP processors URL: https://github.com/apache/nifi/pull/8162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12527) Remove deprecated Session Cache Size property from JMS processors
[ https://issues.apache.org/jira/browse/NIFI-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799401#comment-17799401 ] ASF subversion and git services commented on NIFI-12527: Commit 4727d591d115cdca1975d91348ae75faba56e75a in nifi's branch refs/heads/main from Peter Turcsanyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4727d591d1 ] NIFI-12527: Removed deprecated Session Cache Size property from JMS processors Signed-off-by: Pierre Villard This closes #8172. > Remove deprecated Session Cache Size property from JMS processors > - > > Key: NIFI-12527 > URL: https://issues.apache.org/jira/browse/NIFI-12527 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > PublishJMS and ConsumeJMS processors' Session Cache Size property is not used > / has no effect. It was marked as deprecated and can be removed in 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12527) Remove deprecated Session Cache Size property from JMS processors
[ https://issues.apache.org/jira/browse/NIFI-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12527: -- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Remove deprecated Session Cache Size property from JMS processors > - > > Key: NIFI-12527 > URL: https://issues.apache.org/jira/browse/NIFI-12527 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > PublishJMS and ConsumeJMS processors' Session Cache Size property is not used > / has no effect. It was marked as deprecated and can be removed in 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12527: Removed deprecated Session Cache Size property from JMS p… [nifi]
asfgit closed pull request #8172: NIFI-12527: Removed deprecated Session Cache Size property from JMS p… URL: https://github.com/apache/nifi/pull/8172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2273 Update minifi documentation [nifi-site]
martinzink commented on PR #79: URL: https://github.com/apache/nifi-site/pull/79#issuecomment-1866135336 > Thanks for the update @martinzink! I may have missed this earlier, but similar to the about pages, it seems better to keep one MiNiFi Download page, with separate sections for C++ and Java, similar to how it is now. This is the general pattern being considered now in the redesigned approach. Having fewer pages should be easier to maintain, and easier to navigate for someone looking to download sources or binaries. What do you think? The reason I split it into two because the topbar felt crammed with the new C++ and Java dropdowns so I removed the separate dropdown for Downloads, then I split it into two because it would be weird (for me at least) that the first download link from the C++ dropdown is actually for Java. But I understand where you are coming from. What do you think would be the best, reintroduce the Download dropdown from the topbar and remove the links from the C++/Java dropdowns, or leave the download links in the C++/Java dropdowns but they would lead to the single download link? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12531) Parameter references are removed after property migration
[
https://issues.apache.org/jira/browse/NIFI-12531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsihovszki Krisztina updated NIFI-12531:
Affects Version/s: 2.0.0-M1
2.0.0
Status: Patch Available (was: Open)
> Parameter references are removed after property migration
> -
>
> Key: NIFI-12531
> URL: https://issues.apache.org/jira/browse/NIFI-12531
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 2.0.0-M1, 2.0.0
>Reporter: Zsihovszki Krisztina
>Assignee: Zsihovszki Krisztina
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Parameter references disappear from the properties when a flow is imported to
> NiFi 2.0.
> The problem was observed for InvokeHTTP processor when e.g. we extract "Host
> URL" property to a parameter. The flow definition contains the parameter
> reference properly:
>
> {code:java}
> "HTTP URL": "#{Server URL}",{code}
>
> but the property value is resolved in the imported flow and the connection
> between the parameter ("Server URL") and the processor is lost.
> The issue did not occur for other processors like ConvertRecord and it occurs
> in NiFi 2.0 only.
> Based on my investigation the root cause seems to be related to the property
> migration.
> During the property migration the raw values("#\{Server URL}") are resolved
> to effective values (e.g. http://host:port).
> In StandardProcessorNode.migrateProperties() the properties are overwritten (
> overwriteProperties) if the propertyConfig is modified.
> At this step the effective properties are used while I belive the raw
> properties should have been used.
> Another observed minor issue:
> In InvokeHTTP processor, the "Connection Timeout" is renamed to the same name
> (that triggered the above mentioned issue since it looked as if the processor
> properties were modified, property overwrite was needed)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12531 Parameter references are removed after property migration [nifi]
krisztina-zsihovszki commented on PR #8176: URL: https://github.com/apache/nifi/pull/8176#issuecomment-1866117797 @markap14, please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12531 Parameter references are removed after property migration [nifi]
krisztina-zsihovszki opened a new pull request, #8176: URL: https://github.com/apache/nifi/pull/8176 # Summary [NIFI-12531](https://issues.apache.org/jira/browse/NIFI-12531) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12531) Parameter references are removed after property migration
Zsihovszki Krisztina created NIFI-12531:
---
Summary: Parameter references are removed after property migration
Key: NIFI-12531
URL: https://issues.apache.org/jira/browse/NIFI-12531
Project: Apache NiFi
Issue Type: Bug
Reporter: Zsihovszki Krisztina
Assignee: Zsihovszki Krisztina
Parameter references disappear from the properties when a flow is imported to
NiFi 2.0.
The problem was observed for InvokeHTTP processor when e.g. we extract "Host
URL" property to a parameter. The flow definition contains the parameter
reference properly:
{code:java}
"HTTP URL": "#{Server URL}",{code}
but the property value is resolved in the imported flow and the connection
between the parameter ("Server URL") and the processor is lost.
The issue did not occur for other processors like ConvertRecord and it occurs
in NiFi 2.0 only.
Based on my investigation the root cause seems to be related to the property
migration.
During the property migration the raw values("#\{Server URL}") are resolved to
effective values (e.g. http://host:port).
In StandardProcessorNode.migrateProperties() the properties are overwritten (
overwriteProperties) if the propertyConfig is modified.
At this step the effective properties are used while I belive the raw
properties should have been used.
Another observed minor issue:
In InvokeHTTP processor, the "Connection Timeout" is renamed to the same name
(that triggered the above mentioned issue since it looked as if the processor
properties were modified, property overwrite was needed)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12528) Funnels bug
[ https://issues.apache.org/jira/browse/NIFI-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giovanni updated NIFI-12528: Description: I've notice a bug in our working cluster of 4 nodes. When two funnels are connected, with no other connections as themselves, like in attached image, is not possible to delete them. After trying to modify one of their connections, the Node where the action is performed crashes, and will not turn on unless the entire cluster gets restarted. was: I've notice a bug in our working cluster of 4 nodes. When two funnels are connected, with no other connections as themselves, like in attached image, is not possible to delete them. After trying to modify one of their connections, the Node where the action is performed crashes, and will not turn on unless the entire cluster restarts. > Funnels bug > --- > > Key: NIFI-12528 > URL: https://issues.apache.org/jira/browse/NIFI-12528 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.23.2 > Environment: NiFi cluster >Reporter: Giovanni >Priority: Critical > Attachments: image001.png > > > I've notice a bug in our working cluster of 4 nodes. > When two funnels are connected, with no other connections as themselves, like > in attached image, is not possible to delete them. > After trying to modify one of their connections, the Node where the action is > performed crashes, and will not turn on unless the entire cluster gets > restarted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
