[jira] [Updated] (NIFI-12761) RPG refresh

2024-02-12 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-12761:
---
Status: Patch Available  (was: In Progress)

> RPG refresh
> ---
>
> Key: NIFI-12761
> URL: https://issues.apache.org/jira/browse/NIFI-12761
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12759) RPG GoTo

2024-02-12 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-12759:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> RPG GoTo
> 
>
> Key: NIFI-12759
> URL: https://issues.apache.org/jira/browse/NIFI-12759
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [NIFI-12754] - Flow Configuration History [nifi]

2024-02-12 Thread via GitHub


mcgilman commented on code in PR #8399:
URL: https://github.com/apache/nifi/pull/8399#discussion_r1486960570


##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/state/flow-configuration-history-listing/flow-configuration-history-listing.effects.ts:
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Injectable } from '@angular/core';
+import { Actions, concatLatestFrom, createEffect, ofType } from 
'@ngrx/effects';
+import { Store } from '@ngrx/store';
+import { NiFiState } from '../../../../state';
+import { ErrorHelper } from '../../../../service/error-helper.service';
+import { MatDialog } from '@angular/material/dialog';
+import * as HistoryActions from './flow-configuration-history-listing.actions';
+import { catchError, from, map, of, switchMap, take, tap } from 'rxjs';
+import { selectHistoryQuery, selectHistoryStatus } from 
'./flow-configuration-history-listing.selectors';
+import { FlowConfigurationHistoryService } from 
'../../service/flow-configuration-history.service';
+import { HistoryEntity, PurgeHistoryRequest } from './index';
+import { HttpErrorResponse } from '@angular/common/http';
+import { Router } from '@angular/router';
+import { ActionDetails } from 
'../../ui/flow-configuration-history-listing/action-details/action-details.component';
+import { PurgeHistory } from 
'../../ui/flow-configuration-history-listing/purge-history/purge-history.component';
+import { YesNoDialog } from 
'../../../../ui/common/yes-no-dialog/yes-no-dialog.component';
+import { isDefinedAndNotNull } from '../../../../state/shared';
+
+@Injectable()
+export class FlowConfigurationHistoryListingEffects {
+constructor(
+private actions$: Actions,
+private store: Store,
+private errorHelper: ErrorHelper,
+private dialog: MatDialog,
+private historyService: FlowConfigurationHistoryService,
+private router: Router
+) {}
+
+loadHistory$ = createEffect(() =>
+this.actions$.pipe(
+ofType(HistoryActions.loadHistory),
+map((action) => action.request),
+concatLatestFrom(() => this.store.select(selectHistoryStatus)),
+switchMap(([request, status]) =>
+from(this.historyService.getHistory(request)).pipe(
+map((response: HistoryEntity) =>
+HistoryActions.loadHistorySuccess({
+response: response
+})
+),
+catchError((errorResponse: HttpErrorResponse) =>
+of(this.errorHelper.handleLoadingError(status, 
errorResponse))
+)
+)
+)
+)
+);
+
+flowConfigurationHistorySnackbarError = createEffect(() =>
+this.actions$.pipe(
+ofType(HistoryActions.flowConfigurationHistorySnackbarError),
+map((action) => action.errorResponse),
+concatLatestFrom(() => this.store.select(selectHistoryStatus)),
+switchMap(([errorResponse, status]) => 
of(this.errorHelper.handleLoadingError(status, errorResponse)))

Review Comment:
   Was this intended to be `ErrorActions.snackbarError(...)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [NIFI-12754] - Flow Configuration History [nifi]

2024-02-12 Thread via GitHub


mcgilman commented on code in PR #8399:
URL: https://github.com/apache/nifi/pull/8399#discussion_r1486949253


##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/feature/flow-configuration-history.component.html:
##
@@ -0,0 +1,26 @@
+
+
+
+
+
+
+

Review Comment:
   The spacing between the header and the listing looks a little tight. I 
didn't compare it every other page but we may want to consider some `gap-y` 
here.



##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/state/flow-configuration-history-listing/flow-configuration-history-listing.effects.ts:
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Injectable } from '@angular/core';
+import { Actions, concatLatestFrom, createEffect, ofType } from 
'@ngrx/effects';
+import { Store } from '@ngrx/store';
+import { NiFiState } from '../../../../state';
+import { ErrorHelper } from '../../../../service/error-helper.service';
+import { MatDialog } from '@angular/material/dialog';
+import * as HistoryActions from './flow-configuration-history-listing.actions';
+import { catchError, from, map, of, switchMap, take, tap } from 'rxjs';
+import { selectHistoryQuery, selectHistoryStatus } from 
'./flow-configuration-history-listing.selectors';
+import { FlowConfigurationHistoryService } from 
'../../service/flow-configuration-history.service';
+import { HistoryEntity, PurgeHistoryRequest } from './index';
+import { HttpErrorResponse } from '@angular/common/http';
+import { Router } from '@angular/router';
+import { ActionDetails } from 
'../../ui/flow-configuration-history-listing/action-details/action-details.component';
+import { PurgeHistory } from 
'../../ui/flow-configuration-history-listing/purge-history/purge-history.component';
+import { YesNoDialog } from 
'../../../../ui/common/yes-no-dialog/yes-no-dialog.component';
+import { isDefinedAndNotNull } from '../../../../state/shared';
+
+@Injectable()
+export class FlowConfigurationHistoryListingEffects {
+constructor(
+private actions$: Actions,
+private store: Store,
+private errorHelper: ErrorHelper,
+private dialog: MatDialog,
+private historyService: FlowConfigurationHistoryService,
+private router: Router
+) {}
+
+loadHistory$ = createEffect(() =>
+this.actions$.pipe(
+ofType(HistoryActions.loadHistory),
+map((action) => action.request),
+concatLatestFrom(() => this.store.select(selectHistoryStatus)),
+switchMap(([request, status]) =>
+from(this.historyService.getHistory(request)).pipe(
+map((response: HistoryEntity) =>
+HistoryActions.loadHistorySuccess({
+response: response
+})
+),
+catchError((errorResponse: HttpErrorResponse) =>
+of(this.errorHelper.handleLoadingError(status, 
errorResponse))
+)
+)
+)
+)
+);
+
+flowConfigurationHistorySnackbarError = createEffect(() =>
+this.actions$.pipe(
+ofType(HistoryActions.flowConfigurationHistorySnackbarError),
+map((action) => action.errorResponse),
+concatLatestFrom(() => this.store.select(selectHistoryStatus)),
+switchMap(([errorResponse, status]) => 
of(this.errorHelper.handleLoadingError(status, errorResponse)))

Review Comment:
   Was this intended `ErrorActions.snackbarError(...)`?



##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/feature/flow-configuration-history-routing.module.ts:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The 

[jira] [Commented] (NIFI-12766) Fix Region handling in AssumeRoleCredentialsStrategy in AWSCredentialsProviderControllerService

2024-02-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816826#comment-17816826
 ] 

ASF subversion and git services commented on NIFI-12766:


Commit 9ba68edb5fc39fb63fb745f81fac1f2030f761e0 in nifi's branch 
refs/heads/main from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9ba68edb5f ]

NIFI-12766 Fixed Region handling for AWS Assume Role Credentials

This closes #8382

Signed-off-by: David Handermann 


> Fix Region handling in AssumeRoleCredentialsStrategy in 
> AWSCredentialsProviderControllerService
> ---
>
> Key: NIFI-12766
> URL: https://issues.apache.org/jira/browse/NIFI-12766
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1, 2.0.0-M2
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Either region or custom endpoint configuration (including the region) can be 
> set on {{AWSSecurityTokenServiceClientBuilder}}.
>  
> {code:java}
> 2024-02-09 17:44:16,084 ERROR [Timer-Driven Process Thread-2] 
> o.a.n.c.s.StandardControllerServiceNode 
> StandardControllerServiceNode[service=AWSCredentialsProviderService[id=1b0b4a21-e6fa-3e75-88b2-11e7583673a4],
>  name=AWSCredentialsProviderControllerService (STS+Endpoint), active=true] 
> Failed to invoke @OnEnabled method
> java.lang.IllegalStateException: Only one of Region or EndpointConfiguration 
> may be set.
>     at 
> com.amazonaws.client.builder.AwsClientBuilder.setRegion(AwsClientBuilder.java:450)
>     at 
> com.amazonaws.client.builder.AwsClientBuilder.configureMutableProperties(AwsClientBuilder.java:424)
>     at 
> com.amazonaws.client.builder.AwsSyncClientBuilder.build(AwsSyncClientBuilder.java:46)
>     at 
> org.apache.nifi.processors.aws.credentials.provider.factory.strategies.AssumeRoleCredentialsStrategy.getDerivedCredentialsProvider(AssumeRoleCredentialsStrategy.java:190)
>     at 
> org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderControllerService.createCredentialsProvider(AWSCredentialsProviderControllerService.java:382)
>     at 
> org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderControllerService.onConfigured(AWSCredentialsProviderControllerService.java:371)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12766) Fix Region handling in AssumeRoleCredentialsStrategy in AWSCredentialsProviderControllerService

2024-02-12 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-12766:

Fix Version/s: 2.0.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Fix Region handling in AssumeRoleCredentialsStrategy in 
> AWSCredentialsProviderControllerService
> ---
>
> Key: NIFI-12766
> URL: https://issues.apache.org/jira/browse/NIFI-12766
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1, 2.0.0-M2
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Either region or custom endpoint configuration (including the region) can be 
> set on {{AWSSecurityTokenServiceClientBuilder}}.
>  
> {code:java}
> 2024-02-09 17:44:16,084 ERROR [Timer-Driven Process Thread-2] 
> o.a.n.c.s.StandardControllerServiceNode 
> StandardControllerServiceNode[service=AWSCredentialsProviderService[id=1b0b4a21-e6fa-3e75-88b2-11e7583673a4],
>  name=AWSCredentialsProviderControllerService (STS+Endpoint), active=true] 
> Failed to invoke @OnEnabled method
> java.lang.IllegalStateException: Only one of Region or EndpointConfiguration 
> may be set.
>     at 
> com.amazonaws.client.builder.AwsClientBuilder.setRegion(AwsClientBuilder.java:450)
>     at 
> com.amazonaws.client.builder.AwsClientBuilder.configureMutableProperties(AwsClientBuilder.java:424)
>     at 
> com.amazonaws.client.builder.AwsSyncClientBuilder.build(AwsSyncClientBuilder.java:46)
>     at 
> org.apache.nifi.processors.aws.credentials.provider.factory.strategies.AssumeRoleCredentialsStrategy.getDerivedCredentialsProvider(AssumeRoleCredentialsStrategy.java:190)
>     at 
> org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderControllerService.createCredentialsProvider(AWSCredentialsProviderControllerService.java:382)
>     at 
> org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderControllerService.onConfigured(AWSCredentialsProviderControllerService.java:371)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-12766 Fixed Region handling in AssumeRoleCredentialsStrategy in … [nifi]

2024-02-12 Thread via GitHub


exceptionfactory closed pull request #8382: NIFI-12766 Fixed Region handling in 
AssumeRoleCredentialsStrategy in …
URL: https://github.com/apache/nifi/pull/8382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-12766) Fix Region handling in AssumeRoleCredentialsStrategy in AWSCredentialsProviderControllerService

2024-02-12 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-12766:

Affects Version/s: 2.0.0-M2
   2.0.0-M1

> Fix Region handling in AssumeRoleCredentialsStrategy in 
> AWSCredentialsProviderControllerService
> ---
>
> Key: NIFI-12766
> URL: https://issues.apache.org/jira/browse/NIFI-12766
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1, 2.0.0-M2
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Either region or custom endpoint configuration (including the region) can be 
> set on {{AWSSecurityTokenServiceClientBuilder}}.
>  
> {code:java}
> 2024-02-09 17:44:16,084 ERROR [Timer-Driven Process Thread-2] 
> o.a.n.c.s.StandardControllerServiceNode 
> StandardControllerServiceNode[service=AWSCredentialsProviderService[id=1b0b4a21-e6fa-3e75-88b2-11e7583673a4],
>  name=AWSCredentialsProviderControllerService (STS+Endpoint), active=true] 
> Failed to invoke @OnEnabled method
> java.lang.IllegalStateException: Only one of Region or EndpointConfiguration 
> may be set.
>     at 
> com.amazonaws.client.builder.AwsClientBuilder.setRegion(AwsClientBuilder.java:450)
>     at 
> com.amazonaws.client.builder.AwsClientBuilder.configureMutableProperties(AwsClientBuilder.java:424)
>     at 
> com.amazonaws.client.builder.AwsSyncClientBuilder.build(AwsSyncClientBuilder.java:46)
>     at 
> org.apache.nifi.processors.aws.credentials.provider.factory.strategies.AssumeRoleCredentialsStrategy.getDerivedCredentialsProvider(AssumeRoleCredentialsStrategy.java:190)
>     at 
> org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderControllerService.createCredentialsProvider(AWSCredentialsProviderControllerService.java:382)
>     at 
> org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderControllerService.onConfigured(AWSCredentialsProviderControllerService.java:371)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-12765 Remove Apache Ranger modules [nifi]

2024-02-12 Thread via GitHub


exceptionfactory commented on PR #8389:
URL: https://github.com/apache/nifi/pull/8389#issuecomment-1939816483

   Rebased


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12765: Ranger audit reporting work only with jetty 11.x version [nifi]

2024-02-12 Thread via GitHub


exceptionfactory commented on PR #8381:
URL: https://github.com/apache/nifi/pull/8381#issuecomment-1939815170

   Closing in favor of removal PR #8389 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12765: Ranger audit reporting work only with jetty 11.x version [nifi]

2024-02-12 Thread via GitHub


exceptionfactory closed pull request #8381: NIFI-12765: Ranger audit reporting 
work only with jetty 11.x version
URL: https://github.com/apache/nifi/pull/8381


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-12779) Update okio.version to 3.8.0

2024-02-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816822#comment-17816822
 ] 

ASF subversion and git services commented on NIFI-12779:


Commit d37543bf072de3bd610b100665c3d47c2f00a548 in nifi's branch 
refs/heads/support/nifi-1.x from mr1716
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d37543bf07 ]

NIFI-12779 Upgraded Okio from 3.7.0 to 3.8.0

This closes #8396

Signed-off-by: David Handermann 
(cherry picked from commit 6243d00158ee286643c83d4d78655a1881d96afd)


> Update okio.version to 3.8.0
> 
>
> Key: NIFI-12779
> URL: https://issues.apache.org/jira/browse/NIFI-12779
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mike R
>Assignee: Mike R
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Update okio.version to 3.8.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12779) Update okio.version to 3.8.0

2024-02-12 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-12779:

Affects Version/s: (was: 2.0.0-M2)

> Update okio.version to 3.8.0
> 
>
> Key: NIFI-12779
> URL: https://issues.apache.org/jira/browse/NIFI-12779
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mike R
>Assignee: Mike R
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Update okio.version to 3.8.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (NIFI-12779) Update okio.version to 3.8.0

2024-02-12 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-12779.
-
Fix Version/s: 2.0.0
   1.26.0
   Resolution: Fixed

> Update okio.version to 3.8.0
> 
>
> Key: NIFI-12779
> URL: https://issues.apache.org/jira/browse/NIFI-12779
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mike R
>Assignee: Mike R
>Priority: Minor
> Fix For: 2.0.0, 1.26.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Update okio.version to 3.8.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-12779) Update okio.version to 3.8.0

2024-02-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816820#comment-17816820
 ] 

ASF subversion and git services commented on NIFI-12779:


Commit 6243d00158ee286643c83d4d78655a1881d96afd in nifi's branch 
refs/heads/main from mr1716
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6243d00158 ]

NIFI-12779 Upgraded Okio from 3.7.0 to 3.8.0

This closes #8396

Signed-off-by: David Handermann 


> Update okio.version to 3.8.0
> 
>
> Key: NIFI-12779
> URL: https://issues.apache.org/jira/browse/NIFI-12779
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Mike R
>Assignee: Mike R
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Update okio.version to 3.8.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-12779 Update okio.version to 3.8.0 [nifi]

2024-02-12 Thread via GitHub


exceptionfactory closed pull request #8396: NIFI-12779 Update okio.version to 
3.8.0
URL: https://github.com/apache/nifi/pull/8396


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-12755) Upgrade Jetty to 12.0.6

2024-02-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816819#comment-17816819
 ] 

ASF subversion and git services commented on NIFI-12755:


Commit ecd6ed48a991274f52ce07d0c40529320f81eb27 in nifi's branch 
refs/heads/main from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ecd6ed48a9 ]

NIFI-12755 Upgraded Jetty from 12.0.5 to 12.0.6

- Refactored WebSocket Test Listener to avoid method visibility problem

This closes #8374

Co-authored-by: David Handermann 
Signed-off-by: David Handermann 


> Upgrade Jetty to 12.0.6
> ---
>
> Key: NIFI-12755
> URL: https://issues.apache.org/jira/browse/NIFI-12755
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Upgrade Jetty from 12.0.5 to 12.0.6



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12755) Upgrade Jetty to 12.0.6

2024-02-12 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-12755:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Upgrade Jetty to 12.0.6
> ---
>
> Key: NIFI-12755
> URL: https://issues.apache.org/jira/browse/NIFI-12755
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Upgrade Jetty from 12.0.5 to 12.0.6



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-12755 - Upgrade Jetty to 12.0.6 [nifi]

2024-02-12 Thread via GitHub


exceptionfactory closed pull request #8374: NIFI-12755 - Upgrade Jetty to 12.0.6
URL: https://github.com/apache/nifi/pull/8374


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-12759) RPG GoTo

2024-02-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816815#comment-17816815
 ] 

ASF subversion and git services commented on NIFI-12759:


Commit 25e24e037767f2392dfe9a9fc8fe9bb52f2f6c11 in nifi's branch 
refs/heads/main from Scott Aslan
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=25e24e0377 ]

[NIFI-12759] go to RPG (#8378)

This closes #8378 

> RPG GoTo
> 
>
> Key: NIFI-12759
> URL: https://issues.apache.org/jira/browse/NIFI-12759
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [NIFI-12759] go to RPG [nifi]

2024-02-12 Thread via GitHub


mcgilman merged PR #8378:
URL: https://github.com/apache/nifi/pull/8378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-12782) Migrate GCS processors' Proxy properties to ProxyConfigurationService

2024-02-12 Thread Peter Turcsanyi (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi updated NIFI-12782:
---
Status: Patch Available  (was: Open)

> Migrate GCS processors' Proxy properties to ProxyConfigurationService
> -
>
> Key: NIFI-12782
> URL: https://issues.apache.org/jira/browse/NIFI-12782
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Get rid of the obsolete processor level Proxy properties in all GCS 
> processors and add migration code to convert them to 
> ProxyConfigurationService.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] NIFI-12782 Migrated GCS processors' Proxy properties to ProxyConfigur… [nifi]

2024-02-12 Thread via GitHub


turcsanyip opened a new pull request, #8400:
URL: https://github.com/apache/nifi/pull/8400

   …ationService
   
   Extracted proxy service migration code into a common util module because the 
same logic was already used in AWS module, and it is also reusable in other 
components for proxy property migration.
   
   # Summary
   
   [NIFI-12782](https://issues.apache.org/jira/browse/NIFI-12782)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-12782) Migrate GCS processors' Proxy properties to ProxyConfigurationService

2024-02-12 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-12782:
--

 Summary: Migrate GCS processors' Proxy properties to 
ProxyConfigurationService
 Key: NIFI-12782
 URL: https://issues.apache.org/jira/browse/NIFI-12782
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Peter Turcsanyi
Assignee: Peter Turcsanyi


Get rid of the obsolete processor level Proxy properties in all GCS processors 
and add migration code to convert them to ProxyConfigurationService.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-12781) Remove file location from UPLOAD provenance event

2024-02-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816809#comment-17816809
 ] 

ASF subversion and git services commented on NIFI-12781:


Commit d1af7ef0c551c81604d3d8fb48a23c6ce775de76 in nifi's branch 
refs/heads/main from lehelb
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d1af7ef0c5 ]

NIFI-12781 Removed File Location from Provenance UPLOAD event

This closes #8397

Signed-off-by: David Handermann 


> Remove file location from UPLOAD provenance event
> -
>
> Key: NIFI-12781
> URL: https://issues.apache.org/jira/browse/NIFI-12781
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Lehel Boér
>Assignee: Lehel Boér
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Introducing a file location in the UPLOAD provenance event adds complexity, 
> particularly in regard to modifications in the FileResourceService. Given 
> that the primary concern is displaying file size in the Status History, for 
> now it's advisable to remove the ProvenanceFileResource class. Since the 
> UPLOAD event hasn't been utilized, there are no backward compatibility issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (NIFI-12781) Remove file location from UPLOAD provenance event

2024-02-12 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-12781.
-
Fix Version/s: 2.0.0
   Resolution: Fixed

> Remove file location from UPLOAD provenance event
> -
>
> Key: NIFI-12781
> URL: https://issues.apache.org/jira/browse/NIFI-12781
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Lehel Boér
>Assignee: Lehel Boér
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Introducing a file location in the UPLOAD provenance event adds complexity, 
> particularly in regard to modifications in the FileResourceService. Given 
> that the primary concern is displaying file size in the Status History, for 
> now it's advisable to remove the ProvenanceFileResource class. Since the 
> UPLOAD event hasn't been utilized, there are no backward compatibility issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-12781: Remove file location from provenance UPLOAD event [nifi]

2024-02-12 Thread via GitHub


exceptionfactory closed pull request #8397: NIFI-12781: Remove file location 
from provenance UPLOAD event
URL: https://github.com/apache/nifi/pull/8397


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12632 Extract SFTP components out of the standard bundle [nifi]

2024-02-12 Thread via GitHub


exceptionfactory closed pull request #8277: NIFI-12632 Extract SFTP components 
out of the standard bundle
URL: https://github.com/apache/nifi/pull/8277


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12632 Extract SFTP components out of the standard bundle [nifi]

2024-02-12 Thread via GitHub


exceptionfactory commented on PR #8277:
URL: https://github.com/apache/nifi/pull/8277#issuecomment-1939711448

   @EndzeitBegins Thanks again for your work on this issue.
   
   After some additional discussion on 
[NIFI-11171](https://issues.apache.org/jira/browse/NIFI-11171), I think the 
best approach for now is to hold off on moving the FTP and SFTP components, as 
well as most others listed.
   
   There is still some opportunity for improvement in terms of reducing the 
Proxy Configuration properties, and making that a clean migration using the 
migrate API methods.
   
   Longer term, the design of the SFTP components should be revisited to 
improve connection sharing and other things, but that would be addressed 
separately.
   
   I'm closing this pull request for now, but we can continue the discussion on 
the Jira issue as needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12773: Added join and anchored RecordPath function [nifi]

2024-02-12 Thread via GitHub


ChrisSamo632 commented on code in PR #8391:
URL: https://github.com/apache/nifi/pull/8391#discussion_r1486862504


##
nifi-docs/src/main/asciidoc/record-path-guide.adoc:
##
@@ -456,6 +456,48 @@ Concatenates all the arguments together.
 |==
 
 
+=== join
+
+Joins together multiple values with a separator.
+
+|==
+| RecordPath | Return value
+| `join(', ', /workAddress/* )` | 123, 5th Avenue, New York, NY, 10020
+|==
+
+
+=== anchored
+
+Allows evaluating a RecordPath while anchoring the root context to a child 
record.
+
+|==
+| RecordPath | Return value
+| `anchored(/homeAddress, /city)` | Jersey City
+|==
+
+Additionally, this can be used in conjunction with arrays. For example, if we 
have the following record:
+
+{
+"id": "1234",
+"elements": [{
+"name": "book",
+"color": "red"
+}, {
+"name": "computer",
+"color": "black"
+}]
+}
+
+
+We can evaluate hte following Record paths:

Review Comment:
   ```suggestion
   We can evaluate the following Record paths:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12755 - Upgrade Jetty to 12.0.6 [nifi]

2024-02-12 Thread via GitHub


exceptionfactory commented on PR #8374:
URL: https://github.com/apache/nifi/pull/8374#issuecomment-1939672267

   @pvillard31 I tracked down the source of the problem to due visibility of an 
anonymous class instance used in a test method. The stack trace was related to 
the visibility of a method within the anonymous class, which makes sense since 
it was method-local. I moved the test listener out to a public class in the 
test class and that worked locally as expected. I will plan on merging pending 
successful automated builds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-12754) Flow Configuration History

2024-02-12 Thread Rob Fellows (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Fellows updated NIFI-12754:
---
Status: Patch Available  (was: In Progress)

> Flow Configuration History
> --
>
> Key: NIFI-12754
> URL: https://issues.apache.org/jira/browse/NIFI-12754
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [NIFI-12754] - Flow Configuration History [nifi]

2024-02-12 Thread via GitHub


rfellows opened a new pull request, #8399:
URL: https://github.com/apache/nifi/pull/8399

   * support selection
   * support pagination
   * support sorting
   * added time controls, also updated provenance to use them too
   * allow for clearing of filters
   * use date range filter
   * more details dialog for flow config history
   * support purge history
   
   [NIFI-12754](https://issues.apache.org/jira/browse/NIFI-12754)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-12774) Configure RPG

2024-02-12 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-12774:
---
Status: Patch Available  (was: In Progress)

> Configure RPG
> -
>
> Key: NIFI-12774
> URL: https://issues.apache.org/jira/browse/NIFI-12774
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] NIFI-12781: Remove file location from provenance UPLOAD event [nifi]

2024-02-12 Thread via GitHub


Lehel44 opened a new pull request, #8397:
URL: https://github.com/apache/nifi/pull/8397

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-12781](https://issues.apache.org/jira/browse/NIFI-12781)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [NIFI-12759] go to RPG [nifi]

2024-02-12 Thread via GitHub


mcgilman commented on PR #8378:
URL: https://github.com/apache/nifi/pull/8378#issuecomment-1939523547

   Will review...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-12758) Create RPG

2024-02-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816786#comment-17816786
 ] 

ASF subversion and git services commented on NIFI-12758:


Commit 14fcc42d161a189b1cb41f5398066e19b7824689 in nifi's branch 
refs/heads/main from Scott Aslan
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=14fcc42d16 ]

[NIFI-12758] create remote process group (#8376)

* [NIFI-12758] create remote process group

* address review feedback

* update unit test

This closes #8376 

> Create RPG
> --
>
> Key: NIFI-12758
> URL: https://issues.apache.org/jira/browse/NIFI-12758
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12758) Create RPG

2024-02-12 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-12758:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Create RPG
> --
>
> Key: NIFI-12758
> URL: https://issues.apache.org/jira/browse/NIFI-12758
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [NIFI-12758] create remote process group [nifi]

2024-02-12 Thread via GitHub


mcgilman merged PR #8376:
URL: https://github.com/apache/nifi/pull/8376


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-12781) Remove file location from UPLOAD provenance event

2024-02-12 Thread Jira


[ 
https://issues.apache.org/jira/browse/NIFI-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816785#comment-17816785
 ] 

Lehel Boér commented on NIFI-12781:
---

Thanks, there was a typo in the title, I fixed it. The first usage of UPLOAD 
event will be in PutAzureBlobStorage_v12 when used with FileResourceService. 
When the FileResourceService is used, the content of the FlowFile is replaced 
by external data (FETCH) and we upload external data to an external system 
(UPLOAD), so these provenance events should be emitted in this case.

 

So far the UPLOAD event got a ProvenanceFileResource object as an argument 
which contained the size of the resource in bytes and the location. The initial 
and most important idea was to include the size of the uploaded file too in the 
provenance event and use that size in Status History instead of the FlowFile 
size. The location was additional. 

 

Adding the location would introduce additional changes to FileResourceService 
which was intentionally designed without storing the file location. This would 
further complicate and delay the completion of this task, that's why the 
easiest way is to remove the ProvenanceFileResource(size, location) class and 
instead simply store the size of the resource. This would simply the matter and 
preserve the solution for the initial cause.

> Remove file location from UPLOAD provenance event
> -
>
> Key: NIFI-12781
> URL: https://issues.apache.org/jira/browse/NIFI-12781
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Lehel Boér
>Assignee: Lehel Boér
>Priority: Major
>
> Introducing a file location in the UPLOAD provenance event adds complexity, 
> particularly in regard to modifications in the FileResourceService. Given 
> that the primary concern is displaying file size in the Status History, for 
> now it's advisable to remove the ProvenanceFileResource class. Since the 
> UPLOAD event hasn't been utilized, there are no backward compatibility issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12781) Remove file location from UPLOAD provenance event

2024-02-12 Thread Jira


 [ 
https://issues.apache.org/jira/browse/NIFI-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lehel Boér updated NIFI-12781:
--
Summary: Remove file location from UPLOAD provenance event  (was: Remove 
file size from UPLOAD provenance event)

> Remove file location from UPLOAD provenance event
> -
>
> Key: NIFI-12781
> URL: https://issues.apache.org/jira/browse/NIFI-12781
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Lehel Boér
>Assignee: Lehel Boér
>Priority: Major
>
> Introducing a file location in the UPLOAD provenance event adds complexity, 
> particularly in regard to modifications in the FileResourceService. Given 
> that the primary concern is displaying file size in the Status History, for 
> now it's advisable to remove the ProvenanceFileResource class. Since the 
> UPLOAD event hasn't been utilized, there are no backward compatibility issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-12770) Deprecate Apache Ranger Integration for Removal

2024-02-12 Thread Joe Witt (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816719#comment-17816719
 ] 

Joe Witt commented on NIFI-12770:
-

[~dstiegli1]We set fix versions on things generally when we're merging them.

> Deprecate Apache Ranger Integration for Removal
> ---
>
> Key: NIFI-12770
> URL: https://issues.apache.org/jira/browse/NIFI-12770
> Project: Apache NiFi
>  Issue Type: Task
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Apache Ranger integration should be deprecated on the support branch for 
> subsequent removal on the main branch due to incompatibilities with Jetty 12 
> and related libraries. The Ranger plugins require Jetty 9, which was marked 
> as [End of Community 
> Support|https://github.com/jetty/jetty.project/issues/7958] in June 2022.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12780) Stateless NiFi properties missing in stateless.properties base config

2024-02-12 Thread Stephanie Ambrose (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephanie Ambrose updated NIFI-12780:
-
Description: 
These new properties from NIFI-11471 need to be added to the base 
stateless.properties file otherwise you won't be able to override them with 
environment variables in the replace docker scripts:

 

nifi.stateless.component.enableTimeout

nifi.stateless.processor.startTimeout

 

Alternatively, make the properties not case-sensitive.

  was:
These new properties from NIFI-11471 need to be added to the base 
stateless.properties file otherwise you won't be able to override them with 
environment variables in the replace docker scripts:

 

nifi.stateless.component.enableTimeout

nifi.stateless.processor.startTimeout


> Stateless NiFi properties missing in stateless.properties base config
> -
>
> Key: NIFI-12780
> URL: https://issues.apache.org/jira/browse/NIFI-12780
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Stephanie Ambrose
>Priority: Major
>
> These new properties from NIFI-11471 need to be added to the base 
> stateless.properties file otherwise you won't be able to override them with 
> environment variables in the replace docker scripts:
>  
> nifi.stateless.component.enableTimeout
> nifi.stateless.processor.startTimeout
>  
> Alternatively, make the properties not case-sensitive.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-12781) Remove file size from UPLOAD provenance event

2024-02-12 Thread Joe Witt (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816717#comment-17816717
 ] 

Joe Witt commented on NIFI-12781:
-

Lehel can you elaborate more on what the purpose of this JIRA is?

The subject says you want to remove the file size.  The body says the filesize 
is the primary concern.

The point of provenance data is to give an accurate accounting of what was done 
to/for data and where data came from or went to. What is the proposed outcome 
of this change?

Thanks

> Remove file size from UPLOAD provenance event
> -
>
> Key: NIFI-12781
> URL: https://issues.apache.org/jira/browse/NIFI-12781
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Lehel Boér
>Assignee: Lehel Boér
>Priority: Major
>
> Introducing a file location in the UPLOAD provenance event adds complexity, 
> particularly in regard to modifications in the FileResourceService. Given 
> that the primary concern is displaying file size in the Status History, for 
> now it's advisable to remove the ProvenanceFileResource class. Since the 
> UPLOAD event hasn't been utilized, there are no backward compatibility issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-12770) Deprecate Apache Ranger Integration for Removal

2024-02-12 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816716#comment-17816716
 ] 

Daniel Stieglitz commented on NIFI-12770:
-

[~exceptionfactory] I see "None" for the "Affects Version/s:" and 
"Fix Version/s:"  I assume that should be 1.25 and 1.26 right?

> Deprecate Apache Ranger Integration for Removal
> ---
>
> Key: NIFI-12770
> URL: https://issues.apache.org/jira/browse/NIFI-12770
> Project: Apache NiFi
>  Issue Type: Task
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Apache Ranger integration should be deprecated on the support branch for 
> subsequent removal on the main branch due to incompatibilities with Jetty 12 
> and related libraries. The Ranger plugins require Jetty 9, which was marked 
> as [End of Community 
> Support|https://github.com/jetty/jetty.project/issues/7958] in June 2022.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-12781) Remove file size from UPLOAD provenance event

2024-02-12 Thread Jira
Lehel Boér created NIFI-12781:
-

 Summary: Remove file size from UPLOAD provenance event
 Key: NIFI-12781
 URL: https://issues.apache.org/jira/browse/NIFI-12781
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Lehel Boér
Assignee: Lehel Boér


Introducing a file location in the UPLOAD provenance event adds complexity, 
particularly in regard to modifications in the FileResourceService. Given that 
the primary concern is displaying file size in the Status History, for now it's 
advisable to remove the ProvenanceFileResource class. Since the UPLOAD event 
hasn't been utilized, there are no backward compatibility issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-12780) Stateless NiFi properties missing in stateless.properties base config

2024-02-12 Thread Stephanie Ambrose (Jira)
Stephanie Ambrose created NIFI-12780:


 Summary: Stateless NiFi properties missing in stateless.properties 
base config
 Key: NIFI-12780
 URL: https://issues.apache.org/jira/browse/NIFI-12780
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Stephanie Ambrose


These new properties from NIFI-11471 need to be added to the base 
stateless.properties file otherwise you won't be able to override them with 
environment variables in the replace docker scripts:

 

nifi.stateless.component.enableTimeout

nifi.stateless.processor.startTimeout



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] NIFI-12772 Expose REMOTE_POLL_BATCH_SIZE property for ListSFTP [nifi]

2024-02-12 Thread via GitHub


exceptionfactory commented on code in PR #8390:
URL: https://github.com/apache/nifi/pull/8390#discussion_r1486581589


##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -317,6 +317,12 @@ protected void getListing(final String path, final int 
depth, final int maxResul
 final RemoteResourceFilter filter = (entry) -> {
 final String entryFilename = entry.getName();
 
+// Since SSHJ does not have the concept of BREAK that JSCH 
had, we need to move this before the call to listing.add
+// below, otherwise we would keep adding to the listings since 
returning false here doesn't break
+if (listing.size() >= maxResults) {
+return false;
+}
+

Review Comment:
   Is this change necessary? It seems useful in some circumstances, but not 
needed for this particular property change.



##
nifi-nar-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FileTransfer.java:
##
@@ -29,6 +29,7 @@
 import org.apache.nifi.processor.ProcessSession;
 import org.apache.nifi.processor.exception.ProcessException;
 import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.processor.util.list.AbstractListProcessor;

Review Comment:
   This change can be reverted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12772 Expose REMOTE_POLL_BATCH_SIZE property for ListSFTP [nifi]

2024-02-12 Thread via GitHub


joewitt commented on PR #8390:
URL: https://github.com/apache/nifi/pull/8390#issuecomment-1939182545

   I don't have a lot to add to the comments I see already.  But the main gist 
is if the intent of the JIRA is now broader than the original title please 
change the JIRA.  If the intent has not changed then please narrow the PR.  So 
either this is about adding this option to ListSFTP or it is about others.  
Would be important to validate each case which expands the scope of the review.
   
   Given we don't actually get to, it appears, change the behavior of the SFTP 
commands executed on the remote end (ie: once you start a listing in a large 
directory...much of the damage is already done in terms of time/waiting) then 
the benefit of this property being available is mostly to protect the NiFi 
side.  Still useful just probably not the truly desired/most beneficial impact.
   
   I'd avoid *any* changes for now that aren't central to the specific desired 
improvement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] NIFI-12779 Update okio.version to 3.8.0 [nifi]

2024-02-12 Thread via GitHub


mr1716 opened a new pull request, #8396:
URL: https://github.com/apache/nifi/pull/8396

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-12779](https://issues.apache.org/jira/browse/NIFI-12779)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12779) 
issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-12779) Update okio.version to 3.8.0

2024-02-12 Thread Mike R (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike R updated NIFI-12779:
--
Priority: Minor  (was: Major)

> Update okio.version to 3.8.0
> 
>
> Key: NIFI-12779
> URL: https://issues.apache.org/jira/browse/NIFI-12779
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Mike R
>Assignee: Mike R
>Priority: Minor
>
> Update okio.version to 3.8.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (NIFI-12779) Update okio.version to 3.8.0

2024-02-12 Thread Mike R (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike R reassigned NIFI-12779:
-

Assignee: Mike R

> Update okio.version to 3.8.0
> 
>
> Key: NIFI-12779
> URL: https://issues.apache.org/jira/browse/NIFI-12779
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Mike R
>Assignee: Mike R
>Priority: Major
>
> Update okio.version to 3.8.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-12779) Update okio.version to 3.8.0

2024-02-12 Thread Mike R (Jira)
Mike R created NIFI-12779:
-

 Summary: Update okio.version to 3.8.0
 Key: NIFI-12779
 URL: https://issues.apache.org/jira/browse/NIFI-12779
 Project: Apache NiFi
  Issue Type: Improvement
Affects Versions: 2.0.0-M2
Reporter: Mike R


Update okio.version to 3.8.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-12778) RPG Manage remote ports

2024-02-12 Thread Scott Aslan (Jira)
Scott Aslan created NIFI-12778:
--

 Summary: RPG Manage remote ports
 Key: NIFI-12778
 URL: https://issues.apache.org/jira/browse/NIFI-12778
 Project: Apache NiFi
  Issue Type: Sub-task
Reporter: Scott Aslan
Assignee: Scott Aslan






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework

2024-02-12 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-12400:
---
Description: 
The purpose of this Jira is to track all remaining items following the initial 
commit [1] for NIFI-11481. The description will be kept up to date with 
remaining features, tasks, and improvements. As each items is worked, a new sub 
task Jira will be created and referenced in this description.
 * Support Parameters in Properties with Allowable Values (NIFI-12401)
 * Summary (NIFI-12437)
 ** Remaining work not addressed in initial Jira:
 *** input ports (NIFI-12504)
 *** output ports (NIFI-12504)
 *** remote process groups (NIFI-12504)
 *** process groups (NIFI-12504)
 *** connections (NIFI-12504)
 *** System Diagnostics (NIFI-12505)
 *** support for cluster-specific ui elements (NIFI-12537)
 *** Add pagination (NIFI-12552)
 * Counters (NIFI-12415)
 * Bulletin Board (NIFI-12560)
 * Provenance (NIFI-12445)
 ** Event Listing (NIFI-12445)
 ** Search (NIFI-12445)
 ** Event Dialog (NIFI-12445)
 ** Lineage (NIFI-12485)
 ** Replay from context menu (NIFI-12445)

 * Configure Reporting Task (NIFI-12563)
 * Flow Analysis Rules (NIFI-12588)
 * Registry Clients (NIFI-12486)
 * Import from Registry (NIFI-12734)
 * Parameter Providers (NIFI-12622)
 ** Fetch parameters from provider, map to parameter context (dialog) - 
(NIFI-12665)
 * Cluster
 ** Status History - node specific values
 * Flow Configuration History (NIFI-12754)
 * Node Status History (NIFI-12553)
 * Status history for components from canvas context menu (NIFI-12553)
 * Users (NIFI-12543)
 * Policies (NIFI-12548)
 ** Overridden policy Empty or Copy (NIFI-12679)
 * Help
 * About
 * Show Upstream/Downstream
 * Align
 * List Queue (NIFI-12589)
 * Empty [all] Queue (NIFI-12604)
 * View Content (NIFI-12589 and NIFI-12445)
 * View State (NIFI-12611)
 * Change Component Version
 * Consider PG permissions in Toolbox (NIFI-12683)
 * PG Version
 ** Start
 ** Commit
 ** Force Commit
 ** Show changes
 ** Revert changes
 ** Change Flow version
 ** Stop

 * Configure PG (NIFI-12417)
 * Process Group Services (NIFI-12425)
 ** Listing (NIFI-12425)
 ** Create (NIFI-12425)
 ** Configure (NIFI-12425)
 ** Delete (NIFI-12425)
 ** Enable (NIFI-12529)
 ** Disable (NIFI-12529)
 ** Improve layout and breadcrumbs
 ** Disable and Configure
 * Configure Processor
 ** Service Link (NIFI-12425)
 ** Create inline Service (NIFI-12425)
 ** Parameter Link (NIFI-12502)
 ** Convert to Parameter (NIFI-12502)
 ** Fix issue with Property Editor width (NIFI-12547)
 ** Stop and Configure
 ** Open Custom UI
 ** Property History
 ** Unable to re-add any removed Property (NIFI-12743)
 ** Shift-Enter new line when editing Property (NIFI-12743)
 * Property Verification
 * More Details (Processor, Controller Service, Reporting Task)

 * Download Flow
 * Create RPG (NIFI-12758)
 * Configure RPG (NIFI-12774)
 * RPG Remote Ports (NIFI-12778)
 * RPG Go To (NIFI-12759)
 * RPG Refresh (NIFI-12761)
 * Color
 * Move to Front
 * Copy/Paste
 * Add/Update Info Icons in dialogs throughout the application
 * Set viewport earlier when loading a Process Group (NIFI-12737)
 * Canvas global menu item should navigate user back to where they were on the 
canvas (NIFI-12737)
 * Better theme support (NIFI-12655)
 * Set up development/production environments files
 * Run unit tests are part of standard build
 * Update all API calls to consider disconnect node confirmation
 * Update API calls to use uiOnly flag
 * Use polling interval from API
 * Routing error handling
 * General API response error handling
 ** Management CS (NIFI-12663)
 ** Canvas CS (NIFI-12684)
 ** Remainder of Settings (NIFI-12723)
 ** Counters (NIFI-12723)
 ** Bulletins (NIFI-12723)
 ** Flow Designer
 ** Parameter Contexts
 ** Provenance (NIFI-12767)
 ** Queue Listing (NIFI-12742)
 ** Summary (NIFI-12742)
 ** Users (NIFI-12742)
 ** Policies
 ** Status History
 * Introduce header in new pages to unify with canvas and offer better 
navigation. (NIFI-12597)
 * Prompt user to save Parameter Context when Edit form is dirty
 * Upgrade to Angular 17
 * Start/Stop processors, process groups, ... (NIFI-12568)
 * Dialog vertical resizing on smaller screens do not allow users to access all 
fields (NIFI-12603)
 * Flow Analysis report menu

[1] [https://github.com/apache/nifi/pull/8053]

  was:
The purpose of this Jira is to track all remaining items following the initial 
commit [1] for NIFI-11481. The description will be kept up to date with 
remaining features, tasks, and improvements. As each items is worked, a new sub 
task Jira will be created and referenced in this description.
 * Support Parameters in Properties with Allowable Values (NIFI-12401)
 * Summary (NIFI-12437)
 ** Remaining work not addressed in initial Jira:
 *** input ports (NIFI-12504)
 *** output ports (NIFI-12504)
 *** remote process groups (NIFI-12504)
 *** process groups 

[jira] [Commented] (NIFI-12777) QueryRecord does not support UUID field type

2024-02-12 Thread Nikolas Falco (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816660#comment-17816660
 ] 

Nikolas Falco commented on NIFI-12777:
--

I had open a pull request on github to fix this issue. Added as JIRA link

> QueryRecord does not support UUID field type
> 
>
> Key: NIFI-12777
> URL: https://issues.apache.org/jira/browse/NIFI-12777
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.25.0
> Environment: windows
>Reporter: Nikolas Falco
>Priority: Major
>
> I have a QueryRecord processor that takes a flowfile as input. This flowfile 
> contains records with some fields of type UUID.
> {noformat}
> 

Re: [PR] Feature/nifi 12777 [nifi]

2024-02-12 Thread via GitHub


nfalco79 closed pull request #8395: Feature/nifi 12777
URL: https://github.com/apache/nifi/pull/8395


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Feature/nifi 12777 [nifi]

2024-02-12 Thread via GitHub


nfalco79 opened a new pull request, #8395:
URL: https://github.com/apache/nifi/pull/8395

   # Summary
   
   [NIFI-12777](https://issues.apache.org/jira/browse/NIFI-12777)
   
   # Tracking
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12777) 
issue created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-12777`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-12777`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
   - [ ] JDK 21


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINIFICPP-2276 Support FlowFileTransform NiFi Python processors [nifi-minifi-cpp]

2024-02-12 Thread via GitHub


szaszm commented on code in PR #1712:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1712#discussion_r1486436629


##
extensions/python/types/PyProcessContext.cpp:
##
@@ -65,12 +66,31 @@ PyObject* PyProcessContext::getProperty(PyProcessContext* 
self, PyObject* args)
 return nullptr;
   }
 
-  const char* property;
-  if (!PyArg_ParseTuple(args, "s", )) {
+  const char* property_name = nullptr;
+  PyObject* script_flow_file = nullptr;
+  if (!PyArg_ParseTuple(args, "s|O", _name, _flow_file)) {
 throw PyException();
   }
+
   std::string value;
-  context->getProperty(property, value);
+  if (!script_flow_file) {
+if (!context->getProperty(property_name, value)) {
+  Py_RETURN_NONE;
+}
+  } else {
+auto py_flow = reinterpret_cast(script_flow_file);
+const auto flow_file = py_flow->script_flow_file_.lock();
+if (!flow_file) {
+  PyErr_SetString(PyExc_AttributeError, "tried reading FlowFile outside 
'on_trigger'");
+  return nullptr;
+}

Review Comment:
   No, I was only thinking about raw non-owning pointers instead of weak_ptr, 
but it looks like that's not feasible for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12644:Exported json flows does not match minifi json schema resolved by adding new method Transform to convert Nifi Flow json to MiNifi flow json [nifi]

2024-02-12 Thread via GitHub


AjayPremarajan closed pull request #8393: NIFI-12644:Exported json flows does 
not match minifi json schema resolved by adding new method Transform to convert 
Nifi Flow json to MiNifi flow json
URL: https://github.com/apache/nifi/pull/8393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINIFICPP-2231 Replace global CXX flags with target specific ones [nifi-minifi-cpp]

2024-02-12 Thread via GitHub


lordgamez commented on code in PR #1724:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1724#discussion_r1486368105


##
CMakeLists.txt:
##
@@ -325,20 +325,33 @@ include(MagicEnum)
 
 # Setup warning flags
 if(MSVC)
+set(MINIFI_CPP_COMPILE_OPTIONS ${MINIFI_CPP_COMPILE_OPTIONS} /W3)
 if(FAIL_ON_WARNINGS)
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX")
+set(MINIFI_CPP_COMPILE_OPTIONS ${MINIFI_CPP_COMPILE_OPTIONS} /WX)
 endif()
 else()
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
+set(MINIFI_CPP_COMPILE_OPTIONS ${MINIFI_CPP_COMPILE_OPTIONS} -Wall -Wextra 
-Wno-reorder)

Review Comment:
   Good point, it was set in libminifi for some reason so I moved it to the 
minificpp compile options. I removed it and fixed the libminifi issues in 
f53b73d0a9f001cc4b7d4b1d82950b50855b43af



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-12777) QueryRecord does not support UUID field type

2024-02-12 Thread Nikolas Falco (Jira)
Nikolas Falco created NIFI-12777:


 Summary: QueryRecord does not support UUID field type
 Key: NIFI-12777
 URL: https://issues.apache.org/jira/browse/NIFI-12777
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
Affects Versions: 1.25.0
 Environment: windows
Reporter: Nikolas Falco


I have a QueryRecord processor that takes a flowfile as input. This flowfile 
contains records with some fields of type UUID.
{noformat}

[jira] [Commented] (NIFI-12744) Solr processors do not work with Nifi 2 M2

2024-02-12 Thread Andreas Koch (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816642#comment-17816642
 ] 

Andreas Koch commented on NIFI-12744:
-

Thanks for the answer. Makes sense.

But why is one jar (jetty-io.jar) loaded from within the narfile and the other 
(jetty-util.jar) not. Is that a class loading issue in NIFI? I thought that all 
libs in a NAR file are isolated. Are they not?

 

> Solr processors do not work with Nifi 2 M2
> --
>
> Key: NIFI-12744
> URL: https://issues.apache.org/jira/browse/NIFI-12744
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Andreas Koch
>Priority: Critical
>
> *steps to reproduce*
>  * we launched Nifi in Docker
>  * build the nar file for nifi-solr-processor
>  * deploy the nar file to nifi
>  * Configure Query Solr Processor for cloude
>  * execute query
>  
> {code:java}
> // code placeholder2024-02-06 08:47:28,886 ERROR [Timer-Driven Process 
> Thread-4] o.apache.nifi.processors.solr.QuerySolr 
> QuerySolr[id=7d932b59-018d-1000-404a-2744f73f9f8c] Failed to properly 
> initialize Processor. If still scheduled to run, NiFi will attempt to 
> initialize and run the Processor again after the 'Administrative Yield 
> Duration' has elapsed. Failure is due to 
> java.lang.IncompatibleClassChangeError: class 
> org.eclipse.jetty.io.ArrayRetainableByteBufferPool$RetainedBucket has 
> interface org.eclipse.jetty.util.Pool as super class 
> java.lang.IncompatibleClassChangeError: class 
> org.eclipse.jetty.io.ArrayRetainableByteBufferPool$RetainedBucket has 
> interface org.eclipse.jetty.util.Pool as super class         at 
> java.base/java.lang.ClassLoader.defineClass1(Native Method)         at 
> java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)         at 
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
>          at 
> java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:524)        
>  at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427)         
> at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421)         
> at 
> java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
>          at 
> java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420)         
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593)         at 
> java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)         at 
> org.eclipse.jetty.io.ArrayRetainableByteBufferPool.(ArrayRetainableByteBufferPool.java:148)
>          at 
> org.eclipse.jetty.io.ArrayRetainableByteBufferPool.(ArrayRetainableByteBufferPool.java:95)
>          at 
> org.eclipse.jetty.io.MappedByteBufferPool$Retained.(MappedByteBufferPool.java:317)
>          at 
> org.eclipse.jetty.io.MappedByteBufferPool.newRetainableByteBufferPool(MappedByteBufferPool.java:140)
>          at 
> org.eclipse.jetty.io.AbstractByteBufferPool.(AbstractByteBufferPool.java:68)
>          at 
> org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:133)
>          at 
> org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:89)
>          at 
> org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:77)
>          at org.eclipse.jetty.client.HttpClient.doStart(HttpClient.java:206)  
>        at 
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
>          at 
> org.apache.solr.client.solrj.impl.Http2SolrClient.createHttpClient(Http2SolrClient.java:288)
>          at 
> org.apache.solr.client.solrj.impl.Http2SolrClient.(Http2SolrClient.java:180)
>          at 
> org.apache.solr.client.solrj.impl.Http2SolrClient$Builder.build(Http2SolrClient.java:1099)
>          at 
> org.apache.nifi.processors.solr.SolrUtils.createSolrClient(SolrUtils.java:201)
>          at 
> org.apache.nifi.processors.solr.SolrProcessor.createSolrClient(SolrProcessor.java:153)
>          at 
> org.apache.nifi.processors.solr.SolrProcessor.onScheduled(SolrProcessor.java:79)
>          at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>          at java.base/java.lang.reflect.Method.invoke(Method.java:580)        
>  at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
>          at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
>          at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
>          at 
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
>          at 
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$10(StandardProcessorNode.java:1668)
>          at 

[PR] NIFI-12776: Add UPLOAD provenance event to PutAZureBlobStorage [nifi]

2024-02-12 Thread via GitHub


Lehel44 opened a new pull request, #8394:
URL: https://github.com/apache/nifi/pull/8394

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12772 Expose REMOTE_POLL_BATCH_SIZE property for ListSFTP [nifi]

2024-02-12 Thread via GitHub


tombrisland commented on code in PR #8390:
URL: https://github.com/apache/nifi/pull/8390#discussion_r1486288578


##
nifi-nar-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FileTransfer.java:
##
@@ -172,6 +173,8 @@ default String getAbsolutePath(FlowFile flowFile, String 
remotePath) throws IOEx
 + "than normal.")
 .defaultValue("5000")
 .addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
+// Limiting to batches means that TIME_TRACKING and TIME_WINDOW 
strategies will leave files behind
+.dependsOn(AbstractListProcessor.LISTING_STRATEGY, 
AbstractListProcessor.BY_ENTITIES, AbstractListProcessor.NO_TRACKING)

Review Comment:
   Thanks @exceptionfactory .
   
   I did intend for the changes to cover both, I can't think how 
`TIME_TRACKING` can work with batches for either `ListSFTP` or `ListFTP`. Have 
you got an example where it does?
   
   I checked out `GetFTP` and `GetSFTP` and they retain the property even with 
the dependency, it seems that if the 'depended on' property doesn't exist then 
it defaults to visible.
   
   Happy to make the change of course, can you think of a different way to 
communicate the limitation to the user?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12772 Expose REMOTE_POLL_BATCH_SIZE property for ListSFTP [nifi]

2024-02-12 Thread via GitHub


tombrisland commented on code in PR #8390:
URL: https://github.com/apache/nifi/pull/8390#discussion_r1486288578


##
nifi-nar-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FileTransfer.java:
##
@@ -172,6 +173,8 @@ default String getAbsolutePath(FlowFile flowFile, String 
remotePath) throws IOEx
 + "than normal.")
 .defaultValue("5000")
 .addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
+// Limiting to batches means that TIME_TRACKING and TIME_WINDOW 
strategies will leave files behind
+.dependsOn(AbstractListProcessor.LISTING_STRATEGY, 
AbstractListProcessor.BY_ENTITIES, AbstractListProcessor.NO_TRACKING)

Review Comment:
   I did intend for the changes to cover both, I can't think how 
`TIME_TRACKING` can work with batches for either `ListSFTP` or `ListFTP`. Have 
you got an example where it does?
   
   I checked out `GetFTP` and `GetSFTP` and they retain the property even with 
the dependency, it seems that if the 'depended on' property doesn't exist then 
it defaults to visible.
   
   Happy to make the change of course, can you think of a different way to 
communicate the limitation to the user?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12772 Expose REMOTE_POLL_BATCH_SIZE property for ListSFTP [nifi]

2024-02-12 Thread via GitHub


exceptionfactory commented on code in PR #8390:
URL: https://github.com/apache/nifi/pull/8390#discussion_r1486233561


##
nifi-nar-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FileTransfer.java:
##
@@ -172,6 +173,8 @@ default String getAbsolutePath(FlowFile flowFile, String 
remotePath) throws IOEx
 + "than normal.")
 .defaultValue("5000")
 .addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
+// Limiting to batches means that TIME_TRACKING and TIME_WINDOW 
strategies will leave files behind
+.dependsOn(AbstractListProcessor.LISTING_STRATEGY, 
AbstractListProcessor.BY_ENTITIES, AbstractListProcessor.NO_TRACKING)

Review Comment:
   This should not be changed because it also impacts the `ListFTP` Processor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework

2024-02-12 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-12400:
---
Description: 
The purpose of this Jira is to track all remaining items following the initial 
commit [1] for NIFI-11481. The description will be kept up to date with 
remaining features, tasks, and improvements. As each items is worked, a new sub 
task Jira will be created and referenced in this description.
 * Support Parameters in Properties with Allowable Values (NIFI-12401)
 * Summary (NIFI-12437)
 ** Remaining work not addressed in initial Jira:
 *** input ports (NIFI-12504)
 *** output ports (NIFI-12504)
 *** remote process groups (NIFI-12504)
 *** process groups (NIFI-12504)
 *** connections (NIFI-12504)
 *** System Diagnostics (NIFI-12505)
 *** support for cluster-specific ui elements (NIFI-12537)
 *** Add pagination (NIFI-12552)
 * Counters (NIFI-12415)
 * Bulletin Board (NIFI-12560)
 * Provenance (NIFI-12445)
 ** Event Listing (NIFI-12445)
 ** Search (NIFI-12445)
 ** Event Dialog (NIFI-12445)
 ** Lineage (NIFI-12485)
 ** Replay from context menu (NIFI-12445)

 * Configure Reporting Task (NIFI-12563)
 * Flow Analysis Rules (NIFI-12588)
 * Registry Clients (NIFI-12486)
 * Import from Registry (NIFI-12734)
 * Parameter Providers (NIFI-12622)
 ** Fetch parameters from provider, map to parameter context (dialog) - 
(NIFI-12665)
 * Cluster
 ** Status History - node specific values
 * Flow Configuration History (NIFI-12754)
 * Node Status History (NIFI-12553)
 * Status history for components from canvas context menu (NIFI-12553)
 * Users (NIFI-12543)
 * Policies (NIFI-12548)
 ** Overridden policy Empty or Copy (NIFI-12679)
 * Help
 * About
 * Show Upstream/Downstream
 * Align
 * List Queue (NIFI-12589)
 * Empty [all] Queue (NIFI-12604)
 * View Content (NIFI-12589 and NIFI-12445)
 * View State (NIFI-12611)
 * Change Component Version
 * Consider PG permissions in Toolbox (NIFI-12683)
 * PG Version
 ** Start
 ** Commit
 ** Force Commit
 ** Show changes
 ** Revert changes
 ** Change Flow version
 ** Stop

 * Configure PG (NIFI-12417)
 * Process Group Services (NIFI-12425)
 ** Listing (NIFI-12425)
 ** Create (NIFI-12425)
 ** Configure (NIFI-12425)
 ** Delete (NIFI-12425)
 ** Enable (NIFI-12529)
 ** Disable (NIFI-12529)
 ** Improve layout and breadcrumbs
 ** Disable and Configure
 * Configure Processor
 ** Service Link (NIFI-12425)
 ** Create inline Service (NIFI-12425)
 ** Parameter Link (NIFI-12502)
 ** Convert to Parameter (NIFI-12502)
 ** Fix issue with Property Editor width (NIFI-12547)
 ** Stop and Configure
 ** Open Custom UI
 ** Property History
 ** Unable to re-add any removed Property (NIFI-12743)
 ** Shift-Enter new line when editing Property (NIFI-12743)
 * Property Verification
 * More Details (Processor, Controller Service, Reporting Task)

 * Download Flow
 * Create RPG (NIFI-12758)
 * Configure RPG (NIFI-12774)
 * RPG Remote Ports
 * RPG Go To (NIFI-12759)
 * RPG Refresh (NIFI-12761)
 * Color
 * Move to Front
 * Copy/Paste
 * Add/Update Info Icons in dialogs throughout the application
 * Set viewport earlier when loading a Process Group (NIFI-12737)
 * Canvas global menu item should navigate user back to where they were on the 
canvas (NIFI-12737)
 * Better theme support (NIFI-12655)
 * Set up development/production environments files
 * Run unit tests are part of standard build
 * Update all API calls to consider disconnect node confirmation
 * Update API calls to use uiOnly flag
 * Use polling interval from API
 * Routing error handling
 * General API response error handling
 ** Management CS (NIFI-12663)
 ** Canvas CS (NIFI-12684)
 ** Remainder of Settings (NIFI-12723)
 ** Counters (NIFI-12723)
 ** Bulletins (NIFI-12723)
 ** Flow Designer
 ** Parameter Contexts
 ** Provenance (NIFI-12767)
 ** Queue Listing (NIFI-12742)
 ** Summary (NIFI-12742)
 ** Users (NIFI-12742)
 ** Policies
 ** Status History
 * Introduce header in new pages to unify with canvas and offer better 
navigation. (NIFI-12597)
 * Prompt user to save Parameter Context when Edit form is dirty
 * Upgrade to Angular 17
 * Start/Stop processors, process groups, ... (NIFI-12568)
 * Dialog vertical resizing on smaller screens do not allow users to access all 
fields (NIFI-12603)
 * Flow Analysis report menu

[1] [https://github.com/apache/nifi/pull/8053]

  was:
The purpose of this Jira is to track all remaining items following the initial 
commit [1] for NIFI-11481. The description will be kept up to date with 
remaining features, tasks, and improvements. As each items is worked, a new sub 
task Jira will be created and referenced in this description.
 * Support Parameters in Properties with Allowable Values (NIFI-12401)
 * Summary (NIFI-12437)
 ** Remaining work not addressed in initial Jira:
 *** input ports (NIFI-12504)
 *** output ports (NIFI-12504)
 *** remote process groups (NIFI-12504)
 *** process groups (NIFI-12504)
 *** 

[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework

2024-02-12 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-12400:
---
Description: 
The purpose of this Jira is to track all remaining items following the initial 
commit [1] for NIFI-11481. The description will be kept up to date with 
remaining features, tasks, and improvements. As each items is worked, a new sub 
task Jira will be created and referenced in this description.
 * Support Parameters in Properties with Allowable Values (NIFI-12401)
 * Summary (NIFI-12437)
 ** Remaining work not addressed in initial Jira:
 *** input ports (NIFI-12504)
 *** output ports (NIFI-12504)
 *** remote process groups (NIFI-12504)
 *** process groups (NIFI-12504)
 *** connections (NIFI-12504)
 *** System Diagnostics (NIFI-12505)
 *** support for cluster-specific ui elements (NIFI-12537)
 *** Add pagination (NIFI-12552)
 * Counters (NIFI-12415)
 * Bulletin Board (NIFI-12560)
 * Provenance (NIFI-12445)
 ** Event Listing (NIFI-12445)
 ** Search (NIFI-12445)
 ** Event Dialog (NIFI-12445)
 ** Lineage (NIFI-12485)
 ** Replay from context menu (NIFI-12445)

 * Configure Reporting Task (NIFI-12563)
 * Flow Analysis Rules (NIFI-12588)
 * Registry Clients (NIFI-12486)
 * Import from Registry (NIFI-12734)
 * Parameter Providers (NIFI-12622)
 ** Fetch parameters from provider, map to parameter context (dialog) - 
(NIFI-12665)
 * Cluster
 ** Status History - node specific values
 * Flow Configuration History (NIFI-12754)
 * Node Status History (NIFI-12553)
 * Status history for components from canvas context menu (NIFI-12553)
 * Users (NIFI-12543)
 * Policies (NIFI-12548)
 ** Overridden policy Empty or Copy (NIFI-12679)
 * Help
 * About
 * Show Upstream/Downstream
 * Align
 * List Queue (NIFI-12589)
 * Empty [all] Queue (NIFI-12604)
 * View Content (NIFI-12589 and NIFI-12445)
 * View State (NIFI-12611)
 * Change Component Version
 * Consider PG permissions in Toolbox (NIFI-12683)
 * PG Version
 ** Start
 ** Commit
 ** Force Commit
 ** Show changes
 ** Revert changes
 ** Change Flow version
 ** Stop

 * Configure PG (NIFI-12417)
 * Process Group Services (NIFI-12425)
 ** Listing (NIFI-12425)
 ** Create (NIFI-12425)
 ** Configure (NIFI-12425)
 ** Delete (NIFI-12425)
 ** Enable (NIFI-12529)
 ** Disable (NIFI-12529)
 ** Improve layout and breadcrumbs
 ** Disable and Configure
 * Configure Processor
 ** Service Link (NIFI-12425)
 ** Create inline Service (NIFI-12425)
 ** Parameter Link (NIFI-12502)
 ** Convert to Parameter (NIFI-12502)
 ** Fix issue with Property Editor width (NIFI-12547)
 ** Stop and Configure
 ** Open Custom UI
 ** Property History
 ** Unable to re-add any removed Property (NIFI-12743)
 ** Shift-Enter new line when editing Property (NIFI-12743)
 * Property Verification
 * More Details (Processor, Controller Service, Reporting Task)

 * Download Flow
 * Create RPG (NIFI-12758)
 * Configure RPG (NIFI-12774)
 * RPG Remote Ports
 * RPG Go To (NIFI-12759)
 * RPG Refresh (NIFI-12761)
 * Color
 * Move to Front
 * Copy/Paste
 * Add/Update Info Icons in dialogs throughout the application
 * Set viewport earlier when loading a Process Group (NIFI-12737)
 * Canvas global menu item should navigate user back to where they were on the 
canvas (NIFI-12737)
 * Better theme support (NIFI-12655)
 * Set up development/production environments files
 * Run unit tests are part of standard build
 * Update all API calls to consider disconnect node confirmation
 * Update API calls to use uiOnly flag
 * Use polling interval from API
 * Routing error handling
 * General API response error handling
 ** Management CS (NIFI-12663)
 ** Canvas CS (NIFI-12684)
 ** Remainder of Settings (NIFI-12723)
 ** Counters (NIFI-12723)
 ** Bulletins (NIFI-12723)
 ** Flow Designer
 ** Parameter Contexts
 ** Provenance
 ** Queue Listing (NIFI-12742)
 ** Summary (NIFI-12742)
 ** Users (NIFI-12742)
 ** Policies
 ** Status History
 * Introduce header in new pages to unify with canvas and offer better 
navigation. (NIFI-12597)
 * Prompt user to save Parameter Context when Edit form is dirty
 * Upgrade to Angular 17
 * Start/Stop processors, process groups, ... (NIFI-12568)
 * Dialog vertical resizing on smaller screens do not allow users to access all 
fields (NIFI-12603)
 * Flow Analysis report menu

[1] [https://github.com/apache/nifi/pull/8053]

  was:
The purpose of this Jira is to track all remaining items following the initial 
commit [1] for NIFI-11481. The description will be kept up to date with 
remaining features, tasks, and improvements. As each items is worked, a new sub 
task Jira will be created and referenced in this description.
 * Support Parameters in Properties with Allowable Values (NIFI-12401)
 * Summary (NIFI-12437)
 ** Remaining work not addressed in initial Jira:
 *** input ports (NIFI-12504)
 *** output ports (NIFI-12504)
 *** remote process groups (NIFI-12504)
 *** process groups (NIFI-12504)
 *** connections 

[jira] [Commented] (NIFI-12644) Exported json flows does not match minifi json schema

2024-02-12 Thread Ajay Premarajan (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816596#comment-17816596
 ] 

Ajay Premarajan commented on NIFI-12644:


I have open a pull request for resolution of this issue by adding a separate 
method "tranform" in minifi toolkit to transform MiNifi json flow to Nifi flow 
json based on " 1 to 1 mapping: flowContents in the exported json is rootGroup 
in the flow.json.raw"

> Exported json flows does not match minifi json schema
> -
>
> Key: NIFI-12644
> URL: https://issues.apache.org/jira/browse/NIFI-12644
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: MiNiFi
>Affects Versions: 2.0.0-M1
>Reporter: Valiantsin Shukaila
>Assignee: Ajay Premarajan
>Priority: Major
> Attachments: flow-exported-from-nifi2.json, 
> minifi-example-flow-from-tests.json
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In documentation for Minifi java agent project it is mentioned that in order 
> to import process flow, now it is necessary to export nifi flow as json and 
> put it in minifi. here link to doc: 
> [https://github.com/apache/nifi/blob/main/minifi/minifi-docs/src/main/markdown/minifi-java-agent-quick-start.md]
> But in fact the JSON formats compeltelly do not match. Minifi expect format 
> of legacy nifi flow templates just in JSON. But exported nifi flows is 
> something very much different.
> Therefore it is not really possible to import flows from nifi-2.0 version to 
> minifi 2.0 version.
> It is only possible to export template from nifi 1.2.x version and convert it 
> into json format for minifi-2.0 version.
> for file differences please see attached files.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] NIFI-12644:Exported json flows does not match minifi json schema resolved by adding new method Transform to convert Nifi Flow json to MiNifi flow json [nifi]

2024-02-12 Thread via GitHub


AjayPremarajan opened a new pull request, #8393:
URL: https://github.com/apache/nifi/pull/8393

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-12735) Execute flow analysis before committing flow into Registry

2024-02-12 Thread Simon Bence (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-12735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Bence updated NIFI-12735:
---
Status: Patch Available  (was: In Progress)

> Execute flow analysis before committing flow into Registry
> --
>
> Key: NIFI-12735
> URL: https://issues.apache.org/jira/browse/NIFI-12735
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Simon Bence
>Assignee: Simon Bence
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Based on https://lists.apache.org/thread/hsg2ggj9p47lvj5m00okkj0ok58zdoqp
> When committing a flow into a Registry, it would be beneficial to have the 
> opportunity to execute the existing flow analysis rules and potentially 
> interrupt the commit.
> The change aims for:
> - Execute existing flow analysis rules out of the scheduled times
> - Gracefully resject commit when the flow does not meet the requirements
> - Providing a toggle to turn on or off the feature
> - In case of the feature is inactive or no rules are set, the Registry 
> handling behaviour should not change*
> The change does not aim for:
> - RegistryClient level adjustments
> - Using different rules set or other kind of validation methods
> - Providing support for the 1.x line
> {*}
> Expect this following branch: 
> https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java#L5028
> As with the usage of this feature, failing snapshot commits will be more 
> frequent and I consider "lingering" flow definitions without snapshot 
> misleading for users.
> The following test cases describe the proposed behaviour in detail:
> TC1.1 Adding flow with rules violation
> GIVEN a `DisallowComponentType` flow analysis rule, disallowing 
> `GenerateFlowFile`
> AND NiFi property `nifi.registry.check.for.rules.violation` is true
> AND process group G1 containing a `GenerateFlowFile`
> AND violation appears as validation failure
> WHEN the user tries to add G1 under version control, using registry R1
> THEN the UI displays the following error message "*Cannot store flow version 
> to registry due to rules violations*"
> AND the flow will not appear in registry R1
> AND the UI will show G1 as un-versioned
> AND NiFi node will see G1 as un-versioned
> TC1.2 Adding flow with rules violation before scheduled
> GIVEN a `DisallowComponentType` flow analysis rule, disallowing 
> `GenerateFlowFile`
> AND NiFi property `nifi.registry.check.for.rules.violation` is true
> AND process group G1 containing a `GenerateFlowFile`
> AND violation does not appear in UI
> WHEN the user tries to add G1 under version control, using registry R1
> THEN the UI displays the following error message "*Cannot store flow version 
> to registry due to rules violations*"
> AND the flow will not appear in registry R1
> AND the UI will show G1 as un-versioned
> AND NiFi node will see G1 as un-versioned
> TC1.3 When turned off violating flows will be added
> GIVEN a `DisallowComponentType` flow analysis rule, disallowing 
> `GenerateFlowFile`
> AND NiFi property `nifi.registry.check.for.rules.violation` is fals
> AND process group G1 containing a `GenerateFlowFile`
> AND violation appears as validation failure
> WHEN the user tries to add G1 under version control, using registry R1
> THEN the flow is committed normally
> TC1.4 Adding version with rules violation (when the rule is new)
> GIVEN NiFi property `nifi.registry.check.for.rules.violation` is true
> AND process group G1 containing a `GenerateFlowFile`
> AND process group G1 is under version control
> AND `LogAttribute` processor is added (not committed to the registry)
> GIVEN adding a `DisallowComponentType` flow analysis rule, disallowing 
> `GenerateFlowFile`
> AND  the user tries to add G1 under version control, using registry R1
> THEN the UI displays the following error message "*Cannot store flow version 
> to registry due to rules violations*"
> AND the flow will not appear in registry R1
> AND the UI will show G1 as un-versioned
> AND NiFi node will see G1 as un-versioned
> TC1.5 Adding version with rules violation (when the violation is new)
> GIVEN a `DisallowComponentType` flow analysis rule, disallowing 
> `GenerateFlowFile`
> AND NiFi property `nifi.registry.check.for.rules.violation` is true
> AND process group G1 is under version control
> AND `GenerateFlowFile` processor is added (not committed to the registry)
> WHEN the user tries to add new version of G1 to registry R1
> THEN the UI displays the following error message "*Cannot store flow version 
> to registry due to rules violations*"
> AND the flow will not appear in registry R1
> AND the UI will show G1 as