Re: [PR] NIFI-12350 Implement Azure Active Directory authentication option whe… [nifi]
exceptionfactory commented on PR #8023: URL: https://github.com/apache/nifi/pull/8023#issuecomment-1998910025 Thanks again for the work on this change @vuong2407. In light of the current conflicts, and the work in progress on refactored Kafka Processors for [NIFI-11259](https://issues.apache.org/jira/browse/NIFI-11259) now in review, it would be better to revisit this implementation after the refactored Processors have been reviewed and merged. That should provide a much better baseline for integrating alternative authentication strategies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12350 Implement Azure Active Directory authentication option whe… [nifi]
exceptionfactory closed pull request #8023: NIFI-12350 Implement Azure Active Directory authentication option whe… URL: https://github.com/apache/nifi/pull/8023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12887) Additional ways for handling Strings as binary in PutDatabaseRecord
[ https://issues.apache.org/jira/browse/NIFI-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12887. - Fix Version/s: 2.0.0 Resolution: Fixed > Additional ways for handling Strings as binary in PutDatabaseRecord > --- > > Key: NIFI-12887 > URL: https://issues.apache.org/jira/browse/NIFI-12887 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Fix For: 2.0.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > PutDatabaseRecord expects byte arrays when inserting into a binary type > column (blob, binary etc.) > Or if String is encountered it uses a UTF8 String -> byte conversion. > Using hex-string or base64-encoding to represent binary data as string is > fairly common so this Jira is about adding these capabilities to the > processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12887) Additional ways for handling Strings as binary in PutDatabaseRecord
[ https://issues.apache.org/jira/browse/NIFI-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827359#comment-17827359 ] ASF subversion and git services commented on NIFI-12887: Commit 42bd5243bb3e32b21559f628126d1795e11c5c30 in nifi's branch refs/heads/main from Tamas Palfy [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=42bd5243bb ] NIFI-12887 Added Binary String Format property to PutDatabaseRecord - Supports handling Strings as hexadecimal character sequences or base64-encoded binary data when inserting into a binary type column This closes #8493 Signed-off-by: David Handermann > Additional ways for handling Strings as binary in PutDatabaseRecord > --- > > Key: NIFI-12887 > URL: https://issues.apache.org/jira/browse/NIFI-12887 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > PutDatabaseRecord expects byte arrays when inserting into a binary type > column (blob, binary etc.) > Or if String is encountered it uses a UTF8 String -> byte conversion. > Using hex-string or base64-encoding to represent binary data as string is > fairly common so this Jira is about adding these capabilities to the > processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12887 Additional ways for handling Strings as binary in PutDatabaseRecord [nifi]
exceptionfactory closed pull request #8493: NIFI-12887 Additional ways for handling Strings as binary in PutDatabaseRecord URL: https://github.com/apache/nifi/pull/8493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12901) Remove time units in description of properties that specify a time period
[
https://issues.apache.org/jira/browse/NIFI-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12901.
-
Fix Version/s: 2.0.0
1.26.0
Resolution: Fixed
> Remove time units in description of properties that specify a time period
> -
>
> Key: NIFI-12901
> URL: https://issues.apache.org/jira/browse/NIFI-12901
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Trivial
> Fix For: 2.0.0, 1.26.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In some properties that specify a time period, like {{Max Connection
> Lifetime}} of {{DBCPProperties}}, the documentation claims that the property
> value is to be defined in a concrete time unit, like milliseconds.
> However, those properties use the
> {{StandardValidators.TIME_PERIOD_VALIDATOR}}, or a derivative thereof, which
> supports to define the period in a plethora of time units.
> The documentation should be changed accordingly, to clarify that the
> properties do not require an integer value of a static time unit but rather
> the declaration of a time period including a time unit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12901) Remove time units in description of properties that specify a time period
[
https://issues.apache.org/jira/browse/NIFI-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12901:
Priority: Trivial (was: Major)
> Remove time units in description of properties that specify a time period
> -
>
> Key: NIFI-12901
> URL: https://issues.apache.org/jira/browse/NIFI-12901
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Trivial
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In some properties that specify a time period, like {{Max Connection
> Lifetime}} of {{DBCPProperties}}, the documentation claims that the property
> value is to be defined in a concrete time unit, like milliseconds.
> However, those properties use the
> {{StandardValidators.TIME_PERIOD_VALIDATOR}}, or a derivative thereof, which
> supports to define the period in a plethora of time units.
> The documentation should be changed accordingly, to clarify that the
> properties do not require an integer value of a static time unit but rather
> the declaration of a time period including a time unit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12901) Remove time units in description of properties that specify a time period
[
https://issues.apache.org/jira/browse/NIFI-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827352#comment-17827352
]
ASF subversion and git services commented on NIFI-12901:
Commit 4093fc1ab056c524f7732089adaeb7d8547d9e48 in nifi's branch
refs/heads/support/nifi-1.x from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4093fc1ab0 ]
NIFI-12901 Removed time units in description of time period properties
This closes #8504
Signed-off-by: David Handermann
(cherry picked from commit 27fa595b25c848bc06579748c17be2b0bf6dcd2e)
> Remove time units in description of properties that specify a time period
> -
>
> Key: NIFI-12901
> URL: https://issues.apache.org/jira/browse/NIFI-12901
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In some properties that specify a time period, like {{Max Connection
> Lifetime}} of {{DBCPProperties}}, the documentation claims that the property
> value is to be defined in a concrete time unit, like milliseconds.
> However, those properties use the
> {{StandardValidators.TIME_PERIOD_VALIDATOR}}, or a derivative thereof, which
> supports to define the period in a plethora of time units.
> The documentation should be changed accordingly, to clarify that the
> properties do not require an integer value of a static time unit but rather
> the declaration of a time period including a time unit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12901) Remove time units in description of properties that specify a time period
[
https://issues.apache.org/jira/browse/NIFI-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827350#comment-17827350
]
ASF subversion and git services commented on NIFI-12901:
Commit 27fa595b25c848bc06579748c17be2b0bf6dcd2e in nifi's branch
refs/heads/main from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=27fa595b25 ]
NIFI-12901 Removed time units in description of time period properties
This closes #8504
Signed-off-by: David Handermann
> Remove time units in description of properties that specify a time period
> -
>
> Key: NIFI-12901
> URL: https://issues.apache.org/jira/browse/NIFI-12901
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In some properties that specify a time period, like {{Max Connection
> Lifetime}} of {{DBCPProperties}}, the documentation claims that the property
> value is to be defined in a concrete time unit, like milliseconds.
> However, those properties use the
> {{StandardValidators.TIME_PERIOD_VALIDATOR}}, or a derivative thereof, which
> supports to define the period in a plethora of time units.
> The documentation should be changed accordingly, to clarify that the
> properties do not require an integer value of a static time unit but rather
> the declaration of a time period including a time unit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12901 Remove time units in description of properties that specify a time period [nifi]
exceptionfactory closed pull request #8504: NIFI-12901 Remove time units in description of properties that specify a time period URL: https://github.com/apache/nifi/pull/8504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12907) Update to Groovy 4.0.20
[ https://issues.apache.org/jira/browse/NIFI-12907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12907. - Resolution: Fixed > Update to Groovy 4.0.20 > --- > > Key: NIFI-12907 > URL: https://issues.apache.org/jira/browse/NIFI-12907 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12906) Upgrade ZooKeeper to 3.9.2
[ https://issues.apache.org/jira/browse/NIFI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12906: Summary: Upgrade ZooKeeper to 3.9.2 (was: Upgrade zookeeper to move past server side issues in CVE-2024-23944) > Upgrade ZooKeeper to 3.9.2 > -- > > Key: NIFI-12906 > URL: https://issues.apache.org/jira/browse/NIFI-12906 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12906) Upgrade ZooKeeper to 3.9.2
[ https://issues.apache.org/jira/browse/NIFI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12906. - Resolution: Fixed > Upgrade ZooKeeper to 3.9.2 > -- > > Key: NIFI-12906 > URL: https://issues.apache.org/jira/browse/NIFI-12906 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12906) Upgrade zookeeper to move past server side issues in CVE-2024-23944
[ https://issues.apache.org/jira/browse/NIFI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827348#comment-17827348 ] David Handermann commented on NIFI-12906: - ZooKeeper 3.9.2 resolves server-side vulnerability CVE-2024-23944. > Upgrade zookeeper to move past server side issues in CVE-2024-23944 > --- > > Key: NIFI-12906 > URL: https://issues.apache.org/jira/browse/NIFI-12906 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12906) Upgrade zookeeper to move past server side issues in CVE-2024-23944
[ https://issues.apache.org/jira/browse/NIFI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827347#comment-17827347 ] ASF subversion and git services commented on NIFI-12906: Commit d3738da44895eac7d19a86bf28f60e113907a729 in nifi's branch refs/heads/support/nifi-1.x from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d3738da448 ] NIFI-12906 Upgraded ZooKeeper from 3.9.1 to 3.9.2 This closes #8506 Signed-off-by: David Handermann (cherry picked from commit 33a28dfa48e10025d02a79e7ddbd69d865cb717a) > Upgrade zookeeper to move past server side issues in CVE-2024-23944 > --- > > Key: NIFI-12906 > URL: https://issues.apache.org/jira/browse/NIFI-12906 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12906) Upgrade zookeeper to move past server side issues in CVE-2024-23944
[ https://issues.apache.org/jira/browse/NIFI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827343#comment-17827343 ] ASF subversion and git services commented on NIFI-12906: Commit 33a28dfa48e10025d02a79e7ddbd69d865cb717a in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=33a28dfa48 ] NIFI-12906 Upgraded ZooKeeper from 3.9.1 to 3.9.2 This closes #8506 Signed-off-by: David Handermann > Upgrade zookeeper to move past server side issues in CVE-2024-23944 > --- > > Key: NIFI-12906 > URL: https://issues.apache.org/jira/browse/NIFI-12906 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12907) Update to Groovy 4.0.20
[ https://issues.apache.org/jira/browse/NIFI-12907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827344#comment-17827344 ] ASF subversion and git services commented on NIFI-12907: Commit 8c264d22f82efea0efd81715371c1437ac57e565 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8c264d22f8 ] NIFI-12907 Upgraded Groovy from 4.0.19 to 4.0.20 This closes #8508 Signed-off-by: David Handermann > Update to Groovy 4.0.20 > --- > > Key: NIFI-12907 > URL: https://issues.apache.org/jira/browse/NIFI-12907 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12907 bumped groovy version [nifi]
exceptionfactory closed pull request #8508: NIFI-12907 bumped groovy version URL: https://github.com/apache/nifi/pull/8508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12906 bumped zookeeper version [nifi]
exceptionfactory closed pull request #8506: NIFI-12906 bumped zookeeper version URL: https://github.com/apache/nifi/pull/8506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
bobpaulin commented on PR #8510: URL: https://github.com/apache/nifi/pull/8510#issuecomment-1998889749 I've applied your recommendations to the PR @exceptionfactory. Thanks for the knowledge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
bobpaulin commented on code in PR #8510:
URL: https://github.com/apache/nifi/pull/8510#discussion_r1525719255
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfigMock;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookupMock;
+
+@BeforeEach
+public void setUp() {
+virtualEnvHome = new File("target/virtualEnvHome");
+virtualEnvHome.mkdirs();
Review Comment:
Thanks hadn't used this one before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
exceptionfactory commented on code in PR #8510:
URL: https://github.com/apache/nifi/pull/8510#discussion_r1525660435
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/main/java/org/apache/nifi/py4j/PythonProcess.java:
##
@@ -267,6 +264,21 @@ private Process launchPythonProcess(final int
listeningPort, final String authTo
return processBuilder.start();
}
+String resolvePythonCommand() throws IOException {
+final File pythonCmdFile = new File(processConfig.getPythonCommand());
+final String pythonCmd = pythonCmdFile.getName();
+File[] virtualEnvFileList = virtualEnvHome.listFiles((file, name) ->
file.isDirectory() && (name.equals("bin") || name.equals("Scripts")));
Review Comment:
Recommend adding a comment regarding common names, and declaring the result
as `final`:
```suggestion
// Find command directories according to standard Python venv
conventions
final File[] virtualEnvCommandDirectories =
virtualEnvHome.listFiles((file, name) -> file.isDirectory() &&
(name.equals("bin") || name.equals("Scripts")));
```
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfigMock;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookupMock;
+
+@BeforeEach
+public void setUp() {
+virtualEnvHome = new File("target/virtualEnvHome");
+virtualEnvHome.mkdirs();
+MockitoAnnotations.openMocks(this);
Review Comment:
Instead of this method, the `@ExtendWith(MockitoExtension.class)` annotation
should be used at the class level.
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfigMock;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookupMock;
+
+@BeforeEach
+public void setUp() {
+
[PR] NIFI-12514: Add windows support for python venv [nifi]
bobpaulin opened a new pull request, #8510: URL: https://github.com/apache/nifi/pull/8510 # Summary [NIFI-12514](https://issues.apache.org/jira/browse/NIFI-12514) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. Unit Tests Full build and test on windows. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12908) Provide Scripts for Powershell
[
https://issues.apache.org/jira/browse/NIFI-12908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fredrick Eisele updated NIFI-12908:
---
Description:
There are scripts for configuring NiFi \{ nifi.sh , nifi.cmd }.
Provide scripts for Powershell as well.
I ran into documentation issues in
[https://nifi.apache.org/documentation/nifi-2.0.0-M2/html/administration-guide.html#how-to-install-and-start-nifi]
* nifi.cmd is not mentioned in the documentation.
* it suggests setting the nifi.sensitive.props.key but it takes some digging
to discover that it needs to be at least 12 characters
[https://nifi.apache.org/documentation/nifi-2.0.0-M2/html/administration-guide.html#property-encryption-algorithms]
(some places it states 10 is recommended (but not required))
Where is a good place to report such issues?
I made a pull-request with a reference implementation.
https://github.com/apache/nifi/pull/8509
was:
There are scripts for configuring NiFi \{ nifi.sh , nifi.cmd }.
Provide scripts for Powershell as well.
I ran into documentation issues in
[https://nifi.apache.org/documentation/nifi-2.0.0-M2/html/administration-guide.html#how-to-install-and-start-nifi]
* nifi.cmd is not mentioned in the documentation.
* it suggests setting the nifi.sensitive.props.key but it takes some digging to
discover that it needs to be at least 12 characters
[https://nifi.apache.org/documentation/nifi-2.0.0-M2/html/administration-guide.html#property-encryption-algorithms]
(some places it states 10 is recommended (but not required))
Where is a good place to report such issues?
> Provide Scripts for Powershell
> --
>
> Key: NIFI-12908
> URL: https://issues.apache.org/jira/browse/NIFI-12908
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 2.0.0-M2
>Reporter: Fredrick Eisele
>Priority: Major
>
> There are scripts for configuring NiFi \{ nifi.sh , nifi.cmd }.
> Provide scripts for Powershell as well.
> I ran into documentation issues in
> [https://nifi.apache.org/documentation/nifi-2.0.0-M2/html/administration-guide.html#how-to-install-and-start-nifi]
> * nifi.cmd is not mentioned in the documentation.
> * it suggests setting the nifi.sensitive.props.key but it takes some digging
> to discover that it needs to be at least 12 characters
> [https://nifi.apache.org/documentation/nifi-2.0.0-M2/html/administration-guide.html#property-encryption-algorithms]
> (some places it states 10 is recommended (but not required))
> Where is a good place to report such issues?
> I made a pull-request with a reference implementation.
> https://github.com/apache/nifi/pull/8509
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] provide powershell versions of the nifi-env.cmd and nifi.cmd [nifi]
phreed opened a new pull request, #8509: URL: https://github.com/apache/nifi/pull/8509 # Summary [NIFI-12908](https://issues.apache.org/jira/browse/NIFI-12908) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12908) Provide Scripts for Powershell
Fredrick Eisele created NIFI-12908:
--
Summary: Provide Scripts for Powershell
Key: NIFI-12908
URL: https://issues.apache.org/jira/browse/NIFI-12908
Project: Apache NiFi
Issue Type: Improvement
Components: Configuration
Affects Versions: 2.0.0-M2
Reporter: Fredrick Eisele
There are scripts for configuring NiFi \{ nifi.sh , nifi.cmd }.
Provide scripts for Powershell as well.
I ran into documentation issues in
[https://nifi.apache.org/documentation/nifi-2.0.0-M2/html/administration-guide.html#how-to-install-and-start-nifi]
* nifi.cmd is not mentioned in the documentation.
* it suggests setting the nifi.sensitive.props.key but it takes some digging to
discover that it needs to be at least 12 characters
[https://nifi.apache.org/documentation/nifi-2.0.0-M2/html/administration-guide.html#property-encryption-algorithms]
(some places it states 10 is recommended (but not required))
Where is a good place to report such issues?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12907 bumped groovy version [nifi]
joewitt opened a new pull request, #8508: URL: https://github.com/apache/nifi/pull/8508 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12902) Migrate to @angular-devkit/build-angular:application
[ https://issues.apache.org/jira/browse/NIFI-12902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12902: --- Status: Patch Available (was: Open) > Migrate to @angular-devkit/build-angular:application > > > Key: NIFI-12902 > URL: https://issues.apache.org/jira/browse/NIFI-12902 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Migrate to the latest builder to try avoid sporadic webpack build issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12902: Migrating to @angular-devkit/build-angular:application [nifi]
mcgilman opened a new pull request, #8507: URL: https://github.com/apache/nifi/pull/8507 NIFI-12902: - Migrating to @angular-devkit/build-angular:application to avoid and avoid sporadic webpack build issues. - Updating roboto dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12822) BUG - light mode sorting arrows are too dark
[ https://issues.apache.org/jira/browse/NIFI-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12822: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > BUG - light mode sorting arrows are too dark > > > Key: NIFI-12822 > URL: https://issues.apache.org/jira/browse/NIFI-12822 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0 > > Attachments: Screenshot 2024-02-20 at 9.50.36 AM.png > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12894) Replace .nifi-button with mat-icon-button
[ https://issues.apache.org/jira/browse/NIFI-12894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827276#comment-17827276 ] Matt Gilman commented on NIFI-12894: https://github.com/apache/nifi/pull/8499 > Replace .nifi-button with mat-icon-button > - > > Key: NIFI-12894 > URL: https://issues.apache.org/jira/browse/NIFI-12894 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12894) Replace .nifi-button with mat-icon-button
[ https://issues.apache.org/jira/browse/NIFI-12894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12894: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Replace .nifi-button with mat-icon-button > - > > Key: NIFI-12894 > URL: https://issues.apache.org/jira/browse/NIFI-12894 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12906 bumped zookeeper version [nifi]
joewitt opened a new pull request, #8506: URL: https://github.com/apache/nifi/pull/8506 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12907) Update to Groovy 4.0.20
Joe Witt created NIFI-12907: --- Summary: Update to Groovy 4.0.20 Key: NIFI-12907 URL: https://issues.apache.org/jira/browse/NIFI-12907 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt Fix For: 2.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12906) Upgrade zookeeper to move past server side issues in CVE-2024-23944
[ https://issues.apache.org/jira/browse/NIFI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12906: Fix Version/s: 2.0.0 1.26.0 > Upgrade zookeeper to move past server side issues in CVE-2024-23944 > --- > > Key: NIFI-12906 > URL: https://issues.apache.org/jira/browse/NIFI-12906 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0, 1.26.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12822) BUG - light mode sorting arrows are too dark
[ https://issues.apache.org/jira/browse/NIFI-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827274#comment-17827274 ] ASF subversion and git services commented on NIFI-12822: Commit 69e7a884a3426dd99d7bfaabb014d3a5a2f61a47 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=69e7a884a3 ] [NIFI-12822] table, border, theming updates (#8499) * [NIFI-12822] table, border, theming updates * remove nifi-button and replace with mat-icon-button * Update nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss Co-authored-by: James Mingardi-Elliott * Update nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/operation-control/operation-control.component.scss Co-authored-by: James Mingardi-Elliott * Update nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/navigation-control/navigation-control.component.scss Co-authored-by: James Mingardi-Elliott * review feedback * final touches - Co-authored-by: James Mingardi-Elliott This closes #8499 > BUG - light mode sorting arrows are too dark > > > Key: NIFI-12822 > URL: https://issues.apache.org/jira/browse/NIFI-12822 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-02-20 at 9.50.36 AM.png > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12906) Upgrade zookeeper to move past server side issues in CVE-2024-23944
Joe Witt created NIFI-12906: --- Summary: Upgrade zookeeper to move past server side issues in CVE-2024-23944 Key: NIFI-12906 URL: https://issues.apache.org/jira/browse/NIFI-12906 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
mcgilman merged PR #8499: URL: https://github.com/apache/nifi/pull/8499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12905) UI - page header color
Scott Aslan created NIFI-12905: -- Summary: UI - page header color Key: NIFI-12905 URL: https://issues.apache.org/jira/browse/NIFI-12905 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: Screenshot 2024-03-14 at 5.02.50 PM.png, Screenshot 2024-03-14 at 5.03.01 PM.png, Screenshot 2024-03-14 at 5.03.24 PM.png Currently we have the same style defined in several different places and all used for the header on the different pages of the SPA. These can be combined into a single `.page-header` style and applied consistently throughout the app. !Screenshot 2024-03-14 at 5.03.24 PM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12904) [BUG] nfEditor width has a regression
Scott Aslan created NIFI-12904: -- Summary: [BUG] nfEditor width has a regression Key: NIFI-12904 URL: https://issues.apache.org/jira/browse/NIFI-12904 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Somewhere along the way we lost or overrode the styles for the nfEditor width. This needs to be restored. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12903) UI - update disabled/enabled drag/drop colors
Scott Aslan created NIFI-12903: -- Summary: UI - update disabled/enabled drag/drop colors Key: NIFI-12903 URL: https://issues.apache.org/jira/browse/NIFI-12903 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan The connection prioritizers and the parameter context inheritance drag and drop controls need to update the background color for enabled and disabled states. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
scottyaslan commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525468231
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/edit-tenant/edit-tenant-dialog.component.html:
##
@@ -37,7 +37,7 @@ {{ isNew ? 'Add' : 'Edit' }} {{ isUser ?
'User' : 'User Gro
@if (isUser) {
Member of
-
+
Review Comment:
restored
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/edit-tenant/edit-tenant-dialog.component.html:
##
@@ -48,7 +48,7 @@ {{ isNew ? 'Add' : 'Edit' }} {{ isUser ?
'User' : 'User Gro
} @else {
Members
-
+
Review Comment:
restored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
scottyaslan commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525467793
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.html:
##
@@ -72,7 +72,7 @@
} @else {
@if (asBulletinEvent(item); as event) {
-
+
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
scottyaslan commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525467183
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/connection/prioritizers/prioritizers.component.scss:
##
@@ -17,14 +17,10 @@
.prioritizers {
.prioritizers-list {
-min-height: 66px;
+min-height: 74px;
border-radius: 4px;
overflow: hidden;
display: block;
-
-.cdk-drag-disabled {
-cursor: not-allowed;
-}
Review Comment:
restored
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenant-to-policy-dialog.component.html:
##
@@ -33,7 +33,7 @@ Add Users/Groups To Policy
@if (filteredUserGroups.length > 0) {
User Groups
-
+
Review Comment:
restored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
scottyaslan commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525466946
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenant-to-policy-dialog.component.html:
##
@@ -21,7 +21,7 @@ Add Users/Groups To Policy
@if (filteredUsers.length > 0) {
Users
-
+
Review Comment:
restored
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-inheritance/parameter-context-inheritance.component.scss:
##
@@ -17,14 +17,10 @@
.parameter-context-inheritance {
.parameter-context-inheritance-list {
-min-height: 66px;
+min-height: 74px;
border-radius: 4px;
overflow: hidden;
display: block;
-
-.cdk-drag-disabled {
-cursor: not-allowed;
-}
Review Comment:
restored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
mcgilman commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525421743
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.html:
##
@@ -72,7 +72,7 @@
} @else {
@if (asBulletinEvent(item); as event) {
-
+
Review Comment:
I don't see this class defined anyplace.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenant-to-policy-dialog.component.html:
##
@@ -21,7 +21,7 @@ Add Users/Groups To Policy
@if (filteredUsers.length > 0) {
Users
-
+
Review Comment:
We the intention to remove the border here? Or was something meant to
replace it?
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/connection/prioritizers/prioritizers.component.scss:
##
@@ -17,14 +17,10 @@
.prioritizers {
.prioritizers-list {
-min-height: 66px;
+min-height: 74px;
border-radius: 4px;
overflow: hidden;
display: block;
-
-.cdk-drag-disabled {
-cursor: not-allowed;
-}
Review Comment:
With this style removed, the user is no longer shown the `not-allowed`
cursor when the prioritizers control is disabled.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss:
##
@@ -95,6 +95,10 @@
fill: $warn-palette-lighter;
}
+.warn-default {
+fill: $warn-palette-default;
+}
+
Review Comment:
I think `.warn-default` is already defined in this file below.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-inheritance/parameter-context-inheritance.component.scss:
##
@@ -17,14 +17,10 @@
.parameter-context-inheritance {
.parameter-context-inheritance-list {
-min-height: 66px;
+min-height: 74px;
border-radius: 4px;
overflow: hidden;
display: block;
-
-.cdk-drag-disabled {
-cursor: not-allowed;
-}
Review Comment:
With this style removed, the user is no longer shown the `not-allowed`
cursor when the parameter context inheritance control is disabled.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenant-to-policy-dialog.component.html:
##
@@ -33,7 +33,7 @@ Add Users/Groups To Policy
@if (filteredUserGroups.length > 0) {
User Groups
-
+
Review Comment:
We the intention to remove the border here? Or was something meant to
replace it?
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/edit-tenant/edit-tenant-dialog.component.html:
##
@@ -37,7 +37,7 @@ {{ isNew ? 'Add' : 'Edit' }} {{ isUser ?
'User' : 'User Gro
@if (isUser) {
Member of
-
+
Review Comment:
This border was removed.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/edit-tenant/edit-tenant-dialog.component.html:
##
@@ -48,7 +48,7 @@ {{ isNew ? 'Add' : 'Edit' }} {{ isUser ?
'User' : 'User Gro
} @else {
Members
-
+
Review Comment:
This border was removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-6379: Added SSL context to PutSNS, DeleteSQS, GetSQS, and PutSQS [nifi]
Freedom9339 opened a new pull request, #8505: URL: https://github.com/apache/nifi/pull/8505 # Summary [NIFI-6379](https://issues.apache.org/jira/browse/NIFI-6379) - Added SSL Context Service to PutSNS, DeleteSQS, GetSQS, and PutSQS. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [X] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12854: Add S3 user metadata via flowfile attributes [nifi]
gforeman02 commented on PR #8477:
URL: https://github.com/apache/nifi/pull/8477#issuecomment-1998298309
@markap14 i created a custom s3 nar with the following mod:
```
final Map userMetadata = new HashMap<>();
for (final Entry entry :
context.getProperties().entrySet()) {
if (entry.getKey().isDynamic()) {
final String value = context.getProperty(
entry.getKey()).evaluateAttributeExpressions(ff).getValue();
if( "metadata.json".equals(entry.getKey().getName())){
ObjectReader reader = new ObjectMapper().readerFor(Map.class);
Map map = reader.readValue(value);
userMetadata.putAll(map);
} else {
userMetadata.put(entry.getKey().getName(), value);
}
}
}
```
I am happy to modify this PR and resubmit it for consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… [nifi]
emiliosetiadarma commented on code in PR #8501:
URL: https://github.com/apache/nifi/pull/8501#discussion_r1525379676
##
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/StandardPutKuduResult.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.kudu;
+
+import org.apache.kudu.client.Operation;
+import org.apache.kudu.client.RowError;
+import org.apache.nifi.flowfile.FlowFile;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class StandardPutKuduResult extends PutKuduResult {
+private final Map operationFlowFileMap;
+private final List pendingRowErrors;
+private final Map> flowFileRowErrorsMap;
+
+public StandardPutKuduResult() {
+super();
+this.operationFlowFileMap = new HashMap<>();
+this.pendingRowErrors = new ArrayList<>();
+this.flowFileRowErrorsMap = new HashMap<>();
+}
+
+@Override
+public void recordOperation(final Operation operation) {
+operationFlowFileMap.put(operation, flowFile);
+}
+
+@Override
+public void addError(final RowError rowError) {
+// When this class is used to store results from processing FlowFiles,
the FlushMode
+// is set to AUTO_FLUSH_BACKGROUND or MANUAL_FLUSH. In either case, we
won't know which
+// FlowFile/Record we are currently processing as the RowErrors are
obtained from the KuduSession
+// post-processing of the FlowFile/Record
+this.pendingRowErrors.add(rowError);
+}
+
+@Override
+public void resolveFlowFileToRowErrorAssociations() {
+flowFileRowErrorsMap.putAll(pendingRowErrors.stream()
+.filter(e -> operationFlowFileMap.get(e.getOperation()) !=
null)
+.collect(
+Collectors.groupingBy(e ->
operationFlowFileMap.get(e.getOperation()))
+)
+);
+
+pendingRowErrors.clear();
+}
+
+@Override
+public boolean hasRowErrorsOrFailures() {
+if (!flowFileFailures.isEmpty()) {
+return true;
+}
+
+for (final Map.Entry> entry :
flowFileRowErrorsMap.entrySet()) {
+if (!entry.getValue().isEmpty()) {
+return true;
+}
+}
+
+return false;
Review Comment:
Will make the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-12902) Migrate to @angular-devkit/build-angular:application
Matt Gilman created NIFI-12902: -- Summary: Migrate to @angular-devkit/build-angular:application Key: NIFI-12902 URL: https://issues.apache.org/jira/browse/NIFI-12902 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman Fix For: 2.0.0 Migrate to the latest builder to try avoid sporadic webpack build issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… [nifi]
emiliosetiadarma commented on code in PR #8501:
URL: https://github.com/apache/nifi/pull/8501#discussion_r1525376745
##
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/PutKuduResult.java:
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.kudu;
+
+import org.apache.kudu.client.Operation;
+import org.apache.kudu.client.RowError;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.serialization.record.Record;
+
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+public abstract class PutKuduResult {
+protected FlowFile flowFile;
+protected final Map flowFileFailures;
+private final Set processedFlowFiles;
+private final Map processedRecords;
+
+public PutKuduResult() {
+this.flowFile = null;
+
+this.flowFileFailures = new HashMap<>();
+this.processedFlowFiles = new HashSet<>();
+this.processedRecords = new HashMap<>();
+}
+
+public void setFlowFile(final FlowFile flowFile) {
+this.flowFile = flowFile;
+processedFlowFiles.add(flowFile);
+}
+
+public Set getProcessedFlowFiles() {
+return this.processedFlowFiles;
+}
+
+public int getProcessedRecordsForFlowFile(final FlowFile flowFile) {
+return this.processedRecords.getOrDefault(flowFile, 0);
+}
+
+/**
+ * Increments the number of {@link Record}s that has been successfully
processed for this {@link FlowFile}
+ */
+public void incrementProcessedRecordsForFlowFile() {
+final int newCount = this.processedRecords.getOrDefault(flowFile, 0) +
1;
+this.processedRecords.put(flowFile, newCount);
+}
+
+/**
+ * Records an {@link Operation} being processed for a specific {@link
FlowFile}
+ * @param operation the {@link Operation} to record
+ */
+public abstract void recordOperation(final Operation operation);
+
+/**
+ * Records a {@link RowError} for the particular {@link FlowFile} that's
being processed
+ * @param rowError the {@link RowError} to add
+ */
+public abstract void addError(final RowError rowError);
+
+/**
+ * Records a {@link List} of {@link RowError}s for the particular {@link
FlowFile} that's being processed
+ * @param rowErrors the {@link List} of {@link RowError}s to add
+ */
+public void addErrors(final List rowErrors) {
+for (final RowError rowError : rowErrors) {
+addError(rowError);
+}
+}
+
+/**
+ * Records a failure (an {@link Exception} or a {@link RowError}) for the
particular {@link FlowFile} that's being processed.
+ * A failure is defined as anything that stops the processing of the
records in a {@link FlowFile}
+ * @param failure the {@link Exception} or {@link RowError} to add
+ */
+public void addFailure(final Object failure) {
+if (flowFileFailures.containsKey(flowFile)) {
+throw new IllegalStateException("A failure has already previously
occurred while processing FlowFile.");
+}
+flowFileFailures.put(flowFile, failure);
+}
+
+
+/**
+ * Resolves the associations between {@link FlowFile} and the {@link
RowError}s that occurred
+ * while processing them. This is only applicable in batch sesssion
flushes, namely when
+ * using the {@code SessionConfiguration.FlushMode.AUTO_FLUSH_BACKGROUND}
and
+ * {@code SessionConfiguration.FlushMode.MANUAL_FLUSH} flush modes.
Otherwise, this
+ * function should be a no-op. This function should only be called once
finished with processing
+ * all {@link FlowFile}s in a batch.
+ */
+public void resolveFlowFileToRowErrorAssociations() {
+return;
+}
+
+/**
+ * Checks whether there was a failure (i.e. either an {@link Exception} or
{@link RowError} that happened during processing)
+ * @return {@code true} if there was a {@link Exception} or a {@link
RowError} that happened during processing, {@code false} otherwise
+ */
+public abstract boolean
Re: [PR] NIFI-12735 Adding the option to execute flow analysis before committing snapshot to registry [nifi]
tpalfy commented on code in PR #8377:
URL: https://github.com/apache/nifi/pull/8377#discussion_r1525306917
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/registry/flow/FlowAnalyzingRegistryClientNode.java:
##
@@ -0,0 +1,452 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.registry.flow;
+
+import org.apache.nifi.authorization.Resource;
+import org.apache.nifi.authorization.resource.Authorizable;
+import org.apache.nifi.bundle.BundleCoordinate;
+import org.apache.nifi.components.ConfigurableComponent;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.validation.ValidationState;
+import org.apache.nifi.components.validation.ValidationStatus;
+import org.apache.nifi.controller.LoggableComponent;
+import org.apache.nifi.controller.PropertyConfiguration;
+import org.apache.nifi.controller.TerminationAwareLogger;
+import org.apache.nifi.controller.flow.FlowManager;
+import org.apache.nifi.controller.flowanalysis.FlowAnalyzer;
+import org.apache.nifi.controller.service.ControllerServiceProvider;
+import org.apache.nifi.flow.ExternalControllerServiceReference;
+import org.apache.nifi.flow.ParameterProviderReference;
+import org.apache.nifi.flow.VersionedParameterContext;
+import org.apache.nifi.flow.VersionedProcessGroup;
+import org.apache.nifi.groups.ProcessGroup;
+import org.apache.nifi.parameter.ParameterContext;
+import org.apache.nifi.parameter.ParameterLookup;
+import org.apache.nifi.parameter.ParameterUpdate;
+import org.apache.nifi.registry.flow.mapping.InstantiatedVersionedProcessGroup;
+import org.apache.nifi.registry.flow.mapping.NiFiRegistryFlowMapper;
+import org.apache.nifi.validation.RuleViolation;
+import org.apache.nifi.validation.RuleViolationsManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.net.URL;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import java.util.stream.Collectors;
+
+public final class FlowAnalyzingRegistryClientNode implements
FlowRegistryClientNode {
+private static final Logger LOGGER =
LoggerFactory.getLogger(FlowAnalyzingRegistryClientNode.class);
+
+private final FlowRegistryClientNode node;
+private final ControllerServiceProvider serviceProvider;
+private final FlowAnalyzer flowAnalyzer;
+private final RuleViolationsManager ruleViolationsManager;
+private final FlowManager flowManager;
+private final Supplier flowMapperSupplier;
+
+public FlowAnalyzingRegistryClientNode(
+final FlowRegistryClientNode node,
+final ControllerServiceProvider serviceProvider,
+final FlowAnalyzer flowAnalyzer,
+final RuleViolationsManager ruleViolationsManager,
+final FlowManager flowManager,
+final Supplier flowMapperSupplier
Review Comment:
I don't see a reason for this to be a Supplier. The mapper the flow analysis
requires an implementation that doesn't rely on any configuration that can
change runtime.
So we can just create it and pass on.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/registry/flow/FlowAnalyzingRegistryClientNode.java:
##
@@ -0,0 +1,452 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the
[jira] [Commented] (NIFI-6379) Add SSL Context Service Property to GetSQS Processor
[ https://issues.apache.org/jira/browse/NIFI-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827212#comment-17827212 ] Reynaldo Rea commented on NIFI-6379: The SSL Context Service will be added to PutSNS, DeleteSQS, GetSQS, and PutSQS > Add SSL Context Service Property to GetSQS Processor > > > Key: NIFI-6379 > URL: https://issues.apache.org/jira/browse/NIFI-6379 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.7.1, 1.9.2 > Environment: GetSQS Processor >Reporter: John Crooke >Assignee: Reynaldo Rea >Priority: Major > > The GetSQS processor does NOT let you choose an SSL Context Service, but > other AWS-related processors such as "FetchS3Object" do have the "SSL Context > Service" property. > > This improvement is to enable the choice of SSL Context Service for the > certificate presented and/or the truststore that will be used to trust the > SQS endpoint's certificate. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12901 Remove time units in description of properties that specify a time period [nifi]
EndzeitBegins opened a new pull request, #8504: URL: https://github.com/apache/nifi/pull/8504 # Summary [NIFI-12901](https://issues.apache.org/jira/browse/NIFI-12901) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12901) Remove time units in description of properties that specify a time period
endzeit created NIFI-12901:
--
Summary: Remove time units in description of properties that
specify a time period
Key: NIFI-12901
URL: https://issues.apache.org/jira/browse/NIFI-12901
Project: Apache NiFi
Issue Type: Improvement
Reporter: endzeit
Assignee: endzeit
In some properties that specify a time period, like {{Max Connection Lifetime}}
of {{DBCPProperties}}, the documentation claims that the property value is to
be defined in a concrete time unit, like milliseconds.
However, those properties use the {{StandardValidators.TIME_PERIOD_VALIDATOR}},
or a derivative thereof, which supports to define the period in a plethora of
time units.
The documentation should be changed accordingly, to clarify that the properties
do not require an integer value of a static time unit but rather the
declaration of a time period including a time unit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12897) Allow users to upload files/resources to nifi for use in the dataflow
[ https://issues.apache.org/jira/browse/NIFI-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827195#comment-17827195 ] Mark Payne commented on NIFI-12897: --- [~pvillard] not at the moment. I will plan to put together a Feature Proposal in the next few days. > Allow users to upload files/resources to nifi for use in the dataflow > - > > Key: NIFI-12897 > URL: https://issues.apache.org/jira/browse/NIFI-12897 > Project: Apache NiFi > Issue Type: Epic > Components: Core Framework, Core UI >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > > A common feature request that we receive is to make it easier to upload a > resource file, such as JDBC Driver JAR to nifi so that all of the nodes > receive the file. This epic is meant to capture that request -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]
sardell commented on code in PR #8273:
URL: https://github.com/apache/nifi/pull/8273#discussion_r1525292949
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js:
##
@@ -400,6 +406,556 @@
}
}
+/**
+ * The flow analysis controller.
+ */
+
+this.flowAnalysis = {
+
+/**
+ * Create the list of rule violations
+ */
+buildRuleViolationsList: function(rules, violationsAndRecs) {
+var ruleViolationCountEl = $('#rule-violation-count');
+var ruleViolationListEl = $('#rule-violations-list');
+var ruleWarningCountEl = $('#rule-warning-count');
+var ruleWarningListEl = $('#rule-warnings-list');
+var violations = violationsAndRecs.filter(function
(violation) {
+return violation.enforcementPolicy === 'ENFORCE'
+});
+var warnings = violationsAndRecs.filter(function
(violation) {
+return violation.enforcementPolicy === 'WARN'
+});
+ruleViolationCountEl.empty().text('(' + violations.length
+ ')');
+ruleWarningCountEl.empty().text('(' + warnings.length +
')');
+ruleViolationListEl.empty();
+violations.forEach(function(violation) {
+var rule = rules.find(function(rule) {
+return rule.id === violation.ruleId;
+});
+// create DOM elements
+var violationListItemEl = $('');
+var violationEl = $('');
+var violationListItemWrapperEl = $('');
+var violationRuleEl = $('');
+var violationListItemNameEl = $('');
+var violationListItemIdEl = $('');
+var violationInfoButtonEl = $('');
+
+// add text content and button data
+$(violationRuleEl).text(rule.name);
+
$(violationListItemNameEl).text(violation.subjectDisplayName);
Review Comment:
@mcgilman Quick update: @tpalfy's work has been reviewed and merged into
`main`. I've rebased this PR to include those changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-12900 Avoid unnecessary file listing in PutSFTP [nifi]
EndzeitBegins opened a new pull request, #8503: URL: https://github.com/apache/nifi/pull/8503 # Summary Adjusts `SFTPTransfer` to avoid listing whole target directory before upload in `PutSFTP`. [NIFI-12900](https://issues.apache.org/jira/browse/NIFI-12900) I'd appreciate if we could backport these changes to 1.x as well. Please let me know if I should open a separate pull-request for that. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12862) FlowAnalysisResults should not leak anauthorized component details
[ https://issues.apache.org/jira/browse/NIFI-12862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827188#comment-17827188 ] ASF subversion and git services commented on NIFI-12862: Commit c093ea54b77c816d94a23c7af19f97f96baa7d2f in nifi's branch refs/heads/main from Tamas Palfy [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c093ea54b7 ] NIFI-12862 When building FlowAnalysisRuleViolationDTO objects (in StandardNiFiServiceFacade), violating component details will be left blank when user has no read permission for that component. NIFI-12862 Expose subjectComponentType to frontend. Signed-off-by: Pierre Villard This closes #8475. > FlowAnalysisResults should not leak anauthorized component details > -- > > Key: NIFI-12862 > URL: https://issues.apache.org/jira/browse/NIFI-12862 > Project: Apache NiFi > Issue Type: Bug >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > The FlowAnalysisResultEntity hold FlowAnalysisRuleViolationDTO that contain > the name of a violating component as a message describing the violation. This > usually contains details about the violating component. > A user can see these even if they don't have read permission for that > particular component. > In clustered environment the request merger filters out such violations but > in a non-clustered environment there is no such filtering phase. > The FlowAnalysisRuleViolationDTO itself should be built accordingly and leave > certain details blank when the user lacks read permissions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12862 FlowAnalysisResults should not leak unauthorized component details [nifi]
asfgit closed pull request #8475: NIFI-12862 FlowAnalysisResults should not leak unauthorized component details URL: https://github.com/apache/nifi/pull/8475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12862) FlowAnalysisResults should not leak anauthorized component details
[ https://issues.apache.org/jira/browse/NIFI-12862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-12862. --- Fix Version/s: 2.0.0 Resolution: Fixed > FlowAnalysisResults should not leak anauthorized component details > -- > > Key: NIFI-12862 > URL: https://issues.apache.org/jira/browse/NIFI-12862 > Project: Apache NiFi > Issue Type: Bug >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Fix For: 2.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > The FlowAnalysisResultEntity hold FlowAnalysisRuleViolationDTO that contain > the name of a violating component as a message describing the violation. This > usually contains details about the violating component. > A user can see these even if they don't have read permission for that > particular component. > In clustered environment the request merger filters out such violations but > in a non-clustered environment there is no such filtering phase. > The FlowAnalysisRuleViolationDTO itself should be built accordingly and leave > certain details blank when the user lacks read permissions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12900) Avoid unnecessary file listing in PutSFTP
[
https://issues.apache.org/jira/browse/NIFI-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
endzeit updated NIFI-12900:
---
Description:
The processor {{PutSFTP}} is based on {{PutFileTransfer}}.
Before an actual upload takes place, potential conflicts (e.g. existing file)
are identified and resolved using {{identifyAndResolveConflictFile(...)}}.
As part of this process, information on the target file is retrieved using
{{FileTransfer.getRemoteFileInfo(...)}}.
In case of {{PutSFTP}} this is implemented by {{SFTPTransfer}}.
The implementation of {{getRemoteFileInfo}} executes {{ls}} on the target
directory path. In case there are a lot of files inside the remote directory,
e.g. >10.000 files, the listing reduces the performance of {{PutSFTP}}
significantly.
Instead of a listing on the directory, file information should be retrieved
using either {{ls}} or {{stat}} on the target file directly.
was:
The processor `PutSFTP` is based on `PutFileTransfer`.
Before an actual upload takes place, potential conflicts (e.g. existing file)
are identified and resolved using `identifyAndResolveConflictFile(...)`.
As part of this process, information on the target file is retrieved using
`FileTransfer.getRemoteFileInfo(...)`.
In case of `PutSFTP` this is implemented by `SFTPTransfer`.
The implementation of `getRemoteFileInfo` executes `ls` on the target directory
path. In case there are a lot of files inside the remote directory, e.g.
>10.000 files, the listing reduces the performance of `PutSFTP` significantly.
Instead of a listing on the directory, file information should be retrieved
using either `ls` or `stat` on the target file directly.
> Avoid unnecessary file listing in PutSFTP
> --
>
> Key: NIFI-12900
> URL: https://issues.apache.org/jira/browse/NIFI-12900
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
>
> The processor {{PutSFTP}} is based on {{PutFileTransfer}}.
> Before an actual upload takes place, potential conflicts (e.g. existing file)
> are identified and resolved using {{identifyAndResolveConflictFile(...)}}.
> As part of this process, information on the target file is retrieved using
> {{FileTransfer.getRemoteFileInfo(...)}}.
> In case of {{PutSFTP}} this is implemented by {{SFTPTransfer}}.
> The implementation of {{getRemoteFileInfo}} executes {{ls}} on the target
> directory path. In case there are a lot of files inside the remote directory,
> e.g. >10.000 files, the listing reduces the performance of {{PutSFTP}}
> significantly.
> Instead of a listing on the directory, file information should be retrieved
> using either {{ls}} or {{stat}} on the target file directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12900) Avoid unnecessary file listing in PutSFTP
endzeit created NIFI-12900: -- Summary: Avoid unnecessary file listing in PutSFTP Key: NIFI-12900 URL: https://issues.apache.org/jira/browse/NIFI-12900 Project: Apache NiFi Issue Type: Improvement Reporter: endzeit Assignee: endzeit The processor `PutSFTP` is based on `PutFileTransfer`. Before an actual upload takes place, potential conflicts (e.g. existing file) are identified and resolved using `identifyAndResolveConflictFile(...)`. As part of this process, information on the target file is retrieved using `FileTransfer.getRemoteFileInfo(...)`. In case of `PutSFTP` this is implemented by `SFTPTransfer`. The implementation of `getRemoteFileInfo` executes `ls` on the target directory path. In case there are a lot of files inside the remote directory, e.g. >10.000 files, the listing reduces the performance of `PutSFTP` significantly. Instead of a listing on the directory, file information should be retrieved using either `ls` or `stat` on the target file directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2317) Fix openssl flag flipped in MINIFICPP-1797
[ https://issues.apache.org/jira/browse/MINIFICPP-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2317. - Fix Version/s: 0.16.0 Assignee: Marton Szasz Resolution: Fixed > Fix openssl flag flipped in MINIFICPP-1797 > -- > > Key: MINIFICPP-2317 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2317 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Marton Szasz >Assignee: Marton Szasz >Priority: Major > Fix For: 0.16.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2317 Fix openssl flag flipped in MINIFICPP-1797 [nifi-minifi-cpp]
szaszm closed pull request #1744: MINIFICPP-2317 Fix openssl flag flipped in MINIFICPP-1797 URL: https://github.com/apache/nifi-minifi-cpp/pull/1744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12880 Add processor DeleteFile [nifi]
EndzeitBegins commented on PR #8489: URL: https://github.com/apache/nifi/pull/8489#issuecomment-1997965398 I've added a commit that: 1. upon success, emits a provenance event of type `REMOTE_INVOCATION` 2. upon failure, adds failure details to the FlowFile's attributes I'd appreciate another review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
james-elliott commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525241743
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/navigation-control/navigation-control.component.scss:
##
@@ -18,9 +18,12 @@
div.navigation-control {
margin-bottom: 2px;
-.fa,
-.icon {
-font-size: 18px;
+.mat-mdc-icon-button {
+height: 34px !important;
+width: 34px !important;
+line-height: 34px;
+font-size: 17px !important;
+padding: 0px !important;
Review Comment:
```suggestion
--mdc-icon-button-state-layer-size: 34px;
--mdc-icon-button-icon-size: 17px;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
james-elliott commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525241194
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/operation-control/operation-control.component.scss:
##
@@ -18,9 +18,12 @@
div.operation-control {
margin-bottom: 2px;
-.fa,
-.icon {
-font-size: 18px;
+.mat-mdc-icon-button {
+height: 34px !important;
+width: 34px !important;
+line-height: 34px;
+font-size: 17px !important;
+padding: 0px !important;
Review Comment:
```suggestion
--mdc-icon-button-state-layer-size: 34px;
--mdc-icon-button-icon-size: 17px;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
james-elliott commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525240338
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -0,0 +1,327 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@use 'sass:map';
+@use '@angular/material' as mat;
+@use '../utils.scss' as utils;
+
+@mixin styles() {
+html,
+body {
+height: 100%;
+}
+
+body {
+margin: 0;
+font-family: Roboto, 'Helvetica Neue', sans-serif;
+}
+
+a {
+font-size: 13px;
+cursor: pointer;
+font-weight: normal;
+display: inline-block;
+font-family: Roboto;
+text-decoration: underline;
+text-underline-offset: 3px;
+}
+
+//Icon for styling mat-icon in forms throughout the application.
+.info-icon {
+font-size: 14px;
+height: 14px !important;
+width: 14px !important;
+}
+
+//This style is needed due to an incompatibility between material and
tailwind.
+.mdc-notched-outline__notch {
+border-right: none;
+}
+
+.small-dialog {
+min-width: 320px;
+}
+
+.medium-dialog {
+min-width: 470px;
+}
+
+.medium-short-dialog {
+max-height: 32%;
+max-width: 34%;
+min-height: 250px;
+min-width: 440px;
+font-size: 13px;
+}
+
+.large-dialog {
+max-height: 72%;
+max-width: 55%;
+min-height: 520px;
+min-width: 760px;
+}
+
+.xl-dialog {
+max-height: 72%;
+max-width: 85%;
+min-height: 560px;
+min-width: 1024px;
+}
+
+.edit-parameter-context-dialog {
+max-height: 72%;
+max-width: 55%;
+min-width: 850px;
+min-height: 575px;
+}
+
+.tooltip {
+position: fixed;
+max-width: 500px;
+padding: 10px;
+border-radius: 2px;
+border-width: 1px;
+font-size: 13px;
+font-family: Roboto;
+font-weight: 400;
+word-wrap: break-word;
+white-space: normal;
+z-index: 1;
+
+ul {
+list-style: disc outside;
+margin-left: 1em;
+}
+}
+
+.property-editor {
+font-size: 13px;
+font-family: Roboto;
+font-weight: 400;
+}
+
+.CodeMirror-hints {
+font-size: 13px !important;
+z-index: 1000 !important;
+overflow-y: scroll !important;
+}
+
+.blank,
+.unset,
+.sensitive {
+font-weight: normal !important;
+}
+
+.mat-mdc-icon-button {
+height: 28px !important;
+width: 28px !important;
+line-height: 28px;
+font-size: 14px !important;
+padding: 0 !important;
Review Comment:
```suggestion
--mdc-icon-button-state-layer-size: 28px;
--mdc-icon-button-icon-size: 14px;
line-height: var(--mdc-icon-button-state-layer-size);
padding: 0;
&.mat-mdc-button-base.mdc-icon-button {
padding: 0;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-10707) Add Proxy Configuration Service to new PutBigQuery processor
[ https://issues.apache.org/jira/browse/NIFI-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10707: -- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Add Proxy Configuration Service to new PutBigQuery processor > > > Key: NIFI-10707 > URL: https://issues.apache.org/jira/browse/NIFI-10707 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Csaba Bejan >Assignee: Peter Turcsanyi >Priority: Major > Labels: BigQuery, GCP > Fix For: 2.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The new PutBigQuery processor targeting the new Write API introduced as part > of this ticket: https://issues.apache.org/jira/browse/NIFI-10403 should be > extended with Proxy Configuration Service capability. As discussed on an > earlier PR Proxy configuration needs to be added on gRPC level as well which > could be a more involved effort: https://github.com/apache/nifi/pull/6580 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10707) Add Proxy Configuration Service to new PutBigQuery processor
[ https://issues.apache.org/jira/browse/NIFI-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827181#comment-17827181 ] ASF subversion and git services commented on NIFI-10707: Commit f8d3fcd66cd53668d339ccbcb6d2175defb63393 in nifi's branch refs/heads/main from Peter Turcsanyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f8d3fcd66c ] NIFI-10707 Added proxy support in PutBigQuery Bumped GCP client library version Added grpc-* jars in service api nar in order to avoid CNFE warning in io.grpc.LoadBalancerRegistry Dependency clean-up in GCP modules Signed-off-by: Pierre Villard This closes #8491. > Add Proxy Configuration Service to new PutBigQuery processor > > > Key: NIFI-10707 > URL: https://issues.apache.org/jira/browse/NIFI-10707 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Csaba Bejan >Assignee: Peter Turcsanyi >Priority: Major > Labels: BigQuery, GCP > Time Spent: 20m > Remaining Estimate: 0h > > The new PutBigQuery processor targeting the new Write API introduced as part > of this ticket: https://issues.apache.org/jira/browse/NIFI-10403 should be > extended with Proxy Configuration Service capability. As discussed on an > earlier PR Proxy configuration needs to be added on gRPC level as well which > could be a more involved effort: https://github.com/apache/nifi/pull/6580 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-10707 Added proxy support in PutBigQuery [nifi]
asfgit closed pull request #8491: NIFI-10707 Added proxy support in PutBigQuery URL: https://github.com/apache/nifi/pull/8491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]
knguyen1 opened a new pull request, #8502: URL: https://github.com/apache/nifi/pull/8502 # Summary [NIFI-12885](https://issues.apache.org/jira/browse/NIFI-12885) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12822] table, border, theming updates [nifi]
james-elliott commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525219634
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/resizable/resizable.component.scss:
##
@@ -25,8 +25,8 @@ $handle-size: 15px;
.resizable-handle {
position: absolute;
-width: $handle-size;
-height: $handle-size;
Review Comment:
Why did you remove the variable and replace it with a set size?
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/connection/prioritizers/prioritizers.component.html:
##
Review Comment:
The border classes here aren't impacting styling. They're getting overridden
by the border styling on line 45 of _prioritizers.component-theme.scss
They can either be removed, or the styling rules overriding them need to be
removed so they match the behavior of the parameter context inheritance drag &
drop.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/navigation-control/navigation-control.component.scss:
##
@@ -18,9 +18,12 @@
div.navigation-control {
margin-bottom: 2px;
-.fa,
-.icon {
-font-size: 18px;
+.mat-mdc-icon-button {
+height: 34px !important;
+width: 34px !important;
+line-height: 34px;
+font-size: 17px !important;
+padding: 0px !important;
Review Comment:
Rather than using !important because this is in a scoped context of the
navigation control, we can set new values for the material variables, and it'll
only affect items in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-6379) Add SSL Context Service Property to GetSQS Processor
[ https://issues.apache.org/jira/browse/NIFI-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reynaldo Rea reassigned NIFI-6379: -- Assignee: Reynaldo Rea > Add SSL Context Service Property to GetSQS Processor > > > Key: NIFI-6379 > URL: https://issues.apache.org/jira/browse/NIFI-6379 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.7.1, 1.9.2 > Environment: GetSQS Processor >Reporter: John Crooke >Assignee: Reynaldo Rea >Priority: Major > > The GetSQS processor does NOT let you choose an SSL Context Service, but > other AWS-related processors such as "FetchS3Object" do have the "SSL Context > Service" property. > > This improvement is to enable the choice of SSL Context Service for the > certificate presented and/or the truststore that will be used to trust the > SQS endpoint's certificate. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12897) Allow users to upload files/resources to nifi for use in the dataflow
[ https://issues.apache.org/jira/browse/NIFI-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827170#comment-17827170 ] Pierre Villard commented on NIFI-12897: --- Can details be shared on what is going to be the approach here? what are the options that have been evaluated, etc? Maybe I didn't look in the right place but I didn't see anything proposal in [https://cwiki.apache.org/confluence/display/NIFI/Product+requirements]. This could bring a lot of questions so just want to make sure we can discuss the details and I don't see any description in NIFI-12898. > Allow users to upload files/resources to nifi for use in the dataflow > - > > Key: NIFI-12897 > URL: https://issues.apache.org/jira/browse/NIFI-12897 > Project: Apache NiFi > Issue Type: Epic > Components: Core Framework, Core UI >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > > A common feature request that we receive is to make it easier to upload a > resource file, such as JDBC Driver JAR to nifi so that all of the nodes > receive the file. This epic is meant to capture that request -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12880 Add processor DeleteFile [nifi]
EndzeitBegins commented on code in PR #8489:
URL: https://github.com/apache/nifi/pull/8489#discussion_r1525181096
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DeleteFile.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.DefaultRunDuration;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.documentation.UseCase;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.NoSuchFileException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.List;
+import java.util.Set;
+
+@SupportsBatching(defaultDuration = DefaultRunDuration.TWENTY_FIVE_MILLIS)
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@Tags({"file", "remove", "delete", "local", "files", "filesystem"})
+@CapabilityDescription("Deletes a file from the filesystem.")
+@UseCase(
+description = "Delete source file only after its processing completed",
+configuration = """
+Retrieve a file from the filesystem, e.g. using 'ListFile' and
'FetchFile'.
+Process the file using any combination of processors.
+Store the resulting file to a destination, e.g. using
'PutSFTP'.
+Using 'DeleteFile', delete the file from the filesystem only
after the result has been stored.
+"""
+)
+public class DeleteFile extends AbstractProcessor {
+
+public static final Relationship REL_SUCCESS = new Relationship.Builder()
+.name("success")
+.description("All FlowFiles, for which an existing file has been
deleted, are routed to this relationship")
+.build();
+public static final Relationship REL_NOT_FOUND = new Relationship.Builder()
+.name("not found")
+.description("All FlowFiles, for which the file to delete did not
exist, are routed to this relationship")
+.build();
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("All FlowFiles, for which an existing file could not
be deleted, are routed to this relationship")
+.build();
+
+private final static Set relationships = Set.of(REL_SUCCESS,
REL_NOT_FOUND, REL_FAILURE);
+
+public static final PropertyDescriptor DIRECTORY_PATH = new
PropertyDescriptor.Builder()
+.name("Directory Path")
+.displayName("Directory Path")
+.description("The path to the directory the file to delete is
located in.")
+.required(true)
+.defaultValue("${" + CoreAttributes.ABSOLUTE_PATH.key() + "}")
+
.addValidator(StandardValidators.createDirectoryExistsValidator(true, false))
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+.build();
+public static final PropertyDescriptor FILENAME = new
PropertyDescriptor.Builder()
Review Comment:
I looked into `identifiesExternalResource()` a little more. To my knowledge
it is rather used to reference a (more or less static) resource, such as a
configuration file on the NiFi node.
However, the use case here feels somewhat different. The directory and file
are not a external resource required for the processor to work
[jira] [Created] (MINIFICPP-2317) Fix openssl flag flipped in MINIFICPP-1797
Marton Szasz created MINIFICPP-2317: --- Summary: Fix openssl flag flipped in MINIFICPP-1797 Key: MINIFICPP-2317 URL: https://issues.apache.org/jira/browse/MINIFICPP-2317 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Marton Szasz -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2317 Fix openssl flag flipped in MINIFICPP-1797 [nifi-minifi-cpp]
szaszm opened a new pull request, #1744: URL: https://github.com/apache/nifi-minifi-cpp/pull/1744 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-2251) Make OPENSSL and CURL mandatory
[ https://issues.apache.org/jira/browse/MINIFICPP-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2251: Assignee: Gábor Gyimesi > Make OPENSSL and CURL mandatory > --- > > Key: MINIFICPP-2251 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2251 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Martin Zink >Assignee: Gábor Gyimesi >Priority: Major > > The usability of minifi is very limited without curl and openssl, so we > should probably just include these functionalities inside minifi-core -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… [nifi]
dan-s1 commented on code in PR #8501:
URL: https://github.com/apache/nifi/pull/8501#discussion_r1525017249
##
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKuduProcessor.java:
##
@@ -361,6 +363,27 @@ protected Collection
customValidate(ValidationContext context)
return results;
}
+protected List flushKuduSession(final KuduSession kuduSession)
throws KuduException {
+final List responses = kuduSession.flush();
+// RowErrors will only be present in the OperationResponses in this
case if the flush mode
+// selected is MANUAL_FLUSH. It will be empty otherwise.
+return responses.stream()
+.filter(OperationResponse::hasRowError)
+.map(OperationResponse::getRowError)
+.collect(Collectors.toList());
+}
+
+protected List closeKuduSession(final KuduSession kuduSession)
throws KuduException {
+final List responses = kuduSession.close();
+// RowErrors will only be present in the OperationResponses in this
case if the flush mode
+// selected is MANUAL_FLUSH, since the underlying implementation of
kuduSession.close() returns
+// the OperationResponses from a flush() call.
+return responses.stream()
+.filter(OperationResponse::hasRowError)
+.map(OperationResponse::getRowError)
+.collect(Collectors.toList());
+}
Review Comment:
The only difference in these methods is the source of the responses not how
the errors are collected. Refactor how the errors are collected into a common
method.
```suggestion
protected List flushKuduSession(final KuduSession kuduSession)
throws KuduException {
final List responses = kuduSession.flush();
// RowErrors will only be present in the OperationResponses in this
case if the flush mode
// selected is MANUAL_FLUSH. It will be empty otherwise.
return getRowErrors(responses);
}
protected List closeKuduSession(final KuduSession kuduSession)
throws KuduException {
final List responses = kuduSession.close();
// RowErrors will only be present in the OperationResponses in this
case if the flush mode
// selected is MANUAL_FLUSH, since the underlying implementation of
kuduSession.close() returns
// the OperationResponses from a flush() call.
return getRowErrors(responses);
}
private List getRowErrors(List responses) {
return responses.stream()
.filter(OperationResponse::hasRowError)
.map(OperationResponse::getRowError)
.collect(Collectors.toList());
}
```
##
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/StandardPutKuduResult.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.kudu;
+
+import org.apache.kudu.client.Operation;
+import org.apache.kudu.client.RowError;
+import org.apache.nifi.flowfile.FlowFile;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class StandardPutKuduResult extends PutKuduResult {
+private final Map operationFlowFileMap;
+private final List pendingRowErrors;
+private final Map> flowFileRowErrorsMap;
+
+public StandardPutKuduResult() {
+super();
+this.operationFlowFileMap = new HashMap<>();
+this.pendingRowErrors = new ArrayList<>();
+this.flowFileRowErrorsMap = new HashMap<>();
+}
+
+@Override
+public void recordOperation(final Operation operation) {
+operationFlowFileMap.put(operation, flowFile);
+}
+
+@Override
+public void addError(final RowError rowError) {
+// When this class is used to store results from processing FlowFiles,
the FlushMode
+// is set to AUTO_FLUSH_BACKGROUND or MANUAL_FLUSH. In either case, we
won't know which
+
Re: [PR] MINIFICPP-2282 Support re-encryption of sensitive properties [nifi-minifi-cpp]
fgerlits commented on code in PR #1739: URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1525096660 ## encrypt-config/EncryptConfigMain.cpp: ## Review Comment: fixed in e8ca161921504becfb0044d1e86828bcb4a3ce98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2282 Support re-encryption of sensitive properties [nifi-minifi-cpp]
fgerlits commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1525096141
##
encrypt-config/EncryptConfigMain.cpp:
##
@@ -62,18 +65,19 @@ int main(int argc, char* argv[]) try {
if (operation == OPERATION_MINIFI_PROPERTIES) {
encrypt_config.encryptSensitiveValuesInMinifiProperties();
} else if (operation == OPERATION_FLOW_CONFIG) {
+auto re_encrypt = argument_parser.get("--re-encrypt");
auto component_id = argument_parser.present("--component-id");
auto property_name = argument_parser.present("--property-name");
auto property_value = argument_parser.present("--property-value");
Review Comment:
fixed in 9ab4f07115b554b646c601253ecd0e16bc8a5e71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2308) python extension Dict: key type is std::string_view, but null-terminated string is required. The interface should be changed to reflect that.
[
https://issues.apache.org/jira/browse/MINIFICPP-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-2308:
-
Status: Patch Available (was: Open)
> python extension Dict: key type is std::string_view, but null-terminated
> string is required. The interface should be changed to reflect that.
> -
>
> Key: MINIFICPP-2308
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2308
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Marton Szasz
>Assignee: Gábor Gyimesi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We could change it to have two overloads: const char* and maybe std::string.
> Alternatively, change it to use {{PyDict_GetItem}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MINIFICPP-2224) Drop support for disabling peer verification in InvokeHTTP
[ https://issues.apache.org/jira/browse/MINIFICPP-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2224: Assignee: Gábor Gyimesi > Drop support for disabling peer verification in InvokeHTTP > -- > > Key: MINIFICPP-2224 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2224 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Gábor Gyimesi >Priority: Minor > Labels: beginner, hacktoberfest, newbie, starter > > It's not strictly required in any production system, and we shouldn't > encourage any insecure options while using https. > We should deprecate the property and ignore its value, but shouldn't break > old yaml configuration files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12514: Add config python virtual env binary directory for windows. [nifi]
exceptionfactory commented on PR #8500: URL: https://github.com/apache/nifi/pull/8500#issuecomment-1997669153 > > Thanks for the reply and reference to the mailing list thread @bobpaulin. > > Reviewing the [Python Virtual Environments documentation](https://docs.python.org/3/tutorial/venv.html) and a [Python venv tutorial](https://python.land/virtual-environments/virtualenv), `Scripts` seems to be the standard directory for Windows and `bin` seems to be standard for macOS and Linux. > > Given that background, I think directory-existence checking would be the ideal way forward. It avoids having to evaluate the OS System properties, and also avoids the need for a new NiFi property. > > If we run into issues down the road, then something along the lines of the filter property you described seems worth considering. For now, however, checking first for `bin` and then for `Scripts` seems like it should cover current behavior. > > Hi @exceptionfactory . Yes I think we're aligned on using directory over OS detection. And I agree there is less changes required if we simply hard code the check for first bin then Scripts into the code. Naturally the tradeoff is less complexity with requiring a Nifi release to adapt if venv changes vs a more complex change upfront . It sounds like you're saying at this point your read is the property is more trouble than it's worth. I'll bring this conversation back on list and adjust my PR as advised. Thanks again for the quick reply. Yes, that's a good summary. Thanks for moving this forward! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12514: Add config python virtual env binary directory for windows. [nifi]
bobpaulin commented on PR #8500: URL: https://github.com/apache/nifi/pull/8500#issuecomment-1997660499 Will close this PR and open a new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12514: Add config python virtual env binary directory for windows. [nifi]
bobpaulin closed pull request #8500: NIFI-12514: Add config python virtual env binary directory for windows. URL: https://github.com/apache/nifi/pull/8500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12514: Add config python virtual env binary directory for windows. [nifi]
bobpaulin commented on PR #8500: URL: https://github.com/apache/nifi/pull/8500#issuecomment-1997647829 > Thanks for the reply and reference to the mailing list thread @bobpaulin. > > Reviewing the [Python Virtual Environments documentation](https://docs.python.org/3/tutorial/venv.html) and a [Python venv tutorial](https://python.land/virtual-environments/virtualenv), `Scripts` seems to be the standard directory for Windows and `bin` seems to be standard for macOS and Linux. > > Given that background, I think directory-existence checking would be the ideal way forward. It avoids having to evaluate the OS System properties, and also avoids the need for a new NiFi property. > > If we run into issues down the road, then something along the lines of the filter property you described seems worth considering. For now, however, checking first for `bin` and then for `Scripts` seems like it should cover current behavior. Hi @exceptionfactory . Yes I think we're aligned on using directory over OS detection. And I agree there is less changes required if we simply hard code the check for first bin then Scripts into the code. Naturally the tradeoff is less complexity with requiring a Nifi release to adapt if venv changes vs a more complex change upfront . It sounds like you're saying at this point your read is the property is more trouble than it's worth. I'll bring this conversation back on list and adjust my PR as advised. Thanks again for the quick reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1886) MSI Upgrade support on Windows
[ https://issues.apache.org/jira/browse/MINIFICPP-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-1886: - Description: We should also check if we could upgrade our WiX tool support as well for the latest version 5 release. > MSI Upgrade support on Windows > -- > > Key: MINIFICPP-1886 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1886 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Marton Szasz >Priority: Minor > Labels: windows > > We should also check if we could upgrade our WiX tool support as well for the > latest version 5 release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12887 Additional ways for handling Strings as binary in PutDatabaseRecord [nifi]
exceptionfactory commented on PR #8493: URL: https://github.com/apache/nifi/pull/8493#issuecomment-1997607252 > > The last item to address it the `required()` status for the new property. As mentioned in the comment, it can be set to `true` since the default value provided maintains compatibility with existing configuration. > > Technically we could make it required, but we don't automatically do that in such cases. When a property is essential on a conceptual level, we make it required but leave it optional otherwise, even if it has a default value. > > This is more about UX but it makes sense. This can't be considered a conceptually essential parameter, like 'Table Name' for example. Let's leave it optional. Thanks for the reply. Although use of the property is optional in one respect, in that it does not apply if the record does not relate to a binary column, it is required in terms of understanding the default behavior. Right now, the default behavior is implicit, always using UTF-8 decoding. From another angle, making the property optional leaves the behavior ambiguous, because the property value could be an empty string. In that case, it could fall back to UTF-8, but that is less clear than marking the property as required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2202) The MSI installer should start the ApacheNiFiMiNiFi service
[ https://issues.apache.org/jira/browse/MINIFICPP-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2202: - Fix Version/s: 0.16.0 Resolution: Fixed Status: Resolved (was: Patch Available) > The MSI installer should start the ApacheNiFiMiNiFi service > --- > > Key: MINIFICPP-2202 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2202 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Ferenc Gerlits >Assignee: Gábor Gyimesi >Priority: Minor > Fix For: 0.16.0 > > Time Spent: 20m > Remaining Estimate: 0h > > At the end of the installation process, is it possible for the Windows MSI > installer to start the ApacheNiFiMiNiFi service? That would save an > unnecessary step for the user. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2203) Add support for building Windows MSI without any redistributables included
[ https://issues.apache.org/jira/browse/MINIFICPP-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2203: - Fix Version/s: 0.16.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Add support for building Windows MSI without any redistributables included > -- > > Key: MINIFICPP-2203 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2203 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.16.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Currenly MSIs can't be distributed under Apache-2.0, because the required > Microsoft redistributables are included, and their license is not compatible > with Apache-2.0. We should add the option to compile with the system UCRT > only, without including either merge modules or DLLs. The resulting > installers should still work on reasonably up to date systems. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]
szaszm closed pull request #1734: MINIFICPP-2203 Add support for building Windows MSI without any redistributables included URL: https://github.com/apache/nifi-minifi-cpp/pull/1734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12897) Allow users to upload files/resources to nifi for use in the dataflow
Mark Payne created NIFI-12897: - Summary: Allow users to upload files/resources to nifi for use in the dataflow Key: NIFI-12897 URL: https://issues.apache.org/jira/browse/NIFI-12897 Project: Apache NiFi Issue Type: Epic Components: Core Framework, Core UI Reporter: Mark Payne Assignee: Mark Payne A common feature request that we receive is to make it easier to upload a resource file, such as JDBC Driver JAR to nifi so that all of the nodes receive the file. This epic is meant to capture that request -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12899) UI - Allow user to choose assets to upload for a given parameter
Mark Payne created NIFI-12899: - Summary: UI - Allow user to choose assets to upload for a given parameter Key: NIFI-12899 URL: https://issues.apache.org/jira/browse/NIFI-12899 Project: Apache NiFi Issue Type: New Feature Components: Core UI Reporter: Mark Payne -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12898) Backend - Allow uploading asset and referencing via Parameter
Mark Payne created NIFI-12898: - Summary: Backend - Allow uploading asset and referencing via Parameter Key: NIFI-12898 URL: https://issues.apache.org/jira/browse/NIFI-12898 Project: Apache NiFi Issue Type: New Feature Components: Core Framework Reporter: Mark Payne Assignee: Mark Payne -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2202 Start MiNiFi service after Windows install [nifi-minifi-cpp]
szaszm closed pull request #1736: MINIFICPP-2202 Start MiNiFi service after Windows install URL: https://github.com/apache/nifi-minifi-cpp/pull/1736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12514: Add config python virtual env binary directory for windows. [nifi]
exceptionfactory commented on PR #8500: URL: https://github.com/apache/nifi/pull/8500#issuecomment-1997574031 Thanks for the reply and reference to the mailing list thread @bobpaulin. Reviewing the [Python Virtual Environments documentation](https://docs.python.org/3/tutorial/venv.html) and a [Python venv tutorial](https://python.land/virtual-environments/virtualenv), `Scripts` seems to be the standard directory for Windows and `bin` seems to be standard for macOS and Linux. Given that background, I think directory-existence checking would be the ideal way forward. It avoids having to evaluate the OS System properties, and also avoids the need for a new NiFi property. If we run into issues down the road, then something along the lines of the filter property you described seems worth considering. For now, however, checking first for `bin` and then for `Scripts` seems like it should cover current behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12896) PutSNS Endpoint Override
Sue Kim created NIFI-12896: -- Summary: PutSNS Endpoint Override Key: NIFI-12896 URL: https://issues.apache.org/jira/browse/NIFI-12896 Project: Apache NiFi Issue Type: New Feature Reporter: Sue Kim Assignee: Sue Kim Request for PutSNS processor to have an endpoint override property similar to Get/PutSQS processors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
