GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/44
MINIFI-189: Check log level before buffer operations
Checking the log level before attempting buffer operations has
the impact of avoiding memory and functional calls
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/37#discussion_r98902210
--- Diff: libminifi/src/Processor.cpp ---
@@ -206,6 +207,29 @@ bool Processor::getProperty(std::string name,
std::string
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/38
Going through some PRs to learn the lay of the land. I can't approve but I
really like this one. It excites me +1
---
If your project is set up for it, you can reply to this email and have
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/37#discussion_r98902765
--- Diff: libminifi/src/Processor.cpp ---
@@ -226,6 +250,39 @@ bool Processor::setProperty(std::string name,
std::string value
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/37#discussion_r98902595
--- Diff: libminifi/src/Processor.cpp ---
@@ -206,6 +207,29 @@ bool Processor::getProperty(std::string name,
std::string
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99357485
--- Diff: cmake/FindOpenSSL.cmake ---
@@ -0,0 +1,28 @@
+# OPENSSL_ROOT_DIR - Set this variable to the root installation of OpenSSL
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99357721
--- Diff: libminifi/src/FlowController.cpp ---
@@ -75,22 +78,123 @@ FlowController::FlowController(std::string name
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99357571
--- Diff: libminifi/include/FlowController.h ---
@@ -90,6 +93,25 @@ class FlowController
}
return _flowController
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/45
MINIFI-187: Remove XML References and deps.
Remove XML references and dependencies. This
includes changing the reload functionality to use
YAML instead of XML.
You can merge
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/46#discussion_r99655455
--- Diff: libminifi/cmake/FindLeveldb.cmake ---
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/46#discussion_r99686039
--- Diff: libminifi/cmake/FindLeveldb.cmake ---
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/46#discussion_r99691327
--- Diff: libminifi/cmake/FindLeveldb.cmake ---
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/46#discussion_r99691182
--- Diff: libminifi/cmake/FindLeveldb.cmake ---
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/46
MINIFI-188: Incorporate CATCH and example tests
This PR introduces catch and a few example tests.
Additional tests will follow, but they currently cause
several segfaults without
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/54
@apiri I tested it locally. I would like to add tests for it in unit tests
ala the java client. That may require a little bit more work though to stand up
a server
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/54
@apiri FYI the test protocol I used was to test s2s, bidirectionally, in
secure and non-secure mode. I tested in linux and under mac. It inspired me to
try and build an integration test
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/57
MINIFI-83: Allow appenders to be specified and auto configured.
This PR will modify logging so that we can have configurable
appenders and have them be modified via custom configuration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/54#discussion_r102715874
--- Diff: libminifi/CMakeLists.txt ---
@@ -36,18 +36,34 @@ ENDIF(POLICY CMP0048)
set(CMAKE_CXX_STANDARD 11)
set
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/52#discussion_r102284495
--- Diff: libminifi/src/gps/GetGPS.cpp ---
@@ -0,0 +1,158 @@
+/**
+ * @file GetGPS.cpp
+ * GetGPS class implementation
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/52#discussion_r102284269
--- Diff: libminifi/include/GetGPS.h ---
@@ -0,0 +1,73 @@
+/**
+ * @file GetGPS.h
+ * GetGPS class declaration
+ *
+ * Licensed
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/72#discussion_r102290405
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
---
@@ -704,7 +691,7 @@ protected static void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/72#discussion_r102289560
--- Diff: minifi-bootstrap/src/test/resources/MINIFI-216/config.yml ---
@@ -0,0 +1,106 @@
+# Licensed to the Apache Software Foundation (ASF) under
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/54
MINIFI-206: Implement Extensible Comm Mechanism
Create initial communication mechanism that's
initially based on BSD sockets.
MINIFI-201: Change how hostname is resolved
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/55
MINIFI-222: Upgrade spdlog to latest release.
Modified Logger so that it removed the previously required flush argument.
Copyright headers changed but copyright license is the same
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/55
I put the authors with the corresponding license multiple times. I feel
like it would be better to include the Copyrights and the license once, but
I've seen it done like this in other
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@achristianson I thought I created a ticket to break these out...or maybe
it was an E-mail, but I think that's something we could discuss. When I sent a
message to @apiri earlier I said
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
Created MINIFI-213 to have the CMake 3rd party discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/47
@apiri Yes. I just noticed a typo, but it should be ready. It'll probably
have some adjustments along the review pipeline, but I don't plan anything else
in this PR unless
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/47
@apiri Okay, cool. I think reviewing these changes then allow the
subsequent changes to be in a separate PR ( it's coming ) is probably better
since those tests encompass other parts
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/42
+1 totally a fan of 2017
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/50
MINIFI-195: Convert uuid_unparse usage to uuid_unparse_lower
This will ensure that we use lower case UUIDs. Undefining
the macro won't work and we likely don't want to change
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100846349
--- Diff: libminifi/src/ThreadedSchedulingAgent.cpp ---
@@ -64,11 +68,18 @@ void ThreadedSchedulingAgent::schedule(Processor
*processor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100844559
--- Diff: libminifi/include/ProcessSessionFactory.h ---
@@ -0,0 +1,52 @@
+/**
+ * @file ProcessSessionFactory.h
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100847768
--- Diff: libminifi/src/ListenHTTP.cpp ---
@@ -0,0 +1,395 @@
+/**
+ * @file ListenHTTP.cpp
+ * ListenHTTP class implementation
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100844761
--- Diff: libminifi/include/ProcessSessionFactory.h ---
@@ -0,0 +1,52 @@
+/**
+ * @file ProcessSessionFactory.h
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100845905
--- Diff: libminifi/CMakeLists.txt ---
@@ -48,6 +49,19 @@ file(GLOB SPD_SOURCES "../include/spdlog/*")
add_library(spdlog STATIC ${S
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100846654
--- Diff: CMakeLists.txt ---
@@ -63,6 +66,8 @@ find_package(UUID REQUIRED)
file(GLOB SPD_SOURCES "include/s
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100846792
--- Diff: libminifi/CMakeLists.txt ---
@@ -48,6 +49,19 @@ file(GLOB SPD_SOURCES "../include/spdlog/*")
add_library(spdlog STATIC ${S
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100845047
--- Diff: libminifi/src/Processor.cpp ---
@@ -439,31 +447,25 @@ bool Processor::flowFilesOutGoingFull()
return false;
}
-void
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
If you happen to update try -Os ( don't feel like you need to in this PR )
https://issues.apache.org/jira/browse/MINIFI-197 is a corresponding ticket for
it. I was going to do
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100844292
--- Diff: libminifi/include/ListenHTTP.h ---
@@ -0,0 +1,116 @@
+/**
+ * @file ListenHTTP.h
+ * ListenHTTP class declaration
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/47
I have found that the flow repository isn't cleaning up after itself. Will
resolve that first.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/47
MINIFI-190: Creating initial commit with additional tests
Additional tests will be updated in separate tickets as needed.
Resolves MINIFI-194 by using a semaphore in place
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/47
I'll be happy to break this apart
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/48
MINIFI-195: Update root CMake so testing can occur
Update root CMake to bring OpenSSL location to top level. Keeping
find_package(...) in libminifi CMakeLists.txt to avoid issues building
Github user phrocker closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/49
MINIFI-198: Update root CMAKE so testing can occur
Update root CMake to bring OpenSSL location to top level. Keeping
find_package(...) in libminifi CMakeLists.txt to avoid issues building
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/60
I'm going to do this one file at a time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user phrocker closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/60
MINIFI-225: Apply first round of CPP linter and code style fixes
Included and applied Google code style CPP formatter for eclipse.
You can merge this pull request into a Git repository
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/60
Added xml formatter in thirdparty/codestyle dir. Usually I would add this
to /contrib. Please advise.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/57#discussion_r103284177
--- Diff: libminifi/include/LogAppenders.h ---
@@ -0,0 +1,292 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/57#discussion_r103284475
--- Diff: libminifi/include/LogAppenders.h ---
@@ -0,0 +1,292 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user phrocker closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107912643
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/mysql/event/io
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107910775
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/event/TableInfoCacheKey.java
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107920928
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetChangeDataCaptureMySQL.java
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107917776
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/mysql/event/io
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107921330
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetChangeDataCaptureMySQL.java
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107909853
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/event/TableInfo.java
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107922204
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetChangeDataCaptureMySQL.java
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107921926
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetChangeDataCaptureMySQL.java
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107914632
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/mysql/event/io
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1618#discussion_r107908219
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/event/ColumnDefinition.java
Github user phrocker commented on the issue:
https://github.com/apache/nifi/pull/1618
@mattyb149 I began with an empty password for my user and thus set an empty
string. I saw an NPE in the logs, which did go away once I set a password for
my user and subsequently set it in processor
Github user phrocker commented on the issue:
https://github.com/apache/nifi/pull/1618
@mattyb149 Cool stuff. I used your template because it was an easier place
to start. Seems pretty good. I'll continue to test at my leisure but I'm happy
with it presently. I tried to break
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108924803
--- Diff: libminifi/include/processors/GetFile.h ---
@@ -79,16 +80,27 @@ class GetFile : public core::Processor {
virtual void onTrigger
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108926011
--- Diff: libminifi/src/processors/TailFile.cpp ---
@@ -145,10 +145,10 @@ static bool
sortTailMatchedFileItem(TailMatchedFileItem i
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108924490
--- Diff: CMakeLists.txt ---
@@ -136,6 +136,21 @@ enable_testing(test)
target_include_directories(tests PRIVATE BEFORE
"libminifi/in
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108925441
--- Diff: libminifi/src/core/ProcessSession.cpp ---
@@ -530,6 +530,91 @@ void
ProcessSession::read(std::shared_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108924995
--- Diff: libminifi/include/utils/ThreadPool.h ---
@@ -0,0 +1,287 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108924646
--- Diff: libminifi/include/core/ProcessSession.h ---
@@ -122,6 +128,7 @@ class ProcessSession {
void penalize(std::shared_ptr );
void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108819408
--- Diff: libminifi/src/core/ProcessSession.cpp ---
@@ -530,6 +530,91 @@ void
ProcessSession::read(std::shared_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108926131
--- Diff: libminifi/test/TestExecuteProcess.cpp ---
@@ -0,0 +1,136 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108926160
--- Diff: libminifi/test/TestExecuteProcess.cpp ---
@@ -0,0 +1,136 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/72
MINIFI-246: Adding tests that were used to find bug. Solved by MINIFIâ¦
â¦-193
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/63
Updated to facilitate changes for #67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71
MINIFI-236: Make GetFile, PutFile, TailFile, and ExecuteProcess ThreadSafe
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/69#discussion_r107930194
--- Diff: thirdparty/google-styleguide/cppguide.html ---
@@ -0,0 +1,6170 @@
+
--- End diff --
Agreed. Will change
Github user phrocker commented on the issue:
https://github.com/apache/nifi/pull/1618
@mattyb149 I've left some minor comments. I'm going to pull this down and
test this. I'm super excited. Looks cool.
---
If your project is set up for it, you can reply to this email and have your
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/68
MINIFI-193: Ensure safe UTF encoding
Since the C++ library is agnostic of UTF-8 we can safely write the bytes.
Since we won't be interpreting the UTF-8 code in the core library
we
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/70
MINIFI-226
DO NOT MERGE:
This is an early review of changes for MINIFI-226. First step will be to
separate Configuring components from the FlowController. Next Controller
services
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/69
Please provide feedback for this approach. I will update the readme to make
it a bit clear if more is needed. I kept it intentionally short until we can
make this a required process
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/69
MINIFI-225: Add Linter for Google style guide
Please provide feedback for this approach.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/73
MINIFI-254: Incremental update for linter changes
This particular commit reduces the number < 200.
Thank you for submitting a contribution to Apache NiFi - MiNiF
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1586#discussion_r109555028
--- Diff:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109791553
--- Diff: thirdparty/jsoncpp/devtools/batchbuild.py ---
@@ -0,0 +1,278 @@
+from __future__ import print_function
--- End diff
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109792191
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109792168
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -1240,6 +1257,88 @@ void Site2SiteClientProtocol::transferFlowFiles(
return
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109792275
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -682,6 +682,7 @@ bool Site2SiteClientProtocol::receive(std::string
transactionID
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109791492
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109792063
--- Diff: libminifi/src/provenance/ProvenanceRepository.cpp ---
@@ -36,6 +36,7 @@ void ProvenanceRepository::run() {
uint64_t curTime
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109742314
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109745089
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109741638
--- Diff: libminifi/src/provenance/ProvenanceRepository.cpp ---
@@ -36,6 +36,7 @@ void ProvenanceRepository::run() {
uint64_t curTime
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109742049
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109740706
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -682,6 +682,7 @@ bool Site2SiteClientProtocol::receive(std::string
transactionID
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109742909
--- Diff: libminifi/include/provenance/ProvenanceTaskReport.h ---
@@ -0,0 +1,88 @@
+/**
+ * @file ProvenanceTaskReport.h
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109725610
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109726099
--- Diff: thirdparty/jsoncpp/devtools/batchbuild.py ---
@@ -0,0 +1,278 @@
+from __future__ import print_function
--- End diff
1 - 100 of 1063 matches
Mail list logo
