Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117081374
--- Diff: LICENSE ---
@@ -401,6 +401,33 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
The views and conclusions contained in the software
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/99
MINIFI-270: Move Base RPG capabilities back into RemoteProcessGroupPort
This allows us to extend capabilities in RPG into other classes. Since
the same basic functions are the same we
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/98#discussion_r117061878
--- Diff: libminifi/src/core/RepositoryFactory.cpp ---
@@ -48,9 +50,15 @@ std::shared_ptr createRepository(
try {
std::shared_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/98#discussion_r117061976
--- Diff: libminifi/src/core/RepositoryFactory.cpp ---
@@ -48,9 +50,15 @@ std::shared_ptr createRepository(
try {
std::shared_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117079885
--- Diff: LICENSE ---
@@ -401,6 +401,33 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
The views and conclusions contained in the software
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117080960
--- Diff: libminifi/src/core/Processor.cpp ---
@@ -194,52 +193,10 @@ void
Processor::removeConnection(std::shared_ptr conn
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117079731
--- Diff: libminifi/src/core/Processor.cpp ---
@@ -194,52 +193,10 @@ void
Processor::removeConnection(std::shared_ptr conn
Github user phrocker commented on the issue:
https://github.com/apache/nifi/pull/1805
Looks good but would be nice if there were tests for this if that is
possible to replicate statically.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/97
MINIFI-289: Update test folder to apply linter and set max charactersâ¦
⦠to 200
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116983866
--- Diff: libminifi/test/Test.cpp ---
@@ -1,6 +1,4 @@
/**
- * @file MiNiFiMain.cpp
--- End diff --
Ah yeah this one is per
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116968301
--- Diff: libminifi/test/unit/ClassLoaderTests.cpp ---
@@ -0,0 +1,48 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116968249
--- Diff: libminifi/test/resources/TestControllerServices.yml ---
@@ -0,0 +1,62 @@
+Flow Controller:
--- End diff --
Yah
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116968270
--- Diff: libminifi/test/resources/cn.crt.pem ---
@@ -0,0 +1,25 @@
+Bag Attributes
--- End diff --
yes
---
If your project is set
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116968276
--- Diff: libminifi/test/resources/nifi-cert.pem ---
@@ -0,0 +1,20 @@
+-BEGIN CERTIFICATE-
--- End diff --
yes
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116968835
--- Diff: libminifi/include/processors/ListenHTTP.h ---
@@ -115,6 +114,9 @@ class ListenHTTP : public core::Processor {
std::unique_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116968718
--- Diff: libminifi/test/resources/cn.ckey.pem ---
@@ -0,0 +1,31 @@
+Bag Attributes
--- End diff --
yes. i just used the toolkit
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/98
MINIFI-37: Create a volatile repository and config items for
NoOp and Volatile repository configuration
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/96
@apiri I would prefer to wait on #83 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r117021448
--- Diff: libminifi/src/SchedulingAgent.cpp ---
@@ -39,6 +40,36 @@ bool
SchedulingAgent::hasWorkToDo(std::shared_ptr processor) {
return
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123120308
--- Diff: libminifi/include/core/repository/AtomicRepoEntries.h ---
@@ -0,0 +1,501 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123119025
--- Diff: libminifi/include/core/repository/VolatileRepository.h ---
@@ -331,22 +132,240 @@ class VolatileRepository : public core::Repository
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
@benqiu2016
1) Yes, I have run for two days. Have also run valgrind to show no memory
leaks
2) Yes, and in this case I would encourage the users to use the file
system based
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/113
MINIFI-337: Update configuration readme for Repositories
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/113
@apiri This PR follows #110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123113442
--- Diff: libminifi/include/core/FlowFile.h ---
@@ -224,6 +224,10 @@ class FlowFile {
void setStoredToRepository(bool
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123504131
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -76,27 +89,20 @@ void
RemoteProcessorGroupPort::returnProtocol(std::unique_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123503771
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123501252
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -344,7 +427,8 @@ int
Site2SiteClientProtocol::readRequestType(RequestType
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123503614
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123502816
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -314,10 +314,8 @@ void
YamlConfiguration::parseProvenanceReportingYaml(YAML::Node
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123500630
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -38,7 +39,8 @@ namespace minifi {
bool Site2SiteClientProtocol::establish
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123500565
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +147,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123500940
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -278,26 +301,28 @@ bool Site2SiteClientProtocol::handShake
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123501069
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -319,6 +344,64 @@ void Site2SiteClientProtocol::tearDown() {
_peerState = IDLE
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123768801
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123769093
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/115
Looks good will merge shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123644079
--- Diff: libminifi/include/provenance/Provenance.h ---
@@ -160,21 +161,9 @@ class ProvenanceEventRecord : protected
org::apache::nifi::minifi::io
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123642563
--- Diff: libminifi/include/utils/Id.h ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123745177
--- Diff: README.md ---
@@ -326,26 +326,44 @@ Additionally, users can utilize the MiNiFi Toolkit
Converter (version 0.0.1 - sc
### Http
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123748661
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -314,10 +314,8 @@ void
YamlConfiguration::parseProvenanceReportingYaml(YAML::Node
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123743347
--- Diff: README.md ---
@@ -326,26 +326,44 @@ Additionally, users can utilize the MiNiFi Toolkit
Converter (version 0.0.1 - sc
### Http
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123643744
--- Diff: libminifi/src/provenance/Provenance.cpp ---
@@ -34,9 +36,24 @@ namespace nifi {
namespace minifi {
namespace provenance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123745514
--- Diff: libminifi/src/utils/Id.cpp ---
@@ -0,0 +1,154 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123746263
--- Diff: README.md ---
@@ -326,26 +326,44 @@ Additionally, users can utilize the MiNiFi Toolkit
Converter (version 0.0.1 - sc
### Http
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/98
@apiri This should be good once travis deems it so. I'm adding some
information on the wiki on configuring this and other portions of MiNiFi cpp
---
If your project is set up for it, you
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/102
MINIFI-207: Use recursive mutex that avoid thread safety concerns
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/101
Reviewers, I did not add a test, but will do so at the beginning of the
week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/101
MINIFI-325: Set stream_factory_ from FlowConfiguration constructor
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118830045
--- Diff: libminifi/src/Configure.cpp ---
@@ -71,12 +71,31 @@ const char *Configure::nifi_security_client_pass_phrase
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118830430
--- Diff: libminifi/src/ConfigurationListener.cpp ---
@@ -0,0 +1,130 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822078
--- Diff: libminifi/src/FlowController.cpp ---
@@ -90,8 +91,18 @@ FlowController::FlowController(
initialized_ = false;
root_
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118829992
--- Diff: libminifi/src/FlowController.cpp ---
@@ -163,6 +174,31 @@ FlowController::~FlowController() {
provenance_repo_ = nullptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822142
--- Diff: libminifi/include/FlowController.h ---
@@ -131,9 +134,50 @@ class FlowController : public
core::controller::ControllerServiceProvider
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822157
--- Diff: libminifi/include/HttpConfigurationListener.h ---
@@ -0,0 +1,102 @@
+/**
+ * HttpConfigurationListener class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822209
--- Diff: libminifi/src/FlowController.cpp ---
@@ -175,7 +211,7 @@ void FlowController::stop(bool force) {
this->flow_file_repo_-&g
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822113
--- Diff: libminifi/include/ConfigurationListener.h ---
@@ -0,0 +1,121 @@
+/**
+ * ConfigurationListener class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822084
--- Diff: libminifi/src/FlowController.cpp ---
@@ -90,8 +91,18 @@ FlowController::FlowController(
initialized_ = false;
root_
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822171
--- Diff: libminifi/src/ConfigurationListener.cpp ---
@@ -0,0 +1,130 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118830027
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -32,16 +32,25 @@ namespace core {
core::ProcessGroup *YamlConfiguration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822167
--- Diff: libminifi/src/ConfigurationListener.cpp ---
@@ -0,0 +1,130 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118821534
--- Diff: libminifi/include/FlowController.h ---
@@ -131,9 +134,50 @@ class FlowController : public
core::controller::ControllerServiceProvider
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822193
--- Diff: libminifi/include/core/repository/FlowFileRepository.h ---
@@ -36,7 +36,7 @@ namespace repository {
#define
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118830048
--- Diff: libminifi/include/ConfigurationListener.h ---
@@ -0,0 +1,121 @@
+/**
+ * ConfigurationListener class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118821541
--- Diff: libminifi/include/FlowController.h ---
@@ -131,9 +134,50 @@ class FlowController : public
core::controller::ControllerServiceProvider
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/106
MINIFI-328: Change source of the minifi InvokeHTTP Get scripts
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/97
@apiri rebase complete. Waiting on travis to prove me right/wrong...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/98
@apiri after addressing your comments, above, I ran tests which made me
rethink part of how this was tested. To cover my bases I'm going to test a
little more and comment when it's ready
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/100
MINIFI-320: Move instantion of OpenSSL to a singleton that's
lazily created. Added test. In order to make the test work as
expected I had to update thread pool to use a non blocking
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/100#discussion_r117346816
--- Diff: libminifi/include/utils/ThreadPool.h ---
@@ -189,7 +195,8 @@ class ThreadPool {
// atomic running boolean
std::atomic
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/100#discussion_r117346914
--- Diff: libminifi/test/unit/SocketTests.cpp ---
@@ -183,3 +196,42 @@ TEST_CASE("TestSocketWriteTestAfterClose",
&qu
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/100
@apiri this PR is ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user phrocker closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/109
Rolling into MINIFI-249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/109
MINIFI-330: convert const char* to std::string
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/112
+1 approved per evaluation in #107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/107
+1
@benqiu2016 Thanks for the update. Would you mind squashing your commits
with a message you would like to include before we merge it?
---
If your project is set up
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/110
MINIFI-249: Update prov repo to better abstract deser.
Deserialization and serialization are better abstracted
into SerializableComponent allowing us to use all repos with
the same
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
I will be self reviewing this in a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
There are travis failures. Will address.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
Adding one more commit to close this out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
As a general comment, let's have the ability to minimize locking and not
minimize locking in volatile content repository.
---
If your project is set up for it, you can reply to this email
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/86
@apiri yeah sorry it was not intended to take the place of #84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/90#discussion_r114745591
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -417,29 +405,27 @@ void YamlConfiguration::parseConnectionYaml
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/92
thanks @kevdoran
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/92
MINIFI-299: Update Readme.
1) Update caveat section
2) Update list of processors
3) Correct some inconsistencies.
Thank you for submitting a contribution to Apache NiFi
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114861465
--- Diff: libminifi/include/core/FlowConfiguration.h ---
@@ -55,8 +56,9 @@ class FlowConfiguration : public CoreComponent {
* Constructor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114861428
--- Diff: libminifi/include/core/ConfigurationFactory.h ---
@@ -30,25 +30,29 @@ namespace core {
template
typename std::enable_if
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114861939
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -41,10 +42,12 @@ namespace core {
class YamlConfiguration : public
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114860818
--- Diff: libminifi/include/FlowController.h ---
@@ -64,8 +64,9 @@ class FlowController : public core::CoreComponent {
/**
* Flow
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114864639
--- Diff: libminifi/include/EventDrivenSchedulingAgent.h ---
@@ -38,8 +38,8 @@ class EventDrivenSchedulingAgent : public
ThreadedSchedulingAgent
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114863373
--- Diff: libminifi/include/FlowController.h ---
@@ -64,8 +64,9 @@ class FlowController : public core::CoreComponent {
/**
* Flow
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137733
--- Diff: libminifi/test/unit/YamlCongifurationTests.cpp ---
@@ -0,0 +1,182 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114138536
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -491,14 +510,18 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137974
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml(
std
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114138774
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration {
void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137339
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -491,14 +510,18 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114138828
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration {
void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137644
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml(
std
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114138730
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration {
void
201 - 300 of 1063 matches
Mail list logo
