[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637344#comment-16637344 ] Peter Wilcsinszky commented on NIFI-5468: - [~joewitt] yes > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637330#comment-16637330 ] Andrew Christianson commented on NIFI-5468: --- [~joewitt] I believe so --[~pepov] can you confirm? > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637324#comment-16637324 ] Joseph Witt commented on NIFI-5468: --- [~pepov] [~achristianson] this can be closed, right? > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566829#comment-16566829 ] ASF GitHub Bot commented on NIFI-5468: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2921 > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566827#comment-16566827 ] ASF subversion and git services commented on NIFI-5468: --- Commit b7fe04257d10ab7bf9df2661260d731ce92a223a in nifi's branch refs/heads/master from pepov [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b7fe042 ] NIFI-5468 Add toolkit to NiFi docker image and use zip archive NIFI-5468 add keypasswd with the default of keystorepasswd for bc compatibility NIFI-5468 Use ARG instead of ENV for PATH variables as those need to be controlled in the build NIFI-5468 Use BASE_URL for the default case when MIRROR_BASE_URL is not defined (and replace ARCHIVE_BASE_URL) This closes #2921 Signed-off-by: Andrew I. Christianson > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566825#comment-16566825 ] ASF subversion and git services commented on NIFI-5468: --- Commit b7fe04257d10ab7bf9df2661260d731ce92a223a in nifi's branch refs/heads/master from pepov [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b7fe042 ] NIFI-5468 Add toolkit to NiFi docker image and use zip archive NIFI-5468 add keypasswd with the default of keystorepasswd for bc compatibility NIFI-5468 Use ARG instead of ENV for PATH variables as those need to be controlled in the build NIFI-5468 Use BASE_URL for the default case when MIRROR_BASE_URL is not defined (and replace ARCHIVE_BASE_URL) This closes #2921 Signed-off-by: Andrew I. Christianson > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566824#comment-16566824 ] ASF subversion and git services commented on NIFI-5468: --- Commit b7fe04257d10ab7bf9df2661260d731ce92a223a in nifi's branch refs/heads/master from pepov [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b7fe042 ] NIFI-5468 Add toolkit to NiFi docker image and use zip archive NIFI-5468 add keypasswd with the default of keystorepasswd for bc compatibility NIFI-5468 Use ARG instead of ENV for PATH variables as those need to be controlled in the build NIFI-5468 Use BASE_URL for the default case when MIRROR_BASE_URL is not defined (and replace ARCHIVE_BASE_URL) This closes #2921 Signed-off-by: Andrew I. Christianson > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566826#comment-16566826 ] ASF subversion and git services commented on NIFI-5468: --- Commit b7fe04257d10ab7bf9df2661260d731ce92a223a in nifi's branch refs/heads/master from pepov [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b7fe042 ] NIFI-5468 Add toolkit to NiFi docker image and use zip archive NIFI-5468 add keypasswd with the default of keystorepasswd for bc compatibility NIFI-5468 Use ARG instead of ENV for PATH variables as those need to be controlled in the build NIFI-5468 Use BASE_URL for the default case when MIRROR_BASE_URL is not defined (and replace ARCHIVE_BASE_URL) This closes #2921 Signed-off-by: Andrew I. Christianson > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565014#comment-16565014 ] ASF GitHub Bot commented on NIFI-5468: -- Github user pepov commented on the issue: https://github.com/apache/nifi/pull/2921 @apiri or @jtstorck if you may have any comments I would appreciate that > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[
https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562169#comment-16562169
]
ASF GitHub Bot commented on NIFI-5468:
--
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206252629
--- Diff: nifi-docker/dockermaven/sh/secure.sh ---
@@ -45,13 +45,23 @@ prop_replace 'nifi.security.truststore'
"${TRUSTSTORE_PATH}"
prop_replace 'nifi.security.truststoreType' "${TRUSTSTORE_TYPE}"
prop_replace 'nifi.security.truststorePasswd' "${TRUSTSTORE_PASSWORD}"
+prop_replace 'keystore' "${KEYSTORE_PATH}"
${nifi_toolkit_props_file}
+prop_replace 'keystoreType' "${KEYSTORE_TYPE}"
${nifi_toolkit_props_file}
+prop_replace 'keystorePasswd' "${KEYSTORE_PASSWORD}"
${nifi_toolkit_props_file}
--- End diff --
Same comment about `keyPasswd`.
> Add toolkit to NiFi docker image and use zip archive
>
>
> Key: NIFI-5468
> URL: https://issues.apache.org/jira/browse/NIFI-5468
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
>Affects Versions: 1.8.0
>Reporter: Peter Wilcsinszky
>Assignee: Peter Wilcsinszky
>Priority: Major
> Fix For: 1.8.0
>
>
> NiFi toolkit is an essential tool for a NiFi installation and makes sense to
> include it by default in the NiFi Docker image.
> Using the zip archive is a step to make possible switching completely to the
> zip release and avoid generating the tar.gz anymore. For the discussion see
> http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[
https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562164#comment-16562164
]
ASF GitHub Bot commented on NIFI-5468:
--
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206251879
--- Diff: nifi-docker/dockerhub/sh/secure.sh ---
@@ -45,13 +45,23 @@ prop_replace 'nifi.security.truststore'
"${TRUSTSTORE_PATH}"
prop_replace 'nifi.security.truststoreType' "${TRUSTSTORE_TYPE}"
prop_replace 'nifi.security.truststorePasswd' "${TRUSTSTORE_PASSWORD}"
+prop_replace 'keystore' "${KEYSTORE_PATH}"
${nifi_toolkit_props_file}
+prop_replace 'keystoreType' "${KEYSTORE_TYPE}"
${nifi_toolkit_props_file}
+prop_replace 'keystorePasswd' "${KEYSTORE_PASSWORD}"
${nifi_toolkit_props_file}
--- End diff --
Sometimes the `keyPasswd` is different from the `keystorePasswd` so
probably needs to be included here as well.
> Add toolkit to NiFi docker image and use zip archive
>
>
> Key: NIFI-5468
> URL: https://issues.apache.org/jira/browse/NIFI-5468
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
>Affects Versions: 1.8.0
>Reporter: Peter Wilcsinszky
>Assignee: Peter Wilcsinszky
>Priority: Major
> Fix For: 1.8.0
>
>
> NiFi toolkit is an essential tool for a NiFi installation and makes sense to
> include it by default in the NiFi Docker image.
> Using the zip archive is a step to make possible switching completely to the
> zip release and avoid generating the tar.gz anymore. For the discussion see
> http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[
https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561834#comment-16561834
]
ASF GitHub Bot commented on NIFI-5468:
--
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206107302
--- Diff: nifi-docker/dockerhub/Dockerfile ---
@@ -23,11 +23,15 @@ LABEL site="https://nifi.apache.org;
ARG UID=1000
ARG GID=1000
ARG NIFI_VERSION=1.8.0
-ARG MIRROR=https://archive.apache.org/dist
+ARG MIRROR_BASE_URL=https://archive.apache.org/dist
+ARG ARCHIVE_BASE_URL=https://archive.apache.org/dist
+
+ENV NIFI_BASE_DIR=/opt/nifi
+ENV NIFI_HOME=${NIFI_BASE_DIR}/nifi-${NIFI_VERSION}
+
+ENV
NIFI_BINARY_PATH=${NIFI_BINARY_PATH:-/nifi/${NIFI_VERSION}/nifi-${NIFI_VERSION}-bin.zip}
--- End diff --
it's the path behind the domain in the url, not on the filesystem
> Add toolkit to NiFi docker image and use zip archive
>
>
> Key: NIFI-5468
> URL: https://issues.apache.org/jira/browse/NIFI-5468
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
>Affects Versions: 1.8.0
>Reporter: Peter Wilcsinszky
>Assignee: Peter Wilcsinszky
>Priority: Major
> Fix For: 1.8.0
>
>
> NiFi toolkit is an essential tool for a NiFi installation and makes sense to
> include it by default in the NiFi Docker image.
> Using the zip archive is a step to make possible switching completely to the
> zip release and avoid generating the tar.gz anymore. For the discussion see
> http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561832#comment-16561832 ] ASF GitHub Bot commented on NIFI-5468: -- Github user pepov commented on a diff in the pull request: https://github.com/apache/nifi/pull/2921#discussion_r206107007 --- Diff: nifi-docker/dockerhub/pom.xml --- @@ -39,7 +39,7 @@ 1000 1000 -1.6.0 +1.7.0 --- End diff -- unfortunately it cannot, since there is no released binary for 1.8 yet > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[
https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561833#comment-16561833
]
ASF GitHub Bot commented on NIFI-5468:
--
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206107026
--- Diff: nifi-docker/dockerhub/pom.xml ---
@@ -61,7 +61,7 @@
${project.version}-dockerhub
-1.6.0
+1.7.0
--- End diff --
unfortunately it cannot, since there is no released binary for 1.8 yet
> Add toolkit to NiFi docker image and use zip archive
>
>
> Key: NIFI-5468
> URL: https://issues.apache.org/jira/browse/NIFI-5468
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
>Affects Versions: 1.8.0
>Reporter: Peter Wilcsinszky
>Assignee: Peter Wilcsinszky
>Priority: Major
> Fix For: 1.8.0
>
>
> NiFi toolkit is an essential tool for a NiFi installation and makes sense to
> include it by default in the NiFi Docker image.
> Using the zip archive is a step to make possible switching completely to the
> zip release and avoid generating the tar.gz anymore. For the discussion see
> http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[
https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561831#comment-16561831
]
ASF GitHub Bot commented on NIFI-5468:
--
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206106274
--- Diff: nifi-docker/dockerhub/pom.xml ---
@@ -61,7 +61,7 @@
${project.version}-dockerhub
-1.6.0
+1.7.0
--- End diff --
Should be 1.8.0 now.
> Add toolkit to NiFi docker image and use zip archive
>
>
> Key: NIFI-5468
> URL: https://issues.apache.org/jira/browse/NIFI-5468
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
>Affects Versions: 1.8.0
>Reporter: Peter Wilcsinszky
>Assignee: Peter Wilcsinszky
>Priority: Major
> Fix For: 1.8.0
>
>
> NiFi toolkit is an essential tool for a NiFi installation and makes sense to
> include it by default in the NiFi Docker image.
> Using the zip archive is a step to make possible switching completely to the
> zip release and avoid generating the tar.gz anymore. For the discussion see
> http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561829#comment-16561829 ] ASF GitHub Bot commented on NIFI-5468: -- Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2921#discussion_r206106251 --- Diff: nifi-docker/dockerhub/pom.xml --- @@ -39,7 +39,7 @@ 1000 1000 -1.6.0 +1.7.0 --- End diff -- Should be 1.8.0 now. > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[
https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561830#comment-16561830
]
ASF GitHub Bot commented on NIFI-5468:
--
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206105937
--- Diff: nifi-docker/dockerhub/Dockerfile ---
@@ -23,11 +23,15 @@ LABEL site="https://nifi.apache.org;
ARG UID=1000
ARG GID=1000
ARG NIFI_VERSION=1.8.0
-ARG MIRROR=https://archive.apache.org/dist
+ARG MIRROR_BASE_URL=https://archive.apache.org/dist
+ARG ARCHIVE_BASE_URL=https://archive.apache.org/dist
+
+ENV NIFI_BASE_DIR=/opt/nifi
+ENV NIFI_HOME=${NIFI_BASE_DIR}/nifi-${NIFI_VERSION}
+
+ENV
NIFI_BINARY_PATH=${NIFI_BINARY_PATH:-/nifi/${NIFI_VERSION}/nifi-${NIFI_VERSION}-bin.zip}
--- End diff --
Did you forget to add `/opt` here to this? `PATH:-/nifi/${NIFI_VERSION}`?
From the diff, it doesn't look like `/nifi` would be a valid starting path.
> Add toolkit to NiFi docker image and use zip archive
>
>
> Key: NIFI-5468
> URL: https://issues.apache.org/jira/browse/NIFI-5468
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
>Affects Versions: 1.8.0
>Reporter: Peter Wilcsinszky
>Assignee: Peter Wilcsinszky
>Priority: Major
> Fix For: 1.8.0
>
>
> NiFi toolkit is an essential tool for a NiFi installation and makes sense to
> include it by default in the NiFi Docker image.
> Using the zip archive is a step to make possible switching completely to the
> zip release and avoid generating the tar.gz anymore. For the discussion see
> http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5468) Add toolkit to NiFi docker image and use zip archive
[ https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559770#comment-16559770 ] ASF GitHub Bot commented on NIFI-5468: -- GitHub user pepov opened a pull request: https://github.com/apache/nifi/pull/2921 NIFI-5468 Add toolkit to NiFi docker image and use zip archive Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pepov/nifi NIFI-5468 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2921.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2921 commit 00ab8845e55eb5dba30347bf4a0aa9fdacc0332a Author: pepov Date: 2018-07-27T12:53:39Z NIFI-5468 Add toolkit to NiFi docker image and use zip archive commit 48b3046400ee096854d3e7552acee9262d337e61 Author: pepov Date: 2018-07-27T13:37:04Z NIFI-5468 nifi toolkit configuration > Add toolkit to NiFi docker image and use zip archive > > > Key: NIFI-5468 > URL: https://issues.apache.org/jira/browse/NIFI-5468 > Project: Apache NiFi > Issue Type: Improvement > Components: Docker >Affects Versions: 1.8.0 >Reporter: Peter Wilcsinszky >Assignee: Peter Wilcsinszky >Priority: Major > Fix For: 1.8.0 > > > NiFi toolkit is an essential tool for a NiFi installation and makes sense to > include it by default in the NiFi Docker image. > Using the zip archive is a step to make possible switching completely to the > zip release and avoid generating the tar.gz anymore. For the discussion see > http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
