[GitHub] houshengbo closed pull request #148: Better describe LICENSE policies, rules and document exclusions by repo.
houshengbo closed pull request #148: Better describe LICENSE policies, rules and document exclusions by repo. URL: https://github.com/apache/incubator-openwhisk-release/pull/148 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/license_assembly.md b/docs/license_assembly.md new file mode 100644 index 000..92721b6 --- /dev/null +++ b/docs/license_assembly.md @@ -0,0 +1,139 @@ + + +# Assembling a LICENSE file + +## How to assemble the LICENSE file for an Apache OpenWhisk repository + +This document describes how to assemble the LICENSE file for an Apache OpenWhisk repository in compliance with Apache policy. + +## LICENSE file structure + +The LICENSE file consists of two major sections: + +- The content of Apache license 2.0 +- 3rd party License dependency listing (copy 3rd party license and reference) +- Qualified by "bundled" or "unbundled" + +### Copy and adjust the Apache 2 License text + +The content of the first section can be copied from the link [Apache license 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt). + +If applicable replace the sentence "Copyright [] [name of copyright owner]" with "Copyright 2016-[20xx] The Apache Software Foundation". + +### Note and reference 3rd party licenses + +The second section includes the information of licenses used by other software, since OpenWhisk depends on multiple packages in different ways. Please apply the following rules to identify and describe the relationship between them and OpenWhisk. + +A folder named licenses needs to be created under the home directory of each OpenWhisk project in order to keep the license files of other packages, each OpenWhisk project depends on. Make sure the license file is named after LICENSE-[package name].txt for each package. + +So far, we list 4 types of relations available among all OpenWhisk projects. We tend to group the packages by licenses, which means packages can be listed under one statement, if they share the same license. + +- **Source code dependency**: the packages, that OpenWhisk's source code depends on, and will be released together with OpenWhisk projects. + + For this type of dependency, we used the verb "bundle" to indicate the relationship and add the following narration to LICENSE file to describe it: + + This distribution bundles the following components, which are available under a [license name] license ([link of the licese]). + [package name] [version] ([codename] - [link of the package]) +License included at licenses/LICENSE-[package name].txt +[copyright information] + + [package name] [version] ([codename] - [link of the package]) +License included at licenses/LICENSE-[package name].txt +[copyright information] + ... + +- **Binary dependency**: the packages, that OpenWhisk's source code depends on, but will NOT be released together with OpenWhisk projects. + + For this type of dependency, we use the phrase "have binary dependencies on" to indicate the relationship and add the following narration to LICENSE file to describe it: + + This distribution has binary dependencies on the following components, which are available under a [license name] license ([link of the licese]). + [package name] [version] ([codename] - [link of the package]) +License included at licenses/LICENSE-[package name].txt +[copyright information] + + [package name] [version] ([codename] - [link of the package]) +License included at licenses/LICENSE-[package name].txt +[copyright information] + ... + + For example, OpenWhisk CLI has binary dependencies on go-isatty and go-homedir, which are both licensed with MIT. We are add the following narration + into LICENSE file: + +This distribution has binary dependencies on the following components, which are available an MIT license (http://opensource.org/licenses/MIT). +Go Isatty 66b8e73 (mattn/go-isatty - https://github.com/mattn/go-isatty) + License included at licenses/LICENSE-goisatty.txt, or https://github.com/mattn/go-isatty/blob/master/LICENSE + Copyright (c) Yasuhiro MATSUMOTO+ +Go Homedir e45 (mitchellh/go-homedir - https://github.com/mitchellh/go-homedir) + License included at licenses/LICENSE-gohomedir.txt, or https://github.com/mitchellh/go-homedir/blob/master/LICENSE + Copyright (c) 2013 Mitchell Hashimoto + + The content of their licenses are included under licenses/LICENSE-goisatty.txt and licenses/LICENSE-gohomedir.txt. + +- **Packages used by OpenWhisk with no alternative**: the components, that are necessary to deliver OpenWhisk services or tools, +and currently are the only candidates
[GitHub] mrutkows closed pull request #275: Restore the LICENSE and NOTICE to fit the source code release
mrutkows closed pull request #275: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-catalog/pull/275 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE.txt b/LICENSE.txt index eb89f4f..66e4cb7 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -187,7 +187,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright 2016-present The Apache Software Foundation + Copyright 2016-2018 The Apache Software Foundation Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -200,19 +200,3 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - - - -Apache License 2.0 - - -This distribution has binary dependencies on the following components, which are available under an Apache License 2.0 (https://www.apache.org/licenses/LICENSE-2.0). -OpenWhisk Client for JavaScript 3.14.0 (openwhisk - https://github.com/apache/incubator-openwhisk-client-js/) - License included at licenses/LICENSE-openwhisk.txt, or https://github.com/apache/incubator-openwhisk-client-js/blob/master/LICENSE.txt - Copyright 2015-2016 IBM Corporation - -Request 2.79.0 (request - https://github.com/request/request/) - License included at licenses/LICENSE-request.txt, or https://github.com/request/request/blob/master/LICENSE - -Watson APIs Node.js SDK latest (watson-developer-cloud - https://github.com/watson-developer-cloud/node-sdk/) - License included at licenses/LICENSE-watsondevelopercloud.txt, or https://github.com/watson-developer-cloud/node-sdk/blob/master/LICENSE diff --git a/NOTICE.txt b/NOTICE.txt index 09f693b..42b272b 100644 --- a/NOTICE.txt +++ b/NOTICE.txt @@ -3,12 +3,3 @@ Copyright 2016-2018 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). - - -BSD 3-Clause "New" or "Revised" License - - -The following components are provided under the BSD 3-Clause "New" or "Revised" License. See project link for details. - - (BSD 3-Clause "New" or "Revised" License) Scala Library (org.scala-lang:scala-library - https://mvnrepository.com/artifact/org.scala-lang/scala-library) - diff --git a/licenses/LICENSE-openwhisk.txt b/licenses/LICENSE-openwhisk.txt deleted file mode 100644 index dd23c51..000 --- a/licenses/LICENSE-openwhisk.txt +++ /dev/null @@ -1,201 +0,0 @@ - Apache License - Version 2.0, January 2004 -http://www.apache.org/licenses/ - - TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION - - 1. Definitions. - - "License" shall mean the terms and conditions for use, reproduction, - and distribution as defined by Sections 1 through 9 of this document. - - "Licensor" shall mean the copyright owner or entity authorized by - the copyright owner that is granting the License. - - "Legal Entity" shall mean the union of the acting entity and all - other entities that control, are controlled by, or are under common - control with that entity. For the purposes of this definition, - "control" means (i) the power, direct or indirect, to cause the - direction or management of such entity, whether by contract or - otherwise, or (ii) ownership of fifty percent (50%) or more of the - outstanding shares, or (iii) beneficial ownership of such entity. - - "You" (or "Your") shall mean an individual or Legal Entity - exercising permissions granted by this License. - - "Source" form shall mean the preferred form for making modifications, - including but not limited to software source code, documentation - source, and configuration files. - - "Object" form shall mean any form resulting from mechanical - transformation or translation of a Source form, including but - not limited to compiled object code, generated documentation, - and conversions to other media types. - - "Work" shall mean the work of authorship, whether in Source or - Object form, made available under the License, as indicated by a - copyright notice that is included in or attached to the work - (an example is
[GitHub] mrutkows closed pull request #58: Restore the LICENSE and NOTICE to fit the source code release
mrutkows closed pull request #58: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/58 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE.txt b/LICENSE.txt index 51fe50a..66e4cb7 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -187,7 +187,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright 2015-present The Apache Software Foundation + Copyright 2016-2018 The Apache Software Foundation Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -200,47 +200,3 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - - - -Apache License 2.0 - - -This distribution has binary dependencies on the following components, which are available under an Apache License 2.0 (https://opensource.org/licenses/Apache-2.0). -Swift 3.1.1 and 4.1 (swift - https://swift.org/) - License included at licenses/LICENSE-swift.txt, or https://swift.org/community/#license - Copyright (c) 2018 Apple Inc. All rights reserved. - - -This distribution depends on the following components, which are available under an Apache License 2.0 (https://opensource.org/licenses/Apache-2.0). -Openwhisk Runtime Docker 1.0.0 (openwhisk-runtime-docker - https://github.com/apache/incubator-openwhisk-runtime-docker/) - License included at licenses/LICENSE-openwhiskruntimedocker.txt, or https://github.com/apache/incubator-openwhisk-runtime-docker/blob/master/LICENSE.txt - Copyright (c) 2016-present The Apache Software Foundation - - -Python Software Foundation License - - -This distribution has binary dependencies on the following components, which are available under an Python Software Foundation License (https://opensource.org/licenses/Python-2.0). -Python 2.7 (python - https://www.python.org) - License included at licenses/LICENSE-python.txt, or https://www.python.org/download/releases/2.7/license/ - - - -MIT License - - -This distribution depends on the following components, which are available under an MIT License (https://opensource.org/licenses/MIT). -Gevent latest (gevent - https://github.com/gevent/gevent/) - License included at licenses/LICENSE-gevent.txt, or https://github.com/gevent/gevent/blob/master/LICENSE - Copyright (c) Denis Bilenko and the contributors, http://www.gevent.org - - - -BSD 3-Clause License - - -This distribution depends on the following components, which are available under a BSD 3-clause License (https://opensource.org/licenses/BSD-3-Clause). -Flask latest (flask - https://github.com/pallets/flask/) - License included at licenses/LICENSE-flask.txt, or https://github.com/pallets/flask/blob/master/LICENSE - Copyright (c) 2010 by the Pallets team. \ No newline at end of file diff --git a/NOTICE.txt b/NOTICE.txt index af86f6f..2198613 100644 --- a/NOTICE.txt +++ b/NOTICE.txt @@ -3,20 +3,3 @@ Copyright 2016-2018 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). - - -MIT License - - -The following components are provided under the MIT License. See project link for details. - - (MIT License) gradle-scalafmt (cz.alenkacz:gradle-scalafmt:1.6.0 - https://github.com/alenkacz/gradle-scalafmt) - (MIT License) SwiftyJSON (IBM-Swift/SwiftyJSON:15.0.1 - https://github.com/IBM-Swift/SwiftyJSON.git) - - -BSD 3-Clause "New" or "Revised" License - - -The following components are provided under the BSD 3-Clause "New" or "Revised" License. See project link for details. - - (BSD 3-Clause "New" or "Revised" License) Scala Library (org.scala-lang:scala-library -
[GitHub] mrutkows closed pull request #84: Restore the LICENSE and NOTICE to fit the source code release
mrutkows closed pull request #84: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-client-go/pull/84 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE.txt b/LICENSE.txt index 35d1c67f..d62dda9a 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -199,15 +199,3 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - - -=== -BSD 3-Clause "New" or "Revised" License -=== - -This product depends on the software: Go - Available at: https://golang.org/ - Version used: 1.8 - Used under the following license: BSD 3 Clause License (https://opensource.org/licenses/BSD-3-Clause) - License included at licenses/LICENSE-go.txt, or Copyright (c) 2009 The Go Authors. All rights reserved. - Copyright (c) 2009 The Go Authors. All rights reserved. diff --git a/licenses/LICENSE-go.txt b/licenses/LICENSE-go.txt deleted file mode 100644 index 6a66aea5.. --- a/licenses/LICENSE-go.txt +++ /dev/null @@ -1,27 +0,0 @@ -Copyright (c) 2009 The Go Authors. All rights reserved. - -Redistribution and use in source and binary forms, with or without -modification, are permitted provided that the following conditions are -met: - - * Redistributions of source code must retain the above copyright -notice, this list of conditions and the following disclaimer. - * Redistributions in binary form must reproduce the above -copyright notice, this list of conditions and the following disclaimer -in the documentation and/or other materials provided with the -distribution. - * Neither the name of Google Inc. nor the names of its -contributors may be used to endorse or promote products derived from -this software without specific prior written permission. - -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #295: Restore the LICENSE and NOTICE to fit the source code release
mrutkows closed pull request #295: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-cli/pull/295 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 91bd3fff..0c5458a3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,18 +1,19 @@ diff --git a/LICENSE.txt b/LICENSE.txt index e5283547..66e4cb78 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -200,83 +200,3 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - - - -Apache License 2.0 - - -This distribution has binary dependencies on the following components under an Apache License 2.0 (http://opensource.org/licenses/Apache-2.0). -Jibber Jabber bcc4c83 (cloudfoundry/jibber_jabber - https://github.com/cloudfoundry/jibber_jabber) - License included at licenses/LICENSE-jibberjabber.txt, or https://github.com/cloudfoundry-attic/jibber_jabber/blob/master/LICENSE - Copyright (c) 2014 Pivotal - -Mousetrap 76626ae (inconshreveable/mousetrap - https://github.com/inconshreveable/mousetrap) - License included at licenses/LICENSE-mousetrap.txt, or https://github.com/inconshreveable/mousetrap/blob/master/LICENSE - Copyright 2014 Alan Shreve - -OpenWhisk Client Go e4b5f82 (apache/incubator-openwhisk-client-go - https://github.com/apache/incubator-openwhisk-client-go) - License included at licenses/LICENSE-openwhiskclientgo.txt, or https://github.com/apache/incubator-openwhisk-client-go/blob/master/LICENSE.txt - Copyright 2015-2016 IBM Corporation - -YAML support for the Go language cd8b52f (go-yaml/yaml - https://github.com/go-yaml/yaml/tree/v2.2.1) - License included at licenses/LICENSE-goyaml.txt, or https://github.com/go-yaml/yaml/blob/v2.2.1/LICENSE - -Cobra 1238ba1 (spf13/cobra - https://github.com/spf13/cobra) - License included at licenses/LICENSE-cobra.txt, or https://github.com/spf13/cobra/blob/master/LICENSE.txt - - - -MIT License - - -This distribution has binary dependencies on the following components available under an MIT license (http://opensource.org/licenses/MIT). -Color 87d4004 (fatih/color - https://github.com/fatih/color) - License included at licenses/LICENSE-color.txt, or https://github.com/fatih/color/blob/master/LICENSE.md - Copyright (c) 2013 Fatih Arslan - -Go Prettyjson f75235b (hokaccha/go-prettyjson - https://github.com/hokaccha/go-prettyjson) - License included at licenses/LICENSE-goprettyjson.txt - -Go Colorable d228849 (mattn/go-colorable - https://github.com/mattn/go-colorable) - License included at licenses/LICENSE-gocolorable.txt, or https://github.com/mattn/go-colorable/blob/master/LICENSE - Copyright (c) 2016 Yasuhiro Matsumoto - -Go Isatty 66b8e73 (mattn/go-isatty - https://github.com/mattn/go-isatty) - License included at licenses/LICENSE-goisatty.txt, or https://github.com/mattn/go-isatty/blob/master/LICENSE - Copyright (c) Yasuhiro MATSUMOTO- -Go Homedir e45 (mitchellh/go-homedir - https://github.com/mitchellh/go-homedir) - License included at licenses/LICENSE-gohomedir.txt, or https://github.com/mitchellh/go-homedir/blob/master/LICENSE - Copyright (c) 2013 Mitchell Hashimoto - -YAML marshaling and unmarshaling support for Go 0ca9ea5 (ghodss/yaml - https://github.com/ghodss/yaml) - License included at licenses/LICENSE-yaml.txt, or https://github.com/ghodss/yaml/blob/master/LICENSE - Copyright (c) 2014 Sam Ghods - -Go I18n 37e5c2d (nicksnyder/go-i18n - https://github.com/nicksnyder/go-i18n) - License included at licenses/LICENSE-goi18n.txt, or https://github.com/nicksnyder/go-i18n/blob/master/LICENSE - Copyright (c) 2014 Nick Snyder https://github.com/nicksnyder - - -=== -BSD 3-Clause "New" or "Revised" License -=== - -This distribution has binary dependencies on the following components available under a BSD 3 Clause License (https://opensource.org/licenses/BSD-3-Clause). -Go 1.8 (https://golang.org/) - License included at licenses/LICENSE-go.txt, or Copyright (c) 2009 The Go Authors. All rights reserved. - Copyright (c) 2009 The Go Authors. All rights reserved. - -Go Querystring 9235644 (google/go-querystring - https://github.com/google/go-querystring) - License
[GitHub] mrutkows commented on a change in pull request #21: Restore the LICENSE and NOTICE to fit the source code release
mrutkows commented on a change in pull request #21: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/21#discussion_r187642038 ## File path: LICENSE.txt ## @@ -187,7 +187,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright 2016-present The Apache Software Foundation + Copyright 2016-2018 The Apache Software Foundation Review comment: If we are allowed to have an “open ended” date (i..e, “present”) that we never have to edit, why would we ever put 2018? when you adopted “present” did you see this done in other Apache projects? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #23: Restore the LICENSE and NOTICE to fit the source code release
mrutkows closed pull request #23: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/23 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE.txt b/LICENSE.txt index a18ddf0..66e4cb7 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -200,138 +200,3 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - - - -Python Software Foundation License - - -This distribution has a binary dependency on the following components, which are available under a Python Software Foundation License. -Python 2.7.12 and 3.6.1 (python - https://www.python.org/) - License included at licenses/LICENSE-python.txt - - - -MIT License - - -This distribution depends on the following components, which are available under an MIT License (https://opensource.org/licenses/MIT). -Gevent 1.1.2 (gevent - https://github.com/gevent/gevent/) - License included at licenses/LICENSE-gevent.txt, or https://github.com/gevent/gevent/blob/master/LICENSE - Copyright (c) Denis Bilenko and the contributors, http://www.gevent.org - -Beautifulsoup4 4.5.1 and 4.5.3 (beautifulsoup4 - https://www.crummy.com/software/BeautifulSoup/) - License included at licenses/LICENSE-beautifulsoup4.txt - Copyright (c) 2004-2011 Leonard Richardson - -Httplib2 0.9.2 and 0.10.3 (httplib2 - https://github.com/httplib2/httplib2/) - License included at licenses/LICENSE-httplib2.txt, https://github.com/httplib2/httplib2/blob/master/LICENSE - Copyright (c) 2006 by Joe Gregorio - -Simplejson 3.8.2 and 3.10.0 (simplejson - https://github.com/simplejson/simplejson/) - License included at licenses/LICENSE-simplejson.txt, https://github.com/simplejson/simplejson/blob/master/LICENSE.txt - Copyright (c) 2006 Bob Ippolito - -Virtualenv 15.1.0 (virtualenv - https://github.com/pypa/virtualenv/) - License included at licenses/LICENSE-virtualenv.txt, https://github.com/pypa/virtualenv/blob/master/LICENSE.txt - Copyright (c) 2007 Ian Bicking and Contributors - Copyright (c) 2009 Ian Bicking, The Open Planning Project - Copyright (c) 2011-2016 The virtualenv developers - -Twisted 16.4.0 and 17.1.0 (twisted - https://github.com/twisted/twisted/) - License included at licenses/LICENSE-twisted.txt, https://github.com/twisted/twisted/blob/trunk/LICENSE - Copyright (c) 2001-2018 - Allen Short - Amber Hawkie Brown - Andrew Bennetts - Andy Gayton - Antoine Pitrou - Apple Computer, Inc. - Ashwini Oruganti - Benjamin Bruheim - Bob Ippolito - Canonical Limited - Christopher Armstrong - David Reid - Divmod Inc. - Donovan Preston - Eric Mangold - Eyal Lotem - Google Inc. - Hybrid Logic Ltd. - Hynek Schlawack - Itamar Turner-Trauring - James Knight - Jason A. Mobarak - Jean-Paul Calderone - Jessica McKellar - Jonathan D. Simms - Jonathan Jacobs - Jonathan Lange - Julian Berman - Jürgen Hermann - Kevin Horn - Kevin Turner - Laurens Van Houtven - Mary Gardiner - Massachusetts Institute of Technology - Matthew Lefkowitz - Moshe Zadka - Paul Swartz - Pavel Pergamenshchik - Rackspace, US Inc. - Ralph Meijer - Richard Wall - Sean Riley - Software Freedom Conservancy - Tavendo GmbH - Thijs Triemstra - Thomas Herve - Timothy Allen - Tom Prince - Travis B. Hartwell - and others that have contributed code to the public domain. - - - -BSD 3-Clause License - - -This distribution depends on the following components, which are available under a BSD 3-clause License (https://opensource.org/licenses/BSD-3-Clause). -Flask 0.11.1 (flask - https://github.com/pallets/flask/) - License included at licenses/LICENSE-flask.txt, or https://github.com/pallets/flask/blob/master/LICENSE - Copyright (c) 2010 by the Pallets team. - -Lxml 3.6.4 and 3.7.3 (lxml - https://github.com/lxml/lxml/) - License included at licenses/LICENSE-lxml.txt, or https://github.com/lxml/lxml/blob/master/LICENSES.txt - Copyright (c) 2004 Infrae. All rights reserved. - -Dateutil 2.5.3 and 2.6.0 (python-dateutil - https://github.com/dateutil/dateutil/) - License included at licenses/LICENSE-dateutil.txt, or https://github.com/dateutil/dateutil/blob/master/LICENSE - Copyright (c) 2003-2011 - Gustavo Niemeyer
[GitHub] mrutkows closed pull request #21: Restore the LICENSE and NOTICE to fit the source code release
mrutkows closed pull request #21: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/21 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE.txt b/LICENSE.txt index 98cc657..66e4cb7 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -187,7 +187,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright 2016-present The Apache Software Foundation + Copyright 2016-2018 The Apache Software Foundation Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -200,61 +200,3 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - - - -PHP License v3.01 - - -This distribution has binary dependencies on the following components, which are available under a PHP License (http://www.php.net/license/3_01.txt). -PHP 7.1 (php - http://www.php.net/) - License included at licenses/LICENSE-php.txt, or htps://www.php.net/license/3_0.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - - -This distribution depends on the following components, which are available under a PHP License (http://www.php.net/license/3_01.txt). -OPcache latest (opcache - https://github.com/php/php-src/tree/master/ext/) - License included at licenses/LICENSE-opcache.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - -PDO_mysql latest (pdo_mysql - https://pecl.php.net/package/PDO_MYSQL/) - License included at licenses/LICENSE-pdomysql.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - -PDO_pgsql latest (pdo_pgsql - https://pecl.php.net/package/PDO_PGSQL/) - License included at licenses/LICENSE-pdopgsql.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - -Intl latest (intl - https://github.com/php/php-src/) - License included at licenses/LICENSE-intl.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - -BCMath latest (bcmath - https://github.com/php/php-src/tree/master/ext/) - License included at licenses/LICENSE-bcmath.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - -Mysqli latest (mysqli - https://github.com/php/php-src/tree/master/ext/) - License included at licenses/LICENSE-mysqli.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - -Gd latest (gd - https://github.com/php/php-src/tree/master/ext/) - License included at licenses/LICENSE-gd.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - -Zip latest (zip - https://github.com/php/php-src/tree/master/ext/) - License included at licenses/LICENSE-zip.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - -Soap latest (soap - https://github.com/php/php-src/tree/master/ext/) - License included at licenses/LICENSE-soap.txt - Copyright (c) 1999 - 2018 The PHP Group. All rights reserved. - - - -MIT License - - -This distribution depends on the following components, which are available under an MIT License (https://opensource.org/licenses/MIT). -Docker-php-ext-install latest (docker-php-ext-install - https://github.com/docker-library/php/) - License included at licenses/LICENSE-dockerphpext.txt, or https://github.com/docker-library/php/blob/master/LICENSE - Copyright (c) 2014-2016 Docker, Inc. diff --git a/NOTICE.txt b/NOTICE.txt index 0759a38..511e1fd 100644 --- a/NOTICE.txt +++ b/NOTICE.txt @@ -3,11 +3,3 @@ Copyright 2016-2018 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). - - -MIT License - - -The following components are provided under the MIT License. See project link for details. - - (MIT License) gradle-scalafmt (cz.alenkacz:gradle-scalafmt:1.6.0 - https://github.com/alenkacz/gradle-scalafmt) \ No newline at end of file diff --git a/licenses/LICENSE-bcmath.txt b/licenses/LICENSE-bcmath.txt deleted file mode 100644 index 5a37708..000 --- a/licenses/LICENSE-bcmath.txt +++ /dev/null @@ -1,68 +0,0 @@ - - The
[GitHub] mrutkows closed pull request #51: Restore the LICENSE and NOTICE to fit the source code release
mrutkows closed pull request #51: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/51 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE.txt b/LICENSE.txt index 33c4d99..66e4cb7 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -187,7 +187,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright 2016-present The Apache Software Foundation + Copyright 2016-2018 The Apache Software Foundation Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -200,24 +200,3 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - - - -Oracle Binary Code License - - -This distribution has a binary dependency on the following components, which are available under an Oracle Binary Code License (http://www.oracle.com/technetwork/java/javase/terms/license/index.html). -Java Platform, Standard Edition 8 and 9 (java - www.oracle.com/technetwork/java/javase/downloads/index.html) - License included at licenses/LICENSE-java.txt, or http://www.oracle.com/technetwork/java/javase/terms/license/index.html - Copyright 2017 Oracle America, Inc. - 500 Oracle Parkway, Redwood City, California 94065, U.S.A. - All rights reserved. - - -Apache License 2.0 - - -This distribution has a binary dependency on the following components, which are available under an Apache License 2.0 (https://opensource.org/licenses/Apache-2.0). -Google Gson 2.6.2 (gson - https://github.com/google/gson) - License included at licenses/LICENSE-gson.txt, or https://github.com/google/gson/blob/master/LICENSE - Copyright 2008 Google Inc. diff --git a/NOTICE.txt b/NOTICE.txt index cce2b07..586a653 100644 --- a/NOTICE.txt +++ b/NOTICE.txt @@ -3,20 +3,3 @@ Copyright 2016-2018 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). - - -MIT License - - -The following components are provided under the MIT License. See project link for details. - - (MIT License) gradle-scalafmt (cz.alenkacz:gradle-scalafmt:1.6.0 - https://github.com/alenkacz/gradle-scalafmt) - - -BSD 3-Clause "New" or "Revised" License - - -The following components are provided under the BSD 3-Clause "New" or "Revised" License. See project link for details. - - (BSD 3-Clause "New" or "Revised" License) Scala Library (org.scala-lang:scala-library - https://mvnrepository.com/artifact/org.scala-lang/scala-library) - diff --git a/licenses/LICENSE-gson.txt b/licenses/LICENSE-gson.txt deleted file mode 100644 index 8b9312d..000 --- a/licenses/LICENSE-gson.txt +++ /dev/null @@ -1,201 +0,0 @@ - Apache License - Version 2.0, January 2004 -http://www.apache.org/licenses/ - - TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION - - 1. Definitions. - - "License" shall mean the terms and conditions for use, reproduction, - and distribution as defined by Sections 1 through 9 of this document. - - "Licensor" shall mean the copyright owner or entity authorized by - the copyright owner that is granting the License. - - "Legal Entity" shall mean the union of the acting entity and all - other entities that control, are controlled by, or are under common - control with that entity. For the purposes of this definition, - "control" means (i) the power, direct or indirect, to cause the - direction or management of such entity, whether by contract or - otherwise, or (ii) ownership of fifty percent (50%) or more of the - outstanding shares, or (iii) beneficial ownership of such entity. - - "You" (or "Your") shall mean an individual or Legal Entity - exercising permissions granted by this License. - - "Source" form shall mean the preferred form for making modifications, - including
[GitHub] csantanapr commented on issue #3232: Making prewarm kind (and count) configurable
csantanapr commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-388490617 From reading the source code, it will use the kind set by default. So it looks what needs to be specified in the ansible manifest is for `nodejs` json structure a `stemCells` with `count` and `memory` like (2, 256M) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #2795: enable concurrent activation processing
codecov-io commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-386889684 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=h1) Report > Merging [#2795](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7d9372f4ea7e49ad4dd691cba80526cc1c3e940c?src=pr=desc) will **increase** coverage by `0.39%`. > The diff coverage is `87.77%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/graphs/tree.svg?token=l0YmsiSAso=pr=150=650)](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) ```diff @@Coverage Diff@@ ## master #2795 +/- ## = + Coverage 74.41% 74.8% +0.39% = Files 126 126 Lines59526042 +90 Branches 391 400 +9 = + Hits 44294520 +91 + Misses 15231522 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) | Coverage Δ | | |---|---|---| | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.69% <100%> (+1.88%)` | :arrow_up: | | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `93.33% <100%> (+0.83%)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `81.52% <68.75%> (-4.37%)` | :arrow_down: | | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `77.62% <0%> (ø)` | :arrow_up: | | [...main/scala/whisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==) | `96.61% <0%> (+0.05%)` | :arrow_up: | | [...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `91.28% <0%> (+0.18%)` | :arrow_up: | | [...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.26% <0%> (+0.29%)` | :arrow_up: | | [...main/scala/whisk/core/entitlement/Collection.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvQ29sbGVjdGlvbi5zY2FsYQ==) | `85.71% <0%> (+0.34%)` | :arrow_up: | | ... and [6 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=footer). Last update [7d9372f...2faa55c](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated
[GitHub] dgrove-oss opened a new pull request #197: Reorganize values.yaml and simplify helper usage
dgrove-oss opened a new pull request #197: Reorganize values.yaml and simplify helper usage URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/197 Make a pass through values.yaml to unify naming conventions and group into per-service hierarchies. Inline trivial helper templates and apply a number of small fixups to the yaml files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eweiter opened a new issue #3646: Swift 4.1 issue discovered around Structs with two Strings
eweiter opened a new issue #3646: Swift 4.1 issue discovered around Structs with two Strings URL: https://github.com/apache/incubator-openwhisk/issues/3646 It was reported that the Swift 4.1 runtime was exhibiting a strange behavior. The behavior in question occurs when a Struct has multiple Strings and those Strings are being initialized directly. For instance, the following piece of code will work: ``` struct Output: Codable { let greeting: String let group: String } func main(completion: (Output?, Error?) -> Void) -> Void { let name = "MyName" let result = Output(greeting: "Hello \(name)", group: "Greetings") print("Log greeting:\(result.greeting)") completion(result, nil) } ``` However the following code will not: ``` struct Output: Codable { let greeting: String let group: String } func main(completion: (Output?, Error?) -> Void) -> Void { let result = Output(greeting: "Hello Name", group: "bummer") print("Log greeting:\(result.greeting)") completion(result, nil) } ``` It appears to be a bug within Swift itself. We have discovered that if the code is compiled with the compiler flag to turn off optimizations then the compiling will work. This compile flag is `-Xswiftc -Onone` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh).
mrutkows commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh). URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/194#issuecomment-388482338 @dgrove-oss thanks Dave! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #902: Restore the LICENSE and NOTICE to fit the source code release
mrutkows closed pull request #902: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/902 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE.txt b/LICENSE.txt index 156ea49b..66e4cb78 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -187,7 +187,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright 2015-present The Apache Software Foundation + Copyright 2016-2018 The Apache Software Foundation Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -200,128 +200,3 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - - - -Apache License 2.0 - - -This distribution has binary dependencies on the following components, which are available under an Apache License 2.0 (https://opensource.org/licenses/Apache-2.0). -Jibber Jabber bcc4c83 (jibber_jabber - https://github.com/cloudfoundry-attic/jibber_jabber/) - License included at licenses/LICENSE-jibberjabber.txt, or https://github.com/cloudfoundry-attic/jibber_jabber/blob/master/LICENSE - Copyright (c) 2014 Pivotal - -Afero 06b7e5f (afero - https://github.com/spf13/afero/) - License included at licenses/LICENSE-afero.txt, or https://github.com/spf13/afero/blob/master/LICENSE.txt - -Cobra 6e91dde (cobra - https://github.com/spf13/cobra/) - License included at licenses/LICENSE-cobra.txt, or https://github.com/spf13/cobra/blob/master/LICENSE.txt - -Mousetrap 76626ae (mousetrap - https://github.com/inconshreveable/mousetrap) - License included at licenses/LICENSE-mousetrap.txt, or https://github.com/inconshreveable/mousetrap/blob/master/LICENSE - Copyright 2014 Alan Shreve - -Stacktrace 78658fd (stacktrace - https://github.com/palantir/stacktrace), - License included at licenses/LICENSE-stacktrace.txt, or https://github.com/palantir/stacktrace/blob/master/LICENSE - -Yaml eb3733d (yaml - https://github.com/go-yaml/yaml), - License included at licenses/LICENSE-yaml.txt, or https://github.com/go-yaml/yaml/blob/v2/LICENSE - - - -BSD 2-Clause License - - -This distribution has binary dependencies on the following components, which are available under an BSD 2-Clause License (https://opensource.org/licenses/BSD-2-Clause). -Properties 0723e35 (Properties - https://github.com/magiconair/properties) - License included at licenses/LICENSE-properties.txt, or https://github.com/magiconair/properties/blob/master/LICENSE - Copyright (c) 2013-2018 - Frank Schroeder - - - -MIT License - - -This distribution has binary dependencies on the following components, which are available under an MIT License (https://opensource.org/licenses/MIT). -Color 570b54c (color - https://github.com/fatih/color) - License included at licenses/LICENSE-color.txt, or https://github.com/fatih/color/blob/master/LICENSE.md - Copyright (c) 2013 Fatih Arslan - -Go-toml 45932ad (Go-toml - https://github.com/pelletier/go-toml) - License included at licenses/LICENSE-gotoml.txt, or https://github.com/pelletier/go-toml/blob/master/LICENSE - Copyright (c) 2013 - 2017 Thomas Pelletier, Eric Anderton - -Go-colorable d228849 (go-colorable - https://github.com/mattn/go-colorable) - License included at licenses/LICENSE-gocolorable.txt, or https://github.com/mattn/go-colorable/blob/master/LICENSE - Copyright (c) 2016 Yasuhiro Matsumoto - -Go-isatty 66b8e73 (go-isatty - https://github.com/mattn/go-isatty) - License included at licenses/LICENSE-goisatty.txt, or https://github.com/mattn/go-isatty/blob/master/LICENSE - Copyright (c) Yasuhiro MATSUMOTO- -Mapstructure f3009df (mapstructure - https://github.com/mitchellh/mapstructure) - License included at licenses/LICENSE-mapstructure.txt, or https://github.com/mitchellh/mapstructure/blob/master/LICENSE - Copyright (c) 2013 Mitchell Hashimoto - -Go-i18n 991e81c (go-i18n - https://github.com/nicksnyder/go-i18n) - License included at licenses/LICENSE-goi18n.txt, or https://github.com/nicksnyder/go-i18n/blob/master/LICENSE - Copyright (c) 2014 Nick Snyder
[GitHub] jasonpet closed pull request #267: new gradle task
jasonpet closed pull request #267: new gradle task URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/267 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tests/build.gradle b/tests/build.gradle index 9827e73..2d217ce 100644 --- a/tests/build.gradle +++ b/tests/build.gradle @@ -45,6 +45,13 @@ task testHealth(type: Test) { include 'system/health/**' } +task testNoHealth(type: Test) { + configure commonConfiguration + exclude 'system/stress/**' + exclude 'system/health/**' + exclude 'system/packages/MessagingServiceTests.class' +} + dependencies { compile "org.scala-lang:scala-library:${gradle.scala.version}" compile 'com.ibm.messagehub:messagehub.login:1.0.0' This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] abaruni opened a new pull request #267: new gradle task
abaruni opened a new pull request #267: new gradle task URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/267 add additional gradle task to allow running test suite without any tests relying upon health endpoints This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3286: Treat action code as attachments for created/updated actions
codecov-io commented on issue #3286: Treat action code as attachments for created/updated actions URL: https://github.com/apache/incubator-openwhisk/pull/3286#issuecomment-385776180 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286?src=pr=h1) Report > Merging [#3286](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/6a3d6bd22923c6514141942321edce1d3beb4c69?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `90%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3286 +/- ## == - Coverage 74.59% 74.45% -0.14% == Files 126 126 Lines5982 5961 -21 Branches 397 384 -13 == - Hits 4462 4438 -24 - Misses 1520 1523 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286?src=pr=tree) | Coverage Δ | | |---|---|---| | [...in/scala/whisk/core/database/DocumentFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvRG9jdW1lbnRGYWN0b3J5LnNjYWxh) | `89.47% <100%> (ø)` | :arrow_up: | | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `77.62% <100%> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `79.37% <81.81%> (-4.5%)` | :arrow_down: | | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `41.89% <0%> (-4.95%)` | :arrow_down: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `88.5% <0%> (-1.27%)` | :arrow_down: | | [...rc/main/scala/whisk/core/controller/Triggers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9UcmlnZ2Vycy5zY2FsYQ==) | `79.85% <0%> (-0.87%)` | :arrow_down: | | [...rc/main/scala/whisk/core/controller/Packages.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9QYWNrYWdlcy5zY2FsYQ==) | `88.88% <0%> (-0.44%)` | :arrow_down: | | [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `69.37% <0%> (-0.38%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286?src=pr=footer). Last update [6a3d6bd...b415146](https://codecov.io/gh/apache/incubator-openwhisk/pull/3286?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #3232: Making prewarm kind (and count) configurable
tysonnorris commented on a change in pull request #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r187685673 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala ## @@ -204,26 +204,25 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef, * @param kind the kind you want to invoke * @return the container iff found */ - def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef, ContainerData)] = -prewarmConfig.flatMap { config => - val kind = action.exec.kind - val memory = action.limits.memory.megabytes.MB - prewarmedPool -.find { - case (_, PreWarmedData(_, `kind`, `memory`)) => true - case _ => false -} -.map { - case (ref, data) => -// Move the container to the usual pool -freePool = freePool + (ref -> data) -prewarmedPool = prewarmedPool - ref -// Create a new prewarm container -prewarmContainer(config.exec, config.memoryLimit) + def takePrewarmContainer(action: ExecutableWhiskAction): Option[(ActorRef, ContainerData)] = { +val kind = action.exec.kind +val memory = action.limits.memory.megabytes.MB +prewarmedPool + .find { +case (_, PreWarmedData(_, `kind`, `memory`)) => true Review comment: This will use the prewarm IFF the prewarm container is an exact match for memory req. Is that intended? I wonder if it should be `if prewarm-memory > action memory > prewarm-memory - memory-match-threshold` So that * there DOES NOT need to be an exact match of action memory req + prewarm memory * there DOES need to be a "close match", dictated by a configurable memory-match-threshold (so that a 20MB action does not land in a 4GB prewarm) I'm not sure that configuration should be global vs per-prewarm config (which would require additional change in the manifest) WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron closed issue #3207: Remove Consul from "The Internal flow of processing" section diagram in about.md
shazron closed issue #3207: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/issues/3207 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3619: Provide an activation store SPI
codecov-io commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-387224274 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=h1) Report > Merging [#3619](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/34bfe753307a064ad4a4856e23072b1ab96e8c15?src=pr=desc) will **increase** coverage by `0.11%`. > The diff coverage is `77.77%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/graphs/tree.svg?token=l0YmsiSAso=650=pr=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3619 +/- ## = + Coverage 74.59% 74.7% +0.11% = Files 126 127 +1 Lines59825985 +3 Branches 397 371 -26 = + Hits 44624471 +9 + Misses 15201514 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/core/entity/ActivationId.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25JZC5zY2FsYQ==) | `89.47% <ø> (ø)` | :arrow_up: | | [...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `91.28% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/entity/WhiskStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrU3RvcmUuc2NhbGE=) | `96.87% <ø> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [.../main/scala/whisk/core/controller/Controller.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9Db250cm9sbGVyLnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | [...hisk/core/controller/actions/SequenceActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1NlcXVlbmNlQWN0aW9ucy5zY2FsYQ==) | `31.13% <0%> (+0.85%)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.5% <100%> (+0.47%)` | :arrow_up: | | [...main/scala/whisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==) | `96.61% <100%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/Triggers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9UcmlnZ2Vycy5zY2FsYQ==) | `81.02% <100%> (+0.3%)` | :arrow_up: | | [...la/whisk/core/entity/ArtifactActivationStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FydGlmYWN0QWN0aXZhdGlvblN0b3JlLnNjYWxh) | `86.66% <86.66%> (ø)` | | | ... and [1 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=footer). Last update [34bfe75...9330c4a](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the
[GitHub] csantanapr commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
csantanapr commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638#issuecomment-388419055 Sweet @shazron This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
csantanapr closed pull request #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/images/OpenWhisk_flow_of_processing.draw.io.xml b/docs/images/OpenWhisk_flow_of_processing.draw.io.xml new file mode 100644 index 00..e9c127c057 --- /dev/null +++ b/docs/images/OpenWhisk_flow_of_processing.draw.io.xml @@ -0,0 +1 @@
[GitHub] shazron commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
shazron commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638#issuecomment-388418932 Rebased. All checks pass. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
codecov-io commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638#issuecomment-387984721 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=h1) Report > Merging [#3638](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/34bfe753307a064ad4a4856e23072b1ab96e8c15?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3638 +/- ## === Coverage 74.59% 74.59% === Files 126 126 Lines5982 5982 Branches 397 397 === Hits 4462 4462 Misses 1520 1520 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=footer). Last update [34bfe75...068f3c3](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
codecov-io commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638#issuecomment-387984721 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=h1) Report > Merging [#3638](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/34bfe753307a064ad4a4856e23072b1ab96e8c15?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638/graphs/tree.svg?token=l0YmsiSAso=pr=150=650)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3638 +/- ## === Coverage 74.59% 74.59% === Files 126 126 Lines5982 5982 Branches 397 397 === Hits 4462 4462 Misses 1520 1520 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=footer). Last update [34bfe75...068f3c3](https://codecov.io/gh/apache/incubator-openwhisk/pull/3638?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #148: Better describe LICENSE policies, rules and document exclusions by repo.
mrutkows opened a new pull request #148: Better describe LICENSE policies, rules and document exclusions by repo. URL: https://github.com/apache/incubator-openwhisk-release/pull/148 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss closed pull request #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh).
dgrove-oss closed pull request #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh). URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/194 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8c71783..cf5d5b2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,22 +1,24 @@ -[![License](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0) +[![License](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0) + # Contributing to Apache OpenWhisk Anyone can contribute to the OpenWhisk project and we welcome your contributions. @@ -36,18 +38,18 @@ Instructions on how to do this can be found here: [http://www.apache.org/licenses/#clas](http://www.apache.org/licenses/#clas) Once submitted, you will receive a confirmation email from the Apache Software Foundation (ASF) and be added to -the following list: http://people.apache.org/unlistedclas.html. +the following list: http://people.apache.org/unlistedclas.html. Project committers will use this list to verify pull requests (PRs) come from contributors that have signed a CLA. -We look forward to your contributions! +We look forward to your contributions! ## Raising issues -Please raise any bug reports or enhancement requests on the respective project repository's GitHub issue tracker. Be sure to search the +Please raise any bug reports or enhancement requests on the respective project repository's GitHub issue tracker. Be sure to search the list to see if your issue has already been raised. -A good bug report is one that make it easy for us to understand what you were trying to do and what went wrong. +A good bug report is one that make it easy for us to understand what you were trying to do and what went wrong. Provide as much context as possible so we can try to recreate the issue. A good enhancement request comes with an explanation of what you are trying to do and how that enhancement would help you. diff --git a/README.md b/README.md index 08e1ad7..36c6be8 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,22 @@ + + # OpenWhisk Deployment for Kubernetes [![License](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0) diff --git a/docker/README.md b/docker/README.md index ce139cd..4af5406 100644 --- a/docker/README.md +++ b/docker/README.md @@ -1,3 +1,22 @@ + + This directory contains the Dockerfiles and other artifacts to build specialized docker images for deploying OpenWhisk to Kubernetes. diff --git a/docker/couchdb/init.sh b/docker/couchdb/init.sh index a78b309..fe0a64f 100755 --- a/docker/couchdb/init.sh +++ b/docker/couchdb/init.sh @@ -1,4 +1,7 @@ #!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + set -ex # start couchdb as a background process diff --git a/docker/kafkapkg-installer/init.sh b/docker/kafkapkg-installer/init.sh index 2c30a7c..1da13ef 100644 --- a/docker/kafkapkg-installer/init.sh +++ b/docker/kafkapkg-installer/init.sh @@ -1,4 +1,7 @@ #!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + set -ex git clone https://github.com/apache/incubator-openwhisk-package-kafka.git @@ -21,4 +24,3 @@ pushd /incubator-openwhisk-package-kafka popd echo "successfully setup kafka package" - diff --git a/docker/openwhisk-catalog/init.sh b/docker/openwhisk-catalog/init.sh index 32eea88..e9ee73c 100755 --- a/docker/openwhisk-catalog/init.sh +++ b/docker/openwhisk-catalog/init.sh @@ -1,7 +1,8 @@ #!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. -set -x -set -e +set -ex # Clone openwhisk-catalog # TODO: when openwhisk-catalog has releases, download release instead! diff --git a/docker/routemgmt/init.sh b/docker/routemgmt/init.sh index 5444fca..6c860c5 100755 --- a/docker/routemgmt/init.sh +++ b/docker/routemgmt/init.sh @@ -1,7 +1,8 @@ #!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. -set -x -set -e +set -ex export OPENWHISK_HOME=/openwhisk diff --git a/docs/setting_up_minikube/README.md b/docs/setting_up_minikube/README.md index 805ea8c..71a45b5 100644 --- a/docs/setting_up_minikube/README.md +++ b/docs/setting_up_minikube/README.md @@ -1,3 +1,22 @@ + + #
[GitHub] vvraskin opened a new issue #3645: Create a single list of all deployment parameters with description
vvraskin opened a new issue #3645: Create a single list of all deployment parameters with description URL: https://github.com/apache/incubator-openwhisk/issues/3645 We have several places where OW deployment parameters could be configured (pureConf, ansible vars), some of the params are well documented, some are not, others are rotten. It would be useful to consolidate all component parameters in a single place preserving the following information: 1. Parameter name 2. Component 3. Default value 4. Type (pureConf, ansible, other) 5. Description Additionally it would be a real boon to create a simple script to automatically check (if possible) if newly added parameters are listed in the doc, potentially add it to Travis to warn us if the params are not documented. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-388403914 @csantanapr this will need a PG. I'll go through it today or this weekend but it's good enough for jenkins. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3644: Allow more special characters in EntityName.
markusthoemmes commented on issue #3644: Allow more special characters in EntityName. URL: https://github.com/apache/incubator-openwhisk/pull/3644#issuecomment-388403600 @rabbah pushed a change to allow all characters except "/" (to avoid ambiguous URLs). Fixing the underscore problem mentioned is a lot more involved and is API breaking theory (since we'd disallow what we're allowing today). I'd delay that to a later change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh).
dgrove-oss commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh). URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/194#issuecomment-388398048 @mrutkows try rebasing again when you get a chance. I believe setup.sh shouldn't touch the cloned repo now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3644: Allow more special characters in EntityName.
rabbah commented on a change in pull request #3644: Allow more special characters in EntityName. URL: https://github.com/apache/incubator-openwhisk/pull/3644#discussion_r187649246 ## File path: common/scala/src/main/scala/whisk/core/entity/EntityPath.scala ## @@ -189,13 +189,15 @@ protected[core] class EntityName private (val name: String) extends AnyVal { protected[core] object EntityName { protected[core] val ENTITY_NAME_MAX_LENGTH = 256 + protected[core] val allowedSpecialCharacters = "@.&%!?=#-" Review comment: worth a dev list heads up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3644: Allow more special characters in EntityName.
markusthoemmes commented on a change in pull request #3644: Allow more special characters in EntityName. URL: https://github.com/apache/incubator-openwhisk/pull/3644#discussion_r187648786 ## File path: common/scala/src/main/scala/whisk/core/entity/EntityPath.scala ## @@ -189,13 +189,15 @@ protected[core] class EntityName private (val name: String) extends AnyVal { protected[core] object EntityName { protected[core] val ENTITY_NAME_MAX_LENGTH = 256 + protected[core] val allowedSpecialCharacters = "@.&%!?=#-" Review comment: proposing: ``` protected[core] val REGEX = raw"\A([a-zA-Z0-9]|[a-zA-Z0-9][^/]{0,${ENTITY_NAME_MAX_LENGTH - 2}}[^/ ])\z" ``` Will allow anything but "/" since that gets nasty in URLs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3644: Allow more special characters in EntityName.
rabbah commented on a change in pull request #3644: Allow more special characters in EntityName. URL: https://github.com/apache/incubator-openwhisk/pull/3644#discussion_r187648510 ## File path: common/scala/src/main/scala/whisk/core/entity/EntityPath.scala ## @@ -189,13 +189,15 @@ protected[core] class EntityName private (val name: String) extends AnyVal { protected[core] object EntityName { protected[core] val ENTITY_NAME_MAX_LENGTH = 256 + protected[core] val allowedSpecialCharacters = "@.&%!?=#-" Review comment: @csantanapr i think you're referring to https://github.com/apache/incubator-openwhisk/issues/2830 rather than more arbitrary characters - since this isn't the first time the list has gotten larger, how about allowing the largest set of characters instead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3644: Allow more special characters in EntityName.
rabbah commented on a change in pull request #3644: Allow more special characters in EntityName. URL: https://github.com/apache/incubator-openwhisk/pull/3644#discussion_r187648510 ## File path: common/scala/src/main/scala/whisk/core/entity/EntityPath.scala ## @@ -189,13 +189,15 @@ protected[core] class EntityName private (val name: String) extends AnyVal { protected[core] object EntityName { protected[core] val ENTITY_NAME_MAX_LENGTH = 256 + protected[core] val allowedSpecialCharacters = "@.&%!?=#-" Review comment: https://github.com/apache/incubator-openwhisk/issues/2830 rather than more arbitrary characters - since this isn't the first time the list has gotten larger, how about allowing the largest set of characters instead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #196: perform all downloads in /tmp to avoid adding spurious files into clo…
csantanapr closed pull request #196: perform all downloads in /tmp to avoid adding spurious files into clo… URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/196 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/travis/setup.sh b/tools/travis/setup.sh index 75c232d..66f1c8e 100755 --- a/tools/travis/setup.sh +++ b/tools/travis/setup.sh @@ -26,23 +26,29 @@ EOF sudo install -v nsenter /usr/local/bin } -# helm on minikube's vm-driver=none requires nsenter -check_or_build_nsenter +# Download and install misc packages and utilities +pushd /tmp + # helm on minikube's vm-driver=none requires nsenter + check_or_build_nsenter + + # download and install the wsk cli + wget -q https://github.com/apache/incubator-openwhisk-cli/releases/download/latest/OpenWhisk_CLI-latest-linux-amd64.tgz + tar xzf OpenWhisk_CLI-latest-linux-amd64.tgz + sudo cp wsk /usr/local/bin/wsk + + # Download and install kubectl and minikube following the recipe in the minikube + # project README.md for using minikube for Linux Continuous Integration with VM Support +curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$TRAVIS_KUBE_VERSION/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin + curl -Lo minikube https://storage.googleapis.com/minikube/releases/$TRAVIS_MINIKUBE_VERSION/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin + # Download and install helm + curl https://raw.githubusercontent.com/kubernetes/helm/master/scripts/get > get_helm.sh && chmod +x get_helm.sh && ./get_helm.sh -# download and install the wsk cli -wget -q https://github.com/apache/incubator-openwhisk-cli/releases/download/latest/OpenWhisk_CLI-latest-linux-amd64.tgz -tar xzf OpenWhisk_CLI-latest-linux-amd64.tgz -sudo cp wsk /usr/local/bin/wsk +popd # set docker0 to promiscuous mode sudo ip link set docker0 promisc on -# Download and install kubectl and minikube following the recipe in the minikube -# project README.md for using minikube for Linux Continuous Integration with VM Support -curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$TRAVIS_KUBE_VERSION/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin -curl -Lo minikube https://storage.googleapis.com/minikube/releases/$TRAVIS_MINIKUBE_VERSION/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin - export MINIKUBE_WANTUPDATENOTIFICATION=false export MINIKUBE_WANTREPORTERRORPROMPT=false export MINIKUBE_HOME=$HOME @@ -71,19 +77,12 @@ if [ $TIMEOUT -eq $TIMEOUT_COUNT ]; then exit 1 fi -echo "minikube is deployed and reachable" -/usr/local/bin/kubectl describe nodes - minikube update-context -# Download and install helm -pushd /tmp - curl https://raw.githubusercontent.com/kubernetes/helm/master/scripts/get > get_helm.sh - chmod +x get_helm.sh - ./get_helm.sh -popd +echo "minikube is deployed and reachable" +/usr/local/bin/kubectl describe nodes -# Install tiller +# Install tiller into the minikube cluster /usr/local/bin/helm init --service-account default # Wait for tiller to be ready @@ -91,7 +90,8 @@ TIMEOUT=0 TIMEOUT_COUNT=20 until [ $TIMEOUT -eq $TIMEOUT_COUNT ]; do TILLER_STATUS=$(/usr/local/bin/kubectl -n kube-system get pods -o wide | grep tiller-deploy | awk '{print $3}') - if [ "$TILLER_STATUS" == "Running" ]; then + TILLER_READY_COUNT=$(/usr/local/bin/kubectl -n kube-system get pods -o wide | grep tiller-deploy | awk '{print $2}') + if [[ "$TILLER_STATUS" == "Running" ]] && [[ "$TILLER_READY_COUNT" == "1/1" ]]; then break fi echo "Waiting for tiller to be ready" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #193: Flatten and simplify Helm charts
csantanapr closed pull request #193: Flatten and simplify Helm charts URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/193 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/helm/Chart.yaml b/helm/Chart.yaml index c6d25f3..4a3f712 100644 --- a/helm/Chart.yaml +++ b/helm/Chart.yaml @@ -5,5 +5,5 @@ version: 0.1.0 keywords: - Apache OpenWhisk maintainers: - - name: Tom Xing -email: xingz...@cn.ibm.com + - name: Apache OpenWhisk committers +email: d...@openwhisk.apache.org diff --git a/helm/charts/couchdb/Chart.yaml b/helm/charts/couchdb/Chart.yaml deleted file mode 100644 index 9ee0613..000 --- a/helm/charts/couchdb/Chart.yaml +++ /dev/null @@ -1,9 +0,0 @@ -apiVersion: v1 -description: A Helm chart to deploy couchdb service for Kubernetes -name: couchdb -version: 0.1.0 -keywords: - - couchdb -maintainers: - - name: Tom Xing -email: xingz...@cn.ibm.com diff --git a/helm/charts/couchdb/templates/NOTES.txt b/helm/charts/couchdb/templates/NOTES.txt deleted file mode 100644 index c011009..000 --- a/helm/charts/couchdb/templates/NOTES.txt +++ /dev/null @@ -1,11 +0,0 @@ - - - -Thank you for installing {{ .Chart.Name }}. - -Your release is named {{ .Release.Name }}. - -To learn more about the release, try: - - $ helm status {{ .Release.Name }} - $ helm get {{ .Release.Name }} diff --git a/helm/charts/couchdb/templates/_helpers.tpl b/helm/charts/couchdb/templates/_helpers.tpl deleted file mode 100644 index 3cfb249..000 --- a/helm/charts/couchdb/templates/_helpers.tpl +++ /dev/null @@ -1,19 +0,0 @@ -{{/* Set Couchdb service name */}} -{{- define "couchdb_service_name" -}} -{{ .Values.global.couchdbServiceName | default "couchdb" | quote }} -{{- end -}} - -{{/* Set Couchdb port */}} -{{- define "couchdb_port" -}} -{{ .Values.global.couchdbPort | default 5984 }} -{{- end -}} - -{{/* Set Couchdb deployment name */}} -{{- define "couchdb_deployment_name" -}} -{{ .Values.deploymentName | default "couchdb" | quote }} -{{- end -}} - -{{/* Set Couchdb PVC name */}} -{{- define "couchdb_pvc_name" -}} -{{ .Values.pvcName | default "couchdb-pvc" | quote }} -{{- end -}} diff --git a/helm/charts/couchdb/templates/deployment.yaml b/helm/charts/couchdb/templates/deployment.yaml deleted file mode 100644 index a98775a..000 --- a/helm/charts/couchdb/templates/deployment.yaml +++ /dev/null @@ -1,63 +0,0 @@ -apiVersion: extensions/v1beta1 -kind: Deployment -metadata: - name: {{ template "couchdb_deployment_name" . }} - namespace: {{ .Release.Namespace | quote }} - labels: -name: {{ template "couchdb_deployment_name" . }} -spec: - replicas: {{ .Values.replicaCount | default 1 }} - template: -metadata: - labels: -name: {{ template "couchdb_deployment_name" . }} -spec: - restartPolicy: Always - - {{- if .Values.global.affinity.enabled }} - affinity: -{{ include "affinity.controlPlane" . | indent 8 }} -{{ include "affinity.selfAntiAffinity" ( include "couchdb_deployment_name" . ) | indent 8 }} - {{- end }} - - containers: - - name: {{ template "couchdb_deployment_name" . }} -imagePullPolicy: {{ .Values.imagePullPolicy | default "IfNotPresent" | quote }} -image: {{ .Values.image | default "openwhisk/kube-couchdb" | quote }} -command: ["/init.sh"] -ports: -- name: couchdb - containerPort: {{ template "couchdb_port" .}} -env: -- name: "DB_HOST" - value: "127.0.0.1" -- name: "DB_PREFIX" - value: {{ .Values.dbPrefix | default "test_" | quote }} -- name: "COUCHDB_USER" - value: {{ .Values.global.couchdbUserName | default "whisk_admin" | quote }} -- name: "COUCHDB_PASSWORD" - value: {{ .Values.global.couchdbPassword | default "some_passw0rd" | quote }} -- name: "DB_PORT" - value: {{ include "couchdb_port" . | quote }} -- name: "NODENAME" - value: "couchdb0" -readinessProbe: - httpGet: -port: {{ template "couchdb_port" . }} -path: /{{ template "activations_table_unquoted" . }} - initialDelaySeconds: 60 - periodSeconds: 10 - failureThreshold: 10 - timeoutSeconds: 1 -{{- if .Values.persistence.enabled }} -volumeMounts: - - name: database-storage -mountPath: /usr/local/var/lib/couchdb -{{- end }} - {{- if .Values.persistence.enabled }} - volumes: -- name: database-storage - persistentVolumeClaim: -claimName: couchdb-pvc - {{- end }} - diff --git a/helm/charts/couchdb/templates/pv.yaml b/helm/charts/couchdb/templates/pv.yaml deleted file mode 100644 index 4570714..000 ---
[GitHub] csantanapr commented on a change in pull request #3644: Allow more special characters in EntityName.
csantanapr commented on a change in pull request #3644: Allow more special characters in EntityName. URL: https://github.com/apache/incubator-openwhisk/pull/3644#discussion_r187645739 ## File path: common/scala/src/main/scala/whisk/core/entity/EntityPath.scala ## @@ -189,13 +189,15 @@ protected[core] class EntityName private (val name: String) extends AnyVal { protected[core] object EntityName { protected[core] val ENTITY_NAME_MAX_LENGTH = 256 + protected[core] val allowedSpecialCharacters = "@.&%!?=#-" Review comment: all this valid/safe in URL? and CouchDB `_id` ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3644: Allow more special characters in EntityName.
csantanapr commented on issue #3644: Allow more special characters in EntityName. URL: https://github.com/apache/incubator-openwhisk/pull/3644#issuecomment-388394275 @markusthoemmes Is this a fix for #3637 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3644: Allow more special characters in EntityName.
rabbah commented on a change in pull request #3644: Allow more special characters in EntityName. URL: https://github.com/apache/incubator-openwhisk/pull/3644#discussion_r187645162 ## File path: common/scala/src/main/scala/whisk/core/entity/EntityPath.scala ## @@ -189,13 +189,15 @@ protected[core] class EntityName private (val name: String) extends AnyVal { protected[core] object EntityName { protected[core] val ENTITY_NAME_MAX_LENGTH = 256 + protected[core] val allowedSpecialCharacters = "@.&%!?=#-" Review comment: really?!? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #3644: Allow more special characters in EntityName.
markusthoemmes opened a new pull request #3644: Allow more special characters in EntityName. URL: https://github.com/apache/incubator-openwhisk/pull/3644 There's no reason not to allow these characters in EntityName, so let's not be narrower on our users than we need to be. ## My changes affect the following components - [X] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [X] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [X] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [X] I added tests to cover my changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #196: perform all downloads in /tmp to avoid adding spurious files into clo…
dgrove-oss commented on issue #196: perform all downloads in /tmp to avoid adding spurious files into clo… URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/196#issuecomment-388393338 we could move scancode.sh earlier, but it is also probably better to the install of pre-req software in setup.sh in /tmp instead of inside the repo we are testing. (see discussion in #194) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3643: Restore the LICENSE and NOTICE to fit the source code release
codecov-io commented on issue #3643: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk/pull/3643#issuecomment-388390995 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3643?src=pr=h1) Report > Merging [#3643](https://codecov.io/gh/apache/incubator-openwhisk/pull/3643?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/34bfe753307a064ad4a4856e23072b1ab96e8c15?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3643/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3643?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3643 +/- ## === Coverage 74.59% 74.59% === Files 126 126 Lines5982 5982 Branches 397 397 === Hits 4462 4462 Misses 1520 1520 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3643?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3643?src=pr=footer). Last update [34bfe75...9c67f2e](https://codecov.io/gh/apache/incubator-openwhisk/pull/3643?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh).
mrutkows commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh). URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/194#issuecomment-388388278 @csantanapr likely we should be doing less in setup.sh (i.e., during the "before_install" phase). Typically, we place scancode as the first step under the (build) "script" step, once all the code is laid out/marshalled/extracted, etc. I would like to make it earlier by convention, but it seemed that was the convention to assure that dependencies (if there were any) could also get scanned if people wanted. In any event, we should have separation of dependencies/tools that are laid down (not unzip/untar) directly under home) which Dave has been making sure of with push/pop like he did for the Helm stuff. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh).
mrutkows commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh). URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/194#issuecomment-388388278 @csantanapr likely we should be doing less in setup.sh (i.e., during the "before_install" phase). Typically, we place scancode as the first step under the (build) "script" step, once all the code is laid out/marshalled/extracted, etc. I would like to make it earlier by convention, but it seemed that was the existing convention (already in place) and meant to assure that dependencies (if there were any) could also get scanned if people wanted. In any event, we should have separation of dependencies/tools that are laid down (not unzip/untar) directly under home) which Dave has been making sure of with push/pop like he did for the Helm stuff. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh).
mrutkows commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh). URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/194#issuecomment-388388278 @csantanapr likely we should be doing less in setup.sh (i.e., during the "before_install" phase). Typically, we place scancode as the first step under the (build) "script" step, once all the code is laid out/marshalled/extracted, etc. In any event, we should have separation of dependencies/tools that are laid down (not unzip/untar) directly under home) which Dave has been making sure of with push/pop. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #902: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #902: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/902 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #84: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #84: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-client-go/pull/84 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #295: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #295: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-cli/pull/295 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #50: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #50: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/50 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #37: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #37: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/37 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #58: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #58: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/58 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #21: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #21: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/21 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #23: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #23: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/23 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #51: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #51: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/51 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #275: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #275: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk-catalog/pull/275 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #196: perform all downloads in /tmp to avoid adding spurious files into clo…
dgrove-oss opened a new pull request #196: perform all downloads in /tmp to avoid adding spurious files into clo… URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/196 …ned repo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #3643: Restore the LICENSE and NOTICE to fit the source code release
houshengbo opened a new pull request #3643: Restore the LICENSE and NOTICE to fit the source code release URL: https://github.com/apache/incubator-openwhisk/pull/3643 All the work we have done for binary dependencies have been saved in openwhisk release. We will resume the work later in openwhisk release repository. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] brunogirin opened a new issue #901: Allow project credential entry to be an environment variable
brunogirin opened a new issue #901: Allow project credential entry to be an environment variable URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/901 When creating a manifest with project information to use with `wskdeploy sync`, it requires credentials to be specified in the `credential` entry. If I specify an environment variable, I get an error on deployment, whereas if I enter the credential in clear it works. In order to avoid credentials being leaked into files, this field should accept an environment variable that can be set externally. ## Steps to reproduce 1. Create a manifest that starts: ```yaml project: apiHost: your API host credential: $OW_CREDENTIAL ``` 2. Set the `OW_CREDENTIAL` environment variable to the correct value 3. `wskdeploy sync`: fails with the following error message: ``` Error: Deployment did not complete sucessfully. Run `wskdeploy undeploy` to remove partially deployed assets. Error: servicedeployer.go [1627]: [ERROR_WHISK_CLIENT_ERROR]: Error code: 145: The connection failed, or timed out. (HTTP status code 401): HTTP Response Status: 401 Unauthorized HTTP Response Body: {"error":"The supplied authentication is invalid","code":"c9d3da79290088b0f68ffe7fe92d3a98"} ``` If the `credential` entry has the credential value in clear text, it works fine. ## Expected behaviour It should be possible to set the value of `credential` to an environment variable that is set externally to avoid that value being stored in clear in a file that is under source control. ## Version This was tried on `wskdeploy` `latest`, downloaded on 10th May. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #3642: Fix README.md's scanCode issues.
rabbah closed pull request #3642: Fix README.md's scanCode issues. URL: https://github.com/apache/incubator-openwhisk/pull/3642 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 1adaddf940..2a689284d2 100644 --- a/README.md +++ b/README.md @@ -39,7 +39,7 @@ The easiest way to start using OpenWhisk is to get Docker installed on on Mac, W ``` git clone https://github.com/apache/incubator-openwhisk-devtools.git -cd docker-compose +cd docker-compose make quick-start ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3642: Fix README.md's scanCode issues.
rabbah commented on issue #3642: Fix README.md's scanCode issues. URL: https://github.com/apache/incubator-openwhisk/pull/3642#issuecomment-388343824 @markusthoemmes it was a pr that had passed travis before the scan code changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3642: Fix README.md's scanCode issues.
codecov-io commented on issue #3642: Fix README.md's scanCode issues. URL: https://github.com/apache/incubator-openwhisk/pull/3642#issuecomment-388336050 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3642?src=pr=h1) Report > Merging [#3642](https://codecov.io/gh/apache/incubator-openwhisk/pull/3642?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e8091265dcf4181ece5d38e940cb8c210295ac?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3642/graphs/tree.svg?width=650=pr=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3642?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3642 +/- ## === Coverage 74.59% 74.59% === Files 126 126 Lines5982 5982 Branches 397 397 === Hits 4462 4462 Misses 1520 1520 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3642?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3642?src=pr=footer). Last update [23e8091...d13110b](https://codecov.io/gh/apache/incubator-openwhisk/pull/3642?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #294: Fix the copyryright IBM issue in the headers
csantanapr commented on issue #294: Fix the copyryright IBM issue in the headers URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/294#issuecomment-388331960 All source code currently in all the ASF repos that came from IBM is donated to ASF. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #193: Flatten and simplify Helm charts
csantanapr commented on a change in pull request #193: Flatten and simplify Helm charts URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/193#discussion_r187582480 ## File path: helm/Chart.yaml ## @@ -5,5 +5,7 @@ version: 0.1.0 keywords: - Apache OpenWhisk maintainers: + - name: Dave Grove Review comment: We should remove any personal names and emails from ASF repos. How about: Name: Apache OpenWhisk committers email: d...@openwhisk.org This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #193: Flatten and simplify Helm charts
csantanapr commented on a change in pull request #193: Flatten and simplify Helm charts URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/193#discussion_r187582480 ## File path: helm/Chart.yaml ## @@ -5,5 +5,7 @@ version: 0.1.0 keywords: - Apache OpenWhisk maintainers: + - name: Dave Grove Review comment: We should personal names and emails from ASF repos. H How about: Name: Apache OpenWhisk committers email: d...@openwhisk.org This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #193: Flatten and simplify Helm charts
csantanapr commented on issue #193: Flatten and simplify Helm charts URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/193#issuecomment-388330366 Problems with Travis This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
csantanapr commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638#issuecomment-388327278 Ah ok @shazron different readme problem, scancode changed and is out of this repo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
markusthoemmes commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638#issuecomment-388326575 @shazron should be fine after #3642 is merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #3642: Fix README.md's scanCode issues.
markusthoemmes opened a new pull request #3642: Fix README.md's scanCode issues. URL: https://github.com/apache/incubator-openwhisk/pull/3642 `master` is broken due to trailing whitespace. @mrutkows did scanCode's config change without updating the main repo? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh).
csantanapr commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh). URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/194#issuecomment-388326466 The scancode step should be done much earlier on the pure git repo source This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
shazron commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638#issuecomment-388324822 @csantanapr not sure that will help, since the last two commits from master itself failed as well: https://github.com/apache/incubator-openwhisk/commits/master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
csantanapr commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638#issuecomment-388323804 I think you need to update your branch with latest from master. The error is unrelated to your branch. You can rebase or merge master into your branch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md
shazron commented on issue #3638: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/pull/3638#issuecomment-388322618 Not sure why one of the builds in the build matrix failed, this is just a doc change... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sven-lange-last commented on issue #3606: Increase nginx security by adapting ssl_ciphers.
sven-lange-last commented on issue #3606: Increase nginx security by adapting ssl_ciphers. URL: https://github.com/apache/incubator-openwhisk/pull/3606#issuecomment-388310902 @ningyougang you are using [OpenJDK 1.8.0 update 102](http://openjdk.java.net/projects/jdk8u/releases/8u102.html) which is from July 2016. It may not support the required ciphers and TLS v1.2 yet. Can you please try the latest update 172? You can also find discussions in www around removed EC ciphers on RHEL / CentOS. This may also be the root cause of your problems. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sven-lange-last commented on issue #3606: Increase nginx security by adapting ssl_ciphers.
sven-lange-last commented on issue #3606: Increase nginx security by adapting ssl_ciphers. URL: https://github.com/apache/incubator-openwhisk/pull/3606#issuecomment-388310902 @ningyougang you are using [OpenJDK 1.8.0 update 102](http://openjdk.java.net/projects/jdk8u/releases/8u102.html) which is from July 2016. It may not support the required ciphers and TLS v1.2 yet. Can you please try the latest update 172? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3607: Change the JDK to use openjdk8-openj9
markusthoemmes commented on issue #3607: Change the JDK to use openjdk8-openj9 URL: https://github.com/apache/incubator-openwhisk/issues/3607#issuecomment-388269801 Good one @dgrove-oss! Didn't think about all the other stuff in a docker image. I think its illusionary to have a docker image with no GPL software in it, so why bother about the JDK specifically? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services