[jira] [Commented] (PHOENIX-7258) Query Optimizer should pick Index hint even for point lookup queries

[ https://issues.apache.org/jira/browse/PHOENIX-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824642#comment-17824642 ] ASF GitHub Bot commented on PHOENIX-7258: - sanjeet006py commented on code in PR #1851: URL:

[jira] [Commented] (PHOENIX-7258) Query Optimizer should pick Index hint even for point lookup queries

[ https://issues.apache.org/jira/browse/PHOENIX-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824641#comment-17824641 ] ASF GitHub Bot commented on PHOENIX-7258: - sanjeet006py commented on code in PR #1851: URL:

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517343363 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517343103 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

[jira] [Commented] (PHOENIX-7265) Add 5.2 versions to BackwardsCompatibilityIT once released

[ https://issues.apache.org/jira/browse/PHOENIX-7265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824633#comment-17824633 ] Istvan Toth commented on PHOENIX-7265: -- We should also add this step to release steps on the

[jira] [Commented] (PHOENIX-7255) Non-existent artifacts referred in compatible_client_versions.json

[ https://issues.apache.org/jira/browse/PHOENIX-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824632#comment-17824632 ] ASF GitHub Bot commented on PHOENIX-7255: - stoty opened a new pull request, #1852: URL:

[PR] PHOENIX-7255 Non-existent artifacts referred in compatible_client_ver… [phoenix]

stoty opened a new pull request, #1852: URL: https://github.com/apache/phoenix/pull/1852 …sions.json also remove old HBase 1.x entries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (PHOENIX-7263) Row value constructor split keys not allowed on indexes

[ https://issues.apache.org/jira/browse/PHOENIX-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824629#comment-17824629 ] ASF GitHub Bot commented on PHOENIX-7263: - stoty commented on PR #1850: URL:

Re: [PR] PHOENIX-7263 Row value constructor split keys not allowed on indexes [phoenix]

stoty commented on PR #1850: URL: https://github.com/apache/phoenix/pull/1850#issuecomment-1985099655 The checkstyle errors also look relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-7263) Row value constructor split keys not allowed on indexes

[ https://issues.apache.org/jira/browse/PHOENIX-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824628#comment-17824628 ] ASF GitHub Bot commented on PHOENIX-7263: - stoty commented on code in PR #1850: URL:

Re: [PR] PHOENIX-7263 Row value constructor split keys not allowed on indexes [phoenix]

stoty commented on code in PR #1850: URL: https://github.com/apache/phoenix/pull/1850#discussion_r1517205871 ## phoenix-core-client/src/main/java/org/apache/phoenix/compile/SplitKeyUtil.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (PHOENIX-7251) Refactor server-side code to support multiple ServerMetadataCache for HA tests

[ https://issues.apache.org/jira/browse/PHOENIX-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824623#comment-17824623 ] ASF GitHub Bot commented on PHOENIX-7251: - shahrs87 merged PR #1845: URL:

Re: [PR] PHOENIX-7251 : Refactor server-side code to support multiple ServerMetadataCache for ITs which create multiple RSs or mini clusters [phoenix]

shahrs87 merged PR #1845: URL: https://github.com/apache/phoenix/pull/1845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PHOENIX-7258) Query Optimizer should pick Index hint even for point lookup queries

[ https://issues.apache.org/jira/browse/PHOENIX-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824612#comment-17824612 ] ASF GitHub Bot commented on PHOENIX-7258: - virajjasani commented on code in PR #1851: URL:

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

virajjasani commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517163722 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

[jira] [Comment Edited] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824569#comment-17824569 ] Viraj Jasani edited comment on PHOENIX-7253 at 3/7/24 11:37 PM:

[jira] [Commented] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824574#comment-17824574 ] ASF GitHub Bot commented on PHOENIX-7253: - virajjasani commented on PR #1848: URL:

Re: [PR] PHOENIX-7253 Perf improvement for non-full scan queries on large table [phoenix]

virajjasani commented on PR #1848: URL: https://github.com/apache/phoenix/pull/1848#issuecomment-1984781605 Even earlier, without this patch, once CQSI connection is cached, multiple queries executed from the same client, using the same CQSI, do end up calling the same metadata API from

[jira] [Comment Edited] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824569#comment-17824569 ] Viraj Jasani edited comment on PHOENIX-7253 at 3/7/24 11:17 PM:

[jira] [Comment Edited] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824569#comment-17824569 ] Viraj Jasani edited comment on PHOENIX-7253 at 3/7/24 11:16 PM:

[jira] [Commented] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824569#comment-17824569 ] Viraj Jasani commented on PHOENIX-7253: --- {quote}AFAIK for point lookups the code short circuits

[jira] [Commented] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824568#comment-17824568 ] ASF GitHub Bot commented on PHOENIX-7253: - dbwong commented on PR #1848: URL:

Re: [PR] PHOENIX-7253 Perf improvement for non-full scan queries on large table [phoenix]

dbwong commented on PR #1848: URL: https://github.com/apache/phoenix/pull/1848#issuecomment-1984753107 @virajjasani This change as setup minimally looks reasonable to me... one area i do think we may need to be careful on however is the single threadedness of the HConnection... I didn't

[jira] [Commented] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824567#comment-17824567 ] ASF GitHub Bot commented on PHOENIX-7253: - virajjasani commented on code in PR #1848: URL:

Re: [PR] PHOENIX-7253 Perf improvement for non-full scan queries on large table [phoenix]

virajjasani commented on code in PR #1848: URL: https://github.com/apache/phoenix/pull/1848#discussion_r1516955054 ## phoenix-core-client/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java: ## @@ -1005,6 +1005,43 @@ private ScansWithRegionLocations

[jira] [Commented] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824566#comment-17824566 ] ASF GitHub Bot commented on PHOENIX-7253: - tkhurana commented on code in PR #1848: URL:

Re: [PR] PHOENIX-7253 Perf improvement for non-full scan queries on large table [phoenix]

tkhurana commented on code in PR #1848: URL: https://github.com/apache/phoenix/pull/1848#discussion_r1516942676 ## phoenix-core-client/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java: ## @@ -1005,6 +1005,43 @@ private ScansWithRegionLocations

[jira] [Commented] (PHOENIX-7258) Query Optimizer should pick Index hint even for point lookup queries

[ https://issues.apache.org/jira/browse/PHOENIX-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824565#comment-17824565 ] ASF GitHub Bot commented on PHOENIX-7258: - tkhurana commented on code in PR #1851: URL:

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

tkhurana commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1516937729 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

[jira] [Commented] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824564#comment-17824564 ] Tanuj Khurana commented on PHOENIX-7253: [~vjasani] I didn't understand what was the perf issue

[jira] [Commented] (PHOENIX-7258) Query Optimizer should pick Index hint even for point lookup queries

[ https://issues.apache.org/jira/browse/PHOENIX-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824548#comment-17824548 ] ASF GitHub Bot commented on PHOENIX-7258: - kadirozde commented on code in PR #1851: URL:

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

kadirozde commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1516869330 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorOffsetIT.java: ## @@ -1221,4 +1222,29 @@ public void rvcOffsetTrailingNullKeyTest() throws

[jira] [Commented] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824546#comment-17824546 ] ASF GitHub Bot commented on PHOENIX-7253: - virajjasani commented on PR #1848: URL:

Re: [PR] PHOENIX-7253 Perf improvement for non-full scan queries on large table [phoenix]

virajjasani commented on PR #1848: URL: https://github.com/apache/phoenix/pull/1848#issuecomment-1984557213 @dbwong here are some of the observations: In both HBase 1 and 2, region locations for the given table are cached at HBase Connection level. Phoenix CQSI connections are by default

[jira] [Commented] (PHOENIX-7258) Query Optimizer should pick Index hint even for point lookup queries

[ https://issues.apache.org/jira/browse/PHOENIX-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824542#comment-17824542 ] ASF GitHub Bot commented on PHOENIX-7258: - virajjasani commented on code in PR #1851: URL:

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

virajjasani commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1516856703 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantSpecificTablesDDLIT.java: ## @@ -616,6 +621,52 @@ public void testTableMetadataScan() throws Exception

[jira] [Commented] (PHOENIX-7251) Refactor server-side code to support multiple ServerMetadataCache for HA tests

[ https://issues.apache.org/jira/browse/PHOENIX-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824541#comment-17824541 ] ASF GitHub Bot commented on PHOENIX-7251: - shahrs87 commented on PR #1845: URL:

Re: [PR] PHOENIX-7251 : Refactor server-side code to support multiple ServerMetadataCache for ITs which create multiple RSs or mini clusters [phoenix]

shahrs87 commented on PR #1845: URL: https://github.com/apache/phoenix/pull/1845#issuecomment-1984524062 > So I think we do need to read all site files? Looks like we do have to use `this.conf = HBaseConfiguration.create(conf)` But since we are caching ServerMetadataCache object

[jira] [Commented] (PHOENIX-7258) Query Optimizer should pick Index hint even for point lookup queries

[ https://issues.apache.org/jira/browse/PHOENIX-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824538#comment-17824538 ] ASF GitHub Bot commented on PHOENIX-7258: - sanjeet006py opened a new pull request, #1851: URL:

[jira] [Commented] (PHOENIX-7243) Add connectionType property to ConnectionInfo class.

[ https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824515#comment-17824515 ] Palash Chauhan commented on PHOENIX-7243: - [~shahrs87] Please let me know when we have this

[jira] [Commented] (PHOENIX-7251) Refactor server-side code to support multiple ServerMetadataCache for HA tests

[ https://issues.apache.org/jira/browse/PHOENIX-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824514#comment-17824514 ] ASF GitHub Bot commented on PHOENIX-7251: - palashc commented on PR #1845: URL:

Re: [PR] PHOENIX-7251 : Refactor server-side code to support multiple ServerMetadataCache for ITs which create multiple RSs or mini clusters [phoenix]

palashc commented on PR #1845: URL: https://github.com/apache/phoenix/pull/1845#issuecomment-1984251635 > Lets see why this is breaking our test. Creating a connection on the server side fails because of malformed URL exception. ``` Caused by: java.sql.SQLException: ERROR 102

[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.

[ https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824513#comment-17824513 ] Rushabh Shah commented on PHOENIX-7243: --- Thank you [~palashc] for the PR. > Add

[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.

[ https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824511#comment-17824511 ] ASF GitHub Bot commented on PHOENIX-7243: - shahrs87 commented on PR #1839: URL:

Re: [PR] PHOENIX-7243 : Add connectionType property to ConnectionInfo [phoenix]

shahrs87 commented on PR #1839: URL: https://github.com/apache/phoenix/pull/1839#issuecomment-1984248090 Forgot to approve the PR. Belated +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.

[ https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824510#comment-17824510 ] ASF GitHub Bot commented on PHOENIX-7243: - shahrs87 merged PR #1839: URL:

Re: [PR] PHOENIX-7243 : Add connectionType property to ConnectionInfo [phoenix]

shahrs87 merged PR #1839: URL: https://github.com/apache/phoenix/pull/1839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PHOENIX-7251) Refactor server-side code to support multiple ServerMetadataCache for HA tests

[ https://issues.apache.org/jira/browse/PHOENIX-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824507#comment-17824507 ] ASF GitHub Bot commented on PHOENIX-7251: - shahrs87 commented on PR #1845: URL:

Re: [PR] PHOENIX-7251 : Refactor server-side code to support multiple ServerMetadataCache for ITs which create multiple RSs or mini clusters [phoenix]

shahrs87 commented on PR #1845: URL: https://github.com/apache/phoenix/pull/1845#issuecomment-1984244698 > Maybe we need HBaseConfiguration.create(conf); - Yes, that works! Lets not do this. This reads all site.xml files (hbase-site.xml, hbase-default.xml, hdfs-site.xml) and then

[jira] [Commented] (PHOENIX-7251) Refactor server-side code to support multiple ServerMetadataCache for HA tests

[ https://issues.apache.org/jira/browse/PHOENIX-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824505#comment-17824505 ] ASF GitHub Bot commented on PHOENIX-7251: - palashc commented on PR #1845: URL:

Re: [PR] PHOENIX-7251 : Refactor server-side code to support multiple ServerMetadataCache for ITs which create multiple RSs or mini clusters [phoenix]

palashc commented on PR #1845: URL: https://github.com/apache/phoenix/pull/1845#issuecomment-1984217352 `this.conf = new Configuration(conf); ` - This change breaks our tests, need to look into it. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (PHOENIX-7251) Refactor server-side code to support multiple ServerMetadataCache for HA tests

[ https://issues.apache.org/jira/browse/PHOENIX-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824501#comment-17824501 ] ASF GitHub Bot commented on PHOENIX-7251: - shahrs87 commented on PR #1845: URL:

Re: [PR] PHOENIX-7251 : Refactor server-side code to support multiple ServerMetadataCache for ITs which create multiple RSs or mini clusters [phoenix]

shahrs87 commented on PR #1845: URL: https://github.com/apache/phoenix/pull/1845#issuecomment-1984174529 > INSTANCE variable does not match static variable name pattern but it was already present in code, we just refactored in this PR. Can we fix this just by following the pattern

[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.

[ https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824500#comment-17824500 ] ASF GitHub Bot commented on PHOENIX-7243: - shahrs87 commented on PR #1839: URL:

Re: [PR] PHOENIX-7243 : Add isServerConnection property to ConnectionInfo [phoenix]

shahrs87 commented on PR #1839: URL: https://github.com/apache/phoenix/pull/1839#issuecomment-1984168480 Change the title of the PR and commit to "PHOENIX-7243 : Add connectionType property to ConnectionInfo" There is 1 checkstyle warning that needs to be addressed. -- This is an

[jira] [Commented] (PHOENIX-7263) Row value constructor split keys not allowed on indexes

[ https://issues.apache.org/jira/browse/PHOENIX-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824497#comment-17824497 ] ASF GitHub Bot commented on PHOENIX-7263: - chrajeshbabu opened a new pull request, #1850: URL:

[PR] PHOENIX-7263 Row value constructor split keys not allowed on indexes [phoenix]

chrajeshbabu opened a new pull request, #1850: URL: https://github.com/apache/phoenix/pull/1850 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (PHOENIX-7251) Refactor server-side code to support multiple ServerMetadataCache for HA tests

[ https://issues.apache.org/jira/browse/PHOENIX-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824493#comment-17824493 ] ASF GitHub Bot commented on PHOENIX-7251: - palashc commented on PR #1845: URL:

Re: [PR] PHOENIX-7251 : Refactor server-side code to support multiple ServerMetadataCache for ITs which create multiple RSs or mini clusters [phoenix]

palashc commented on PR #1845: URL: https://github.com/apache/phoenix/pull/1845#issuecomment-1984109150 Checkstyle - INSTANCE variable does not match static variable name pattern but it was already present in code, we just refactored in this PR. - new class does have license but it's

[jira] [Commented] (PHOENIX-7251) Refactor server-side code to support multiple ServerMetadataCache for HA tests

[ https://issues.apache.org/jira/browse/PHOENIX-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824482#comment-17824482 ] ASF GitHub Bot commented on PHOENIX-7251: - shahrs87 commented on PR #1845: URL:

Re: [PR] PHOENIX-7251 : Refactor server-side code to support multiple ServerMetadataCache for ITs which create multiple RSs or mini clusters [phoenix]

shahrs87 commented on PR #1845: URL: https://github.com/apache/phoenix/pull/1845#issuecomment-1984033676 @palashc There are still 2 checkstyle and 1 spotbugs warning. Mind taking a look? spotbugs warning is relevant in this case. -- This is an automated message from the Apache Git

[jira] [Commented] (PHOENIX-7123) Support for multi-column split keys

[ https://issues.apache.org/jira/browse/PHOENIX-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824377#comment-17824377 ] Rajeshbabu Chintaguntla commented on PHOENIX-7123: -- I think this has been supported