[jira] [Commented] (PHOENIX-4647) Column header doesn't handle optional arguments correctly

2018-08-04 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569268#comment-16569268 ] Thomas D'Silva commented on PHOENIX-4647: - nit: Instead of using the for loop, since SUBSTR 

[jira] [Commented] (PHOENIX-4841) Filters that uses RVC with pk columns where with DESC sort order don't work correctly

2018-08-11 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577333#comment-16577333 ] Thomas D'Silva commented on PHOENIX-4841: - I don't think we can push the filter into the

[jira] [Commented] (PHOENIX-4837) Update deprecated API to the new one. Also make the code a bit java 7 style

2018-08-07 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572138#comment-16572138 ] Thomas D'Silva commented on PHOENIX-4837: - [~vincentpoon] or [~chrajeshbab...@gmail.com] can

[jira] [Commented] (PHOENIX-4838) Remove viewIndexId from PHOENIX protobuf

2018-08-08 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572749#comment-16572749 ] Thomas D'Silva commented on PHOENIX-4838: - I think [~m2je] is going to keep the existing 

[jira] [Commented] (PHOENIX-4841) Filters that uses RVC with pk columns where with DESC sort order don't work correctly

2018-08-13 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578675#comment-16578675 ] Thomas D'Silva commented on PHOENIX-4841: - [~jamestaylor] Inverting the column should work, I

[jira] [Commented] (PHOENIX-4841) Filters that uses RVC with pk columns where with DESC sort order don't work correctly

2018-08-13 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579064#comment-16579064 ] Thomas D'Silva commented on PHOENIX-4841: - Instead of inverting DESC columns in the WHERE

[jira] [Commented] (PHOENIX-4764) Cleanup metadata of child views for a base table that has been dropped

2018-08-14 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580486#comment-16580486 ] Thomas D'Silva commented on PHOENIX-4764: - Currently when we drop a table that has child views

[jira] [Commented] (PHOENIX-4798) Update encoded col qualifiers on the base table correctly

2018-08-16 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583237#comment-16583237 ] Thomas D'Silva commented on PHOENIX-4798: - This spreadsheet details the various mutexes that

[jira] [Commented] (PHOENIX-4848) Do not propagate unrequired metadata changes and handle orphaned child views

2018-08-16 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583214#comment-16583214 ] Thomas D'Silva commented on PHOENIX-4848: - Could you please commit to all the 4.14 branches? >

[jira] [Commented] (PHOENIX-4529) Users should only require RX access to SYSTEM.SEQUENCE table

2018-08-11 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577255#comment-16577255 ] Thomas D'Silva commented on PHOENIX-4529: - Users/teams can create their own tables. A user has

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-11 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577307#comment-16577307 ] Thomas D'Silva commented on PHOENIX-4843: - Thanks [~jamestaylor], I have attached a v5 patch.

[jira] [Commented] (PHOENIX-3817) VerifyReplication using SQL

2018-08-23 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590568#comment-16590568 ] Thomas D'Silva commented on PHOENIX-3817: - Its triggered

[jira] [Comment Edited] (PHOENIX-4869) Empty row when using OFFSET + LIMIT

2018-08-25 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592722#comment-16592722 ] Thomas D'Silva edited comment on PHOENIX-4869 at 8/25/18 10:11 PM: --- I

[jira] [Commented] (PHOENIX-4869) Empty row when using OFFSET + LIMIT

2018-08-25 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592722#comment-16592722 ] Thomas D'Silva commented on PHOENIX-4869: - I mean the minimum number of rows needed to repro

[jira] [Commented] (PHOENIX-4869) Empty row when using OFFSET + LIMIT

2018-08-25 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592715#comment-16592715 ] Thomas D'Silva commented on PHOENIX-4869: - [~gardellajuanpablo] Please provide the DML

[jira] [Commented] (PHOENIX-3178) Row count incorrect for UPSERT SELECT when auto commit is false

2018-08-28 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595500#comment-16595500 ] Thomas D'Silva commented on PHOENIX-3178: - [~swaroopa] there are two test failures, but I think

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-28 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595521#comment-16595521 ] Thomas D'Silva commented on PHOENIX-3547: - [~m2je] I cannot apply the patch cleanly to the 4.x

[jira] [Commented] (PHOENIX-4830) order by primary key desc return wrong results

2018-08-28 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595550#comment-16595550 ] Thomas D'Silva commented on PHOENIX-4830: - [~xucang] The pre commit build had a few test

[jira] [Commented] (PHOENIX-3178) Row count incorrect for UPSERT SELECT when auto commit is false

2018-08-28 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595748#comment-16595748 ] Thomas D'Silva commented on PHOENIX-3178: - +1 [~karanmehta93] can you please commit this patch

[jira] [Commented] (PHOENIX-4849) UPSERT SELECT fails with stale region boundary exception after a split

2018-08-27 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594041#comment-16594041 ] Thomas D'Silva commented on PHOENIX-4849: - [~lhofhansl] Should we always set the max timestamp

[jira] [Commented] (PHOENIX-4869) Empty row when using OFFSET + LIMIT

2018-08-30 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597859#comment-16597859 ] Thomas D'Silva commented on PHOENIX-4869: - Looks like its using the index can you run the query

[jira] [Commented] (PHOENIX-4839) IndexHalfStoreFileReaderGenerator throws NullPointerException

2018-08-29 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596648#comment-16596648 ] Thomas D'Silva commented on PHOENIX-4839: - [~mnpoonia] can you attach a patch for 1.4 that

[jira] [Commented] (PHOENIX-4881) Add config option to throw an exception before running a query if the estimated bytes scanned is larger than a threshold if stats are available

2018-08-30 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597697#comment-16597697 ] Thomas D'Silva commented on PHOENIX-4881: - >From discussion on dev list

[jira] [Commented] (PHOENIX-1481) Improve explain plan documentation

2018-08-30 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597703#comment-16597703 ] Thomas D'Silva commented on PHOENIX-1481: - It would also be helpful to show concrete example

[jira] [Commented] (PHOENIX-4869) Empty row when using OFFSET + LIMIT

2018-08-30 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597709#comment-16597709 ] Thomas D'Silva commented on PHOENIX-4869: - [~gardellajuanpablo] Does increasing

[jira] [Commented] (PHOENIX-4791) Array elements are nullified with joins

2018-09-04 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603687#comment-16603687 ] Thomas D'Silva commented on PHOENIX-4791: - The concurrency test failure is a flapper and the

[jira] [Commented] (PHOENIX-4882) The client re-resolves the table for every projected non-indexed column when there's a local index.

2018-09-05 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604768#comment-16604768 ] Thomas D'Silva commented on PHOENIX-4882: - [~lhofhansl] Would it be possible to add a test to

[jira] [Commented] (PHOENIX-4791) Array elements are nullified with joins

2018-09-05 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604972#comment-16604972 ] Thomas D'Silva commented on PHOENIX-4791: - +1 will get this committed soon. > Array elements

[jira] [Commented] (PHOENIX-4882) The client re-resolves the table for every projected non-indexed column when there's a local index.

2018-09-05 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605099#comment-16605099 ] Thomas D'Silva commented on PHOENIX-4882: - +1 on this fix. We should file a separate JIRA to

[jira] [Commented] (PHOENIX-4893) Phoenix scans SYSCAT region from RegionServerCoprocessor

2018-09-07 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607377#comment-16607377 ] Thomas D'Silva commented on PHOENIX-4893: - We call ViewFinder.findRelatedViews() when adding a

[jira] [Commented] (PHOENIX-4003) Document how to use snapshots for MR

2018-09-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606112#comment-16606112 ] Thomas D'Silva commented on PHOENIX-4003: - [~akshita.malhotra] can you also work on this doc

[jira] [Commented] (PHOENIX-4666) Add a subquery cache that persists beyond the life of a query

2018-09-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609756#comment-16609756 ] Thomas D'Silva commented on PHOENIX-4666: - Those three tests are flappers, we should be good to

[jira] [Commented] (PHOENIX-4868) Create a column attribute IS_EXCLUDED to denote a dropped derived column and remove LinkType.EXCLUDED_COLUMN

2018-08-30 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598093#comment-16598093 ] Thomas D'Silva commented on PHOENIX-4868: - While dropping a column that is inherited from the

[jira] [Commented] (PHOENIX-4966) Implement unhandledFilters in PhoenixRelation so that spark only evaluates filters when required

2018-10-12 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648303#comment-16648303 ] Thomas D'Silva commented on PHOENIX-4966: - [~jmahonin] Thanks for the review. I couldn't figure

[jira] [Commented] (PHOENIX-4089) Prevent index from getting out of sync with data table under high concurrency

2018-10-12 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648397#comment-16648397 ] Thomas D'Silva commented on PHOENIX-4089: - [~abhishektall...@cloudera.com] Please reopen this

[jira] [Comment Edited] (PHOENIX-172) Support the ability for a client to do query more

2018-10-12 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648604#comment-16648604 ] Thomas D'Silva edited comment on PHOENIX-172 at 10/13/18 12:02 AM: ---

[jira] [Commented] (PHOENIX-4877) Consider Adding Developer Documentation for Phoenix Query Execution

2018-10-11 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647217#comment-16647217 ] Thomas D'Silva commented on PHOENIX-4877: - [~dbwong] LGTM, thanks for the contribution. Please

[jira] [Commented] (PHOENIX-4964) ORDER BY should use a LOCAL index even if the query is not fully covered

2018-10-11 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647393#comment-16647393 ] Thomas D'Silva commented on PHOENIX-4964: - +1, it would be good if you assert that the rows

[jira] [Commented] (PHOENIX-172) Support the ability for a client to do query more

2018-10-12 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648604#comment-16648604 ] Thomas D'Silva commented on PHOENIX-172: [~lhofhansl] I was looking through this JIRA and saw

[jira] [Commented] (PHOENIX-172) Support the ability for a client to do query more

2018-10-15 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650758#comment-16650758 ] Thomas D'Silva commented on PHOENIX-172: The sql standard for RVC does involve comparing each

[jira] [Commented] (PHOENIX-4815) support alter table modify column

2018-10-15 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650931#comment-16650931 ] Thomas D'Silva commented on PHOENIX-4815: - Sorry [~Jaanai], was busy with $dayjob will look

[jira] [Commented] (PHOENIX-4942) Move MetaDataEndpointImplTest to integration test

2018-10-15 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650975#comment-16650975 ] Thomas D'Silva commented on PHOENIX-4942: - please review [~ckulkarni] > Move

[jira] [Commented] (PHOENIX-4973) Pherf standalone script (pherf-standalone.py) is failing with class-path issues

2018-10-16 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651240#comment-16651240 ] Thomas D'Silva commented on PHOENIX-4973: - I added you as a contributor, you should be able to

[jira] [Commented] (PHOENIX-4976) Comparisson on RVC are still incorrect

2018-10-16 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652085#comment-16652085 ] Thomas D'Silva commented on PHOENIX-4976: - Might be related to Phoenix-4841. [~dbwong] can you

[jira] [Commented] (PHOENIX-4841) Filters that uses RVC with pk columns where with DESC sort order don't work correctly

2018-10-16 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652114#comment-16652114 ] Thomas D'Silva commented on PHOENIX-4841: - If the rvc has all the leading columns of the

[jira] [Commented] (PHOENIX-4975) Fix failing unit tests for Omid due to shadow cells and no local indexes

2018-10-16 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652464#comment-16652464 ] Thomas D'Silva commented on PHOENIX-4975: - In IndexToolIT if the transaction provided does not

[jira] [Commented] (PHOENIX-4552) Allow ROW_TIMESTAMP declaration for non PK column

2018-10-18 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656009#comment-16656009 ] Thomas D'Silva commented on PHOENIX-4552: - Thanks [~spetschu], I filed PHOENIX-4983. > Allow

[jira] [Comment Edited] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause to support paging in tables where the sort order of PK columns varies

2018-10-18 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655867#comment-16655867 ] Thomas D'Silva edited comment on PHOENIX-4845 at 10/18/18 9:04 PM: ---

[jira] [Commented] (PHOENIX-4988) Incorrect index rowkey generated when updating only non-indexed columns after a delete

2018-10-22 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659995#comment-16659995 ] Thomas D'Silva commented on PHOENIX-4988: - Nice find [~vincentpoon]. So

[jira] [Commented] (PHOENIX-4981) Add tests for salted table using phoenix-spark

2018-10-19 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657102#comment-16657102 ] Thomas D'Silva commented on PHOENIX-4981: - [~ckulkarni] Can you please review? > Add tests for

[jira] [Commented] (PHOENIX-4975) Fix failing unit tests for Omid due to shadow cells and no local indexes

2018-10-19 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657076#comment-16657076 ] Thomas D'Silva commented on PHOENIX-4975: - [~jamestaylor] A few tests in

[jira] [Commented] (PHOENIX-4872) BulkLoad has bug when loading on single-cell-array-with-offsets table.

2018-10-29 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667779#comment-16667779 ] Thomas D'Silva commented on PHOENIX-4872: - +1 thanks for the contribution. > BulkLoad has bug

[jira] [Commented] (PHOENIX-4971) Drop index will execute successfully using Incorrect name of parent tables

2018-10-31 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670729#comment-16670729 ] Thomas D'Silva commented on PHOENIX-4971: - Ping [~Jaanai] please fix this test failure so that

[jira] [Commented] (PHOENIX-4996) Refactor PTableImpl to use Builder Pattern

2018-10-26 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665542#comment-16665542 ] Thomas D'Silva commented on PHOENIX-4996: - Thanks for taking this on Chinmay, this refactoring

[jira] [Comment Edited] (PHOENIX-4971) Drop index will execute successfully using Incorrect name of parent tables

2018-10-30 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669421#comment-16669421 ] Thomas D'Silva edited comment on PHOENIX-4971 at 10/30/18 11:14 PM:

[jira] [Commented] (PHOENIX-4971) Drop index will execute successfully using Incorrect name of parent tables

2018-10-30 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669421#comment-16669421 ] Thomas D'Silva commented on PHOENIX-4971: - [~Jaanai] This patch is causing some test failures

[jira] [Commented] (PHOENIX-4891) An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table

2018-10-26 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665652#comment-16665652 ] Thomas D'Silva commented on PHOENIX-4891: - [~ckulkarni] the patch doesn't apply cleanly on the

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause to support paging in tables where the sort order of PK columns varies

2018-10-26 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665745#comment-16665745 ] Thomas D'Silva commented on PHOENIX-4845: - [~dbwong] So if you see that the RVC has a column

[jira] [Commented] (PHOENIX-5003) Fix ViewIT.testCreateViewMappedToExistingHbaseTableWithNamespaceMappingEnabled()

2018-11-02 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673844#comment-16673844 ] Thomas D'Silva commented on PHOENIX-5003: - [~kozdemir] this test is failing after your addendum

[jira] [Commented] (PHOENIX-4971) Drop index will execute successfully using Incorrect name of parent tables

2018-11-05 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675791#comment-16675791 ] Thomas D'Silva commented on PHOENIX-4971: - ping [~gjacoby] can you take a look at [~Jaanai]'s

[jira] [Commented] (PHOENIX-5005) Server-side delete / upsert-select potentially blocked after a split

2018-11-08 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680677#comment-16680677 ] Thomas D'Silva commented on PHOENIX-5005: - [~vincentpoon] The v2 patch still does {code}

[jira] [Commented] (PHOENIX-5005) Server-side delete / upsert-select potentially blocked after a split

2018-11-08 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680731#comment-16680731 ] Thomas D'Silva commented on PHOENIX-5005: - Should we add the same logic to wait till maxWait in

[jira] [Commented] (PHOENIX-4981) Add tests for ORDER BY, GROUP BY, salted tables using phoenix-spark

2018-11-12 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684473#comment-16684473 ] Thomas D'Silva commented on PHOENIX-4981: - [~jamestaylor] I think the error about "Received

[jira] [Commented] (PHOENIX-4981) Add tests for ORDER BY, GROUP BY, salted tables using phoenix-spark

2018-11-12 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684563#comment-16684563 ] Thomas D'Silva commented on PHOENIX-4981: - I tried setting https.protocols using the

[jira] [Commented] (PHOENIX-4841) Filters that uses RVC with pk columns where with DESC sort order don't work correctly

2018-11-12 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684482#comment-16684482 ] Thomas D'Silva commented on PHOENIX-4841: - [~dbwong] does  SplitIT pass for you locally? >

[jira] [Commented] (PHOENIX-4981) Add tests for ORDER BY, GROUP BY, salted tables using phoenix-spark

2018-11-11 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683092#comment-16683092 ] Thomas D'Silva commented on PHOENIX-4981: - [~jamestaylor] I am able to build the 4.x-HBase-1.3

[jira] [Commented] (PHOENIX-4764) Cleanup metadata of child views for a base table that has been dropped

2018-11-13 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685900#comment-16685900 ] Thomas D'Silva commented on PHOENIX-4764: - [~jamestaylor] I filed PHOENIX-5017 to fix the test

[jira] [Commented] (PHOENIX-5000) Make SecureUserConnectionsTest as Integration test

2018-11-13 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685907#comment-16685907 ] Thomas D'Silva commented on PHOENIX-5000: - +1 > Make SecureUserConnectionsTest as Integration

[jira] [Commented] (PHOENIX-5017) Fix testRecreateViewWhoseParentWasDropped test flapper

2018-11-13 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685906#comment-16685906 ] Thomas D'Silva commented on PHOENIX-5017: - Please review [~karanmehta93] > Fix

[jira] [Commented] (PHOENIX-4764) Cleanup metadata of child views for a base table that has been dropped

2018-11-15 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688756#comment-16688756 ] Thomas D'Silva commented on PHOENIX-4764: - [~jamestaylor] I tries a single node local setup

[jira] [Commented] (PHOENIX-4841) Filters that uses RVC with pk columns where with DESC sort order don't work correctly

2018-11-15 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688716#comment-16688716 ] Thomas D'Silva commented on PHOENIX-4841: - [~dbwong] The latest patch doesn't apply cleanly to

[jira] [Commented] (PHOENIX-5021) Remove SplitIT from the 4.x-HBase-1.4 and master branch

2018-11-15 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688949#comment-16688949 ] Thomas D'Silva commented on PHOENIX-5021: - In HBase 1.4 and 2.x these tests do not behave

[jira] [Commented] (PHOENIX-5013) Increase timeout for Tephra discovery service

2018-11-15 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688636#comment-16688636 ] Thomas D'Silva commented on PHOENIX-5013: - Actually Networks.getRandomPort() doesn't set

[jira] [Commented] (PHOENIX-4971) Drop index will execute successfully using Incorrect name of parent tables

2018-11-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677335#comment-16677335 ] Thomas D'Silva commented on PHOENIX-4971: - [~Jaanai] Thanks for the addendum, but I think

[jira] [Commented] (PHOENIX-4841) Filters that uses RVC with pk columns where with DESC sort order don't work correctly

2018-11-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677404#comment-16677404 ] Thomas D'Silva commented on PHOENIX-4841: - [~dbwong] can you please rebase you patch, it doesn

[jira] [Commented] (PHOENIX-374) Enable access to dynamic columns in * or cf.* selection

2018-11-14 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687281#comment-16687281 ] Thomas D'Silva commented on PHOENIX-374: When we do a select * or Select CF.* we current only

[jira] [Commented] (PHOENIX-5005) Server-side delete / upsert-select potentially blocked after a split

2018-11-09 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681828#comment-16681828 ] Thomas D'Silva commented on PHOENIX-5005: - +1 > Server-side delete / upsert-select potentially

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause to support paging in tables where the sort order of PK columns varies

2018-11-12 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684314#comment-16684314 ] Thomas D'Silva commented on PHOENIX-4845: - I think having a way to page through data

[jira] [Commented] (PHOENIX-4764) Cleanup metadata of child views for a base table that has been dropped

2018-11-13 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685671#comment-16685671 ] Thomas D'Silva commented on PHOENIX-4764: - James Taylor I am looking into the test failure now. 

[jira] [Commented] (PHOENIX-4949) IndexTool - updateIndexState called too many times unnecessarily

2018-10-04 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638851#comment-16638851 ] Thomas D'Silva commented on PHOENIX-4949: - [~gjacoby] If any of the map tasks fails, will the

[jira] [Commented] (PHOENIX-3950) IndexTool marks index active even when index building fails

2018-10-04 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638883#comment-16638883 ] Thomas D'Silva commented on PHOENIX-3950: - [~gjacoby] [~vincentpoon] Since we only have one

[jira] [Commented] (PHOENIX-4917) ClassCastException when projecting array elements in hash join

2018-10-03 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637291#comment-16637291 ] Thomas D'Silva commented on PHOENIX-4917: - [~sangudi] ok, I missed that. If I run the test

[jira] [Commented] (PHOENIX-4917) ClassCastException when projecting array elements in hash join

2018-10-03 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637489#comment-16637489 ] Thomas D'Silva commented on PHOENIX-4917: - You can do PInteger.INSTANCE.toBytes(10) >

[jira] [Commented] (PHOENIX-4930) Add test for a ORDER BY and LIMIT queries during a split

2018-09-27 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631247#comment-16631247 ] Thomas D'Silva commented on PHOENIX-4930: - [~lhofhansl] Thanks for the review. I have updated

[jira] [Commented] (PHOENIX-3955) Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL properties stay in sync between the physical data table and index tables

2018-09-27 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631352#comment-16631352 ] Thomas D'Silva commented on PHOENIX-3955: - [~ckulkarni] The patch doesn't apply clean to the

[jira] [Commented] (PHOENIX-4930) Add test for a ORDER BY and LIMIT queries during a split

2018-09-28 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632676#comment-16632676 ] Thomas D'Silva commented on PHOENIX-4930: - [~lhofhansl] I attached an addendum to fix a

[jira] [Commented] (PHOENIX-4934) Make BaseTest.splitSystemCatalog generic

2018-09-28 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632685#comment-16632685 ] Thomas D'Silva commented on PHOENIX-4934: - [~karanmehta93] please review. > Make

[jira] [Commented] (PHOENIX-4552) Allow ROW_TIMESTAMP declaration for non PK column

2018-10-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645641#comment-16645641 ] Thomas D'Silva commented on PHOENIX-4552: - [~spetschu] Is the main reason you want support for

[jira] [Commented] (PHOENIX-4963) Do not throw when transitioning to PENDING_DISABLE if index is already disabled

2018-10-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645969#comment-16645969 ] Thomas D'Silva commented on PHOENIX-4963: - So if a client tries to change the index state from

[jira] [Comment Edited] (PHOENIX-4963) Do not throw when transitioning to PENDING_DISABLE if index is already disabled

2018-10-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645969#comment-16645969 ] Thomas D'Silva edited comment on PHOENIX-4963 at 10/11/18 4:43 AM: ---

[jira] [Commented] (PHOENIX-4917) ClassCastException when projecting array elements in hash join

2018-10-01 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634721#comment-16634721 ] Thomas D'Silva commented on PHOENIX-4917: - Thanks [~sangudi]! > ClassCastException when

[jira] [Commented] (PHOENIX-4936) Empty resultset returned when hbase.rpc.timeout hit

2018-10-01 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634472#comment-16634472 ] Thomas D'Silva commented on PHOENIX-4936: - If you run the corresponding HBase scan, does it

[jira] [Commented] (PHOENIX-4957) IndexTool incorrectly uses index when rebuilding an active index

2018-10-05 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640499#comment-16640499 ] Thomas D'Silva commented on PHOENIX-4957: - +1 LGTM > IndexTool incorrectly uses index when

[jira] [Commented] (PHOENIX-4855) Continue to write base table column metadata when creating a view in order to support rollback

2018-10-06 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640869#comment-16640869 ] Thomas D'Silva commented on PHOENIX-4855: - [~jamestaylor] Sorry about that, I have committed an

[jira] [Commented] (PHOENIX-4917) ClassCastException when projecting array elements in hash join

2018-09-29 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632847#comment-16632847 ] Thomas D'Silva commented on PHOENIX-4917: - You can just use {{BaseTest.splitTable}} to split a

[jira] [Commented] (PHOENIX-4882) The client re-resolves the table for every projected non-indexed column when there's a local index.

2018-08-31 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599066#comment-16599066 ] Thomas D'Silva commented on PHOENIX-4882: - We can probably be smarter about resolving the data

[jira] [Commented] (PHOENIX-4008) UPDATE STATISTIC should collect all versions of cells

2018-09-20 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622874#comment-16622874 ] Thomas D'Silva commented on PHOENIX-4008: - +1 LGTM, those are flappers and can be ignored. >

[jira] [Commented] (PHOENIX-4815) support alter table modify column

2018-09-20 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622908#comment-16622908 ] Thomas D'Silva commented on PHOENIX-4815: - [~Jaanai] Thanks for your patch. After

[jira] [Commented] (PHOENIX-4849) UPSERT SELECT fails with stale region boundary exception after a split

2018-09-24 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626582#comment-16626582 ] Thomas D'Silva commented on PHOENIX-4849: - The existing special case check we had for

[jira] [Commented] (PHOENIX-4921) Change SerialIterators to call peek() so that we can detect if the table split and we need to reload the table region cache.

2018-09-24 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626590#comment-16626590 ] Thomas D'Silva commented on PHOENIX-4921: - FYI [~lhofhansl] > Change SerialIterators to call

  1   2   3   4   >