lokiore commented on PR #1551:
URL: https://github.com/apache/phoenix/pull/1551#issuecomment-1398803857
@mnpoonia
`org.apache.phoenix.execute.PartialCommitIT.testUpsertSelectFailure` is failing
for the PR which started failing after
https://github.com/apache/phoenix/commit/8b688fcbe16f89b2
stoty opened a new pull request, #113:
URL: https://github.com/apache/phoenix-queryserver/pull/113
…r test image for phoenixdb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
Abhey opened a new pull request, #92:
URL: https://github.com/apache/phoenix-connectors/pull/92
This PR introduces the changes for adding the PySpark code references in the
phoenix5-spark3 connector README.
--
This is an automated message from the Apache Git Service.
To respond to the mes
stoty commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1400367248
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m 18s | Doc
stoty commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1400381667
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 3s | Doc
stoty commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1400404549
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s | Doc
stoty commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1400626524
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 6s | Doc
stoty commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1400651464
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 0s | Do
Abhey commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1400653837
@virajjasani @tkhurana Please review the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tkhurana closed pull request #1516: PHOENIX-6807 Change return type of
PHOENIX_ROW_TIMESTAMP() function
URL: https://github.com/apache/phoenix/pull/1516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
virajjasani commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1400759569
@stoty you might also be interested in this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
virajjasani commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1400759783
Thanks for the PR @Abhey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
virajjasani commented on PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#issuecomment-1400766603
I think we should remove formatting changes from this PR, to have smooth
backports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
stoty commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1400769839
Would it be possible to add the relevant changes to the Spark2 README ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
virajjasani commented on code in PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#discussion_r1084400178
##
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##
@@ -1411,8 +1431,6 @@ public List getMutationList() {
child.sto
virajjasani commented on code in PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#discussion_r1084400178
##
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##
@@ -1411,8 +1431,6 @@ public List getMutationList() {
child.sto
stoty commented on code in PR #92:
URL: https://github.com/apache/phoenix-connectors/pull/92#discussion_r1084392227
##
phoenix5-spark3/README.md:
##
@@ -15,18 +15,59 @@ See the License for the specific language governing
permissions and
limitations under the License.
-->
-p
kadirozde commented on code in PR #1551:
URL: https://github.com/apache/phoenix/pull/1551#discussion_r1084482589
##
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java:
##
@@ -105,6 +105,8 @@ public class TableResultIterator implements ResultIterator {
kadirozde commented on code in PR #1551:
URL: https://github.com/apache/phoenix/pull/1551#discussion_r1084565051
##
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java:
##
@@ -115,6 +111,7 @@ public class TableResultIterator implements ResultIterator {
lokiore commented on code in PR #1551:
URL: https://github.com/apache/phoenix/pull/1551#discussion_r1084570587
##
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java:
##
@@ -115,6 +111,7 @@ public class TableResultIterator implements ResultIterator {
virajjasani commented on code in PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#discussion_r1084397300
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricType.java:
##
@@ -208,23 +209,23 @@ private MetricType(String shortName, String description,
LogL
stoty commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1084883581
##
phoenix-core/src/main/antlr3/PhoenixSQL.g:
##
@@ -704,19 +707,31 @@ column_defs returns [List ret]
: v = column_def {$ret.add(v);} (COMMA v = column_def {$ret.a
richardantal commented on PR #114:
URL:
https://github.com/apache/phoenix-queryserver/pull/114#issuecomment-1401550210
Thanks @stoty I updated the ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
richardantal merged PR #114:
URL: https://github.com/apache/phoenix-queryserver/pull/114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
stoty closed pull request #113: PHOENIX-6858 Add Python 3.11 to supported
languages, and update docke…
URL: https://github.com/apache/phoenix-queryserver/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Aarchy commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1085127414
##
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##
@@ -2614,7 +2628,47 @@ else if
(!SchemaUtil.isSystemTable(Bytes.toBytes(SchemaUtil.getTa
Aarchy commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1085127414
##
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##
@@ -2614,7 +2628,47 @@ else if
(!SchemaUtil.isSystemTable(Bytes.toBytes(SchemaUtil.getTa
Aarchy commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1085154185
##
phoenix-core/src/main/antlr3/PhoenixSQL.g:
##
@@ -704,19 +707,31 @@ column_defs returns [List ret]
: v = column_def {$ret.add(v);} (COMMA v = column_def {$ret.
stoty commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1085332725
##
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##
@@ -2614,7 +2628,47 @@ else if
(!SchemaUtil.isSystemTable(Bytes.toBytes(SchemaUtil.getTab
stoty commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1085354653
##
phoenix-core/src/main/antlr3/PhoenixSQL.g:
##
@@ -704,19 +707,31 @@ column_defs returns [List ret]
: v = column_def {$ret.add(v);} (COMMA v = column_def {$ret.a
lokiore commented on PR #1551:
URL: https://github.com/apache/phoenix/pull/1551#issuecomment-1402735903
@kadirozde, locally also only 1 test is failing which I mentioned above! and
I have addressed the comments. Thanks!
--
This is an automated message from the Apache Git Service.
To respo
chrajeshbabu merged PR #125:
URL: https://github.com/apache/phoenix-omid/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@pho
kadirozde merged PR #1551:
URL: https://github.com/apache/phoenix/pull/1551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.a
Aarchy commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1086761668
##
phoenix-core/src/main/java/org/apache/phoenix/parse/CreateTableStatement.java:
##
@@ -83,11 +87,13 @@ public CreateTableStatement(CreateTableStatement
createTable, L
Aarchy commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1086762675
##
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##
@@ -2614,7 +2628,47 @@ else if
(!SchemaUtil.isSystemTable(Bytes.toBytes(SchemaUtil.getTa
stoty commented on PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#issuecomment-1404137118
We already have the DEFAULT_COLUMN_FAMILY property, where we specify column
families in a table property.
According to the grammar page:
DEFAULT_COLUMN_FAMILY string option det
stoty commented on PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#issuecomment-1404139508
i.e.
`COLUMN_QUALIFIER_COUNTER ('A'=14, 'B'=13, 'a'=5)`
Of course it's also worth checking the the docs I quoted above is correct.
--
This is an automated message from the Apach
lokiore opened a new pull request, #1555:
URL: https://github.com/apache/phoenix/pull/1555
…tor (#1551)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
stoty closed pull request #1554: PHOENIX-6862 Phoenix-client jar relocates
log4j2
URL: https://github.com/apache/phoenix/pull/1554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
stoty opened a new pull request, #115:
URL: https://github.com/apache/phoenix-queryserver/pull/115
…th Phoenix 5.2
- make javax.servlet relocation a build time option controlled by a profile
- update default phoenix version to 5.1.3 and HBase to 2.4.12
- add log4j2 logging test d
virajjasani merged PR #1555:
URL: https://github.com/apache/phoenix/pull/1555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
virajjasani commented on PR #1551:
URL: https://github.com/apache/phoenix/pull/1551#issuecomment-1405623444
> @mnpoonia
`org.apache.phoenix.execute.PartialCommitIT.testUpsertSelectFailure` is failing
for the PR which started failing after
[8b688fc](https://github.com/apache/phoenix/commit/
stoty closed pull request #115: PHOENIX-6861 PQS fails to start because of
relocated javax.servlet wi…
URL: https://github.com/apache/phoenix-queryserver/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
stoty opened a new pull request, #116:
URL: https://github.com/apache/phoenix-queryserver/pull/116
Document the problem as a known issue, and refer to the ticket for workaround
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
stoty closed pull request #116: PHOENIX-6863 PhoenixDB 1.2+ doesn't work with
Python2 on some systems
URL: https://github.com/apache/phoenix-queryserver/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
stoty commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1090229132
##
phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java:
##
@@ -289,22 +289,33 @@ public PropertyName propertyName(String familyName,
String propert
stoty closed pull request #1553: PHOENIX-6720 "create table" can't recreate
column encoded tables that had columns dropped
URL: https://github.com/apache/phoenix/pull/1553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Abhey commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1409230823
Thanks, @stoty for reviewing the PR. I will take a look at your review
comments and address the same.
--
This is an automated message from the Apache Git Service.
To respond to th
Abhey commented on PR #92:
URL:
https://github.com/apache/phoenix-connectors/pull/92#issuecomment-1409232833
@stoty One question for you, I created a Docker Image with all the
Pre-Requisites for testing the Phoenix-Spark connector. Do you think it's a
good idea to add the reference to the
kadirozde commented on PR #1531:
URL: https://github.com/apache/phoenix/pull/1531#issuecomment-1409550066
@tkhurana, @gjacoby126, please let me know if you have further review
comments. I think I addressed or replied to all your comments. Thanks
--
This is an automated message from the Ap
Aarchy opened a new pull request, #1556:
URL: https://github.com/apache/phoenix/pull/1556
…ad columns dropped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
stoty closed pull request #1556: PHOENIX-6720 CREATE TABLE can't recreate
column encoded tables that h…
URL: https://github.com/apache/phoenix/pull/1556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty commented on PR #1552:
URL: https://github.com/apache/phoenix/pull/1552#issuecomment-1410838918
I suggest using a more generic name, like PhoenixMasterObserver.
This will make our lives easier if we ever need to more features to it.
--
This is an automated message from the Apa
richardantal closed pull request #1244: Phoenix 6485 4.x
URL: https://github.com/apache/phoenix/pull/1244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
mnpoonia commented on PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#issuecomment-1418709847
@virajjasani I have removed all the whitespace and indentation changes.
Please review now.
@tkhurana FYI
--
This is an automated message from the Apache Git Service.
To respond to t
mnpoonia commented on PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#issuecomment-1418721088
PR for 5.1 branch
https://github.com/apache/phoenix/pull/1557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
virajjasani merged PR #1546:
URL: https://github.com/apache/phoenix/pull/1546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
tkhurana merged PR #1557:
URL: https://github.com/apache/phoenix/pull/1557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.ap
virajjasani commented on PR #1557:
URL: https://github.com/apache/phoenix/pull/1557#issuecomment-1419628782
The build in progress:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/view/change-requests/job/PR-1557/2/
--
This is an automated message from the Apache G
stoty commented on PR #1545:
URL: https://github.com/apache/phoenix/pull/1545#issuecomment-1420352317
This was tracked and commit with the following JIRA:
https://issues.apache.org/jira/browse/PHOENIX-6848
--
This is an automated message from the Apache Git Service.
To respond to th
virajjasani merged PR #1558:
URL: https://github.com/apache/phoenix/pull/1558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
stoty opened a new pull request, #117:
URL: https://github.com/apache/phoenix-queryserver/pull/117
…ns in PQS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
mnpoonia commented on PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#issuecomment-1423998901
@tkhurana FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
stoty opened a new pull request, #1560:
URL: https://github.com/apache/phoenix/pull/1560
…verytime in PhoenixAccessController class
Co-authored-by: vmeka2020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gourabtaparia commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1101494720
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -502,9 +503,10 @@ private void
populateRowsToLock(MiniBatchOperation
mnpoonia commented on PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#issuecomment-1424309113
Test failure
_FailoverPhoenixConnectionIT.testConnectionWhenActiveZKRestarts_
It seems unrelated.
--
This is an automated message from the Apache Git Service.
To respond
tkhurana commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1101829246
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -502,9 +503,10 @@ private void
populateRowsToLock(MiniBatchOperationInPro
tkhurana commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1101829246
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -502,9 +503,10 @@ private void
populateRowsToLock(MiniBatchOperationInPro
stoty opened a new pull request, #118:
URL: https://github.com/apache/phoenix-queryserver/pull/118
also mention the option to install from PyPI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
virajjasani commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1102259231
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -227,7 +228,7 @@ public static class BatchMutateContext {
// The
mnpoonia commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1102313724
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -502,9 +503,10 @@ private void
populateRowsToLock(MiniBatchOperationInPro
mnpoonia commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1102313913
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -227,7 +228,7 @@ public static class BatchMutateContext {
// The co
mnpoonia commented on PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#issuecomment-1425252636
@gourabtaparia @tkhurana @virajjasani Please review and merge if changes
look good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
stoty closed pull request #118: PHOENIX-6812 Add the pip requirements install
step to the README
URL: https://github.com/apache/phoenix-queryserver/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
stoty opened a new pull request, #1562:
URL: https://github.com/apache/phoenix/pull/1562
…onScanner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gjacoby126 commented on PR #1560:
URL: https://github.com/apache/phoenix/pull/1560#issuecomment-1425777413
Generally looks good -- are there any concerns about what happens if the
HBase connection gets into a bad state? Would the operator have to bounce the
region server if that happened?
stoty commented on PR #1560:
URL: https://github.com/apache/phoenix/pull/1560#issuecomment-1425820014
The same question occured to me.
However, when we use ServerUtil.ConnectionFactory, we are always getting the
same Connection instance (per env), so storing the reference in the copro
gjacoby126 commented on code in PR #1563:
URL: https://github.com/apache/phoenix/pull/1563#discussion_r1102943974
##
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java:
##
@@ -90,26 +89,33 @@ public StoreFileReader
preStoreFil
gjacoby126 commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1102958695
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -227,7 +228,7 @@ public static class BatchMutateContext {
// The
gjacoby126 commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1102960388
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -227,7 +228,7 @@ public static class BatchMutateContext {
// The
stoty commented on PR #1560:
URL: https://github.com/apache/phoenix/pull/1560#issuecomment-1426116389
Thank you @gjacoby126 .
My explanation above has a mistake, there is one connection per
ConnectionType, not one per RegionCoprocessorEnvironment.
The API for ServerUtil.Connec
stoty closed pull request #1560: PHOENIX-6395 Reusing Connection instance
object instead of creating e…
URL: https://github.com/apache/phoenix/pull/1560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty closed pull request #1562: PHOENIX-6872 Use ServerUtil.getConnection() in
UngroupedAggregateRegi…
URL: https://github.com/apache/phoenix/pull/1562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty opened a new pull request, #1564:
URL: https://github.com/apache/phoenix/pull/1564
…nection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: is
stoty opened a new pull request, #1565:
URL: https://github.com/apache/phoenix/pull/1565
…nection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: is
virajjasani commented on PR #1561:
URL: https://github.com/apache/phoenix/pull/1561#issuecomment-1426303275
FYI @shahrs87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
virajjasani commented on PR #1565:
URL: https://github.com/apache/phoenix/pull/1565#issuecomment-1426320059
The changes look good. I was thinking, can we make `hbasexy.compat.version`
as `${hbase-x.y.runtime.version}` for each compat module?
Like `hbase23.compat.version` as `${hbase-2
gjacoby126 commented on PR #1531:
URL: https://github.com/apache/phoenix/pull/1531#issuecomment-1426409762
Kicked off a new PR build to check the Yetus results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
virajjasani commented on PR #1565:
URL: https://github.com/apache/phoenix/pull/1565#issuecomment-1426426903
nvm, this is not required to be handled here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
virajjasani commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1103525695
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -227,7 +228,7 @@ public static class BatchMutateContext {
// The
stoty closed pull request #1564: PHOENIX-6874 Support older HBase versions with
broken ShortCircuitCon…
URL: https://github.com/apache/phoenix/pull/1564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty closed pull request #1565: PHOENIX-6874 Support older HBase versions with
broken ShortCircuitCon…
URL: https://github.com/apache/phoenix/pull/1565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty closed pull request #1563: PHOENIX-6873 Use cached Connection in
IndexHalfStoreFileReaderGenerator
URL: https://github.com/apache/phoenix/pull/1563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mnpoonia commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1104605952
##
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -227,7 +228,7 @@ public static class BatchMutateContext {
// The co
tkhurana merged PR #1559:
URL: https://github.com/apache/phoenix/pull/1559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.ap
virajjasani commented on PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#issuecomment-1428566004
Belated +1, thank you @mnpoonia!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
lucakovacs opened a new pull request, #119:
URL: https://github.com/apache/phoenix-queryserver/pull/119
In this change:
- I added a new **servlet (/prometheus)** for exposing Prometheus format
metrics
- The metrics' **description** can be enabled by
`"/prometheus?description=true
stoty commented on code in PR #127:
URL: https://github.com/apache/phoenix-omid/pull/127#discussion_r1107158161
##
pom.xml:
##
@@ -1071,6 +1071,13 @@
${netty4.version}
+
Review Comment:
If we add a dependencyManagement
stoty commented on PR #127:
URL: https://github.com/apache/phoenix-omid/pull/127#issuecomment-1431455088
I can see a test error, but that was already present earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
richardantal commented on PR #127:
URL: https://github.com/apache/phoenix-omid/pull/127#issuecomment-1431456099
Thanks @stoty for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
1 - 100 of 6109 matches
Mail list logo
