[jira] [Updated] (RATIS-122) Add a FileStore example

2017-11-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-122: -- Attachment: r122_20171103.patch r122_20171103.patch: removes unused import "Raft.proto".

[jira] [Created] (RATIS-129) Compile protobuf and shade if the shaded source directory is missing

2017-11-03 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-129: - Summary: Compile protobuf and shade if the shaded source directory is missing Key: RATIS-129 URL: https://issues.apache.org/jira/browse/RATIS-129 Project:

[jira] [Commented] (RATIS-134) PeerProxyMap#addPeers should add peers only if it is not already present in the proxymap

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240755#comment-16240755 ] Tsz Wo Nicholas Sze commented on RATIS-134: --- Thanks, Mukul. We should use {code}

[jira] [Commented] (RATIS-132) Support simple 'mvn clean compile' command (move shading before the compile phase)

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240886#comment-16240886 ] Tsz Wo Nicholas Sze commented on RATIS-132: --- Just have tried the patch. It fails when I run

[jira] [Commented] (RATIS-132) Support simple 'mvn clean compile' command (move shading before the compile phase)

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240894#comment-16240894 ] Tsz Wo Nicholas Sze commented on RATIS-132: --- The directory for org.apache.ratis.shaded.proto

[jira] [Commented] (RATIS-135) Closed segments contribute to leaked memory as eviction policies are not honoured

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240771#comment-16240771 ] Tsz Wo Nicholas Sze commented on RATIS-135: --- Good catch Mukul. After applied the patch,

[jira] [Updated] (RATIS-132) Support simple 'mvn clean compile' command (move shading before the compile phase)

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-132: -- Description: The current situation is described in the BUILDING.md: {code} When

[jira] [Commented] (RATIS-129) Compile protobuf and shade if the shaded source directory is missing

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240791#comment-16240791 ] Tsz Wo Nicholas Sze commented on RATIS-129: --- Marton, thanks for pointing out that the profile

[jira] [Commented] (RATIS-132) Support simple 'mvn clean compile' command (move shading before the compile phase)

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240908#comment-16240908 ] Tsz Wo Nicholas Sze commented on RATIS-132: --- The generated proto java files are in

[jira] [Commented] (RATIS-136) Reduce log level for segment rollover

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240779#comment-16240779 ] Tsz Wo Nicholas Sze commented on RATIS-136: --- Thanks Mukul. Please do not change ConfUtils since

[jira] [Updated] (RATIS-133) Raft gRPC client should check proto size before sending a message

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-133: -- Description: Raft client should check the entry size before the command is send, This

[jira] [Commented] (RATIS-132) Support simple 'mvn clean compile' command (move shading before the compile phase)

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240803#comment-16240803 ] Tsz Wo Nicholas Sze commented on RATIS-132: --- [~elek], thanks a lot for fixing this. Your

[jira] [Commented] (RATIS-113) Add Async send interface to RaftClient

2017-11-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241181#comment-16241181 ] Tsz Wo Nicholas Sze commented on RATIS-113: --- - Actually, the default sendRequestAsync

[jira] [Updated] (RATIS-122) Add a FileStore example

2017-11-01 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-122: -- Attachment: r122_20171101b.patch r122_20171101b.patch: fixes test failures. All unit

[jira] [Commented] (RATIS-102) Clean generated sources as part of the default clean lifecycle

2017-11-02 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236604#comment-16236604 ] Tsz Wo Nicholas Sze commented on RATIS-102: --- > There are new WARNINGs from mvn (for any goal).

[jira] [Updated] (RATIS-125) The cause in a StateMachineException is not sent to client

2017-11-02 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-125: -- Description: StateMachineExceptionProto only has class name, message and stack trace but

[jira] [Resolved] (RATIS-121) In RaftServer.Builder, allow serverId and group to be initialized automatically

2017-11-02 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-121. --- Resolution: Fixed Fix Version/s: 0.2.0-alpha Yes, this JIRA should be resolved.

[jira] [Created] (RATIS-128) Missing maven plugin version for protobuf and shade plugins

2017-11-02 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-128: - Summary: Missing maven plugin version for protobuf and shade plugins Key: RATIS-128 URL: https://issues.apache.org/jira/browse/RATIS-128 Project: Ratis

[jira] [Assigned] (RATIS-128) Missing maven plugin version for protobuf and shade plugins

2017-11-02 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze reassigned RATIS-128: - Assignee: Tsz Wo Nicholas Sze > Missing maven plugin version for protobuf and

[jira] [Updated] (RATIS-128) Missing maven plugin version for protobuf and shade plugins

2017-11-02 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-128: -- Attachment: r128_20171102.patch r128_20171102.patch: adds the missing versions and uses

[jira] [Commented] (RATIS-102) Clean generated sources as part of the default clean lifecycle

2017-11-02 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236637#comment-16236637 ] Tsz Wo Nicholas Sze commented on RATIS-102: --- I have filed RATIS-128 for the missing versions

[jira] [Commented] (RATIS-95) Executable Jar for the ratis examples

2017-11-02 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236640#comment-16236640 ] Tsz Wo Nicholas Sze commented on RATIS-95: -- This is very useful, especially for the new FileStore

[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243247#comment-16243247 ] Tsz Wo Nicholas Sze commented on RATIS-77: -- I probably is missing something -- why it should return

[jira] [Updated] (RATIS-123) Add CLI for FileStore example

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-123: -- Attachment: FileStoreServer.java I have a very simple, incomplete implementation of

[jira] [Commented] (RATIS-134) PeerProxyMap#addPeers should add peers only if it is not already present in the proxymap

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243218#comment-16243218 ] Tsz Wo Nicholas Sze commented on RATIS-134: --- Thanks for the update. The patch looks good. Need

[jira] [Commented] (RATIS-72) Enable Ratis to run on high-performance RDMA networks

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243260#comment-16243260 ] Tsz Wo Nicholas Sze commented on RATIS-72: -- {code}

[jira] [Commented] (RATIS-137) RaftBasicTests.testBasicAppendEntries may fail

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243265#comment-16243265 ] Tsz Wo Nicholas Sze commented on RATIS-137: --- It seems that the failure happens at {code}

[jira] [Created] (RATIS-137) RaftBasicTests.testBasicAppendEntries may fail

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-137: - Summary: RaftBasicTests.testBasicAppendEntries may fail Key: RATIS-137 URL: https://issues.apache.org/jira/browse/RATIS-137 Project: Ratis Issue

[jira] [Comment Edited] (RATIS-132) Support simple 'mvn clean compile' command (move shading before the compile phase)

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243254#comment-16243254 ] Tsz Wo Nicholas Sze edited comment on RATIS-132 at 11/8/17 2:11 AM: I

[jira] [Commented] (RATIS-136) Reduce log level for segment rollover

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243272#comment-16243272 ] Tsz Wo Nicholas Sze commented on RATIS-136: --- {code} ---

[jira] [Resolved] (RATIS-136) Reduce log level for segment rollover

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-136. --- Resolution: Fixed Fix Version/s: 0.2.0-alpha I have committed this. Thanks,

[jira] [Updated] (RATIS-136) Reduce log level for segment rollover

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-136: -- Attachment: RATIS-136.003.patch RATIS-136.003.patch: file to be committed. > Reduce log

[jira] [Commented] (RATIS-72) Enable Ratis to run on high-performance RDMA networks

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243288#comment-16243288 ] Tsz Wo Nicholas Sze commented on RATIS-72: -- [~atrivedi], please feel free to file JIRA if you see

[jira] [Commented] (RATIS-117) Add test for situation when old leader can/cannot commit log

2017-11-09 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246644#comment-16246644 ] Tsz Wo Nicholas Sze commented on RATIS-117: --- Thanks, [~yubox] and [~jingzhao]. > Add test for

[jira] [Created] (RATIS-140) Server may see out-of-order gRPC messages sent from the same client

2017-11-09 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-140: - Summary: Server may see out-of-order gRPC messages sent from the same client Key: RATIS-140 URL: https://issues.apache.org/jira/browse/RATIS-140 Project:

[jira] [Commented] (RATIS-140) Server may see out-of-order gRPC messages sent from the same client

2017-11-09 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246840#comment-16246840 ] Tsz Wo Nicholas Sze commented on RATIS-140: --- The bug is that the client creates a new stream per

[jira] [Commented] (RATIS-138) "mvn clean install" doesn't work.

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244865#comment-16244865 ] Tsz Wo Nicholas Sze commented on RATIS-138: --- Let's just revert RATIS-129 using git. I am happy

[jira] [Reopened] (RATIS-129) Compile protobuf and shade if the shaded source directory is missing

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze reopened RATIS-129: --- Reopen for reverting. > Compile protobuf and shade if the shaded source directory is

[jira] [Updated] (RATIS-122) Add a FileStore example

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-122: -- Attachment: r122_20171108.patch Thanks [~jnp]. Here is a new patch addressing your

[jira] [Resolved] (RATIS-129) Compile protobuf and shade if the shaded source directory is missing

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-129. --- Resolution: Not A Problem Resolving this as Not A Problem. > Compile protobuf and

[jira] [Comment Edited] (RATIS-129) Compile protobuf and shade if the shaded source directory is missing

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244868#comment-16244868 ] Tsz Wo Nicholas Sze edited comment on RATIS-129 at 11/8/17 10:35 PM: -

[jira] [Commented] (RATIS-138) "mvn clean install" doesn't work.

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244870#comment-16244870 ] Tsz Wo Nicholas Sze commented on RATIS-138: --- I just have reverted the commit in RATIS-129. >

[jira] [Updated] (RATIS-135) Closed segments contribute to leaked memory as eviction policies are not honoured

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-135: -- +1 > Closed segments contribute to leaked memory as eviction policies are not > honoured >

[jira] [Assigned] (RATIS-137) RaftBasicTests.testBasicAppendEntries may fail

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze reassigned RATIS-137: - Assignee: Lokesh Jain > RaftBasicTests.testBasicAppendEntries may fail >

[jira] [Commented] (RATIS-95) Executable Jar for the ratis examples

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245025#comment-16245025 ] Tsz Wo Nicholas Sze commented on RATIS-95: -- {{example/src/main/bin}} sounds since it won't confuse

[jira] [Updated] (RATIS-129) Compile protobuf and shade if the shaded source directory is missing

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-129: -- Fix Version/s: (was: 0.2.0-alpha) > Compile protobuf and shade if the shaded source

[jira] [Created] (RATIS-131) Add checkstyle configuration

2017-11-03 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-131: - Summary: Add checkstyle configuration Key: RATIS-131 URL: https://issues.apache.org/jira/browse/RATIS-131 Project: Ratis Issue Type: Bug

[jira] [Updated] (RATIS-125) The cause in a StateMachineException is not sent to client

2017-11-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-125: -- Priority: Major (was: Trivial) > The cause in a StateMachineException is not sent to

[jira] [Commented] (RATIS-102) Clean generated sources as part of the default clean lifecycle

2017-11-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238503#comment-16238503 ] Tsz Wo Nicholas Sze commented on RATIS-102: --- A better approach is to check if the shaded src dir

[jira] [Commented] (RATIS-102) Clean generated sources as part of the default clean lifecycle

2017-11-03 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238487#comment-16238487 ] Tsz Wo Nicholas Sze commented on RATIS-102: --- [~jingzhao], you are right that {{mvn test}} does

[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent

2017-11-07 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242621#comment-16242621 ] Tsz Wo Nicholas Sze commented on RATIS-77: -- > //Executes a client-streaming call , return only one

[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.

2017-12-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283336#comment-16283336 ] Tsz Wo Nicholas Sze commented on RATIS-168: --- Question: Why 1.5.0 but not the latest, which is

[jira] [Updated] (RATIS-162) Clean up reply exception handling code for RATIS-140

2017-12-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-162: -- Attachment: r162_20171204.patch r162_20171204.patch: removes retryInterval from

[jira] [Created] (RATIS-162) Clean up reply exception handling code for RATIS-140

2017-12-03 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-162: - Summary: Clean up reply exception handling code for RATIS-140 Key: RATIS-162 URL: https://issues.apache.org/jira/browse/RATIS-162 Project: Ratis

[jira] [Updated] (RATIS-165) Change ClientProtoUtils from "class" to "interface" and remove "public"

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-165: -- Summary: Change ClientProtoUtils from "class" to "interface" and remove "public" (was:

[jira] [Updated] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-140: -- Attachment: r140_20171206.patch r140_20171206.patch: reverts the RaftOutputStream

[jira] [Updated] (RATIS-131) Add checkstyle configuration

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-131: -- Description: This JIRA is to setup our checkstyle coding conventions. We probably

[jira] [Commented] (RATIS-131) Add checkstyle configuration

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279530#comment-16279530 ] Tsz Wo Nicholas Sze commented on RATIS-131: --- We probably want to modify the following checkstyle

[jira] [Updated] (RATIS-166) Remove the use of sun.misc.Unsafe

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-166: -- Priority: Minor (was: Major) +1 patch looks good. > Remove the use of sun.misc.Unsafe

[jira] [Commented] (RATIS-165) ClientProtoUtils change from "class" to "interface" and remove "public"

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279568#comment-16279568 ] Tsz Wo Nicholas Sze commented on RATIS-165: --- +1 patch looks good. > ClientProtoUtils change from

[jira] [Commented] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279591#comment-16279591 ] Tsz Wo Nicholas Sze commented on RATIS-140: --- Agree. The gRPC change in RATIS-113 is incorrect in

[jira] [Commented] (RATIS-161) gRPC Log appender should check if the appended request size is less than max message size of the server

2017-12-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284597#comment-16284597 ] Tsz Wo Nicholas Sze commented on RATIS-161: --- Hi Mukul, if it happens that configuredBufferSize >

[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.

2017-12-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284593#comment-16284593 ] Tsz Wo Nicholas Sze commented on RATIS-168: --- Thanks, the latest version is 1.7.1 for grpc-java.

[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.

2017-12-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284595#comment-16284595 ] Tsz Wo Nicholas Sze commented on RATIS-168: --- It seems that all the following should be excluded.

[jira] [Updated] (RATIS-167) Implement a high performance OutputStream using async API

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-167: -- Attachment: r167_20171206.patch r167_20171206.patch: split from RATIS-140. > Implement

[jira] [Updated] (RATIS-167) Implement a high performance OutputStream using async API

2017-12-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-167: -- Attachment: r167_20171206.patch > Implement a high performance OutputStream using async

[jira] [Updated] (RATIS-167) Implement a high performance OutputStream using async API

2017-12-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-167: -- Attachment: (was: r167_20171206.patch) > Implement a high performance OutputStream

[jira] [Created] (RATIS-167) Implement a high performance OutputStream using async API

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-167: - Summary: Implement a high performance OutputStream using async API Key: RATIS-167 URL: https://issues.apache.org/jira/browse/RATIS-167 Project: Ratis

[jira] [Comment Edited] (RATIS-167) Implement a high performance OutputStream using async API

2017-12-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279790#comment-16279790 ] Tsz Wo Nicholas Sze edited comment on RATIS-167 at 12/6/17 8:13 AM:

[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent

2017-12-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279830#comment-16279830 ] Tsz Wo Nicholas Sze commented on RATIS-77: -- Thanks for the explanation. I missed that

[jira] [Commented] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279817#comment-16279817 ] Tsz Wo Nicholas Sze commented on RATIS-140: --- > ... Let me separate the OutputStream change to

[jira] [Updated] (RATIS-167) Implement a high performance OutputStream using async API

2017-12-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-167: -- Description: With an in-order async API, it is easy to implement a high performance

[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.

2017-12-08 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284600#comment-16284600 ] Tsz Wo Nicholas Sze commented on RATIS-168: --- And also {code} [INFO] Including

[jira] [Commented] (RATIS-161) gRPC Log appender should check if the appended request size is less than max message size of the server

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285151#comment-16285151 ] Tsz Wo Nicholas Sze commented on RATIS-161: --- - GrpcConfigKeys.MESSAGE_SIZE_MAX_KEY specifies the

[jira] [Comment Edited] (RATIS-170) Add an async FileStore test

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285138#comment-16285138 ] Tsz Wo Nicholas Sze edited comment on RATIS-170 at 12/10/17 9:23 AM: - >

[jira] [Comment Edited] (RATIS-170) Add an async FileStore test

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285138#comment-16285138 ] Tsz Wo Nicholas Sze edited comment on RATIS-170 at 12/10/17 9:23 AM: - >

[jira] [Commented] (RATIS-161) gRPC Log appender should check if the appended request size is less than max message size of the server

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285152#comment-16285152 ] Tsz Wo Nicholas Sze commented on RATIS-161: --- BTW, let's also change LogEntryBuffer.addEntry. It

[jira] [Commented] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285137#comment-16285137 ] Tsz Wo Nicholas Sze commented on RATIS-140: --- The patch has passed 99 times the new async

[jira] [Commented] (RATIS-170) Add an async FileStore test

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285138#comment-16285138 ] Tsz Wo Nicholas Sze commented on RATIS-170: --- > But it is about 50% faster than the multi-threaded

[jira] [Assigned] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

2017-12-11 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze reassigned RATIS-124: - Assignee: Kit Hui > RaftLog should be sync'ed on all the entries appended but not

[jira] [Updated] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-124: -- Attachment: r124_20171212b_committed.patch +1 the 20171212b patch looks good.

[jira] [Commented] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287253#comment-16287253 ] Tsz Wo Nicholas Sze commented on RATIS-124: --- Patch looks good. Some minor comments: - Let's

[jira] [Updated] (RATIS-161) gRPC Log appender should check if the appended request size is less than max message size of the server

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-161: -- +1 patch looks good. > gRPC Log appender should check if the appended request size is less

[jira] [Created] (RATIS-171) The FileStore tests fails with NullPointerException

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-171: - Summary: The FileStore tests fails with NullPointerException Key: RATIS-171 URL: https://issues.apache.org/jira/browse/RATIS-171 Project: Ratis

[jira] [Commented] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287779#comment-16287779 ] Tsz Wo Nicholas Sze commented on RATIS-124: --- The failures of TestFileStoreWithNetty and

[jira] [Updated] (RATIS-171) The FileStore tests fail with NullPointerException

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-171: -- Description: In the RaftLogWorker.WriteLog constructor, stateMachineFuture can be null

[jira] [Updated] (RATIS-170) Add an async FileStore test

2017-12-09 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-170: -- Attachment: r170_20171210.patch r170_20171210.patch: (depends on RATIS-140) - adds async

[jira] [Created] (RATIS-170) Add an async FileStore test

2017-12-09 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-170: - Summary: Add an async FileStore test Key: RATIS-170 URL: https://issues.apache.org/jira/browse/RATIS-170 Project: Ratis Issue Type: Bug

[jira] [Updated] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-09 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-140: -- Attachment: r140_20171210.patch r140_20171210.patch: - fixes a bug in

[jira] [Commented] (RATIS-121) In RaftServer.Builder, allow serverId and group to be initialized automatically

2017-10-25 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219660#comment-16219660 ] Tsz Wo Nicholas Sze commented on RATIS-121: --- Hey, this patch still allow upper layer applications

[jira] [Commented] (RATIS-121) In RaftServer.Builder, allow serverId and group to be initialized automatically

2017-10-25 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219675#comment-16219675 ] Tsz Wo Nicholas Sze commented on RATIS-121: --- Also, without this patch, we won't be able to set

[jira] [Commented] (RATIS-121) In RaftServer.Builder, allow serverId and group to be initialized automatically

2017-10-25 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219715#comment-16219715 ] Tsz Wo Nicholas Sze commented on RATIS-121: --- I see. That's why you were objecting. Thanks a lot

[jira] [Updated] (RATIS-122) Add a FileStore example

2017-10-25 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-122: -- Attachment: r122_20171025.patch The previous patch uses

[jira] [Updated] (RATIS-121) In RaftServer.Builder, allow serverId and group to be initialized automatically

2017-10-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-121: -- Summary: In RaftServer.Builder, allow serverId and group to be initialized automatically

[jira] [Resolved] (RATIS-120) In RaftClient.Builder, allow clientRpc to be initialized automatically

2017-10-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-120. --- Resolution: Fixed Fix Version/s: 0.2.0-alpha Thanks Jing for reviewing the

[jira] [Resolved] (RATIS-119) RaftServerImpl.registerMBean may throw MalformedObjectNameException

2017-10-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-119. --- Resolution: Fixed Fix Version/s: 0.2.0-alpha I have committed this. >

[jira] [Commented] (RATIS-121) In RaftServer.Builder, allow serverId and group to be initialized automatically

2017-10-24 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217757#comment-16217757 ] Tsz Wo Nicholas Sze commented on RATIS-121: --- When working on Ozone, I found that we don't really

[jira] [Updated] (RATIS-122) Add a FileStore example

2017-10-31 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-122: -- Attachment: r122_20171031.patch Thanks [~jnp]. Here is a new patch addressing your

[jira] [Commented] (RATIS-236) Use TimeoutScheduler in RaftClientImpl

2018-05-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464192#comment-16464192 ] Tsz Wo Nicholas Sze commented on RATIS-236: --- Also, even scheduler can be set to null, s won't be

[jira] [Commented] (RATIS-236) Use TimeoutScheduler in RaftClientImpl

2018-05-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464185#comment-16464185 ] Tsz Wo Nicholas Sze commented on RATIS-236: --- Thanks [~ljain] If (s instanceof

<    1   2   3   4   5   6   7   8   9   10   >