[GitHub] [royale-asjs] joshtynjala edited a comment on pull request #1041: Reconcile Basic ContainerView for SWF and JS, and some SWF fixes

2021-04-06 Thread GitBox
joshtynjala edited a comment on pull request #1041: URL: https://github.com/apache/royale-asjs/pull/1041#issuecomment-814455513 I've confirmed that the `MouseEventConverter` class stopped behaving as expected ~~after this pull request was merged~~ (edit: it was actually my attempted fix

[GitHub] [royale-asjs] joshtynjala commented on pull request #1041: Reconcile Basic ContainerView for SWF and JS, and some SWF fixes

2021-04-06 Thread GitBox
joshtynjala commented on pull request #1041: URL: https://github.com/apache/royale-asjs/pull/1041#issuecomment-814471244 > I'm not sure your change to addViewport() is the right way to go Yeah, I've determined that my change to addViewport() is what was breaking the

[GitHub] [royale-asjs] estanglerbm commented on pull request #1041: Reconcile Basic ContainerView for SWF and JS, and some SWF fixes

2021-04-06 Thread GitBox
estanglerbm commented on pull request #1041: URL: https://github.com/apache/royale-asjs/pull/1041#issuecomment-814462965 Things are more complicated, regarding changing this kind of thing, than I can quickly write here. Also, I didn't have full access to running ant tests at the time,

[GitHub] [royale-asjs] joshtynjala commented on pull request #1041: Reconcile Basic ContainerView for SWF and JS, and some SWF fixes

2021-04-06 Thread GitBox
joshtynjala commented on pull request #1041: URL: https://github.com/apache/royale-asjs/pull/1041#issuecomment-814455513 I've confirmed that the `MouseEventConverter` class stopped behaving as expected after this pull request was merged. Previously, it was properly converting all mouse

[GitHub] [royale-asjs] joshtynjala commented on pull request #1041: Reconcile Basic ContainerView for SWF and JS, and some SWF fixes

2021-04-06 Thread GitBox
joshtynjala commented on pull request #1041: URL: https://github.com/apache/royale-asjs/pull/1041#issuecomment-814393934 In `addViewport()`, I replaced this code: ```as3 if (chost != null && chost != _viewport.contentView) { chost.addElement(_viewport.contentView); }

[GitHub] [royale-asjs] joshtynjala commented on pull request #1041: Reconcile Basic ContainerView for SWF and JS, and some SWF fixes

2021-04-06 Thread GitBox
joshtynjala commented on pull request #1041: URL: https://github.com/apache/royale-asjs/pull/1041#issuecomment-814336955 FYI — The Mustella tests have been failing since this pull request was merged. We haven't had a successful CI build since January. The error we get is included

[GitHub] [royale-asjs] Harbs commented on issue #1099: Incorrect Message type cast by compiler.

2021-04-06 Thread GitBox
Harbs commented on issue #1099: URL: https://github.com/apache/royale-asjs/issues/1099#issuecomment-814249799 Do you have a small test case which shows the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [royale-asjs] roboticavicensvives opened a new issue #1099: Incorrect Message type cast by compiler.

2021-04-06 Thread GitBox
roboticavicensvives opened a new issue #1099: URL: https://github.com/apache/royale-asjs/issues/1099 When using a BlazeDS backend and mx:RemoteObjects if there is reference to org.apache.royale.net.remoting.messages anywhere in the codebase such as having in a component :