[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533177#comment-14533177
]
Hitesh Shah commented on TEZ-776:
-
+1 on the patch.
Though as [~sseth] pointed out, there
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533129#comment-14533129
]
Bikas Saha commented on TEZ-776:
[~hitesh] [~rajesh.balamohan] Any further comments?
Reduce
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533428#comment-14533428
]
Bikas Saha commented on TEZ-776:
Thanks for the reviews. Uploading rebased patch for a
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533495#comment-14533495
]
TezQA commented on TEZ-776:
---
{color:green}+1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531636#comment-14531636
]
TezQA commented on TEZ-776:
---
{color:green}+1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531552#comment-14531552
]
Bikas Saha commented on TEZ-776:
From the code in the array list implementation and our
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531394#comment-14531394
]
Hitesh Shah commented on TEZ-776:
-
From arraylist javadoc:
{code}
Note that this
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531183#comment-14531183
]
Siddharth Seth commented on TEZ-776:
bq. prepareForRouting is guarded by synchronized in
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531931#comment-14531931
]
Siddharth Seth commented on TEZ-776:
More offline discussions. I think we're going to try
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529113#comment-14529113
]
TezQA commented on TEZ-776:
---
{color:green}+1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527677#comment-14527677
]
Siddharth Seth commented on TEZ-776:
- Minor: {code}Target input indices. The number must
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527766#comment-14527766
]
TezQA commented on TEZ-776:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527845#comment-14527845
]
Bikas Saha commented on TEZ-776:
prepareForRouting is guarded by synchronized in Edge which
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527957#comment-14527957
]
TezQA commented on TEZ-776:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523525#comment-14523525
]
TezQA commented on TEZ-776:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523656#comment-14523656
]
Siddharth Seth commented on TEZ-776:
bq. 1) The patch in TEZ-2255 is doing e2e Composite
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523740#comment-14523740
]
Siddharth Seth commented on TEZ-776:
bq. The code is being optimistic here and its
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522738#comment-14522738
]
Bikas Saha commented on TEZ-776:
bq. Can the fields in DataMovementEvent be made final after
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522714#comment-14522714
]
Bikas Saha commented on TEZ-776:
bq. That's still making more changes which belong to other
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520568#comment-14520568
]
Siddharth Seth commented on TEZ-776:
Quick note. In process of looking at the .A patch.
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520628#comment-14520628
]
Bikas Saha commented on TEZ-776:
Please look at patch B. That is where I am making bug fixes
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520724#comment-14520724
]
Siddharth Seth commented on TEZ-776:
That's still making more changes which belong to
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520753#comment-14520753
]
TezQA commented on TEZ-776:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520833#comment-14520833
]
Siddharth Seth commented on TEZ-776:
Some numbers form various runs. All of these are on
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520815#comment-14520815
]
Siddharth Seth commented on TEZ-776:
From another offline discussion to resolve the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518380#comment-14518380
]
Bikas Saha commented on TEZ-776:
TEZ-776.6.A and TEZ-776.6.B are 2 versions of the API with
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518330#comment-14518330
]
TezQA commented on TEZ-776:
---
{color:green}+1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518543#comment-14518543
]
TezQA commented on TEZ-776:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517533#comment-14517533
]
TezQA commented on TEZ-776:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516579#comment-14516579
]
TezQA commented on TEZ-776:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508042#comment-14508042
]
TezQA commented on TEZ-776:
---
{color:green}+1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500575#comment-14500575
]
TezQA commented on TEZ-776:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500804#comment-14500804
]
TezQA commented on TEZ-776:
---
{color:green}+1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493244#comment-14493244
]
Rohini Palaniswamy commented on TEZ-776:
bq. 95 million events in memory is crazy.
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487990#comment-14487990
]
Rohini Palaniswamy commented on TEZ-776:
jmap -histo:live output of AM from one of
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486602#comment-14486602
]
Hadoop QA commented on TEZ-776:
---
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370582#comment-14370582
]
Siddharth Seth commented on TEZ-776:
Apologies for the late reply. Options have been
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362632#comment-14362632
]
Bikas Saha commented on TEZ-776:
Sorry I take that back. Combining on-demand and current
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362685#comment-14362685
]
Bikas Saha commented on TEZ-776:
Not needed. They all have default implementations that throw
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362657#comment-14362657
]
Rajesh Balamohan commented on TEZ-776:
--
Given the fact that the APIs are all optional
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361273#comment-14361273
]
Bikas Saha commented on TEZ-776:
All options have been sufficiently discussed on this thread
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360078#comment-14360078
]
Siddharth Seth commented on TEZ-776:
Please see my first comment on the document posted -
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359459#comment-14359459
]
Bikas Saha commented on TEZ-776:
This jira has presented a solution for reducing the memory
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354831#comment-14354831
]
Rajesh Balamohan commented on TEZ-776:
--
Could you please outline how you connected JMC
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355938#comment-14355938
]
Siddharth Seth commented on TEZ-776:
One option would be to make these changes now, and
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353222#comment-14353222
]
Bikas Saha commented on TEZ-776:
Thanks [~rajesh.balamohan]. The overall picture is inline
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353345#comment-14353345
]
Siddharth Seth commented on TEZ-776:
Thanks for the analysis [~rajesh.balamohan]. Without
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354316#comment-14354316
]
Rohini Palaniswamy commented on TEZ-776:
Ran the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14349931#comment-14349931
]
Bikas Saha commented on TEZ-776:
Sorry for the delayed response.
MxN for broadcast is a
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346585#comment-14346585
]
Siddharth Seth commented on TEZ-776:
bq. The edge manager implementations are precisely
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344691#comment-14344691
]
Bikas Saha commented on TEZ-776:
Attached new revision (2) of the patch. It re-writes the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344654#comment-14344654
]
Bikas Saha commented on TEZ-776:
The edge manager implementations are precisely that. Impls
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338932#comment-14338932
]
Siddharth Seth commented on TEZ-776:
One more thing to keep in mind is to retain the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337050#comment-14337050
]
Bikas Saha commented on TEZ-776:
From the simulation, the CPU overhead for routing 1
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338043#comment-14338043
]
Siddharth Seth commented on TEZ-776:
bq. Are composite events being exploded into dm
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328663#comment-14328663
]
Bikas Saha commented on TEZ-776:
EdgeManagerPlugin have been created for the specific goal of
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328668#comment-14328668
]
Bikas Saha commented on TEZ-776:
Attaching a POC patch that shows that event routing can be
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325123#comment-14325123
]
Siddharth Seth commented on TEZ-776:
Comments on the options posted in the doc (apologies
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317218#comment-14317218
]
Siddharth Seth commented on TEZ-776:
Was having an offline discussion with [~gopalv] and
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14315964#comment-14315964
]
Siddharth Seth commented on TEZ-776:
Here's some numbers on current memory usage (making
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316052#comment-14316052
]
Siddharth Seth commented on TEZ-776:
Elaborating more on what I had mentioned in the
[
https://issues.apache.org/jira/browse/TEZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316061#comment-14316061
]
Siddharth Seth commented on TEZ-776:
That said, I think Point2 from
62 matches
Mail list logo
