[GitHub] [trafficcontrol] ocket8888 closed issue #7049: Traffic Portal (v1) - Servers do not display for layered/multi profiles

2022-09-29 Thread GitBox
ocket closed issue #7049: Traffic Portal (v1) - Servers do not display for layered/multi profiles URL: https://github.com/apache/trafficcontrol/issues/7049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [trafficcontrol] ocket8888 closed issue #7052: Traffic Portal v1 - Quick Search does not work for second/layered profiles

2022-09-29 Thread GitBox
ocket closed issue #7052: Traffic Portal v1 - Quick Search does not work for second/layered profiles URL: https://github.com/apache/trafficcontrol/issues/7052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [trafficcontrol] ocket8888 merged pull request #7074: Fixed server table's quick search and filter for multiple profiles

2022-09-29 Thread GitBox
ocket merged PR #7074: URL: https://github.com/apache/trafficcontrol/pull/7074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7099: Delivery Service Active Flag Rework

2022-09-29 Thread GitBox
ocket opened a new pull request, #7099: URL: https://github.com/apache/trafficcontrol/pull/7099 In accordance with the blueprint from #4654, this changes the `active` property of Delivery Services from a simple boolean to a three state system, where the three states are: -

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7074: Fixed server table's quick search and filter for multiple profiles

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7074: URL: https://github.com/apache/trafficcontrol/pull/7074#discussion_r983989905 ## traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.js: ## @@ -301,6 +301,34 @@ let CommonGridController = function ($scope, $document,

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7074: Fixed server table's quick search and filter for multiple profiles

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7074: URL: https://github.com/apache/trafficcontrol/pull/7074#discussion_r983954178 ## traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.js: ## @@ -301,6 +301,34 @@ let CommonGridController = function ($scope, $document,

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7074: Fixed server table's quick search and filter for multiple profiles

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7074: URL: https://github.com/apache/trafficcontrol/pull/7074#discussion_r983954758 ## traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.js: ## @@ -301,6 +301,34 @@ let CommonGridController = function ($scope, $document,

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7074: Fixed server table's quick search and filter for multiple profiles

2022-09-29 Thread GitBox
ocket commented on code in PR #7074: URL: https://github.com/apache/trafficcontrol/pull/7074#discussion_r983945604 ## traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.js: ## @@ -301,6 +301,34 @@ let CommonGridController = function ($scope, $document,

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7068: Renamed rascal to tm/traffic_monitor

2022-09-29 Thread GitBox
rimashah25 commented on PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068#issuecomment-1262722975 > As Rawlin said, we can't just change what TO is querying for when it looks for Parameters or servers etc. That would break a lot of things on install, that would take a while

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7087: TP Allow Change Logs to be "expanded" to see the whole message.

2022-09-29 Thread GitBox
ocket commented on code in PR #7087: URL: https://github.com/apache/trafficcontrol/pull/7087#discussion_r983941452 ## experimental/traffic-portal/src/app/shared/dialogs/text-dialog/text-dialog.component.ts: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
ocket commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983938986 ## traffic_portal/app/src/common/modules/table/serverCapabilityServers/table.serverCapabilityServers.tpl.html: ## @@ -20,11 +20,12 @@ -

[GitHub] [trafficcontrol] ocket8888 merged pull request #7098: Bugfix/server capability breadcrumb links

2022-09-29 Thread GitBox
ocket merged PR #7098: URL: https://github.com/apache/trafficcontrol/pull/7098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 closed issue #6335: TP: server capabilities breadcrumb links are broken

2022-09-29 Thread GitBox
ocket closed issue #6335: TP: server capabilities breadcrumb links are broken URL: https://github.com/apache/trafficcontrol/issues/6335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] ocket8888 closed issue #7080: Server Capability Link Broken

2022-09-29 Thread GitBox
ocket closed issue #7080: Server Capability Link Broken URL: https://github.com/apache/trafficcontrol/issues/7080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7068: Renamed rascal to tm/traffic_monitor

2022-09-29 Thread GitBox
ocket commented on code in PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r983902839 ## docs/source/overview/profiles_and_parameters.rst: ## @@ -497,7 +497,7 @@ For each Parameter with this Config File value on the same :ref:`Profile = 5 { +

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983905411 ## traffic_portal/app/src/common/modules/table/serverCapabilityServers/table.serverCapabilityServers.tpl.html: ## @@ -20,11 +20,12 @@ -

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983904795 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -527,3 +527,70 @@ func AssignMultipleServerCapabilities(w http.ResponseWriter, r

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
ocket commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983879958 ## traffic_portal/app/src/common/modules/table/serverCapabilityServers/table.serverCapabilityServers.tpl.html: ## @@ -20,11 +20,12 @@ -

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983763105 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -527,3 +527,70 @@ func AssignMultipleServerCapabilities(w http.ResponseWriter, r

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983705053 ## traffic_portal/app/src/common/modules/table/serverCapabilityServers/table.serverCapabilityServers.tpl.html: ## @@ -20,11 +20,12 @@ -

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7098: Bugfix/server capability breadcrumb links

2022-09-29 Thread GitBox
rimashah25 opened a new pull request, #7098: URL: https://github.com/apache/trafficcontrol/pull/7098 Fixes: https://github.com/apache/trafficcontrol/issues/7080, https://github.com/apache/trafficcontrol/issues/6335 ## Which Traffic Control components are affected by this

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983705053 ## traffic_portal/app/src/common/modules/table/serverCapabilityServers/table.serverCapabilityServers.tpl.html: ## @@ -20,11 +20,12 @@ -

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983696770 ## docs/source/api/v4/multiple_servers_per_capability.rst: ## @@ -0,0 +1,83 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0 (the "License"); +..

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983699552 ## docs/source/api/v4/multiple_servers_per_capability.rst: ## @@ -0,0 +1,83 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0 (the "License"); +..

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-29 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983672102 ## traffic_portal/app/src/common/modules/table/serverCapabilityServers/table.serverCapabilityServers.tpl.html: ## @@ -20,11 +20,12 @@ -

[GitHub] [trafficcontrol] ocket8888 closed issue #7064: All endpoints need to account for the ASN field in servers

2022-09-29 Thread GitBox
ocket closed issue #7064: All endpoints need to account for the ASN field in servers URL: https://github.com/apache/trafficcontrol/issues/7064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] ocket8888 merged pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-29 Thread GitBox
ocket merged PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-09-29 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r983631749 ## tc-health-client/sar/multisar.go: ## @@ -0,0 +1,388 @@ +// package sar implements a syn-ack-rst health ping. +// It sends a TCP SYN, waits for an ACK, then

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7015: Add blueprint for a Global Configuration object

2022-09-28 Thread GitBox
ocket commented on PR #7015: URL: https://github.com/apache/trafficcontrol/pull/7015#issuecomment-1261741581 No, I don't believe this to really be directly related to #1969. This will not obviate the use of Parameters in general. It's only meant to take the place of "global"-like

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-28 Thread GitBox
ocket commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983027503 ## docs/source/api/v4/multiple_servers_per_capability.rst: ## @@ -0,0 +1,83 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0 (the "License"); +..

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7096: Add health client parent health

2022-09-28 Thread GitBox
github-code-scanning[bot] commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r982922207 ## tc-health-client/sar/multisar.go: ## @@ -0,0 +1,388 @@ +// package sar implements a syn-ack-rst health ping. +// It sends a TCP SYN, waits

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-09-28 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r982915522 ## tc-health-client/sar/sar.go: ## @@ -0,0 +1,348 @@ +// package sar implements a syn-ack-rst health ping. +// It sends a TCP SYN, waits for an ACK, then

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-28 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r982905595 ## traffic_ops/testing/api/v4/server_server_capabilities_test.go: ## @@ -223,7 +233,14 @@ func TestServerServerCapabilities(t *testing.T) {

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7096: Add health client parent health

2022-09-28 Thread GitBox
github-code-scanning[bot] commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r982897220 ## tc-health-client/sar/sar.go: ## @@ -0,0 +1,348 @@ +// package sar implements a syn-ack-rst health ping. +// It sends a TCP SYN, waits for an

[GitHub] [trafficcontrol] zrhoffman opened a new issue, #7097: For a Regional Delivery Service, MaxOriginConnections should only be divided among Servers within a single Cache Group

2022-09-28 Thread GitBox
zrhoffman opened a new issue, #7097: URL: https://github.com/apache/trafficcontrol/issues/7097 ## This Feature Request affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic Ops ## Description The

[GitHub] [trafficcontrol] rob05c commented on pull request #7096: Add health client parent health

2022-09-28 Thread GitBox
rob05c commented on PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#issuecomment-1261503484 Making not a draft to make Github tests to run. Still really a draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] rob05c opened a new pull request, #7096: Add health client parent health

2022-09-28 Thread GitBox
rob05c opened a new pull request, #7096: URL: https://github.com/apache/trafficcontrol/pull/7096 Adds parent health to the health client. This allows caches to log and markdown parent health based on whether the cache can directly request its parents, in addition to the existing

[GitHub] [trafficcontrol] ezelkow1 opened a new issue, #7095: Profile comparison from profile page

2022-09-28 Thread GitBox
ezelkow1 opened a new issue, #7095: URL: https://github.com/apache/trafficcontrol/issues/7095 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Portal ## Current behavior: Currently to

[GitHub] [trafficcontrol] guzzijason commented on pull request #7015: Add blueprint for a Global Configuration object

2022-09-28 Thread GitBox
guzzijason commented on PR #7015: URL: https://github.com/apache/trafficcontrol/pull/7015#issuecomment-1261383160 My understanding is that this addresses #1969 , but its not clear to me just how yet. Does the use of Global Configuration simply make the past use of parameters obsolete? --

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-28 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r982769195 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -527,3 +527,70 @@ func AssignMultipleServerCapabilities(w http.ResponseWriter, r

[GitHub] [trafficcontrol] ocket8888 opened a new issue, #7094: Routing Name can be changed to default

2022-09-28 Thread GitBox
ocket opened a new issue, #7094: URL: https://github.com/apache/trafficcontrol/issues/7094 ## This Bug Report affects these Traffic Control components: - Traffic Ops ## Current behavior: When updating a Delivery Service, the routing name is immutable if it has SSL keys

[GitHub] [trafficcontrol] traeak commented on issue #1970: Not possible to disable retry for MSO

2022-09-28 Thread GitBox
traeak commented on issue #1970: URL: https://github.com/apache/trafficcontrol/issues/1970#issuecomment-1261169503 The official apache trafficserver documentation seems to indicate that there is no way to entirely turn off parent retries. It's just not an option currently.

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7093: Update Tomcat to 9.0.66

2022-09-28 Thread GitBox
zrhoffman opened a new pull request, #7093: URL: https://github.com/apache/trafficcontrol/pull/7093 This PR updates Tomcat to version 9.0.66. ## Which Traffic Control components are affected by this PR? - Traffic Router ## What is the best way to verify this

[GitHub] [trafficcontrol] zrhoffman merged pull request #7088: Made `Clear Table Filters` option visible to the user

2022-09-28 Thread GitBox
zrhoffman merged PR #7088: URL: https://github.com/apache/trafficcontrol/pull/7088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman closed issue #7055: TP "Clear Table Filters" action does not have a button

2022-09-28 Thread GitBox
zrhoffman closed issue #7055: TP "Clear Table Filters" action does not have a button URL: https://github.com/apache/trafficcontrol/issues/7055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] limited opened a new issue, #7092: Upgrade Tomcat in 6.1.x, 7.0.x, and master

2022-09-28 Thread GitBox
limited opened a new issue, #7092: URL: https://github.com/apache/trafficcontrol/issues/7092 ## This Bug Report affects these Traffic Control components: - Traffic Router https://lists.apache.org/thread/9ylm11h0sgkcl1sj3kdbyp726cz3xjtx -- This is an automated message

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7088: Made `Clear Table Filters` option visible to the user

2022-09-28 Thread GitBox
zrhoffman commented on code in PR #7088: URL: https://github.com/apache/trafficcontrol/pull/7088#discussion_r982540681 ## traffic_portal/app/src/common/modules/table/agGrid/grid.tpl.html: ## @@ -61,6 +61,7 @@

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7088: Made `Clear Table Filters` option visible to the user

2022-09-28 Thread GitBox
zrhoffman commented on PR #7088: URL: https://github.com/apache/trafficcontrol/pull/7088#issuecomment-1261066521 On second thought, having the button always visible like this makes it obvious enough to a user who doesn't know what the *filter* icon is, and as long as the help text is

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7091: Bump vm2 from 3.9.9 to 3.9.11 in /traffic_portal/app/src

2022-09-28 Thread GitBox
dependabot[bot] opened a new pull request, #7091: URL: https://github.com/apache/trafficcontrol/pull/7091 Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.9 to 3.9.11. Release notes Sourced from https://github.com/patriksimek/vm2/releases;>vm2's releases. 3.9.11

[GitHub] [trafficcontrol] traeak opened a new pull request, #7090: t3c/parentdotconfig: enforce mso.parent_retry ds parameter

2022-09-27 Thread GitBox
traeak opened a new pull request, #7090: URL: https://github.com/apache/trafficcontrol/pull/7090 Currently during t3c parent.config line generation the parent_retry is always set to "both". During t3c parent.config line generation the t3c code uses the `mso.parent_retry` ds

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-09-27 Thread GitBox
srijeet0406 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r981477784 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -527,3 +527,70 @@ func AssignMultipleServerCapabilities(w http.ResponseWriter,

[GitHub] [trafficcontrol] mkrug1981 commented on issue #7089: Traffic Router default certificate configuration for port 443

2022-09-27 Thread GitBox
mkrug1981 commented on issue #7089: URL: https://github.com/apache/trafficcontrol/issues/7089#issuecomment-1259362218 What I have tried already is to try and set a certificate via keyStore file with **CN=default.invalid** `[root@sn-tr0001-blstg conf]# keytool -list -v -keystore

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7088: Made `clear table filter` option visible to the user

2022-09-26 Thread GitBox
rimashah25 opened a new pull request, #7088: URL: https://github.com/apache/trafficcontrol/pull/7088 Closes: #7055 ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best way to verify this PR? All pages

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7087: TP Allow Change Logs to be "expanded" to see the whole message.

2022-09-26 Thread GitBox
shamrickus opened a new pull request, #7087: URL: https://github.com/apache/trafficcontrol/pull/7087 This PR fixes #6021 ## Which Traffic Control components are affected by this PR? - Traffic Portal - Traffic Portal v2 ## What is the best way to verify

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7074: Fixed server table's quick search and filter for multiple profiles

2022-09-26 Thread GitBox
rimashah25 commented on PR #7074: URL: https://github.com/apache/trafficcontrol/pull/7074#issuecomment-1258458449 > This fixes the search and appears to render fine, but some other tables aren't displaying Profiles for servers properly, e.g. the Delivery Service server-assignment table

[GitHub] [trafficcontrol] zrhoffman merged pull request #7086: adds issue or PR links to unreleased change log

2022-09-26 Thread GitBox
zrhoffman merged PR #7086: URL: https://github.com/apache/trafficcontrol/pull/7086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7086: adds issue or PR links to unreleased change log

2022-09-26 Thread GitBox
rimashah25 commented on PR #7086: URL: https://github.com/apache/trafficcontrol/pull/7086#issuecomment-1258413940 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] mitchell852 opened a new pull request, #7086: adds issue or PR links to unreleased change log

2022-09-26 Thread GitBox
mitchell852 opened a new pull request, #7086: URL: https://github.com/apache/trafficcontrol/pull/7086 adds issue or PR links to unreleased change log ## Which Traffic Control components are affected by this PR? - Documentation ## What is the best way to verify this PR?

[GitHub] [trafficcontrol] ocket8888 commented on issue #3258: Hide ILO password in TP UI by default

2022-09-26 Thread GitBox
ocket commented on issue #3258: URL: https://github.com/apache/trafficcontrol/issues/3258#issuecomment-1258367773 Fixed by #6981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] ocket8888 closed issue #3258: Hide ILO password in TP UI by default

2022-09-26 Thread GitBox
ocket closed issue #3258: Hide ILO password in TP UI by default URL: https://github.com/apache/trafficcontrol/issues/3258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [trafficcontrol] zrhoffman merged pull request #7056: Refactor Topologies Tests

2022-09-23 Thread GitBox
zrhoffman merged PR #7056: URL: https://github.com/apache/trafficcontrol/pull/7056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7056: Refactor Topologies Tests

2022-09-23 Thread GitBox
zrhoffman commented on code in PR #7056: URL: https://github.com/apache/trafficcontrol/pull/7056#discussion_r977467947 ## traffic_ops/testing/api/v3/topologies_test.go: ## @@ -20,316 +20,468 @@ package v3 */ import ( - "fmt" + "encoding/json" + "net/http"

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-23 Thread GitBox
ocket commented on code in PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r978711512 ## lib/go-tc/deliveryservice_servers.go: ## @@ -206,7 +206,8 @@ type DSServerResponseV40 struct { Alerts } -// for servers assigned to a Delivery

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-22 Thread GitBox
rimashah25 commented on code in PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r978185408 ## traffic_ops/traffic_ops_golang/server/servers.go: ## @@ -1631,7 +1631,27 @@ func Update(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] rimashah25 commented on issue #7080: Server Capability Link Broken

2022-09-22 Thread GitBox
rimashah25 commented on issue #7080: URL: https://github.com/apache/trafficcontrol/issues/7080#issuecomment-1255600699 Duplicate to https://github.com/apache/trafficcontrol/issues/6335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] srijeet0406 opened a new issue, #7085: Any API version 3.x call that returns a server object, should return the version appropriate structure

2022-09-22 Thread GitBox
srijeet0406 opened a new issue, #7085: URL: https://github.com/apache/trafficcontrol/issues/7085 When you make a call to a 3.x API endpoint that returns a server object, you get back a version 4.0 specific server representation. This breaks compatibility with clients that are using the

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7084: TP fix filtering on Delivery Service "Targets For" column

2022-09-22 Thread GitBox
shamrickus opened a new pull request, #7084: URL: https://github.com/apache/trafficcontrol/pull/7084 On the "Targets For" column in the Delivery Services table, the filtering/sorting does not work at all. ## Which Traffic Control components are affected by this PR?

[GitHub] [trafficcontrol] ocket8888 commented on pull request #6525: CiaB: Do not rebuild Traffic Server when the ATS RPM spec changes

2022-09-22 Thread GitBox
ocket commented on PR #6525: URL: https://github.com/apache/trafficcontrol/pull/6525#issuecomment-1255177619 This still feels like a step backwards, though. Make is doing its level-best to tell if something needs to be rebuilt, but it's just not quite smart enough to do it - so instead

[GitHub] [trafficcontrol] mikeV02 opened a new pull request, #7083: Tr fix nxdomain

2022-09-21 Thread GitBox
mikeV02 opened a new pull request, #7083: URL: https://github.com/apache/trafficcontrol/pull/7083 Related: #7082 This PR uses a somewhat hacky solution for issue #7082, to check the NS record for a given FQDN to determine if it is fully an NXDOMAIN. ## Which

[GitHub] [trafficcontrol] mikeV02 opened a new issue, #7082: Traffic Router returns NXDOMAIN for non-existent AAAA records within existent DNS zone for the Delivery Service

2022-09-21 Thread GitBox
mikeV02 opened a new issue, #7082: URL: https://github.com/apache/trafficcontrol/issues/7082 ## This Bug Report affects these Traffic Control components: - Traffic Router ## Current behavior: For IPv4 only infrastructure, that is, no IPv6 anywhere more than

[GitHub] [trafficcontrol] ocket8888 commented on pull request #6525: CiaB: Do not rebuild Traffic Server when the ATS RPM spec changes

2022-09-21 Thread GitBox
ocket commented on PR #6525: URL: https://github.com/apache/trafficcontrol/pull/6525#issuecomment-1254291107 I didn't check for a commit where any specific file was modified I just did `~HEAD`, because I thought you meant it would happen *any* time you switch branches. -- This is an

[GitHub] [trafficcontrol] srijeet0406 commented on pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-21 Thread GitBox
srijeet0406 commented on PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073#issuecomment-1254273188 > Docs changes all look good (comments are nitpicks), but changes still need to be made to the `/servers/{{ID}}` endpoint documentation While fixing the docs of that

[GitHub] [trafficcontrol] zrhoffman commented on pull request #6525: CiaB: Do not rebuild Traffic Server when the ATS RPM spec changes

2022-09-21 Thread GitBox
zrhoffman commented on PR #6525: URL: https://github.com/apache/trafficcontrol/pull/6525#issuecomment-1254270531 > I just verified that switching git branches doesn't make you rebuild that: That is a different result than I got. You used `1f264bf162`, which is most recent time the

[GitHub] [trafficcontrol] zrhoffman commented on pull request #6525: CiaB: Do not rebuild Traffic Server when the ATS RPM spec changes

2022-09-21 Thread GitBox
zrhoffman commented on PR #6525: URL: https://github.com/apache/trafficcontrol/pull/6525#issuecomment-1254267213 It happens frequently to me. Just running this triggers an ATS RPM rebuild for me the next time I run `make cache/trafficserver.rpm`. ```shell git checkout 1f264bf162~

[GitHub] [trafficcontrol] ocket8888 commented on pull request #6525: CiaB: Do not rebuild Traffic Server when the ATS RPM spec changes

2022-09-21 Thread GitBox
ocket commented on PR #6525: URL: https://github.com/apache/trafficcontrol/pull/6525#issuecomment-1254256447 Oh, so you mean like you switch to a branch where the source is changed and then switch back it still thinks the source is newer? That's true, but it seems extremely rare

[GitHub] [trafficcontrol] zrhoffman commented on issue #7081: Traffic Router logs `SocketTimeoutException` for port 53 TCP health checks

2022-09-21 Thread GitBox
zrhoffman commented on issue #7081: URL: https://github.com/apache/trafficcontrol/issues/7081#issuecomment-1254233156 > Additionally, if the connection is closed by the client prematurely, a different exception is thrown: Reproducible by running ```shell docker-compose

[GitHub] [trafficcontrol] TaylorCFrey commented on issue #7081: Traffic Router logs `SocketTimeoutException` for port 53 TCP health checks

2022-09-21 Thread GitBox
TaylorCFrey commented on issue #7081: URL: https://github.com/apache/trafficcontrol/issues/7081#issuecomment-1254132232 Additionally, if the connection is closed by the client prematurely, a different exception is thrown: ```java ERROR 2022-09-21T16:40:25.925 [pool-14-thread-78]

[GitHub] [trafficcontrol] TaylorCFrey commented on issue #7081: Traffic Router logs `SocketTimeoutException` for port 53 TCP health checks

2022-09-21 Thread GitBox
TaylorCFrey commented on issue #7081: URL: https://github.com/apache/trafficcontrol/issues/7081#issuecomment-1254130463 I was able to reproduce this using both `curl` and `nc` utilities -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] zrhoffman opened a new issue, #7081: Traffic Router logs `SocketTimeoutException` for port 53 TCP health checks

2022-09-21 Thread GitBox
zrhoffman opened a new issue, #7081: URL: https://github.com/apache/trafficcontrol/issues/7081 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Router ## Current behavior: To ensure

[GitHub] [trafficcontrol] rimashah25 opened a new issue, #7080: Server Capability Link Broken

2022-09-21 Thread GitBox
rimashah25 opened a new issue, #7080: URL: https://github.com/apache/trafficcontrol/issues/7080 ## This Bug Report affects these Traffic Control components: - Traffic Portal ## Current behavior: When clicking on a server capability name, the UI redirects

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7079: Assign multiple servers to a capability

2022-09-21 Thread GitBox
rimashah25 opened a new pull request, #7079: URL: https://github.com/apache/trafficcontrol/pull/7079 Closes: https://github.com/apache/trafficcontrol/issues/6033 ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Ops -

[GitHub] [trafficcontrol] rimashah25 closed issue #7078: Add ability to assign multiple server capabilities to a server

2022-09-21 Thread GitBox
rimashah25 closed issue #7078: Add ability to assign multiple server capabilities to a server URL: https://github.com/apache/trafficcontrol/issues/7078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [trafficcontrol] rimashah25 commented on issue #6033: Add ability to assign and remove a server capability for multiple servers at a time

2022-09-21 Thread GitBox
rimashah25 commented on issue #6033: URL: https://github.com/apache/trafficcontrol/issues/6033#issuecomment-1254053221 @srijeet0406, You are right. I created a new feature request (#7078) for #6996 and #7020. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] zrhoffman commented on pull request #6525: CiaB: Do not rebuild Traffic Server when the ATS RPM spec changes

2022-09-21 Thread GitBox
zrhoffman commented on PR #6525: URL: https://github.com/apache/trafficcontrol/pull/6525#issuecomment-1254050308 > Why do you have to rebuild the ATS RPM when you switch git branches? You should only have to rebuild if the sources in that directory change. It's not only about the

[GitHub] [trafficcontrol] rimashah25 opened a new issue, #7078: Add ability to assign multiple server capabilities to a server

2022-09-21 Thread GitBox
rimashah25 opened a new issue, #7078: URL: https://github.com/apache/trafficcontrol/issues/7078 ## I'm submitting a ... new feature / enhancement request ## This Feature Request affects these Traffic Control components: - Traffic Ops - Traffic Portal -

[GitHub] [trafficcontrol] ocket8888 commented on issue #7076: Add server indicator if a server is a cache

2022-09-21 Thread GitBox
ocket commented on issue #7076: URL: https://github.com/apache/trafficcontrol/issues/7076#issuecomment-1254042652 Server types should be eliminated entirely, IMO. Or at least cache servers should not have mutable, user-create-able types. You can fairly easily place an indicator on a

[GitHub] [trafficcontrol] mitchell852 commented on issue #7076: Add server indicator if a server is a cache

2022-09-21 Thread GitBox
mitchell852 commented on issue #7076: URL: https://github.com/apache/trafficcontrol/issues/7076#issuecomment-1254011874 well that all sounds great/hard but don't you think a simple flag on a server (cache=true/false) which could be set on migration if type=EDGE*/MID* and allowing the

[GitHub] [trafficcontrol] zrhoffman merged pull request #7077: Fix duplicate labels in the documentation

2022-09-21 Thread GitBox
zrhoffman merged PR #7077: URL: https://github.com/apache/trafficcontrol/pull/7077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7039: Fix docs for DS retries

2022-09-21 Thread GitBox
ocket commented on code in PR #7039: URL: https://github.com/apache/trafficcontrol/pull/7039#discussion_r976746657 ## cache-config/t3c-apply/torequest/cmd.go: ## @@ -294,21 +294,9 @@ func sendUpdate(cfg config.Cfg, configApplyTime, revalApplyTime *time.Time, conf

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7039: Fix docs for DS retries

2022-09-21 Thread GitBox
ocket commented on code in PR #7039: URL: https://github.com/apache/trafficcontrol/pull/7039#discussion_r976746657 ## cache-config/t3c-apply/torequest/cmd.go: ## @@ -294,21 +294,9 @@ func sendUpdate(cfg config.Cfg, configApplyTime, revalApplyTime *time.Time, conf

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7077: Fix duplicate labels in the documentation

2022-09-21 Thread GitBox
ocket opened a new pull request, #7077: URL: https://github.com/apache/trafficcontrol/pull/7077 This PR fixes some duplicate labels which were resulting in broken or incorrect links since #7063 introduced them. ## Which Traffic Control components are affected by this PR?

[GitHub] [trafficcontrol] ocket8888 commented on issue #7076: Add server indicator if a server is a cache

2022-09-21 Thread GitBox
ocket commented on issue #7076: URL: https://github.com/apache/trafficcontrol/issues/7076#issuecomment-1253900057 The original plan with TPv2 was to artificially separate server types into cache and non-cache, but that turned out to be difficult and expensive, because what a "cache

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-21 Thread GitBox
ocket commented on code in PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r976670398 ## lib/go-tc/deliveryservice_servers.go: ## @@ -189,21 +189,33 @@ type DSServerResponseV30 struct { // DSServerV4 contains information for a V4.x Delivery

[GitHub] [trafficcontrol] mitchell852 commented on issue #4906: v4.1.0 TP in section bandwidth shows unrealistic values

2022-09-21 Thread GitBox
mitchell852 commented on issue #4906: URL: https://github.com/apache/trafficcontrol/issues/4906#issuecomment-1253869575 @cheluskin unfortunately 4.x is no longer supported. can you upgrade to a currently supported version and see if you still have the problem?

[GitHub] [trafficcontrol] zrhoffman commented on issue #6963: `POST /api/3.1/servers` does not set `updPending`

2022-09-21 Thread GitBox
zrhoffman commented on issue #6963: URL: https://github.com/apache/trafficcontrol/issues/6963#issuecomment-1253825778 @mitchell852 It does not work as expected but only affects API version 3. We're sort of waiting for API version 3 to go away to close the issue -- This is an automated

[GitHub] [trafficcontrol] mitchell852 commented on issue #6963: `POST /api/3.1/servers` does not set `updPending`

2022-09-21 Thread GitBox
mitchell852 commented on issue #6963: URL: https://github.com/apache/trafficcontrol/issues/6963#issuecomment-1253817831 so is this works as expected or needs to be fixed? @zrhoffman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] mitchell852 opened a new issue, #7076: Add server indicator if a server is a cache

2022-09-21 Thread GitBox
mitchell852 opened a new issue, #7076: URL: https://github.com/apache/trafficcontrol/issues/7076 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Ops - Traffic Portal ## Current behavior: ALL

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-19 Thread GitBox
zrhoffman commented on code in PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r974745382 ## traffic_ops/traffic_ops_golang/deliveryservice/servers/servers_test.go: ## @@ -192,10 +194,13 @@ func getMockDSServers() []tc.DSServerV4 {

[GitHub] [trafficcontrol] srijeet0406 commented on issue #6033: Add ability to assign and remove a server capability for multiple servers at a time

2022-09-19 Thread GitBox
srijeet0406 commented on issue #6033: URL: https://github.com/apache/trafficcontrol/issues/6033#issuecomment-1251635664 This was earlier linked to https://github.com/apache/trafficcontrol/pull/6996 and https://github.com/apache/trafficcontrol/pull/7020. However, those PRs are for adding

[GitHub] [trafficcontrol] rawlinp opened a new issue, #6033: Add ability to assign and remove a server capability for multiple servers at a time

2022-09-19 Thread GitBox
rawlinp opened a new issue, #6033: URL: https://github.com/apache/trafficcontrol/issues/6033 ## I'm submitting a ... - new feature / enhancement request ## Traffic Control components affected ... - Traffic Ops - Traffic Portal ## Current behavior: There is no way

<    6   7   8   9   10   11   12   13   14   15   >