date:20200213

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox

mitchell852 commented on a change in pull request #4394: TP: adds 
configurability (show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378983632
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/capabilityUsers/TableCapabilityUsersController.js
 ##
 @@ -17,11 +17,14 @@
  * under the License.
  */
 
-var TableCapabilityUsersController = function(capability, capUsers, $scope, 
$state, locationUtils) {
+var TableCapabilityUsersController = function(capability, capUsers, 
$controller, $scope, $state, locationUtils) {
 
-   $scope.capability = capability;
+   // extends the TableUsersController to inherit common methods
+   angular.extend(this, $controller('TableUsersController', { users: 
capUsers, $scope: $scope }));
 
-   $scope.capUsers = capUsers;
+   let capUsersTable;
+
+   $scope.capability = capability[0];
 
 Review comment:
   the call to get a capability looked like this:
   
   `GET /api/capabilities?name=foo` which returns an array of 1 so this was a 
bug that i fixed with this PR as you need to fetch it with the index.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #4257: Get request to api_capabilities using query values that don't exist return null

2020-02-13 Thread GitBox

mhoppa commented on issue #4257: Get request to api_capabilities using query 
values that don't exist return null
URL: https://github.com/apache/trafficcontrol/issues/4257#issuecomment-585801557
 
 
   this was fixed in https://github.com/apache/trafficcontrol/pull/4321 
@mitchell852 @rawlinp  @ocket  can you close 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox

mitchell852 commented on a change in pull request #4394: TP: adds 
configurability (show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378982702
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/cacheGroupParameters/table.cacheGroupParameters.tpl.html
 ##
 @@ -48,7 +60,6 @@
 {{::p.configFile}}
 {{::p.value}}
 {{::p.secure}}
-
 
 Review comment:
   would i have liked to leave it? yeah, but wasn't finding a good solution to 
keep it AND provide configurable show/hide capability of parameter columns


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox

mhoppa commented on a change in pull request #4394: TP: adds configurability 
(show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378985577
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/capabilityUsers/TableCapabilityUsersController.js
 ##
 @@ -17,11 +17,14 @@
  * under the License.
  */
 
-var TableCapabilityUsersController = function(capability, capUsers, $scope, 
$state, locationUtils) {
+var TableCapabilityUsersController = function(capability, capUsers, 
$controller, $scope, $state, locationUtils) {
 
-   $scope.capability = capability;
+   // extends the TableUsersController to inherit common methods
+   angular.extend(this, $controller('TableUsersController', { users: 
capUsers, $scope: $scope }));
 
-   $scope.capUsers = capUsers;
+   let capUsersTable;
+
+   $scope.capability = capability[0];
 
 Review comment:
   ahh make sense  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #4386: Fix dnssec refresh endpoint

2020-02-13 Thread GitBox

mhoppa commented on issue #4386: Fix dnssec refresh endpoint
URL: https://github.com/apache/trafficcontrol/pull/4386#issuecomment-585855654
 
 
   ready for review please remove the WIP tag


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox

mitchell852 commented on a change in pull request #4394: TP: adds 
configurability (show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378984778
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/cacheGroupParameters/table.cacheGroupParameters.tpl.html
 ##
 @@ -48,7 +60,6 @@
 {{::p.configFile}}
 {{::p.value}}
 {{::p.secure}}
-
 
 Review comment:
   actually, give me a sec. i have an idea.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox

mitchell852 commented on a change in pull request #4394: TP: adds 
configurability (show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378982102
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/cacheGroupParameters/table.cacheGroupParameters.tpl.html
 ##
 @@ -48,7 +60,6 @@
 {{::p.configFile}}
 {{::p.value}}
 {{::p.secure}}
-
 
 Review comment:
   this is kind of a "fake" column. it doesn't map to a property of a 
"parameter" so it makes things messy when defining columns in a dynamic and 
configurable way. i.e. 
   
   
   ```
"columns": [
{ "name": "Name", "visible": true, 
"searchable": true },
{ "name": "Config File", "visible": true, 
"searchable": true },
{ "name": "Value", "visible": true, 
"searchable": true },
{ "name": "Secure", "visible": true, 
"searchable": true }
],
   ```
   
   so rather than deal with it, i just removed it. you can still remove a param 
from a cg using the "context menu" (right click) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox

mhoppa commented on a change in pull request #4394: TP: adds configurability 
(show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378935342
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/cacheGroupParameters/table.cacheGroupParameters.tpl.html
 ##
 @@ -48,7 +60,6 @@
 {{::p.configFile}}
 {{::p.value}}
 {{::p.secure}}
-
 
 Review comment:
   why the removal of this? I think it was the easiest way to remove 
associations without the need to right click or search through the big list 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox

mhoppa commented on a change in pull request #4394: TP: adds configurability 
(show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378936950
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/capabilityUsers/TableCapabilityUsersController.js
 ##
 @@ -17,11 +17,14 @@
  * under the License.
  */
 
-var TableCapabilityUsersController = function(capability, capUsers, $scope, 
$state, locationUtils) {
+var TableCapabilityUsersController = function(capability, capUsers, 
$controller, $scope, $state, locationUtils) {
 
-   $scope.capability = capability;
+   // extends the TableUsersController to inherit common methods
+   angular.extend(this, $controller('TableUsersController', { users: 
capUsers, $scope: $scope }));
 
-   $scope.capUsers = capUsers;
+   let capUsersTable;
+
+   $scope.capability = capability[0];
 
 Review comment:
   more of just for my understanding but why did this go to indexing of the 
capability when setting it in the scope? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp closed issue #4257: Get request to api_capabilities using query values that don't exist return null

2020-02-13 Thread GitBox

rawlinp closed issue #4257: Get request to api_capabilities using query values 
that don't exist return null
URL: https://github.com/apache/trafficcontrol/issues/4257
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #5311

2020-02-13 Thread Apache Jenkins Server

See 


Changes:

[github] Make pkg.ps1 compatible with PowerShell Core (OSS version) (#4391)

[matthew_jackson] Added IPv6 checking to Traffic Monitor

[matthew_jackson] updated CHANGELOG

[matthew_jackson] update per comment

[matthew_jackson] update so TM UI updates when IP is removed

[matthew_jackson] ipv6 TP and TO updates

[matthew_jackson] ipv6 updates to TM and TR

[matthew_jackson] CHANGELOG update

[matthew_jackson] updates per comments


--
[...truncated 4.06 MB...]
[33;1mdocs_1   |[0m writing output... [ 74%] api/system_info
[33;1mdocs_1   |[0m writing output... [ 74%] api/tenants
[33;1mdocs_1   |[0m writing output... [ 75%] api/tenants_id
[33;1mdocs_1   |[0m writing output... [ 75%] api/to_extensions
[33;1mdocs_1   |[0m writing output... [ 75%] 
api/to_extensions_id
[33;1mdocs_1   |[0m writing output... [ 76%] 
api/to_extensions_id_delete
[33;1mdocs_1   |[0m writing output... [ 76%] 
api/traffic_monitor_stats
[33;1mdocs_1   |[0m writing output... [ 77%] api/types
[33;1mdocs_1   |[0m writing output... [ 77%] api/types_id
[33;1mdocs_1   |[0m writing output... [ 77%] api/types_trimmed
[33;1mdocs_1   |[0m writing output... [ 78%] api/user_current
[33;1mdocs_1   |[0m writing output... [ 78%] 
api/user_current_jobs
[33;1mdocs_1   |[0m writing output... [ 79%] 
api/user_current_update
[33;1mdocs_1   |[0m writing output... [ 79%] 
api/user_id_deliveryservices_available
[33;1mdocs_1   |[0m writing output... [ 80%] api/user_login
[33;1mdocs_1   |[0m writing output... [ 80%] 
api/user_login_oauth
[33;1mdocs_1   |[0m writing output... [ 80%] 
api/user_login_token
[33;1mdocs_1   |[0m writing output... [ 81%] api/user_logout
[33;1mdocs_1   |[0m writing output... [ 81%] 
api/user_reset_password
[33;1mdocs_1   |[0m writing output... [ 82%] api/users
[33;1mdocs_1   |[0m writing output... [ 82%] api/users_id
[33;1mdocs_1   |[0m writing output... [ 82%] 
api/users_id_deliveryservices
[33;1mdocs_1   |[0m writing output... [ 83%] 
api/users_register
[33;1mdocs_1   |[0m writing output... [ 83%] 
basics/cache_revalidation
[33;1mdocs_1   |[0m writing output... [ 84%] 
basics/content_delivery_networks
[33;1mdocs_1   |[0m writing output... [ 84%] basics/http_11
[33;1mdocs_1   |[0m writing output... [ 85%] basics/index
[33;1mdocs_1   |[0m writing output... [ 85%] 
development/building
[33;1mdocs_1   |[0m writing output... [ 85%] 
development/documentation_guidelines
[33;1mdocs_1   |[0m writing output... [ 86%] development/index
[33;1mdocs_1   |[0m writing output... [ 86%] 
development/ort/traffic_ops_ort
[33;1mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.configuration
[33;1mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.main_routines
[33;1mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.packaging
[33;1mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.to_api
[33;1mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.utils
[33;1mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor
[33;1mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor/traffic_monitor_api
[33;1mdocs_1   |[0m writing output... [ 90%] 
development/traffic_ops
[33;1mdocs_1   |[0m writing output... [ 90%] 
development/traffic_portal
[33;1mdocs_1   |[0m writing output... [ 90%] 
development/traffic_router
[33;1mdocs_1   |[0m writing output... [ 91%] 
development/traffic_router/traffic_router_api
[33;1mdocs_1   |[0m writing output... [ 91%] 
development/traffic_stats
[33;1mdocs_1   |[0m writing output... [ 92%] faq
[33;1mdocs_1   |[0m writing output... [ 92%] glossary
[33;1mdocs_1   |[0m writing output... [ 92%] index
[33;1mdocs_1   |[0m writing output... [ 93%] 
overview/cache_groups
[33;1mdocs_1   |[0m writing output... [ 93%] 
overview/delivery_services
[33;1mdocs_1   |[0m writing output... [ 94%] overview/index
[33;1mdocs_1   |[0m writing output... [ 94%] 
overview/introduction
[33;1mdocs_1

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox

mitchell852 commented on a change in pull request #4394: TP: adds 
configurability (show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r379014401
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/cacheGroupParameters/table.cacheGroupParameters.tpl.html
 ##
 @@ -48,7 +60,6 @@
 {{::p.configFile}}
 {{::p.value}}
 {{::p.secure}}
-
 
 Review comment:
   updated
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #5312

2020-02-13 Thread Apache Jenkins Server

See 


Changes:

[mitchell852] adds column configurability to users tables

[mitchell852] adds column configurability to parameters tables

[mitchell852] adds back the action column for each of parameter removal from a 
profile


--
[...truncated 2.99 MB...]
[36munit_1  |[0m === RUN   TestInterfaces
[36munit_1  |[0m --- PASS: TestInterfaces (0.00s)
[36munit_1  |[0m === RUN   TestValidate
[36munit_1  |[0m --- PASS: TestValidate (0.00s)
[36munit_1  |[0m PASS
[36munit_1  |[0m coverage: 15.7% of statements
[36munit_1  |[0m ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/physlocation
0.014s  coverage: 15.7% of statements
[36munit_1  |[0m === RUN   TestPingHandler
[36munit_1  |[0m --- PASS: TestPingHandler (0.00s)
[36munit_1  |[0m PASS
[36munit_1  |[0m coverage: 16.7% of statements
[36munit_1  |[0m ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/ping0.015s  
coverage: 16.7% of statements
[36munit_1  |[0m ?
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/plugin  [no 
test files]
[36munit_1  |[0m === RUN   TestCopyProfileInvalidExistingProfile
[36munit_1  |[0m === RUN   
TestCopyProfileInvalidExistingProfile/multiple_profiles_with_existing_name_returned
[36munit_1  |[0m === RUN   
TestCopyProfileInvalidExistingProfile/existing_profile_does_not_exist
[36munit_1  |[0m --- PASS: TestCopyProfileInvalidExistingProfile (0.00s)
[36munit_1  |[0m --- PASS: 
TestCopyProfileInvalidExistingProfile/multiple_profiles_with_existing_name_returned
 (0.00s)
[36munit_1  |[0m --- PASS: 
TestCopyProfileInvalidExistingProfile/existing_profile_does_not_exist (0.00s)
[36munit_1  |[0m === RUN   TestCopyNewProfileExists
[36munit_1  |[0m --- PASS: TestCopyNewProfileExists (0.00s)
[36munit_1  |[0m === RUN   TestCopyProfile
[36munit_1  |[0m --- PASS: TestCopyProfile (0.00s)
[36munit_1  |[0m === RUN   TestGetExportProfileResponse
[36munit_1  |[0m === RUN   
TestGetExportProfileResponse/Success:_Read_export_profile_successful
[36munit_1  |[0m === RUN   
TestGetExportProfileResponse/Success:_Read_export_profile_with_no_parameters_successful
[36munit_1  |[0m === RUN   
TestGetExportProfileResponse/Failure:_Storage_error_reading_profile
[36munit_1  |[0m --- PASS: TestGetExportProfileResponse (0.00s)
[36munit_1  |[0m --- PASS: 
TestGetExportProfileResponse/Success:_Read_export_profile_successful (0.00s)
[36munit_1  |[0m profile_export_test.go:74: Starting test scenario:  
Success: Read export profile successful
[36munit_1  |[0m --- PASS: 
TestGetExportProfileResponse/Success:_Read_export_profile_with_no_parameters_successful
 (0.00s)
[36munit_1  |[0m profile_export_test.go:74: Starting test scenario:  
Success: Read export profile with no parameters successful
[36munit_1  |[0m --- PASS: 
TestGetExportProfileResponse/Failure:_Storage_error_reading_profile (0.00s)
[36munit_1  |[0m profile_export_test.go:74: Starting test scenario:  
Failure: Storage error reading profile
[36munit_1  |[0m === RUN   TestGetImportProfile
[36munit_1  |[0m === RUN   
TestGetImportProfile/Success:_Import_profile_successful
[36munit_1  |[0m === RUN   
TestGetImportProfile/Failure:_Import_profile_didn't_insert_row
[36munit_1  |[0m === RUN   
TestGetImportProfile/Failure:_Import_profile_storage_error
[36munit_1  |[0m --- PASS: TestGetImportProfile (0.00s)
[36munit_1  |[0m --- PASS: 
TestGetImportProfile/Success:_Import_profile_successful (0.00s)
[36munit_1  |[0m profile_import_test.go:86: Starting test scenario:  
Success: Import profile successful
[36munit_1  |[0m --- PASS: 
TestGetImportProfile/Failure:_Import_profile_didn't_insert_row (0.00s)
[36munit_1  |[0m profile_import_test.go:86: Starting test scenario:  
Failure: Import profile didn't insert row
[36munit_1  |[0m --- PASS: 
TestGetImportProfile/Failure:_Import_profile_storage_error (0.00s)
[36munit_1  |[0m profile_import_test.go:86: Starting test scenario:  
Failure: Import profile storage error
[36munit_1  |[0m === RUN   TestGetImportProfileParameters
[36munit_1  |[0m === RUN   
TestGetImportProfileParameters/Success:_All_import_parameters_new
[36munit_1  |[0m === RUN   
TestGetImportProfileParameters/Success:_All_parameters_exisiting
[36munit_1  |[0m === RUN   
TestGetImportProfileParameters/Success:_Mix_of_existing/new_parameters
[36munit_1  |[0m === RUN   
TestGetImportProfileParameters/Success:_Dup_of_existing
[36munit_1  |[0m === RUN   
TestGetImportProfileParameters/Fail:_Storage_error_selecting_param
[36munit_1  |[0m === RUN   
TestGetImportProfileParameters/Fail:_Storage_error_inserting_param
[36munit_1  |[0m --- PASS: TestGetImportProfileParameters (0.00s)
[36munit_1  |[0m --- PASS:

Build failed in Jenkins: trafficcontrol-PR #5314

2020-02-13 Thread Apache Jenkins Server

See 

Changes:


--
[...truncated 2.68 MB...]
[32mdocs_1   |[0m writing output... [ 81%] 
api/user_reset_password
[32mdocs_1   |[0m writing output... [ 82%] api/users
[32mdocs_1   |[0m writing output... [ 82%] api/users_id
[32mdocs_1   |[0m writing output... [ 82%] 
api/users_id_deliveryservices
[32mdocs_1   |[0m writing output... [ 83%] api/users_register
[32mdocs_1   |[0m writing output... [ 83%] 
basics/cache_revalidation
[32mdocs_1   |[0m writing output... [ 84%] 
basics/content_delivery_networks
[32mdocs_1   |[0m writing output... [ 84%] basics/http_11
[32mdocs_1   |[0m writing output... [ 85%] basics/index
[32mdocs_1   |[0m writing output... [ 85%] 
development/building
[32mdocs_1   |[0m writing output... [ 85%] 
development/documentation_guidelines
[32mdocs_1   |[0m writing output... [ 86%] development/index
[32mdocs_1   |[0m writing output... [ 86%] 
development/ort/traffic_ops_ort
[32mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.configuration
[32mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.main_routines
[32mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.packaging
[32mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.to_api
[32mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.utils
[32mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor
[32mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor/traffic_monitor_api
[32mdocs_1   |[0m writing output... [ 90%] 
development/traffic_ops
[32mdocs_1   |[0m writing output... [ 90%] 
development/traffic_portal
[32mdocs_1   |[0m writing output... [ 90%] 
development/traffic_router
[32mdocs_1   |[0m writing output... [ 91%] 
development/traffic_router/traffic_router_api
[32mdocs_1   |[0m writing output... [ 91%] 
development/traffic_stats
[32mdocs_1   |[0m writing output... [ 92%] faq
[32mdocs_1   |[0m writing output... [ 92%] glossary
[32mdocs_1   |[0m writing output... [ 92%] index
[32mdocs_1   |[0m writing output... [ 93%] 
overview/cache_groups
[32mdocs_1   |[0m writing output... [ 93%] 
overview/delivery_services
[32mdocs_1   |[0m writing output... [ 94%] overview/index
[32mdocs_1   |[0m writing output... [ 94%] 
overview/introduction
[32mdocs_1   |[0m writing output... [ 95%] 
overview/profiles_and_parameters
[32mdocs_1   |[0m writing output... [ 95%] 
overview/traffic_monitor
[32mdocs_1   |[0m writing output... [ 95%] 
overview/traffic_ops
[32mdocs_1   |[0m writing output... [ 96%] 
overview/traffic_portal
[32mdocs_1   |[0m writing output... [ 96%] 
overview/traffic_router
[32mdocs_1   |[0m writing output... [ 97%] 
overview/traffic_stats
[32mdocs_1   |[0m writing output... [ 97%] 
overview/traffic_vault
[32mdocs_1   |[0m writing output... [ 97%] tools/atstccfg
[32mdocs_1   |[0m writing output... [ 98%] tools/compare
[32mdocs_1   |[0m writing output... [ 98%] tools/index
[32mdocs_1   |[0m writing output... [ 99%] tools/python_client
[32mdocs_1   |[0m writing output... [ 99%] tools/toaccess
[32mdocs_1   |[0m writing output... [100%] 
tools/traffic_vault_util
[32mdocs_1   |[0m 
[32mdocs_1   |[0m 
/tmp/go/src/github.com/apache/trafficcontrol/docs/source/overview/delivery_services.rst:190:
 WARNING: undefined label: ort-special-strings (if the link has no caption the 
label must precede a section header)
[32mdocs_1   |[0m 
/tmp/go/src/github.com/apache/trafficcontrol/docs/source/overview/delivery_services.rst:501:
 WARNING: undefined label: ort-special-strings (if the link has no caption the 
label must precede a section header)
[32mdocs_1   |[0m 
/tmp/go/src/github.com/apache/trafficcontrol/docs/source/overview/delivery_services.rst:628:
 WARNING: undefined label: ort-special-strings (if the link has no caption the 
label must precede a section header)
[32mdocs_1   |[0m 
/tmp/go/src/github.com/apache/trafficcontrol/docs/source/overview/delivery_services.rst:628:
 WARNING: undefined label: ort-remap-override (if

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox

ocket opened a new pull request #4397: Fixed /api/2.0/roles always 
returning empty array
URL: https://github.com/apache/trafficcontrol/pull/4397
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR is not related to any Issue
   
   The `/roles` endpoint when called in API version 2.0 is always returning an 
empty array because of how it handles the new v1.3 fields. This fixes that.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   Build and run, make a GET request to `/roles`, verify the resulting array of 
roles is not empty.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   ## The following criteria are ALL met by this PR
   - [x] Tests are being added in #4374 
   - [x] Documentation is being added in #4371 
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox

ocket commented on issue #4397: Fixed /api/2.0/roles always returning empty 
array
URL: https://github.com/apache/trafficcontrol/pull/4397#issuecomment-585945318
 
 
   Not really sure about "medium", but at best it means that new users can not 
be created and old ones can't be updated - which is a bit of a big deal when 
users can't be deleted.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #5315

2020-02-13 Thread Apache Jenkins Server

See

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox

ocket commented on a change in pull request #4397: Fixed /api/2.0/roles 
always returning empty array
URL: https://github.com/apache/trafficcontrol/pull/4397#discussion_r379107649
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/role/roles.go
 ##
 @@ -164,6 +164,11 @@ func (role *TORole) Read() ([]interface{}, error, error, 
int) {
if userErr != nil || sysErr != nil {
return nil, userErr, sysErr, errCode
}
+
+   if version.Major > 1 {
+   return vals, nil, nil, http.StatusOK
 
 Review comment:
   It that case I'll just move this into the loop below.
   Done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox

rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, 
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379024121
 
 

 ##
 File path: traffic_monitor/manager/manager.go
 ##
 @@ -45,6 +46,8 @@ import (
 func Start(opsConfigFile string, cfg config.Config, appData 
config.StaticAppData, trafficMonitorConfigFileName string) error {
toSession := 
towrap.ITrafficOpsSession(towrap.NewTrafficOpsSessionThreadsafe(nil, 
cfg.CRConfigHistoryCount, cfg))
 
+   url6Regex := regexp.MustCompile(`/\d+`)
 
 Review comment:
   I wanted to be sure, so I wrote a benchmark:
   
   ```
   package main
   
   import (
"math/rand"
"net"
"regexp"
"strconv"
"strings"
"testing"
   )
   
   func BenchmarkRemoveCIDRFunc(b *testing.B) {
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ipStrs[i] = ipv6CIDRStrToAddr(cidrStrs[i])
}
   }
   
   func BenchmarkRemoveCIDRRegex(b *testing.B) {
re := regexp.MustCompile(`/\d+`)
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ipStrs[i] = re.ReplaceAllString(cidrStrs[i], "")
}
   }
   
   func BenchmarkRemoveCIDRIP(b *testing.B) {
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ip, _, err := net.ParseCIDR(cidrStrs[i])
if err != nil {
b.Fatal("not an IP: '" + cidrStrs[i] + "'")
}
ipStrs[i] = ip.String()
}
   }
   
   func BenchmarkRemoveCIDRIPNoErrCheck(b *testing.B) {
// because the others don't check for malformed input, it wasn't really 
fair for the IP bench to do so if it's slower.
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ip, _, _ := net.ParseCIDR(cidrStrs[i])
ipStrs[i] = ip.String()
}
   }
   
   
   func randCIDRStrs(n int) []string {
ips := []net.IP{}
for i := 0; i < n; i++ {
ip := make([]byte, 16, 16)
rand.Read(ip) // math/rand.Read is documented to always return 
a nil error.
ips = append(ips, net.IP(ip))
}
   
ipStrs := []string{}
for _, ip := range ips {
ipStrs = append(ipStrs, 
ip.String()+`/`+strconv.Itoa(rand.Intn(129)))
}
   
return ipStrs
   }
   
   // ipv6CIDRStrToAddr takes an IPv6 CIDR string, e.g. `2001:DB8::1/32` 
returns `2001:DB8::1`.
   // It does not verify cidr is a valid CIDR or IPv6. It only removes the 
first slash and everything after it, for performance.
   func ipv6CIDRStrToAddr(cidr string) string {
i := strings.Index(cidr, `/`)
if i == -1 {
return cidr
}
return cidr[:i]
   }
   ```
   
   ```
   $ go test -bench=.
   goos: darwin
   goarch: amd64
   pkg: github.com/apache/trafficcontrol/traffic_monitor
   BenchmarkRemoveCIDRFunc-16  6310060523.7 ns/op
   BenchmarkRemoveCIDRRegex-16  4373604   290 ns/op
   BenchmarkRemoveCIDRIP-16 2342938   530 ns/op
   BenchmarkRemoveCIDRIPNoErrCheck-16   2322907   513 ns/op
   PASS
   ok  github.com/apache/trafficcontrol/traffic_monitor37.686s
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4399: Fixed '/deliveryservices' not working with API 2.0

2020-02-13 Thread GitBox

ocket opened a new pull request #4399: Fixed '/deliveryservices' not 
working with API 2.0
URL: https://github.com/apache/trafficcontrol/pull/4399
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR fixes #4398 
   
   This fixes the version-checking logic of the handler for GET requests to 
`/deliveryservices` to allow API versions >= 2.0.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   Make a GET request to `/deliveryservices` and observe that no internal 
server error occurs.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   ## The following criteria are ALL met by this PR
   - [x] Tests will be added by #4374 
   - [x] Documentation will be added by #4371 
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1833

2020-02-13 Thread Apache Jenkins Server

See 


Changes:

[github] TP: adds configurability (show/hide columns) to the parameters and 
users

[github] Fixed /api/2.0/roles always returning empty array (#4397)

[github] Fixed '/deliveryservices' not working with API 2.0 (#4399)


--
[...truncated 61.59 KB...]
[36munit_golang_1  |[0m PASS
[36munit_golang_1  |[0m coverage: 16.7% of statements
[36munit_golang_1  |[0m ok
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/ping0.108s  
coverage: 16.7% of statements
[36munit_golang_1  |[0m === RUN   TestCopyProfileInvalidExistingProfile
[36munit_golang_1  |[0m === RUN   
TestCopyProfileInvalidExistingProfile/multiple_profiles_with_existing_name_returned
[36munit_golang_1  |[0m === RUN   
TestCopyProfileInvalidExistingProfile/existing_profile_does_not_exist
[36munit_golang_1  |[0m --- PASS: TestCopyProfileInvalidExistingProfile 
(0.00s)
[36munit_golang_1  |[0m --- PASS: 
TestCopyProfileInvalidExistingProfile/multiple_profiles_with_existing_name_returned
 (0.00s)
[36munit_golang_1  |[0m --- PASS: 
TestCopyProfileInvalidExistingProfile/existing_profile_does_not_exist (0.00s)
[36munit_golang_1  |[0m === RUN   TestCopyNewProfileExists
[36munit_golang_1  |[0m --- PASS: TestCopyNewProfileExists (0.00s)
[36munit_golang_1  |[0m === RUN   TestCopyProfile
[36munit_golang_1  |[0m --- PASS: TestCopyProfile (0.00s)
[36munit_golang_1  |[0m === RUN   TestGetExportProfileResponse
[36munit_golang_1  |[0m === RUN   
TestGetExportProfileResponse/Success:_Read_export_profile_successful
[36munit_golang_1  |[0m === RUN   
TestGetExportProfileResponse/Success:_Read_export_profile_with_no_parameters_successful
[36munit_golang_1  |[0m === RUN   
TestGetExportProfileResponse/Failure:_Storage_error_reading_profile
[36munit_golang_1  |[0m --- PASS: TestGetExportProfileResponse (0.00s)
[36munit_golang_1  |[0m --- PASS: 
TestGetExportProfileResponse/Success:_Read_export_profile_successful (0.00s)
[36munit_golang_1  |[0m profile_export_test.go:74: Starting test 
scenario:  Success: Read export profile successful
[36munit_golang_1  |[0m --- PASS: 
TestGetExportProfileResponse/Success:_Read_export_profile_with_no_parameters_successful
 (0.00s)
[36munit_golang_1  |[0m profile_export_test.go:74: Starting test 
scenario:  Success: Read export profile with no parameters successful
[36munit_golang_1  |[0m --- PASS: 
TestGetExportProfileResponse/Failure:_Storage_error_reading_profile (0.00s)
[36munit_golang_1  |[0m profile_export_test.go:74: Starting test 
scenario:  Failure: Storage error reading profile
[36munit_golang_1  |[0m === RUN   TestGetImportProfile
[36munit_golang_1  |[0m === RUN   
TestGetImportProfile/Success:_Import_profile_successful
[36munit_golang_1  |[0m === RUN   
TestGetImportProfile/Failure:_Import_profile_didn't_insert_row
[36munit_golang_1  |[0m === RUN   
TestGetImportProfile/Failure:_Import_profile_storage_error
[36munit_golang_1  |[0m --- PASS: TestGetImportProfile (0.00s)
[36munit_golang_1  |[0m --- PASS: 
TestGetImportProfile/Success:_Import_profile_successful (0.00s)
[36munit_golang_1  |[0m profile_import_test.go:86: Starting test 
scenario:  Success: Import profile successful
[36munit_golang_1  |[0m --- PASS: 
TestGetImportProfile/Failure:_Import_profile_didn't_insert_row (0.00s)
[36munit_golang_1  |[0m profile_import_test.go:86: Starting test 
scenario:  Failure: Import profile didn't insert row
[36munit_golang_1  |[0m --- PASS: 
TestGetImportProfile/Failure:_Import_profile_storage_error (0.00s)
[36munit_golang_1  |[0m profile_import_test.go:86: Starting test 
scenario:  Failure: Import profile storage error
[36munit_golang_1  |[0m === RUN   TestGetImportProfileParameters
[36munit_golang_1  |[0m === RUN   
TestGetImportProfileParameters/Success:_All_import_parameters_new
[36munit_golang_1  |[0m === RUN   
TestGetImportProfileParameters/Success:_All_parameters_exisiting
[36munit_golang_1  |[0m === RUN   
TestGetImportProfileParameters/Success:_Mix_of_existing/new_parameters
[36munit_golang_1  |[0m === RUN   
TestGetImportProfileParameters/Success:_Dup_of_existing
[36munit_golang_1  |[0m === RUN   
TestGetImportProfileParameters/Fail:_Storage_error_selecting_param
[36munit_golang_1  |[0m === RUN   
TestGetImportProfileParameters/Fail:_Storage_error_inserting_param
[36munit_golang_1  |[0m --- PASS: TestGetImportProfileParameters (0.03s)
[36munit_golang_1  |[0m --- PASS: 
TestGetImportProfileParameters/Success:_All_import_parameters_new (0.03s)
[36munit_golang_1  |[0m profile_import_test.go:292: Starting test 
scenario:  Success: All import parameters new
[36munit_golang_1  |[0m --- PASS: 
TestGetImportProfileParameters/Success:_All_parameters_exisiting (0.00s)

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox

rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, 
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379024121
 
 

 ##
 File path: traffic_monitor/manager/manager.go
 ##
 @@ -45,6 +46,8 @@ import (
 func Start(opsConfigFile string, cfg config.Config, appData 
config.StaticAppData, trafficMonitorConfigFileName string) error {
toSession := 
towrap.ITrafficOpsSession(towrap.NewTrafficOpsSessionThreadsafe(nil, 
cfg.CRConfigHistoryCount, cfg))
 
+   url6Regex := regexp.MustCompile(`/\d+`)
 
 Review comment:
   I wanted to be sure, so I wrote a benchmark:
   
   ```
   package main
   
   import (
"math/rand"
"net"
"regexp"
"strconv"
"strings"
"testing"
   )
   
   func BenchmarkRemoveCIDRFunc(b *testing.B) {
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ipStrs[i] = ipv6CIDRStrToAddr(cidrStrs[i])
}
   }
   
   func BenchmarkRemoveCIDRRegex(b *testing.B) {
re := regexp.MustCompile(`/\d+`)
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ipStrs[i] = re.ReplaceAllString(cidrStrs[i], "")
}
   }
   
   func BenchmarkRemoveCIDRIP(b *testing.B) {
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ip, _, err := net.ParseCIDR(cidrStrs[i])
if err != nil {
b.Fatal("not an IP: '" + cidrStrs[i] + "'")
}
ipStrs[i] = ip.String()
}
   }
   
   func BenchmarkRemoveCIDRIPNoErrCheck(b *testing.B) {
// because the others don't check for malformed input, it wasn't really 
fair for the IP bench to do so if it's slower.
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ip, _, _ := net.ParseCIDR(cidrStrs[i])
ipStrs[i] = ip.String()
}
   }
   
   
   func randCIDRStrs(n int) []string {
ips := []net.IP{}
for i := 0; i < n; i++ {
ip := make([]byte, 16, 16)
rand.Read(ip) // math/rand.Read is documented to always return 
a nil error.
ips = append(ips, net.IP(ip))
}
   
ipStrs := []string{}
for _, ip := range ips {
ipStrs = append(ipStrs, 
ip.String()+`/`+strconv.Itoa(rand.Intn(129)))
}
   
return ipStrs
   }
   
   // ipv6CIDRStrToAddr takes an IPv6 CIDR string, e.g. `2001:DB8::1/32` 
returns `2001:DB8::1`.
   // It does not verify cidr is a valid CIDR or IPv6. It only removes the 
first slash and everything after it, for performance.
   func ipv6CIDRStrToAddr(cidr string) string {
i := strings.Index(cidr, `/`)
if i == -1 {
return cidr
}
return cidr[:i]
   }
   ```
   
   ```
   $ go test -bench=.
   goos: darwin
   goarch: amd64
   pkg: github.com/apache/trafficcontrol/traffic_monitor
   BenchmarkRemoveCIDRFunc-16  6310060523.7 ns/op
   BenchmarkRemoveCIDRRegex-16  4373604   290 ns/op
   BenchmarkRemoveCIDRIP-16 2342938   530 ns/op
   BenchmarkRemoveCIDRIPNoErrCheck-16   2322907   513 ns/op
   PASS
   ok  github.com/apache/trafficcontrol/traffic_monitor37.686s
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 opened a new issue #4398: /deliveryservices GET handler internal server error in 2.0

2020-02-13 Thread GitBox

ocket opened a new issue #4398: /deliveryservices GET handler internal 
server error in 2.0
URL: https://github.com/apache/trafficcontrol/issues/4398
 
 
   ## I'm submitting a ...
   - bug report
   
   ## Traffic Control components affected ...
   - Traffic Ops
   
   ## Current behavior:
   The Delivery Services `Read` handler isn't working with API version 2.0
   
   ## Expected / new behavior:
   The Delivery Services `Read` handler should work with API version 2.0
   
   ## Minimal reproduction of the problem with instructions:
   Make a GET request to `/api/2.0/deliveryservices`.
   
   ## Anything else:
   Error in the logs is:
   ```
   TODeliveryService.Read called with invalid API version: 2.0
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4400: TP: Fixes missubg ecs enabled property on a number of ds tables

2020-02-13 Thread GitBox

mitchell852 opened a new pull request #4400: TP: Fixes missubg ecs enabled 
property on a number of ds tables
URL: https://github.com/apache/trafficcontrol/pull/4400
 
 
   ## What does this PR (Pull Request) do?
   
   - [x] This PR is not related to any Issue 
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   
   ## The following criteria are ALL met by this PR
   
   - [ ] This PR includes tests OR I have explained why tests are unnecessary
   - [ ] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [ ] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [ ] This PR includes any and all required license headers
   - [ ] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox

rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, 
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379024121
 
 

 ##
 File path: traffic_monitor/manager/manager.go
 ##
 @@ -45,6 +46,8 @@ import (
 func Start(opsConfigFile string, cfg config.Config, appData 
config.StaticAppData, trafficMonitorConfigFileName string) error {
toSession := 
towrap.ITrafficOpsSession(towrap.NewTrafficOpsSessionThreadsafe(nil, 
cfg.CRConfigHistoryCount, cfg))
 
+   url6Regex := regexp.MustCompile(`/\d+`)
 
 Review comment:
   I wanted to be sure, so I wrote a benchmark:
   
   ```
   package main
   
   import (
"math/rand"
"net"
"regexp"
"strconv"
"strings"
"testing"
   )
   
   func BenchmarkRemoveCIDRFunc(b *testing.B) {
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ipStrs[i] = ipv6CIDRStrToAddr(cidrStrs[i])
}
   }
   
   func BenchmarkRemoveCIDRRegex(b *testing.B) {
re := regexp.MustCompile(`/\d+`)
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ipStrs[i] = re.ReplaceAllString(cidrStrs[i], "")
}
   }
   
   func BenchmarkRemoveCIDRIP(b *testing.B) {
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ip, _, err := net.ParseCIDR(cidrStrs[i])
if err != nil {
b.Fatal("not an IP: '" + cidrStrs[i] + "'")
}
ipStrs[i] = ip.String()
}
   }
   
   func BenchmarkRemoveCIDRIPNoErrCheck(b *testing.B) {
// because the others don't check for malformed input, it wasn't really 
fair for the IP bench to do so if it's slower.
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ip, _, _ := net.ParseCIDR(cidrStrs[i])
ipStrs[i] = ip.String()
}
   }
   
   
   func randCIDRStrs(n int) []string {
ips := []net.IP{}
for i := 0; i < n; i++ {
ip := make([]byte, 16, 16)
rand.Read(ip) // math/rand.Read is documented to always return 
a nil error.
ips = append(ips, net.IP(ip))
}
   
ipStrs := []string{}
for _, ip := range ips {
ipStrs = append(ipStrs, 
ip.String()+`/`+strconv.Itoa(rand.Intn(129)))
}
   
return ipStrs
   }
   
   // ipv6CIDRStrToAddr takes an IPv6 CIDR string, e.g. `2001:DB8::1/32` 
returns `2001:DB8::1`.
   // It does not verify cidr is a valid CIDR or IPv6. It only removes the 
first slash and everything after it, for performance.
   func ipv6CIDRStrToAddr(cidr string) string {
i := strings.Index(cidr, `/`)
if i == -1 {
return cidr
}
return cidr[:i]
   }
   ```
   
   ```
   $ go test -bench=.
   goos: darwin
   goarch: amd64
   pkg: github.com/apache/trafficcontrol/traffic_monitor
   BenchmarkRemoveCIDRFunc-16  63100605   23.7 ns/op
   BenchmarkRemoveCIDRRegex-16  4373604   290 ns/op
   BenchmarkRemoveCIDRIP-16 2342938   530 ns/op
   BenchmarkRemoveCIDRIPNoErrCheck-16   2322907   513 ns/op
   PASS
   ok  github.com/apache/trafficcontrol/traffic_monitor37.686s
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox

ocket commented on a change in pull request #4142: Allow IPv6 Only Caches, 
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379037787
 
 

 ##
 File path: traffic_monitor/manager/manager.go
 ##
 @@ -45,6 +46,8 @@ import (
 func Start(opsConfigFile string, cfg config.Config, appData 
config.StaticAppData, trafficMonitorConfigFileName string) error {
toSession := 
towrap.ITrafficOpsSession(towrap.NewTrafficOpsSessionThreadsafe(nil, 
cfg.CRConfigHistoryCount, cfg))
 
+   url6Regex := regexp.MustCompile(`/\d+`)
 
 Review comment:
   Sure but if the result of stripping is used for TCP dials then you're paying 
that cost anyway. Idk how it's used later on, just wanted to throw that out 
there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #5313

2020-02-13 Thread Apache Jenkins Server

See 


Changes:

[github] Rewrote deliveryservices/{{ID}/safe to Go (#4388)

[github] Deprecate /regions/name/{{name}} (#4357)

[github] Remove methods marked as deprecated in 3.x (#4390)

[github] Added documentation for atstccfg (#4291)

[github] updated API to version 2.x (#4378)

[github] Make pkg.ps1 compatible with PowerShell Core (OSS version) (#4391)

[ocket] Updated experimental Angular8 TP to use TOAPI v2.0

[ocket] Updated CDN-in-a-Box to use TOAPI v2.0

[ocket] Updated atstccfg library to use TOAPI v2.0 (don't think that 
matters,

[ocket] Updated ATS simulator to use TO API v2.0

[ocket] Updated an example in a README

[ocket] (Partially) Updated cfg_test to use TOAPI v2.0 (but not the config 
gen

[ocket] Updated Java TO client to use TOAPI v2.0

[ocket] fixed typo

[ocket] Updated Python client to use TOAPI v2.0

[ocket] Updated 'extensions' script to use TOAPI v2.0

[ocket] Updated check scripts to use TOAPI v2.0

[ocket] Updated database script to use TOAPI v2.0

[ocket] Updated Go TO client to use TO API v2.0


--
[...truncated 2.63 MB...]
[35mdocs_1   |[0m writing output... [ 81%] 
api/user_reset_password
[35mdocs_1   |[0m writing output... [ 82%] api/users
[35mdocs_1   |[0m writing output... [ 82%] api/users_id
[35mdocs_1   |[0m writing output... [ 82%] 
api/users_id_deliveryservices
[35mdocs_1   |[0m writing output... [ 83%] api/users_register
[35mdocs_1   |[0m writing output... [ 83%] 
basics/cache_revalidation
[35mdocs_1   |[0m writing output... [ 84%] 
basics/content_delivery_networks
[35mdocs_1   |[0m writing output... [ 84%] basics/http_11
[35mdocs_1   |[0m writing output... [ 85%] basics/index
[35mdocs_1   |[0m writing output... [ 85%] 
development/building
[35mdocs_1   |[0m writing output... [ 85%] 
development/documentation_guidelines
[35mdocs_1   |[0m writing output... [ 86%] development/index
[35mdocs_1   |[0m writing output... [ 86%] 
development/ort/traffic_ops_ort
[35mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.configuration
[35mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.main_routines
[35mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.packaging
[35mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.to_api
[35mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.utils
[35mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor
[35mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor/traffic_monitor_api
[35mdocs_1   |[0m writing output... [ 90%] 
development/traffic_ops
[35mdocs_1   |[0m writing output... [ 90%] 
development/traffic_portal
[35mdocs_1   |[0m writing output... [ 90%] 
development/traffic_router
[35mdocs_1   |[0m writing output... [ 91%] 
development/traffic_router/traffic_router_api
[35mdocs_1   |[0m writing output... [ 91%] 
development/traffic_stats
[35mdocs_1   |[0m writing output... [ 92%] faq
[35mdocs_1   |[0m writing output... [ 92%] glossary
[35mdocs_1   |[0m writing output... [ 92%] index
[35mdocs_1   |[0m writing output... [ 93%] 
overview/cache_groups
[35mdocs_1   |[0m writing output... [ 93%] 
overview/delivery_services
[35mdocs_1   |[0m writing output... [ 94%] overview/index
[35mdocs_1   |[0m writing output... [ 94%] 
overview/introduction
[35mdocs_1   |[0m writing output... [ 95%] 
overview/profiles_and_parameters
[35mdocs_1   |[0m writing output... [ 95%] 
overview/traffic_monitor
[35mdocs_1   |[0m writing output... [ 95%] 
overview/traffic_ops
[35mdocs_1   |[0m writing output... [ 96%] 
overview/traffic_portal
[35mdocs_1   |[0m writing output... [ 96%] 
overview/traffic_router
[35mdocs_1   |[0m writing output... [ 97%] 
overview/traffic_stats
[35mdocs_1   |[0m writing output... [ 97%] 
overview/traffic_vault
[35mdocs_1   |[0m writing output... [ 97%] tools/atstccfg
[35mdocs_1   |[0m writing output... [ 98%] tools/compare
[35mdocs_1   |[0m writing output... [ 98%] tools/index
[35mdocs_1   |[0m writing output... [ 99%] tools/python_client
[35mdocs_1

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox

mhoppa commented on a change in pull request #4397: Fixed /api/2.0/roles always 
returning empty array
URL: https://github.com/apache/trafficcontrol/pull/4397#discussion_r379104175
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/role/roles.go
 ##
 @@ -164,6 +164,11 @@ func (role *TORole) Read() ([]interface{}, error, error, 
int) {
if userErr != nil || sysErr != nil {
return nil, userErr, sysErr, errCode
}
+
+   if version.Major > 1 {
+   return vals, nil, nil, http.StatusOK
 
 Review comment:
   this needs to fill in the capabilities else it will return nil for 
capabilities 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 merged pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox

ocket merged pull request #4394: TP: adds configurability (show/hide 
columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox

rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, 
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379024121
 
 

 ##
 File path: traffic_monitor/manager/manager.go
 ##
 @@ -45,6 +46,8 @@ import (
 func Start(opsConfigFile string, cfg config.Config, appData 
config.StaticAppData, trafficMonitorConfigFileName string) error {
toSession := 
towrap.ITrafficOpsSession(towrap.NewTrafficOpsSessionThreadsafe(nil, 
cfg.CRConfigHistoryCount, cfg))
 
+   url6Regex := regexp.MustCompile(`/\d+`)
 
 Review comment:
   I wanted to be sure, so I wrote a benchmark:
   
   ```
   package main
   
   import (
"math/rand"
"net"
"regexp"
"strconv"
"strings"
"testing"
   )
   
   func BenchmarkRemoveCIDRFunc(b *testing.B) {
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ipStrs[i] = ipv6CIDRStrToAddr(cidrStrs[i])
}
   }
   
   func BenchmarkRemoveCIDRRegex(b *testing.B) {
re := regexp.MustCompile(`/\d+`)
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ipStrs[i] = re.ReplaceAllString(cidrStrs[i], "")
}
   }
   
   func BenchmarkRemoveCIDRIP(b *testing.B) {
cidrStrs := randCIDRStrs(b.N)
ipStrs := make([]string, len(cidrStrs), len(cidrStrs))
   
b.ResetTimer()
for i := 0; i < b.N; i++ {
ip, _, err := net.ParseCIDR(cidrStrs[i])
if err != nil {
b.Fatal("not an IP: '" + cidrStrs[i] + "'")
}
ipStrs[i] = ip.String()
}
   }
   
   func randCIDRStrs(n int) []string {
ips := []net.IP{}
for i := 0; i < n; i++ {
ip := make([]byte, 16, 16)
rand.Read(ip) // math/rand.Read is documented to always return 
a nil error.
ips = append(ips, net.IP(ip))
}
   
ipStrs := []string{}
for _, ip := range ips {
ipStrs = append(ipStrs, 
ip.String()+`/`+strconv.Itoa(rand.Intn(129)))
}
   
return ipStrs
   }
   
   // ipv6CIDRStrToAddr takes an IPv6 CIDR string, e.g. `2001:DB8::1/32` 
returns `2001:DB8::1`.
   // It does not verify cidr is a valid CIDR or IPv6. It only removes the 
first slash and everything after it, for performance.
   func ipv6CIDRStrToAddr(cidr string) string {
i := strings.Index(cidr, `/`)
if i == -1 {
return cidr
}
return cidr[:i]
   }
   ```
   
   ```
   $ go test -bench=.
   goos: darwin
   goarch: amd64
   pkg: github.com/apache/trafficcontrol/traffic_monitor
   BenchmarkRemoveCIDRFunc-16  6310060523.7 ns/op
   BenchmarkRemoveCIDRRegex-16  4373604   290 ns/op
   BenchmarkRemoveCIDRIP-16 2069672   528 ns/op
   PASS
   ok  github.com/apache/trafficcontrol/traffic_monitor37.686s
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 closed issue #4398: /deliveryservices GET handler internal server error in 2.0

2020-02-13 Thread GitBox

mitchell852 closed issue #4398: /deliveryservices GET handler internal server 
error in 2.0
URL: https://github.com/apache/trafficcontrol/issues/4398
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 merged pull request #4399: Fixed '/deliveryservices' not working with API 2.0

2020-02-13 Thread GitBox

mitchell852 merged pull request #4399: Fixed '/deliveryservices' not working 
with API 2.0
URL: https://github.com/apache/trafficcontrol/pull/4399
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 merged pull request #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox

mitchell852 merged pull request #4397: Fixed /api/2.0/roles always returning 
empty array
URL: https://github.com/apache/trafficcontrol/pull/4397
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #5321

2020-02-13 Thread Apache Jenkins Server

See 


Changes:

[ocket] Updated experimental Angular8 TP to use TOAPI v2.0

[ocket] Updated CDN-in-a-Box to use TOAPI v2.0

[ocket] Updated atstccfg library to use TOAPI v2.0 (don't think that 
matters,

[ocket] Updated ATS simulator to use TO API v2.0

[ocket] Updated an example in a README

[ocket] (Partially) Updated cfg_test to use TOAPI v2.0 (but not the config 
gen

[ocket] Updated Java TO client to use TOAPI v2.0

[ocket] fixed typo

[ocket] Updated Python client to use TOAPI v2.0

[ocket] Updated 'extensions' script to use TOAPI v2.0

[ocket] Updated check scripts to use TOAPI v2.0

[ocket] Updated database script to use TOAPI v2.0

[ocket] Updated Go TO client to use TO API v2.0

[ocket] 'updated' compare tool suite to use TO API v2.0

[ocket] Updated Traffic Portal to use TO API v2.0


--
[...truncated 2.63 MB...]
[36;1mdocs_1   |[0m writing output... [ 81%] 
api/user_reset_password
[36;1mdocs_1   |[0m writing output... [ 82%] api/users
[36;1mdocs_1   |[0m writing output... [ 82%] api/users_id
[36;1mdocs_1   |[0m writing output... [ 82%] 
api/users_id_deliveryservices
[36;1mdocs_1   |[0m writing output... [ 83%] 
api/users_register
[36;1mdocs_1   |[0m writing output... [ 83%] 
basics/cache_revalidation
[36;1mdocs_1   |[0m writing output... [ 84%] 
basics/content_delivery_networks
[36;1mdocs_1   |[0m writing output... [ 84%] basics/http_11
[36;1mdocs_1   |[0m writing output... [ 85%] basics/index
[36;1mdocs_1   |[0m writing output... [ 85%] 
development/building
[36;1mdocs_1   |[0m writing output... [ 85%] 
development/documentation_guidelines
[36;1mdocs_1   |[0m writing output... [ 86%] development/index
[36;1mdocs_1   |[0m writing output... [ 86%] 
development/ort/traffic_ops_ort
[36;1mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.configuration
[36;1mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.main_routines
[36;1mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.packaging
[36;1mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.to_api
[36;1mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.utils
[36;1mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor
[36;1mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor/traffic_monitor_api
[36;1mdocs_1   |[0m writing output... [ 90%] 
development/traffic_ops
[36;1mdocs_1   |[0m writing output... [ 90%] 
development/traffic_portal
[36;1mdocs_1   |[0m writing output... [ 90%] 
development/traffic_router
[36;1mdocs_1   |[0m writing output... [ 91%] 
development/traffic_router/traffic_router_api
[36;1mdocs_1   |[0m writing output... [ 91%] 
development/traffic_stats
[36;1mdocs_1   |[0m writing output... [ 92%] faq
[36;1mdocs_1   |[0m writing output... [ 92%] glossary
[36;1mdocs_1   |[0m writing output... [ 92%] index
[36;1mdocs_1   |[0m writing output... [ 93%] 
overview/cache_groups
[36;1mdocs_1   |[0m writing output... [ 93%] 
overview/delivery_services
[36;1mdocs_1   |[0m writing output... [ 94%] overview/index
[36;1mdocs_1   |[0m writing output... [ 94%] 
overview/introduction
[36;1mdocs_1   |[0m writing output... [ 95%] 
overview/profiles_and_parameters
[36;1mdocs_1   |[0m writing output... [ 95%] 
overview/traffic_monitor
[36;1mdocs_1   |[0m writing output... [ 95%] 
overview/traffic_ops
[36;1mdocs_1   |[0m writing output... [ 96%] 
overview/traffic_portal
[36;1mdocs_1   |[0m writing output... [ 96%] 
overview/traffic_router
[36;1mdocs_1   |[0m writing output... [ 97%] 
overview/traffic_stats
[36;1mdocs_1   |[0m writing output... [ 97%] 
overview/traffic_vault
[36;1mdocs_1   |[0m writing output... [ 97%] tools/atstccfg
[36;1mdocs_1   |[0m writing output... [ 98%] tools/compare
[36;1mdocs_1   |[0m writing output... [ 98%] tools/index
[36;1mdocs_1   |[0m writing output... [ 99%] 
tools/python_client
[36;1mdocs_1   |[0m writing output... [ 99%] tools/toaccess
[36;1mdocs_1   |[0m writing output... [100%] 
tools/traffic_vault_util

Jenkins build is back to normal : trafficcontrol-PR #5322

2020-02-13 Thread Apache Jenkins Server

See

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox

rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, 
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379169003
 
 

 ##
 File path: traffic_monitor/poller/cache.go
 ##
 @@ -162,14 +181,30 @@ func poller(
pollID := atomic.AddUint64(, 1)
pollFinishedChan := make(chan uint64)
log.Debugf("poll %v %v start\n", pollID, time.Now())
-   bts, reqEnd, reqTime, err := pollFunc(pollCtx, url, 
host, pollID)
-   rdr := io.Reader(nil)
-   if bts != nil {
-   rdr = bytes.NewReader(bts) // TODO change 
handler to take bytes? Benchmark?
+   if usingIPv4 {
+   bts, reqEnd, reqTime, err := pollFunc(pollCtx, 
url, host, pollID)
 
 Review comment:
   It looks like this and the next block are identical, except for `url`. Could 
the duplication be reduced by changing this to 
   ```
   pollURL := url
   if !usingIPv4 {
 pollURL = url6
   }
   bts, reqEnd, reqTime, err := pollFunc(pollCtx, pollURL, host, pollID)
   ```
   ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox

rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, 
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379176893
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/crconfig/servers.go
 ##
 @@ -111,7 +111,7 @@ func getAllServers(cdn string, tx *sql.Tx) 
(map[string]ServerUnion, error) {
 
// TODO select deliveryservices as array?
q := `
-select s.host_name, cg.name as cachegroup, concat(s.host_name, '.', 
s.domain_name) as fqdn, s.xmpp_id as hashid, s.https_port, s.interface_name, 
s.ip_address, s.ip6_address, s.tcp_port, p.name as profile_name, 
cast(p.routing_disabled as int), st.name as status, t.name as type
+select s.host_name, cg.name as cachegroup, concat(s.host_name, '.', 
s.domain_name) as fqdn, s.xmpp_id as hashid, s.https_port, s.interface_name, 
case when s.ip_address_is_service = true then s.ip_address else '' end, case 
when s.ip6_address_is_service = true then s.ip6_address else '' end, 
s.tcp_port, p.name as profile_name, cast(p.routing_disabled as int), st.name as 
status, t.name as type
 
 Review comment:
   How strongly do you feel about this, vs an `if` statement in Go?
   
   The `case` here is a conditional. I know this feels like a nitpick, but in 
my experience, embedding code in the database or queries leads to pain. I think 
if we keep code as code, and data as data, and SQL as a declarative query, it 
just makes everything easier to understand and work with, and less to 
misunderstand or go wrong.
   
   Here, the `case` is technically SQL, but it's an imperative `if` statement, 
not declarative like SQL is intended to be. It's not a query, it's logic.
   
   Would you object to changing this to something like:
   ```
qry := `
   SELECT
 s.host_name,
 cg.name AS cachegroup,
 CONCAT(s.host_name, '.', s.domain_name) AS fqdn,
 s.xmpp_id AS hashid,
 s.https_port,
 s.interface_name,
 s.ip_address_is_service,
 s.ip6_address_is_service,
 s.ip_address,
 s.ip6_address,
 s.tcp_port,
 p.name AS profile_name,
 CAST(p.routing_disabled AS int),
 st.name AS status,
 t.name AS type
   FROM
 server s
 JOIN cachegroup cg ON cg.id = s.cachegroup
 JOIN type t on t.id = s.type
 JOIN profile p ON p.id = s.profile
 JOIN status st ON st.id = s.status
   WHERE
 cdn_id = (SELECT id FROM cdn WHERE name = $1)
 AND (st.name = 'REPORTED' or st.name = 'ONLINE' or st.name = 'ADMIN_DOWN')
   `
rows, err := tx.Query(qry, cdn)
if err != nil {
return nil, errors.New("Error querying servers: " + err.Error())
}
defer rows.Close()
   
for rows.Next() {
port := sql.NullInt64{}
ip6 := sql.NullString{}
hashId := sql.NullString{}
httpsPort := sql.NullInt64{}
ipIsService := false
ipIsService := false
host := ""
status := ""
s := ServerUnion{}
if err := rows.Scan(, , , , 
, , , , , , , 
, , , ); err != nil {
return nil, errors.New("Error scanning server: " + 
err.Error())
}
if !ipIsService {
s.Ip = util.StrPtr("")
}
if !ip6IsService {
s.Ip6 = util.StrPtr("")
}
   ```
   
   Really, the very need for imperative logic here is a result of 
denormalization. But we certainly don't have time to properly normalize our 
schema right now.
   
   I know my position is a little bit nuanced. If you feel strongly in the 
other direction, I won't push for it. But if it's all the same to you, IMO the 
separation of data vs code makes things easier and safer to work with.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #5324

2020-02-13 Thread Apache Jenkins Server

See 

Changes:


--
GitHub pull request #4401 of commit 126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc, 
no merge conflicts.
Running as SYSTEM
Setting status of 126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/5324/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H36 (ubuntu) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc^{commit} # timeout=10
 > git rev-parse origin/126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc^{commit} # 
 > timeout=10
 > git rev-parse 126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc^{commit} # timeout=10
 > git rev-parse origin/126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc^{commit} # 
 > timeout=10
 > git rev-parse 126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc^{commit} # timeout=10
 > git rev-parse origin/126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc^{commit} # 
 > timeout=10
 > git rev-parse 126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

Build failed in Jenkins: trafficcontrol-PR #5325

2020-02-13 Thread Apache Jenkins Server

See 


Changes:

[mitchell852] upgrades load-grunt-config to 3.0.1


--
[...truncated 2.87 MB...]
[32;1mdocs_1   |[0m writing output... [ 75%] api/tenants_id
[32;1mdocs_1   |[0m writing output... [ 75%] api/to_extensions
[32;1mdocs_1   |[0m writing output... [ 75%] 
api/to_extensions_id
[32;1mdocs_1   |[0m writing output... [ 76%] 
api/to_extensions_id_delete
[32;1mdocs_1   |[0m writing output... [ 76%] 
api/traffic_monitor_stats
[32;1mdocs_1   |[0m writing output... [ 77%] api/types
[32;1mdocs_1   |[0m writing output... [ 77%] api/types_id
[32;1mdocs_1   |[0m writing output... [ 77%] api/types_trimmed
[32;1mdocs_1   |[0m writing output... [ 78%] api/user_current
[32;1mdocs_1   |[0m writing output... [ 78%] 
api/user_current_jobs
[32;1mdocs_1   |[0m writing output... [ 79%] 
api/user_current_update
[32;1mdocs_1   |[0m writing output... [ 79%] 
api/user_id_deliveryservices_available
[32;1mdocs_1   |[0m writing output... [ 80%] api/user_login
[32;1mdocs_1   |[0m writing output... [ 80%] 
api/user_login_oauth
[32;1mdocs_1   |[0m writing output... [ 80%] 
api/user_login_token
[32;1mdocs_1   |[0m writing output... [ 81%] api/user_logout
[32;1mdocs_1   |[0m writing output... [ 81%] 
api/user_reset_password
[32;1mdocs_1   |[0m writing output... [ 82%] api/users
[32;1mdocs_1   |[0m writing output... [ 82%] api/users_id
[32;1mdocs_1   |[0m writing output... [ 82%] 
api/users_id_deliveryservices
[32;1mdocs_1   |[0m writing output... [ 83%] 
api/users_register
[32;1mdocs_1   |[0m writing output... [ 83%] 
basics/cache_revalidation
[32;1mdocs_1   |[0m writing output... [ 84%] 
basics/content_delivery_networks
[32;1mdocs_1   |[0m writing output... [ 84%] basics/http_11
[32;1mdocs_1   |[0m writing output... [ 85%] basics/index
[32;1mdocs_1   |[0m writing output... [ 85%] 
development/building
[32;1mdocs_1   |[0m writing output... [ 85%] 
development/documentation_guidelines
[32;1mdocs_1   |[0m writing output... [ 86%] development/index
[32;1mdocs_1   |[0m writing output... [ 86%] 
development/ort/traffic_ops_ort
[32;1mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.configuration
[32;1mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.main_routines
[32;1mdocs_1   |[0m writing output... [ 87%] 
development/ort/traffic_ops_ort.packaging
[32;1mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.to_api
[32;1mdocs_1   |[0m writing output... [ 88%] 
development/ort/traffic_ops_ort.utils
[32;1mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor
[32;1mdocs_1   |[0m writing output... [ 89%] 
development/traffic_monitor/traffic_monitor_api
[32;1mdocs_1   |[0m writing output... [ 90%] 
development/traffic_ops
[32;1mdocs_1   |[0m writing output... [ 90%] 
development/traffic_portal
[32;1mdocs_1   |[0m writing output... [ 90%] 
development/traffic_router
[32;1mdocs_1   |[0m writing output... [ 91%] 
development/traffic_router/traffic_router_api
[32;1mdocs_1   |[0m writing output... [ 91%] 
development/traffic_stats
[32;1mdocs_1   |[0m writing output... [ 92%] faq
[32;1mdocs_1   |[0m writing output... [ 92%] glossary
[32;1mdocs_1   |[0m writing output... [ 92%] index
[32;1mdocs_1   |[0m writing output... [ 93%] 
overview/cache_groups
[32;1mdocs_1   |[0m writing output... [ 93%] 
overview/delivery_services
[32;1mdocs_1   |[0m writing output... [ 94%] overview/index
[32;1mdocs_1   |[0m writing output... [ 94%] 
overview/introduction
[32;1mdocs_1   |[0m writing output... [ 95%] 
overview/profiles_and_parameters
[32;1mdocs_1   |[0m writing output... [ 95%] 
overview/traffic_monitor
[32;1mdocs_1   |[0m writing output... [ 95%] 
overview/traffic_ops
[32;1mdocs_1   |[0m writing output... [ 96%] 
overview/traffic_portal
[32;1mdocs_1   |[0m writing output... [ 96%] 
overview/traffic_router
[32;1mdocs_1   |[0m writing output... [ 97%] 
overview/traffic_stats
[32;1mdocs_1

[GitHub] [trafficcontrol] mitchell852 commented on issue #4400: TP: Fixes missing ecs enabled property on a number of ds tables

2020-02-13 Thread GitBox

mitchell852 commented on issue #4400: TP: Fixes missing ecs enabled property on 
a number of ds tables
URL: https://github.com/apache/trafficcontrol/pull/4400#issuecomment-585994819
 
 
   @mattjackson220 is going to review this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #5319

2020-02-13 Thread Apache Jenkins Server

See 

Changes:


--
GitHub pull request #4396 of commit b0ca67c0effb0f32041ec95cf4b54958fcbce359, 
no merge conflicts.
Running as SYSTEM
Setting status of b0ca67c0effb0f32041ec95cf4b54958fcbce359 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/5319/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H36 (ubuntu) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse b0ca67c0effb0f32041ec95cf4b54958fcbce359^{commit} # timeout=10
 > git rev-parse origin/b0ca67c0effb0f32041ec95cf4b54958fcbce359^{commit} # 
 > timeout=10
 > git rev-parse b0ca67c0effb0f32041ec95cf4b54958fcbce359^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse b0ca67c0effb0f32041ec95cf4b54958fcbce359^{commit} # timeout=10
 > git rev-parse origin/b0ca67c0effb0f32041ec95cf4b54958fcbce359^{commit} # 
 > timeout=10
 > git rev-parse b0ca67c0effb0f32041ec95cf4b54958fcbce359^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse b0ca67c0effb0f32041ec95cf4b54958fcbce359^{commit} # timeout=10
 > git rev-parse origin/b0ca67c0effb0f32041ec95cf4b54958fcbce359^{commit} # 
 > timeout=10
 > git rev-parse b0ca67c0effb0f32041ec95cf4b54958fcbce359^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

Build failed in Jenkins: trafficcontrol-PR #5320

2020-02-13 Thread Apache Jenkins Server

See 

Changes:


--
GitHub pull request #4396 of commit c86f0b09951c1c4db99299c213579e697e59e169, 
no merge conflicts.
Running as SYSTEM
Setting status of c86f0b09951c1c4db99299c213579e697e59e169 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/5320/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H36 (ubuntu) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse c86f0b09951c1c4db99299c213579e697e59e169^{commit} # timeout=10
 > git rev-parse origin/c86f0b09951c1c4db99299c213579e697e59e169^{commit} # 
 > timeout=10
 > git rev-parse c86f0b09951c1c4db99299c213579e697e59e169^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse c86f0b09951c1c4db99299c213579e697e59e169^{commit} # timeout=10
 > git rev-parse origin/c86f0b09951c1c4db99299c213579e697e59e169^{commit} # 
 > timeout=10
 > git rev-parse c86f0b09951c1c4db99299c213579e697e59e169^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse c86f0b09951c1c4db99299c213579e697e59e169^{commit} # timeout=10
 > git rev-parse origin/c86f0b09951c1c4db99299c213579e697e59e169^{commit} # 
 > timeout=10
 > git rev-parse c86f0b09951c1c4db99299c213579e697e59e169^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4371: API 2.0 documentation

2020-02-13 Thread GitBox

ocket commented on a change in pull request #4371: API 2.0 documentation
URL: https://github.com/apache/trafficcontrol/pull/4371#discussion_r379171815
 
 

 ##
 File path: docs/source/api/v2/cdns_name_snapshot.rst
 ##
 @@ -0,0 +1,542 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-cdns-name-snapshot:
+
+**
+``cdns/{{name}}/snapshot``
+**
+.. caution:: This page is a stub! Much of it may be missing or just downright 
wrong - it needs a lot of love from people with the domain knowledge required 
to update it.
+
+``GET``
+===
+Retrieves the *current* :term:`Snapshot` for a CDN, which represents the 
current *operating state* of the CDN, **not** the current *configuration* of 
the CDN. The contents of this :term:`Snapshot` are currently used by Traffic 
Monitor and Traffic Router.
+
+:Auth. Required: Yes
+:Roles Required: "admin" or "operations"
+:Response Type:  Object
+
+Request Structure
+-
+.. table:: Request Path Parameters
+
+   
+--++
+   | Name | Description
|
+   
+==++
+   | name | The name of the CDN for which a :term:`Snapshot` shall be 
returned |
+   
+--++
+
+.. code-block:: http
+   :caption: Request Example
+
+   GET /api/2.0/cdns/CDN-in-a-Box/snapshot HTTP/1.1
+   Host: trafficops.infra.ciab.test
+   User-Agent: curl/7.47.0
+   Accept: */*
+   Cookie: mojolicious=...
+
+Response Structure
+--
+:config: An object containing basic configurations on the actual CDN object
+
+   :api.cache-control.max-age: A string containing an integer which 
specifies the value of ``max-age`` in the :mailheader:`Cache-Control` header of 
some HTTP responses, likely the :ref:`tr-api` responses
+   :certificates.polling.interval: A string containing an integer which 
specifies the interval, in seconds, on which other Traffic Control components 
should check for updated SSL certificates
+   :consistent.dns.routing:A string containing a boolean which 
indicates whether DNS routing will use a consistent hashing method or 
"round-robin"
+
+   "false"
+   The "round-robin" method will be used to define DNS 
routing
+   "true"
+   A consistent hashing method will be used to define DNS 
routing
+
+   :coveragezone.polling.interval:  A string containing an integer 
which specifies the interval, in seconds, on which Traffic Routers should check 
for a new Coverage Zone file
+   :coveragezone.polling.url:   The URL where a :term:`Coverage 
Zone File` may be requested by Traffic Routers
+   :dnssec.dynamic.response.expiration: A string containing a number and 
unit suffix that specifies the length of time for which dynamic responses to 
DNSSEC lookup queries should remain valid
+   :dnssec.dynamic.concurrencylevel:An integer that defines the size 
of the concurrency level (threads) of the Guava cache used by ZoneManager to 
store zone material
+   :dnssec.dynamic.initialcapacity: An integer that defines the 
initial size of the Guava cache, default is 1. Too low of a value can lead 
to expensive resizing
+   :dnssec.init.timeout:An integer that defines the number 
of minutes to allow for zone generation, this bounds the zone priming activity
+   :dnssec.enabled: A string that tells whether or not 
the CDN uses DNSSEC; one of:
+
+   "false"
+   DNSSEC is not used within this CDN
+   "true"
+   DNSSEC is used within this CDN
+
+   :domain_name:A string that is the :abbr:`TLD 
(Top-Level Domain)` served by the CDN
+   :federationmapping.polling.interval: A string containing an integer 
which specifies the interval, in seconds, on which other Traffic Control 
components should check for new federation mappings
+   :federationmapping.polling.url:  The URL where Traffic Control 
components can request federation mappings
+   :geolocation.polling.interval:   A string containing an integer 
which

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4371: API 2.0 documentation

2020-02-13 Thread GitBox

ocket commented on a change in pull request #4371: API 2.0 documentation
URL: https://github.com/apache/trafficcontrol/pull/4371#discussion_r379172049
 
 

 ##
 File path: docs/source/api/v2/cdns_name_snapshot_new.rst
 ##
 @@ -0,0 +1,545 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-cdns-name-snapshot-new:
+
+**
+``cdns/{{name}}/snapshot/new``
+**
+
+``GET``
+===
+Retrieves the *pending* :term:`Snapshot` for a CDN, which represents the 
current *configuration* of the CDN, **not** the current *operating state* of 
the CDN. The contents of this :term:`Snapshot` are currently used by Traffic 
Monitor and Traffic Router.
+
+:Auth. Required: Yes
+:Roles Required: "admin" or "operations"
+:Response Type:  Object
+
+Request Structure
+-
+.. table:: Request Path Parameters
+
+   
+--++
+   | Name | Description
|
+   
+==++
+   | name | The name of the CDN for which a :term:`Snapshot` shall be 
returned |
+   
+--++
+
+.. code-block:: http
+   :caption: Request Example
+
+   GET /api/2.0/cdns/CDN-in-a-Box/snapshot/new HTTP/1.1
+   Host: trafficops.infra.ciab.test
+   User-Agent: curl/7.47.0
+   Accept: */*
+   Cookie: mojolicious=...
+
+Response Structure
+--
+:config: An object containing basic configurations on the actual CDN object
+
+   :api.cache-control.max-age: A string containing an integer which 
specifies the value of ``max-age`` in the :mailheader:`Cache-Control` header of 
some HTTP responses, likely the :ref:`tr-api` responses
+   :certificates.polling.interval: A string containing an integer which 
specifies the interval, in seconds, on which other Traffic Control components 
should check for updated SSL certificates
+   :consistent.dns.routing:A string containing a boolean which 
indicates whether DNS routing will use a consistent hashing method or 
"round-robin"
+
+   "false"
+   The "round-robin" method will be used to define DNS 
routing
+   "true"
+   A consistent hashing method will be used to define DNS 
routing
+
+   :coveragezone.polling.interval:  A string containing an integer 
which specifies the interval, in seconds, on which Traffic Routers should check 
for a new Coverage Zone file
+   :coveragezone.polling.url:   The URL where a :term:`Coverage 
Zone File` may be requested by Traffic Routers
+   :dnssec.dynamic.response.expiration: A string containing a number and 
unit suffix that specifies the length of time for which dynamic responses to 
DNSSEC lookup queries should remain valid
+   :dnssec.dynamic.concurrencylevel:An integer that defines the size 
of the concurrency level (threads) of the Guava cache used by ZoneManager to 
store zone material
+   :dnssec.dynamic.initialcapacity: An integer that defines the 
initial size of the Guava cache, default is 1. Too low of a value can lead 
to expensive resizing
+   :dnssec.init.timeout:An integer that defines the number 
of minutes to allow for zone generation, this bounds the zone priming activity
+   :dnssec.enabled: A string that tells whether or not 
the CDN uses DNSSEC; one of:
+
+   "false"
+   DNSSEC is not used within this CDN
+   "true"
+   DNSSEC is used within this CDN
+
+   :domain_name:A string that is the :abbr:`TLD 
(Top-Level Domain)` served by the CDN
+   :federationmapping.polling.interval: A string containing an integer 
which specifies the interval, in seconds, on which other Traffic Control 
components should check for new federation mappings
+   :federationmapping.polling.url:  The URL where Traffic Control 
components can request federation mappings
+   :geolocation.polling.interval:   A string containing an integer 
which specifies the interval, in seconds, on which other Traffic Control 
components should check for new IP-to-geographic-location mapping databases
+

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-13 Thread GitBox

ocket commented on a change in pull request #3534: TP Delivery Service 
Generate SSL update, new letsencrypt generate and renew API endpoints
URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r379192083
 
 

 ##
 File path: docs/source/api/deliveryservices_hostname_name_sslkeys.rst
 ##
 @@ -70,9 +70,12 @@ Response Structure
 :hostname:The hostname generated by Traffic Ops that is used as the 
common name when generating the certificate - this will be an :abbr:`FQDN 
(Fully Qualified Domain Name)` for DNS :term:`Delivery Services` and a wildcard 
URL for HTTP :term:`Delivery Services`
 :organization:An optional field which, if present, contains the 
organization entered by the user when generating certificate\ [#optional]_
 :state:   An optional field which, if present, contains the state 
entered by the user when generating certificate\ [#optional]_
-:version: The version of the certificate record in Traffic Vault
+:version: An integer that defines the "version" of the key - which may 
be thought of as the sequential generation; that is, the higher the number the 
more recent the key
 
-.. code- block:: http
+:expiration:  The expiration date of the certificate for the 
:term:`Delivery Service` in :rfc:`3339` format
+   .. versionadded:: 1.5
 
 Review comment:
   Looks like you accidentally deleted the blank line above this directive.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox

rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, 
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379160057
 
 

 ##
 File path: traffic_monitor/health/cache.go
 ##
 @@ -171,45 +172,100 @@ func EvalCache(result cache.ResultInfo, resultStats 
*threadsafe.ResultStatValHis
}
 
if !inThreshold(threshold, resultStatNum) {
-   return false, eventDesc(status, 
exceedsThresholdMsg(stat, threshold, resultStatNum)), stat
+   return false, result.UsingIPv4, eventDesc(status, 
exceedsThresholdMsg(stat, threshold, resultStatNum)), stat
}
}
 
-   return avail, eventDescVal, eventMsg
+   return avail, result.UsingIPv4, eventDescVal, eventMsg
 }
 
 // CalcAvailabilityWithStats calculates the availability of each cache in 
results.
 // statResultHistory may be nil, in which case stats won't be used to 
calculate availability.
-func CalcAvailability(results []cache.Result, pollerName string, 
statResultHistory *threadsafe.ResultStatHistory, mc tc.TrafficMonitorConfigMap, 
toData todata.TOData, localCacheStatusThreadsafe 
threadsafe.CacheAvailableStatus, localStates peer.CRStatesThreadsafe, events 
ThreadsafeEvents) {
+func CalcAvailability(results []cache.Result, pollerName string, 
statResultHistory *threadsafe.ResultStatHistory, mc tc.TrafficMonitorConfigMap, 
toData todata.TOData, localCacheStatusThreadsafe 
threadsafe.CacheAvailableStatus, localStates peer.CRStatesThreadsafe, events 
ThreadsafeEvents, protocol config.PollingProtocol) {
localCacheStatuses := localCacheStatusThreadsafe.Get().Copy()
statResults := (*threadsafe.ResultStatValHistory)(nil)
+   processAvailableTuple := func(tuple cache.AvailableTuple, serverInfo 
tc.TrafficServer) bool {
+   switch protocol {
+   case config.IPv4Only:
+   return tuple.IPv4
+   case config.IPv6Only:
+   return tuple.IPv6
+   case config.Both:
+   // only report availability based on defined IP 
addresses
+   if serverInfo.IP == "" {
+   return tuple.IPv6
+   } else if serverInfo.IP6 == "" {
+   return tuple.IPv4
+   }
+   // if both IP addresses are defined then report 
availability based on both
+   return tuple.IPv4 || tuple.IPv6
 
 Review comment:
   This returns that the cache is healthy if _either_ IPv4 _or_ IPv6 polling 
reported available? Is that intentional?
   If so, I think we should document that. I didn't see anything in the docs 
indicating that "both" is really "either."
   
   It'd be nice if it were a config option, for "both" and "either." But I 
don't want to ask you to do more work, this works as-is, as long as we document 
the behavior. We can always add "either" later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4401: TP: upgrades load-grunt-config to 3.0.1 and removes grun-usemin

2020-02-13 Thread GitBox

mitchell852 opened a new pull request #4401: TP: upgrades load-grunt-config to 
3.0.1 and removes grun-usemin
URL: https://github.com/apache/trafficcontrol/pull/4401
 
 
   ## What does this PR (Pull Request) do?
   
   - [x] This PR is not related to any Issue
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   
   
   ## The following criteria are ALL met by this PR
   
   
   - [ ] This PR includes tests OR I have explained why tests are unnecessary
   - [ ] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [ ] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [ ] This PR includes any and all required license headers
   - [ ] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4401: TP: upgrades application build dependencies

2020-02-13 Thread GitBox

ocket commented on issue #4401: TP: upgrades application build dependencies
URL: https://github.com/apache/trafficcontrol/pull/4401#issuecomment-586011557
 
 
   Why upgrade that one, specifically? Most of our dependencies are pretty 
out-of-date


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox

rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, 
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379043530
 
 

 ##
 File path: traffic_monitor/manager/manager.go
 ##
 @@ -45,6 +46,8 @@ import (
 func Start(opsConfigFile string, cfg config.Config, appData 
config.StaticAppData, trafficMonitorConfigFileName string) error {
toSession := 
towrap.ITrafficOpsSession(towrap.NewTrafficOpsSessionThreadsafe(nil, 
cfg.CRConfigHistoryCount, cfg))
 
+   url6Regex := regexp.MustCompile(`/\d+`)
 
 Review comment:
   It isn't. But that's not a bad idea, might be worth looking into. I don't 
know how the cost of parsing the IP compares to the request cost; but we do 
enough requests, and use enough CPU, it might be significant.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

2020-02-13 Thread GitBox

mhoppa commented on a change in pull request #4356: Update generic API Create 
to allow arrays in POST if set on object
URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r379063930
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/api/shared_handlers.go
 ##
 @@ -395,34 +397,125 @@ func CreateHandler(creator Creator) http.HandlerFunc {
obj := reflect.New(objectType).Interface().(Creator)
obj.SetInfo(inf)
 
-   err := decodeAndValidateRequestBody(r, obj)
-   if err != nil {
-   HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest, err, 
nil)
-   return
-   }
+   if c, ok := obj.(MultipleCreator); ok && 
c.AllowMultipleCreates() {
+   data, err := ioutil.ReadAll(r.Body)
+   if err != nil {
+   HandleErr(w, r, inf.Tx.Tx, 
http.StatusBadRequest, err, nil)
+   return
+   }
 
-   if t, ok := obj.(Tenantable); ok {
-   authorized, err := t.IsTenantAuthorized(inf.User)
+   objSlice, err := parseMultipleCreates(data, objectType, 
inf)
if err != nil {
-   HandleErr(w, r, inf.Tx.Tx, 
http.StatusInternalServerError, nil, errors.New("checking tenant authorized: 
"+err.Error()))
+   HandleErr(w, r, inf.Tx.Tx, 
http.StatusInternalServerError, nil, err)
return
}
-   if !authorized {
-   HandleErr(w, r, inf.Tx.Tx, 
http.StatusForbidden, errors.New("not authorized on this tenant"), nil)
+
+   for _, objElemInt := range objSlice {
 
 Review comment:
   this looks great! but I wonder if there is a different approach so we dont 
have to loop through and do n db calls but just one to do a bulk insert. Not 
blocking but more of a comment to think about.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

50 matches

Mail list logo