[GitHub] [trafficcontrol] rimashah25 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

rimashah25 commented on PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397342010 > Can you help me understand what this does @ocket ? > > exposeInactive = true will display 3 options? active, primed, AND inactive exposeInactive = false will

[GitHub] [trafficcontrol] serDrem opened a new pull request, #7302: added anycast traffic routing ability, and lastpoll time for v6

serDrem opened a new pull request, #7302: URL: https://github.com/apache/trafficcontrol/pull/7302 These changes enable TM to poll caches that have the same ip address and are in ecmp on the same router, and direct traffic to them appropriately. ## Which Traffic Control components are

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7302: added anycast traffic routing ability, and lastpoll time for v6

github-code-scanning[bot] commented on code in PR #7302: URL: https://github.com/apache/trafficcontrol/pull/7302#discussion_r1081774801 ## traffic_monitor/cache/astats.go: ## @@ -116,8 +117,23 @@ astats.Ats["system.proc.loadavg"] = astats.System.ProcLoadavg

[GitHub] [trafficcontrol] rawlinp merged pull request #7300: Rebuild RPM DB after installing NodeSource repo on RHEL 7

rawlinp merged PR #7300: URL: https://github.com/apache/trafficcontrol/pull/7300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rawlinp closed issue #7297: TP integration tests fail in CiaB: `Fatal error, run database recovery`

rawlinp closed issue #7297: TP integration tests fail in CiaB: `Fatal error, run database recovery` URL: https://github.com/apache/trafficcontrol/issues/7297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [trafficcontrol] ericholguin commented on pull request #7298: Separate Go Unit GHA into individual workflows

ericholguin commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397520223 > Since we're running all Go unit tests on every Go-modifying PR, splitting the Go unit tests by component means occupying 6 runners for each such PR instead of 1, which is a

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7302: added anycast traffic routing ability, and lastpoll time for v6

codecov[bot] commented on PR #7302: URL: https://github.com/apache/trafficcontrol/pull/7302#issuecomment-1397520331 #

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7294: Fix Internal Server Error when GETting sslkey_expirations endpoint

ocket commented on PR #7294: URL: https://github.com/apache/trafficcontrol/pull/7294#issuecomment-1397698240 Other than the Changelog, this looks good to go. Tested it and it's working. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [trafficcontrol] zrhoffman merged pull request #7296: Traffic Portal configuration option for Delivery Service active flags

zrhoffman merged PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] mitchell852 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

mitchell852 commented on PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397448779 @ocket - arent there a bunch of DS tables as well that will still say "primed"? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7292: TPv2 Cache Groups table/details pages

shamrickus commented on code in PR #7292: URL: https://github.com/apache/trafficcontrol/pull/7292#discussion_r1081549988 ## experimental/traffic-portal/src/app/core/cache-groups/cache-group-table/cache-group-table.component.ts: ## @@ -162,13 +222,78 @@ export class

[GitHub] [trafficcontrol] mitchell852 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

mitchell852 commented on PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397194147 Can you help me understand what this does @ocket ? exposeInactive = true will display 3 options? active, primed, AND inactive exposeInactive = false will display 2

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

ocket commented on PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397356383 The old notion of "inactive" is what is known as "primed" in APIv5. True "INACTIVE" is not available prior to that version, so when `exposeInactive` is `true`, it'll show all

[GitHub] [trafficcontrol] ragen14 opened a new pull request, #7299: updating snapshot url and logic

ragen14 opened a new pull request, #7299: URL: https://github.com/apache/trafficcontrol/pull/7299 ## Which Traffic Control components are affected by this PR? - Automation -- Ansible Roles ## What is the best way to verify this PR? Run ansible plays

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7294: Fix Internal Server Error when GETting sslkeys_expirations endpoint

ocket commented on code in PR #7294: URL: https://github.com/apache/trafficcontrol/pull/7294#discussion_r1081589154 ## CHANGELOG.md: ## @@ -36,6 +36,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] ocket8888 opened a new issue, #7301: CiaB RPMs can only be `make`-d once without manual intervention

ocket opened a new issue, #7301: URL: https://github.com/apache/trafficcontrol/issues/7301 ## This Bug Report affects these Traffic Control components: - CDN in a Box ## Current behavior: When running `make` in the CDN-in-a-Box directory, `make` will attempt to use the

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7300: Rebuild RPM DB after installing NodeSource repo on RHEL 7

zrhoffman opened a new pull request, #7300: URL: https://github.com/apache/trafficcontrol/pull/7300 This PR fixes #7297 by running `rpm --rebuilddb` if installing `nodejs` fails without that. ## Which Traffic Control components are affected by this PR? - CDN in a

[GitHub] [trafficcontrol] ericholguin commented on pull request #7298: Separate Go Unit GHA into individual workflows

ericholguin commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397379289 > What is the goal of splitting the Go unit tests into components? Since we'd like to run all the unit tests regardless of files modified, the only goal would be to have

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7298: Separate Go Unit GHA into individual workflows

zrhoffman commented on code in PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1081956473 ## .github/workflows/cache-config.unit.tests.yml: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7298: Separate Go Unit GHA into individual workflows

zrhoffman commented on code in PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1081967259 ## .github/workflows/cache-config.unit.tests.yml: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [trafficcontrol] ocket8888 merged pull request #7298: Separate Go Unit GHA into individual workflows

ocket merged PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7298: Separate Go Unit GHA into individual workflows

zrhoffman commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397722042 > > Since we're running all Go unit tests on every Go-modifying PR, splitting the Go unit tests by component means occupying 6 runners for each such PR instead of 1, which is a

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7298: Separate Go Unit GHA into individual workflows

zrhoffman commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397743743 > One thing Zach didn't mention: according to what I'm seeing here, the lib tests only run if code in the lib changes. But that library is linked to from, I think, every other

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7298: Separate Go Unit GHA into individual workflows

ericholguin commented on code in PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1081966622 ## .github/workflows/cache-config.unit.tests.yml: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7303: Add Physical Location Page to TPv2

shamrickus opened a new pull request, #7303: URL: https://github.com/apache/trafficcontrol/pull/7303 This PR implements the Physical Locations table/detail views. It also adds a sidebar and the header service has been converted to a navigation service responsible for both the

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7298: Separate Go Unit GHA into individual workflows

zrhoffman commented on code in PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1081956473 ## .github/workflows/cache-config.unit.tests.yml: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [trafficcontrol] ocket8888 merged pull request #7294: Fix Internal Server Error when GETting sslkey_expirations endpoint

ocket merged PR #7294: URL: https://github.com/apache/trafficcontrol/pull/7294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 closed issue #7293: Internal Server Error: GET /api/4.1/sslkey_expirations

ocket closed issue #7293: Internal Server Error: GET /api/4.1/sslkey_expirations URL: https://github.com/apache/trafficcontrol/issues/7293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the