[GitHub] [trafficcontrol] gbkannan89 commented on a diff in pull request #7733: To origin rfc3339

2023-08-28 Thread via GitHub
gbkannan89 commented on code in PR #7733: URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1307318177 ## traffic_ops/traffic_ops_golang/origin/origins.go: ## @@ -487,3 +488,277 @@ func deleteQuery() string { WHERE id=:id` return query } + +// Get is

[GitHub] [trafficcontrol] gbkannan89 commented on a diff in pull request #7733: To origin rfc3339

2023-08-28 Thread via GitHub
gbkannan89 commented on code in PR #7733: URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1307318177 ## traffic_ops/traffic_ops_golang/origin/origins.go: ## @@ -487,3 +488,277 @@ func deleteQuery() string { WHERE id=:id` return query } + +// Get is

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7744: Use RFC 3339 for lastUpdated timestamp in /server_server_capabilities

2023-08-25 Thread via GitHub
codecov[bot] commented on PR #7744: URL: https://github.com/apache/trafficcontrol/pull/7744#issuecomment-1693586566 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7744?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] jagan-parthiban opened a new pull request, #7745: RFC3339 Fix for ProfileParameter

2023-08-25 Thread via GitHub
jagan-parthiban opened a new pull request, #7745: URL: https://github.com/apache/trafficcontrol/pull/7745 Related: #5911 - Documentation - Traffic Ops ## What is the best way to verify this PR? Make Api calls to Parameter 5.0 ProfileParameters to

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7708: Fixes Parameters V5 apis to respond with RFC3339 date/time Format

2023-08-25 Thread via GitHub
jagan-parthiban commented on code in PR #7708: URL: https://github.com/apache/trafficcontrol/pull/7708#discussion_r1305895796 ## traffic_ops/traffic_ops_golang/parameter/parameters.go: ## @@ -364,23 +363,28 @@ func CreateParameter(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7708: Fixes Parameters V5 apis to respond with RFC3339 date/time Format

2023-08-25 Thread via GitHub
zrhoffman commented on code in PR #7708: URL: https://github.com/apache/trafficcontrol/pull/7708#discussion_r1305899493 ## traffic_ops/traffic_ops_golang/parameter/parameters.go: ## @@ -361,32 +361,16 @@ func CreateParameter(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7745: RFC3339 Fix for ProfileParameter

2023-08-25 Thread via GitHub
codecov[bot] commented on PR #7745: URL: https://github.com/apache/trafficcontrol/pull/7745#issuecomment-1693692565 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7745?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7744: Use RFC 3339 for lastUpdated timestamp in /server_server_capabilities

2023-08-25 Thread via GitHub
zrhoffman opened a new pull request, #7744: URL: https://github.com/apache/trafficcontrol/pull/7744 This PR resolves #7743 by using the timestamp format specified in RFC 3339 for the `lastUpdated` field of the `/api/5.0/server_server_capabilities` endpoint. ## Which

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7708: Fixes Parameters V5 apis to respond with RFC3339 date/time Format

2023-08-25 Thread via GitHub
jagan-parthiban commented on code in PR #7708: URL: https://github.com/apache/trafficcontrol/pull/7708#discussion_r1305902380 ## traffic_ops/traffic_ops_golang/parameter/parameters.go: ## @@ -361,32 +361,16 @@ func CreateParameter(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7708: Fixes Parameters V5 apis to respond with RFC3339 date/time Format

2023-08-24 Thread via GitHub
zrhoffman commented on code in PR #7708: URL: https://github.com/apache/trafficcontrol/pull/7708#discussion_r1304943384 ## traffic_ops/traffic_ops_golang/parameter/parameters.go: ## @@ -259,3 +264,351 @@ func deleteQuery() string { WHERE id=:id` return query } + +func

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7734: Fixed Profiles(APIv5) REST calls to respond with RFC3339 timestamp

2023-08-24 Thread via GitHub
ocket commented on code in PR #7734: URL: https://github.com/apache/trafficcontrol/pull/7734#discussion_r1304856157 ## traffic_ops/traffic_ops_golang/profile/profiles.go: ## @@ -226,10 +228,10 @@ LEFT JOIN cdn c ON prof.cdn = c.id` return query } -func

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7734: Fixed Profiles(APIv5) REST calls to respond with RFC3339 timestamp

2023-08-24 Thread via GitHub
ocket commented on code in PR #7734: URL: https://github.com/apache/trafficcontrol/pull/7734#discussion_r1305005669 ## traffic_ops/traffic_ops_golang/profile/profiles.go: ## @@ -360,3 +363,290 @@ type) VALUES ( func deleteQuery() string { return `DELETE FROM

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7708: Fixes Parameters V5 apis to respond with RFC3339 date/time Format

2023-08-24 Thread via GitHub
zrhoffman commented on code in PR #7708: URL: https://github.com/apache/trafficcontrol/pull/7708#discussion_r1305017425 ## traffic_ops/traffic_ops_golang/parameter/parameters.go: ## @@ -259,3 +264,351 @@ func deleteQuery() string { WHERE id=:id` return query } + +func

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7708: Fixes Parameters V5 apis to respond with RFC3339 date/time Format

2023-08-24 Thread via GitHub
jagan-parthiban commented on code in PR #7708: URL: https://github.com/apache/trafficcontrol/pull/7708#discussion_r1305081449 ## traffic_ops/traffic_ops_golang/parameter/parameters.go: ## @@ -259,3 +264,351 @@ func deleteQuery() string { WHERE id=:id` return query } +

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7718: Servers RFC3339 timestamps

2023-08-25 Thread via GitHub
zrhoffman commented on code in PR #7718: URL: https://github.com/apache/trafficcontrol/pull/7718#discussion_r1305979282 ## traffic_ops/traffic_ops_golang/api/api.go: ## @@ -893,12 +893,21 @@ func (v *Version) String() string { return strconv.FormatUint(v.Major, 10) +

[GitHub] [trafficcontrol] AbdelrahmanElawady opened a new pull request, #7746: Add TM integration and separate docker-compose services for Varnish

2023-08-25 Thread via GitHub
AbdelrahmanElawady opened a new pull request, #7746: URL: https://github.com/apache/trafficcontrol/pull/7746 Add Traffic Monitor integration with a daemon running on Varnish cache servers to report whether Varnish is running or not and to report load average and interface stats. Also,

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7733: To origin rfc3339

2023-08-25 Thread via GitHub
ocket commented on code in PR #7733: URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1306064852 ## traffic_ops/traffic_ops_golang/origin/origins.go: ## @@ -487,3 +488,277 @@ func deleteQuery() string { WHERE id=:id` return query } + +// Get is

[GitHub] [trafficcontrol] zrhoffman closed issue #7714: Add access control to Varnish cache server

2023-08-25 Thread via GitHub
zrhoffman closed issue #7714: Add access control to Varnish cache server URL: https://github.com/apache/trafficcontrol/issues/7714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7734: Fixed Profiles(APIv5) REST calls to respond with RFC3339 timestamp

2023-08-25 Thread via GitHub
ocket commented on code in PR #7734: URL: https://github.com/apache/trafficcontrol/pull/7734#discussion_r1306086502 ## lib/go-tc/profiles.go: ## @@ -91,6 +92,28 @@ type Profile struct { Parameters []ParameterNullable `json:"params,omitempty"` } +//

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7748: Using go-rfc for location header

2023-08-25 Thread via GitHub
rimashah25 opened a new pull request, #7748: URL: https://github.com/apache/trafficcontrol/pull/7748 Using `go-rfc` package for location header instead of a string value. ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7718: Servers RFC3339 timestamps

2023-08-25 Thread via GitHub
ocket commented on code in PR #7718: URL: https://github.com/apache/trafficcontrol/pull/7718#discussion_r1306052909 ## traffic_ops/traffic_ops_golang/server/servers.go: ## @@ -1421,230 +1365,200 @@ func Update(w http.ResponseWriter, r *http.Request) { }

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7725: Add HTTPS support to Varnish cache using Hitch

2023-08-25 Thread via GitHub
codecov[bot] commented on PR #7725: URL: https://github.com/apache/trafficcontrol/pull/7725#issuecomment-1693831927 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7725?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7734: Fixed Profiles(APIv5) REST calls to respond with RFC3339 timestamp

2023-08-25 Thread via GitHub
ocket commented on code in PR #7734: URL: https://github.com/apache/trafficcontrol/pull/7734#discussion_r1306073401 ## lib/go-tc/profiles.go: ## @@ -91,6 +92,28 @@ type Profile struct { Parameters []ParameterNullable `json:"params,omitempty"` } +//

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7734: Fixed Profiles(APIv5) REST calls to respond with RFC3339 timestamp

2023-08-25 Thread via GitHub
ocket commented on code in PR #7734: URL: https://github.com/apache/trafficcontrol/pull/7734#discussion_r1306073401 ## lib/go-tc/profiles.go: ## @@ -91,6 +92,28 @@ type Profile struct { Parameters []ParameterNullable `json:"params,omitempty"` } +//

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7734: Fixed Profiles(APIv5) REST calls to respond with RFC3339 timestamp

2023-08-25 Thread via GitHub
rimashah25 commented on code in PR #7734: URL: https://github.com/apache/trafficcontrol/pull/7734#discussion_r1303627964 ## lib/go-tc/profiles.go: ## @@ -91,6 +92,28 @@ type Profile struct { Parameters []ParameterNullable `json:"params,omitempty"` } +//

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7718: Servers RFC3339 timestamps

2023-08-25 Thread via GitHub
ocket commented on PR #7718: URL: https://github.com/apache/trafficcontrol/pull/7718#issuecomment-1693804008 > > > You resolved [this conversation](https://github.com/apache/trafficcontrol/pull/7718#discussion_r1302074955) but went ahead and did it anyway? Please revert the Version

[GitHub] [trafficcontrol] AbdelrahmanElawady commented on pull request #7746: Add TM integration and separate docker-compose services for Varnish

2023-08-25 Thread via GitHub
AbdelrahmanElawady commented on PR #7746: URL: https://github.com/apache/trafficcontrol/pull/7746#issuecomment-1693811031 marked draft until #7727 is reviewed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7747: Update changelog

2023-08-25 Thread via GitHub
rimashah25 opened a new pull request, #7747: URL: https://github.com/apache/trafficcontrol/pull/7747 In preparation of ATC 8.0 release, updating the changelog. ## Which Traffic Control components are affected by this PR? - CHANGELOG ## What is the best way to

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7748: Using go-rfc for location header

2023-08-25 Thread via GitHub
codecov[bot] commented on PR #7748: URL: https://github.com/apache/trafficcontrol/pull/7748#issuecomment-1693922918 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7748?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] kdamichie opened a new pull request, #7749: Tenants rfc3339 apiv5

2023-08-25 Thread via GitHub
kdamichie opened a new pull request, #7749: URL: https://github.com/apache/trafficcontrol/pull/7749 This PR changes the returned timestamp to be RFC3339 format for tenants in APIv5. ## Which Traffic Control components are affected by this PR? - Documentation -

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7708: Fixes Parameters V5 apis to respond with RFC3339 date/time Format

2023-08-25 Thread via GitHub
zrhoffman commented on code in PR #7708: URL: https://github.com/apache/trafficcontrol/pull/7708#discussion_r1305565834 ## traffic_ops/traffic_ops_golang/parameter/parameters.go: ## @@ -364,23 +363,28 @@ func CreateParameter(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] ocket8888 merged pull request #7748: Using go-rfc for location header

2023-08-26 Thread via GitHub
ocket merged PR #7748: URL: https://github.com/apache/trafficcontrol/pull/7748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7718: Servers RFC3339 timestamps

2023-08-15 Thread via GitHub
ocket opened a new pull request, #7718: URL: https://github.com/apache/trafficcontrol/pull/7718 Related: #5911 This PR changes the `lastUpdated` field of server objects to use RFC3339 formatting to be consistent with all of the other timestamps used by that endpoint. It also

[GitHub] [trafficcontrol] ocket8888 commented on issue #7617: Docs for /toplogies incorrectly specify a maximum number of parents

2023-08-15 Thread via GitHub
ocket commented on issue #7617: URL: https://github.com/apache/trafficcontrol/issues/7617#issuecomment-1679237604 Nope. That just looks wrong to me, should say there's no upper limit on parentage relationships. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7718: Servers RFC3339 timestamps

2023-08-15 Thread via GitHub
codecov[bot] commented on PR #7718: URL: https://github.com/apache/trafficcontrol/pull/7718#issuecomment-1679239183 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7718?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] mohitsatr commented on issue #7617: Docs for /toplogies incorrectly specify a maximum number of parents

2023-08-15 Thread via GitHub
mohitsatr commented on issue #7617: URL: https://github.com/apache/trafficcontrol/issues/7617#issuecomment-1678872787 Hi @zrhoffman @ocket , I want to take this one. I have a doubt ? is every any limit on maximum number of child nodes a single Topology node can have ? In docs

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7719: t3c to add self-healing automatically when using slice plugin

2023-08-15 Thread via GitHub
codecov[bot] commented on PR #7719: URL: https://github.com/apache/trafficcontrol/pull/7719#issuecomment-1679591159 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7719?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] jpappa200 opened a new pull request, #7719: t3c to add self-healing automatically when using slice plugin

2023-08-15 Thread via GitHub
jpappa200 opened a new pull request, #7719: URL: https://github.com/apache/trafficcontrol/pull/7719 When using the slice plugin you have to add the `--consider-ims` parameter to the remap line in remap.config. This change will make it automatically add the parameter without using a

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7720: Api v5 should return RFC3339 timestamps for Delivery Service Servers

2023-08-15 Thread via GitHub
codecov[bot] commented on PR #7720: URL: https://github.com/apache/trafficcontrol/pull/7720#issuecomment-1679617521 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7720?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] srijeet0406 opened a new pull request, #7720: Api v5 should return RFC3339 timestamps for Delivery Service Servers

2023-08-15 Thread via GitHub
srijeet0406 opened a new pull request, #7720: URL: https://github.com/apache/trafficcontrol/pull/7720 This PR is not related to any issue. It changes the timestamps returned in api v5 for deliveryserviceservers to be in RFC3339 format. ## Which Traffic Control components

[GitHub] [trafficcontrol] zrhoffman merged pull request #7716: Use GCC 11 to build Apache Traffic Server

2023-08-15 Thread via GitHub
zrhoffman merged PR #7716: URL: https://github.com/apache/trafficcontrol/pull/7716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman closed issue #7713: Apache Traffic Server not building

2023-08-15 Thread via GitHub
zrhoffman closed issue #7713: Apache Traffic Server not building URL: https://github.com/apache/trafficcontrol/issues/7713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7749: Tenants rfc3339 apiv5

2023-08-28 Thread via GitHub
zrhoffman commented on code in PR #7749: URL: https://github.com/apache/trafficcontrol/pull/7749#discussion_r1307812780 ## CHANGELOG.md: ## @@ -159,9 +159,15 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7744: Use RFC 3339 for lastUpdated timestamp in /server_server_capabilities

2023-08-28 Thread via GitHub
zrhoffman commented on code in PR #7744: URL: https://github.com/apache/trafficcontrol/pull/7744#discussion_r1307822455 ## traffic_ops/v5-client/server_server_capabilities.go: ## @@ -31,14 +31,14 @@ const apiServerServerCapabilities = "/server_server_capabilities" //

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7750: TO: Add fields to servers v5 endpoints to indicate update failures

2023-08-28 Thread via GitHub
shamrickus commented on code in PR #7750: URL: https://github.com/apache/trafficcontrol/pull/7750#discussion_r1307913878 ## lib/go-tc/servers.go: ## @@ -1356,7 +1358,9 @@ type ServerV50 struct { // The time at which revalidations for this server were last updated by

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7754: Add ReadTheDocs configuration file

2023-08-28 Thread via GitHub
ocket commented on PR #7754: URL: https://github.com/apache/trafficcontrol/pull/7754#issuecomment-1696506275 At least it's now trying to build it, that's progress -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [trafficcontrol] zrhoffman closed issue #7752: production/backends.conf invalid JSON

2023-08-28 Thread via GitHub
zrhoffman closed issue #7752: production/backends.conf invalid JSON URL: https://github.com/apache/trafficcontrol/issues/7752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [trafficcontrol] zrhoffman merged pull request #7754: Add ReadTheDocs configuration file

2023-08-28 Thread via GitHub
zrhoffman merged PR #7754: URL: https://github.com/apache/trafficcontrol/pull/7754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7749: Tenants rfc3339 apiv5

2023-08-28 Thread via GitHub
kdamichie commented on code in PR #7749: URL: https://github.com/apache/trafficcontrol/pull/7749#discussion_r1307820286 ## CHANGELOG.md: ## @@ -159,9 +159,15 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7744: Use RFC 3339 for lastUpdated timestamp in /server_server_capabilities

2023-08-28 Thread via GitHub
kdamichie commented on code in PR #7744: URL: https://github.com/apache/trafficcontrol/pull/7744#discussion_r1307829096 ## traffic_ops/v5-client/server_server_capabilities.go: ## @@ -52,8 +52,8 @@ func (to *Session) DeleteServerServerCapability(serverID int, serverCapability s

[GitHub] [trafficcontrol] zrhoffman merged pull request #7753: Fix back-end configuration contains invalid JSON

2023-08-28 Thread via GitHub
zrhoffman merged PR #7753: URL: https://github.com/apache/trafficcontrol/pull/7753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7754: Add ReadTheDocs configuration file

2023-08-28 Thread via GitHub
zrhoffman commented on PR #7754: URL: https://github.com/apache/trafficcontrol/pull/7754#issuecomment-1696352101 It fails still ```python python -m sphinx -T -E -b html -d _build/doctrees -D language=en . $READTHEDOCS_OUTPUT/html Traceback (most recent call last): File

[GitHub] [trafficcontrol] zrhoffman merged pull request #7744: Use RFC 3339 for lastUpdated timestamp in /server_server_capabilities

2023-08-28 Thread via GitHub
zrhoffman merged PR #7744: URL: https://github.com/apache/trafficcontrol/pull/7744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] jagan-parthiban opened a new pull request, #7755: Fixes QA issue of redirect after creating a parameter with RFC3339

2023-08-29 Thread via GitHub
jagan-parthiban opened a new pull request, #7755: URL: https://github.com/apache/trafficcontrol/pull/7755 ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is the best way to verify this PR? - Creating a parameter from

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7755: Fixes QA issue of redirect after creating a parameter with RFC3339

2023-08-29 Thread via GitHub
codecov[bot] commented on PR #7755: URL: https://github.com/apache/trafficcontrol/pull/7755#issuecomment-1697197578 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7755?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7733: To origin rfc3339

2023-08-29 Thread via GitHub
ocket commented on code in PR #7733: URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1308130343 ## traffic_ops/testing/api/v5/origins_test.go: ## @@ -162,113 +162,113 @@ func TestOrigins(t *testing.T) { "POST": {

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7756: Update only if ASN id is unique

2023-08-29 Thread via GitHub
rimashah25 opened a new pull request, #7756: URL: https://github.com/apache/trafficcontrol/pull/7756 PR not related to any issue but ensuring a client is not allowed to update ASN if the asn id already exists. ## Which Traffic Control components are affected by this PR?

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7756: Update only if ASN id is unique

2023-08-29 Thread via GitHub
codecov[bot] commented on PR #7756: URL: https://github.com/apache/trafficcontrol/pull/7756#issuecomment-1697706720 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7756?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] gbkannan89 commented on a diff in pull request #7720: Api v5 should return RFC3339 timestamps for Delivery Service Servers

2023-08-21 Thread via GitHub
gbkannan89 commented on code in PR #7720: URL: https://github.com/apache/trafficcontrol/pull/7720#discussion_r1300518023 ## traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go: ## @@ -170,7 +170,30 @@ func ReadDSSHandler(w http.ResponseWriter, r *http.Request) {

Re: [I] t3c: Can't detect SystemD in Rocky Linux 9 [trafficcontrol]

2023-11-08 Thread via GitHub
smalenfant commented on issue #7858: URL: https://github.com/apache/trafficcontrol/issues/7858#issuecomment-1802368948 I believe I found the problem. RHEL9 doesn't come with `/sbin/chkconfig`. But the code is not handling this right. Will always be Unknown.

Re: [PR] Removing check for chkconfig [trafficcontrol]

2023-11-08 Thread via GitHub
codecov[bot] commented on PR #7861: URL: https://github.com/apache/trafficcontrol/pull/7861#issuecomment-1802419125 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7861?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[PR] Removing check for chkconfig [trafficcontrol]

2023-11-08 Thread via GitHub
smalenfant opened a new pull request, #7861: URL: https://github.com/apache/trafficcontrol/pull/7861 Closes: #7858 ## Which Traffic Control components are affected by this PR? - Traffic Control Cache Config (`t3c`, formerly ORT) ## What is the best way to verify this PR?

Re: [I] problem with files download with macos [trafficcontrol]

2023-11-09 Thread via GitHub
ocket commented on issue #7856: URL: https://github.com/apache/trafficcontrol/issues/7856#issuecomment-1804986506 Traffic Portal does not support "eagle download manager" as a browser - officially we support the latest Chrome and Firefox only. Is this some kind of Microsoft Edge

Re: [PR] Update Topology Cache Group Servers table to use AG-Grid [trafficcontrol]

2023-11-09 Thread via GitHub
codecov[bot] commented on PR #7849: URL: https://github.com/apache/trafficcontrol/pull/7849#issuecomment-1804988083 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7849?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

Re: [PR] Add comment field to parameters [trafficcontrol]

2023-11-09 Thread via GitHub
ocket commented on PR #7845: URL: https://github.com/apache/trafficcontrol/pull/7845#issuecomment-1804987296 Any Parameter that is required for a Profile of some given type ought not to be optionally provided by the data model; instead it should be a required property of a Profile.

Re: [I] t3c makes too many environment-level assumptions w/o any ability to override [trafficcontrol]

2023-11-09 Thread via GitHub
ocket commented on issue #7857: URL: https://github.com/apache/trafficcontrol/issues/7857#issuecomment-1804984537 Related: #6205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Improve code quality with Prettier [trafficcontrol]

2023-11-09 Thread via GitHub
ocket commented on PR #7862: URL: https://github.com/apache/trafficcontrol/pull/7862#issuecomment-1804981656 Traffic Portal is a legacy product by now, and it would be very unlikely that anyone would put in the effort to fix these all of these things, let alone get a reviewer for those

Re: [PR] increase state character limit to 4 [trafficcontrol]

2023-11-09 Thread via GitHub
ocket commented on code in PR #7846: URL: https://github.com/apache/trafficcontrol/pull/7846#discussion_r1388802581 ## traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js: ## @@ -42,7 +42,7 @@ var FormPhysLocationController =

Re: [PR] Improve code quality with Prettier [trafficcontrol]

2023-11-09 Thread via GitHub
ntheanh201 commented on PR #7862: URL: https://github.com/apache/trafficcontrol/pull/7862#issuecomment-1805100080 > Traffic Portal is a legacy product by now, and it would be very unlikely that anyone would put in the effort to fix these all of these things, let alone get a reviewer for

[PR] Bump axios from 0.21.2 to 1.6.0 in /traffic_portal/test/integration [trafficcontrol]

2023-11-10 Thread via GitHub
dependabot[bot] opened a new pull request, #7865: URL: https://github.com/apache/trafficcontrol/pull/7865 Bumps [axios](https://github.com/axios/axios) from 0.21.2 to 1.6.0. Release notes Sourced from https://github.com/axios/axios/releases;>axios's releases. Release v1.6.0

Re: [PR] Removing check for chkconfig [trafficcontrol]

2023-11-10 Thread via GitHub
jpappa200 commented on code in PR #7861: URL: https://github.com/apache/trafficcontrol/pull/7861#discussion_r1389939726 ## cache-config/t3c-apply/config/config.go: ## @@ -681,8 +681,7 @@ func getOSSvcManagement() SvcManagement { _svcManager = SystemD }

Re: [PR] Removing check for chkconfig [trafficcontrol]

2023-11-10 Thread via GitHub
jpappa200 commented on code in PR #7861: URL: https://github.com/apache/trafficcontrol/pull/7861#discussion_r1389939726 ## cache-config/t3c-apply/config/config.go: ## @@ -681,8 +681,7 @@ func getOSSvcManagement() SvcManagement { _svcManager = SystemD }

[PR] t3c RPM DB check to work with rocky linux 9 [trafficcontrol]

2023-11-10 Thread via GitHub
jpappa200 opened a new pull request, #7866: URL: https://github.com/apache/trafficcontrol/pull/7866 Closes: #7860 Rocky Linux 9 has changed the database format for the RPM database. This causes the RPM DB check to fail and t3c will not run in badass mode. t3c has been updated

Re: [PR] Removing check for chkconfig [trafficcontrol]

2023-11-10 Thread via GitHub
jpappa200 commented on code in PR #7861: URL: https://github.com/apache/trafficcontrol/pull/7861#discussion_r1389943810 ## cache-config/t3c-apply/config/config.go: ## @@ -681,8 +681,7 @@ func getOSSvcManagement() SvcManagement { _svcManager = SystemD }

[PR] Bump chromedriver from 117.0.3 to 119.0.1 in /traffic_portal/test/integration [trafficcontrol]

2023-11-09 Thread via GitHub
dependabot[bot] opened a new pull request, #7864: URL: https://github.com/apache/trafficcontrol/pull/7864 Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 117.0.3 to 119.0.1. Commits

Re: [PR] Bump chromedriver from 117.0.3 to 119.0.1 in /experimental/traffic-portal [trafficcontrol]

2023-11-09 Thread via GitHub
codecov[bot] commented on PR #7863: URL: https://github.com/apache/trafficcontrol/pull/7863#issuecomment-1804776700 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7863?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[PR] Bump chromedriver from 117.0.3 to 119.0.1 in /experimental/traffic-portal [trafficcontrol]

2023-11-09 Thread via GitHub
dependabot[bot] opened a new pull request, #7863: URL: https://github.com/apache/trafficcontrol/pull/7863 Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 117.0.3 to 119.0.1. Commits

[I] Rocky Linux 9: /usr/lib/rpm/rpmdb_verify is not available - CRITICAL FAILURE [trafficcontrol]

2023-11-08 Thread via GitHub
smalenfant opened a new issue, #7860: URL: https://github.com/apache/trafficcontrol/issues/7860 ## This Bug Report affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT) ## What did you do? Installed Cache Config on Rocky LInux 9.

[PR] Update Go version to 1.21.4 [trafficcontrol]

2023-11-08 Thread via GitHub
asf-ci-trafficcontrol opened a new pull request, #7859: URL: https://github.com/apache/trafficcontrol/pull/7859 ## What does this PR (Pull Request) do? This PR makes the Go components of Traffic Control build using Go version 1.21.4 and updates the `golang.org/x/` dependencies.

[I] t3c: Can't detect SystemD in Rocky Linux 9 [trafficcontrol]

2023-11-08 Thread via GitHub
smalenfant opened a new issue, #7858: URL: https://github.com/apache/trafficcontrol/issues/7858 ## This Bug Report affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT) ## What did you do? Installed Cache Config on Rocky LInux 9

Re: [PR] Update Go version to 1.21.4 [trafficcontrol]

2023-11-08 Thread via GitHub
codecov[bot] commented on PR #7859: URL: https://github.com/apache/trafficcontrol/pull/7859#issuecomment-1801954384 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7859?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] smalenfant commented on issue #7129: Let's Encrypt certificates sometimes fails to write to Traffic Vault - postgresql

2023-01-23 Thread via GitHub
smalenfant commented on issue #7129: URL: https://github.com/apache/trafficcontrol/issues/7129#issuecomment-1400410538 Just an update here. When I issue a renew, this will always happen on the first try (500 error on the UI). I just go back and renew again and it "renews successfully".

[GitHub] [trafficcontrol] ocket8888 merged pull request #7299: updating snapshot url and logic

2023-01-24 Thread via GitHub
ocket merged PR #7299: URL: https://github.com/apache/trafficcontrol/pull/7299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] dilraj-vyas commented on issue #7310: Docs list incorrect request property for `/jobs`

2023-01-24 Thread via GitHub
dilraj-vyas commented on issue #7310: URL: https://github.com/apache/trafficcontrol/issues/7310#issuecomment-1402261315 Hi, I Would Like to work on this issue, pls provide the necessary doc, thank you . -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] serDrem commented on a diff in pull request #7302: added anycast traffic routing ability, and lastpoll time for v6

2023-01-24 Thread via GitHub
serDrem commented on code in PR #7302: URL: https://github.com/apache/trafficcontrol/pull/7302#discussion_r1085632179 ## docs/source/overview/traffic_monitor.rst: ## @@ -56,3 +56,6 @@ Protocol Engagement --- Short polling intervals of both the :term:`cache

[GitHub] [trafficcontrol] serDrem commented on a diff in pull request #7302: added anycast traffic routing ability, and lastpoll time for v6

2023-01-24 Thread via GitHub
serDrem commented on code in PR #7302: URL: https://github.com/apache/trafficcontrol/pull/7302#discussion_r1085673122 ## docs/source/overview/traffic_monitor.rst: ## @@ -56,3 +56,6 @@ Protocol Engagement --- Short polling intervals of both the :term:`cache

[GitHub] [trafficcontrol] ocket8888 opened a new issue, #7310: Docs list incorrect request property for `/jobs`

2023-01-24 Thread via GitHub
ocket opened a new issue, #7310: URL: https://github.com/apache/trafficcontrol/issues/7310 ## This Bug Report affects these Traffic Control components: - Documentation ## Current behavior: The APIv4 and APIv5 request body descriptions for POST requests to `/jobs` list a

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7282: Missing user in logs bug

2023-01-24 Thread via GitHub
srijeet0406 commented on code in PR #7282: URL: https://github.com/apache/trafficcontrol/pull/7282#discussion_r1085606049 ## traffic_ops/traffic_ops_golang/routing/middleware/wrappers_test.go: ## @@ -440,4 +440,36 @@ func TestNoOpWhenNoPermissionsRequired(t *testing.T) {

[GitHub] [trafficcontrol] dilraj-vyas opened a new pull request, #7311: #7310

2023-01-24 Thread via GitHub
dilraj-vyas opened a new pull request, #7311: URL: https://github.com/apache/trafficcontrol/pull/7311 This Pr will fix #7310 issue Doc update ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Control Cache Config (`t3c`,

[GitHub] [trafficcontrol] kdamichie opened a new pull request, #7309: Add new role to user

2023-01-24 Thread via GitHub
kdamichie opened a new pull request, #7309: URL: https://github.com/apache/trafficcontrol/pull/7309 ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic Control Health

[GitHub] [trafficcontrol] serDrem commented on a diff in pull request #7302: added anycast traffic routing ability, and lastpoll time for v6

2023-01-24 Thread via GitHub
serDrem commented on code in PR #7302: URL: https://github.com/apache/trafficcontrol/pull/7302#discussion_r1085672706 ## traffic_monitor/cache/astats.go: ## @@ -116,8 +117,23 @@ func astatsParse(cacheName string, rdr io.Reader, pollCTX interface{}) (Statisti

[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7282: Missing user in logs bug

2023-01-24 Thread via GitHub
kdamichie commented on code in PR #7282: URL: https://github.com/apache/trafficcontrol/pull/7282#discussion_r1085936103 ## traffic_ops/traffic_ops_golang/routing/middleware/wrappers_test.go: ## @@ -440,4 +440,36 @@ func TestNoOpWhenNoPermissionsRequired(t *testing.T) {

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7303: Add Physical Location Page to TPv2

2023-01-24 Thread via GitHub
shamrickus commented on code in PR #7303: URL: https://github.com/apache/trafficcontrol/pull/7303#discussion_r1086051541 ## experimental/traffic-portal/src/app/shared/generic-table/generic-table.component.ts: ## @@ -629,7 +660,7 @@ export class GenericTableComponent implements

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7303: Add Physical Location Page to TPv2

2023-01-24 Thread via GitHub
shamrickus commented on code in PR #7303: URL: https://github.com/apache/trafficcontrol/pull/7303#discussion_r1086059972 ## experimental/traffic-portal/src/app/core/servers/phys-loc/table/phys-loc-table.component.spec.ts: ## @@ -0,0 +1,80 @@ +/* + * Licensed under the Apache

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7303: Add Physical Location Page to TPv2

2023-01-24 Thread via GitHub
shamrickus commented on code in PR #7303: URL: https://github.com/apache/trafficcontrol/pull/7303#discussion_r1086071676 ## experimental/traffic-portal/src/app/shared/navigation/tp-sidebar/tp-sidebar.component.ts: ## @@ -0,0 +1,140 @@ +/* + * Licensed under the Apache License,

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7303: Add Physical Location Page to TPv2

2023-01-24 Thread via GitHub
ocket commented on code in PR #7303: URL: https://github.com/apache/trafficcontrol/pull/7303#discussion_r1086002557 ## experimental/traffic-portal/src/app/api/physical-location.service.ts: ## @@ -23,33 +22,75 @@ import { APIService } from "./base-api.service"; */

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7303: Add Physical Location Page to TPv2

2023-01-24 Thread via GitHub
shamrickus commented on code in PR #7303: URL: https://github.com/apache/trafficcontrol/pull/7303#discussion_r1086054580 ## experimental/traffic-portal/src/app/shared/generic-table/generic-table.component.html: ## @@ -49,7 +50,7 @@

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7303: Add Physical Location Page to TPv2

2023-01-24 Thread via GitHub
shamrickus commented on code in PR #7303: URL: https://github.com/apache/trafficcontrol/pull/7303#discussion_r1086056792 ## experimental/traffic-portal/src/app/core/servers/phys-loc/detail/phys-loc-detail.component.html: ## @@ -0,0 +1,78 @@ + + + + + +

[GitHub] [trafficcontrol] ocket8888 opened a new issue, #7312: CDN Locks documentation missing response structure

2023-01-25 Thread via GitHub
ocket opened a new issue, #7312: URL: https://github.com/apache/trafficcontrol/issues/7312 ## This Bug Report affects these Traffic Control components: - Documentation ## Current behavior: APIv4 and APIv5 documentation for the `/cdn_locks` endpoint are missing a description

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7304: Added the separated workflow badges to readme

2023-01-20 Thread via GitHub
ericholguin opened a new pull request, #7304: URL: https://github.com/apache/trafficcontrol/pull/7304 This PR simply adds the newly separated unit test workflow badges to the readme with their associated codecov badge. ## Which Traffic Control components are

<    1   2   3   4   5   6   7   8   9   10   >