[jira] [Created] (TC-460) Delivery-service tenancy based access control - DS/Server Assignment

2017-07-25 Thread Nir Sopher (JIRA)
Nir Sopher created TC-460: - Summary: Delivery-service tenancy based access control - DS/Server Assignment Key: TC-460 URL: https://issues.apache.org/jira/browse/TC-460 Project: Traffic Control

[GitHub] incubator-trafficcontrol issue #742: [TC-428] Ds tenancy validation

2017-07-25 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/742 If you set neither both features will work simultaneously. In order to access a DS you'll need to be in the proper tenant (if DS has tenancy) as well as have a ds/tm_user

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129162314 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -153,21 +158,26 @@ sub show { my $current_user = $self

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129148538 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -153,21 +158,26 @@ sub show { my $current_user = $self

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129144946 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -909,8 +945,13 @@ sub capacity { my $id = $self->param(

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129143451 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -292,7 +308,10 @@ sub update { } #setting

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129120463 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -54,7 +54,10 @@ sub index { $criteria{'me.logs_enabled

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129119425 --- Diff: traffic_ops/app/lib/Utils/Tenant.pm --- @@ -64,6 +64,10 @@ sub new { ->get_column('value')->

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129117364 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -54,7 +54,10 @@ sub index { $criteria{'me.logs_enabled

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-20 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/742 [TC-428] Ds tenancy validation Verifying the DS tenancy on delivery-service API You can merge this pull request into a Git repository by running: $ git pull https

[jira] [Created] (TC-428) Tenancy based access control - Delivery Service API

2017-07-20 Thread Nir Sopher (JIRA)
Nir Sopher created TC-428: - Summary: Tenancy based access control - Delivery Service API Key: TC-428 URL: https://issues.apache.org/jira/browse/TC-428 Project: Traffic Control Issue Type

[GitHub] incubator-trafficcontrol pull request #735: [TC-427] User tenancy validation

2017-07-19 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/735#discussion_r128364144 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -477,6 +506,13 @@ sub update_current { return $self->alert( "

[jira] [Created] (TC-427) Tenancy Based Access Control - User Resource

2017-07-19 Thread Nir Sopher (JIRA)
Nir Sopher created TC-427: - Summary: Tenancy Based Access Control - User Resource Key: TC-427 URL: https://issues.apache.org/jira/browse/TC-427 Project: Traffic Control Issue Type: Improvement

[GitHub] incubator-trafficcontrol pull request #735: User tenancy validation

2017-07-18 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/735 User tenancy validation Updating the user API to enforce user tenancy access control. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #718: Tenant in DS table - tenant name...

2017-07-10 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/718 Tenant in DS table - tenant name in API Adding the tenant name to DS listing APIs You can merge this pull request into a Git repository by running: $ git pull https

[jira] [Commented] (TC-412) Currently when a delivery service encounters an error we currently don’t know how to find the owner to notify them of the outage or contact them to find cause of issue.

2017-07-06 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076233#comment-16076233 ] Nir Sopher commented on TC-412: --- Hi William, Regarding the addition of owner to each DS. Are you going to use

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-29 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124880183 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol issue #644: Tenant utils

2017-06-29 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/644 file move moved as required --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-trafficcontrol issue #644: Tenant utils

2017-06-28 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/644 True. Note that there is also a matter of consistency: Tenant update can also be done only by the parent. Would you like to change that as well? On Jun 29, 2017

[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...

2017-06-28 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r124647087 --- Diff: docs/source/development/traffic_ops_api/v12/deliveryservice.rst --- @@ -168,6 +168,8 @@ Delivery Service

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124640284 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -248,7 +326,17 @@ sub delete { if ( !defined($tenant

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124639190 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124638570 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124637268 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -121,7 +115,12 @@ sub update

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124635238 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -31,34 +32,28 @@ sub getTenantName { return defined($tenant_id) ? $self->

[GitHub] incubator-trafficcontrol pull request #691: [TC-398] "create user" API - mov...

2017-06-20 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/691 [TC-398] "create user" API - moving password hashing to scrypt You can merge this pull request into a Git repository by running: $ git pull https://github.com/

[jira] [Created] (TC-398) Create User API - Broken due to merge issue

2017-06-20 Thread Nir Sopher (JIRA)
Nir Sopher created TC-398: - Summary: Create User API - Broken due to merge issue Key: TC-398 URL: https://issues.apache.org/jira/browse/TC-398 Project: Traffic Control Issue Type: Bug

[jira] [Updated] (TC-384) Profiles exported from TC1.7 cannot be imported to TC 2.1

2017-06-12 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nir Sopher updated TC-384: -- Description: Due to a missing "profile-type" in the 1.7 json, the profiles cannot be imported.

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-05 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/644 Tenant utils Adding the "TenantUtils" class allowing to check if resource is accessible (tenancy wise). The class provides further tenants related functionalit

[GitHub] incubator-trafficcontrol issue #403: [TC-184] Org tenancy - delivery service...

2017-06-01 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/403 Rebase was done. The below tests are failing regardless to the PR t/api/1.1/deliveryservice/ssl_keys.t t/user.t t/deliveryserviceserver.t t/api/1.2

[GitHub] incubator-trafficcontrol issue #230: [TC-121] Allowing variables in traffic-...

2017-06-01 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/230 PR was rebased so it cam be merged. However, it still needs to be verified again by adding a record to records.config and checking the value --- If your project is set up

[GitHub] incubator-trafficcontrol issue #370: Adding a "create user" to the api

2017-06-01 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/370 The change of the "role" broke the UT and was reverted. It changes current behavior of user-update. I prefer not to make such changes in this PR --- If yo

[GitHub] incubator-trafficcontrol issue #370: Adding a "create user" to the api

2017-06-01 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/370 Rebase was done a PR review changes were made, except for a test for "username" in the beginning of the create function. The test is done as the value is in use by th

[jira] [Created] (TC-332) Heatlh tab never loads if there are no traffic monitors

2017-05-15 Thread Nir Sopher (JIRA)
Nir Sopher created TC-332: - Summary: Heatlh tab never loads if there are no traffic monitors Key: TC-332 URL: https://issues.apache.org/jira/browse/TC-332 Project: Traffic Control Issue Type: Bug

[jira] [Created] (TC-317) ORT syncds bug

2017-05-15 Thread Nir Sopher (JIRA)
Nir Sopher created TC-317: - Summary: ORT syncds bug Key: TC-317 URL: https://issues.apache.org/jira/browse/TC-317 Project: Traffic Control Issue Type: Bug Reporter: Nir Sopher Based

[jira] [Created] (TC-304) Ping each Riak server

2017-05-15 Thread Nir Sopher (JIRA)
Nir Sopher created TC-304: - Summary: Ping each Riak server Key: TC-304 URL: https://issues.apache.org/jira/browse/TC-304 Project: Traffic Control Issue Type: Improvement Components

[jira] [Created] (TC-299) TO Change Log. Expand status to human readable string

2017-05-15 Thread Nir Sopher (JIRA)
Nir Sopher created TC-299: - Summary: TO Change Log. Expand status to human readable string Key: TC-299 URL: https://issues.apache.org/jira/browse/TC-299 Project: Traffic Control Issue Type

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r113034286 --- Diff: traffic_ops/app/t/api/1.2/user_admin.t --- @@ -0,0 +1,126 @@ +package main; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r113034309 --- Diff: traffic_ops/app/t/api/1.2/user_admin.t --- @@ -0,0 +1,126 @@ +package main; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-24 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r113028771 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -226,6 +226,120 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol issue #379: Reverse schema gaps

2017-04-24 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/379 This PR became old and might be irrelevant. Closing it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-trafficcontrol pull request #379: Reverse schema gaps

2017-04-24 Thread nir-sopher
Github user nir-sopher closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafficcontrol issue #433: [TC-184] Tenancy validation for resourc...

2017-04-24 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/433 Following a discussion with @mitchell852 I'm closing this PR. New PR will be provided, supplying an API that supports tenants table caching to reduce calls to DB when the API

[GitHub] incubator-trafficcontrol issue #403: [TC-184] Org tenancy - delivery service...

2017-04-20 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/403 @mitchell852 Please note that after rebasing the branch deliveryservice UT fail. For some reason the changes I do does not work well with the changes you did, moving from

[GitHub] incubator-trafficcontrol issue #403: [TC-184] Org tenancy - delivery service...

2017-04-20 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/403 File was renamed as required --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...

2017-04-20 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112417979 --- Diff: traffic_ops/app/db/migrations/2017040400_delivery_service_tenancy.sql --- @@ -0,0 +1,30 @@ +/* --- End diff

[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...

2017-04-20 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112418273 --- Diff: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm --- @@ -278,11 +278,22 @@ __PACKAGE__->table("deliver

[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...

2017-04-20 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112420550 --- Diff: traffic_ops/app/t/api/1.2/deliveryservice.t --- @@ -30,302 +30,407 @@ use Test::TestHelper; BEGIN { $ENV{MOJO_MODE

[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...

2017-04-20 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112409155 --- Diff: docs/source/development/traffic_ops_api/v12/deliveryservice.rst --- @@ -168,6 +168,8 @@ Delivery Service

[jira] [Comment Edited] (TC-217) Self Service - CRUD Sub Tenant

2017-04-18 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972417#comment-15972417 ] Nir Sopher edited comment on TC-217 at 4/18/17 12:42 PM: - Hi, I believe we need

[jira] [Commented] (TC-217) Self Service - CRUD Sub Tenant

2017-04-18 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972417#comment-15972417 ] Nir Sopher commented on TC-217: --- Hi, I believe we need to distinguish between the 2 terminologies: "desce

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-10 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r110659889 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -226,6 +226,120 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-10 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r110659653 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -226,6 +226,120 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol issue #402: [TC-184] Org tenancy - adding tenant to...

2017-04-10 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/402 In this phase we are dealing with "org-tenancy". Initially I thought some CDN tenancy is required in this phase - as the content provider creating a DS needs

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-07 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r110366117 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -218,6 +218,115 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-07 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r110366079 --- Diff: docs/source/development/traffic_ops_api/v12/user.rst --- @@ -214,6 +214,153 @@ Users | + +**POST

[GitHub] incubator-trafficcontrol issue #370: Adding a "create user" to the api

2017-04-07 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/370 Indeed On Apr 7, 2017 6:16 AM, "Jeremy Mitchell" <notificati...@github.com> wrote: > *@mitchell852* commented o

[GitHub] incubator-trafficcontrol pull request #322: Adding tenancy to the database

2017-04-06 Thread nir-sopher
Github user nir-sopher closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafficcontrol issue #322: Adding tenancy to the database

2017-04-06 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/322 Almost all changes are already added by other PRs. Closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-trafficcontrol pull request #439: org tenancy - verify tenant user...

2017-04-06 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/439 org tenancy - verify tenant user test stability Verifying the order of items in the list to ensure test stability You can merge this pull request into a Git repository

[GitHub] incubator-trafficcontrol pull request #433: Tenancy validation tenant

2017-04-06 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/433 Tenancy validation tenant WIP. First step in tenancy verification and tests - treating "tenant" as a resource and verify who can write/read it. WIP as this

[GitHub] incubator-trafficcontrol pull request #429: Org tenancy - initial configurat...

2017-04-05 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/429 Org tenancy - initial configuration This PR deals with adding a root tenant. seed.sql was added with a root user and a util script was added to assign a user to a tenant

[jira] [Comment Edited] (TC-217) Self Service - CRUD Sub Tenant

2017-04-05 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954994#comment-15954994 ] Nir Sopher edited comment on TC-217 at 4/5/17 8:59 AM: --- Further thinking of the issue I

[jira] [Comment Edited] (TC-217) Self Service - CRUD Sub Tenant

2017-04-05 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954994#comment-15954994 ] Nir Sopher edited comment on TC-217 at 4/5/17 8:57 AM: --- Further thinking of the issue I

[GitHub] incubator-trafficcontrol issue #403: [TC-184] Org tenancy - delivery service...

2017-04-04 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/403 All required merges were done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-04-04 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109747255 --- Diff: traffic_ops/app/db/migrations/2017031502_cdn_tenancy.sql --- @@ -0,0 +1,31 @@ +/* --- End diff -- Done

[jira] [Commented] (TC-217) Self Service - CRUD Sub Tenant

2017-04-04 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955009#comment-15955009 ] Nir Sopher commented on TC-217: --- Ryan, Per your comment, please see my comments and edits to https

[jira] [Commented] (TC-217) Self Service - CRUD Sub Tenant

2017-04-04 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954994#comment-15954994 ] Nir Sopher commented on TC-217: --- Further thinking of the issue I would like to revise the earlier suggestion I

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-02 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109313737 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -277,6 +285,7 @@ sub current { @data

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-02 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109302513 --- Diff: traffic_ops/app/t/api/1.2/tenant.t --- @@ -152,6 +152,12 @@ ok $t->delete_ok('/api/1.2/tenants/' . $tenantE_id)->sta

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-02 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109302190 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -174,7 +179,9 @@ sub update { registration_sent

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-04-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109292359 --- Diff: traffic_ops/app/lib/Fixtures/Cdn.pm --- @@ -33,6 +34,17 @@ my %definition_for = ( id =>

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-04-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109292282 --- Diff: traffic_ops/app/lib/API/Cdn.pm --- @@ -181,19 +189,25 @@ sub update { return $self->alert( "a cdn wit

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-04-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109292241 --- Diff: traffic_ops/app/lib/API/Cdn.pm --- @@ -123,10 +126,14 @@ sub create { return $self->alert( "a cdn wit

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-04-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109292194 --- Diff: traffic_ops/app/lib/API/Cdn.pm --- @@ -123,10 +126,14 @@ sub create { return $self->alert( "a cdn wit

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-04-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109292111 --- Diff: traffic_ops/app/db/migrations/2017031502_cdn_tenancy.sql --- @@ -0,0 +1,31 @@ +/* --- End diff

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109291385 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -159,6 +161,9 @@ sub update { return $self->not_fo

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109291378 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -159,6 +161,9 @@ sub update { return $self->not_fo

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109291260 --- Diff: traffic_ops/app/db/migrations/2017031501_user_tenancy.sql --- @@ -0,0 +1,31 @@ +/* --- End diff

[jira] [Commented] (TC-217) Self Service - CRUD Sub Tenant

2017-03-28 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944602#comment-15944602 ] Nir Sopher commented on TC-217: --- Hi, Please let me know if the below satisfy you need: Adding an api whose

[jira] [Commented] (TC-215) SSL Automate Standard Cert Generation and Application

2017-03-28 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944597#comment-15944597 ] Nir Sopher commented on TC-215: --- Please note that the solution proposed in TC-55 practically allows you to use

[GitHub] incubator-trafficcontrol pull request #403: Org tenancy - delivery services

2017-03-23 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/403 Org tenancy - delivery services This PR adds the tenancy to the delivery services, and adjusts the API. No tenancy based authorization yet. Note that the PR can

[GitHub] incubator-trafficcontrol pull request #402: Org tenancy - adding tenant to c...

2017-03-23 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/402 Org tenancy - adding tenant to cdn This PR adds tenant to the CDN table and adjusts the API. It can be pulled by itself but merging it with PR-398 (adding the user tenancy

[GitHub] incubator-trafficcontrol issue #385: [TC-184] - adds parent tenant name

2017-03-22 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/385 Yes I am. Thank you for adding it. Nir On Wed, Mar 22, 2017 at 7:18 PM, Jeremy Mitchell <notificati...@github.com> wrote: > @nir-soph

[GitHub] incubator-trafficcontrol issue #371: [TC-184] Tenancy table creation

2017-03-17 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/371 I'll add the test, also as all other fields in the tenant module are tested upon update, so it is more consistent. --- If your project is set up for it, you can reply

[GitHub] incubator-trafficcontrol issue #371: [TC-184] Tenancy table creation

2017-03-17 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/371 Thanks Jeremy for your comments and help with documentation. Most AIs are in. Still need to further discuss "Active" input as required comment --- If your proj

[GitHub] incubator-trafficcontrol pull request #371: [TC-184] Tenancy table creation

2017-03-17 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/371#discussion_r106616105 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -0,0 +1,247 @@ +package API::Tenant; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #371: [TC-184] Tenancy table creation

2017-03-17 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/371#discussion_r106613842 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -0,0 +1,247 @@ +package API::Tenant; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #371: [TC-184] Tenancy table creation

2017-03-17 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/371#discussion_r106613824 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -0,0 +1,247 @@ +package API::Tenant; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #371: [TC-184] Tenancy table creation

2017-03-17 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/371#discussion_r106613763 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -0,0 +1,247 @@ +package API::Tenant; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #378: t_integration/server.t test & Up...

2017-03-16 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/378 t_integration/server.t test & UploadCsv - Aligning the csv file header This PR was created while trying to fix the subject test, but it is not required for the

[GitHub] incubator-trafficcontrol pull request #377: t_integration/server.t test fix

2017-03-16 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/377 t_integration/server.t test fix This PR tries to fix the failures of the subject test. It seems not like a test issue, but rather a bug. Still, the below fix feels like

[GitHub] incubator-trafficcontrol pull request #371: Tenancy table creation

2017-03-15 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/371 Tenancy table creation This PR is the first step in adding "org tenancy" to TC. It comes to start and replace PR-322 It define the tenants table, including an &qu

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-03-15 Thread nir-sopher
GitHub user nir-sopher opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/370 Adding a "create user" to the api You can merge this pull request into a Git repository by running: $ git pull https://github.com/nir-sopher/incubator-traf

[jira] [Commented] (TC-184) Tenant Hierarchy

2017-03-15 Thread Nir Sopher (JIRA)
[ https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926224#comment-15926224 ] Nir Sopher commented on TC-184: --- Hi Ryan, I'm currently working on a PR focusing on items 1-4 of the JIRA

[GitHub] incubator-trafficcontrol issue #322: Adding tenancy to the database

2017-03-07 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/322 Current status: All UTs passed. First batch of PR remarks was fixed. The API supports tenancy for CDn / Delivery Service / Users UTs are added to cover

[GitHub] incubator-trafficcontrol issue #322: Adding tenancy to the database

2017-03-06 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/322 The \ is still in my local repo. Will be pushed on next update On Mar 6, 2017 8:35 PM, "Jeremy Mitchell" <notificati...@github.com> wrote:

[GitHub] incubator-trafficcontrol issue #322: Adding tenancy to the database

2017-03-01 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/322 This PR can stand for its own. It passed the unit tests beside delivery-service related failures, which as far as I can see are not related to my change. Will be able

[GitHub] incubator-trafficcontrol pull request #322: Adding tenancy to the database

2017-03-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r103793015 --- Diff: traffic_ops/app/t/api/1.2/tenant.t --- @@ -0,0 +1,156 @@ +package main; +# +# +# Licensed under the Apache

[GitHub] incubator-trafficcontrol pull request #322: Adding tenancy to the database

2017-03-01 Thread nir-sopher
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r103788980 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -0,0 +1,225 @@ +package API::Tenant; +# +# +# Licensed under

<    1   2   3   >