Github user jpeach closed the issue at:
https://github.com/apache/trafficserver/issues/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/issues/1423
```
[jpeach@sk1 trafficserver]$ /opt/ats/bin/traffic_ctl config status
Apache Traffic Server - traffic_server - 7.2.0 - (build # 022120 on Feb 21
2017 at 20:56:37)
Started at Tue
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102378936
--- Diff: proxy/FetchSM.cc ---
@@ -26,6 +26,7 @@
#include
#include "HTTP.h"
#include "PluginVC.h"
+#include // Ugly, but we need
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102379397
--- Diff: proxy/http/remap/RemapConfig.cc ---
@@ -778,7 +778,7 @@ remap_load_plugin(const char **argv, int argc,
url_mapping *mp, char *errbuf, in
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102379269
--- Diff: proxy/Plugin.cc ---
@@ -231,8 +231,8 @@ plugin_init(bool validateOnly)
if (INIT_ONCE) {
api_init();
-
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102378986
--- Diff: proxy/Main.cc ---
@@ -38,6 +38,8 @@
#include "ts/ink_syslog.h"
#include "ts/hugepages.h"
+#include // This is sadly
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102378964
--- Diff: proxy/Main.cc ---
@@ -38,6 +38,8 @@
#include "ts/ink_syslog.h"
#include "ts/hugepages.h"
+#include // This is sadly
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102379416
--- Diff: proxy/Plugin.cc ---
@@ -231,8 +231,8 @@ plugin_init(bool validateOnly)
if (INIT_ONCE) {
api_init();
-
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102378869
--- Diff: lib/wccp/Makefile.am ---
@@ -20,8 +20,8 @@
include $(top_srcdir)/build/tidy.mk
AM_CPPFLAGS = \
-
Github user jpeach closed the issue at:
https://github.com/apache/trafficserver/issues/1425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1468
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1479
I don't get how this is better than the previous version. That was purely
compile time and this compares the global `typeid` constants at runtime. It
doesn't seem better.
---
If your
GitHub user shinrich opened an issue:
https://github.com/apache/trafficserver/issues/1480
Crash in Http1ClientSession::set_inactivity_timeout
While testing 7.1, we see the following crash and stack track
```
#0 0x in ?? ()
#1 0x005d6794 in
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1479
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/161/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1479
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1596/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1479
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1490/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1479
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/29/ for details.
---
If your project is set up for it, you can reply to this email and have your
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1479
Add static type checking to configuration override API implementation.
You can merge this pull request into a Git repository by running:
$ git pull
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
I should have added:
- the copyright headers for the source files
- blurb to the notices file ( I hope this is correct @zwoop?)
- I have add some documentation @persiaAziz
GitHub user realpdm opened an issue:
https://github.com/apache/trafficserver/issues/1478
sscl is occasionally zero (formerly TS-2998)
Scott Beardsley originally reported in
https://issues.apache.org/jira/browse/TS-2998
Running ATS 5.0 it looks like sscl in the
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/160/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1489/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1595/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/28/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1477#discussion_r102292776
--- Diff: lib/ts/ink_assert.h ---
@@ -32,6 +32,11 @@ Assertions
#include "ts/ink_error.h"
#ifdef __cplusplus
+
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1477#discussion_r102291884
--- Diff: proxy/InkAPI.cc ---
@@ -7772,395 +7772,372 @@ TSSkipRemappingSet(TSHttpTxn txnp, int flag)
}
// Little helper
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1477
I can write that part if you want, IMHO it should be trivial. Basically
you'd convert the `switch` to an `if/else` like
```
if (*type == typeid(MgmtInt)) { ... do int type
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1477
@SolidWallOfCode Thanks! So 1) yeh, I can look at that and for 2) I'm not
sure you can get rid of OverridableDataType, the issue is, if I recall, that
there is/was mismatch in how this is
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1477#discussion_r102279727
--- Diff: proxy/InkAPI.cc ---
@@ -7772,395 +7772,372 @@ TSSkipRemappingSet(TSHttpTxn txnp, int flag)
}
// Little helper function to
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1477
Two comments.
First,I think the function approach is not a good one. I would recommend
straight struct templates with a value. Something like
```
template struct
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/159/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1594/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/158/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1488/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/27/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1593/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1487/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/26/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/1456
It seems like we should have some sort of layered approach, where we keep
track of tcp (l4) http (L5?) and TLS (L7). We have metrics for some of this it
sounds, but IIRC they are a bit
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/157/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/25/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1477
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/155/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1592/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/156/ for details.
---
If your project is set up for it, you can reply to this email
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1477#discussion_r102254881
--- Diff: proxy/InkAPI.cc ---
@@ -7772,395 +7772,372 @@ TSSkipRemappingSet(TSHttpTxn txnp, int flag)
}
// Little helper function to
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1477#discussion_r102254435
--- Diff: proxy/InkAPI.cc ---
@@ -7772,395 +7772,372 @@ TSSkipRemappingSet(TSHttpTxn txnp, int flag)
}
// Little helper function to
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1486/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1591/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/24/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1485/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1446
Updated PR to address issue #1459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1477
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1590/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1477
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1484/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1477
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/23/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1472
Have you tested this in practice? `ua_buffer_reader->read_avail()` should
be zero in most cases, because all of the header has been read and the user
agent shouldn't send more data
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1477
Uses static type checking on the overridable types
Also cleans up the code a little bit, but the big change is that
we now produce compile time errors when someone is not using the
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1456
The `http` stat measures only HTTP 1.X connections and only those that are
successfully created. If, for example, there is a connection that fails the TLS
handshake, this stat will
GitHub user shinrich opened an issue:
https://github.com/apache/trafficserver/issues/1476
Crash in get_client_addr()
After working through issues #1401 and #1443, we now see the following
crash in our copy of 7.1. The crash occurs once every couple hours.
```
#0
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
@jpeach So I agree with everything you suggest except for moving the test
under the ci directory. The source layout is confusing enough as is. hiding
this under some location no one will
Github user shinrich closed the issue at:
https://github.com/apache/trafficserver/issues/1369
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/issues/1369
Change committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/issues/1421
Related discussion on issue #1401. I have a hacky PR related to that
issue, which has enabled us to continue on. It is definitely triggered by the
error bubbling changes. I didn't pin
63 matches
Mail list logo
