[GitHub] trafficserver issue #1615: Doc: Update plugin stats documentation.

2017-03-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1615 > On Mar 28, 2017, at 2:08 PM, Alan M. Carroll <notificati...@github.com> wrote: > > I'll see what I can do, @jpeach. This already includes code from the ex

[GitHub] trafficserver issue #1598: Assertion failing when calling TSHttpTxnReenable ...

2017-03-20 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/issues/1598 You have to call `TSHttpTxnReenable` from an event thread. The typical pattern is to use `TSContSchedule` to bounce the call back over to the event thread pool once you are done

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-10 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1565 Consider updating the API documentation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-03-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1457 With some additional effort, we can fix this reliably. The traditional way to do this is for the signal handler to write a byte to a pipe, which will wake up an event handler to do an ordered

[GitHub] trafficserver issue #1515: Logging cache code map size fix

2017-02-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1515 Can you look into fixing the APIs so this can't happen again? > On Feb 28, 2017, at 10:32 AM, Gancho Tenev <notificati...@github.com> wrote: > > The size of

[GitHub] trafficserver pull request #1508: Fix template directory path

2017-02-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1508#discussion_r103381037 --- Diff: proxy/http/HttpBodyFactory.cc --- @@ -301,14 +299,13 @@ HttpBodyFactory::reconfigure() ats_scoped_str

[GitHub] trafficserver issue #1423: traffic_ctl status is broken

2017-02-21 Thread jpeach
Github user jpeach closed the issue at: https://github.com/apache/trafficserver/issues/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1423: traffic_ctl status is broken

2017-02-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/issues/1423 ``` [jpeach@sk1 trafficserver]$ /opt/ats/bin/traffic_ctl config status Apache Traffic Server - traffic_server - 7.2.0 - (build # 022120 on Feb 21 2017 at 20:56:37) Started at Tue

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102378936 --- Diff: proxy/FetchSM.cc --- @@ -26,6 +26,7 @@ #include #include "HTTP.h" #include "PluginVC.h" +#include

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102379397 --- Diff: proxy/http/remap/RemapConfig.cc --- @@ -778,7 +778,7 @@ remap_load_plugin(const char **argv, int argc, url_mapping *mp, char *errbuf

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102379269 --- Diff: proxy/Plugin.cc --- @@ -231,8 +231,8 @@ plugin_init(bool validateOnly) if (INIT_ONCE) { api_init

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102378986 --- Diff: proxy/Main.cc --- @@ -38,6 +38,8 @@ #include "ts/ink_syslog.h" #include "ts/hugepages.h" +#inclu

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102378964 --- Diff: proxy/Main.cc --- @@ -38,6 +38,8 @@ #include "ts/ink_syslog.h" #include "ts/hugepages.h" +#inclu

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102379416 --- Diff: proxy/Plugin.cc --- @@ -231,8 +231,8 @@ plugin_init(bool validateOnly) if (INIT_ONCE) { api_init

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102378869 --- Diff: lib/wccp/Makefile.am --- @@ -20,8 +20,8 @@ include $(top_srcdir)/build/tidy.mk AM_CPPFLAGS = \ - -I$(abs_top_srcdir

[GitHub] trafficserver issue #1425: PROXY_CONFIG_CONFIG_DIR doesn't change sysconfig ...

2017-02-21 Thread jpeach
Github user jpeach closed the issue at: https://github.com/apache/trafficserver/issues/1425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1468: Allow overriding proxy.config.config_dir.

2017-02-21 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

2017-02-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1479 I don't get how this is better than the previous version. That was purely compile time and this compares the global `typeid` constants at runtime. It doesn't seem better. --- If your

[GitHub] trafficserver pull request #1477: Uses static type checking on the overridab...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1477#discussion_r102254881 --- Diff: proxy/InkAPI.cc --- @@ -7772,395 +7772,372 @@ TSSkipRemappingSet(TSHttpTxn txnp, int flag) } // Little helper function

[GitHub] trafficserver pull request #1477: Uses static type checking on the overridab...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1477#discussion_r102254435 --- Diff: proxy/InkAPI.cc --- @@ -7772,395 +7772,372 @@ TSSkipRemappingSet(TSHttpTxn txnp, int flag) } // Little helper function

[GitHub] trafficserver issue #1475: ASAN issue in traffic_manager metrics Lua binding...

2017-02-20 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/issues/1475 Check the verbose log to ensure that Lua was excluded from ASAN correctly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #1461: Changes debug builds with Intel to just -g

2017-02-20 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1469: Introduce a Result error object.

2017-02-20 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1469: Introduce a Result error object.

2017-02-18 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/1469 Introduce a Result error object. Introduce a `Result` object to carry an abstract error with a corresponding message. We already had `config_parse_error`, but this is slightly more general

[GitHub] trafficserver pull request #1468: Allow overriding proxy.config.config_dir.

2017-02-18 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/1468 Allow overriding proxy.config.config_dir. Explicitly check whether proxy.config.config_dir has been overridden in the environment before trying to load any configuration files

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1457 Is it still possible to use leak checkers that reconcile at exit after this fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1423: traffic_ctl status is broken

2017-02-08 Thread jpeach
GitHub user jpeach opened an issue: https://github.com/apache/trafficserver/issues/1423 traffic_ctl status is broken ``` # /opt/ats/bin/traffic_ctl config status traffic_ctl: [11] Invalid parameters passed into function call. ``` --- If your project is set

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-01-30 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1357 Whilst the configuration of SSL keys and certificates is a bit unfortunate, I think that it is important to be consistent. Separately, you have to define the base directory

[GitHub] trafficserver issue #1325: #1323 Restores the NULL string where appropriate

2017-01-13 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1325 Afaict this is just strcmp then? > On Jan 13, 2017, at 7:03 PM, Leif Hedstrom <notificati...@github.com> wrote: > > @zwoop commented on this pull request.

[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...

2017-01-13 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1325#discussion_r96091697 --- Diff: lib/records/RecUtils.cc --- @@ -419,7 +419,7 @@ RecDataSetFromString(RecDataT data_type, RecData *data_dst, const char *data_str

[GitHub] trafficserver pull request #1309: Fixes for building with LibreSSL

2017-01-09 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1309#discussion_r95204594 --- Diff: example/cppapi/websocket/WSBuffer.cc --- @@ -157,7 +157,7 @@ WSBuffer::read_buffered_message(std::string , int ) std::string

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

2017-01-04 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1294#discussion_r94717030 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -58,26 +57,26 @@ fastopen_bwrite(BIO *bio, const char *in, int insz) errno = 0

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

2017-01-04 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1294#discussion_r94717201 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -27,28 +27,27 @@ #include "BIO_fastopen.h" -static int -fastopen_creat

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

2017-01-04 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1294#discussion_r94717094 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -116,39 +115,21 @@ static long fastopen_ctrl(BIO *bio, int cmd, long larg, void *ptr

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

2017-01-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1294#discussion_r94530155 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -44,8 +57,7 @@ fastopen_destroy(BIO *bio) if (bio) { // We expect this BIO to not own

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

2017-01-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1294#discussion_r94529780 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -27,13 +27,26 @@ #include "BIO_fastopen.h" +#if OPENSSL_VERSION_NUMBER <

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

2017-01-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1294#discussion_r94529615 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -160,9 +174,24 @@ static const BIO_METHOD fastopen_methods = { .destroy = fastopen_destroy

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

2017-01-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1294#discussion_r94530947 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -27,13 +27,26 @@ #include "BIO_fastopen.h" +#if OPENSSL_VERSION_NUMBER <

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

2017-01-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1294#discussion_r94530637 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -27,13 +27,26 @@ #include "BIO_fastopen.h" +#if OPENSSL_VERSION_NUMBER <

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

2017-01-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1294#discussion_r94530049 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -27,13 +27,26 @@ #include "BIO_fastopen.h" +#if OPENSSL_VERSION_NUMBER <

[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency

2016-12-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/981 Ubuntu 12 IIRC. But it is a problem with the virtualized hardware not the OS itself. > On Dec 16, 2016, at 10:07 AM, Phil Sorber <notificati...@github.com> wrote: >

[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency

2016-12-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/981 The problem I saw was with hwloc crashing on startup. This was on a Chinese VM hosting service and was caused by hwloc doing a divide by zero. It was unclear what version of hwloc the bug

[GitHub] trafficserver pull request #1261: TS-5096: Lua metrics crashes if the prefix...

2016-12-13 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/1261 TS-5096: Lua metrics crashes if the prefix is missing. Prevent a traffic_manager crash if someone registers a metric with no prefix. We can't make that metric available in Lua, but we

[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1258 Is anyone outside of Comcast using this? Can a configurable plugin supporting [OpenTracing](http://opentracing.io) be generalized to also support Comcast? --- If your project is set up

[GitHub] trafficserver issue #1254: TS-5085 `posix_fadvise` is incorrectly used in tr...

2016-12-07 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1254 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1235: HostDB memory fixes

2016-11-28 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1233: TS-5062: Fix traffic_ctl to track plugin s...

2016-11-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1233#discussion_r89939136 --- Diff: doc/developer-guide/api/functions/TSMgmtSourceGet.en.rst --- @@ -0,0 +1,69 @@ +.. Licensed to the Apache Software Foundation (ASF) under

[GitHub] trafficserver pull request #1233: TS-5062: Fix traffic_ctl to track plugin s...

2016-11-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1233#discussion_r89939168 --- Diff: doc/developer-guide/api/functions/TSMgmtSourceGet.en.rst --- @@ -0,0 +1,69 @@ +.. Licensed to the Apache Software Foundation (ASF) under

[GitHub] trafficserver issue #1225: Create a tool to list files changed since a tag

2016-11-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1225 Sounds like a git alias, or [git shortlog](https://git-scm.com/docs/git-shortlog). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1227: TS-5051 Add a new log tag % AppVersionInfo.B...

2016-11-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1227 Well it is trivial to make those constants available in the Lua API. I don't think these things are worth adding log tags on their own. --- If your project is set up for it, you can reply

[GitHub] trafficserver pull request #1235: HostDB memory fixes

2016-11-26 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/1235 HostDB memory fixes [TS-5065](https://issues.apache.org/jira/browse/TS-5066) Use after free clearing HostDB. [TS-5066](https://issues.apache.org/jira/browse/TS-5065) HostDB

[GitHub] trafficserver pull request #1234: TS-5063: Fixes coverity warnings and clean...

2016-11-23 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1234#discussion_r89402683 --- Diff: mgmt/LocalManager.cc --- @@ -950,29 +949,27 @@ LocalManager::startProxy(const char *onetime_options) if (open_ports_p

[GitHub] trafficserver pull request #1233: TS-5062: Fix traffic_ctl to track plugin s...

2016-11-23 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1233#discussion_r89399145 --- Diff: lib/ts/apidefs.h.in --- @@ -798,6 +798,16 @@ typedef int64_t TSMgmtCounter; typedef float TSMgmtFloat; typedef char *TSMgmtString

[GitHub] trafficserver pull request #1228: TS-5058: Fix CONNECT handling without pare...

2016-11-22 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1229: TS-5061 TS use ats_malloc instead of malloc in lo...

2016-11-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1229 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1228: TS-5058: Fix CONNECT handling without pare...

2016-11-19 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/1228 TS-5058: Fix CONNECT handling without parent proxying. The change in TS-5040 broke direct CONNECT method handling by always attempting to forward the CONNECT request. In fact, we should

[GitHub] trafficserver issue #1227: TS-5051 Add a new log tag % AppVersionInfo.B...

2016-11-19 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1227 I really don't think this is worth a log tag. It is trivial to add this information as Lua constants to be consumed by `logging.config`. Alternatively, a logging tag that can log an arbitrary

[GitHub] trafficserver pull request #1073: TS-4399 TS-4400 Management API messes up p...

2016-11-17 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1073 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1218: TS-5050: The background_fetch plugin fails...

2016-11-14 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1218#discussion_r87948595 --- Diff: plugins/background_fetch/configs.cc --- @@ -44,8 +44,13 @@ BgFetchConfig::readConfig(const char *config_file) snprintf(file_path

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

2016-11-11 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1218 @jrushford Since you are fixing this, please make sure that the new behavior is consistent with other plugins that load files. IIRC absolute paths are consumes as is, relative paths

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

2016-11-11 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1218 Is this change consistent with other plugins are doing? > On Nov 11, 2016, at 1:07 PM, Leif Hedstrom <notificati...@github.com> wrote: > > @zwoop approved th

[GitHub] trafficserver pull request #1202: TS-5040: Forward CONNECT without parent pr...

2016-11-09 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1211: TS-5045: Add ws and wss scheme constants.

2016-11-09 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1212: TS-1257: [ssl_cipher_table] replace TCL Ha...

2016-11-08 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1212#discussion_r87022320 --- Diff: iocore/net/SSLUtils.cc --- @@ -141,8 +142,9 @@ static int ssl_vc_index = -1; static ink_mutex *mutex_buf = nullptr; static

[GitHub] trafficserver pull request #1211: TS-5045: Add ws and wss scheme constants.

2016-11-07 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/1211 TS-5045: Add ws and wss scheme constants. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/5045 Alternatively

[GitHub] trafficserver issue #1197: TS-1257_ssl_cipher_name_table: replace TCL_HashTa...

2016-11-07 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1197 Please reformat the PR and commit subject to the convention: ``` TS-1257: Replace TCL hash table with unordered_map. ``` --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #1202: TS-5040: Forward CONNECT without parent proxying.

2016-11-07 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1202 @zwoop Added docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1201: TS-4994: make state configuration in ts_lu...

2016-11-06 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1201#discussion_r86699466 --- Diff: plugins/experimental/ts_lua/ts_lua.c --- @@ -64,18 +65,46 @@ TSRemapNewInstance(int argc, char *argv[], void **ih, char *errbuf, int

[GitHub] trafficserver pull request #1201: TS-4994: make state configuration in ts_lu...

2016-11-06 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1201#discussion_r86699484 --- Diff: plugins/experimental/ts_lua/ts_lua.c --- @@ -64,18 +65,46 @@ TSRemapNewInstance(int argc, char *argv[], void **ih, char *errbuf, int

[GitHub] trafficserver pull request #1201: TS-4994: make state configuration in ts_lu...

2016-11-06 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1201#discussion_r86699557 --- Diff: plugins/experimental/ts_lua/ts_lua.c --- @@ -391,12 +422,38 @@ TSPluginInit(int argc, const char *argv[]) return

[GitHub] trafficserver pull request #1201: TS-4994: make state configuration in ts_lu...

2016-11-06 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1201#discussion_r86699540 --- Diff: plugins/experimental/ts_lua/ts_lua.c --- @@ -391,12 +422,38 @@ TSPluginInit(int argc, const char *argv[]) return

[GitHub] trafficserver issue #1202: TS-5040: Forward CONNECT without parent proxying.

2016-11-06 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1202 Sending early for review. Will add another commit with documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1202: TS-5040: Forward CONNECT without parent pr...

2016-11-06 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/1202 TS-5040: Forward CONNECT without parent proxying. Unless parent proxy is enabled, CONNECT methods always result in setting up a direct tunnel to the origin server. Parent proxy

[GitHub] trafficserver pull request #1193: TS-5037: Fix LogFormat object leak.

2016-11-05 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1193: TS-5037: Fix LogFormat object leak.

2016-11-04 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1193 The `LogObject` constructor copies the format. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1073: TS-4399 TS-4400 Management API messes up proxy op...

2016-11-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1073 @danobi Since this covers 2 JIRAs, please designate one of them for the fix, and mark the other as a duplicate. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1184: TS-5030: Add API to get the unique client request...

2016-11-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1184 @calavera [here](https://github.com/apache/trafficserver/blob/master/proxy/InkAPI.cc#L5743) is an arena example. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1175: socks.config - dest_ip rule issue

2016-11-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/issues/1175 Which version of Traffic Server are you running? @oknet fixed the SOCKS proxy recently and those changes will be available in the forthcoming [7.0 release](https://lists.apache.org

[GitHub] trafficserver pull request #1192: TS-5036: use absolute path in autoconf/aut...

2016-11-03 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1191: TS-5035: plugin 'background_fetch' can be built n...

2016-11-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1191 Wow, that is embarrassing. Thanks @yunwen0111! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request #1191: TS-5035: plugin 'background_fetch' can be ...

2016-11-03 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1193: TS-5037: Fix LogFormat object leak.

2016-11-03 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/1193 TS-5037: Fix LogFormat object leak. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver jpeach/log-fmt-leak

[GitHub] trafficserver issue #1192: TS-5036: use absolute path in autoconf/automake f...

2016-11-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1192 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1191: TS-5035: plugin 'background_fetch' can be built n...

2016-11-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1191 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1187: TS-5034: Add a --enable-tsan configure opt...

2016-11-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1187#discussion_r86480536 --- Diff: configure.ac --- @@ -197,6 +197,15 @@ AC_ARG_ENABLE([asan], ) AC_MSG_RESULT([$enable_asan]) +# Enable TSAN for the builds

[GitHub] trafficserver pull request #1181: TS-5027: Replace readdir_r with readdir.

2016-11-03 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1185: TS-5031: Use readdir() instead of readdir_r()

2016-11-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1185 Dupe of #1181 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1073: TS-4399 TS-4400 Management API messes up proxy op...

2016-11-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1073 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1180: TS-4991: jtest should handle Range requests.

2016-11-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1180 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1165: TS-5023 Allow diags.log and traffic.out to be rot...

2016-11-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1165 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1168: Tsqa-- switch to using build that exist

2016-11-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1168 /cc @dragon512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver pull request #1127: TS-4990: Support new apis in ts_lua.

2016-11-02 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1127#discussion_r86285707 --- Diff: doc/admin-guide/plugins/ts_lua.en.rst --- @@ -1424,6 +1460,38 @@ We will get the output: `TOP <#ts-lua-plu

[GitHub] trafficserver pull request #1181: TS-5027: Replace readdir_r with readdir.

2016-11-02 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/1181 TS-5027: Replace readdir_r with readdir. Glibc deprecated readdir_r(3), so replace it with readdir(3). We were already using readdir(3) in many places so this is just accepting

[GitHub] trafficserver pull request #1073: TS-4399 TS-4400 Management API messes up p...

2016-10-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1073#discussion_r85870712 --- Diff: mgmt/LocalManager.cc --- @@ -189,6 +189,7 @@ LocalManager::LocalManager(bool proxy_on) : BaseManager(), run_proxy(proxy_on

[GitHub] trafficserver pull request #1073: TS-4399 TS-4400 Management API messes up p...

2016-10-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1073#discussion_r85870674 --- Diff: mgmt/LocalManager.cc --- @@ -902,8 +907,13 @@ LocalManager::startProxy() Vec real_proxy_options

[GitHub] trafficserver pull request #1073: TS-4399 TS-4400 Management API messes up p...

2016-10-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1073#discussion_r85870603 --- Diff: mgmt/api/CoreAPI.cc --- @@ -184,21 +184,19 @@ ProxyStateSet(TSProxyStateT state, TSCacheClearT clear) ink_strlcat(tsArgs, &quo

[GitHub] trafficserver pull request #1112: TS-4977: Prefer nullptr to NULL.

2016-10-28 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1147: TS-4855: Make `const char` consistent acro...

2016-10-26 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1127: [TS-4990] support new apis in ts_lua

2016-10-26 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1127#discussion_r85235598 --- Diff: plugins/experimental/ts_lua/ts_lua_server_request.c --- @@ -755,3 +765,46 @@ ts_lua_server_request_server_addr_get_addr(lua_State *L

[GitHub] trafficserver pull request #1127: [TS-4990] support new apis in ts_lua

2016-10-26 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1127#discussion_r85234779 --- Diff: plugins/experimental/ts_lua/ts_lua_http.c --- @@ -387,6 +411,52 @@ ts_lua_http_set_cache_lookup_url(lua_State *L) } static

  1   2   3   4   5   6   7   >