[GitHub] trafficserver issue #753: Proposal: NetVC Context

2016-07-25 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 @zwoop rebase & clang-format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] trafficserver issue #823: TS-4697: free MIOBuffer if fails on ipallow check.

2016-07-24 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/823 clang-format fixed. @zwoop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-07-28 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r72571589 --- Diff: iocore/net/UnixConnection.cc --- @@ -320,14 +320,15 @@ Connection::connect(sockaddr const *target, NetVCOptions const ) int res

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-07-28 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r72571991 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -1296,7 +1294,7 @@ UnixNetVConnection::connectUp(EThread *t, int fd) } if (fd

[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context

2016-07-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 @bryancall update the enums. ``` NET_VCONNECTION_UNSET, NET_VCONNECTION_IN, // Client <--> ATS, Client-Side NET_VCONNECTION_OUT, // ATS <--> Server,

[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context

2016-07-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 @masaori335 JIRA issue created. BTW what is the proposal review progress ? Is it same as the bug report progress ? create JIRA issue then create PR ? --- If your project is set up

[GitHub] trafficserver issue #823: TS-4697: free MIOBuffer if fails on ipallow check.

2016-08-01 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/823 @jpeach SessionAccept is a interface to create ClientSession. Its mutex is NULL, it is not safe to release any resource. The caller to SessionAccept is Trampline that mutex is copy from NetVC

[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-26 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/771 @bryancall to review the codes of ClusterHandlerBase.cc ``` 979 thread = eventProcessor.eventthread[ET_CLUSTER][id % num_of_cluster_threads]; 980 if (net_vc

[GitHub] trafficserver issue #823: TS-4697: free MIOBuffer if fails on ipallow check.

2016-08-15 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/823 @jpeach Do you means L175 ~ L184 in proxy/http/HttpSessionAccept.h ? ``` 175 /** 176The continuation mutex is NULL to allow parellel accepts in NT. No 177state is recorded

[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-19 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/771#discussion_r71296490 --- Diff: iocore/net/UnixNet.cc --- @@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e) epd = (EventIO *)get_ev_data(pd, x

[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-20 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/771#discussion_r71490427 --- Diff: iocore/net/UnixNet.cc --- @@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e) epd = (EventIO *)get_ev_data(pd, x

[GitHub] trafficserver pull request #766: TS-4614: avoid e->schedule_in for dummy eve...

2016-07-16 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/766#discussion_r71065565 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -1139,8 +1139,8 @@ UnixNetVConnection::mainEvent(int event, Event *e) (write.vio.mutex

[GitHub] trafficserver pull request #766: TS-4614: avoid e->schedule_in for dummy eve...

2016-07-16 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/766#discussion_r71065621 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -1139,8 +1139,8 @@ UnixNetVConnection::mainEvent(int event, Event *e) (write.vio.mutex

[GitHub] trafficserver issue #766: TS-4614: avoid e->schedule_in for dummy event

2016-07-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/766 This is a InactivityCop minor issue. @bryancall --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #823: TS-4697: free MIOBuffer if fails on ipallow check.

2016-08-02 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/823 @jpeach agree with u to return bool from SessionAccept::accept(). SessionAccept did not consume any parameters, It is just transfer parameters to ClientSession. as your said "

[GitHub] trafficserver issue #823: TS-4697: free MIOBuffer if fails on ipallow check.

2016-07-23 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/823 Due to multi types of SessionAccept, I'm change the return type of SessionAccept::accept() from void to int and free the MIOBuffer in ProtocolProbeTrampoline::ioCompletionEvent

[GitHub] trafficserver pull request #823: TS-4697: free MIOBuffer if fails on ipallow...

2016-07-23 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/823 TS-4697: free MIOBuffer if fails on ipallow check. You can merge this pull request into a Git repository by running: $ git pull https://github.com/oknet/trafficserver TS-4697

[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-23 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/771 clang-format is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-23 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/771#discussion_r71972136 --- Diff: iocore/net/UnixNet.cc --- @@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e) epd = (EventIO *)get_ev_data(pd, x

[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-23 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/771 update iocore/cluster/ClusterHandlerBase.cc @bryancall @zwoop but I have no environment to perform cluster system test. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-23 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/771 @bryancall I'm found open_list also used in Cluster. file: iocore/cluster/ClusterHandlerBase.cc ``` 1007 case ClusterHandler::CLCON_CONN_BIND_CLEAR: { 1008

[GitHub] trafficserver pull request #823: TS-4697: free MIOBuffer if fails on ipallow...

2016-08-16 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/823#discussion_r75058577 --- Diff: iocore/net/I_SessionAccept.h --- @@ -29,12 +29,40 @@ struct AclRecord; +/** + The base class SessionAccept can

[GitHub] trafficserver pull request #772: TS-3726: Expose build_error_response

2016-08-18 Thread oknet
Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/772 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #772: TS-3726: Expose build_error_response

2016-08-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/772 @zwoop ok, close this PR and wait for @alhonen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1275: TS-5105: Do vc->con.setRemote(target) before sock...

2017-01-25 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1275 Got it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1345: Crash on retry to open server connection with POS...

2017-01-25 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1345 @bcall Sorry, I'm not familiar with HttpSM. Also I think this issue is covered in the topic that "Kees Spoelstra" described in secur...@trafficserver.apache.org. 20

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-02-11 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1276 Sorry, I'm busy on our product release. I will update this PR recently. 2017-02-11 11:02 GMT+08:00 Phil Sorber <notificati...@github.com>: > @oknet <https://gith

[GitHub] trafficserver issue #1333: PluginVC::inactive_event is not set to NULL after...

2017-01-18 Thread oknet
GitHub user oknet opened an issue: https://github.com/apache/trafficserver/issues/1333 PluginVC::inactive_event is not set to NULL after cancelled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1333: PluginVC::inactive_event is not set to NULL after...

2017-01-18 Thread oknet
Github user oknet closed the issue at: https://github.com/apache/trafficserver/issues/1333 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1334: Do not reschedule the periodic inactive_ev...

2017-01-18 Thread oknet
Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/1334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1345: Crash on retry to open server connection with POS...

2017-01-19 Thread oknet
GitHub user oknet opened an issue: https://github.com/apache/trafficserver/issues/1345 Crash on retry to open server connection with POST transformed content. We have a plugin, it is working on POST transform. ATS crash if a client sent the request: ``` telnet

[GitHub] trafficserver pull request #1334: Do not reschedule the periodic inactive_ev...

2017-01-18 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/1334 Do not reschedule the periodic inactive_event and cancel it after signal timeout event to SM this resolve issue 1333 You can merge this pull request into a Git repository by running

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

2017-01-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1334 Link it to https://issues.apache.org/jira/browse/TS-3235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

2017-01-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1334 The inactive_event is a periodic event that is create by eventProcessor.schedule_every(). We should not reschedule it by schedule_in(). We cancelled it by call_event->cancel() e

[GitHub] trafficserver issue #1326: Core dump in SSLAccept / SSLNetVConnection::sslSe...

2017-01-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1326 I only saw the TS-4363 once and can not repeat it. How about your issue ? Is it repeatable ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1175: socks.config - dest_ip rule issue

2017-01-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1175 I think the message at below indicate your run-time openssl library is different from your build server. ``` /usr/local/lib/libssl.so.8: Undefined symbol

[GitHub] trafficserver issue #863: TS-4750: Fix Connection Leak warnings.

2016-08-15 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/863 @zwoop Looks good to me! @shinrich we are defined too many get_remote_*() method, my suggest is only keep one from get_remote_addr() and get_remote_endpoint() --- If your project is set up

[GitHub] trafficserver issue #701: TS-4522: Should signal SM with EVENT_ERROR on erro...

2016-08-21 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/701 change the assert condition from (r==0) to (r!=0) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-02-27 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1276 There is another bug that related to "proxy.config.socks.default_servers", I will make a backport for TS-5106 to fix it. --- If your project is set up for it, you can reply to

[GitHub] trafficserver issue #1412: Assertion in HttpSM::tunnel_handler_post

2017-02-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1412 and HttpSM::history is needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1509: TS-5106: Create ParentRoundRobin object as...

2017-02-28 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/1509 TS-5106: Create ParentRoundRobin object as ParentRecord->selection_strategy for default parent proxy server (cherry picked from commit 7ffe037845f45497aa9e95919a3a7bc0ca288

[GitHub] trafficserver pull request #1511: heap-use-after-free: Access ua_session aft...

2017-02-28 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/1511 heap-use-after-free: Access ua_session after HttpTunnel::chain_abort_all called due to bad post chunked data You can merge this pull request into a Git repository by running: $ git

[GitHub] trafficserver issue #1412: Assertion in HttpSM::tunnel_handler_post

2017-02-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1412 Can you show me the netvc_context of the UnixNetVConnection ? in order to identify the side of it (client vc or server vc ?) --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #1412: Assertion in HttpSM::tunnel_handler_post

2017-02-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1412 I found a bug related to this issue: HttpSM::state_request_wait_for_transform_read could receive the VC_EVENT_EOS, VC_EVENT_ERROR from TransformTerminus::handle_event and transfer

[GitHub] trafficserver pull request #1510: Crash at HttpSM::state_request_wait_for_tr...

2017-02-28 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/1510 Crash at HttpSM::state_request_wait_for_transform_read In the function, it is try to get int64_t from 'data': int64_t size = *((int64_t)data); But TransformTerminus

[GitHub] trafficserver issue #1510: Crash at HttpSM::state_request_wait_for_transform...

2017-02-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1510 we should always callback EVENT_ERROR or EVENT_EOS with VIO as data value. a nullptr as data is bad idea here. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1510: Crash at HttpSM::state_request_wait_for_transform...

2017-03-01 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1510 @bryancall @zwoop Could you please assign someone to review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass

2017-02-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1472 "TS-3100: Extend tr-pass to allow malformed HTTP GET requests to be blind tunneled." is added by @shinrich . --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

2016-08-31 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r77108646 --- Diff: iocore/net/I_NetVConnection.h --- @@ -566,6 +573,21 @@ class NetVConnection : public VConnection is_transparent = state

[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

2016-08-31 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r77107845 --- Diff: iocore/net/P_SSLNetVConnection.h --- @@ -101,26 +101,13 @@ class SSLNetVConnection : public UnixNetVConnection

[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

2016-08-31 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r77109780 --- Diff: iocore/net/I_NetVConnection.h --- @@ -566,6 +573,21 @@ class NetVConnection : public VConnection is_transparent = state

[GitHub] trafficserver issue #850: TS-4728: Remove invalid LogHost assertion.

2016-09-02 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/850 Should we define LogFile::free() first ? The Ptr::clear() need free() to dealloc the LogFile. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #947: TS-4796 Change UnixNetHandler to always bubble up ...

2016-09-02 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/947 according your description, the HttpTunnel transfers the data from server session to client session, ATS received a RST from client and the connection between ATS and origin server is still

[GitHub] trafficserver issue #947: TS-4796 Change UnixNetHandler to always bubble up ...

2016-09-03 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/947 comments for codes: ``` if (get_ev_events(pd, x) & (EVENTIO_READ | EVENTIO_ERROR)) { // ** set read.triggered if a epoll event of net has EVENTIO_READ or EVENTIO_E

[GitHub] trafficserver pull request #947: TS-4796 Change UnixNetHandler to always bub...

2016-09-05 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/947#discussion_r77499140 --- Diff: iocore/net/UnixNet.cc --- @@ -542,7 +555,14 @@ NetHandler::mainNetEvent(int event, Event *e) close_UnixNetVConnection(vc

[GitHub] trafficserver issue #701: TS-4522: Should signal SM with EVENT_ERROR on erro...

2016-09-01 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/701 Copy bug in load_buffer_and_write() if 0 returned from write() or writev(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #721: TS-4470: ASAN stack-buffer-overflow when sl...

2016-09-01 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/721#discussion_r77122696 --- Diff: proxy/http/HttpSM.cc --- @@ -6890,7 +6890,8 @@ HttpSM::update_stats() int offset = 0; int skip = 0

[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context

2016-09-01 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 Depend on @jpeach's suggestion: - the return type of set_context is void now. - add ink_assert inside set_context() Also: - set NET_VCONNECTION_UNSET to 0 in the enum

[GitHub] trafficserver issue #831: TS-4475: Log Collation Client SM, added VC_EVENT_I...

2016-09-01 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/831 @zwoop @pbchou Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #831: TS-4475: Log Collation Client SM, added VC_...

2016-09-01 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/831#discussion_r77137573 --- Diff: doc/admin-guide/files/records.config.en.rst --- @@ -2703,6 +2703,14 @@ Logging Configuration The number of seconds between

[GitHub] trafficserver issue #947: TS-4796 Change UnixNetHandler to always bubble up ...

2016-09-01 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/947 EVENTIO_ERROR means EPOLLHUP | EPOLLERR | EPOLLPRI. EPOLLPRI means OOB or TCP URG is set. You will always receive EPOLLPRI with EPOLLIN. To EPOLLPRI, we need handle READ first

[GitHub] trafficserver pull request #952: TS-4804: Add r into total_written only if r...

2016-09-01 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/952 TS-4804: Add r into total_written only if r > 0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/oknet/trafficserver TS-4804 Alternativ

[GitHub] trafficserver issue #952: TS-4804: Add r into total_written only if r > 0

2016-09-01 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/952 @zwoop negative means error. man 2 writev: RETURN VALUES Upon successful completion the number of bytes which were written is returned. Otherwise, a -1 is returned

[GitHub] trafficserver issue #947: TS-4796 Change UnixNetHandler to always bubble up ...

2016-09-02 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/947 The InactivityCop will handle those netvc that read or write disabled. InactivityCop will send TIMEOUT to SM or call close_UnixNetVConnection() to close netvc directly depend on the last

[GitHub] trafficserver issue #947: TS-4796 Change UnixNetHandler to always bubble up ...

2016-09-08 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/947 looks good to me. @jpeach, Can you review the finial code ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #831: TS-4475: Log Collation Client SM, added VC_EVENT_I...

2016-09-08 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/831 backport +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

2016-08-29 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/937 @jpeach It is conditional assert on lock check. Do u means keep the if statement and ink_abort inside it ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context

2016-08-30 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 rebase after TS-4779 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #701: TS-4522: Should signal SM with EVENT_ERROR on erro...

2016-09-11 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/701 @jpeach Could you please review this PR? I think this is final version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #947: TS-4796 Change UnixNetHandler to always bub...

2016-09-08 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/947#discussion_r78126177 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc, EThread *thread

[GitHub] trafficserver pull request #947: TS-4796 Change UnixNetHandler to always bub...

2016-09-08 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/947#discussion_r78126610 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc, EThread *thread

[GitHub] trafficserver pull request #947: TS-4796 Change UnixNetHandler to always bub...

2016-09-08 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/947#discussion_r78128086 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc, EThread *thread

[GitHub] trafficserver pull request #947: TS-4796 Change UnixNetHandler to always bub...

2016-09-08 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/947#discussion_r78127044 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc, EThread *thread

[GitHub] trafficserver pull request #947: TS-4796 Change UnixNetHandler to always bub...

2016-09-08 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/947#discussion_r78127251 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc, EThread *thread

[GitHub] trafficserver issue #1068: TS-4920: Consolidate accept socket options.

2016-10-08 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1068 @jpeach Good job! And I have my own thoughts on AcceptOptions optimization, but it is quite basic and rough. 1. class NetVCOptions as base class and defined in iocore/net

[GitHub] trafficserver pull request #1033: TS-4879: Checking con.fd == NO_FD while we...

2016-09-19 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/1033 TS-4879: Checking con.fd == NO_FD while we get return from check_emergency_throttle() You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context

2016-09-19 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 bugfix: In do_blocking_accept(), we should check the con.fd == NO_FD while we get return from check_emergency_throttle(). --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1033: TS-4879: Checking con.fd == NO_FD while we...

2016-09-19 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1033#discussion_r79530800 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -1273,14 +1273,21 @@ UnixNetVConnection::connectUp(EThread *t, int fd) con.is_bound

[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

2016-09-19 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r79531880 --- Diff: iocore/net/UnixNetAccept.cc --- @@ -281,29 +280,30 @@ NetAccept::do_blocking_accept(EThread *t) return -1

[GitHub] trafficserver issue #1033: TS-4879: Checking con.fd == NO_FD while we get re...

2016-09-19 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1033 @jpeach , There is a similar bug in NetAccept::do_blocking_accept() which belongs to ACCEPT side instead of CONNECT side. Should I combine them together in one commit or 2 commits respectively

[GitHub] trafficserver pull request #1033: TS-4879: Checking con.fd == NO_FD while we...

2016-09-19 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1033#discussion_r79531088 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -1273,14 +1273,21 @@ UnixNetVConnection::connectUp(EThread *t, int fd) con.is_bound

[GitHub] trafficserver issue #1033: TS-4879: Checking con.fd == NO_FD while we get re...

2016-09-19 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1033 updated per @jpeach 's comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1033: TS-4879: Checking con.fd == NO_FD while we...

2016-09-19 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1033#discussion_r79530993 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -1273,14 +1273,21 @@ UnixNetVConnection::connectUp(EThread *t, int fd) con.is_bound

[GitHub] trafficserver pull request #1040: TS-4885: Correct the calculation of fds_th...

2016-09-22 Thread oknet
Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/1040 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1033: TS-4879: Checking con.fd == NO_FD while we get re...

2016-09-22 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1033 @jpeach updated upon your comments. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request #1033: TS-4879: Checking con.fd == NO_FD while we...

2016-09-23 Thread oknet
Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/1033 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize

2016-09-23 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/771 @jpeach @bryancall add comments and details in commit message ``` Load the NetVCs from open_list to cop_list before next InactivityCop runs. NetHandler will remove NetVC from cop_list

[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize

2016-09-23 Thread oknet
Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1040: TS-4885: Correct the calculation of fds_th...

2016-09-22 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/1040 TS-4885: Correct the calculation of fds_throttle and fds_limit You can merge this pull request into a Git repository by running: $ git pull https://github.com/oknet/trafficserver TS

[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

2016-09-22 Thread oknet
Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/753 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #947: TS-4796 Change UnixNetHandler to always bub...

2016-09-07 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/947#discussion_r77764403 --- Diff: iocore/net/UnixNet.cc --- @@ -525,7 +531,17 @@ NetHandler::mainNetEvent(int event, Event *e) close_UnixNetVConnection(vc

[GitHub] trafficserver pull request #947: TS-4796 Change UnixNetHandler to always bub...

2016-09-07 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/947#discussion_r77765559 --- Diff: iocore/net/UnixNet.cc --- @@ -525,7 +531,17 @@ NetHandler::mainNetEvent(int event, Event *e) close_UnixNetVConnection(vc

[GitHub] trafficserver issue #701: TS-4522: check EPIPE instead r==0

2016-08-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/701 agree with @jpeach 's comments and code suggestion. With minor modify that only assert on ( r == 0 ) because of (r < 0) means error on write(). --- If your project is set up for it, you

[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize

2016-08-27 Thread oknet
GitHub user oknet reopened a pull request: https://github.com/apache/trafficserver/pull/771 TS-4612: Proposal: InactivityCop Optimize Optimize InactivityCop on a heavy load and high level concurrent connection system. It is set default inactivity timeout before put vc

[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize

2016-08-27 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/771 rebased on master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver pull request #937: TS-2482: Fix Socks Proxy bugs

2016-08-27 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/937 TS-2482: Fix Socks Proxy bugs You can merge this pull request into a Git repository by running: $ git pull https://github.com/oknet/trafficserver TS-2482 Alternatively you can review

[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize

2016-08-27 Thread oknet
Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

2016-08-29 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/937 @zwoop ink_release_assert added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1203: TS-2482: Should use target_addr instead of...

2016-11-06 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/1203 TS-2482: Should use target_addr instead of server_addr when build socks request You can merge this pull request into a Git repository by running: $ git pull https://github.com/oknet

[GitHub] trafficserver issue #1175: socks.config - dest_ip rule issue

2016-11-06 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1175 backport to 6.2.1. 2016-11-04 21:32 GMT+08:00 Christian Haynes <notificati...@github.com>: > Closed #1175 <https://github.com/apache/trafficserver/issues/1175>

  1   2   3   4   >