Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/825#discussion_r72200488
--- Diff: proxy/ProxyClientTransaction.h ---
@@ -211,7 +211,11 @@ class ProxyClientTransaction : public VConnection
virtual bool
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/828
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/792
Thanks @gtenev. @ftarnell can you fix the clang format error (see the linux
build above), and then we can land this.
Thanks!
---
If your project is set up for it, you can reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/796
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/797
The patch seems fine, but I'm a little concerned why those were put in
there to begin with? Obviously some sort of sentinel at some point? As long as
we don't need those, I'm +1
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/792
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/792
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/818
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/771
@bryancall Should we merge this? [approve ci].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/647
@reveller Any update? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/776
@bgaff We should decide what to do here, land this, land your version, or
merge ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/771
@oknet This fails on the clang-format, can you please fix and push an
update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/753
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/821
@mlibbey Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/821
TS-4678 Promotes a few plugins to stable
The following are moved:
authproxy
background_fetch
esi
generator
regex_revalidate
s3_auth
xdebug
You
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/825#discussion_r72022413
--- Diff: proxy/ProxyClientTransaction.h ---
@@ -211,7 +211,11 @@ class ProxyClientTransaction : public VConnection
virtual bool
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/825
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/810
@shinrich I think you linked this to the wrong Jira number? It should be
TS-4679, right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/819
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/821
@mlibbey Yes. Updated, see second commit. (I will squash the commits
before committing)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/624
Status on this PR? Is there a Jira? The branch has conflicts now, and
likely might need a clang-format run as well.
---
If your project is set up for it, you can reply to this email and have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/568
[approve ci] @PSUdaemon @jpeach thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/712
Some minor details here:
1) Update the commit subject message please.
2) It now has marge conflicts, so please rebase, and re-run clang-format as
well.
@ushachar Can you
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/806
I'll look again later, but I don't think so. At least it should work on
more than just the pristine request URL. The intent of these is to support
various types of the URLs for different types
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/832
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/832
Looks good,
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/831
@oknet Can you review this too please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/831
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/833
@maskit Yeh, saw the email now :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/810#discussion_r72265027
--- Diff: iocore/net/SSLUtils.cc ---
@@ -1583,7 +1583,10 @@ SSLInitServerContext(const SSLConfigParams *params,
const ssl_user_config
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/821
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/826
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/810
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/825#discussion_r72140971
--- Diff: proxy/ProxyClientTransaction.h ---
@@ -211,7 +211,11 @@ class ProxyClientTransaction : public VConnection
virtual bool
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/833
Also, even with this being an experimental API, I think we should go
through the normal API review process for this, right?
---
If your project is set up for it, you can reply to this email
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/827
Ah I see, it's because of the multiple commits. Probably should squash this
before push.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/827
Seems the commit message here is sort of missing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/829#discussion_r72558333
--- Diff:
doc/developer-guide/api/functions/TSHttpTxnClientProtocolGet.en.rst ---
@@ -0,0 +1,34 @@
+.. Licensed to the Apache Software Foundation
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/829
Also, please remember to do the normal API review process (emails etc.),
see https://cwiki.apache.org/confluence/display/TS/API+Review+Process .
---
If your project is set up for it, you can
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/837
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/846
Should we land this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/852
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/852
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/851
Ding dong, XML is dead? :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/851
Fwiw, it's running on docs/ci, with the slightly modified squid log that we
use there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/851#discussion_r74513800
--- Diff: proxy/logging/LogConfig.cc ---
@@ -493,14 +494,21 @@ void
LogConfig::setup_log_objects()
{
Debug("log", "c
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/846
I think I see this, we only set current_reader=NULL after that assert,
right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/843#discussion_r74176854
--- Diff: plugins/experimental/carp/CarpConfig.cc ---
@@ -0,0 +1,581 @@
+/** @file
+
+ Loads the CARP configuration
+
+ @section
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/847
I assume is_done is still in use elsewhere.
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/839
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/838
Do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/834
I think I'm ok with this for now, but I really wish we'd done something
similar to TSHttpTxnCacheLookupUrlGet() / TSHttpTxnCacheLookupUrlSet(), but for
the parent selection URL to use. Like
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/776
Maybe @jacksontj can help here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/866#discussion_r74707669
--- Diff: proxy/logging/LogUtils.cc ---
@@ -359,6 +359,23 @@ LogUtils::escapify_url(Arena *arena, char *url, size_t
len_in, int *len_out, cha
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/866#discussion_r74707817
--- Diff: proxy/logging/LogUtils.cc ---
@@ -359,6 +359,23 @@ LogUtils::escapify_url(Arena *arena, char *url, size_t
len_in, int *len_out, cha
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/866#discussion_r74707413
--- Diff: configure.ac ---
@@ -49,7 +49,7 @@ AM_INIT_AUTOMAKE([-Wall -Werror -Wno-portability
tar-ustar foreign no-installinf
AM_MAINTAINER_MODE
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/864
The safer of the two seems to be to honor the last seen header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/863
@oknet Can you take a look at this as well please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/850
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/850
This is likely a back port candidate for 6.2.1 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/849
@bryancall Can you review please, you had some concerns on the previous PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/848#discussion_r74351692
--- Diff: plugins/regex_remap/README ---
@@ -53,11 +54,19 @@ to turn this off use the option 'no-query-string', e.g.
... @pparam=maps.reg @pparam
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/848#discussion_r74351795
--- Diff: plugins/regex_remap/regex_remap.cc ---
@@ -759,15 +761,19 @@ TSRemapNewInstance(int argc, char *argv[], void **ih,
char * /* errbuf ATS_UNUSE
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/848#discussion_r74351870
--- Diff: plugins/regex_remap/regex_remap.cc ---
@@ -759,15 +761,19 @@ TSRemapNewInstance(int argc, char *argv[], void **ih,
char * /* errbuf ATS_UNUSE
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/848
Btw, one slight nit-pick (mostly for future reference): You should keep the
Subject line on the commit to < 50 characters, otherwise (as you can see)
Github does crazy line truncati
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/848
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/862
TS-4691 Removes a bogus assertion which can cause failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4691
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/856
Clang-format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/855
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/855
Needs to run "make clang-format". :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/858
TS-4184 Makes -std=c++11 mandatory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4184
Alternatively you can
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/860
TS-4695 Removes the --enable-cppapi build option
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4695
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/861
TS-4360 Renames NPN_ defines to ALPN_
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4360
Alternatively you can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/862
I already did a while ago ( can't see the Jira right now). ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/795
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/818#discussion_r71722683
--- Diff: lib/ts/tests.cc ---
@@ -19,7 +19,7 @@
limitations under the License.
*/
-#include "ts/TestBox.h"
+#i
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/815
Yeah, like that. Makes you wonder why TSPluginDirGet() was so different
though ... I've had issues before with these APIs, where transfer of ownership
was not clear. I'll take a peek in a bit
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/310
I'm going to close this for now, please open a new PR after we discuss this
more?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/568
Well, this slipped through the net. @danobi Can you please make an update
to the PR, that does not have merge conflicts?
---
If your project is set up for it, you can reply to this email
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/816
I don't speak Vagrant, but this seems reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/588
So, now that we're on the 7.0.0 release cycle, I wonder if we should have
pqhl, cqhl, pshl, and sshl all exclude any @ headers? If not, if we really want
this, don't we also want all 4 variants
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/817
@oschaaf please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/310
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/819
TS-4311 Removes support for SPDY completely
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4311
Alternatively you
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/817
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/804
Almost, but not quite. :) All APIs that are prefixed TS are the public
APIs, and we don't use those in the internal code. Look at the log tags in
logging that uses the internal APIs
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/805
Also, please add some tests to proxy/InkAPITest.cc, see how the existing
tests are done for e.g. TSInstallDirGet.
---
If your project is set up for it, you can reply to this email and have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/802
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/798#discussion_r71084358
--- Diff: plugins/experimental/esi/lib/Variables.cc ---
@@ -357,9 +357,26 @@ Variables::_parseCookieString(const char *str, int
str_len
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/803
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/806
This is a good start, but it's missing a few things (I think at least, been
a while since I looked at this). Look at how the eval() function is handling
the different cases. But at least I
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/805
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/804#discussion_r71084262
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -750,12 +752,10 @@
HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s, HTTPHd
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/798#discussion_r71084383
--- Diff: plugins/experimental/esi/esi.cc ---
@@ -61,6 +61,7 @@ struct OptionInfo {
};
static HandlerManager *gHandlerManager = NULL
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/804#discussion_r71085418
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -750,12 +752,10 @@
HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s, HTTPHd
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/803
Could we use the ats_scoped_obj here? Or some other smart ptr? I'm ok
either way, but maybe we should encourage these smart pointer patterns?
This might change memory management though
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/805
Cool. Can you add a documentation to this too? Either just add a new file,
e.g.
doc/developer-guide/api/functions/TSRuntimeDirGet.en.rst
Or, my personal preference, merge
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/804
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 896 matches
Mail list logo
