Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/807
I wonder if we should move this out of the examples tree? It seems useful
as a debugging tool, and most people probably don't look in examples for useful
tools :).
---
If your project is set
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/808
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/805
Unless @yatsukhnenko also wants to fix the thread safety issue on this, and
all APIs? If not, file another Jira IMO.
---
If your project is set up for it, you can reply to this email and have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/805
Sounds good, can you file a new Jira for these issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/809
+1, although I'm trusting your call here on the internals and changes
already made :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/804
@yatsukhnenko What do you think of a future feature (config) to disable
this Via checking completely? If I know there's not chance of a loop, why
bother checking the Via header? I guess one
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/804
Did a quick test of this, and it looks good:
Via: http/1.1 fedora.ogre.com[f6f5162d-5a02-4d10-ac6e-35aede508fe5]
(ApacheTrafficServer/7.0.0)
---
If your project is set up
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/804
I suspect this failed for other reasons, trying again [approve ci].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/804
I checked the core on this FreeBSD build, and it seems completely unrelated
to pretty much anything :).
```
(gdb) bt
#0 0x in ?? ()
#1 0x006ec34a
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/804
Yeah, file a Jira probably. I could have sworn we've had issues before
where loop detection kicked in when it shouldn't (e.g. you legitimately proxy
to yourself). But I can find an issue
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/804
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/805
@yatsukhnenko As James suggested, can you just add a line or two to
doc/developer-guide/api/functions/TSInstallDirGet.en.rst instead of creating a
new file? This would be my preference as well
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/814
TS-4689 Assert if Machine UUID init fails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4689
Alternatively you
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/814
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/813
TS-4652 Fixes log field initialization, previously crippled
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4652
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/810#discussion_r71376108
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2010,8 +2013,9 @@ ssl_extract_certificate(const matcher_line
*line_info, ssl_user_config
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/805
Great, thanks! [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/805
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/813
Let me take a look, but I was going for the simplest solution that works,
with minimal risk. It's pretty finicky on the order :)
---
If your project is set up for it, you can reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/815
Interesting, so e.g.
static char *runtimedir = RecConfigReadRuntimeDir();
would be thread safe. That seems like a no-brainer to me :). +1
---
If your project is set
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/813
Ah, yeah, I'm pretty sure that entire if() can be safely eliminated (famous
last words ...).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/813
@jpeach @bryancall check the update please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/815
If I understand C++ at all, I don't think that example is thread safe? But,
moving it outside (file scope) would be. No?
---
If your project is set up for it, you can reply to this email
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/815
Gotcha. Well, you showed me C++11 has this requirement for thread safety,
and we've said that v7.0.0 will require C++11 support, so +1 on that.
---
If your project is set up for it, you can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/815
@jpeach Wdyt? Would TLS make more sense here? It would duplicate those
static strings, but avoids locks, no ?
---
If your project is set up for it, you can reply to this email and have your
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/817
TS-4667 Uses the WKS in the gzip plugin
Instead of just using strings, like "deflate". Albeit, it's functionally
the same, this is a bad pattern that we should discourage (using
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/818
TS-4683 Adds better error handling on config problems
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4683
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/644
Aww, don't close it. I don't think anything absolutely wrong here, we
should land this. There are things that needs to be fixed, but they are pretty
minor (like, squashing, clang-format, typos
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/792
[approve ci]
@gtenev Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/803
This fails on clang-format, please re-run and push --force.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/803
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/804
It's an inefficiency for starters (you go through a C-> C++ wrapper layer,
for no good reason (remember, the public APIs are all C, whereas in the core,
you can use all the C++ obje
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/644
Hmmm, well, if it doesn't work, then it's a moot point. I know people have
implemented rate limiting in plugins, it was just never open sourced. If you
don't feel strongly about it, closing
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/840
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/841
Wonder if there's some easy way to add this check to the synthetic server
(i.e. the regressions as run with traffic_server -R 1)? Also, this might be a
back port candidate for 6.2.x (our
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/845
For @PSUdaemon .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/836
Weird:
REGRESSION TEST SDK_API_OVERRIDABLE_CONFIGS started
FATAL: InkAPI.cc:8354: failed assertion
`sdk_sanity_check_null_ptr((void *)name) == TS_SUCCESS
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/837
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jrushford Please review. [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/833
Trying another build, for some reason builds are not stable now [approve
ci].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/823
Certainly seems reasonable to me. [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/822
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/701
@oknet How do you want to proceed with this? Are you making an update to
the PR to address some of the review suggestions?
---
If your project is set up for it, you can reply to this email
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/771
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/823
@oknet This failed clang-format, please fix and push update :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/822
Cool. Couple of things:
1) Please email dev@ with a short description for the API proposal. For
some details on the process of adding new APIs, see
https://cwiki.apache.org/confluence
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/766
@shinrich Should we land this? Also, is this a back port candidate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/753
@shinrich Should we continue with this PR? @oknet there are now merge
conflicts, can you please rebase (and remember to re-run clang-format too :).
---
If your project is set up for it, you
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/802
@alhonen Thoughts on the concerns from James?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/769
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/819#discussion_r71749709
--- Diff: lib/ts/ink_config.h.in ---
@@ -127,5 +127,6 @@
#define TS_BUILD_CANONICAL_HOST "@host@"
#define TS_BUILD_DEFAULT_LOOP
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/818
Made the changes per Gancho's suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/815
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/870
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/859
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/868
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/862
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/858
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/860
Sigh, freebsd regression arbitrarily failed it seems ... try again [approve
ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/867
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/861
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/863
@shinrich Lets do it! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/869
I'm +1 on this, would be curious if the original Jira poster can / have
verify ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/866
@maskit Are you saying the patch as is is not good / sufficient?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/644
I'm not sure if anyone has had the cycles to help debug this :-/ It might
be worth emailing dev@ with a concrete question / request for help.
---
If your project is set up for it, you can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1397
Hmmm, not sure, it is for me:
```
[root@fedora ats]# ldd bin/traffic_top | grep -i hwloc
libhwloc.so.5 => /lib64/libhwloc.so.5 (0x7f29395a7000)
```
Tha
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1418
Consistently use ink_atoi() (or one of the equivalent functions we provide)
(This is moved from https://issues.apache.org/jira/browse/TS-1773).
Right now, we have a hotchpotch of various
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1407
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1408#discussion_r99240250
--- Diff: iocore/cache/Cache.cc ---
@@ -1041,12 +1041,12 @@ CacheProcessor::cacheInitialized()
case CACHE_COMPRESSION_FASTLZ
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1404
Looks great. Two issues:
1) Run clang-format on it :).
2) On FreeBSD, it fails with
```
../../plugins/experimental/ts_lua/ts_lua_http_config.c:244:53: error
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1404
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1401
you didn't see this crasher in 7.0.0 right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1402
If possible, can you test with 7.0 or 7.1x (branch) and see if it happens
there too ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1388
[approve ci] to get the clang-analyzer build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1388
@jablko do we need two commits here? Or can they be squashed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1381
This still has
1) clang-format issues
2) Compile issues:
```
In file included from ../../../lib/ts/test_Scalar.cc:24:
/var/jenkins/workspace/freebsd-github
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1335
@randall reports that this happens with sync off as well :-/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1415
Oh yeah, if this is not a back port from master, then this should be
changed / closed, and replaced with a PR against master. We always commit on
master, and then suggest back ports to the RMs
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1415
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1415
You can ignore the clang-analyzer build failures, since 6.2.x branch is
busted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1392
Should we land this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1421
@jacksontj Ping on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1421
Segmentation fault on TLS when destination server issues Reset
Creating this issue, copying from the original Jira to capture all the
details.
On HEAD as of 16DEC2016
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1357
@SolidWallOfCode Ping? Also, seems this needs to be rebased now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1420#discussion_r99900589
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -615,10 +618,14 @@ LogBuffer::resolve_custom_entry(LogFieldList
*fieldlist, char *printf_str, char
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1422
@SolidWallOfCode Is this something you feel comfortable with, and should be
a 7.1.x back port?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1412
Assertion in HttpSM::tunnel_handler_post
I think we've seen this before, but filing this again to make sure I don't
lose the info:
```
(gdb) bt
#0 0x74fed1d7
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1408#discussion_r99174413
--- Diff: iocore/cache/Cache.cc ---
@@ -1041,12 +1041,12 @@ CacheProcessor::cacheInitialized()
case CACHE_COMPRESSION_FASTLZ
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1409
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1398
Testing to see if clang-analyzer builds triggers [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1404#discussion_r98966326
--- Diff: proxy/http/HttpTransact.cc ---
@@ -6487,9 +6487,15 @@ HttpTransact::is_request_valid(State *s, HTTPHdr
*incoming_request)
bool
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1357
@SolidWallOfCode Is this going to go in for 7.1.x ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop closed the issue at:
https://github.com/apache/trafficserver/issues/1403
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1400
Testing again [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1400
Testing again [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1403
Closing, since we have a PR already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1404#discussion_r99178025
--- Diff: proxy/http/HttpTransact.cc ---
@@ -6487,9 +6487,15 @@ HttpTransact::is_request_valid(State *s, HTTPHdr
*incoming_request)
bool
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1404
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1401
Are you getting a core file / backtrace ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1398
Testing to see if clang-analyzer builds triggers [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
101 - 200 of 896 matches
Mail list logo
