[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r172439014 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileChannelBacking

Jenkins build is back to stable : bookkeeper_release_nightly_snapshot #86

See

[GitHub] sijie opened a new pull request #1231: Dont shade netty at distributedlog-core-shaded

sijie opened a new pull request #1231: Dont shade netty at distributedlog-core-shaded URL: https://github.com/apache/bookkeeper/pull/1231 Descriptions of the changes in this PR: *Problem* JVM crashed when `distributedlog-core-shaded` (where netty was shaded) is used in a proj

[GitHub] ivankelly commented on issue #1201: (DRAFT/RFC/DONOTMERGE) ISSUE #570: Entrylog per ledger

ivankelly commented on issue #1201: (DRAFT/RFC/DONOTMERGE) ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#issuecomment-370706908 I usually use WIP This is an automated message from the Apa

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172443006 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172447253 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFacto

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172447036 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.

[GitHub] sijie opened a new issue #1232: cherry-pick #1230 to branch 4.6.

sijie opened a new issue #1232: cherry-pick #1230 to branch 4.6. URL: https://github.com/apache/bookkeeper/issues/1232 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sijie commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

sijie commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172454534 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java

[GitHub] sijie commented on issue #1231: Dont shade netty at distributedlog-core-shaded

sijie commented on issue #1231: Dont shade netty at distributedlog-core-shaded URL: https://github.com/apache/bookkeeper/pull/1231#issuecomment-370719700 IGNORE CI This is an automated message from the Apache Git Service. To r

[GitHub] sijie commented on issue #1231: Dont shade netty at distributedlog-core-shaded

sijie commented on issue #1231: Dont shade netty at distributedlog-core-shaded URL: https://github.com/apache/bookkeeper/pull/1231#issuecomment-370719670 travis and IT passed. since this change is only touch the dlog shaded jar, ignore CI results to merge this, allowing to unblock pulsar.

[GitHub] sijie closed pull request #1231: Dont shade netty at distributedlog-core-shaded

sijie closed pull request #1231: Dont shade netty at distributedlog-core-shaded URL: https://github.com/apache/bookkeeper/pull/1231 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172461503 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChanne

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172460039 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bo

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172461173 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bo

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172460269 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bo

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172459536 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bo

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172463549 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.

[GitHub] reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172470978 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChanne

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172481464 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172483093 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172483645 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172492072 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bo

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172492593 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bo

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172493072 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bo

[GitHub] ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370758791 @reddycharan test is failing. Saying that flush task was cancelled. I don't see how that can be

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172496811 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.

[GitHub] ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370765608 ``` 2018-03-06 01:43:23,095 - INFO - [main:ScanAndCompareGarbageCollector@103] - Over Replic

[GitHub] reddycharan commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370768691 this is little surprising. We are seeing cancellationexception because time given for the exec

[GitHub] reddycharan commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370773398 hmm..I'm able to run successfully 64 times in loop on my machine (MacbookPro), wondering if th

[GitHub] ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370785040 > When time has elapsed, the pending tasks are cancelled. It seems it infact waited for 6 second

Jenkins build became unstable: bookkeeper_postcommit_master_java9 #62

See

Jenkins build became unstable: bookkeeper_release_nightly_snapshot #89

See

[GitHub] ivankelly opened a new pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop

ivankelly opened a new pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop URL: https://github.com/apache/bookkeeper/pull/1233 This test has flaked in CI regularly mainly because it takes a long time to run. This changes reduces the running time by.

[GitHub] ivankelly commented on issue #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop

ivankelly commented on issue #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop URL: https://github.com/apache/bookkeeper/pull/1233#issuecomment-370844399 @reddycharan I tried to add you as a reviewer to this, but it wouldn't find your name. Are you in the apache org in g

[GitHub] reddycharan commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370931409 yes, testcase must has failed because of timeout issue. Locally on my MacbookPro (using SSD) (

[GitHub] sijie opened a new pull request #1234: Make shading rule consistent between bookkeeper-server-shaded and bookkeeper-server-tests-shaded

sijie opened a new pull request #1234: Make shading rule consistent between bookkeeper-server-shaded and bookkeeper-server-tests-shaded URL: https://github.com/apache/bookkeeper/pull/1234 Descriptions of the changes in this PR: `bookkeeper-server:test-jar` is working with `bookke

[GitHub] sijie closed pull request #1234: Make shading rule consistent between bookkeeper-server-shaded and bookkeeper-server-tests-shaded

sijie closed pull request #1234: Make shading rule consistent between bookkeeper-server-shaded and bookkeeper-server-tests-shaded URL: https://github.com/apache/bookkeeper/pull/1234 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed b

Jenkins build is back to stable : bookkeeper_release_nightly_snapshot #90

See

[GitHub] reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop

reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop URL: https://github.com/apache/bookkeeper/pull/1233#discussion_r172747594 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLed

[GitHub] reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop

reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop URL: https://github.com/apache/bookkeeper/pull/1233#discussion_r172747788 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLed

[GitHub] reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop

reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop URL: https://github.com/apache/bookkeeper/pull/1233#discussion_r172749487 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLed

[GitHub] reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop

reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop URL: https://github.com/apache/bookkeeper/pull/1233#discussion_r172752790 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLed

[GitHub] reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop

reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop URL: https://github.com/apache/bookkeeper/pull/1233#discussion_r172753303 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLed

[GitHub] reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop

reddycharan commented on a change in pull request #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop URL: https://github.com/apache/bookkeeper/pull/1233#discussion_r172754140 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLed

[GitHub] reddycharan commented on issue #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop

reddycharan commented on issue #1233: Reduce running time for testLedgerCreateAdvWithLedgerIdInLoop URL: https://github.com/apache/bookkeeper/pull/1233#issuecomment-371052207 > @reddycharan I tried to add you as a reviewer to this, but it wouldn't find your name. Are you in the apache org