[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-03-19 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062769#comment-17062769 ] Ruben Q L commented on CALCITE-3285: Fixed via

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-03-16 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060036#comment-17060036 ] Ruben Q L commented on CALCITE-3285: Recap: [PR#1788|https://github.com/apache/calcite/pull/1788]

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-03-11 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056997#comment-17056997 ] Ruben Q L commented on CALCITE-3285: [~zabetak], thanks for your comment. I have no problem in

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-03-11 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056845#comment-17056845 ] Stamatis Zampetakis commented on CALCITE-3285: -- Everybody in this discussion seem to agree

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-03-10 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055777#comment-17055777 ] Ruben Q L commented on CALCITE-3285: Could we please re-consider merging

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-02-06 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031700#comment-17031700 ] Ruben Q L commented on CALCITE-3285: [~vladimirsitnikov], I understand your point. But even when /

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-02-06 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031687#comment-17031687 ] Vladimir Sitnikov commented on CALCITE-3285: The API you add does not leave room for

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-02-06 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031633#comment-17031633 ] Ruben Q L commented on CALCITE-3285: Thanks for your reply [~vladimirsitnikov]. The solution that

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-02-06 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031626#comment-17031626 ] Vladimir Sitnikov commented on CALCITE-3285: [~rubenql], does 

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-02-06 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031602#comment-17031602 ] Ruben Q L commented on CALCITE-3285: Hello guys, I have given this another try, with a simple

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-10 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012721#comment-17012721 ] Vladimir Sitnikov commented on CALCITE-3285: Reverted in

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010004#comment-17010004 ] Julian Hyde commented on CALCITE-3285: -- {quote}The sad thing is there's no clear way to prevent

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-07 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009530#comment-17009530 ] Vladimir Sitnikov commented on CALCITE-3285: {quote} What if we return infinite cost in

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-07 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009487#comment-17009487 ] Ruben Q L commented on CALCITE-3285: What if we return infinite cost in

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-06 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009405#comment-17009405 ] Vladimir Sitnikov commented on CALCITE-3285: The sad thing is there's no clear way to

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009375#comment-17009375 ] Haisheng Yuan commented on CALCITE-3285: If we change to mergeJoin(...).where(...), why don't

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-03 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007899#comment-17007899 ] Jin Xing commented on CALCITE-3285: --- Hi, [~vladimirsitnikov] ~ Thanks a lot for the fix PR-1702 ~ Now

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007796#comment-17007796 ] Haisheng Yuan commented on CALCITE-3285: [~vladimirsitnikov] I checked your fix at

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-03 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007788#comment-17007788 ] Julian Hyde commented on CALCITE-3285: -- In order to increase the capabilities of

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-02 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006842#comment-17006842 ] Jin Xing commented on CALCITE-3285: --- Hi [~vladimirsitnikov] Yes, you are right, it's a bug. I filed a

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-02 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006820#comment-17006820 ] Jin Xing commented on CALCITE-3285: --- Thanks for ping me [~vladimirsitnikov] I will verify soon ~ >

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-01 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006383#comment-17006383 ] Vladimir Sitnikov commented on CALCITE-3285: [~jinxing6...@126.com], [~hyuan] it looks like