[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60799066 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254608#comment-15254608 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1911#issuecomment-213581650 Regarding the Jackson / dependency issue: You don't need to worry about it know. I'll take another look at the problem and make sure it'll work once we merge it. ---

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60799474 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60799388 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java ---

[jira] [Updated] (FLINK-3753) KillerWatchDog should not use kill on toKill thread

2016-04-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-3753: -- Description: {code} // this is harsh, but this watchdog is a last resort if (toKill.isAlive()) {

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254633#comment-15254633 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on the pull request:

[jira] [Commented] (FLINK-1746) Add linear discriminant analysis to machine learning library

2016-04-22 Thread Ronak Nathani (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255146#comment-15255146 ] Ronak Nathani commented on FLINK-1746: -- Thanks [~till.rohrmann]! Look forward to working on this! :)

[jira] [Commented] (FLINK-1743) Add multinomial logistic regression to machine learning library

2016-04-22 Thread David E Drummond (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254984#comment-15254984 ] David E Drummond commented on FLINK-1743: - Thanks for the warm welcome [~trohrm...@apache.org]!

[jira] [Commented] (FLINK-3669) WindowOperator registers a lot of timers at StreamTask

2016-04-22 Thread Konstantin Knauf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253557#comment-15253557 ] Konstantin Knauf commented on FLINK-3669: - Aljoscha, could you have a look at

[GitHub] flink pull request: [FLINK-3800] [jobmanager] Terminate ExecutionG...

2016-04-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1923#issuecomment-213288408 Good fix, Till! Changes look good, +1 to merge soon for 1.0.3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Updated] (FLINK-3701) Cant call execute after first execution

2016-04-22 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-3701: -- Fix Version/s: 1.1.0 > Cant call execute after first execution >

[jira] [Updated] (FLINK-3701) Cant call execute after first execution

2016-04-22 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-3701: -- Affects Version/s: 1.1.0 > Cant call execute after first execution >

[jira] [Assigned] (FLINK-3793) Re-organize the Table API and SQL docs

2016-04-22 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-3793: Assignee: Vasia Kalavri > Re-organize the Table API and SQL docs >

[jira] [Commented] (FLINK-3800) ExecutionGraphs can become orphans

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253449#comment-15253449 ] ASF GitHub Bot commented on FLINK-3800: --- Github user uce commented on the pull request:

[GitHub] flink pull request: FunctionAnnotation example should match docs

2016-04-22 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1925#issuecomment-213315680 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Updated] (FLINK-1749) Add Boosting algorithm for ensemble learning to machine learning library

2016-04-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-1749: - Assignee: (was: narayana reddy) > Add Boosting algorithm for ensemble learning to machine

[jira] [Commented] (FLINK-3800) ExecutionGraphs can become orphans

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253584#comment-15253584 ] ASF GitHub Bot commented on FLINK-3800: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

2016-04-22 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1903#discussion_r60728363 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/InputFormatVertex.java --- @@ -64,13 +65,19 @@ public void

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253806#comment-15253806 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in the pull request:

[jira] [Commented] (FLINK-3777) Add open and close methods to manage IF lifecycle

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253807#comment-15253807 ] ASF GitHub Bot commented on FLINK-3777: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-04-22 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1916#discussion_r60728312 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -199,12 +151,12 @@ class Table( *

[jira] [Commented] (FLINK-1749) Add Boosting algorithm for ensemble learning to machine learning library

2016-04-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253589#comment-15253589 ] Till Rohrmann commented on FLINK-1749: -- Hi [~dedrummond], I think Narayana is no longer working on

[jira] [Commented] (FLINK-3669) WindowOperator registers a lot of timers at StreamTask

2016-04-22 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253666#comment-15253666 ] Aljoscha Krettek commented on FLINK-3669: - Hi, it's almost done but I think we need both the

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60726049 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253808#comment-15253808 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on a diff in the pull request:

[jira] [Commented] (FLINK-3669) WindowOperator registers a lot of timers at StreamTask

2016-04-22 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253601#comment-15253601 ] Aljoscha Krettek commented on FLINK-3669: - I'm checking it out. > WindowOperator registers a lot

[jira] [Created] (FLINK-3803) Checkpoint Stats Tracker Reads from Wrong Configuration

2016-04-22 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-3803: --- Summary: Checkpoint Stats Tracker Reads from Wrong Configuration Key: FLINK-3803 URL: https://issues.apache.org/jira/browse/FLINK-3803 Project: Flink

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-04-22 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/1916#discussion_r60728611 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -0,0 +1,188 @@ +/* + * Licensed

[jira] [Created] (FLINK-3804) Update YARN documentation

2016-04-22 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-3804: Summary: Update YARN documentation Key: FLINK-3804 URL: https://issues.apache.org/jira/browse/FLINK-3804 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-1729) Assess performance of classification algorithms

2016-04-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253665#comment-15253665 ] Till Rohrmann commented on FLINK-1729: -- Hi [~h...@insightdatascience.com], great to hear that you

[jira] [Updated] (FLINK-1729) Assess performance of classification algorithms

2016-04-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-1729: - Assignee: hoa nguyen (was: Till Rohrmann) > Assess performance of classification algorithms >

[jira] [Assigned] (FLINK-1729) Assess performance of classification algorithms

2016-04-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-1729: Assignee: Till Rohrmann > Assess performance of classification algorithms >

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

2016-04-22 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1903#issuecomment-213399764 Hi @fpompermaier, I thought about this again. I don't think it is a good idea to tie `closeInputFormat()` to `configure()` because `configure()` is called at different

[jira] [Commented] (FLINK-3777) Add open and close methods to manage IF lifecycle

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253820#comment-15253820 ] ASF GitHub Bot commented on FLINK-3777: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3800] [jobmanager] Terminate ExecutionG...

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1923#issuecomment-213346413 Maybe I have to increase the timeout for Travis here. Will do it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3800) ExecutionGraphs can become orphans

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253597#comment-15253597 ] ASF GitHub Bot commented on FLINK-3800: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

2016-04-22 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1903#discussion_r60728010 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/DataSourceNode.java --- @@ -187,6 +194,10 @@ else if (len >= 0) {

[jira] [Commented] (FLINK-3777) Add open and close methods to manage IF lifecycle

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253801#comment-15253801 ] ASF GitHub Bot commented on FLINK-3777: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

2016-04-22 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1903#discussion_r60727958 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/DataSourceNode.java --- @@ -150,6 +151,12 @@ protected void

[jira] [Updated] (FLINK-1743) Add multinomial logistic regression to machine learning library

2016-04-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-1743: - Assignee: David E Drummond (was: Ozturk Gokal) > Add multinomial logistic regression to machine

[jira] [Commented] (FLINK-1743) Add multinomial logistic regression to machine learning library

2016-04-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253594#comment-15253594 ] Till Rohrmann commented on FLINK-1743: -- I haven't seen any updates on this issue for a long time.

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253779#comment-15253779 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3800] [jobmanager] Terminate ExecutionG...

2016-04-22 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1923#issuecomment-213342621 Code looks good. It seems that the test is still a bit unstable: ``` Tests in error: LeaderChangeJobRecoveryTest.before:73 » Timeout Futures timed

[jira] [Commented] (FLINK-3669) WindowOperator registers a lot of timers at StreamTask

2016-04-22 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253604#comment-15253604 ] Aljoscha Krettek commented on FLINK-3669: - Btw, in the future if you reference me like this

[jira] [Commented] (FLINK-1746) Add linear discriminant analysis to machine learning library

2016-04-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253654#comment-15253654 ] Till Rohrmann commented on FLINK-1746: -- Hi [~ronaknnath...@gmail.com], great to hear that you want

[jira] [Updated] (FLINK-1746) Add linear discriminant analysis to machine learning library

2016-04-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-1746: - Assignee: Ronak Nathani (was: Raghav Chalapathy) > Add linear discriminant analysis to machine

[jira] [Closed] (FLINK-3072) DbStateBackendTest

2016-04-22 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-3072. - Resolution: Invalid > DbStateBackendTest > -- > > Key: FLINK-3072 >

[jira] [Closed] (FLINK-3193) Add optional bloomfilter to sql state backend

2016-04-22 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-3193. - Resolution: Invalid > Add optional bloomfilter to sql state backend >

[GitHub] flink pull request: FunctionAnnotation example should match docs

2016-04-22 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1925#issuecomment-213371505 Thanks for the fix @NathanHowell. Good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-3777) Add open and close methods to manage IF lifecycle

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253802#comment-15253802 ] ASF GitHub Bot commented on FLINK-3777: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253868#comment-15253868 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60733038 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60738627 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60739128 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala --- @@ -0,0 +1,73 @@ +/* + * Licensed

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253932#comment-15253932 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60731025 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253836#comment-15253836 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253835#comment-15253835 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2157] [ml] Create evaluation framework ...

2016-04-22 Thread rawkintrevo
Github user rawkintrevo commented on the pull request: https://github.com/apache/flink/pull/1849#issuecomment-213411019 The transformer needs to scale the label too... I might not be correctly understanding your last paragraph / what you are proposing. I agree with paragraph

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253889#comment-15253889 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation

2016-04-22 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253888#comment-15253888 ] Greg Hogan commented on FLINK-3618: --- This looks to be a simple change with no dissension, but is

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60735615 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60737947 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253913#comment-15253913 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60737984 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253937#comment-15253937 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60739509 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala --- @@ -0,0 +1,73 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1898#issuecomment-213434810 Thanks for your contribution @rawkintrevo. Good work. I had some minor inline comments. I'm mainly concerned about the efficiency of `multiRandomSplit` because it

[jira] [Commented] (FLINK-2828) Add interfaces for Table API input formats

2016-04-22 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253841#comment-15253841 ] Fabian Hueske commented on FLINK-2828: -- I started with the implementation of the {{TableRef}} design

[jira] [Assigned] (FLINK-2828) Add interfaces for Table API input formats

2016-04-22 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-2828: Assignee: Fabian Hueske (was: Timo Walther) > Add interfaces for Table API input formats

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253843#comment-15253843 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60732321 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java ---

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253856#comment-15253856 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60732384 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java ---

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253886#comment-15253886 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60736953 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253903#comment-15253903 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253911#comment-15253911 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60739818 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253943#comment-15253943 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253954#comment-15253954 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on the pull request:

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253857#comment-15253857 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60732457 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253858#comment-15253858 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60733595 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253870#comment-15253870 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253920#comment-15253920 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60738393 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60738251 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60738935 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala --- @@ -0,0 +1,73 @@ +/* + * Licensed

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253927#comment-15253927 ] ASF GitHub Bot commented on FLINK-2259: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3708] Scala API for CEP (initial).

2016-04-22 Thread StefanRRichter
Github user StefanRRichter commented on the pull request: https://github.com/apache/flink/pull/1905#issuecomment-213443445 The current version should cover all of your feedback and could be pulled @tillrohrmann . --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253838#comment-15253838 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3229) Kinesis streaming consumer with integration of Flink's checkpointing mechanics

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253839#comment-15253839 ] ASF GitHub Bot commented on FLINK-3229: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-22 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1911#issuecomment-213407614 I could not get the example to work with the current jackson version. Only after upgrading it to `2.7.3` it was working. Did you test the kinesis consumer using a

[jira] [Commented] (FLINK-3754) Add a validation phase before construct RelNode using TableAPI

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253850#comment-15253850 ] ASF GitHub Bot commented on FLINK-3754: --- Github user yjshen commented on the pull request:

[jira] [Commented] (FLINK-2157) Create evaluation framework for ML library

2016-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253849#comment-15253849 ] ASF GitHub Bot commented on FLINK-2157: --- Github user rawkintrevo commented on the pull request:

[GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...

2016-04-22 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/flink/pull/1916#issuecomment-213411425 For ease of review, I would like to explain this RP with more details. While table api are called to construct a query, it was first constructed as a operator

[GitHub] flink pull request: [FLINK-2259][ml] Add Train-Testing Splitters

2016-04-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1898#discussion_r60732832 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to

  1   2   >