[jira] [Created] (FLINK-3968) Cancel button on a running job not available on smaller screens

2016-05-24 Thread Lokesh Ravindranathan (JIRA)
Lokesh Ravindranathan created FLINK-3968: Summary: Cancel button on a running job not available on smaller screens Key: FLINK-3968 URL: https://issues.apache.org/jira/browse/FLINK-3968

[jira] [Updated] (FLINK-3968) Cancel button on a running job not available on smaller screens

2016-05-24 Thread Lokesh Ravindranathan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Ravindranathan updated FLINK-3968: - Description: I am using a Mac with Chrome as my browser. I run a Flink job and

[jira] [Updated] (FLINK-3968) Cancel button on a running job not available on smaller screens

2016-05-24 Thread Lokesh Ravindranathan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Ravindranathan updated FLINK-3968: - Description: I am using a Mac with Chrome as my browser. I run a Flink job and

[GitHub] flink pull request: [FLINK-3586] Fix potential overflow of Long AV...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2024#issuecomment-221477372 I would like to merge this later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-3586) Risk of data overflow while use sum/count to calculate AVG value

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299487#comment-15299487 ] ASF GitHub Bot commented on FLINK-3586: --- Github user fhueske commented on the pull request:

[jira] [Created] (FLINK-3967) Provide RethinkDB Sink for Flink

2016-05-24 Thread Mans Singh (JIRA)
Mans Singh created FLINK-3967: - Summary: Provide RethinkDB Sink for Flink Key: FLINK-3967 URL: https://issues.apache.org/jira/browse/FLINK-3967 Project: Flink Issue Type: New Feature

[GitHub] flink pull request: FLINK-3967 - Flink Streaming Sink for Rethink ...

2016-05-24 Thread mans4singh
GitHub user mans4singh opened a pull request: https://github.com/apache/flink/pull/2030 FLINK-3967 - Flink Streaming Sink for Rethink Db Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[jira] [Commented] (FLINK-3967) Provide RethinkDB Sink for Flink

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299282#comment-15299282 ] ASF GitHub Bot commented on FLINK-3967: --- GitHub user mans4singh opened a pull request:

[jira] [Commented] (FLINK-3967) Provide RethinkDB Sink for Flink

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299295#comment-15299295 ] ASF GitHub Bot commented on FLINK-3967: --- Github user mans4singh closed the pull request at:

[GitHub] flink pull request: FLINK-3967 - Flink Streaming Sink for Rethink ...

2016-05-24 Thread mans4singh
Github user mans4singh closed the pull request at: https://github.com/apache/flink/pull/2030 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: FLINK-3967 - Flink Sink for Rethink Db

2016-05-24 Thread mans2singh
GitHub user mans2singh opened a pull request: https://github.com/apache/flink/pull/2031 FLINK-3967 - Flink Sink for Rethink Db Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes

[jira] [Commented] (FLINK-3967) Provide RethinkDB Sink for Flink

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299296#comment-15299296 ] ASF GitHub Bot commented on FLINK-3967: --- GitHub user mans2singh opened a pull request:

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-24 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-221452144 @vasia fixed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-2044) Implementation of Gelly HITS Algorithm

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299312#comment-15299312 ] ASF GitHub Bot commented on FLINK-2044: --- Github user gallenvara commented on the pull request:

[GitHub] flink pull request: [FLINK-3728] [tableAPI] Improve error message ...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2018#issuecomment-221179326 Will merge this later today, unless somebody objects. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-3728] [tableAPI] Improve error message ...

2016-05-24 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/2018#issuecomment-221185294 Also looks good! +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-3955) Change Table.toSink() to Table.writeToSink()

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297766#comment-15297766 ] ASF GitHub Bot commented on FLINK-3955: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3955] [tableAPI] Rename Table.toSink() ...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2023#issuecomment-221179338 Will merge this later today, unless somebody objects. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-3728) Throw meaningful exceptions for unsupported SQL features

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297765#comment-15297765 ] ASF GitHub Bot commented on FLINK-3728: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2025#issuecomment-221186678 Thanks for the PR, @yjshen. Looks good except for a few minor comments. Can you also add one test method to the Scala SQL UnionITCase, such that the SQL side is also

[jira] [Commented] (FLINK-3941) Add support for UNION (with duplicate elimination)

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297823#comment-15297823 ] ASF GitHub Bot commented on FLINK-3941: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3728] [tableAPI] Improve error message ...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2018#issuecomment-221186713 Thanks :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3728) Throw meaningful exceptions for unsupported SQL features

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297854#comment-15297854 ] ASF GitHub Bot commented on FLINK-3728: --- Github user fhueske commented on the pull request:

[jira] [Commented] (FLINK-3955) Change Table.toSink() to Table.writeToSink()

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297853#comment-15297853 ] ASF GitHub Bot commented on FLINK-3955: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3955] [tableAPI] Rename Table.toSink() ...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2023#issuecomment-221191467 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3728] [tableAPI] Improve error message ...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2018#issuecomment-221191485 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3941) Add support for UNION (with duplicate elimination)

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297806#comment-15297806 ] ASF GitHub Bot commented on FLINK-3941: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3728) Throw meaningful exceptions for unsupported SQL features

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297824#comment-15297824 ] ASF GitHub Bot commented on FLINK-3728: --- Github user fhueske commented on the pull request:

[jira] [Commented] (FLINK-3955) Change Table.toSink() to Table.writeToSink()

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297803#comment-15297803 ] ASF GitHub Bot commented on FLINK-3955: --- Github user vasia commented on the pull request:

[GitHub] flink pull request: [FLINK-3955] [tableAPI] Rename Table.toSink() ...

2016-05-24 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/2023#issuecomment-221184374 +1 looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3941) Add support for UNION (with duplicate elimination)

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297815#comment-15297815 ] ASF GitHub Bot commented on FLINK-3941: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3728) Throw meaningful exceptions for unsupported SQL features

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297812#comment-15297812 ] ASF GitHub Bot commented on FLINK-3728: --- Github user vasia commented on the pull request:

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2025#discussion_r64338444 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/table/UnionITCase.java --- @@ -43,7 +43,7 @@ public

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-221188902 No worries and thanks @dawidwys! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-3728] [tableAPI] Improve error message ...

2016-05-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2018 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3955) Change Table.toSink() to Table.writeToSink()

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297924#comment-15297924 ] ASF GitHub Bot commented on FLINK-3955: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-3728) Throw meaningful exceptions for unsupported SQL features

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297923#comment-15297923 ] ASF GitHub Bot commented on FLINK-3728: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3955] [tableAPI] Rename Table.toSink() ...

2016-05-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3955) Change Table.toSink() to Table.writeToSink()

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297807#comment-15297807 ] ASF GitHub Bot commented on FLINK-3955: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-24 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-221187695 Hi @fhueske. Yes I will update this PR today. Sorry I haven't done it earlier but I was away for the past week. --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-221187388 Hi @dawidwys, do you have some time to work on this PR this week? I will be away next week + a couple of days and would really like to merge it before. Thanks,

[jira] [Commented] (FLINK-3699) Allow per-job Kerberos authentication

2016-05-24 Thread Stefano Baghino (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297875#comment-15297875 ] Stefano Baghino commented on FLINK-3699: Hi Eron; I concur with your opinion. Thanks for taking

[GitHub] flink pull request: [FLINK-3955] [tableAPI] Rename Table.toSink() ...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2023#issuecomment-221184757 Thx @vasia! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2025#discussion_r64338066 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetUnion.scala --- @@ -69,7 +73,7 @@ class

[jira] [Commented] (FLINK-3941) Add support for UNION (with duplicate elimination)

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297818#comment-15297818 ] ASF GitHub Bot commented on FLINK-3941: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2025#discussion_r64339091 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/UnionITCase.scala --- @@ -54,7 +54,22 @@ class UnionITCase(

[jira] [Updated] (FLINK-3699) Allow per-job Kerberos authentication

2016-05-24 Thread Stefano Baghino (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Baghino updated FLINK-3699: --- Assignee: (was: Stefano Baghino) > Allow per-job Kerberos authentication >

[GitHub] flink pull request: [FLINK-3960] ignore EventTimeWindowCheckpointi...

2016-05-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2022 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3960) EventTimeWindowCheckpointingITCase fails with a segmentation fault

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297998#comment-15297998 ] ASF GitHub Bot commented on FLINK-3960: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-3963) AbstractReporter uses shaded dependency

2016-05-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298035#comment-15298035 ] Maximilian Michels commented on FLINK-3963: --- Thanks for reporting [~kkl0u]. Do you want to open

[jira] [Created] (FLINK-3963) AbstractReporter uses shaded dependency

2016-05-24 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3963: - Summary: AbstractReporter uses shaded dependency Key: FLINK-3963 URL: https://issues.apache.org/jira/browse/FLINK-3963 Project: Flink Issue Type:

[jira] [Commented] (FLINK-3962) JMXReporter doesn't properly register/deregister metrics

2016-05-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298008#comment-15298008 ] Maximilian Michels commented on FLINK-3962: --- [~Zentol] I assigned you because you had been

[jira] [Commented] (FLINK-3941) Add support for UNION (with duplicate elimination)

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298039#comment-15298039 ] ASF GitHub Bot commented on FLINK-3941: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2025#issuecomment-221232111 Changes look good. Can you also please update the supported feature set in the docs (`docs/apis/table.md`)? Should be good to merge once that is done.

[jira] [Closed] (FLINK-3955) Change Table.toSink() to Table.writeToSink()

2016-05-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3955. Resolution: Implemented Fix Version/s: 1.1.0 Implemented with

[jira] [Created] (FLINK-3962) JMXReporter doesn't properly register/deregister metrics

2016-05-24 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3962: - Summary: JMXReporter doesn't properly register/deregister metrics Key: FLINK-3962 URL: https://issues.apache.org/jira/browse/FLINK-3962 Project: Flink

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2025#discussion_r64367480 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateMapFunction.scala --- @@ -44,7 +44,7 @@ class

[jira] [Commented] (FLINK-3941) Add support for UNION (with duplicate elimination)

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298031#comment-15298031 ] ASF GitHub Bot commented on FLINK-3941: --- Github user fhueske commented on a diff in the pull

[jira] [Created] (FLINK-3964) Job submission times out with recursive.file.enumeration

2016-05-24 Thread Juho Autio (JIRA)
Juho Autio created FLINK-3964: - Summary: Job submission times out with recursive.file.enumeration Key: FLINK-3964 URL: https://issues.apache.org/jira/browse/FLINK-3964 Project: Flink Issue Type:

[jira] [Closed] (FLINK-3728) Throw meaningful exceptions for unsupported SQL features

2016-05-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3728. Resolution: Implemented Fix Version/s: 1.1.0 Implemented with

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/2025#discussion_r64371728 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateMapFunction.scala --- @@ -44,7 +44,7 @@ class

[jira] [Commented] (FLINK-3960) EventTimeWindowCheckpointingITCase fails with a segmentation fault

2016-05-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298010#comment-15298010 ] Maximilian Michels commented on FLINK-3960: --- Merged temporary fix which should be reverted once

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/flink/pull/2025#issuecomment-221225446 Hi @fhueske , thanks for the review! The changes are: - Remove the whole `java/batch/table/UnionITCase.java` - Remove `testUnionWithFilter`, `testUnionWithJoin`

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persi...

2016-05-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/2020#issuecomment-221227518 CC: @StephanEwen By the way, it might not look like it but the only additional methods this introduces on `StreamExecutionEnvironment` are are these three:

[jira] [Commented] (FLINK-3941) Add support for UNION (with duplicate elimination)

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298057#comment-15298057 ] ASF GitHub Bot commented on FLINK-3941: --- Github user yjshen commented on a diff in the pull request:

[GitHub] flink pull request: [hotfix] Removed shaded import

2016-05-24 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/2026#issuecomment-221248085 Yes, give me a sec. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Reopened] (FLINK-2155) Add an additional checkstyle validation for illegal imports

2016-05-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reopened FLINK-2155: --- Assignee: Kostas Kloudas (was: Lokesh Rajaram) The Checkstyle rule for checking

[GitHub] flink pull request: [hotfix] Removed shaded import

2016-05-24 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2026 [hotfix] Removed shaded import You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink hotfix Alternatively you can review and apply these

[GitHub] flink pull request: [hotfix] Removed shaded import

2016-05-24 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/2026#issuecomment-221247552 The fix looks okay. However, can you add a rule to the checkstyle config in "tools/maven/checkstyle.xml" to ensure that the build will fail if people use wrong

[jira] [Closed] (FLINK-3963) AbstractReporter uses shaded dependency

2016-05-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-3963. - Resolution: Fixed Fixed with cbee4ef20431be9d934a25ba89a801b16b4f85dd > AbstractReporter

[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298085#comment-15298085 ] ASF GitHub Bot commented on FLINK-2155: --- Github user mxm commented on the pull request:

[GitHub] flink pull request: [hotfix] Removed shaded import

2016-05-24 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2026#issuecomment-221251824 Follow-up issue is here: https://issues.apache.org/jira/browse/FLINK-2155 --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Updated] (FLINK-2155) Add an additional checkstyle validation for illegal imports

2016-05-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-2155: -- Affects Version/s: 1.1.0 > Add an additional checkstyle validation for illegal imports

[jira] [Updated] (FLINK-2155) Add an additional checkstyle validation for illegal imports

2016-05-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-2155: -- Fix Version/s: 1.1.0 > Add an additional checkstyle validation for illegal imports >

[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports

2016-05-24 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298086#comment-15298086 ] Kostas Kloudas commented on FLINK-2155: --- Yes of course! Will do that later in the day. > Add an

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/2025#discussion_r64382835 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetUnion.scala --- @@ -69,16 +73,23 @@ class

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

2016-05-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298074#comment-15298074 ] Aljoscha Krettek commented on FLINK-3758: - [~knaufk], we might have to reconsider how this is

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

2016-05-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298079#comment-15298079 ] Aljoscha Krettek commented on FLINK-3758: - The issue for the monitoring is this one: FLINK-456 >

[GitHub] flink pull request: [hotfix] Removed shaded import

2016-05-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2026 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3941) Add support for UNION (with duplicate elimination)

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298114#comment-15298114 ] ASF GitHub Bot commented on FLINK-3941: --- Github user yjshen commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/2025#discussion_r64383299 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetUnion.scala --- @@ -69,16 +73,23 @@ class

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298185#comment-15298185 ] ASF GitHub Bot commented on FLINK-2314: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-3941) Add support for UNION (with duplicate elimination)

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298073#comment-15298073 ] ASF GitHub Bot commented on FLINK-3941: --- Github user yjshen commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3941][TableAPI]Add support for UNION (w...

2016-05-24 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/flink/pull/2025#discussion_r64377174 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateMapFunction.scala --- @@ -44,7 +44,7 @@ class

[jira] [Commented] (FLINK-3963) AbstractReporter uses shaded dependency

2016-05-24 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298082#comment-15298082 ] Kostas Kloudas commented on FLINK-3963: --- Thanks a lot [~mxm] for opening this. The PR is

[GitHub] flink pull request: [hotfix] Removed shaded import

2016-05-24 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2026#issuecomment-221250699 +1 going to merge. Let's fix the Checkstyle rule in a separate issue/pull request. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298209#comment-15298209 ] ASF GitHub Bot commented on FLINK-2314: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3761) Introduce key group state backend

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298250#comment-15298250 ] ASF GitHub Bot commented on FLINK-3761: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persi...

2016-05-24 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2020#discussion_r64392589 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamFaultToleranceTestBase.java --- @@ -104,8 +106,25 @@ public void

[jira] [Reopened] (FLINK-3963) AbstractReporter uses shaded dependency

2016-05-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reopened FLINK-3963: --- The import is still not correct and let's Hadoop 1 builds fail. > AbstractReporter uses

[jira] [Commented] (FLINK-3922) Infinite recursion on TypeExtractor

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298241#comment-15298241 ] ASF GitHub Bot commented on FLINK-3922: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3761] Introduction of key groups

2016-05-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1988#issuecomment-221289448 I started looking into it, but man this is one big change... 😃 I have some first remarks about API and internals: Whats the reason for the

[jira] [Closed] (FLINK-3963) AbstractReporter uses shaded dependency

2016-05-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-3963. - Resolution: Fixed Fixed via 5b9872492394026f3e6ac31b9937141ebedb1481 by replacing Netty's

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persi...

2016-05-24 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2020#discussion_r64395572 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamFaultToleranceTestBase.java --- @@ -104,8 +106,25 @@ public void

[GitHub] flink pull request: [FLINK-3922] [types] Infinite recursion on Typ...

2016-05-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2011#issuecomment-221288209 Does this also prevent infinite recursion on non transitive recursive types? Something like: ```java public class A { public B field; }

[jira] [Updated] (FLINK-3239) Support for Kerberos enabled Kafka 0.9.0.0

2016-05-24 Thread Stefano Baghino (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Baghino updated FLINK-3239: --- Assignee: Vijay Srinivasaraghavan (was: Stefano Baghino) > Support for Kerberos enabled

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-24 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-221307901 @fhueske I have uploaded the updated PR. Unfortunately there are some strange VM crashes, that I think are not related to the changes. --- If your project is set up

[jira] [Commented] (FLINK-3761) Introduce key group state backend

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298355#comment-15298355 ] ASF GitHub Bot commented on FLINK-3761: --- Github user tillrohrmann commented on the pull request:

[jira] [Commented] (FLINK-3761) Introduce key group state backend

2016-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298360#comment-15298360 ] ASF GitHub Bot commented on FLINK-3761: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3761] Introduction of key groups

2016-05-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1988#issuecomment-221311349 Jip, this last paragraph with the Factory is what I hinted at with my comment. 😃 This may be somewhat academic but if there is a method `getPartitionedStateBackend`

  1   2   >