[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069580#comment-16069580 ] Aljoscha Krettek commented on FLINK-7047: - To me that sounds very good! We might be able to run

[jira] [Commented] (FLINK-6502) Add support ElasticsearchSink for DataSet

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069579#comment-16069579 ] ASF GitHub Bot commented on FLINK-6502: --- Github user tzulitai commented on the issue:

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

2017-06-30 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3855#discussion_r124972967 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java --- @@ -35,6 +35,7 @@ import

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069601#comment-16069601 ] Chesnay Schepler commented on FLINK-7047: - We can also do that now, but i wanted to keep the added

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

2017-06-30 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3855#discussion_r124970218 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/akka/AkkaSslITCase.scala --- @@ -20,8 +20,8 @@ package org.apache.flink.runtime.akka

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

2017-06-30 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3855#discussion_r124969948 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala --- @@ -26,7 +26,7 @@ import akka.actor._ import

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

2017-06-30 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3855#discussion_r124970162 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java --- @@ -35,6 +35,7 @@ import

[jira] [Commented] (FLINK-6496) Migrate SSL configuration options

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069553#comment-16069553 ] ASF GitHub Bot commented on FLINK-6496: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-6496) Migrate SSL configuration options

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069554#comment-16069554 ] ASF GitHub Bot commented on FLINK-6496: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-6496) Migrate SSL configuration options

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069552#comment-16069552 ] ASF GitHub Bot commented on FLINK-6496: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-7045) Reduce element count of UdfStreamOperatorCheckpointingITCase

2017-06-30 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069558#comment-16069558 ] mingleizhang commented on FLINK-7045: - With NUM_INPUT equals 2,500,000. It costs *33s,556ms* on my

[GitHub] flink pull request #4230: [FLINK-7045] [checkpoints] Reduce element count of...

2017-06-30 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4230 [FLINK-7045] [checkpoints] Reduce element count of UdfStreamOperatorC… With NUM_INPUT equals to 2,500,000. It costs 33s,556ms on my computer. But and I can get 10s, 915ms as I reduce the

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069562#comment-16069562 ] Chesnay Schepler commented on FLINK-7047: - here's an exxample build

[jira] [Commented] (FLINK-7045) Reduce element count of UdfStreamOperatorCheckpointingITCase

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069563#comment-16069563 ] ASF GitHub Bot commented on FLINK-7045: --- GitHub user zhangminglei opened a pull request:

[jira] [Updated] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7047: Description: With the current build times once again hitting the timeout it is time to

[GitHub] flink issue #3869: [FLINK-6502] Add support ElasticsearchSink for DataSet

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3869 @397090770 I'm afraid I will need to reject this PR as of its current state. The main issue is that we can't just move those public user-facing classes. We either have to deprecate them and

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

2017-06-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3855#discussion_r124973801 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java --- @@ -35,6 +35,7 @@ import

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

2017-06-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3855#discussion_r124973760 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java --- @@ -35,6 +35,7 @@ import

[jira] [Commented] (FLINK-6496) Migrate SSL configuration options

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069591#comment-16069591 ] ASF GitHub Bot commented on FLINK-6496: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-6496) Migrate SSL configuration options

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069594#comment-16069594 ] ASF GitHub Bot commented on FLINK-6496: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6496) Migrate SSL configuration options

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069596#comment-16069596 ] ASF GitHub Bot commented on FLINK-6496: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069603#comment-16069603 ] Chesnay Schepler commented on FLINK-7047: - We can also think about adding more profiles 1 month

[jira] [Commented] (FLINK-6575) Disable all tests on Windows that use HDFS

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069628#comment-16069628 ] ASF GitHub Bot commented on FLINK-6575: --- Github user zentol commented on the issue:

[GitHub] flink issue #2761: [FLINK-3551] [examples] Sync Scala Streaming Examples

2017-06-30 Thread ch33hau
Github user ch33hau commented on the issue: https://github.com/apache/flink/pull/2761 @fhueske Sorry for the problems you have raised, I can see the painful now, I will avoid the same mistake. Thanks for your time I really appreciate it. --- If your project is set up for it,

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069696#comment-16069696 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124988636 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java --- @@ -1900,7 +1900,7 @@ public void unparse(

[GitHub] flink pull request #3984: [FLINK-6710] Remove Twitter-InputFormat

2017-06-30 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/3984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7041) Deserialize StateBackend from JobCheckpointingSettings with user classloader

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069762#comment-16069762 ] ASF GitHub Bot commented on FLINK-7041: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125002758 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069605#comment-16069605 ] Kostas Kloudas commented on FLINK-7047: --- I like this change. It is a more systematic approach than

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069611#comment-16069611 ] mingleizhang commented on FLINK-7047: - Chesnay Schepler is great. Actually, I did not like travis

[jira] [Commented] (FLINK-6575) Disable all tests on Windows that use HDFS

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069609#comment-16069609 ] ASF GitHub Bot commented on FLINK-6575: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-6575) Disable all tests on Windows that use HDFS

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069610#comment-16069610 ] ASF GitHub Bot commented on FLINK-6575: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3776: [FLINK-6376]when deploy flink cluster on the yarn, it is ...

2017-06-30 Thread Rucongzhang
Github user Rucongzhang commented on the issue: https://github.com/apache/flink/pull/3776 @tzulitai ,ok,Thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #4206: [FLINK-6996] FlinkKafkaProducer010 doesn't guarantee at-l...

2017-06-30 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4206 Hmm, this is disturbing. Locally it works for me always. I have rewritten test so that it should be less prone to intermittent failures (longer reading from Kafka timeout). Hopefully that will

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124991860 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069718#comment-16069718 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6695) Activate strict checkstyle in flink-contrib

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069760#comment-16069760 ] ASF GitHub Bot commented on FLINK-6695: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #4231: [FLINK-6695] Activate strict checkstyle for flink-...

2017-06-30 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4231 [FLINK-6695] Activate strict checkstyle for flink-contrib This PR moves the checkstyle plugin declaration into the flink-contrib pom. You can merge this pull request into a Git repository by

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125000171 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java --- @@ -267,6 +293,177 @@ public void shutDown() {

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r124999617 --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java --- @@ -534,33 +537,66 @@ public Integer

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r124998338 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java --- @@ -157,10 +168,16 @@ public QueryableStateClient(

[jira] [Created] (FLINK-7050) RFC Compliant CSV Parser for Table Source

2017-06-30 Thread Usman Younas (JIRA)
Usman Younas created FLINK-7050: --- Summary: RFC Compliant CSV Parser for Table Source Key: FLINK-7050 URL: https://issues.apache.org/jira/browse/FLINK-7050 Project: Flink Issue Type:

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125003218 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlGroupFunction.java --- @@ -50,7 +50,8 @@ * GROUP BY HOP(rowtime,

[GitHub] flink issue #4232: [FLINK-7041] Deserialize StateBackend from JobCheckpointi...

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4232 Ah scratch that, perhaps the `CheckpointSettingsSerializableTest` is sufficient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069801#comment-16069801 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6376) when deploy flink cluster on the yarn, it is lack of hdfs delegation token.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069621#comment-16069621 ] ASF GitHub Bot commented on FLINK-6376: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-6996) FlinkKafkaProducer010 doesn't guarantee at-least-once semantic

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069657#comment-16069657 ] ASF GitHub Bot commented on FLINK-6996: --- Github user pnowojski commented on the issue:

[jira] [Comment Edited] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069688#comment-16069688 ] Chesnay Schepler edited comment on FLINK-7047 at 6/30/17 8:23 AM: -- WIth a

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069688#comment-16069688 ] Chesnay Schepler commented on FLINK-7047: - WIth a split repo we could make the tests way more

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069711#comment-16069711 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r124999382 --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java --- @@ -234,38 +239,28 @@ public Integer

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069779#comment-16069779 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069783#comment-16069783 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069781#comment-16069781 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r124998957 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/VoidNamespaceTypeInfo.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069780#comment-16069780 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069782#comment-16069782 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-7041) Deserialize StateBackend from JobCheckpointingSettings with user classloader

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069793#comment-16069793 ] ASF GitHub Bot commented on FLINK-7041: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-7041) Deserialize StateBackend from JobCheckpointingSettings with user classloader

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069803#comment-16069803 ] ASF GitHub Bot commented on FLINK-7041: --- Github user tzulitai commented on the issue:

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125004836 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125006417 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/VoidNamespaceTypeInfo.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125006493 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java --- @@ -267,6 +293,177 @@ public void shutDown() { }

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069827#comment-16069827 ] ASF GitHub Bot commented on FLINK-7044: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink issue #3891: [FLINK-6575] Disable tests on Windows that use HDFS

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3891 One question: I'm curious how the scan for tests that use HDFS was done? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3891: [FLINK-6575] Disable tests on Windows that use HDFS

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3891 This looks good! +1, merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069632#comment-16069632 ] ASF GitHub Bot commented on FLINK-3551: --- Github user ch33hau commented on the issue:

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069667#comment-16069667 ] Till Rohrmann commented on FLINK-7047: -- I like the idea. +1 for the changes. This could also be the

[jira] [Commented] (FLINK-4022) Partition discovery / regex topic subscription for the Kafka consumer

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069669#comment-16069669 ] ASF GitHub Bot commented on FLINK-4022: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3746: [FLINK-4022] [kafka] Partition and topic discovery for Fl...

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3746 (please ignore the batch of commits. I'm just using this branch for an overall Travis run before committing the batch; personal accounts get time-outs too constantly) --- If your project is set

[jira] [Comment Edited] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069688#comment-16069688 ] Chesnay Schepler edited comment on FLINK-7047 at 6/30/17 8:23 AM: -- WIth a

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124990940 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class

[GitHub] flink pull request #4232: [FLINK-7041] Deserialize StateBackend from JobChec...

2017-06-30 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/4232 [FLINK-7041] Deserialize StateBackend from JobCheckpointingSettings with user classloader R: @tzulitai CC: @StephanEwen I noticed that the state backend that is in the configuration is

[jira] [Commented] (FLINK-7041) Deserialize StateBackend from JobCheckpointingSettings with user classloader

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069822#comment-16069822 ] ASF GitHub Bot commented on FLINK-7041: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #4167: Test PR, please ignore

2017-06-30 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/4167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6376) when deploy flink cluster on the yarn, it is lack of hdfs delegation token.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069627#comment-16069627 ] ASF GitHub Bot commented on FLINK-6376: --- Github user Rucongzhang commented on the issue:

[GitHub] flink issue #3891: [FLINK-6575] Disable tests on Windows that use HDFS

2017-06-30 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3891 I ran the tests repeatedly and analyzed why they failed. For these i determined the cause to be hdfs. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124990474 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069707#comment-16069707 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in the pull

[jira] [Closed] (FLINK-6710) Remove twitter-inputformat

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6710. --- Resolution: Fixed 1.4: d7d10a130bf7a1856e5ab17ac354f3f2fc4d2f55 > Remove twitter-inputformat

[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069756#comment-16069756 ] ASF GitHub Bot commented on FLINK-6710: --- Github user zentol closed the pull request at:

[jira] [Comment Edited] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069605#comment-16069605 ] Kostas Kloudas edited comment on FLINK-7047 at 6/30/17 6:54 AM: I like

[GitHub] flink issue #3776: [FLINK-6376]when deploy flink cluster on the yarn, it is ...

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3776 @Rucongzhang ok, understood. I agree that in general the current `AbstractYarnClusterDescriptor` has poor separation of concerns, as is a bit hard to write contained tests. We should remember to

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069634#comment-16069634 ] ASF GitHub Bot commented on FLINK-6352: --- Github user zjureel commented on a diff in the pull

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-06-30 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r124977924 --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer010.java --- @@ -128,6

[GitHub] flink issue #2761: [FLINK-3551] [examples] Sync Scala Streaming Examples

2017-06-30 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2761 No worries :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069671#comment-16069671 ] ASF GitHub Bot commented on FLINK-3551: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4232: [FLINK-7041] Deserialize StateBackend from JobCheckpointi...

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4232 Thanks for the quick fix @aljoscha! Regarding tests: Can we also have another test that verifies `JobGraphs` containing custom `StateBackend`s or `StateBackends` with custom classes can

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069797#comment-16069797 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125003073 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069799#comment-16069799 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069817#comment-16069817 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4232: [FLINK-7041] Deserialize StateBackend from JobChec...

2017-06-30 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4232#discussion_r125004426 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java --- @@ -223,19 +223,21 @@ public static

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125007122 --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java --- @@ -234,38 +239,28 @@ public Integer

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069967#comment-16069967 ] ASF GitHub Bot commented on FLINK-6058: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #3921: [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnv...

2017-06-30 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3921 I think we can get by without changing `ClusterClient` and `ContextEnvironment` by only reading the parallelism from the global config in `CliFrontend` when trying to read the user parallelism from

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069904#comment-16069904 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in the pull

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069909#comment-16069909 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in the pull

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069906#comment-16069906 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in the pull

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069899#comment-16069899 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in the pull

  1   2   3   >