[jira] [Commented] (FLINK-5964) Change TypeSerializers to allow construction of immutable types

2017-09-18 Thread David Anderson (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169780#comment-16169780 ] David Anderson commented on FLINK-5964: --- Here's an example that compiles, but fails at runtime:

[jira] [Created] (FLINK-7637) FlinkKinesisProducer violates at-least-once guarantees

2017-09-18 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-7637: -- Summary: FlinkKinesisProducer violates at-least-once guarantees Key: FLINK-7637 URL: https://issues.apache.org/jira/browse/FLINK-7637 Project: Flink

[GitHub] flink pull request #4674: [FLINK-7627] [table] SingleElementIterable should ...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4674#discussion_r139364586 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/types/SingleElementIterableTest.scala --- @@ -0,0 +1,32 @@ +/*

[GitHub] flink issue #4674: [FLINK-7627] [table] SingleElementIterable should impleme...

2017-09-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4674 Hi @hequn8128, thanks for the PR. I think it's OK to make the iterable serializable, but would like to understand better when a non-serializable iterable leads to a bug. Thanks, Fabian

[jira] [Commented] (FLINK-7627) SingleElementIterable should implement with Serializable

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169760#comment-16169760 ] ASF GitHub Bot commented on FLINK-7627: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7529) Retrieve complete REST address from RestfulGateway

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169885#comment-16169885 ] ASF GitHub Bot commented on FLINK-7529: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #4677: [FLINK-7626] Add some checkpoints metric description in d...

2017-09-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4677 merging. ---

[jira] [Commented] (FLINK-7626) Add some metric description about checkpoints

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169912#comment-16169912 ] ASF GitHub Bot commented on FLINK-7626: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-3991) Remove deprecated configuration keys from ConfigConstants

2017-09-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169871#comment-16169871 ] Chesnay Schepler commented on FLINK-3991: - [~chetna] This issue can only be completed once we're

[GitHub] flink issue #4653: [FLINK-7598][travis] fix ineffective shaded artifacts che...

2017-09-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4653 merging. ---

[jira] [Commented] (FLINK-7510) Move some connectors to Apache Bahir

2017-09-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169763#comment-16169763 ] Robert Metzger commented on FLINK-7510: --- [~aljoscha] [~tzulitai] what do you think about this? >

[jira] [Commented] (FLINK-7582) Rest client may buffer responses indefinitely under heavy laod

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169931#comment-16169931 ] ASF GitHub Bot commented on FLINK-7582: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4645: [FLINK-7582] [REST] Netty thread immediately parse...

2017-09-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4645#discussion_r139403702 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -159,24 +155,17 @@ public void shutdown(Time timeout) { }

[jira] [Commented] (FLINK-7627) SingleElementIterable should implement with Serializable

2017-09-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169757#comment-16169757 ] Fabian Hueske commented on FLINK-7627: -- I don't have concerns that {{SingleElementIterable}}

[jira] [Commented] (FLINK-7627) SingleElementIterable should implement with Serializable

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169762#comment-16169762 ] ASF GitHub Bot commented on FLINK-7627: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7510) Move some connectors to Apache Bahir

2017-09-18 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169792#comment-16169792 ] Tzu-Li (Gordon) Tai commented on FLINK-7510: I also don't think there is an urgent need to do

[jira] [Commented] (FLINK-7598) ineffective shaded artifacts checks in travis_mvn_watchdog.sh

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169899#comment-16169899 ] ASF GitHub Bot commented on FLINK-7598: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6549) Improve error message for type mismatches with side outputs

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169900#comment-16169900 ] ASF GitHub Bot commented on FLINK-6549: --- Github user zentol commented on the issue:

[GitHub] flink issue #4663: [FLINK-6549] [DataStream API] Improve error message for t...

2017-09-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4663 merging. ---

[GitHub] flink pull request #4599: [FLINK-7529] Retrieve complete REST address from g...

2017-09-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4599#discussion_r139392946 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitorITCase.java --- @@ -479,41 +479,6 @@ public void

[jira] [Commented] (FLINK-7531) Move existing REST handler to flink-runtime

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169891#comment-16169891 ] ASF GitHub Bot commented on FLINK-7531: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...

2017-09-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4600#discussion_r139393572 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStatsTrackerTest.java --- @@ -80,11 +73,11 @@

[jira] [Commented] (FLINK-7531) Move existing REST handler to flink-runtime

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169892#comment-16169892 ] ASF GitHub Bot commented on FLINK-7531: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...

2017-09-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4600#discussion_r139393444 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestEndpointITCase.java --- @@ -72,14 +72,14 @@ public void testEndpoints() throws

[GitHub] flink pull request #4636: [FLINK-2268] Allow Flink binary release without Ha...

2017-09-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4636#discussion_r139481104 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-2268) Provide Flink binary release without Hadoop

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170300#comment-16170300 ] ASF GitHub Bot commented on FLINK-2268: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #4602: [FLINK-7533] Let LeaderGatewayRetriever retry failed gate...

2017-09-18 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4602 Rebasing onto the latest master. ---

[jira] [Commented] (FLINK-7533) Retry failed gateway retrievals in the LeaderGatewayRetriever

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169996#comment-16169996 ] ASF GitHub Bot commented on FLINK-7533: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-7531) Move existing REST handler to flink-runtime

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170007#comment-16170007 ] ASF GitHub Bot commented on FLINK-7531: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...

2017-09-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4600#discussion_r139420901 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStatsTrackerTest.java --- @@ -80,11 +73,11

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139387007 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -166,16 +185,16 @@

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139386887 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -196,53 +215,69 @@

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139436010 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,74 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139434334 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139436599 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,74 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139424544 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139386347 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -196,53 +215,69 @@

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139387143 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -196,53 +215,69 @@

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139386829 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -196,53 +215,69 @@

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139385974 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -117,6 +123,11 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139430727 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,74 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139400726 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala --- @@ -383,13 +384,158 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139407845 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139426723 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139423665 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139402125 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala --- @@ -383,13 +384,158 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139437709 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/RowTimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,83 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139446305 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139410699 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139399103 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -166,16 +185,16 @@

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170173#comment-16170173 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139439684 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/RowTimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,83 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139427057 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139400962 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala --- @@ -383,13 +384,158 @@ class

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170195#comment-16170195 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170191#comment-16170191 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170200#comment-16170200 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170179#comment-16170179 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170184#comment-16170184 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170177#comment-16170177 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170174#comment-16170174 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170183#comment-16170183 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170197#comment-16170197 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170186#comment-16170186 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170202#comment-16170202 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170176#comment-16170176 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170181#comment-16170181 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139385852 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -57,6 +61,8 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139401824 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala --- @@ -383,13 +384,158 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139407531 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -55,18 +49,18 @@ import

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139435951 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,74 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139401341 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala --- @@ -383,13 +384,158 @@ class

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r139435309 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170198#comment-16170198 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170201#comment-16170201 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170180#comment-16170180 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170192#comment-16170192 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170188#comment-16170188 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170190#comment-16170190 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170193#comment-16170193 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170182#comment-16170182 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170196#comment-16170196 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170175#comment-16170175 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170194#comment-16170194 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170199#comment-16170199 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170178#comment-16170178 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170185#comment-16170185 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170189#comment-16170189 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4603: [FLINK-7534] Create LegacyRestHandlerAdapter for o...

2017-09-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4603#discussion_r139411152 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RedirectHandler.java --- @@ -143,19 +154,20 @@ protected void channelRead0(

[jira] [Commented] (FLINK-7534) Create LegacyRestHandlerAdapter for the old REST handlers

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169980#comment-16169980 ] ASF GitHub Bot commented on FLINK-7534: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7534) Create LegacyRestHandlerAdapter for the old REST handlers

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169979#comment-16169979 ] ASF GitHub Bot commented on FLINK-7534: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7534) Create LegacyRestHandlerAdapter for the old REST handlers

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169981#comment-16169981 ] ASF GitHub Bot commented on FLINK-7534: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7534) Create LegacyRestHandlerAdapter for the old REST handlers

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169978#comment-16169978 ] ASF GitHub Bot commented on FLINK-7534: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4603: [FLINK-7534] Create LegacyRestHandlerAdapter for o...

2017-09-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4603#discussion_r139414902 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/LegacyRequest.java --- @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-09-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169987#comment-16169987 ] Chesnay Schepler commented on FLINK-7623: - The culprit is this bit in the AbstractStreamOperator:

[GitHub] flink issue #4549: [FLINK-7458] Generalize GatewayRetriever for WebRuntimeMo...

2017-09-18 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4549 Thanks for the review @zentol. Rebasing onto the latest master and if Travis gives green light, I'll merge this PR. ---

[GitHub] flink pull request #4600: [FLINK-7531] Move Flink legacy rest handler to fli...

2017-09-18 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4600#discussion_r139419933 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestEndpointITCase.java --- @@ -72,14 +72,14 @@ public void testEndpoints() throws

[GitHub] flink issue #4643: [FLINK-7580] Automatically retry failed gateway retrieval...

2017-09-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4643 @tillrohrmann No, I haven't looked at #4602 yet. ---

[jira] [Commented] (FLINK-7580) Let LeaderGatewayRetriever implementations automatically retry failed gateway retrieval operations

2017-09-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170024#comment-16170024 ] ASF GitHub Bot commented on FLINK-7580: --- Github user zentol commented on the issue:

[GitHub] flink pull request #4603: [FLINK-7534] Create LegacyRestHandlerAdapter for o...

2017-09-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4603#discussion_r139413912 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/webmonitor/StatusOverviewWithVersion.java --- @@ -0,0 +1,92 @@ +/* + *

  1   2   3   >