[GitHub] [flink] flinkbot edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#issuecomment-541555428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#discussion_r336310564 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#discussion_r336310564 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#discussion_r336310564 ## File path:

[jira] [Comment Edited] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954232#comment-16954232 ] Yun Tang edited comment on FLINK-14445 at 10/18/19 3:45 AM: CC [~dian.fu]

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535430586 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#discussion_r336312977 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535848177 ## CI report: * 5d9e3113e10bbf0220b4f8e080ecd1cddd9c9059 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535435111 ## CI report: * 1aad21713df6970025319183b3774aec674fefde : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535848177 ## CI report: * 5d9e3113e10bbf0220b4f8e080ecd1cddd9c9059 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126 ## CI report: * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE

[GitHub] [flink] TisonKun closed pull request #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar

2019-10-17 Thread GitBox
TisonKun closed pull request #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar URL: https://github.com/apache/flink/pull/9861 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] TisonKun commented on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar

2019-10-17 Thread GitBox
TisonKun commented on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar URL: https://github.com/apache/flink/pull/9861#issuecomment-543477490 Thanks for your reminder Till. I've verified it locally with `-yj /path/to/flink-dist_2.11-1.10-SNAPSHOT.jar` and check TM log

[GitHub] [flink] walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#discussion_r336317015 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#discussion_r336317421 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#discussion_r336317258 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#discussion_r336317216 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar URL: https://github.com/apache/flink/pull/9861#issuecomment-539888511 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] flinkbot edited a comment on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar URL: https://github.com/apache/flink/pull/9861#issuecomment-539888511 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] flinkbot edited a comment on issue #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#issuecomment-526645449 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[jira] [Comment Edited] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954253#comment-16954253 ] Dian Fu edited comment on FLINK-14445 at 10/18/19 5:08 AM: --- [~yunta]  Thanks

[GitHub] [flink] flinkbot edited a comment on issue #9927: [FLINK-14397][hive] Failed to run Hive UDTF with array arguments

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9927: [FLINK-14397][hive] Failed to run Hive UDTF with array arguments URL: https://github.com/apache/flink/pull/9927#issuecomment-543172555 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-539472188 ## CI report: * b10f5603fc55999adb8d5334a3d142d20322de5b : SUCCESS

[jira] [Commented] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954253#comment-16954253 ] Dian Fu commented on FLINK-14445: - [~yunta]  Thanks for reporting this issue. It seems that it is caused

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126 ## CI report: * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#issuecomment-533540408 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#discussion_r336316035 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542644991 ## CI report: * 8d1696b97872fdd9fd3aca725c8b58ad8227f6f2 :

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535844880 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[jira] [Commented] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954232#comment-16954232 ] Yun Tang commented on FLINK-14445: -- CC [~dianfu] > Python module build failed when making sdist >

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535430586 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126 ## CI report: * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542638190 Thanks a lot for your contribution to the Apache Flink project. I'm the

[jira] [Created] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Yun Tang (Jira)
Yun Tang created FLINK-14445: Summary: Python module build failed when making sdist Key: FLINK-14445 URL: https://issues.apache.org/jira/browse/FLINK-14445 Project: Flink Issue Type: Bug

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336298507 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336297753 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336296251 ## File path: flink-python/pyflink/table/table_environment.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336297346 ## File path: flink-python/pyflink/table/udf.py ## @@ -167,13 +166,25

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336300424 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336311539 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541416833 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#discussion_r336314745 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#discussion_r336313420 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#discussion_r336315170 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542638190 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-539472188 ## CI report: * b10f5603fc55999adb8d5334a3d142d20322de5b : SUCCESS

[GitHub] [flink] wuchong commented on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong commented on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#issuecomment-543482276 Hi @hequn8128 , the part of blink looks good to me. I only left a comment about the naming of

[GitHub] [flink] wuchong edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#issuecomment-543482276 Hi @hequn8128 , the part of blink looks good to me. I only left a comment about the naming of

[jira] [Closed] (FLINK-14237) No need to rename shipped Flink jar

2019-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-14237. - Resolution: Fixed master via b022a26b34d7ada92fa459e62f7ec84ce85cfe6f > No need to rename shipped

[jira] [Commented] (FLINK-14308) Kafka09ProducerITCase>KafkaProducerTestBase.testOneToOneAtLeastOnceCustomOperator fails on Travis

2019-10-17 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954238#comment-16954238 ] Yun Tang commented on FLINK-14308: -- Another instance:

[GitHub] [flink] flinkbot edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#issuecomment-541555428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535848177 ## CI report: * 5d9e3113e10bbf0220b4f8e080ecd1cddd9c9059 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#issuecomment-533540408 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535435111 ## CI report: * 1aad21713df6970025319183b3774aec674fefde : SUCCESS

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336322467 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336325463 ## File path: flink-end-to-end-tests/test-scripts/docker-hive-hadoop-cluster/config/mapred-site.xml

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336325001 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336322272 ## File path: flink-end-to-end-tests/flink-hive-test/pom.xml ## @@ -0,0 +1,183 @@ + +

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336322138 ## File path: flink-end-to-end-tests/flink-hive-test/pom.xml ## @@ -0,0 +1,183 @@ + +

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336322335 ## File path: flink-end-to-end-tests/flink-hive-test/pom.xml ## @@ -0,0 +1,183 @@ + +

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535435111 ## CI report: * 1aad21713df6970025319183b3774aec674fefde : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535848177 ## CI report: * 5d9e3113e10bbf0220b4f8e080ecd1cddd9c9059 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542230286 ## CI report: * dd8cbf2ca3d1515420b09362d0a2df938208c2eb :

[jira] [Commented] (FLINK-14364) Allow comments fail when not ignore parse errors in CsvRowDeserializationSchema

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953467#comment-16953467 ] Timo Walther commented on FLINK-14364: -- [~wind_ljy] we can also use

[GitHub] [flink] ifndef-SleePy commented on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-17 Thread GitBox
ifndef-SleePy commented on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-543044286 Hi @pnowojski , thanks for feedback. I have updated the PR to address review comments, except the

[GitHub] [flink] flinkbot edited a comment on issue #9916: [FLINK-14408][Table-Planner]UDF's open method is invoked to initialize when sql is optimized in oldPlanner

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9916: [FLINK-14408][Table-Planner]UDF's open method is invoked to initialize when sql is optimized in oldPlanner URL: https://github.com/apache/flink/pull/9916#issuecomment-542764294 ## CI report: * cd122b399a8dc12c3c604d7db6dea012ee7c0c7f :

[GitHub] [flink] ifndef-SleePy commented on a change in pull request #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-17 Thread GitBox
ifndef-SleePy commented on a change in pull request #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#discussion_r335790644 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9920: [FLINK-14389][runtime] Restore task state before restarting tasks in DefaultScheduler

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9920: [FLINK-14389][runtime] Restore task state before restarting tasks in DefaultScheduler URL: https://github.com/apache/flink/pull/9920#issuecomment-542997479 ## CI report: * c7e058ec893217ef5c8c3cf3ae5e893a7ccf4b8f : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #9911: [hotfix][docs-zh] Fix the incorrect link

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9911: [hotfix][docs-zh] Fix the incorrect link URL: https://github.com/apache/flink/pull/9911#issuecomment-542689902 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request.

[GitHub] [flink] wuchong closed pull request #9911: [hotfix][docs-zh] Fix the incorrect link

2019-10-17 Thread GitBox
wuchong closed pull request #9911: [hotfix][docs-zh] Fix the incorrect link URL: https://github.com/apache/flink/pull/9911 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] TisonKun commented on issue #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session

2019-10-17 Thread GitBox
TisonKun commented on issue #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session URL: https://github.com/apache/flink/pull/9832#issuecomment-543040002 Since we fence different leader epoch with different Dispatcher instance, I think `waitForTerminatingJobManager` should be

[GitHub] [flink] flinkbot edited a comment on issue #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session URL: https://github.com/apache/flink/pull/9832#issuecomment-537039262 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] TisonKun commented on issue #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session

2019-10-17 Thread GitBox
TisonKun commented on issue #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session URL: https://github.com/apache/flink/pull/9832#issuecomment-543040672 > Since we fence different leader epoch with different Dispatcher instance, I think `waitForTerminatingJobManager` should be

[GitHub] [flink] flinkbot edited a comment on issue #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session URL: https://github.com/apache/flink/pull/9832#issuecomment-537039262 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535848177 ## CI report: * 5d9e3113e10bbf0220b4f8e080ecd1cddd9c9059 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126 ## CI report: * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9911: [hotfix][docs-zh] Fix the incorrect link

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9911: [hotfix][docs-zh] Fix the incorrect link URL: https://github.com/apache/flink/pull/9911#issuecomment-542689902 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request.

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335836443 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335836969 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541416833 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-539467530 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335831094 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335823155 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335839358 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335825685 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335835438 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335838306 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335822784 ## File path: flink-python/pyflink/table/environment_settings.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335833796 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335841309 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335825962 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335831867 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335827352 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335832432 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335827393 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335836806 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335840910 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r335825863 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9916: [FLINK-14408][Table-Planner]UDF's open method is invoked to initialize when sql is optimized in oldPlanner

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9916: [FLINK-14408][Table-Planner]UDF's open method is invoked to initialize when sql is optimized in oldPlanner URL: https://github.com/apache/flink/pull/9916#issuecomment-542764294 ## CI report: * cd122b399a8dc12c3c604d7db6dea012ee7c0c7f :

[GitHub] [flink] flinkbot edited a comment on issue #9931: [FLINK-14441][Table-Common] Fix ValueLiteralExpression#getValueAs when valueClass is Period.class

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9931: [FLINK-14441][Table-Common] Fix ValueLiteralExpression#getValueAs when valueClass is Period.class URL: https://github.com/apache/flink/pull/9931#issuecomment-543240888 ## CI report: * a91235b01f24114bd0634f15dfaedc04a280b250 : PENDING

  1   2   3   4   5   6   7   >