Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3851
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116592490
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -215,14 +215,22 @@ case class Aggregate(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116593574
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -215,14 +215,22 @@ case class Aggregate(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116592552
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -584,13 +592,22 @@ case class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116595446
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/validation/AggregationsValidationTest.scala
---
@@ -20,13
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116595353
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -31,6 +31,17 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116592899
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -215,14 +215,22 @@ case class Aggregate(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116442782
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
@@ -50,6 +51,13 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116443377
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupWindowTest.scala
---
@@ -30,6 +30,23 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116444166
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -31,6 +31,18 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116215873
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/utils/UserDefinedAggFunctions.java
---
@@ -23,13 +23,37 @@
import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116217338
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/AggregationsTest.scala
---
@@ -0,0 +1,38 @@
+/*
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116211361
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
@@ -53,8 +54,17 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116211438
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
@@ -53,8 +54,17 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116218286
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/AggregationsTest.scala
---
@@ -0,0 +1,41 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116211870
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateWithNullValuesRule.scala
---
@@ -51,8 +52,17
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116212175
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamGroupAggregateRule.scala
---
@@ -49,13 +49,19
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116211695
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetWindowAggregateRule.scala
---
@@ -49,7 +49,13 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116212002
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
@@ -53,8 +54,17 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116212331
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamGroupWindowAggregateRule.scala
---
@@ -44,14
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116211558
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
@@ -53,8 +54,17 @@ class
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3851
[FLINK-6462] [table] Add requiresOver interface for AggregateFunction
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
22 matches
Mail list logo
