Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5860
---
Github user glaksh100 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r186223237
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -473,6 +4
Github user glaksh100 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r186223099
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -908,6 +9
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r185732573
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -473,6 +48
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r185731699
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -908,6 +929,20
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r183754129
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -87,9 +87,1
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r183756583
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -536,6 +553
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r183757920
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -536,6 +553
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r183754480
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -472,6 +480
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r183753866
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -87,9 +87,1
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r183758663
--- Diff:
flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java
---
@@ -436,6
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r183758338
--- Diff:
flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java
---
@@ -436,6
GitHub user glaksh100 opened a pull request:
https://github.com/apache/flink/pull/5860
[FLINK-9138][filesystem-connectors] Implement time based rollover in
BucketingSink
## What is the purpose of the change
This pull request enables a time-based rollover of the part file in
13 matches
Mail list logo
