[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2020-02-23 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042879#comment-17042879 ] Jiayi Liao commented on FLINK-13702: [~dwysakowicz] [~jark] [~lzljs3620320] The err

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-11-01 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964797#comment-16964797 ] Jark Wu commented on FLINK-13702: - Sounds good to me. > BaseMapSerializerTest.testDupli

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964662#comment-16964662 ] Jingsong Lee commented on FLINK-13702: -- Hi [~dwysakowicz] [~jark], Let me summarize

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964639#comment-16964639 ] Jark Wu commented on FLINK-13702: - As discussed with [~lzljs3620320] offline, we will no

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964605#comment-16964605 ] Jingsong Lee commented on FLINK-13702: -- [~dwysakowicz] yes, it depends on our CodeG

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963982#comment-16963982 ] Dawid Wysakowicz commented on FLINK-13702: -- I don't know exactly how the {{Join

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963955#comment-16963955 ] Jingsong Lee commented on FLINK-13702: -- > There is one problem with entirely removi

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963949#comment-16963949 ] Jark Wu commented on FLINK-13702: - Regarding removing serializer from BinaryGeneric enti

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963941#comment-16963941 ] Dawid Wysakowicz commented on FLINK-13702: -- There is one problem with entirely

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963903#comment-16963903 ] Jingsong Lee commented on FLINK-13702: -- About BinaryGeneric: I have considered pas

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963897#comment-16963897 ] Jingsong Lee commented on FLINK-13702: -- Hi [~dwysakowicz] , I think maybe we don't

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963894#comment-16963894 ] Jark Wu commented on FLINK-13702: - I thought about call {{duplicate}} too, but calling {

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963838#comment-16963838 ] Dawid Wysakowicz commented on FLINK-13702: -- I agree the solution suggested by [

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963812#comment-16963812 ] Jark Wu commented on FLINK-13702: - Thanks for the approach. I think it can solve the pro

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-30 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963600#comment-16963600 ] Jingsong Lee commented on FLINK-13702: -- Thanks [~jark] 's input. It's true that the

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-30 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963031#comment-16963031 ] Dawid Wysakowicz commented on FLINK-13702: -- I agree with [~jark]. If we ever ke

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-30 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962956#comment-16962956 ] Jark Wu commented on FLINK-13702: - Sorry didn't notice the discussion above. Hi [~lzlj

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-30 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962953#comment-16962953 ] Jark Wu commented on FLINK-13702: - Hi [~dwysakowicz], thanks for looking into this. Howe

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-30 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962943#comment-16962943 ] Jingsong Lee commented on FLINK-13702: -- I think this Jira is not production bug, it

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-30 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962940#comment-16962940 ] Jingsong Lee commented on FLINK-13702: -- BinaryLazyFormat is designed for single thr

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-30 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962936#comment-16962936 ] Dawid Wysakowicz commented on FLINK-13702: -- What do you mean by ??invoke Binary

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-30 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962929#comment-16962929 ] Jingsong Lee commented on FLINK-13702: -- Thanks [~dwysakowicz], nice analysis, you a

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-10-30 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962906#comment-16962906 ] Dawid Wysakowicz commented on FLINK-13702: -- I had a look at this issue and I th

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-08-14 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907007#comment-16907007 ] Jingsong Lee commented on FLINK-13702: -- Hi [~jark], TypeSerializer can be not threa

[jira] [Commented] (FLINK-13702) BaseMapSerializerTest.testDuplicate fails on Travis

2019-08-13 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906807#comment-16906807 ] Jark Wu commented on FLINK-13702: - Could you have a look [~lzljs3620320]? It might becau