[GitHub] [hbase] anoopsjohn commented on a change in pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-08-04 Thread GitBox
anoopsjohn commented on a change in pull request #2113: URL: https://github.com/apache/hbase/pull/2113#discussion_r464827401 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java ## @@ -71,7 +71,11 @@ private static void

[GitHub] [hbase] virajjasani commented on a change in pull request #2188: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe (branch-1)

2020-08-04 Thread GitBox
virajjasani commented on a change in pull request #2188: URL: https://github.com/apache/hbase/pull/2188#discussion_r464833942 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java ## @@ -3020,16 +3011,26 @@ public HBaseCluster

[GitHub] [hbase] anoopsjohn commented on pull request #2187: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-04 Thread GitBox
anoopsjohn commented on pull request #2187: URL: https://github.com/apache/hbase/pull/2187#issuecomment-668452417 Can u pls fix the checkstyle issue and look at the Test fail (TestLogRoller seems related) This is an

[GitHub] [hbase] pankaj72981 commented on pull request #2082: HBASE-24570 connection#close throws NPE

2020-08-04 Thread GitBox
pankaj72981 commented on pull request #2082: URL: https://github.com/apache/hbase/pull/2082#issuecomment-668455613 @cuibo01 Is this issue applicable to other branches (master/2/2.3) as well? if yes, please raise PR.

[GitHub] [hbase] Apache-HBase commented on pull request #2187: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2187: URL: https://github.com/apache/hbase/pull/2187#issuecomment-668450105 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Updated] (HBASE-24815) hbase-connectors mvn install error

2020-08-04 Thread leookok (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leookok updated HBASE-24815: Description: *when maven command-line* mvn -Dspark.version=2.2.2 -Dscala.version=2.11.7

[jira] [Commented] (HBASE-24754) Bulk load performance is degraded in HBase 2

2020-08-04 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170710#comment-17170710 ] ramkrishna.s.vasudevan commented on HBASE-24754: Thanks [~sreenivasulureddy]. {code}

[GitHub] [hbase] Apache-HBase commented on pull request #2184: HBASE-24680 Refactor the checkAndMutate code on the server side

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2184: URL: https://github.com/apache/hbase/pull/2184#issuecomment-668474837 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2191: URL: https://github.com/apache/hbase/pull/2191#issuecomment-668496996 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24795) RegionMover should deal with unknown (split/merged) regions

2020-08-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24795: - Fix Version/s: 2.4.0 2.3.1 3.0.0-alpha-1 > RegionMover

[jira] [Commented] (HBASE-24295) [Chaos Monkey] abstract logging through the class hierarchy

2020-08-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170713#comment-17170713 ] Hudson commented on HBASE-24295: Results for branch branch-1 [build #1337 on

[jira] [Commented] (HBASE-22263) Master creates duplicate ServerCrashProcedure on initialization, leading to assignment hanging in region-dense clusters

2020-08-04 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170653#comment-17170653 ] Bo Cui commented on HBASE-22263: [~busbey] yeah, the issue affects only branch-1 i will raise a new

[jira] [Created] (HBASE-24815) hbase-connectors mvn install error

2020-08-04 Thread leookok (Jira)
leookok created HBASE-24815: --- Summary: hbase-connectors mvn install error Key: HBASE-24815 URL: https://issues.apache.org/jira/browse/HBASE-24815 Project: HBase Issue Type: Bug

[jira] [Updated] (HBASE-24754) Bulk load performance is degraded in HBase 2

2020-08-04 Thread Y. SREENIVASULU REDDY (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Y. SREENIVASULU REDDY updated HBASE-24754: -- Attachment: Branch1.3_putSortReducer_sampleCode.patch > Bulk load performance

[jira] [Updated] (HBASE-24754) Bulk load performance is degraded in HBase 2

2020-08-04 Thread Y. SREENIVASULU REDDY (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Y. SREENIVASULU REDDY updated HBASE-24754: -- Attachment: Branch2_putSortReducer_sampleCode.patch > Bulk load performance

[jira] [Updated] (HBASE-24507) Remove HTableDescriptor and HColumnDescriptor

2020-08-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24507: -- Release Note: Removed HTableDescriptor and HColumnDescritor. Please use TableDescriptor and

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-08-04 Thread GitBox
anoopsjohn commented on a change in pull request #2113: URL: https://github.com/apache/hbase/pull/2113#discussion_r464896310 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java ## @@ -71,7 +71,11 @@ private static void

[jira] [Commented] (HBASE-24754) Bulk load performance is degraded in HBase 2

2020-08-04 Thread Y. SREENIVASULU REDDY (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170687#comment-17170687 ] Y. SREENIVASULU REDDY commented on HBASE-24754: --- Attached the sample code to reproduce the

[jira] [Comment Edited] (HBASE-24754) Bulk load performance is degraded in HBase 2

2020-08-04 Thread Y. SREENIVASULU REDDY (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170687#comment-17170687 ] Y. SREENIVASULU REDDY edited comment on HBASE-24754 at 8/4/20, 9:58 AM:

[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica

2020-08-04 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171136#comment-17171136 ] Michael Stack commented on HBASE-18070: --- Implementation notes by Huaxiang and myself. > Enable

[jira] [Created] (HBASE-24819) Fix flaky test TestRaceBetweenSCPAndDTP for branch-2.2

2020-08-04 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24819: -- Summary: Fix flaky test TestRaceBetweenSCPAndDTP for branch-2.2 Key: HBASE-24819 URL: https://issues.apache.org/jira/browse/HBASE-24819 Project: HBase

[jira] [Assigned] (HBASE-24819) Fix flaky test TestRaceBetweenSCPAndDTP for branch-2.2

2020-08-04 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24819: -- Assignee: Guanghao Zhang > Fix flaky test TestRaceBetweenSCPAndDTP for branch-2.2 >

[GitHub] [hbase] Apache-HBase commented on pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2196: URL: https://github.com/apache/hbase/pull/2196#issuecomment-668844676 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-08-04 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171121#comment-17171121 ] Michael Stack commented on HBASE-24749: --- One comment on the [~zyork]  approach is that if a

[jira] [Comment Edited] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-08-04 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171116#comment-17171116 ] Tak-Lon (Stephen) Wu edited comment on HBASE-24749 at 8/4/20, 8:59 PM:

[GitHub] [hbase] Apache-HBase commented on pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2193: URL: https://github.com/apache/hbase/pull/2193#issuecomment-668838364 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio opened a new pull request #2199: HBASE-24819 Fix flaky test TestRaceBetweenSCPAndDTP and TestRaceBetwe…

2020-08-04 Thread GitBox
infraio opened a new pull request #2199: URL: https://github.com/apache/hbase/pull/2199 …enSCPAndTRSP for branch-2.2 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (HBASE-24817) Allow configuring WALEntry filters on ReplicationSource

2020-08-04 Thread Michael Stack (Jira)
Michael Stack created HBASE-24817: - Summary: Allow configuring WALEntry filters on ReplicationSource Key: HBASE-24817 URL: https://issues.apache.org/jira/browse/HBASE-24817 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2196: URL: https://github.com/apache/hbase/pull/2196#issuecomment-668838894 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] joshelser commented on pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on pull request #2193: URL: https://github.com/apache/hbase/pull/2193#issuecomment-668872729 > TestWALEntryStream timed out for me too. Will dig in. Ah, a mocking issue. Fixing. This is an

[jira] [Updated] (HBASE-24819) Fix flaky test TestRaceBetweenSCPAndDTP and TestRaceBetweenSCPAndTRSP for branch-2.2

2020-08-04 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24819: --- Summary: Fix flaky test TestRaceBetweenSCPAndDTP and TestRaceBetweenSCPAndTRSP for

[GitHub] [hbase] saintstack opened a new pull request #2198: HBASE-24817 Allow configuring WALEntry filters on ReplicationSource

2020-08-04 Thread GitBox
saintstack opened a new pull request #2198: URL: https://github.com/apache/hbase/pull/2198 Allow specifying base WALEntry filter on construction of ReplicationSource. Add means of being able to filter WALs by name.

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-08-04 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171129#comment-17171129 ] Zach York commented on HBASE-24749: --- Yep, could do that as well. I was suggesting opening up only the

[GitHub] [hbase] joshelser commented on pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on pull request #2193: URL: https://github.com/apache/hbase/pull/2193#issuecomment-668870260 Interesting. TestWALEntryStream timed out for me too. Will dig in. This is an automated message from the Apache

[jira] [Commented] (HBASE-24812) Fix the precommit error for branch-2.2

2020-08-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171179#comment-17171179 ] Hudson commented on HBASE-24812: Results for branch branch-2.2 [build #925 on

[jira] [Resolved] (HBASE-24818) Fix the precommit error for branch-1

2020-08-04 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24818. Resolution: Duplicate Sorry. Duplicate with HBASE-24816. > Fix the precommit error for

[jira] [Created] (HBASE-24818) Fix the precommit error for branch-1

2020-08-04 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24818: -- Summary: Fix the precommit error for branch-1 Key: HBASE-24818 URL: https://issues.apache.org/jira/browse/HBASE-24818 Project: HBase Issue Type:

[GitHub] [hbase] tedyu commented on a change in pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-04 Thread GitBox
tedyu commented on a change in pull request #2196: URL: https://github.com/apache/hbase/pull/2196#discussion_r465341971 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/regionserver/LogRollBackupSubprocedurePool.java ## @@ -62,10 +62,9 @@ public

[GitHub] [hbase] tedyu commented on a change in pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-04 Thread GitBox
tedyu commented on a change in pull request #2196: URL: https://github.com/apache/hbase/pull/2196#discussion_r465341971 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/regionserver/LogRollBackupSubprocedurePool.java ## @@ -62,10 +62,9 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #2198: HBASE-24817 Allow configuring WALEntry filters on ReplicationSource

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2198: URL: https://github.com/apache/hbase/pull/2198#issuecomment-668840966 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2193: URL: https://github.com/apache/hbase/pull/2193#issuecomment-668841506 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24818) Fix the precommit error for branch-1

2020-08-04 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24818: --- Fix Version/s: 1.7.0 > Fix the precommit error for branch-1 >

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-08-04 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171116#comment-17171116 ] Tak-Lon (Stephen) Wu commented on HBASE-24749: -- sorry for the delay, I was out few days

[jira] [Created] (HBASE-24820) [hbase-thirdparty] Add jersey-hk2 when shading jersey

2020-08-04 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24820: - Summary: [hbase-thirdparty] Add jersey-hk2 when shading jersey Key: HBASE-24820 URL: https://issues.apache.org/jira/browse/HBASE-24820 Project: HBase Issue Type:

[jira] [Commented] (HBASE-24795) RegionMover should deal with unknown (split/merged) regions

2020-08-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171261#comment-17171261 ] Hudson commented on HBASE-24795: Results for branch branch-2 [build #2768 on

[jira] [Commented] (HBASE-24808) skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore: Can NOT create CleanerDelegate= ClassNotFoundException)

2020-08-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171260#comment-17171260 ] Hudson commented on HBASE-24808: Results for branch branch-2 [build #2768 on

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465154338 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java ## @@ -244,17 +248,22 @@ void

[jira] [Updated] (HBASE-24816) Fix pre-commit on branch-1

2020-08-04 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24816: - Component/s: tooling build > Fix pre-commit on branch-1 >

[jira] [Created] (HBASE-24816) Fix pre-commit on branch-1

2020-08-04 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-24816: Summary: Fix pre-commit on branch-1 Key: HBASE-24816 URL: https://issues.apache.org/jira/browse/HBASE-24816 Project: HBase Issue Type: Bug

[GitHub] [hbase] Apache-HBase commented on pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2193: URL: https://github.com/apache/hbase/pull/2193#issuecomment-668766824 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv merged pull request #2195: HBASE-24816: Remove unused credential hbaseqa-at-asf-jira

2020-08-04 Thread GitBox
bharathv merged pull request #2195: URL: https://github.com/apache/hbase/pull/2195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2196: URL: https://github.com/apache/hbase/pull/2196#issuecomment-668782334 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] busbey closed pull request #2188: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe (branch-1)

2020-08-04 Thread GitBox
busbey closed pull request #2188: URL: https://github.com/apache/hbase/pull/2188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2193: URL: https://github.com/apache/hbase/pull/2193#issuecomment-668698173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24816) Fix pre-commit on branch-1

2020-08-04 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24816: - Description: After move to ci-hadoop, branch-1 precommits are unable to

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465212657 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -276,6 +274,8 @@ public

[jira] [Assigned] (HBASE-24750) All executor service should start using our internal ThreadFactory

2020-08-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24750: Assignee: Viraj Jasani > All executor service should start using our internal

[GitHub] [hbase] Apache-HBase commented on pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2130: URL: https://github.com/apache/hbase/pull/2130#issuecomment-668775483 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] joshelser commented on pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on pull request #2193: URL: https://github.com/apache/hbase/pull/2193#issuecomment-668731763 Thanks folks! Just pushed a couple more commits for cleanup on QA and wellington's suggestions. I'll merge when QA is happy.

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465218113 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java ## @@ -314,4

[jira] [Updated] (HBASE-24816) Fix pre-commit on branch-1

2020-08-04 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24816: - Description: After move to ci-hadoop, branch-1 precommits are unable to

[GitHub] [hbase] bharathv opened a new pull request #2195: HBASE-24816: Remove unused credential hbaseqa-at-asf-jira

2020-08-04 Thread GitBox
bharathv opened a new pull request #2195: URL: https://github.com/apache/hbase/pull/2195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-24816) Remove unused credential hbaseqa-at-asf-jira

2020-08-04 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24816: - Summary: Remove unused credential hbaseqa-at-asf-jira (was: Fix pre-commit on

[jira] [Resolved] (HBASE-24816) Fix pre-commit on branch-1

2020-08-04 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada resolved HBASE-24816. -- Fix Version/s: 1.7.0 Resolution: Fixed > Fix pre-commit on branch-1 >

[GitHub] [hbase] Apache-HBase commented on pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2193: URL: https://github.com/apache/hbase/pull/2193#issuecomment-668783695 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on a change in pull request #2197: HBASE-24807 Backport HBASE-20417 to branch-1

2020-08-04 Thread GitBox
bharathv commented on a change in pull request #2197: URL: https://github.com/apache/hbase/pull/2197#discussion_r465296034 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReaderThread.java ## @@ -132,6 +135,10 @@

[GitHub] [hbase] Apache-HBase commented on pull request #2187: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2187: URL: https://github.com/apache/hbase/pull/2187#issuecomment-668667329 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] busbey commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
busbey commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465182276 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java ## @@ -1,253

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465154178 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java ## @@ -314,4

[jira] [Updated] (HBASE-24805) HBaseTestingUtility.getConnection should be threadsafe

2020-08-04 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24805: Fix Version/s: 2.4.0 1.7.0 3.0.0-alpha-1 Hadoop Flags:

[jira] [Updated] (HBASE-24816) Fix pre-commit on branch-1

2020-08-04 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24816: - Affects Version/s: 1.7.0 > Fix pre-commit on branch-1 >

[jira] [Work started] (HBASE-24750) All executor service should start using guava ThreadFactory

2020-08-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24750 started by Viraj Jasani. > All executor service should start using guava ThreadFactory >

[GitHub] [hbase] bharathv commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-04 Thread GitBox
bharathv commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r464801901 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -2931,6 +2935,27 @@ public GetActiveMasterResponse

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465189517 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java ## @@ -1,253

[GitHub] [hbase] Apache-HBase commented on pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2130: URL: https://github.com/apache/hbase/pull/2130#issuecomment-668711613 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bharathv commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
bharathv commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465216898 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java ## @@ -314,4

[jira] [Commented] (HBASE-24672) HBase Shell Commands Survey

2020-08-04 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171093#comment-17171093 ] Elliot Miller commented on HBASE-24672: --- I added one more column ("uses formatter') to the

[GitHub] [hbase] bharathv commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
bharathv commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465146006 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java ## @@ -314,4

[GitHub] [hbase] Apache-HBase commented on pull request #2195: HBASE-24816: Remove unused credential hbaseqa-at-asf-jira

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2195: URL: https://github.com/apache/hbase/pull/2195#issuecomment-668723359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Updated] (HBASE-24750) All executor service should start using guava ThreadFactory

2020-08-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24750: - Description: Currently, we have majority Executor services using guava's ThreadFactoryBuilder

[jira] [Updated] (HBASE-24750) All executor service should start using guava ThreadFactory

2020-08-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24750: - Description: Currently, we have majority Executor services using guava's ThreadFactoryBuilder

[jira] [Updated] (HBASE-24750) All executor service should start using guava ThreadFactory

2020-08-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24750: - Summary: All executor service should start using guava ThreadFactory (was: All executor

[GitHub] [hbase] Apache-HBase commented on pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2193: URL: https://github.com/apache/hbase/pull/2193#issuecomment-668759278 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wchevreuil commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
wchevreuil commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465159767 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java ## @@ -1,253

[GitHub] [hbase] taklwu commented on a change in pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-08-04 Thread GitBox
taklwu commented on a change in pull request #2113: URL: https://github.com/apache/hbase/pull/2113#discussion_r465204694 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java ## @@ -71,7 +71,11 @@ private static void

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465204713 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java ## @@ -1,253

[GitHub] [hbase] virajjasani opened a new pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-04 Thread GitBox
virajjasani opened a new pull request #2196: URL: https://github.com/apache/hbase/pull/2196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] wchevreuil opened a new pull request #2197: HBASE-24807 Backport HBASE-20417 to branch-1

2020-08-04 Thread GitBox
wchevreuil opened a new pull request #2197: URL: https://github.com/apache/hbase/pull/2197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2130: URL: https://github.com/apache/hbase/pull/2130#issuecomment-668778886 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465100973 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java ## @@ -314,4

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465101199 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java ## @@ -497,6 +497,33 @@ public boolean

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465102036 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java ## @@ -76,4 +77,13

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465103092 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java ## @@ -244,17 +248,22 @@ void

[jira] [Commented] (HBASE-24808) skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore: Can NOT create CleanerDelegate= ClassNotFoundException)

2020-08-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170852#comment-17170852 ] Hudson commented on HBASE-24808: Results for branch branch-2.3 [build #199 on

[GitHub] [hbase] joshelser commented on a change in pull request #2193: HBASE-24779 Report on the WAL edit buffer usage/limit for replication

2020-08-04 Thread GitBox
joshelser commented on a change in pull request #2193: URL: https://github.com/apache/hbase/pull/2193#discussion_r465118725 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java ## @@ -76,4 +77,13

[GitHub] [hbase] Apache-HBase commented on pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-04 Thread GitBox
Apache-HBase commented on pull request #2191: URL: https://github.com/apache/hbase/pull/2191#issuecomment-668551955 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24815) hbase-connectors mvn install error

2020-08-04 Thread leookok (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leookok updated HBASE-24815: Description: *when maven command-line* mvn -Dspark.version=2.2.2 -Dscala.version=2.11.7

[jira] [Commented] (HBASE-24754) Bulk load performance is degraded in HBase 2

2020-08-04 Thread Y. SREENIVASULU REDDY (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170727#comment-17170727 ] Y. SREENIVASULU REDDY commented on HBASE-24754: --- Thanks [~ram_krish] for looking into this

[GitHub] [hbase] WenFeiYi closed pull request #2152: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-04 Thread GitBox
WenFeiYi closed pull request #2152: URL: https://github.com/apache/hbase/pull/2152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] WenFeiYi opened a new pull request #2194: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-04 Thread GitBox
WenFeiYi opened a new pull request #2194: URL: https://github.com/apache/hbase/pull/2194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   >