[GitHub] [hbase] Reidddddd edited a comment on pull request #2585: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

Reidd edited a comment on pull request #2585: URL: https://github.com/apache/hbase/pull/2585#issuecomment-718341999 > Curious whats the context for this change? Noticed something fishy there in the call queue? The main purpose is to gain better insight of the whole rpc process

[GitHub] [hbase] brfrn169 edited a comment on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

brfrn169 edited a comment on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-718287389 The failed UT is not related to the patch. It was successful locally. I removed the new additional Scanner things from the patch and added the following document

[GitHub] [hbase] Apache-HBase commented on pull request #2585: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

Apache-HBase commented on pull request #2585: URL: https://github.com/apache/hbase/pull/2585#issuecomment-718386600 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718552316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718639479 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2595: HBASE-25090 CompactionConfiguration logs unrealistic store file sizes

Apache-HBase commented on pull request #2595: URL: https://github.com/apache/hbase/pull/2595#issuecomment-718684251 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anoopsjohn commented on pull request #2594: HBASE-25227 [branch-1] Cast in UnsafeAccess to avoid Java 11 runtime issue

anoopsjohn commented on pull request #2594: URL: https://github.com/apache/hbase/pull/2594#issuecomment-718503775 > +1, what about directly changing BYTE_ARRAY_BASE_OFFSET's type to long Ya that single change will be enough then and can avoid all cast

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718427635 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Reidddddd commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

Reidd commented on a change in pull request #2591: URL: https://github.com/apache/hbase/pull/2591#discussion_r514092739 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSplit.java ## @@ -184,9 +184,24 @@ public TableSplit(final byte []

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718399581 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] GeorryHuang opened a new pull request #2595: HBASE-25090 CompactionConfiguration logs unrealistic store file sizes

GeorryHuang opened a new pull request #2595: URL: https://github.com/apache/hbase/pull/2595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase-native-client] bharathv opened a new pull request #14: HBASE-23105: Download lib double conversion, fizz, update folly

bharathv opened a new pull request #14: URL: https://github.com/apache/hbase-native-client/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase-native-client] Apache-HBase commented on pull request #14: HBASE-23105: Download lib double conversion, fizz, update folly

Apache-HBase commented on pull request #14: URL: https://github.com/apache/hbase-native-client/pull/14#issuecomment-719178082 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[GitHub] [hbase-native-client] Apache-HBase commented on pull request #14: HBASE-23105: Download lib double conversion, fizz, update folly

Apache-HBase commented on pull request #14: URL: https://github.com/apache/hbase-native-client/pull/14#issuecomment-719187264 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 357

[GitHub] [hbase-native-client] bharathv commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

bharathv commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-719185147 I figured out the issue, submitted a new PR with my patch on top #14. A quick summary of my patch addition - Patched fizz/wangle to find boost libs and pass

[GitHub] [hbase] Apache-HBase commented on pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

Apache-HBase commented on pull request #2591: URL: https://github.com/apache/hbase/pull/2591#issuecomment-719165758 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-718706220 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-718705999 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-718709754 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-718775649 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25223) Use try-with-resources statement in snapshot package

[ https://issues.apache.org/jira/browse/HBASE-25223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223156#comment-17223156 ] Hudson commented on HBASE-25223: Results for branch branch-2 [build #87 on

[jira] [Commented] (HBASE-25224) Maximize sleep for checking meta and namespace regions availability

[ https://issues.apache.org/jira/browse/HBASE-25224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223157#comment-17223157 ] Hudson commented on HBASE-25224: Results for branch branch-2 [build #87 on

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-718979616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

Apache-HBase commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-718978987 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2385: HBASE-24950 Another solution for Splittable Meta

Apache-HBase commented on pull request #2385: URL: https://github.com/apache/hbase/pull/2385#issuecomment-718914945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

Apache-HBase commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-718913446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-718918341 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2594: HBASE-25227 [branch-1] Fix Java 11 runtime issue in UnsafeAccess

Apache-HBase commented on pull request #2594: URL: https://github.com/apache/hbase/pull/2594#issuecomment-718933092 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m

[GitHub] [hbase] ndimiduk commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

ndimiduk commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r514493750 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,78 @@ static final

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514512363 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -577,6 +635,15 @@ private void

[GitHub] [hbase] Apache9 commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

Apache9 commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r514222462 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4569,13 +4665,29 @@ private void

[GitHub] [hbase] virajjasani commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

virajjasani commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r514160584 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -9000,6 +9173,51 @@ public long getReadPoint() {

[GitHub] [hbase] Apache9 commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache9 commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514224110 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSelector.java ## @@ -0,0 +1,46 @@ +/** + *

[GitHub] [hbase] Apache9 commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache9 commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514232329 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #2595: HBASE-25090 CompactionConfiguration logs unrealistic store file sizes

Apache-HBase commented on pull request #2595: URL: https://github.com/apache/hbase/pull/2595#issuecomment-718754483 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache9 commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache9 commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514228087 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -577,6 +635,15 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2595: HBASE-25090 CompactionConfiguration logs unrealistic store file sizes

Apache-HBase commented on pull request #2595: URL: https://github.com/apache/hbase/pull/2595#issuecomment-718749861 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25221) Backport HBASE-24368 "Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null"

[ https://issues.apache.org/jira/browse/HBASE-25221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222911#comment-17222911 ] Peter Somogyi commented on HBASE-25221: --- The original commit (HBASE-24368) was merged to

[GitHub] [hbase] Apache-HBase commented on pull request #2385: HBASE-24950 Another solution for Splittable Meta

Apache-HBase commented on pull request #2385: URL: https://github.com/apache/hbase/pull/2385#issuecomment-718800705 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r514337192 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8730,12 +8868,22 @@ public void startRegionOperation()

[jira] [Commented] (HBASE-25176) MasterStoppedException should be moved to hbase-client module

[ https://issues.apache.org/jira/browse/HBASE-25176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222880#comment-17222880 ] Hudson commented on HBASE-25176: Results for branch master [build #109 on

[jira] [Commented] (HBASE-25201) YouAreDeadException should be moved to hbase-server module

[ https://issues.apache.org/jira/browse/HBASE-25201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222881#comment-17222881 ] Hudson commented on HBASE-25201: Results for branch master [build #109 on

[jira] [Commented] (HBASE-25224) Maximize sleep for checking meta and namespace regions availability

[ https://issues.apache.org/jira/browse/HBASE-25224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222883#comment-17222883 ] Hudson commented on HBASE-25224: Results for branch master [build #109 on

[jira] [Commented] (HBASE-25223) Use try-with-resources statement in snapshot package

[ https://issues.apache.org/jira/browse/HBASE-25223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222882#comment-17222882 ] Hudson commented on HBASE-25223: Results for branch master [build #109 on

[GitHub] [hbase] Apache-HBase commented on pull request #2595: HBASE-25090 CompactionConfiguration logs unrealistic store file sizes

Apache-HBase commented on pull request #2595: URL: https://github.com/apache/hbase/pull/2595#issuecomment-718779796 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r514337192 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8730,12 +8868,22 @@ public void startRegionOperation()

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

sandeepvinayak commented on a change in pull request #2591: URL: https://github.com/apache/hbase/pull/2591#discussion_r514528418 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSplit.java ## @@ -184,9 +184,24 @@ public TableSplit(final byte []

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-719002752 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-719012161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell merged pull request #2578: HBASE-24768 Clear cached service kerberos ticket in case of SASL fail…

apurtell merged pull request #2578: URL: https://github.com/apache/hbase/pull/2578 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514580314 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java ## @@ -182,8 +183,20 @@ public void

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223221#comment-17223221 ] Sandeep Guggilam commented on HBASE-25032: -- [~anoop.hbase] [~apurtell]  I spent some time

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514583501 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -196,8 +202,43 @@ private boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-719042209 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-719052727 Update to address some of comments from Stack. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-719054811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] bharathv commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

bharathv commented on a change in pull request #2591: URL: https://github.com/apache/hbase/pull/2591#discussion_r514590686 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScanBase.java ## @@ -271,6 +272,11 @@ public void

[jira] [Resolved] (HBASE-24463) Allow operator to limit total normalization work per invocation

[ https://issues.apache.org/jira/browse/HBASE-24463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24463. -- Resolution: Won't Fix The ability to limit the normalizer is now provided by rate limiting.

[jira] [Resolved] (HBASE-25090) CompactionConfiguration logs unrealistic store file sizes

[ https://issues.apache.org/jira/browse/HBASE-25090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25090. --- Fix Version/s: 2.4.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[GitHub] [hbase] ndimiduk merged pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

ndimiduk merged pull request #2490: URL: https://github.com/apache/hbase/pull/2490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ndimiduk opened a new pull request #2596: Backport "HBASE-24419 Normalizer merge plans should consider more than 2 region…" to branch-2

ndimiduk opened a new pull request #2596: URL: https://github.com/apache/hbase/pull/2596 …s when possible The core change here is to the loop in `SimpleRegionNormalizer#computeMergeNormalizationPlans`. It's a nested loop that walks the table's region chain once, looking for

[GitHub] [hbase] apurtell merged pull request #2594: HBASE-25227 [branch-1] Fix Java 11 runtime issue in UnsafeAccess

apurtell merged pull request #2594: URL: https://github.com/apache/hbase/pull/2594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] apurtell commented on pull request #2594: HBASE-25227 [branch-1] Fix Java 11 runtime issue in UnsafeAccess

apurtell commented on pull request #2594: URL: https://github.com/apache/hbase/pull/2594#issuecomment-719038355 I'm not sure what happened here. Applying the commit locally. This is an automated message from the Apache Git

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514584611 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -196,8 +202,43 @@ private boolean

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514588062 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -577,6 +635,15 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

Apache-HBase commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-718982958 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

saintstack commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514543049 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java ## @@ -182,8 +183,20 @@ public void newDead(ServerName

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514587250 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -433,9 +474,24 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-719063108 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

sandeepvinayak commented on a change in pull request #2591: URL: https://github.com/apache/hbase/pull/2591#discussion_r514525613 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScanBase.java ## @@ -271,6 +272,11 @@ public void

[GitHub] [hbase] saintstack merged pull request #2595: HBASE-25090 CompactionConfiguration logs unrealistic store file sizes

saintstack merged pull request #2595: URL: https://github.com/apache/hbase/pull/2595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2596: Backport "HBASE-24419 Normalizer merge plans should consider more than 2 region…" to branch-2

Apache-HBase commented on pull request #2596: URL: https://github.com/apache/hbase/pull/2596#issuecomment-719035664 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Updated] (HBASE-25227) [branch-1] Fix Java 11 runtime issue in UnsafeAccess

[ https://issues.apache.org/jira/browse/HBASE-25227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25227: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was:

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-719041537 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514396843 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -577,6 +635,15 @@ private void

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514400512 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514400318 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSelector.java ## @@ -0,0 +1,46 @@ +/** + *

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r514400489 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8777,23 +8936,36 @@ public void

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718875966 @Apache9 I am having trouble responding to your comment above. > After reading this discussion several times, I think the reason we do not want to niterrupte a WAL sync

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718875966 @Apache9 I am having trouble responding to your comment above. > After reading this discussion several times, I think the reason we do not want to niterrupte a WAL

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718875966 @Apache9 I am having trouble responding to your comment above. > After reading this discussion several times, I think the reason we do not want to niterrupte a WAL

[GitHub] [hbase] apurtell commented on pull request #2594: HBASE-25227 [branch-1] Cast in UnsafeAccess to avoid Java 11 runtime issue

apurtell commented on pull request #2594: URL: https://github.com/apache/hbase/pull/2594#issuecomment-718889835 > directly changing BYTE_ARRAY_BASE_OFFSET's type to long Ok This is an automated message from the Apache

[GitHub] [hbase] nkalmar edited a comment on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

nkalmar edited a comment on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-718901775 Why is this so flaky? Different 5 tests this time, only 1 test last time :( All of them seems to be timeout issues.

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r514337192 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8730,12 +8868,22 @@ public void startRegionOperation()

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

apurtell commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-718871541 Unit test failure seems unrelated, probable flaky test [ERROR] TestDurability.testDurability:132->verifyWALCount:242 expected:<10> but was:<9>

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r514400950 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -9000,6 +9173,51 @@ public long getReadPoint() {

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r514401694 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -577,6 +635,15 @@ private void

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718875966 @Apache9 I am having trouble responding to your comment above. > After reading this discussion several times, I think the reason we do not want to niterrupte a WAL

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718875966 @Apache9 I am having trouble responding to your comment above. > After reading this discussion several times, I think the reason we do not want to niterrupte a WAL

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718875966 @Apache9 I am having trouble responding to your comment above. > After reading this discussion several times, I think the reason we do not want to niterrupte a WAL

[jira] [Commented] (HBASE-25224) Maximize sleep for checking meta and namespace regions availability

[ https://issues.apache.org/jira/browse/HBASE-25224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223065#comment-17223065 ] Hudson commented on HBASE-25224: Results for branch branch-2.3 [build #93 on

[GitHub] [hbase] nkalmar commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

nkalmar commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-718901775 Why is this so flaky? Different 5 tests this time, only 1 test last time :( This is an automated message from the

[jira] [Updated] (HBASE-25227) [branch-1] Fix Java 11 runtime issue in UnsafeAccess

[ https://issues.apache.org/jira/browse/HBASE-25227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25227: Description: When running tests with Java 11 UnsafeAccess is observed to throw

[jira] [Updated] (HBASE-25227) [branch-1] Fix Java 11 runtime issue in UnsafeAccess

[ https://issues.apache.org/jira/browse/HBASE-25227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25227: Summary: [branch-1] Fix Java 11 runtime issue in UnsafeAccess (was: [branch-1]

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-718855909 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-718857112 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2595: HBASE-25090 CompactionConfiguration logs unrealistic store file sizes

Apache-HBase commented on pull request #2595: URL: https://github.com/apache/hbase/pull/2595#issuecomment-718860254 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2595: HBASE-25090 CompactionConfiguration logs unrealistic store file sizes

Apache-HBase commented on pull request #2595: URL: https://github.com/apache/hbase/pull/2595#issuecomment-718861846 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-24845) Git/Jira Release Audit: limit branches when building audit db

[ https://issues.apache.org/jira/browse/HBASE-24845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24845. -- Resolution: Fixed Thanks for the review [~apurtell] > Git/Jira Release Audit: limit branches

[jira] [Updated] (HBASE-24845) Git/Jira Release Audit: limit branches when building audit db

[ https://issues.apache.org/jira/browse/HBASE-24845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24845: - Component/s: community > Git/Jira Release Audit: limit branches when building audit db >

  1   2   >