[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219072#comment-16219072
]
Hudson commented on HBASE-19057:
FAILURE: Integrated in Jenkins build HBase-2.0 #748 (See
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218503#comment-16218503
]
Duo Zhang commented on HBASE-19057:
---
Just done a rebase. It is clean so I think it is safe to just
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218168#comment-16218168
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218163#comment-16218163
]
Zheng Hu commented on HBASE-19057:
--
[~Apache9], I've committed this patch into branch HBASE-18410, you
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218058#comment-16218058
]
stack commented on HBASE-19057:
---
bq. I've updated the release note with more details about the bug fix, I
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218055#comment-16218055
]
Zheng Hu commented on HBASE-19057:
--
bq. Can fix the mis-comment on commit.
I've fixed the comment what
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218020#comment-16218020
]
stack commented on HBASE-19057:
---
Don't bother with the VOTE thread. Let me add to the end of the DISCUSS
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218015#comment-16218015
]
Duo Zhang commented on HBASE-19057:
---
[~openinx] Let's commit the patch here. And then I will do a final
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218012#comment-16218012
]
stack commented on HBASE-19057:
---
[~openinx] Push. Can fix the mis-comment on commit. If [~Apache9] can't do
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218004#comment-16218004
]
Ted Yu commented on HBASE-19057:
I have no other comment for this JIRA.
> Fix other code review comments
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217993#comment-16217993
]
Zheng Hu commented on HBASE-19057:
--
[~tedyu]
bq. Can you add comment explaining why NEXT_ROW would be
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217820#comment-16217820
]
stack commented on HBASE-19057:
---
That looks good.
> Fix other code review comments about FilterList
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217818#comment-16217818
]
Hadoop QA commented on HBASE-19057:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217341#comment-16217341
]
Ted Yu commented on HBASE-19057:
For FilterListWithOR :
{code}
+ if (isInReturnCodes(rc,
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217227#comment-16217227
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217216#comment-16217216
]
stack commented on HBASE-19057:
---
builds.apache.org is borked (broke). Not working. FYI. I'll try and get
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216659#comment-16216659
]
Zheng Hu commented on HBASE-19057:
--
The last UT failed because of H5 is offlined.
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216456#comment-16216456
]
Zheng Hu commented on HBASE-19057:
--
Thanks Duo's careful work. I checked the code, no other errors
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216322#comment-16216322
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216254#comment-16216254
]
Duo Zhang commented on HBASE-19057:
---
Done a rebase and force push. There are conflicts, mainly because
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216221#comment-16216221
]
Duo Zhang commented on HBASE-19057:
---
OK, let me rebase first.
> Fix other code review comments about
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216076#comment-16216076
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215606#comment-16215606
]
stack commented on HBASE-19057:
---
On patch, yeah, be careful with those Docker file changes... Make sure you
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215595#comment-16215595
]
stack commented on HBASE-19057:
---
bq. So what is a typical way of merging back a feature branch sir stack?
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215574#comment-16215574
]
Hadoop QA commented on HBASE-19057:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215470#comment-16215470
]
Hadoop QA commented on HBASE-19057:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215043#comment-16215043
]
Duo Zhang commented on HBASE-19057:
---
Hey [~anoopsamjohn], do we need a rebase and force push on
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215033#comment-16215033
]
Zheng Hu commented on HBASE-19057:
--
bq. Change in docket file is as per the recent change in trunk?
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215028#comment-16215028
]
Anoop Sam John commented on HBASE-19057:
Change in docket file is as per the recent change in
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215025#comment-16215025
]
Hadoop QA commented on HBASE-19057:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214990#comment-16214990
]
Anoop Sam John commented on HBASE-19057:
As discussed above, better we keep the original way of
[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214988#comment-16214988
]
Zheng Hu commented on HBASE-19057:
--
The failed Hadoop QA is caused by downloading Oracle JDK, I'll
32 matches
Mail list logo
