[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315800#comment-16315800
]
Hudson commented on HBASE-19696:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4361 (See
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315617#comment-16315617
]
Zheng Hu commented on HBASE-19696:
--
Filed issue HBASE-19729 for the mergeFilterResponse optimization.
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315333#comment-16315333
]
Anoop Sam John commented on HBASE-19696:
+1
> Filter returning INCLUDE_AND_NEXT_COL doesn't skip
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313812#comment-16313812
]
Ted Yu commented on HBASE-19696:
[~anoopsamjohn]:
Is the patch good by you ?
> Filter returning
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313215#comment-16313215
]
Ted Yu commented on HBASE-19696:
+1
> Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313199#comment-16313199
]
Hadoop QA commented on HBASE-19696:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313011#comment-16313011
]
Ankit Singhal commented on HBASE-19696:
---
bq. Or can we make doneWithColumn() in ColumnTracker
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311396#comment-16311396
]
Ted Yu commented on HBASE-19696:
ExplicitColumnTracker is marked Private.
I feel adding doneWithColumn()
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311136#comment-16311136
]
Hadoop QA commented on HBASE-19696:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311086#comment-16311086
]
Zheng Hu commented on HBASE-19696:
--
Fine, I'm OK :-)
> Filter returning INCLUDE_AND_NEXT_COL doesn't
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311085#comment-16311085
]
Anoop Sam John commented on HBASE-19696:
Can we fix the other issue as part of another jira pls?
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311082#comment-16311082
]
Anoop Sam John commented on HBASE-19696:
Nice digging in Ankit.. Thanks for the great work.
On
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311081#comment-16311081
]
Zheng Hu commented on HBASE-19696:
--
{code}
case INCLUDE_AND_SEEK_NEXT_ROW:
+if (matchCode
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311073#comment-16311073
]
Ankit Singhal commented on HBASE-19696:
---
Thank you guys for the review.
bq. BTW, I have another
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309650#comment-16309650
]
Ted Yu commented on HBASE-19696:
Ankit:
Nice catch.
Nice test.
> Filter returning INCLUDE_AND_NEXT_COL
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309644#comment-16309644
]
Zheng Hu commented on HBASE-19696:
--
bq. we can't return the code from getNextRowOrNextColumn(cell) as
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309642#comment-16309642
]
Hadoop QA commented on HBASE-19696:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309593#comment-16309593
]
Ankit Singhal commented on HBASE-19696:
---
bq. Can we just write 'return
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309575#comment-16309575
]
Duo Zhang commented on HBASE-19696:
---
Ping [~openinx]. You may also want to look at this problem?
>
[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309573#comment-16309573
]
Duo Zhang commented on HBASE-19696:
---
Can we just write 'return columns.getNextRowOrNextColumn(cell);'?
20 matches
Mail list logo