[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315800#comment-16315800 ] Hudson commented on HBASE-19696: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4361 (See

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-07 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315617#comment-16315617 ] Zheng Hu commented on HBASE-19696: -- Filed issue HBASE-19729 for the mergeFilterResponse optimization.

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-07 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315333#comment-16315333 ] Anoop Sam John commented on HBASE-19696: +1 > Filter returning INCLUDE_AND_NEXT_COL doesn't skip

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313812#comment-16313812 ] Ted Yu commented on HBASE-19696: [~anoopsamjohn]: Is the patch good by you ? > Filter returning

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313215#comment-16313215 ] Ted Yu commented on HBASE-19696: +1 > Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313199#comment-16313199 ] Hadoop QA commented on HBASE-19696: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-05 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313011#comment-16313011 ] Ankit Singhal commented on HBASE-19696: --- bq. Or can we make doneWithColumn() in ColumnTracker

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311396#comment-16311396 ] Ted Yu commented on HBASE-19696: ExplicitColumnTracker is marked Private. I feel adding doneWithColumn()

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311136#comment-16311136 ] Hadoop QA commented on HBASE-19696: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-04 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311086#comment-16311086 ] Zheng Hu commented on HBASE-19696: -- Fine, I'm OK :-) > Filter returning INCLUDE_AND_NEXT_COL doesn't

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-04 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311085#comment-16311085 ] Anoop Sam John commented on HBASE-19696: Can we fix the other issue as part of another jira pls?

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-04 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311082#comment-16311082 ] Anoop Sam John commented on HBASE-19696: Nice digging in Ankit.. Thanks for the great work. On

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-04 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311081#comment-16311081 ] Zheng Hu commented on HBASE-19696: -- {code} case INCLUDE_AND_SEEK_NEXT_ROW: +if (matchCode

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-04 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311073#comment-16311073 ] Ankit Singhal commented on HBASE-19696: --- Thank you guys for the review. bq. BTW, I have another

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309650#comment-16309650 ] Ted Yu commented on HBASE-19696: Ankit: Nice catch. Nice test. > Filter returning INCLUDE_AND_NEXT_COL

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-03 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309644#comment-16309644 ] Zheng Hu commented on HBASE-19696: -- bq. we can't return the code from getNextRowOrNextColumn(cell) as

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309642#comment-16309642 ] Hadoop QA commented on HBASE-19696: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-03 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309593#comment-16309593 ] Ankit Singhal commented on HBASE-19696: --- bq. Can we just write 'return

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309575#comment-16309575 ] Duo Zhang commented on HBASE-19696: --- Ping [~openinx]. You may also want to look at this problem? >

[jira] [Commented] (HBASE-19696) Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns

2018-01-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309573#comment-16309573 ] Duo Zhang commented on HBASE-19696: --- Can we just write 'return columns.getNextRowOrNextColumn(cell);'?