[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856188#comment-16856188 ] Hudson commented on HBASE-21415: Results for branch master [build #1089 on

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855196#comment-16855196 ] Philippe Laflamme commented on HBASE-21415: --- [~elserj] LGTM > Admin#snapshot method

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855106#comment-16855106 ] Biju Nair commented on HBASE-21415: --- Sorry for the delay [~elserj]. The updates in the patch looks

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855063#comment-16855063 ] Josh Elser commented on HBASE-21415: [~plaflamme], aside from the line-length I missed, does v3 look

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854867#comment-16854867 ] HBase QA commented on HBASE-21415: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854759#comment-16854759 ] Josh Elser commented on HBASE-21415: {quote}noticed one problem with one of the comments. One of

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854736#comment-16854736 ] Josh Elser commented on HBASE-21415: {quote}I would specify whether this is per table or globally

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854568#comment-16854568 ] Philippe Laflamme commented on HBASE-21415: --- [~elserj] noticed one problem with one of the

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853858#comment-16853858 ] Josh Elser commented on HBASE-21415: [~gsbiju] or [~plaflamme], can either of you glance at my

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852476#comment-16852476 ] HBase QA commented on HBASE-21415: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852441#comment-16852441 ] Josh Elser commented on HBASE-21415: Stale patch and the patch didn't correct all of the instances

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847080#comment-16847080 ] HBase QA commented on HBASE-21415: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847068#comment-16847068 ] Biju Nair commented on HBASE-21415: --- Looks like the new patch takes into account the previous

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671935#comment-16671935 ] Josh Elser commented on HBASE-21415: {quote}Canceling patch to update with a new one. Not sure if

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671006#comment-16671006 ] Hadoop QA commented on HBASE-21415: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670929#comment-16670929 ] Philippe Laflamme commented on HBASE-21415: --- [~xucang] I've updated the patch with a comment

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670895#comment-16670895 ] Hadoop QA commented on HBASE-21415: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670832#comment-16670832 ] Josh Elser commented on HBASE-21415: Talked through this with Phil today in Slack. Best as I can

[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.

[ https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670824#comment-16670824 ] Xu Cang commented on HBASE-21415: - Nit: besides removing it, maybe also add "the HBase master will