[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856188#comment-16856188
]
Hudson commented on HBASE-21415:
Results for branch master
[build #1089 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1089/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1089//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1089//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1089//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HBASE-21415.002.patch, HBASE-21415.003.patch,
> HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855196#comment-16855196
]
Philippe Laflamme commented on HBASE-21415:
---
[~elserj] LGTM
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.002.patch, HBASE-21415.003.patch,
> HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855106#comment-16855106
]
Biju Nair commented on HBASE-21415:
---
Sorry for the delay [~elserj]. The updates in the patch looks fine.
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.002.patch, HBASE-21415.003.patch,
> HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855063#comment-16855063
]
Josh Elser commented on HBASE-21415:
[~plaflamme], aside from the line-length I missed, does v3 look good to you?
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.002.patch, HBASE-21415.003.patch,
> HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854867#comment-16854867
]
HBase QA commented on HBASE-21415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
41s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
32s{color} | {color:red} hbase-client: The patch generated 1 new + 35 unchanged
- 0 fixed = 36 total (was 35) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
40s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
13m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
14s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/481/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-21415 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970710/HBASE-21415.003.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5ca34dd5cb50 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul
13 08:53:17 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b4d5a9a8e1 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/481/artifact/patchprocess/diff-checkstyle-hbase-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/481/testReport/
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854759#comment-16854759
]
Josh Elser commented on HBASE-21415:
{quote}noticed one problem with one of the comments. One of them is missing a
period:
{quote}
I'm not seeing this, Phillipe. Are you sure it's missing a period, or maybe the
period is contained in code unchanged by the patch (e.g. on the next line)?
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.002.patch, HBASE-21415.patch,
> HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854736#comment-16854736
]
Josh Elser commented on HBASE-21415:
{quote}I would specify whether this is per table or globally (not sure which
one it is). e.g.
{quote}
It is global. Seems obvious to me, but I probably know more of the guts which
leads me to that conclusion :).
Let me update again with your feedback. Thanks!
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.002.patch, HBASE-21415.patch,
> HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854568#comment-16854568
]
Philippe Laflamme commented on HBASE-21415:
---
[~elserj] noticed one problem with one of the comments. One of them is missing
a period:
{quote}sequentially even when requested concurrentlySnapshots are considered
unique{quote}
Also, when it says
{quote}Snapshots are taken sequentially even when requested concurrently.{quote}
I would specify whether this is per table or globally (not sure which one it
is). e.g.
if it's per table:
{quote}Snapshots are taken sequentially even when requested concurrently, per
table.{quote}
or if it's globally:
{quote}Snapshots are taken sequentially even when requested concurrently,
across all tables.{quote}
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.002.patch, HBASE-21415.patch,
> HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853858#comment-16853858
]
Josh Elser commented on HBASE-21415:
[~gsbiju] or [~plaflamme], can either of you glance at my modified patch?
Should be an improvement, but want to make sure I didn't miss anything else
obvious :).
Backporting this will probably require unique patches. Maybe [~dbist13] would
want to help with that leg-work?
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.002.patch, HBASE-21415.patch,
> HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852476#comment-16852476
]
HBase QA commented on HBASE-21415:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
41s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
48s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
44s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
13m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
9s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/458/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-21415 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970405/HBASE-21415.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 7bb5ad1ead8e 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 98a1552687 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/458/testReport/ |
| Max. process+thread count | 276 (vs. ulimit of 1) |
| modules | C: hbase-client U: hbase-client |
| Console output |
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852441#comment-16852441
]
Josh Elser commented on HBASE-21415:
Stale patch and the patch didn't correct all of the instances of this incorrect
javadoc. Attached .002 which fixes them all.
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.002.patch, HBASE-21415.patch,
> HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847080#comment-16847080
]
HBase QA commented on HBASE-21415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-21415 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-21415 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946468/HBASE-21415.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/406/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847068#comment-16847068
]
Biju Nair commented on HBASE-21415:
---
Looks like the new patch takes into account the previous comments. Good to
commit [~elserj] ?
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671935#comment-16671935
]
Josh Elser commented on HBASE-21415:
{quote}Canceling patch to update with a new one. Not sure if this is how I
should do this though...
{quote}
[~plaflamme], in general what we suggest is to just include a "number" in your
patch name and then upload a new one when required.
e.g. your first patch might be HBASE-21415.001.patch, your second
HBASE-21415.002.patch.
We like seeing the evolution of patches (helps to see context during longer
reviews) and you can just leave the "state" as Patch-Available (QA will see the
new file you attached and try to test it).
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671006#comment-16671006
]
Hadoop QA commented on HBASE-21415:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 5m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
26s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
54s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 41s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 57m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21415 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946468/HBASE-21415.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2b7677db6e81 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 6d709c0311 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/14914/artifact/patchprocess/patch-unit-hbase-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14914/testReport/ |
| Max. process+thread count | 97 (vs. ulimit of 1) |
| modules | C: hbase-client U:
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670929#comment-16670929
]
Philippe Laflamme commented on HBASE-21415:
---
[~xucang] I've updated the patch with a comment about concurrency. Let me know
if it makes sense.
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670895#comment-16670895
]
Hadoop QA commented on HBASE-21415:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
8s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
4s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 5s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 31s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21415 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946457/HBASE-21415.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 17def5f132bf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 6d709c0311 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/14913/artifact/patchprocess/patch-unit-hbase-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14913/testReport/ |
| Max. process+thread count | 99 (vs. ulimit of 1) |
| modules | C: hbase-client U:
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670832#comment-16670832
]
Josh Elser commented on HBASE-21415:
Talked through this with Phil today in Slack.
Best as I can see, we synchronized on the MasterSnapshotManager methods,
through which all snapshot-creation requests flow. My hunch is that this
javadoc is from days-of-old, but didn't dig back into history to confirm.
Added Phil as a contributor and assigned this issue to him to track the
recognition. Thanks again!
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670824#comment-16670824
]
Xu Cang commented on HBASE-21415:
-
Nit: besides removing it, maybe also add "the HBase master will simply run them
sequentially " as you mentioned above? Thanks.
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Priority: Trivial
> Attachments: HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
