[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256228#comment-13256228 ] Hudson commented on HBASE-5788: --- Integrated in HBase-TRUNK-security #174 (See [https://builds.apache.org/job/HBase-TRUNK-security/174/]) HBASE-5788 Move Dynamic Metrics storage off of HRegion (Revision 1327316) Result = FAILURE stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionMetricsStorage.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerDynamicMetrics.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Fix For: 0.96.0 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255635#comment-13255635 ] Elliott Clark commented on HBASE-5788: -- RegionMetricsStorage could be a better name this class holds and mutates the numbers that will be exposed as dynamic region metrics. I'll add the comments, and check the line length. Not sure how I messed up eclipse. The data members can be package private now that they are in the regionserver.metrics package. I'll check to make sure. Everything else is accessed in the regionserver package so they need to be public :-/ TestRegionServerMetrics covers most of the functionality of the new class but I can create a new set of more explicit tests if you think that is needed. Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255645#comment-13255645 ] stack commented on HBASE-5788: -- bq. TestRegionServerMetrics covers most of the functionality of the new class but I can create a new set of more explicit tests if you think that is needed. Probably no need if we have some coverage already. Just want to make sure the class does its basic contract. Easier figuring this stuff in a unit test than up on a cluster, yadda, yadda, you know what I'm at. Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256005#comment-13256005 ] Hadoop QA commented on HBASE-5788: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523008/HBASE-5788-4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1557//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1557//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1557//console This message is automatically generated. Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256096#comment-13256096 ] Hudson commented on HBASE-5788: --- Integrated in HBase-TRUNK #2776 (See [https://builds.apache.org/job/HBase-TRUNK/2776/]) HBASE-5788 Move Dynamic Metrics storage off of HRegion (Revision 1327316) Result = FAILURE stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionMetricsStorage.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerDynamicMetrics.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Fix For: 0.96.0 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256110#comment-13256110 ] Enis Soztutar commented on HBASE-5788: -- bq. The next step will be to simplify the api exposed so that using it will be easier. @Elliot, do you have something in mind for this? While working on HBASE-5601, I also noticed that SchemaMetrics needs some simplification as well. Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Fix For: 0.96.0 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256114#comment-13256114 ] Elliott Clark commented on HBASE-5788: -- @Enis I was thinking of getting things more like HBASE-3614. I moved metrics about get/put/delete/icv into a helper class that mutates data in RegionMetricsStorage. I was hoping to go that way with pretty simple helper classes that expose update methods. Then SchemaMetrics can be mutated in the same way and metric naming can be handled by static helpers only. Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Fix For: 0.96.0 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256121#comment-13256121 ] Enis Soztutar commented on HBASE-5788: -- bq. I moved metrics about get/put/delete/icv into a helper class that mutates data in RegionMetricsStorage. I was hoping to go that way with pretty simple helper classes that expose update methods. Then SchemaMetrics can be mutated in the same way and metric naming can be handled by static helpers only. Ok, i see. Helper methods should help. But I think we should get rid of the static state there. I also left a comment on HBASE-3614. Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Fix For: 0.96.0 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255014#comment-13255014 ] Elliott Clark commented on HBASE-5788: -- On trying to add more to this class it became obvious to me that it needs more love than the first try. I'll roll this into exposing per region metrics. Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Attachments: HBASE-5788-0.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.
[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255323#comment-13255323 ] stack commented on HBASE-5788: -- Is MetricsStorage for Region metrics only? If so, call it RegionMetrics? Or maybe its generic metrics storage for this package? If so, the name is right. Should it be down in the metrics package? Regardless, new class needs class comment explaining class scope. Does it have to public? Can it be private to the package at least? Lines 100 chars. Why are data members in this new class public rather than private? Even if they are static. And static data members probably ain't a good idea because then there is one only per JVM and there can be many regionservers in the one JVM; e.g. in testing. Yeah, do its method names need to be public? Can these be package private? Hmm... maybe they need to be public because called from the metrics subpackage? I like all the code that comes out of HRegion. Thats good. And no harm in a basic unit test that your new class is basically working. Any worries w/ concurrent access? Good stuff Elliott. Move Dynamic Metrics storage off of HRegion. Key: HBASE-5788 URL: https://issues.apache.org/jira/browse/HBASE-5788 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, HBASE-5788-2.patch HRegion right now has the responsibility of storing static counts and latency numbers for use by the metrics package. Since these maps are incremented and set from lots of places it makes adding functionality hard. So move the metrics functionality into SchemaMetrics making it more than just a class for naming. The next step will be to simplify the api exposed so that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
