[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728874#comment-16728874
]
Saikat Maitra commented on IGNITE-3303:
---
[~dpavlov] [~amashenkov] [~agoncharuk] [~avinogradov]
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728768#comment-16728768
]
ASF GitHub Bot commented on IGNITE-3303:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713814#comment-16713814
]
Saikat Maitra commented on IGNITE-3303:
---
[~dpavlov] can you please review and merge this PR
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703056#comment-16703056
]
Andrew Mashenkov commented on IGNITE-3303:
--
Latch seems broken in master and Mvcc failures are
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702315#comment-16702315
]
Andrew Mashenkov commented on IGNITE-3303:
--
[~dpavlov],
Done, license & inspections & SPI
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702101#comment-16702101
]
Dmitriy Pavlov commented on IGNITE-3303:
[~amashenkov] could you please pull the latest master?
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700898#comment-16700898
]
Ignite TC Bot commented on IGNITE-3303:
---
{panel:title=Possible
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656016#comment-16656016
]
Saikat Maitra commented on IGNITE-3303:
---
[~amashenkov]
Thank you so much for your help.
Regards,
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654852#comment-16654852
]
Andrew Mashenkov commented on IGNITE-3303:
--
I've created a new PR base on #870, with some minor
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654769#comment-16654769
]
ASF GitHub Bot commented on IGNITE-3303:
GitHub user AMashenkov opened a pull request:
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654522#comment-16654522
]
Saikat Maitra commented on IGNITE-3303:
---
Hi [~agoncharuk]
Can you please review and let me know
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629722#comment-16629722
]
Saikat Maitra commented on IGNITE-3303:
---
[~dpavlov]
Thank you for clarification. I will no longer
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628520#comment-16628520
]
Dmitriy Pavlov commented on IGNITE-3303:
Hi [~samaitra] usually we don't reassign issue to a
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624794#comment-16624794
]
Saikat Maitra commented on IGNITE-3303:
---
Hi [~amashenkov]
I have updated the changes. Please
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616800#comment-16616800
]
Saikat Maitra commented on IGNITE-3303:
---
Hi [~amashenkov]
I have updated the tests and also added
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611856#comment-16611856
]
Andrew Mashenkov commented on IGNITE-3303:
--
[~samaitra]
The fail() call in catch block will be
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611467#comment-16611467
]
Saikat Maitra commented on IGNITE-3303:
---
[~amashenkov]
I have incorporated the review comments.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608178#comment-16608178
]
Saikat Maitra commented on IGNITE-3303:
---
[~amashenkov], [~agoncharuk]
I have incorporated the
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603827#comment-16603827
]
Saikat Maitra commented on IGNITE-3303:
---
[~amashenkov] [~agoncharuk]
Thank you for reviewing the
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603232#comment-16603232
]
Alexey Goncharuk commented on IGNITE-3303:
--
[~samaitra],
I've added some comments as well.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602946#comment-16602946
]
Andrew Mashenkov commented on IGNITE-3303:
--
[~samaitra],
I've add some notes to the Upsource
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596009#comment-16596009
]
Saikat Maitra commented on IGNITE-3303:
---
[~dpavlov]
All the changes are added in the PR, can you
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594558#comment-16594558
]
Saikat Maitra commented on IGNITE-3303:
---
[~amashenkov] Thank you for reviewing the changes. I have
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593239#comment-16593239
]
Saikat Maitra commented on IGNITE-3303:
---
[~dpavlov], [~amashenkov]
I have updated the PR with
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539929#comment-16539929
]
Dmitriy Pavlov commented on IGNITE-3303:
[~avinogradov] [~dmagda] could you advice expert here?
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539919#comment-16539919
]
Anton Vinogradov commented on IGNITE-3303:
--
[~samaitra],
Currently I have no opportunity to
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539556#comment-16539556
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Can you please review the changes and
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521324#comment-16521324
]
Saikat Maitra commented on IGNITE-3303:
---
[~dpavlov] [~avinogradov]
I have updated the PR and
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499509#comment-16499509
]
Saikat Maitra commented on IGNITE-3303:
---
[~dpavlov] [~avinogradov]
I am still working on this
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956867#comment-15956867
]
Anton Vinogradov commented on IGNITE-3303:
--
[~samaitra]
I don't think it's acceptable
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944491#comment-15944491
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Please review the changes and let me know
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942353#comment-15942353
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
I have not found any handlers
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942349#comment-15942349
]
Saikat Maitra commented on IGNITE-3303:
---
Tests report
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929439#comment-15929439
]
Saikat Maitra commented on IGNITE-3303:
---
[~vozerov]
Hi Vladimir,
I am still working on the tests.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927877#comment-15927877
]
Vladimir Ozerov commented on IGNITE-3303:
-
Hi [~samaitra],
Any news on the tickets?
> Apache
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752153#comment-15752153
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
I have identified an issue with
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752020#comment-15752020
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Thank you Anton. I will use the code
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751238#comment-15751238
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
We've got cool review tool.
Please start
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739530#comment-15739530
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
I have added Sink instead of
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676885#comment-15676885
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Thank you Anton for your feedback. I will
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676280#comment-15676280
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
1) Seems you fix not works.
I set
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674665#comment-15674665
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
Thank you for your feedback.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670037#comment-15670037
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
1) As far as I can see
{noformat}
stopped
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664759#comment-15664759
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
Thank you for your feedback.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15657165#comment-15657165
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
I've started review and still see that
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647420#comment-15647420
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
Thanks,
I'll review this in nearest days.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642201#comment-15642201
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
I have modified tests and fixed
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604674#comment-15604674
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
As far as I understand you have ExecTimeout
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602619#comment-15602619
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
The changes as we discussed are
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601340#comment-15601340
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
Please let me know when issue will be ready
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597215#comment-15597215
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton
I have noticed that when the
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597206#comment-15597206
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
I have fixed the test failures
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575974#comment-15575974
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Thank you Anton. I will check the
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568093#comment-15568093
]
Anton Vinogradov commented on IGNITE-3303:
--
Update.
According to
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567961#comment-15567961
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
There is no reason to validate, because
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565974#comment-15565974
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
I ran the tests in win7 with
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554281#comment-15554281
]
Anton Vinogradov commented on IGNITE-3303:
--
Hi,
it is java version "1.8.0_91"
Java(TM) SE
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552925#comment-15552925
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton
Thank you for reviewing the PR.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552207#comment-15552207
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
sorry for delay.
I've checked latest
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519744#comment-15519744
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
As discussed I have updated the
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491169#comment-15491169
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton
Thank you for your feedback.
2.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489721#comment-15489721
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
Thanks for comments
2. Before next review
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487999#comment-15487999
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Thank you Anton for reviewing the changes.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484010#comment-15484010
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
I've started from tests run, one failed, so
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464322#comment-15464322
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
sorry for the delay, I'll check changes
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439343#comment-15439343
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hello Anton,
I have made the following
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426937#comment-15426937
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Thank you Anton for your feedback. I will
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424111#comment-15424111
]
Anton Vinogradov commented on IGNITE-3303:
--
{noformat}
The LinkedBlockingQueue is static as we
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423029#comment-15423029
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
Thank you for your feedback. I
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421180#comment-15421180
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
I still see static fields, are they
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419851#comment-15419851
]
Saikat Maitra commented on IGNITE-3303:
---
[~dmagda]
Denis,
No problem. Thanks for letting me know.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419675#comment-15419675
]
Denis Magda commented on IGNITE-3303:
-
Saikat,
To my knowledge Anton is unavailable this and
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409725#comment-15409725
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
Please let me know if any
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399818#comment-15399818
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
I have modified the static
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397395#comment-15397395
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
I still see static fiellds, and they
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386383#comment-15386383
]
Saikat Maitra commented on IGNITE-3303:
---
[~avinogradov]
Hi Anton,
Thank you for reviewing the PR.
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385755#comment-15385755
]
Anton Vinogradov commented on IGNITE-3303:
--
Saikat,
I've made a couple of fixes related to
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383818#comment-15383818
]
Denis Magda commented on IGNITE-3303:
-
[~avinogradov], please review the changes.
> Apache Flink
[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380920#comment-15380920
]
ASF GitHub Bot commented on IGNITE-3303:
GitHub user samaitra opened a pull request:
79 matches
Mail list logo