[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337734#comment-17337734
]
Dawid Weiss commented on LUCENE-9947:
-
I think excluding javadocs from documentation should be done
rmuir opened a new pull request #119:
URL: https://github.com/apache/lucene/pull/119
jacoco plugin is activated by `-Ptests.coverage=true`
Each parallel jvm writes in append-mode to `jacoco.db` (we clear this out
before test-runs to be safe). e.g. you'll see 4 sessions if you have
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830573541
Also, just casually browsing and randomly clicking the first file that
looked interesting, I see huge chunks of untested code that surprised me. So I
really do think the problem is
rmuir commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624472119
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
dweiss commented on a change in pull request #120:
URL: https://github.com/apache/lucene/pull/120#discussion_r624451369
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -255,6 +255,14 @@ configure(subprojects) {
}
}
+configure(project(':lucene:luke')) {
+
mocobeta merged pull request #120:
URL: https://github.com/apache/lucene/pull/120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830618797
Hi,
I tested with jenkins, works fine. For Jenkins it is enough to run tests
with `tests.coverage=true` and configure the jenkins plugin to create the
reports and save them
dweiss commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624450643
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
rmuir commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624457772
##
File path: gradle/testing/randomization/policies/tests.policy
##
@@ -104,9 +104,16 @@ grant {
permission java.io.FilePermission
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830577840
@uschindler this uses defaults, which I think is HTML output only. We could
attach reports as artifacts in jenkins as a start.
The plugin seems to support also CSV and XML
dweiss commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624465249
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337783#comment-17337783
]
Tomoko Uchida commented on LUCENE-9947:
---
We can embed the project version in the path to launch
uschindler edited a comment on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830618797
Hi,
I tested with jenkins, works fine. For Jenkins it is enough to run tests
with `tests.coverage=true` and configure the jenkins plugin to create the
reports and
uschindler commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624446845
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
rmuir commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624447305
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830577310
Looks fine to me, but haven't tested.
I would add a job to jenkins to run all tests with jacob and publish the
report as javadocs or similar (depending on plugin
rmuir commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624452579
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
rmuir commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624467798
##
File path: help/tests.txt
##
@@ -156,6 +156,16 @@ to increase the top-N count:
gradlew -p lucene/core test -Ptests.profile=true
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-9947.
---
Fix Version/s: main (9.0)
Assignee: Tomoko Uchida
Resolution: Fixed
> Don't
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337784#comment-17337784
]
ASF subversion and git services commented on LUCENE-9947:
-
Commit
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830619699
For easier setup on jenkins (maybe others may do this), let's rename the
database file to `jacoco.exec` instead of `jacoco.db`. It looks like this is
the standard.
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830572404
I'm reviving this issue as I think it's an easy win to keep an eye on this
coverage. Maybe I can work with @mikemccand to add reports to luceneutil, or
maybe ultimately we track
mocobeta opened a new pull request #120:
URL: https://github.com/apache/lucene/pull/120
This excludes Javadocs of luke module from the documentation site by
explicitly disable "renderSiteJavadoc" task for it.
While removing the link to javadocs, I added a short description and launch
mocobeta commented on a change in pull request #120:
URL: https://github.com/apache/lucene/pull/120#discussion_r624452737
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -255,6 +255,14 @@ configure(subprojects) {
}
}
+configure(project(':lucene:luke')) {
+
rmuir commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624454578
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337772#comment-17337772
]
ASF subversion and git services commented on LUCENE-9947:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9947:
--
Attachment: LUCENE-9947-embed-version-to-luke-path.patch
> Don't publish luke jar to Maven
dweiss commented on pull request #118:
URL: https://github.com/apache/lucene/pull/118#issuecomment-830557888
I think it's fine, @mocobeta!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337741#comment-17337741
]
Robert Muir commented on LUCENE-9946:
-
{quote}
I was aiming for consistency with the approach taken
[
https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337742#comment-17337742
]
Zach Chen commented on LUCENE-9335:
---
Hi [~jpountz], I've done another pass and fixed a few issues in
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337745#comment-17337745
]
ASF subversion and git services commented on LUCENE-9947:
-
Commit
mocobeta merged pull request #118:
URL: https://github.com/apache/lucene/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9947:
--
Attachment: docsite-8x.png
> Don't publish luke jar to Maven Central
>
dweiss commented on pull request #121:
URL: https://github.com/apache/lucene/pull/121#issuecomment-830688737
This piggybacks TLD update too. And sadly, it's very complex gradle code.
Again - I don't know of any way to simplify it and make it correct at the same
time.
--
This is an
dweiss opened a new pull request #121:
URL: https://github.com/apache/lucene/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337819#comment-17337819
]
Tomoko Uchida commented on LUCENE-9947:
---
We can partially backport the changes in documentation
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337822#comment-17337822
]
Tomoko Uchida commented on LUCENE-9947:
---
!docsite-8x.png|width=100%!
> Don't publish luke jar to
gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r624557991
##
File path: gradle/validation/jar-checks.gradle
##
@@ -140,41 +139,6 @@ subprojects {
}
}
- // Verifies that each JAR has a corresponding
gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r624567412
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums,
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830703824
Thanks Dawid, I changed the jenkins job to look for the other database file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830703849
The security settings are still not working, aren't they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830704527
My latest commit should fix the replicator module. It was a bug anyways,
because this missing permission silently disabled MMapDirectory.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9947:
--
Attachment: LUCENE-9947-backport-8x.patch
> Don't publish luke jar to Maven Central
>
[
https://issues.apache.org/jira/browse/LUCENE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337821#comment-17337821
]
ASF subversion and git services commented on LUCENE-9947:
-
Commit
dweiss commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r624560350
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums,
gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r624567412
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums,
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830706001
> This runs the tests and produces a report (printing its location to the
console). Seems nicer than having to remember jacoco's task names + property?
For developers,
dweiss commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830687911
I've changed the code slightly so that you can just say:
```
gradlew -p lucene/core test coverage
```
or even more briefly:
```
gradlew -p lucene/core coverage
uschindler removed a comment on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830703849
The security settings are still not working, aren't they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uschindler edited a comment on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830706797
Jenkins works now.
Replicator module works, too; but it has 2 new test failures (looks like
those 2 tests were never ran because MMAP was not working):
-
[
https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337948#comment-17337948
]
Zach Chen edited comment on LUCENE-9335 at 5/2/21, 4:16 AM:
I was trying to
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830707951
The replicator problem is not caused by MMAP not working. The missing
permission made the whole TestNRTReplication.testCrashReplica test not work at
all (the SimpleServer child
dsmiley commented on pull request #1139:
URL: https://github.com/apache/lucene-solr/pull/1139#issuecomment-830713953
Superseded by https://github.com/apache/solr/pull/111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dsmiley closed pull request #1139:
URL: https://github.com/apache/lucene-solr/pull/1139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337948#comment-17337948
]
Zach Chen commented on LUCENE-9335:
---
I was trying to modify the _CreateQueries_ class in luceneutil to
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830706797
Jenkins works now.
Replicator mdoule works, too; but it has 2 new test failures (looks like
those 2 tests were never ran because MMAP was not working):
-
uschindler edited a comment on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830707951
The replicator problem is not caused by MMAP not working. The missing
permission made the whole `TestNRTReplication.testCrashReplica` test not work
at all (the
[
https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach Chen updated LUCENE-9335:
--
Attachment: wikimedium.10M.nostopwords.tasks
> Add a bulk scorer for disjunctions that does dynamic
[
https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337942#comment-17337942
]
Greg Miller commented on LUCENE-9946:
-
Thanks [~rcmuir]. I've got a change mostly ready to clean up
59 matches
Mail list logo
