[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-16 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r441095444 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@ -406,15 +444,17 @@ private ModelSource

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-16 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r441095313 ## File path: maven-core/src/main/java/org/apache/maven/internal/aether/ConsumerModelSourceTransformer.java ## @@ -0,0 +1,111 @@ +package

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-16 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r441093443 ## File path: maven-core/src/main/java/org/apache/maven/project/ReactorModelPool.java ## @@ -19,53 +19,127 @@ * under the License. */ -import

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-16 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r441092529 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/AbstractModelSourceTransformer.java ## @@ -0,0 +1,196 @@ +package

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-14 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r439869758 ## File path: maven-xml/src/main/java/org/apache/maven/xml/sax/filter/AbstractEventXMLFilter.java ## @@ -0,0 +1,289 @@ +package

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-14 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r439869255 ## File path: maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java ## @@ -266,5 +279,41 @@ private String

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-14 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r439858810 ## File path: maven-xml/src/test/java/org/apache/maven/xml/sax/LexicalHandlerVerifier.java ## @@ -0,0 +1,277 @@ +package org.apache.maven.xml.sax; + +/* +

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-14 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r439854934 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@ -269,7 +273,7 @@ private DependencyResolutionResult

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-14 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r439853954 ## File path: maven-core/src/main/java/org/apache/maven/project/ProjectModelResolver.java ## @@ -285,6 +275,16 @@ public ModelSource resolveModel( final

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-14 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r439853720 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/AbstractModelSourceTransformer.java ## @@ -0,0 +1,196 @@ +package

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-14 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r439853622 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/AbstractModelSourceTransformer.java ## @@ -0,0 +1,196 @@ +package

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-14 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r439853476 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java ## @@ -646,8 +657,33 @@ else if ( modelSource

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-06-14 Thread GitBox
rfscholte commented on a change in pull request #286: URL: https://github.com/apache/maven/pull/286#discussion_r439853141 ## File path: maven-core/src/main/java/org/apache/maven/internal/aether/ConsumerModelSourceTransformer.java ## @@ -0,0 +1,111 @@ +package

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-14 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r392589127 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-14 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r392586609 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-14 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r392582965 ## File path: maven-core/src/main/java/org/apache/maven/project/ReactorModelPool.java ## @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-14 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r392578080 ## File path: maven-xml/src/test/java/org/apache/maven/xml/sax/LexicalHandlerVerifier.java ## @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-14 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r392577192 ## File path: maven-model-builder/src/main/java/org/apache/maven/feature/Features.java ## @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386618866 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386618453 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386614058 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386607205 ## File path: maven-xml/src/test/java/org/apache/maven/xml/sax/filter/ReactorDependencyXMLFilterTest.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386599766 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386592065 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-03-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386589451 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-02-29 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386045987 ## File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java ## @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-02-29 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386045615 ## File path: maven-core/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-02-29 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386045562 ## File path: maven-compat/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2020-02-09 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r376787962 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-16 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335708221 ## File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventUtils.java ## @@ -0,0 +1,38 @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335150201 ## File path: maven-xml/src/test/java/org/apache/maven/xml/filter/AbstractXMLFilterTests.java ##

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335149892 ## File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventFactory.java ## @@ -0,0 +1,111

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335149716 ## File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventUtils.java ## @@ -0,0 +1,38 @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335149584 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335147909 ## File path: maven-core/src/main/java/org/apache/maven/xml/internal/DefaultBuildPomXMLFilterFactory.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335147791 ## File path: maven-core/src/main/java/org/apache/maven/xml/internal/DefaultBuildPomXMLFilterFactory.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335147360 ## File path: maven-core/src/main/java/org/apache/maven/xml/filter/FastForwardFilter.java ## @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335147203 ## File path: maven-core/src/main/java/org/apache/maven/xml/filter/ConsumerPomXMLFilter.java ##

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r335146663 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r334773548 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r334773151 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/DependencyKey.java ## @@ -0,0

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r334772817 ## File path: maven-xml/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r334772348 ## File path: maven-core/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-12 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r334255176 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-12 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r334242784 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-03 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r331180213 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-03 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r331179612 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-03 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r331179612 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330389392 ## File path: maven-xml/src/test/java/org/apache/maven/xml/filter/AbstractXMLFilterTests.java ##

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330388940 ## File path: maven-core/src/main/java/org/apache/maven/xml/filter/FastForwardFilter.java ## @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330388340 ## File path: maven-core/src/main/java/org/apache/maven/xml/filter/ConsumerPomXMLFilter.java ##

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330387741 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330386987 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-02 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330386216 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330274591 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/BuildPomXMLFilterFactory.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330265590 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/BuildPomXMLFilterFactory.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330237064 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/DependencyKey.java ## @@ -0,0

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330236983 ## File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventUtils.java ## @@ -0,0 +1,38 @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330235852 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/BuildPomXMLFilterFactory.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330235426 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330234983 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330234343 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330232022 ## File path: maven-xml/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330204588 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330204200 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330201980 ## File path: maven-core/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330198943 ## File path: maven-core/src/main/java/org/apache/maven/xml/internal/DefaultBuildPomXMLFilterFactory.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330185735 ## File path: pom.xml ## @@ -47,8 +47,8 @@ under the License. 3.0.5 -1.7 -1.7