Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
Per @simonellistonball's comment, I removed the compiled Angular code from
the pom.xml excludes, and instead added them to the prepend_license_header.sh
script. In addition, I've added .n
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1121
METRON-1675: Add Pagination to PCAP
## Contributor Comments
This PR is a subtask of the PCAP feature branch. Simply put, it adds
pagination functionality to the PCAP results.
Unit
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1122
METRON-1683: Fix the download progress bar in PCAP UI
## Contributor Comments
The download progress bar in the current PCAP UI work does not appear when
a PCAP search is submitted.
To
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1122#discussion_r204801057
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -0,0 +1,71 @@
+import { Component, OnInit, Input
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1122#discussion_r204802074
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-list/pcap-list.component.spec.ts
---
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1122#discussion_r204802426
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@mmiklavc I've updated my PR description to include a testing section with
steps to reproduce. Please let me know if I can clarify any further.
@justinleet An empty results message i
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1121
@cestella I've added license headers to all the pcap files in [this
commit](https://github.com/apache/metron/pull/1103/commits/dd7c66d17ada01b1e9281f264cd174b0cf8c6639)
in PR
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r205746588
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.html
---
@@ -0,0 +1,19
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1103
@justinleet In response to your UI-related questions:
> Better input validation would be nice. I can currently enter negative
ports (which don't match anything) or ports beyond
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@merrimanr All tests should run fine now. As @ruffle1986 pointed out, I
accidentally left a focused describe method in my tests, which causes Jasmine
to only execute focused describe blocks. I have
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@merrimanr No problem. I began work on the service tests yesterday and
should have time to finish things up later today.
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@merrimanr I've increased test coverage in the pcap service to cover all
functions there. I also removed that large set of test pdml data and replaced
it with mock data.
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1103
@justinleet Here are the tickets for the follow-on items:
* Input validation: https://issues.apache.org/jira/browse/METRON-1712
* Kill button for in progress jobs:
https
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1139
METRON-1723: Unable to select/copy from packets details in PCAP query panel
## Contributor Comments
As pointed out in
[METRON-1723](https://issues.apache.org/jira/browse/METRON-1723), a user
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1121#discussion_r207940394
--- Diff:
metron-interface/metron-alerts/src/app/pcap/model/pcap-status-response.ts ---
@@ -0,0 +1,21 @@
+/**
+ * Licensed to the Apache Software
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1121#discussion_r208139712
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-pagination/pcap-pagination.component.html
---
@@ -0,0 +1,26 @@
+
+
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1121#discussion_r208139725
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-pagination/pcap-pagination.component.html
---
@@ -0,0 +1,26 @@
+
+
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@justinleet Thanks for the feedback. I've updated the panel component to
disable the submit button and display the progress bar on search submit rather
than first response from REST.
---
Github user sardell closed the pull request at:
https://github.com/apache/metron/pull/1121
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@justinleet No problem at all. Those conflicts have now been resolved.
---
Github user sardell closed the pull request at:
https://github.com/apache/metron/pull/1122
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1139
@justinleet Those merge conflicts are now resolved.
---
Github user sardell closed the pull request at:
https://github.com/apache/metron/pull/1139
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1156
@merrimanr I reviewed and tested on full dev. I have the same thought as
@ruffle1986 regarding the cancelling of the subscription. We should add that
line inside the ngOnDestroy lifecycle hook
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1156
+1. Tested on full dev.
---
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1158
METRON-1733: PCAP UI - PCAP queries don't work on Safari
## Contributor Comments
This PR fixes a bug where Safari cannot read the format of the date we are
passing to the startTimeM
Github user sardell closed the pull request at:
https://github.com/apache/metron/pull/1158
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1158
Closing and reopening to rerun Travis.
---
GitHub user sardell reopened a pull request:
https://github.com/apache/metron/pull/1158
METRON-1733: PCAP UI - PCAP queries don't work on Safari
## Contributor Comments
This PR fixes a bug where Safari cannot read the format of the date we are
passing to the startTimeM
Github user sardell closed the pull request at:
https://github.com/apache/metron/pull/1158
---
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211945169
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212012726
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@justinleet I completely agree. This PR is pretty big, so submitting the
`npm ci` fix in a separate PR would mitigate our risk if trying to include it
in the next release. I created a separate ASF
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1177
METRON-1752: Prevent package.lock from changing during build
## Contributor Comments
This PR updates the build script to use `npm ci` instead of `npm install`.
The former command installs
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1096#discussion_r213361764
--- Diff: metron-interface/metron-alerts/.nvmrc ---
@@ -0,0 +1 @@
+v9.11.1
--- End diff --
Thanks for pointing this out! The maven
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1096#discussion_r213364339
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.spec.ts
---
@@ -42,17 +42,18 @@ describe
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@justinleet I tested locally and ran into the same thing. Thanks for
catching this! The spec file has been updated.
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@nickwallen Will do.
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@nickwallen I've added the last of my changes. Almost all were related to
review feedback, but I did notice a deprecated class still being imported while
applying these feedback updates. My l
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@nickwallen @tiborm Sorry for the ongoing nature of this PR, but I've made
two small but important updates:
* The first has to do with rxjs import statements that weren't updated
aut
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1180
+1. Tested on full-dev, and everything works as expected. Good catch,
@tiborm.
---
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1096#discussion_r215198334
--- Diff: metron-interface/metron-alerts/README.md ---
@@ -45,7 +45,7 @@ Alerts that are contained in a a meta alert are generally
excluded from search r
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1199
+1. Tested as described above on full-dev.
---
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1217
METRON-1749: Update Angular to latest release in Management UI
## Contributor Comments
Link to ASF JIRA ticket: https://issues.apache.org/jira/browse/METRON-1749
This Pull Request contains
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1217
@mmiklavc Thanks for starting to take a look at this PR!
You're correct that all these changes are related to the upgrade. This
means removing deprecated items, updating syntax, util
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1217
@mmiklavc I was unable to find a discuss thread. I understand this is
standard for a change like this and I would be more than happy to start one if
the community desires, otherwise I'm hopi
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1217#discussion_r222949278
--- Diff: metron-interface/metron-config/package.json ---
@@ -7,10 +7,11 @@
},
"angular-cli": {},
"scripts"
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1240
METRON-1830: Re-implement Alerts dialog box without jQuery
## Contributor Comments
[Link to METRON-1830 on ASF
JIRA](https://issues.apache.org/jira/browse/METRON-1830)
Previously, the
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1240
@tiborm In regard to the 'Initial' state check, I was able to do what you
suggested but only after switching from a BehaviorSubject to a Subject. I did
this because Subjects do not
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1217
Just wanted to let everyone know about a small fix I just pushed to here.
It turns out that Angular's HttpParams class is immutable. As a result, I
needed to set new parameters when instanti
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1217
@justinleet Thanks for catching that! I updated metron.spec accordingly.
---
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1267
METRON-1873: Update Bootstrap version in Management UI
## Contributor Comments
Link to original ticket here:
https://jira.apache.org/jira/browse/METRON-1873
We are currently using an
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234283406
--- Diff:
metron-interface/metron-alerts/src/app/service/app-config.service.ts ---
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234287609
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.spec.ts
---
@@ -31,12 +31,20 @@ import { UpdateService
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234287807
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.spec.ts
---
@@ -32,6 +32,14 @@ import { UpdateService
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234287914
--- Diff: metron-interface/metron-alerts/src/app/app.module.ts ---
@@ -48,13 +48,11 @@ import { GlobalConfigService } from
'./service/global-config.se
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288056
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.spec.ts ---
@@ -33,6 +33,7 @@ import { PcapStatusResponse } from
'../model
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288083
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts ---
@@ -25,6 +25,7 @@ import { HttpUtil } from '../../utils/htt
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288118
--- Diff: metron-interface/metron-alerts/src/app/service/alerts.service.ts
---
@@ -22,14 +22,15 @@ import {Alert} from '../model/alert';
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288233
--- Diff:
metron-interface/metron-alerts/src/app/service/global-config.service.ts ---
@@ -21,14 +21,15 @@ import { Injectable } from '@angular
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288029
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.spec.ts
---
@@ -28,6 +28,7 @@ import { PcapRequest } from '../
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288184
--- Diff:
metron-interface/metron-alerts/src/app/service/authentication.service.ts ---
@@ -22,26 +22,28 @@ import {Router} from '@angular/r
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288308
--- Diff: metron-interface/metron-alerts/src/app/service/search.service.ts
---
@@ -30,6 +30,7 @@ import { RestError } from '../model/rest-
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288335
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -28,6 +28,7 @@ import {Utils} from '../utils/utils';
imp
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288280
--- Diff:
metron-interface/metron-alerts/src/app/service/meta-alert.service.ts ---
@@ -26,14 +26,15 @@ import {Alert} from '../model/alert';
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234289363
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts ---
@@ -47,47 +48,47 @@ export class PcapService {
public
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234296496
--- Diff:
metron-interface/metron-alerts/src/app/service/app-config.service.ts ---
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1266
After addressing my concerns listed, I think this looks great! It's nice to
have this architecture in place to make a change like this at runtime vs.
compile time. I can see us taking advanta
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1267#discussion_r235332053
--- Diff: metron-interface/metron-config/package-lock.json ---
@@ -39,50 +39,50 @@
"@angular-devkit/build-webpack&quo
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1284
Though I cannot vouch for the Java changes, the UI builds and runs fine. It
looks like the only change needed there is the removal of the replace request
model since, as you pointed out, there were
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1285
I was able to reproduce the failure and resolution as described in the
testing steps. +1.
---
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1294
METRON-1930: Update webpack-dev-server in Alerts UI
## Contributor Comments
After running `npm audit` in the Alerts UI, it looks like we need to update
our version of webpack-dev-server
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/998
METRON-1530: Default proxy config settings in metron-contrib need to be
updated
## Contributor Comments
The default target settings inside of metron-config's proxy.conf.json file
result
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1001
METRON-1532: Getting started documentation improvements
## Contributor Comments
I added the documentation items mentioned here:
https://issues.apache.org/jira/browse/METRON-1532
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1004
METRON-1489: Retrofit UI tests to run reliably during nightly QE runs
## Contributor Comments
This Pull Request includes work started by @iraghumitra on his branch
`e2e-using-await-1`. In
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r185477581
--- Diff:
metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts
---
@@ -23,64 +23,67 @@ import {loadTestData
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r185477602
--- Diff:
metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts
---
@@ -101,7 +104,7 @@ describe('metron-a
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r185477633
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/alert-status/alerts-list-status.e2e-spec.ts
---
@@ -44,84 +45,84 @@ describe('metron-alerts
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r185477658
--- Diff: metron-interface/metron-alerts/e2e/alerts-list/alerts-list.po.ts
---
@@ -272,63 +308,149 @@ export class MetronAlertsPage
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1004
@nickwallen This work is ready on my end. I'm happy with where I'm at since
addressing the feedback given by others here. The automated retries are to be
expected and means protracto
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1001#discussion_r187332809
--- Diff: metron-deployment/development/centos6/README.md ---
@@ -103,3 +103,8 @@ Tags are listed in the playbooks, some frequently used
tags:
+ `hdp
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r187354305
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.po.ts ---
@@ -97,21 +155,24 @@ export class TreeViewPage
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1010
METRON-1548: Remove hardcoded source:type from Alerts UI
## Contributor Comments
Instead of 'source:type' being hard coded as a string in the Alerts UI, we
now use a global-config
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r187971664
--- Diff: metron-interface/metron-alerts/README.md ---
@@ -126,7 +126,14 @@ The application will be available at http://host:4201
assuming the port is set
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1010#discussion_r188243982
--- Diff:
metron-interface/metron-alerts/src/app/service/global-config.service.ts ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1010
@justinleet I've changed the property to be `source.type.field` and added
the property to the documentation at
https://github.com/apache/metron/tree/master/metron-platform/metron-common#g
Github user sardell closed the pull request at:
https://github.com/apache/metron/pull/1010
---
GitHub user sardell reopened a pull request:
https://github.com/apache/metron/pull/1010
METRON-1548: Remove hardcoded source:type from Alerts UI
## Contributor Comments
Instead of 'source:type' being hard coded as a string in the Alerts UI, we
now use a global-config
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/956
Normalize is included with Bootstrap, so it isnât necessary to add it
again as an NPM dependency. You can see it being imported in the metron-alerts
application [on this
line](https://github.com
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/953
I think adding stylelint to this project would be great. Linters keep our
code looking consistent and make it easier to parse through and understand.
However, I don't think we should be adding
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/954
I think it's better to default to [coupling @types with their respective
modules in
package.json](https://github.com/Microsoft/types-publisher/issues/81).
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/952
> What yarn does is that reduces the possibility of version mismatch of the
dependencies by importing the dependencies subdependency in the right version
I believe npm also does this w
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/951
I think this is a good addition, as .editorconfig is included by default
with Angular CLI-generated projects and gives consistent formatting between
different contributors' editors. However,
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1010#discussion_r189261776
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.ts
---
@@ -77,12 +80,24 @@ export class
Github user sardell closed the pull request at:
https://github.com/apache/metron/pull/1004
---
GitHub user sardell reopened a pull request:
https://github.com/apache/metron/pull/1004
METRON-1489: Retrofit UI tests to run reliably
## Contributor Comments
This Pull Request includes work started by @iraghumitra on his branch
`e2e-using-await-1`. In addition to the asyn
Github user sardell closed the pull request at:
https://github.com/apache/metron/pull/1004
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1004
Re-running Travis.
---
GitHub user sardell reopened a pull request:
https://github.com/apache/metron/pull/1004
METRON-1489: Retrofit UI tests to run reliably
## Contributor Comments
This Pull Request includes work started by @iraghumitra on his branch
`e2e-using-await-1`. In addition to the asyn
1 - 100 of 115 matches
Mail list logo
