adamdebreceni opened a new pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
Adam Hunyadi created MINIFICPP-1393:
---
Summary: Deprecate set-env commads from the GitHub Actions runner
setup
Key: MINIFICPP-1393
URL: https://issues.apache.org/jira/browse/MINIFICPP-1393
Project:
Adam Debreceni created MINIFICPP-1392:
-
Summary: Some streams error when writing no data with zero length
Key: MINIFICPP-1392
URL: https://issues.apache.org/jira/browse/MINIFICPP-1392
Project:
fgerlits commented on a change in pull request #925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/925#discussion_r507599295
##
File path: .github/workflows/ci.yml
##
@@ -13,12 +13,11 @@ jobs:
- id: setup_env
run: |
echo -e
adamdebreceni opened a new pull request #927:
URL: https://github.com/apache/nifi-minifi-cpp/pull/927
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
[
https://issues.apache.org/jira/browse/MINIFICPP-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216698#comment-17216698
]
Gabor Gyimesi commented on MINIFICPP-1390:
--
Note: Currently adobe/S3Mock server does not
szaszm commented on a change in pull request #925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/925#discussion_r507720413
##
File path: .github/workflows/ci.yml
##
@@ -77,9 +75,8 @@ jobs:
ubuntu-16.04-ccache-refs/heads/main-
- id: install_deps
Adam Debreceni created MINIFICPP-1394:
-
Summary: Speed up ConsumeWindowsEventLog processor
Key: MINIFICPP-1394
URL: https://issues.apache.org/jira/browse/MINIFICPP-1394
Project: Apache NiFi MiNiFi
arpadboda commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507731802
##
File path: libminifi/include/utils/SmallString.h
##
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
arpadboda commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507733162
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool
arpadboda commented on a change in pull request #925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/925#discussion_r507589084
##
File path: .github/workflows/ci.yml
##
@@ -13,12 +13,11 @@ jobs:
- id: setup_env
run: |
echo -e
adamdebreceni edited a comment on pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#issuecomment-712128292
Given a GenerateFlowFile -> LogAttribute flow with 10'000 batchSize (for
both) and 10 byte payload, the length of the onTrigger is the following:
[
https://issues.apache.org/jira/browse/MINIFICPP-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits resolved MINIFICPP-1393.
---
Resolution: Duplicate
> Deprecate set-env commads from the GitHub Actions runner
adamdebreceni commented on pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#issuecomment-712128292
Given a GenerateFlowFile -> LogAttribute flow with 10'000 batchSize (for
both) and 10 byte payload, the length of the onTrigger is the following:
arpadboda closed pull request #925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/925
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
fgerlits commented on pull request #925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/925#issuecomment-712152393
> Is this unused?
Cmake doesn't look at the value of `CMAKE_BUILD_OPTIONS`; possibly the cmake
command line contained `... ${CMAKE_BUILD_OPTIONS} ...` at some
arpadboda closed pull request #927:
URL: https://github.com/apache/nifi-minifi-cpp/pull/927
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pgyori commented on a change in pull request #4603:
URL: https://github.com/apache/nifi/pull/4603#discussion_r507808251
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/servlets/ListenHTTPServlet.java
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507814242
##
File path: libminifi/src/core/ProcessSession.cpp
##
@@ -66,10 +66,12 @@ ProcessSession::~ProcessSession() {
}
void ProcessSession::add(const
pgyori commented on a change in pull request #4603:
URL: https://github.com/apache/nifi/pull/4603#discussion_r507819038
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
##
@@ -351,6
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507752703
##
File path: libminifi/include/utils/SmallString.h
##
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507761664
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
pgyori commented on pull request #4603:
URL: https://github.com/apache/nifi/pull/4603#issuecomment-712194518
> > > The concept of a health check for deployment behind a load balancer is
useful, but listening on a different port and having a different approach to
TLS negotiation may not be
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507750504
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507758324
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507815133
##
File path: libminifi/include/utils/SmallString.h
##
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/MINIFICPP-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits resolved MINIFICPP-1391.
---
Resolution: Fixed
> Update CI jobs to remove errors/warnings
>
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507760547
##
File path: libminifi/include/utils/SmallString.h
##
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
pgyori commented on a change in pull request #4603:
URL: https://github.com/apache/nifi/pull/4603#discussion_r507811792
##
File path:
[
https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216864#comment-17216864
]
Thanh Phuc Vo commented on NIFI-7012:
-
Dear [~alopresto] and [~markap14] could you please share the
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507746211
##
File path: libminifi/include/utils/SmallString.h
##
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507726059
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507746211
##
File path: libminifi/include/utils/SmallString.h
##
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507745780
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
szaszm commented on pull request #925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/925#issuecomment-712156537
I've deleted this question because I realized that you've already answered
it in the description. Thanks for the clarification.
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507766370
##
File path: libminifi/src/core/ProcessSession.cpp
##
@@ -66,10 +66,12 @@ ProcessSession::~ProcessSession() {
}
void
pgyori commented on a change in pull request #4603:
URL: https://github.com/apache/nifi/pull/4603#discussion_r507799954
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/servlets/HealthCheckServlet.java
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507760547
##
File path: libminifi/include/utils/SmallString.h
##
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507761664
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507780131
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool
thenatog commented on pull request #4250:
URL: https://github.com/apache/nifi/pull/4250#issuecomment-712293762
+1 from me, keen to get this merged so I can fix up my PR so we can get it
all merged it.
This is an automated
[
https://issues.apache.org/jira/browse/NIFI-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216959#comment-17216959
]
Andy LoPresto commented on NIFI-7924:
-
Thanks for opening the ticket and proposing a change. Please
[
https://issues.apache.org/jira/browse/NIFI-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7924:
Fix Version/s: (was: 1.13.0)
> Fallback claim(s) support in OIDC based authentication
>
[
https://issues.apache.org/jira/browse/NIFI-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7932:
Status: Patch Available (was: Open)
> Allow MonitorActivity's "Threshold Duration" property to use
[
https://issues.apache.org/jira/browse/NIFI-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7932:
Fix Version/s: (was: 1.12.1)
> Allow MonitorActivity's "Threshold Duration" property to use
[
https://issues.apache.org/jira/browse/NIFI-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216956#comment-17216956
]
Andy LoPresto commented on NIFI-7932:
-
Thanks for opening the ticket and submitting a patch. Please
jfrazee commented on a change in pull request #4250:
URL: https://github.com/apache/nifi/pull/4250#discussion_r507950335
##
File path:
Joe Witt created NIFI-7939:
--
Summary: Github CI/Actions has changed - requires updates to build
config
Key: NIFI-7939
URL: https://issues.apache.org/jira/browse/NIFI-7939
Project: Apache NiFi
exceptionfactory commented on a change in pull request #4250:
URL: https://github.com/apache/nifi/pull/4250#discussion_r508111993
##
File path:
jfrazee commented on a change in pull request #4592:
URL: https://github.com/apache/nifi/pull/4592#discussion_r508113540
##
File path:
jfrazee commented on pull request #4592:
URL: https://github.com/apache/nifi/pull/4592#issuecomment-712491718
I gave this a spin today and it works as expected. I tested with JKS stores
and ListFile with a network filesystem. I agree with some of the other
comments, but probably makes
kevinbsilva commented on pull request #4605:
URL: https://github.com/apache/nifi/pull/4605#issuecomment-712524341
Hello @pvillard31, thank you very much for your comment!
There is no particular reason at all, i thought it would be a good idea when
using older flows (from imports,
thenatog commented on pull request #4592:
URL: https://github.com/apache/nifi/pull/4592#issuecomment-712504637
One thing I'm trying to change is passing through the Zookeeper TLS
configuration from NiFi properties to the state provider. This will make
configuration a lot simpler and less
53 matches
Mail list logo
