[GitHub] nifi issue #1409: NIFI-1962 - Fixed NPE in toDate() EL function

2017-01-18 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1409 Thanks @pvillard31 All looks good to me, confirmed it addresses NullPointerException. I'm going to merge this into master. --- If your project is set up for it, you can reply to this emai

[GitHub] nifi issue #1142: NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logica...

2017-01-23 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1142 Hi @ToivoAdams @trixpan I've encountered similar issue. So I've researched and tried to use Avro 1.8.1 LogicalTypes, without knowing there's an existing JIRA and PR

[GitHub] nifi pull request #1417: NIFI-3339 Add getDataSource() to DBCPService.

2017-01-25 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1417#discussion_r97921016 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-api/src/main/java/org/apache/nifi/dbcp/DBCPService.java --- @@ -31,4 +33,6

[GitHub] nifi pull request #1417: NIFI-3339 Add getDataSource() to DBCPService.

2017-01-25 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1417#discussion_r97919769 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/test/java/org/apache/nifi/processors/hive/TestPutHiveQL.java --- @@ -493,8 +496,12

[GitHub] nifi pull request #1417: NIFI-3339 Add getDataSource() to DBCPService.

2017-01-25 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1417#discussion_r97923254 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-api/src/main/java/org/apache/nifi/dbcp/DBCPService.java --- @@ -31,4 +33,6

[GitHub] nifi issue #1448: NIFI-3387 Updated NOT_YET_CONNECTED value in Disconnection...

2017-01-26 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1448 @jtstorck Thanks for the correction, I will merge it into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1407: NIFI-2881: Added EL support to DB Fetch processors, allow ...

2017-01-27 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1407 @mattyb149 Thanks for the update. Sorry for the late response, somehow the notification was slipped through my attention.. I'm going to review it and comment soon! --- If your project i

[GitHub] nifi pull request #1426: NIFI-3363: PutKafka NPE with User-Defined partition...

2017-01-30 Thread ijokarumawak
Github user ijokarumawak closed the pull request at: https://github.com/apache/nifi/pull/1426 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1426: NIFI-3363: PutKafka NPE with User-Defined partition (0.x)

2017-01-30 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1426 Thanks @olegz ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1407: NIFI-2881: Added EL support to DB Fetch processors,...

2017-01-31 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1407#discussion_r98615920 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi pull request #1407: NIFI-2881: Added EL support to DB Fetch processors,...

2017-01-31 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1407#discussion_r98604070 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard

[GitHub] nifi pull request #1407: NIFI-2881: Added EL support to DB Fetch processors,...

2017-01-31 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1407#discussion_r98614712 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi pull request #1407: NIFI-2881: Added EL support to DB Fetch processors,...

2017-01-31 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1407#discussion_r98604895 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java

[GitHub] nifi pull request #1407: NIFI-2881: Added EL support to DB Fetch processors,...

2017-01-31 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1407#discussion_r98807002 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi pull request #1407: NIFI-2881: Added EL support to DB Fetch processors,...

2017-01-31 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1407#discussion_r98810570 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi issue #1417: NIFI-3339 Add getDataSource() to DBCPService.

2017-01-31 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1417 @ToivoAdams Would you close this PR as you opened new PR #1450 for the same JIRA. Usually, you just need to add commit to your branch and push it, in order to update a PR which is already

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-01-31 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1450 Hi @ToivoAdams , thank you for your contribution. I reviewed it and saw the sample code using Spring JDBC template. Then I felt that this can be done outside of DBCPService. Adding getDataSource

[GitHub] nifi pull request #1460: NIFI-3373: Add nifi.flow.configuration.archive.max....

2017-01-31 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1460 NIFI-3373: Add nifi.flow.configuration.archive.max.count - Add 'nifi.flow.configuration.archive.max.count' in nifi.properties - Change default archive limit so that it uses archiv

[GitHub] nifi pull request #1466: NIFI-3431: Support batch update in Notify processor

2017-02-01 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1466 NIFI-3431: Support batch update in Notify processor - Added Signal Counter Delta property - Added Signal Buffer Count property - Changed IOException handling from routing it to failure

[GitHub] nifi issue #1466: NIFI-3431: Support batch update in Notify processor

2017-02-02 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1466 Dear reviewer, I wrote a blog post on how to use Wait/Notify processors which can take benefit from this PR. I hope this helps: http://ijokarumawak.github.io/nifi/2017/02/02/nifi-notify-batch

[GitHub] nifi pull request #1407: NIFI-2881: Added EL support to DB Fetch processors,...

2017-02-02 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1407#discussion_r99103639 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard

[GitHub] nifi pull request #1407: NIFI-2881: Added EL support to DB Fetch processors,...

2017-02-02 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1407#discussion_r99103861 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi issue #1407: NIFI-2881: Added EL support to DB Fetch processors, allow ...

2017-02-02 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1407 Thanks @mattyb149 , LGTM! I've written up a Gist [NiFi Example: Change detection from Multiple Tables](https://gist.github.com/ijokarumawak/ed9085024fbca19cfb2f20d23ed4) with s

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-02-05 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1450 Hi @ToivoAdams I think we should think who should manage the DataSource instance. For me, that should be NiFi DBCPService, because it provides control via NiFi UI or REST API to users

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-02-06 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1450 @mattyb149 Thanks for sharing your use case. That's interesting. Why does your processor need DBCPService's URL? For provenance? If so, I'd prefer creating another interface l

[GitHub] nifi pull request #1476: NIFI-3162: Audit RPG and RPG port config changes

2017-02-06 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1476 NIFI-3162: Audit RPG and RPG port config changes - Added configure audits for Transport Protocol, HTTP Proxy Server Host, Port, User and Password in RemoteProcessGroup configuration

[GitHub] nifi pull request #1477: NIFI-1125 InvokeHTTP throws NullPointerException

2017-02-06 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1477 NIFI-1125 InvokeHTTP throws NullPointerException Added null check in onPropertyModified to avoid NPE. Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi pull request #1490: NIFI-3452: Add Wait processor Wait Mode property

2017-02-09 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1490 NIFI-3452: Add Wait processor Wait Mode property Ensure back-pressure is active until downstream processing completes. Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property

2017-02-09 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1490 Dear reviewer, an example flow template is available here: https://gist.github.com/ijokarumawak/85a3d77297ea94614e9f3f2a9dabca67 --- If your project is set up for it, you can reply to

[GitHub] nifi pull request #1496: NIFI-3414: Added EnforceOrder processor

2017-02-09 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1496 NIFI-3414: Added EnforceOrder processor Use it with FirstInFirstOutPrioritizer, it can enforce original ordering of 'out-of-order' FlowFiles. nifi-mock is modified

[GitHub] nifi issue #1496: NIFI-3414: Added EnforceOrder processor

2017-02-10 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1496 I've written a Gist with a flow template to describe how this is intended to work, hope this helps for reviewing PR. Thanks! https://gist.github.com/ijokaru

[GitHub] nifi issue #1497: NIFI-3454 Tests should consistently use the FileNameFilter...

2017-02-10 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1497 @ottobackwards Reviewed the changes. Confirmed that both test runs successfully even if there's a .DS_Store file in the test input directory. +1 Please note that when you submit a P

[GitHub] nifi issue #1497: NIFI-3454 Tests should consistently use the FileNameFilter...

2017-02-10 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1497 @ottobackwards Sorry, I forgot to add "This closes #. " in the commit message. Would you please close this PR? It's already merged in the master branch. Thanks! --- If your

[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property

2017-02-10 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1490 @basvank Thanks for confirming the change, that certainly make the review & merge process easier! --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property

2017-02-12 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1490 Thanks for reviewing, @pvillard31 . I've updated this PR: - Rebased with the latest master, just in case - Added display name and name - Corrected indent (probably this i

[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property

2017-02-12 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1490 As a side note, there's Notify processor which is designed to work together with Wait processor. Since there's an existing PR #1466 adding properties to Notify, I didn't touc

[GitHub] nifi pull request #1504: NIFI-3107: Unit test failure for DBCPServiceTest

2017-02-13 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1504 NIFI-3107: Unit test failure for DBCPServiceTest H2 and Kafka broker uses the same default port 9092. If an user is running Kafka broker on the same machine, or run the unit tests in

[GitHub] nifi issue #1394: NIFI-3255 removed dependency on session.merge from SplitTe...

2017-02-13 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1394 Hi @olegz have you had a chance to see my review comments? The issue not being able to generate fork provenance should be addressed. Thanks! --- If your project is set up for it, you can reply

[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...

2017-02-13 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 @qfdk Thanks for your contribution! Excuse us for taking so long to respond. Please note that when you submit a PR for a JIRA, push the "submit patch" button to move JIRA stat

[GitHub] nifi pull request #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTabl...

2017-02-13 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1376#discussion_r100969417 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java

[GitHub] nifi pull request #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTabl...

2017-02-13 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1376#discussion_r100967405 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java

[GitHub] nifi issue #1492: NIFI-3405 - Add uptime to JVM section in System Diagnostic...

2017-02-13 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1492 Reviewing.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] nifi issue #1492: NIFI-3405 - Add uptime to JVM section in System Diagnostic...

2017-02-14 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1492 @pvillard31 Thanks for the improvement! I've tested it with a standalone and cluster mode. Although uptime was displayed as expected, I felt the NiFi Cluster dialog became a littl

[GitHub] nifi issue #1405: NIFI-3294 Adjusting nifi.sh to invoke nifi-env.sh

2017-02-14 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1405 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] nifi issue #1405: NIFI-3294 Adjusting nifi.sh to invoke nifi-env.sh

2017-02-14 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1405 I was testing this PR using Amazon Linux. Checking if I can refer ${NIFI_HOME} environmental value via Attribute Expression Language, before and after applying the patch. I set run.as

[GitHub] nifi issue #1405: NIFI-3294 Adjusting nifi.sh to invoke nifi-env.sh

2017-02-14 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1405 Thanks @apiri , I didn't notice that nifi.sh has conflict. I used latest 1.2.0-SNAPSHOT and replaced nifi.sh with the one in this PR. I'll test it again once the conflict gets

[GitHub] nifi issue #1492: NIFI-3405 - Add uptime to JVM section in System Diagnostic...

2017-02-14 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1492 @pvillard31 Thanks for updating the PR, LGTM. Squashed and merged it into master branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1394: NIFI-3255 removed dependency on session.merge from ...

2017-02-15 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1394#discussion_r101223043 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java --- @@ -326,6

[GitHub] nifi issue #1394: NIFI-3255 removed dependency on session.merge from SplitTe...

2017-02-15 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1394 @olegz Thanks for updating the PR. Please check the comment I put on the provenance once again. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi pull request #1460: NIFI-3373: Add nifi.flow.configuration.archive.max....

2017-02-15 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1460#discussion_r101427041 --- Diff: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java --- @@ -972,11 +973,15 @@ public Integer

[GitHub] nifi pull request #1460: NIFI-3373: Add nifi.flow.configuration.archive.max....

2017-02-15 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1460#discussion_r101433687 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1934,9 +1934,10 @@ The first section of the _nifi.properties_ file is for the

[GitHub] nifi issue #1460: NIFI-3373: Add nifi.flow.configuration.archive.max.count

2017-02-15 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1460 Following Joe's +1, squashed and merged it into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-16 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1335 @trixpan Thanks for reviewing and catching the unit test failure. Yes, I'd like to look at it closer. I will update the PR accordingly. --- If your project is set up for it, you can rep

[GitHub] nifi issue #1496: NIFI-3414: Added EnforceOrder processor

2017-02-16 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1496 Hey @pvillard31 thanks for trying out this PR. I've update it to use both `.name()` and `.displayName`. Please let me know if you find anything suspicious during your test. --- If your pr

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-16 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1335 @trixpan Since the failing test has more Thread.sleep calls than before, the meaning of variables such as `age1` or `age2` became fragile at the later part of the test. I added another commit to

[GitHub] nifi pull request #1405: NIFI-3294 Adjusting nifi.sh to invoke nifi-env.sh

2017-02-17 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1405#discussion_r101703153 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi.sh --- @@ -284,18 +281,21 @@ run

[GitHub] nifi pull request #1405: NIFI-3294 Adjusting nifi.sh to invoke nifi-env.sh

2017-02-17 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1405#discussion_r101703608 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi.sh --- @@ -284,18 +281,21 @@ run

[GitHub] nifi pull request #1335: NIFI-3213: ListFile - Do not skip obviously old fil...

2017-02-17 Thread ijokarumawak
Github user ijokarumawak closed the pull request at: https://github.com/apache/nifi/pull/1335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-17 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1335 @trixpan Thank you for merging! closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1405: NIFI-3294 Adjusting nifi.sh to invoke nifi-env.sh

2017-02-19 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1405 @apiri Thanks for the fix. Confirmed it runs with/without run.as configuration. LGTM +1. Merging into master. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #1332: NIFI-3163: Flow Fingerprint should include new RPG configu...

2017-02-19 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1332 @trixpan Rebased with the latest master, confirmed contrib check passed locally. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1523: NIFI-3505: Fix nifi.sh restart

2017-02-20 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1523 NIFI-3505: Fix nifi.sh restart The 'exec' command added by NIFI-2689 affected restart behavior negatively as 'exec' command will not execute subsequent commands in

[GitHub] nifi issue #1523: NIFI-3505: Fix nifi.sh restart

2017-02-20 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1523 I tested this PR on Ubuntu to confirm below: 1. 'exec' works as NIFI-2689 expected. 2. Don't break NIFI-3294, nifi-env.sh being used properly with 'run.as' confi

[GitHub] nifi issue #1523: NIFI-3505: Fix nifi.sh restart

2017-02-20 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1523 Hi @automaticgiant , unfortunately, 'exec' command added into nifi.sh by #966 broke `nifi.sh restart` to work properly. I tried fixing it with this PR. I confirmed that '

[GitHub] nifi issue #1522: NIFI-3508 Added support for PATCH identical to that of PUT...

2017-02-20 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1522 Thanks @nickcarenza for contributing this improvement. I'm going to review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] nifi issue #1522: NIFI-3508 Added support for PATCH identical to that of PUT...

2017-02-21 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1522 Reviewed code and docs updates, unit test passed, and using InvokeHTTP, HandleHTTPRequest and Response, confirmed that incoming FlowFile contents can be sent with PATCH method. All looks good

[GitHub] nifi issue #1523: NIFI-3505: Fix nifi.sh restart

2017-02-21 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1523 Thank you @patricker @joewitt . I considered about merging this right away, but since this piece is so crucial, I ask @apiri to look at this PR, too, just in case. As he's working on the

[GitHub] nifi pull request #1527: NIFI-3189: ConsumeKafka & Back-pressure. ConsumeKaf...

2017-02-22 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1527 NIFI-3189: ConsumeKafka & Back-pressure. ConsumeKafka_0_10 While downstream connections are full, ConsumeKafka is not scheduled to run onTrigger, and it won't perform poll,

[GitHub] nifi issue #1527: NIFI-3189: ConsumeKafka & Back-pressure. ConsumeKafka_0_10

2017-02-22 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1527 Dear reviewers, This PR contains handful debug level logs that would make easier to understand how the additional thread is working. To see those log messages, modify `conf/logback.xml

[GitHub] nifi issue #1525: NIFI-3294 (0.x) - Adjusting nifi.sh to invoke nifi-env.sh ...

2017-02-22 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1525 Thanks for updating. Reviewing.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1525: NIFI-3294 (0.x) - Adjusting nifi.sh to invoke nifi-env.sh ...

2017-02-22 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1525 Confirmed with/without `run.as` configuration the shell worked, with 'restart', 'stop', 'start', 'run' ... etc. LGTM +1. Squashed and merged into 0.x bran

[GitHub] nifi issue #1527: NIFI-3189: ConsumeKafka & Back-pressure. ConsumeKafka_0_10

2017-02-24 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1527 @bbende Thanks for reviewing. Incorporated comment. While I was doing so, I found that Kafka client library started supporting heartbeat in background thread [KAFKA-3888](https

[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...

2017-02-27 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 @patricker Thank you for pointing that out. It can vary among databases. Peter, What RDB do you usually use? @qfdk I thought you're using PostgreSQL by reading the [HCC question](

[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...

2017-02-27 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 @qfdk I understand. It's ok to have Travis test failure with other USER_LANGUAGE than English for now. Since the test has passed with English locale, we can move forward. We're aware

[GitHub] nifi issue #1527: NIFI-3189: ConsumeKafka & Back-pressure. ConsumeKafka_0_10

2017-02-27 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1527 @bbende It turned out to be updating Kafka client is sufficient for 0.10. Confirmed that ConsumeKafka_0_10 can rejoin the consumer group when it resumes after being back-pressure engaged more

[GitHub] nifi pull request #1554: NIFI-3545: Release M FlowFilews once N signals arri...

2017-03-02 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1554 NIFI-3545: Release M FlowFilews once N signals arrive - Support multiplle incoming FlowFiles to Wait processor, up to Wait Buffer Count - Added Releasable FlowFile Count, which

[GitHub] nifi issue #1554: NIFI-3545: Release M FlowFilews once N signals arrive

2017-03-02 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1554 Dear reviewer, I've tested this PR with different use-cases. Templates and screenshots are available at this [Gist](https://gist.github.com/ijokarumawak/ab6487801c636628ddedd5f025f

[GitHub] nifi issue #1332: NIFI-3163: Flow Fingerprint should include new RPG configu...

2017-03-06 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1332 @markap14 Would you be able to review this PR? It's there for a while and I had to update this PR couple of times to resolve conflicts with the latest master. This PR is required to move

[GitHub] nifi issue #1332: NIFI-3163: Flow Fingerprint should include new RPG configu...

2017-03-06 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1332 @alopresto It'd be convenient if a node can fix stale flow.xml.gz automatically and join a cluster by removing its flow.xml.gz and fetch the latest one from primary node. I think we need t

[GitHub] nifi pull request #1568: NIFI-3561: Fix WS port forwarding

2017-03-07 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1568 NIFI-3561: Fix WS port forwarding Fixed service instance lookup to use local port so that it works when it is accessed through port forwarding. Thank you for submitting a

[GitHub] nifi issue #1569: NIFI-3541 NIFI-3545 - check style violations

2017-03-07 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1569 Confirmed contrib check passed locally. Merged into master. https://git-wip-us.apache.org/repos/asf?p=nifi.git However, the commit is not synched to Github thus this PR is still open

[GitHub] nifi pull request #1450: NIFI-3339b Add getDataSource() to DBCPService, seco...

2017-03-08 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1450#discussion_r104869088 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/pom.xml --- @@ -81,5 +81,17 @@ hamcrest

[GitHub] nifi issue #1579: NIFI-3313 Added explicit Java runtime argument to default ...

2017-03-08 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1579 @alopresto I have an environment that can reproduce insufficient entropy blocking NiFi to startup. Will try to review.. --- If your project is set up for it, you can reply to this email and

[GitHub] nifi issue #1579: NIFI-3313 Added explicit Java runtime argument to default ...

2017-03-08 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1579 @alopresto LGTM +1. Thanks for fixing this! Please merge if my test result is sufficient. ## Confirmed that I can reproduce the issue I had been using a workaround by

[GitHub] nifi pull request #1597: NIFI-3609: ConnectWebSocket auto session recovery

2017-03-16 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1597 NIFI-3609: ConnectWebSocket auto session recovery Before this fix, ConnectWebSocket has to be restarted manually if its target WebSocket server restarted, or session expiration if there'

[GitHub] nifi pull request #1604: NIFI-3603:localization needed

2017-03-20 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1604#discussion_r106852844 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/java/Messages_cn.properties --- @@ -0,0 +1,785

[GitHub] nifi issue #1604: NIFI-3603:localization needed

2017-03-21 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1604 @wangrenlei The Travis result looks fine. Builds using default or US locale passed: ![image](https://cloud.githubusercontent.com/assets/1107620/24137692/49bd8060-0e58-11e7-8da0-51445513e1c7

[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...

2017-03-28 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 Hi @qfdk , excuse me for not providing further review comments. Today, I wanted to test this updated PR but unfortunately it is conflicted. Would you rebase it with the latest master, address

[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...

2017-03-28 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 @qfdk I updated the JIRA and emptied Fix Version for now. Please let me request one more thing, is it possible for you to provide test result with PostgreSQL (or whatever DBMS you&#x

[GitHub] nifi issue #1324: NIFI-3166: Fix SocketRemoteSiteListener NPE.

2017-03-28 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1324 @joewitt @trixpan Fixed merge conflict. Tested [NIFI-3166](https://issues.apache.org/jira/browse/NIFI-3166) issue is addressed, disabling HTTP remote input worked without NPE. I also

[GitHub] nifi pull request #1634: NIFI-3657: Fix HTTP S2S to use local address.

2017-03-28 Thread ijokarumawak
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1634 NIFI-3657: Fix HTTP S2S to use local address. - Fixed SiteInfoProvider and HttpClient to use specified local address with its SiteToSiteRestApiClient - Removed setupRequestConfig method

[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...

2017-03-29 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 @qfdk "26,360,516 documents (5.6 Gb), in 5 minutes" is amazing! A video would be very helpful, but a image or two might be enough. I'd like to know the difference between the t

[GitHub] nifi pull request #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-29 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1618#discussion_r108833900 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CaptureChangeMySQL.java

[GitHub] nifi pull request #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-29 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1618#discussion_r108826242 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CaptureChangeMySQL.java

[GitHub] nifi pull request #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-29 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1618#discussion_r108827633 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CaptureChangeMySQL.java

[GitHub] nifi pull request #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-29 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1618#discussion_r108830875 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CaptureChangeMySQL.java

[GitHub] nifi pull request #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-29 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1618#discussion_r108829639 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/event/BaseEventInfo.java

[GitHub] nifi pull request #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-29 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1618#discussion_r108833778 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CaptureChangeMySQL.java

[GitHub] nifi pull request #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-29 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1618#discussion_r108831385 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CaptureChangeMySQL.java

[GitHub] nifi pull request #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-29 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/1618#discussion_r108827773 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CaptureChangeMySQL.java

  1   2   3   4   5   6   7   8   9   10   >