[GitHub] phoenix pull request #323: PHOENIX-4839 Check for memstore scanners if it is...

2018-08-10 Thread mnpoonia
Github user mnpoonia commented on a diff in the pull request: https://github.com/apache/phoenix/pull/323#discussion_r209235284 --- Diff: phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java --- @@ -395,7 +395,10 @@ public KeyValueS

[jira] [Commented] (PHOENIX-4839) IndexHalfStoreFileReaderGenerator throws NullPointerException

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576174#comment-16576174 ] ASF GitHub Bot commented on PHOENIX-4839: - Github user mnpoonia commented on a

[jira] [Commented] (PHOENIX-4750) Resolve server customizers and provide them to Avatica

2018-08-10 Thread Alex Araujo (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576397#comment-16576397 ] Alex Araujo commented on PHOENIX-4750: -- {code:java} +class ServerCustomizersFa

[jira] [Commented] (PHOENIX-4834) PhoenixMetricsLog interface methods should not depend on specific logger

2018-08-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576412#comment-16576412 ] Hudson commented on PHOENIX-4834: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-4805) Move Avatica version to 1.12 for PQS

2018-08-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576413#comment-16576413 ] Hudson commented on PHOENIX-4805: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-4647) Column header doesn't handle optional arguments correctly

2018-08-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576414#comment-16576414 ] Hudson commented on PHOENIX-4647: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-4750) Resolve server customizers and provide them to Avatica

2018-08-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576411#comment-16576411 ] Hadoop QA commented on PHOENIX-4750: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-4841) Filters that uses RVC with pk columns where with DESC sort order don't work correctly

2018-08-10 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576505#comment-16576505 ] James Taylor commented on PHOENIX-4841: --- Agreed - we should be able to push this

[jira] [Commented] (PHOENIX-4750) Resolve server customizers and provide them to Avatica

2018-08-10 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576646#comment-16576646 ] Josh Elser commented on PHOENIX-4750: - {quote}I thought about doing that for the ot

[jira] [Commented] (PHOENIX-4750) Resolve server customizers and provide them to Avatica

2018-08-10 Thread Alex Araujo (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576781#comment-16576781 ] Alex Araujo commented on PHOENIX-4750: -- {quote}what you have now to try to extract

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576846#comment-16576846 ] Thomas D'Silva commented on PHOENIX-4843: - [~vincentpoon] or [~karanmehta93] ca

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576852#comment-16576852 ] James Taylor commented on PHOENIX-4843: --- It often won't work to attempt to do a t

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576867#comment-16576867 ] Thomas D'Silva commented on PHOENIX-4843: - [~jamestaylor] Thanks for looking at

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576866#comment-16576866 ] Hadoop QA commented on PHOENIX-4843: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576885#comment-16576885 ] Thomas D'Silva commented on PHOENIX-4843: - [~jamestaylor] I have attached a v2

[jira] [Commented] (PHOENIX-4830) order by primary key desc return wrong results

2018-08-10 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576906#comment-16576906 ] Xu Cang commented on PHOENIX-4830: -- added unit tests for my fix. Please review.[~tdsil

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576927#comment-16576927 ] Thomas D'Silva commented on PHOENIX-4843: - I attached a v3 patch that only crea

[jira] [Commented] (PHOENIX-4835) LoggingPhoenixConnection should log metrics upon connection close

2018-08-10 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576957#comment-16576957 ] Karan Mehta commented on PHOENIX-4835: -- Here's what happens according to my unders

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576969#comment-16576969 ] James Taylor commented on PHOENIX-4843: --- Nasty bug - nice find, [~tdsilva]. Minor

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576975#comment-16576975 ] Thomas D'Silva commented on PHOENIX-4843: - Thanks for the review [~jamestaylor]

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576982#comment-16576982 ] James Taylor commented on PHOENIX-4843: --- Couple more thoughts, [~tdsilva]: * I d

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576983#comment-16576983 ] Hadoop QA commented on PHOENIX-4843: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577010#comment-16577010 ] Hadoop QA commented on PHOENIX-4843: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-4843) InListExpression toString() converts the values in the list to ASC sort order always

2018-08-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577046#comment-16577046 ] Hadoop QA commented on PHOENIX-4843: {color:red}-1 overall{color}. Here are the re