[GitHub] [trafficcontrol] ntheanh201 opened a new pull request, #7760: Issues/7456

ntheanh201 opened a new pull request, #7760: URL: https://github.com/apache/trafficcontrol/pull/7760 Add field comment to parameter Closes: #7456 ## Which Traffic Control components are affected by this PR? - Traffic Ops - Traffic Portal ## What is the

[GitHub] [trafficcontrol] ericholguin merged pull request #7772: Added api contract test case for system/info endpoint

ericholguin merged PR #7772: URL: https://github.com/apache/trafficcontrol/pull/7772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7709: Added api contract test case for cdn health and routing endpoints

ericholguin commented on code in PR #7709: URL: https://github.com/apache/trafficcontrol/pull/7709#discussion_r1316016144 ## traffic_ops/testing/api_contract/v4/test_cdn_health.py: ## @@ -0,0 +1,81 @@ +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you

[GitHub] [trafficcontrol] limited merged pull request #7725: Add HTTPS support to Varnish cache using Hitch

limited merged PR #7725: URL: https://github.com/apache/trafficcontrol/pull/7725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] limited closed issue #7722: Add support for HTTPS requests to Varnish cache

limited closed issue #7722: Add support for HTTPS requests to Varnish cache URL: https://github.com/apache/trafficcontrol/issues/7722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7760: Add notes/comments field to parameters

ocket commented on PR #7760: URL: https://github.com/apache/trafficcontrol/pull/7760#issuecomment-1706803489 the core idea. Adding an arbitrary text field to an object that shouldn't really exist in its own right doesn't seem like the best idea. -- This is an automated message from

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7773: ReadTheDocs fix attempt No. 2

ocket opened a new pull request, #7773: URL: https://github.com/apache/trafficcontrol/pull/7773 I checked my site packages and in version 5.1 Sphinx is correctly importing `Union` from the `typing` package, not the `types` package, so I figure it's worth a shot updating our

[GitHub] [trafficcontrol] jpappa200 opened a new pull request, #7774: T3c uses V5 api by default and will fallback to V4

jpappa200 opened a new pull request, #7774: URL: https://github.com/apache/trafficcontrol/pull/7774 Closes: #7768 This will implement API V5 in t3c by default. It will also fallback to API v4 is V5 is not available. I"m still adding support for the DS Active flag and will commit

[GitHub] [trafficcontrol] cybertunnel opened a new pull request, #7776: Feature/improved tchc logging

cybertunnel opened a new pull request, #7776: URL: https://github.com/apache/trafficcontrol/pull/7776 This PR adds better logging into TCHC's interaction with TO. Added where it provides the actual error instead of a generic response when TO is having trouble being contacted.

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7777: Changes for ATC 8.0.0 release

rimashah25 opened a new pull request, #: URL: https://github.com/apache/trafficcontrol/pull/ This PR is not related to any issues. It includes all the changes required for a release ## Which Traffic Control components are affected by this PR? - Traffic

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

rimashah25 commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1316486906 ## traffic_ops/app/db/seeds.sql: ## @@ -97,6 +103,23 @@ FROM public.role WHERE "name" in ('operations', 'read-only', 'portal', 'federation', 'steering') ON

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7775: Fix tchealthclient CiaB service unable to build

ocket opened a new pull request, #7775: URL: https://github.com/apache/trafficcontrol/pull/7775 I have no idea why this is only affecting me, but the `tchealthclient` CiaB service is failing to build because of a build `ARG` that is being used in a layer in which it is unavailable.

[GitHub] [trafficcontrol] ericholguin merged pull request #7709: Added api contract test case for cdn health and routing endpoints

ericholguin merged PR #7709: URL: https://github.com/apache/trafficcontrol/pull/7709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

rimashah25 commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1316486440 ## traffic_ops/app/db/seeds.sql: ## @@ -97,6 +103,23 @@ FROM public.role WHERE "name" in ('operations', 'read-only', 'portal', 'federation', 'steering') ON

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

zrhoffman commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1316168351 ## traffic_ops/app/db/seeds.sql: ## @@ -97,6 +103,23 @@ FROM public.role WHERE "name" in ('operations', 'read-only', 'portal', 'federation', 'steering') ON

[GitHub] [trafficcontrol] fatih-acar commented on a diff in pull request #7741: fix(t3c): regex for pparam should check end of path

fatih-acar commented on code in PR #7741: URL: https://github.com/apache/trafficcontrol/pull/7741#discussion_r1316219342 ## cache-config/t3c-check-refs/t3c-check-refs.go: ## @@ -115,7 +115,7 @@ func checkConfigLine(line string, lineNumber int, filesAdding map[string]struct{

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7774: T3c uses V5 api by default and will fallback to V4

codecov[bot] commented on PR #7774: URL: https://github.com/apache/trafficcontrol/pull/7774#issuecomment-1707116483 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7774?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] zrhoffman merged pull request #7775: Fix tchealthclient CiaB service unable to build

zrhoffman merged PR #7775: URL: https://github.com/apache/trafficcontrol/pull/7775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

zrhoffman commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1316411101 ## traffic_ops/app/db/seeds.sql: ## @@ -97,6 +103,23 @@ FROM public.role WHERE "name" in ('operations', 'read-only', 'portal', 'federation', 'steering') ON

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7709: Added api contract test case for cdn health and routing endpoints

gokulakrishnansvm commented on code in PR #7709: URL: https://github.com/apache/trafficcontrol/pull/7709#discussion_r1316270360 ## traffic_ops/testing/api_contract/v4/test_cdn_health.py: ## @@ -0,0 +1,81 @@ +# +# Licensed under the Apache License, Version 2.0 (the "License");

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

rimashah25 commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1316287812 ## traffic_ops/app/db/seeds.sql: ## @@ -97,6 +103,23 @@ FROM public.role WHERE "name" in ('operations', 'read-only', 'portal', 'federation', 'steering') ON

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7776: Improvement to TCHC's logging around TO failure

codecov[bot] commented on PR #7776: URL: https://github.com/apache/trafficcontrol/pull/7776#issuecomment-1707235292 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7776?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] dsouza93 opened a new pull request, #7786: Removing the quotes around client auth enabled

dsouza93 opened a new pull request, #7786: URL: https://github.com/apache/trafficcontrol/pull/7786 Removing the quotes around client auth enabled Which Traffic Control components are affected by this PR? Automation - Lab Ansible Infrastructure What is the best way to verify

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7682: Bump jszip from 3.6.0 to 3.10.1 in /traffic_portal/test/integration

codecov[bot] commented on PR #7682: URL: https://github.com/apache/trafficcontrol/pull/7682#issuecomment-1714273579 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7682?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7794: ReadTheDocs fix attempt #3

ocket opened a new pull request, #7794: URL: https://github.com/apache/trafficcontrol/pull/7794 This fixes an incompatibility with the Sphinx version and the versions of other things as declared in the `requirements.txt` file for the docs. In the new version - 7.0.1 - there is now a

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7684: Bump minimist from 1.2.5 to 1.2.8 in /traffic_portal/test/integration

codecov[bot] commented on PR #7684: URL: https://github.com/apache/trafficcontrol/pull/7684#issuecomment-1714272194 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7684?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7793: Bump engine.io and socket.io in /traffic_portal

dependabot[bot] opened a new pull request, #7793: URL: https://github.com/apache/trafficcontrol/pull/7793 Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates

[GitHub] [trafficcontrol] dependabot[bot] commented on pull request #7490: Bump engine.io and socket.io in /traffic_portal

dependabot[bot] commented on PR #7490: URL: https://github.com/apache/trafficcontrol/pull/7490#issuecomment-1714271644 Superseded by #7793. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] dependabot[bot] closed pull request #7490: Bump engine.io and socket.io in /traffic_portal

dependabot[bot] closed pull request #7490: Bump engine.io and socket.io in /traffic_portal URL: https://github.com/apache/trafficcontrol/pull/7490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] shamrickus merged pull request #7793: Bump engine.io and socket.io in /traffic_portal

shamrickus merged PR #7793: URL: https://github.com/apache/trafficcontrol/pull/7793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus commented on pull request #7490: Bump engine.io and socket.io in /traffic_portal

shamrickus commented on PR #7490: URL: https://github.com/apache/trafficcontrol/pull/7490#issuecomment-1714269802 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] dependabot[bot] commented on pull request #7526: Bump vm2 from 3.9.17 to 3.9.19 in /traffic_portal/app/src

dependabot[bot] commented on PR #7526: URL: https://github.com/apache/trafficcontrol/pull/7526#issuecomment-1714270218 Looks like vm2 is no longer updatable, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] dependabot[bot] closed pull request #7526: Bump vm2 from 3.9.17 to 3.9.19 in /traffic_portal/app/src

dependabot[bot] closed pull request #7526: Bump vm2 from 3.9.17 to 3.9.19 in /traffic_portal/app/src URL: https://github.com/apache/trafficcontrol/pull/7526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [trafficcontrol] shamrickus merged pull request #7685: Bump minimatch from 3.0.4 to 3.1.2 in /traffic_portal/test/integration

shamrickus merged PR #7685: URL: https://github.com/apache/trafficcontrol/pull/7685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7793: Bump engine.io and socket.io in /traffic_portal

codecov[bot] commented on PR #7793: URL: https://github.com/apache/trafficcontrol/pull/7793#issuecomment-1714277882 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7793?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] shamrickus merged pull request #7671: Bump word-wrap from 1.2.3 to 1.2.5 in /traffic_portal/app/src

shamrickus merged PR #7671: URL: https://github.com/apache/trafficcontrol/pull/7671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman merged pull request #7794: ReadTheDocs fix attempt #3

zrhoffman merged PR #7794: URL: https://github.com/apache/trafficcontrol/pull/7794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus merged pull request #7569: Bump socket.io-parser from 4.2.2 to 4.2.4 in /experimental/traffic-portal

shamrickus merged PR #7569: URL: https://github.com/apache/trafficcontrol/pull/7569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus merged pull request #7568: Bump socket.io-parser from 4.2.1 to 4.2.4 in /traffic_portal

shamrickus merged PR #7568: URL: https://github.com/apache/trafficcontrol/pull/7568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] jpappa200 commented on a diff in pull request #7774: T3c uses V5 api by default and will fallback to V4

jpappa200 commented on code in PR #7774: URL: https://github.com/apache/trafficcontrol/pull/7774#discussion_r1322080567 ## lib/go-tc/totest/tenants.go: ## @@ -41,13 +42,13 @@ func DeleteTestTenants(t *testing.T, cl *toclient.Session) { assert.NoError(t, err, "Cannot get

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7795: Update CDN in a Box enroller to use TO API v5

zrhoffman opened a new pull request, #7795: URL: https://github.com/apache/trafficcontrol/pull/7795 This PR makes the CDN in a Box enroller use Traffic Ops API version 5. This PR also removes `v5` from some API v5 TO client method names. ## Which Traffic Control

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7774: T3c uses V5 api by default and will fallback to V4

zrhoffman commented on code in PR #7774: URL: https://github.com/apache/trafficcontrol/pull/7774#discussion_r1322062680 ## lib/go-tc/totest/tenants.go: ## @@ -41,13 +42,13 @@ func DeleteTestTenants(t *testing.T, cl *toclient.Session) { assert.NoError(t, err, "Cannot get

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7795: Update CDN in a Box enroller to use TO API v5

codecov[bot] commented on PR #7795: URL: https://github.com/apache/trafficcontrol/pull/7795#issuecomment-1714596449 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7795: Update CDN in a Box enroller to use TO API v5

ocket commented on code in PR #7795: URL: https://github.com/apache/trafficcontrol/pull/7795#discussion_r1322242574 ## infrastructure/cdn-in-a-box/enroller/enroller.go: ## @@ -318,10 +318,10 @@ func enrollDeliveryServiceServer(toSession *session, r io.Reader) error {

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7796: Fix ASN precondition test

codecov[bot] commented on PR #7796: URL: https://github.com/apache/trafficcontrol/pull/7796#issuecomment-1714718097 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7796?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7796: Fix ASN precondition test

srijeet0406 merged PR #7796: URL: https://github.com/apache/trafficcontrol/pull/7796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] 235115 opened a new issue, #7797: Traffic Control ProJ

235115 opened a new issue, #7797: URL: https://github.com/apache/trafficcontrol/issues/7797 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7796: Fix ASN precondition test

rimashah25 opened a new pull request, #7796: URL: https://github.com/apache/trafficcontrol/pull/7796 This PR is not related to an issue. Tries to fix a flaky ASN test ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is

[GitHub] [trafficcontrol] ocket8888 closed issue #7797: Traffic Control ProJ

ocket closed issue #7797: Traffic Control ProJ URL: https://github.com/apache/trafficcontrol/issues/7797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7798: Documentation cleanup

ocket opened a new pull request, #7798: URL: https://github.com/apache/trafficcontrol/pull/7798 This PR addresses some issues with our API documentation. Its primary purpose, though, is to add in all of the `.. versionchanged::` directives that are missing from fields that were changed

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7806: `cdns/{{name}}/federations` and `cdns/{{name}}/federations/{{ID}}` use RFC3339 timestamps

ocket commented on code in PR #7806: URL: https://github.com/apache/trafficcontrol/pull/7806#discussion_r1327687700 ## traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go: ## @@ -21,21 +23,27 @@ package cdnfederation import ( "database/sql" + _

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7806: `cdns/{{name}}/federations` and `cdns/{{name}}/federations/{{ID}}` use RFC3339 timestamps

ocket commented on code in PR #7806: URL: https://github.com/apache/trafficcontrol/pull/7806#discussion_r1327687910 ## traffic_ops/testing/api/v5/cdn_federations_test.go: ## @@ -220,10 +219,9 @@ func validateCDNFederationCNameSort() utils.CkReqFunc { return func(t

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7806: `cdns/{{name}}/federations` and `cdns/{{name}}/federations/{{ID}}` use RFC3339 timestamps

ocket commented on code in PR #7806: URL: https://github.com/apache/trafficcontrol/pull/7806#discussion_r1327688202 ## traffic_ops/traffic_ops_golang/routing/routes.go: ## @@ -395,10 +395,11 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7806: `cdns/{{name}}/federations` and `cdns/{{name}}/federations/{{ID}}` use RFC3339 timestamps

ocket commented on code in PR #7806: URL: https://github.com/apache/trafficcontrol/pull/7806#discussion_r1327688515 ## traffic_ops/traffic_ops_golang/cdnfederation/insert.sql: ## @@ -0,0 +1,12 @@ +INSERT INTO federation ( Review Comment: Yeah, and I find that harder to

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7806: `cdns/{{name}}/federations` and `cdns/{{name}}/federations/{{ID}}` use RFC3339 timestamps

zrhoffman commented on code in PR #7806: URL: https://github.com/apache/trafficcontrol/pull/7806#discussion_r1327572509 ## traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go: ## @@ -21,21 +23,27 @@ package cdnfederation import ( "database/sql" + _

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7806: `cdns/{{name}}/federations` and `cdns/{{name}}/federations/{{ID}}` use RFC3339 timestamps

rimashah25 commented on code in PR #7806: URL: https://github.com/apache/trafficcontrol/pull/7806#discussion_r1327568914 ## traffic_ops/testing/api/v5/cdn_federations_test.go: ## @@ -220,10 +219,9 @@ func validateCDNFederationCNameSort() utils.CkReqFunc { return func(t

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7806: `cdns/{{name}}/federations` and `cdns/{{name}}/federations/{{ID}}` use RFC3339 timestamps

ocket commented on code in PR #7806: URL: https://github.com/apache/trafficcontrol/pull/7806#discussion_r1327687168 ## infrastructure/cdn-in-a-box/enroller/enroller.go: ## @@ -842,13 +847,8 @@ func enrollFederation(toSession *session, r io.Reader) error {

[GitHub] [trafficcontrol] rimashah25 merged pull request #7804: Removing v5 client methods for Delivery Service Required Capabilities

rimashah25 merged PR #7804: URL: https://github.com/apache/trafficcontrol/pull/7804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rimashah25 closed issue #7801: API v5 client.CreateDeliveryServicesRequiredCapability 404s

rimashah25 closed issue #7801: API v5 client.CreateDeliveryServicesRequiredCapability 404s URL: https://github.com/apache/trafficcontrol/issues/7801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7718: Servers RFC3339 timestamps

zrhoffman commented on code in PR #7718: URL: https://github.com/apache/trafficcontrol/pull/7718#discussion_r1304603210 ## traffic_ops/traffic_ops_golang/server/servers.go: ## @@ -1421,230 +1365,200 @@ func Update(w http.ResponseWriter, r *http.Request) { }

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7718: Servers RFC3339 timestamps

zrhoffman commented on PR #7718: URL: https://github.com/apache/trafficcontrol/pull/7718#issuecomment-1692054744 > > You resolved [this conversation](https://github.com/apache/trafficcontrol/pull/7718#discussion_r1302074955) but went ahead and did it anyway? Please revert the Version

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7719: add automatic self-healing when using slice plugin to t3c

ocket commented on code in PR #7719: URL: https://github.com/apache/trafficcontrol/pull/7719#discussion_r1304463322 ## lib/go-atscfg/remapdotconfig_test.go: ## @@ -1599,16 +1599,16 @@ func TestMakeRemapDotConfigMidSlicePluginRangeRequestHandling(t *testing.T) {

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7741: fix(t3c): regex for pparam should check end of path

codecov[bot] commented on PR #7741: URL: https://github.com/apache/trafficcontrol/pull/7741#issuecomment-1691844862 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7741?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] rimashah25 closed issue #7659: Traffic Stats should use TO API v5

rimashah25 closed issue #7659: Traffic Stats should use TO API v5 URL: https://github.com/apache/trafficcontrol/issues/7659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] rimashah25 closed issue #7658: TR should default to using TO API 5.0

rimashah25 closed issue #7658: TR should default to using TO API 5.0 URL: https://github.com/apache/trafficcontrol/issues/7658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

rimashah25 commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1312402547 ## CHANGELOG.md: ## @@ -79,31 +80,34 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

rimashah25 commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1312402547 ## CHANGELOG.md: ## @@ -79,31 +80,34 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

rimashah25 commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1312420258 ## traffic_ops/app/db/seeds.sql: ## @@ -97,6 +103,23 @@ FROM public.role WHERE "name" in ('operations', 'read-only', 'portal', 'federation', 'steering') ON

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7767: Fixed ASN Update logic for APIv5

codecov[bot] commented on PR #7767: URL: https://github.com/apache/trafficcontrol/pull/7767#issuecomment-1701396272 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7767?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7766: Update TP to use API v5

srijeet0406 commented on code in PR #7766: URL: https://github.com/apache/trafficcontrol/pull/7766#discussion_r1312007852 ## traffic_portal/test/integration/Data/physlocations.ts: ## @@ -200,32 +200,32 @@ export const physLocations = {

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

zrhoffman commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1312384741 ## CHANGELOG.md: ## @@ -79,31 +80,34 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] shamrickus merged pull request #7767: Fixed ASN Update logic for APIv5

shamrickus merged PR #7767: URL: https://github.com/apache/trafficcontrol/pull/7767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7733: To origin rfc3339

ocket commented on code in PR #7733: URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1312108021 ## traffic_ops/traffic_ops_golang/origin/origins.go: ## @@ -38,6 +38,7 @@ import (

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7760: Add notes/comments field to parameters

codecov[bot] commented on PR #7760: URL: https://github.com/apache/trafficcontrol/pull/7760#issuecomment-1701842077 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7760?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7733: To origin rfc3339

ocket commented on code in PR #7733: URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1311902118 ## traffic_ops/traffic_ops_golang/origin/origins.go: ## @@ -487,3 +487,294 @@ func deleteQuery() string { WHERE id=:id` return query } + +// Get is

[GitHub] [trafficcontrol] gbkannan89 commented on a diff in pull request #7733: To origin rfc3339

gbkannan89 commented on code in PR #7733: URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1311942139 ## traffic_ops/traffic_ops_golang/origin/origins.go: ## @@ -487,3 +487,294 @@ func deleteQuery() string { WHERE id=:id` return query } + +// Get is

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7766: Update TP to use API v5

github-code-scanning[bot] commented on code in PR #7766: URL: https://github.com/apache/trafficcontrol/pull/7766#discussion_r1311892556 ## traffic_portal/app/src/common/modules/form/server/form.server.tpl.html: ## @@ -120,25 +119,25 @@ For example, P1 and

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7764: Squash db migration that have already been released (7.x.x)

zrhoffman commented on code in PR #7764: URL: https://github.com/apache/trafficcontrol/pull/7764#discussion_r1312208424 ## traffic_ops/app/db/create_tables.sql: ## @@ -841,7 +835,6 @@ CREATE TABLE IF NOT EXISTS deliveryservice_tmuser ( CONSTRAINT idx_89525_primary PRIMARY

[GitHub] [trafficcontrol] jpappa200 opened a new issue, #7768: t3c should default to traffic ops API v5 and fall back to API v4 if v5 is unavailable.

jpappa200 opened a new issue, #7768: URL: https://github.com/apache/trafficcontrol/issues/7768 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT)

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7733: To origin rfc3339

ocket commented on code in PR #7733: URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1311909834 ## traffic_ops/traffic_ops_golang/origin/origins.go: ## @@ -487,3 +487,294 @@ func deleteQuery() string { WHERE id=:id` return query } + +// Get is

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7733: To origin rfc3339

ocket commented on code in PR #7733: URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1311911252 ## traffic_ops/traffic_ops_golang/origin/origins.go: ## @@ -487,3 +487,294 @@ func deleteQuery() string { WHERE id=:id` return query } + +// Get is

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7767: Fixed ASN Update logic for APIv5

rimashah25 opened a new pull request, #7767: URL: https://github.com/apache/trafficcontrol/pull/7767 This PR fixed the ASN update logic for APIv5 ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is the best way to verify this

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7760: Add notes/comments field to parameters

ocket commented on PR #7760: URL: https://github.com/apache/trafficcontrol/pull/7760#issuecomment-1701834638 I don't think this is a great idea tbh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7749: Tenants rfc3339 apiv5

github-code-scanning[bot] commented on code in PR #7749: URL: https://github.com/apache/trafficcontrol/pull/7749#discussion_r1307563918 ## traffic_ops/traffic_ops_golang/apitenant/tenant.go: ## @@ -336,3 +341,462 @@ WHERE id=:id` return query } + +func

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7750: TO: Add fields to servers v5 endpoints to indicate update failures

ocket commented on code in PR #7750: URL: https://github.com/apache/trafficcontrol/pull/7750#discussion_r1307696075 ## lib/go-tc/servers.go: ## @@ -1356,7 +1358,9 @@ type ServerV50 struct { // The time at which revalidations for this server were last updated by

[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7749: Tenants rfc3339 apiv5

kdamichie commented on code in PR #7749: URL: https://github.com/apache/trafficcontrol/pull/7749#discussion_r1307572965 ## traffic_ops/traffic_ops_golang/apitenant/tenant.go: ## @@ -336,3 +341,462 @@ WHERE id=:id` return query } + +func selectMaxLastUpdatedQuery(where

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7750: TO: Add fields to servers v5 endpoints to indicate update failures

codecov[bot] commented on PR #7750: URL: https://github.com/apache/trafficcontrol/pull/7750#issuecomment-1695963335 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7750?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7753: Fix back-end configuration contains invalid JSON

ocket opened a new pull request, #7753: URL: https://github.com/apache/trafficcontrol/pull/7753 Fixes #7752 ## Which Traffic Control components are affected by this PR? - unknown ## What is the best way to verify this PR? Make sure the affected file is valid

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7749: Tenants rfc3339 apiv5

codecov[bot] commented on PR #7749: URL: https://github.com/apache/trafficcontrol/pull/7749#issuecomment-1695877606 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7749?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] cybertunnel opened a new issue, #7752: production/backends.conf invalid JSON

cybertunnel opened a new issue, #7752: URL: https://github.com/apache/trafficcontrol/issues/7752 ## This Bug Report affects these Traffic Control components: - Traffic Ops - CDN in a Box ## What did you do? While building TO, the default config under

[GitHub] [trafficcontrol] shamrickus closed pull request #7574: Update Chromedriver Versions

shamrickus closed pull request #7574: Update Chromedriver Versions URL: https://github.com/apache/trafficcontrol/pull/7574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7751: Update Chromedriver Versions

codecov[bot] commented on PR #7751: URL: https://github.com/apache/trafficcontrol/pull/7751#issuecomment-1695976714 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7751?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7744: Use RFC 3339 for lastUpdated timestamp in /server_server_capabilities

kdamichie commented on code in PR #7744: URL: https://github.com/apache/trafficcontrol/pull/7744#discussion_r1307607183 ## CHANGELOG.md: ## @@ -102,6 +102,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7749: Tenants rfc3339 apiv5

zrhoffman commented on code in PR #7749: URL: https://github.com/apache/trafficcontrol/pull/7749#discussion_r1307560027 ## lib/go-tc/tenants.go: ## @@ -1,5 +1,7 @@ package tc +import "time" + Review Comment: Nit: import should come after the license -- This is an

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7750: TO: Add fields to servers v5 endpoints to indicate update failures

shamrickus opened a new pull request, #7750: URL: https://github.com/apache/trafficcontrol/pull/7750 This fixes #7674 ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Ops ## What is the best way to verify this PR?

[GitHub] [trafficcontrol] asf-ci-trafficcontrol opened a new pull request, #7751: Update Chromedriver Versions

asf-ci-trafficcontrol opened a new pull request, #7751: URL: https://github.com/apache/trafficcontrol/pull/7751 This PR updates chromedriver in: traffic_portal/test/integration: 114.0.3 -> 116.0.0 experimental/traffic-portal: 114.0.3 -> 116.0.0 ## Which Traffic

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7754: Add ReadTheDocs configuration file

ocket opened a new pull request, #7754: URL: https://github.com/apache/trafficcontrol/pull/7754 Our builds for docs on RTD are currently failing due to a missing required configuration parameter. This PR is an attempt to fix that by adding the new configuration file which will be the

[GitHub] [trafficcontrol] ntheanh201 commented on pull request #7760: Add notes/comments field to parameters

ntheanh201 commented on PR #7760: URL: https://github.com/apache/trafficcontrol/pull/7760#issuecomment-1702202404 > I don't think this is a great idea tbh About the code or about the idea of this issue? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] ocket8888 merged pull request #7750: TO: Add fields to servers v5 endpoints to indicate update failures

ocket merged PR #7750: URL: https://github.com/apache/trafficcontrol/pull/7750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 closed issue #7674: add update and reval flag to indicate failure

ocket closed issue #7674: add update and reval flag to indicate failure URL: https://github.com/apache/trafficcontrol/issues/7674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   3   4   5   6   7   8   9   10   >