[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724371#action_12724371
]
Shai Erera commented on LUCENE-1707:
sure, especially if == 0 and <= 0 perform the sam
See http://hudson.zones.apache.org/hudson/job/Lucene-trunk/870/changes
Changes:
[mikemccand] LUCENE-1630: call the right createWeight method
[mikemccand] LUCENE-1707: refCount doesn't need to be volatile
[mikemccand] LUCENE-1630: make Query.createQueryWeight optional, with default
impl to wrap
P.S Looking forward to this issue. Just ordered the cheapest quad core
laptop I could find :) So long dual core.
- Mark
Mark Miller wrote:
I found a couple external solutions last I looked. They appeared to
have various limitations though. I really think, longer term, the
built in support is
I found a couple external solutions last I looked. They appeared to have
various limitations though. I really think, longer term, the built in
support is the way to go. I'd hate to require a certain version of ANT
(its only the very latest 4.6 release), but perhaps we could set it up
to work ea
There's this foreach parallel ant-contrib task. Perhaps we have a winner!
http://www.jadeliquid.com/liquidtest/docs/doku.php?id=developers:cookbooks:scaling_liquidtest_with_junit_parallel:home
http://ant-contrib.sourceforge.net/tasks/tasks/foreach.html
On Thu, Jun 25, 2009 at 7:14 PM, Mark Mill
JUnit also supports parallelizing tasks, but its only in the very latest
release. I'd check out that. There are generally more issues than just
firing off multiple tests at once.
--
- Mark
http://www.lucidimagination.com
Jason Rutherglen (JIRA) wrote:
[ https://issues.apache.org/jira/br
[
https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724325#action_12724325
]
Jason Rutherglen commented on LUCENE-1709:
--
{quote} Do you mean that you would im
[
https://issues.apache.org/jira/browse/LUCENE-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724322#action_12724322
]
Uwe Schindler commented on LUCENE-1461:
---
Mike: There is one thing, I wanted to know,
[
https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724317#action_12724317
]
Johan Kindgren commented on LUCENE-1709:
Just a thought from an outsider...
Do you
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724296#action_12724296
]
Michael McCandless commented on LUCENE-1707:
bq. Following assert we call ensu
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724291#action_12724291
]
Shai Erera commented on LUCENE-1707:
bq. if an app over-decRef's and refCount becomes
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724289#action_12724289
]
Shai Erera commented on LUCENE-1630:
oops .. :). I've said it before - these two just
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-1630.
Resolution: Fixed
> Mating Collector and Scorer on doc Id orderness
>
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724283#action_12724283
]
Yonik Seeley commented on LUCENE-1707:
--
I also just double-checked and confirmed that
[
https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724277#action_12724277
]
Jason Rutherglen commented on LUCENE-1709:
--
{quote} As mentioned in the "Previous
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724284#action_12724284
]
Michael McCandless commented on LUCENE-1630:
Agreed -- I'll commit shortly.
>
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724268#action_12724268
]
Uwe Schindler commented on LUCENE-1630:
---
I think the patch is wrong, it must be
{cod
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724256#action_12724256
]
Yonik Seeley commented on LUCENE-1707:
--
bq. Do you think that changing ensureOpen() t
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless reopened LUCENE-1630:
Something is still amiss... from SOLR-940:
{code}
java.lang.StackOverflowError
at org.
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724254#action_12724254
]
Michael McCandless commented on LUCENE-1707:
Alas I don't think we should do t
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724251#action_12724251
]
Shai Erera commented on LUCENE-1707:
Do you think that changing ensureOpen() to check
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-1707.
Resolution: Fixed
> Don't use ensureOpen() excessively in IndexReader and IndexWri
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724237#action_12724237
]
Michael McCandless commented on LUCENE-1707:
bq. Except making refCount not vo
On Thu, Jun 25, 2009 at 3:34 PM, Shai Erera wrote:
> Funny, we're just having a similar discussion on LUCENE-1707.
Not a coincidence ;-) I attempt to at least skim all the threads I
have no bandwidth to keep up with... LUCENE-1707 jiggled a neuron,
but this didn't seem to be part of that issue -
On Thu, Jun 25, 2009 at 3:47 PM, Michael
McCandless wrote:
> Since close() is just a protected ("only once") call to decRef(), you
> could simply always call decRef() and never close()?
Yep, just re-read the javadoc to decRef()... as long as it stays that
way, solr will just avoid close().
I'll op
On Thu, Jun 25, 2009 at 3:34 PM, Shai Erera wrote:
> Doesn't reopen increase the refCount already? why do you call incRef()?
If you get the same reader back, the refCount is unchanged. If you
get a new reader back, it returns a reference (ie, refCount is 1).
Mike
--
This came up a while back and we decided (then) that double-closing
should be allowed:
http://issues.apache.org/jira/browse/LUCENE-818?focusedCommentId=12477399&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12477399
I think if we changed this ("every close coun
Funny, we're just having a similar discussion on LUCENE-1707. I think the
purpose of closed is to save against calling close() twice w/o "knowing any
better". I.e, IndexWriter.ReadersPool's release() both call decRef() (to
decrease its own ref) and close() to decrease the caller's. But then the
cal
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724220#action_12724220
]
Shai Erera commented on LUCENE-1707:
Ok I won't argue about that - these are hypotheti
Are the semantics of close() really correct when reopen() is used?
public final synchronized void close() throws IOException {
if (!closed) {
decRef();
closed = true;
}
}
Solr has the following code:
IndexReader newReader = currentReader.reopen();
if (newRe
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724186#action_12724186
]
Michael McCandless commented on LUCENE-1707:
bq. So calling decRef() twice in
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724169#action_12724169
]
Shai Erera commented on LUCENE-1707:
bq. Patch looks good; thanks Shai!
Note that de
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724153#action_12724153
]
Michael McCandless commented on LUCENE-1707:
Patch looks good; thanks Shai!
b
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724138#action_12724138
]
Shai Erera commented on LUCENE-1707:
I see all access to refCount is synchronized. Why
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-1707:
---
Attachment: LUCENE-1707.patch
Patch with protecting against decRef() and close(). Lines 28-30 includ
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724131#action_12724131
]
Shai Erera commented on LUCENE-1707:
bq. But, if refCount hits 0 and closed is false t
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724127#action_12724127
]
Michael McCandless commented on LUCENE-1707:
bq. So I'm not sure closed can be
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724121#action_12724121
]
Shai Erera commented on LUCENE-1707:
bq. If decRef() is called and refCount is 0, doCl
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724118#action_12724118
]
Shai Erera commented on LUCENE-1707:
I tried using closed, but TestIndexReaderReopen f
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724112#action_12724112
]
Michael McCandless commented on LUCENE-1707:
bq. IndexReader already has a 'cl
[
https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1625:
---
Fix Version/s: 2.9
> openReaderPassed not populated in CheckIndex.Status.SegmentInfo
[
https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724106#action_12724106
]
Michael McCandless commented on LUCENE-1625:
This patch is awesome, Tim; thank
[
https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless reassigned LUCENE-1625:
--
Assignee: Michael McCandless
> openReaderPassed not populated in CheckIndex.St
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724103#action_12724103
]
Shai Erera commented on LUCENE-1707:
IndexReader already has a 'closed' member which i
[
https://issues.apache.org/jira/browse/LUCENE-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724100#action_12724100
]
Uwe Schindler commented on LUCENE-1461:
---
oh ja, found it - was copy'n'paste
> Cache
[
https://issues.apache.org/jira/browse/LUCENE-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724097#action_12724097
]
Uwe Schindler commented on LUCENE-1461:
---
where? these are typical copy'n'paste error
[
https://issues.apache.org/jira/browse/LUCENE-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724096#action_12724096
]
Michael McCandless commented on LUCENE-1461:
Patch looks good, Uwe! The only
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724090#action_12724090
]
Michael McCandless commented on LUCENE-1707:
bq. However, I thought we agreed
[
https://issues.apache.org/jira/browse/LUCENE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724085#action_12724085
]
Michael McCandless commented on LUCENE-1717:
bq. is there already an issue to
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-1630.
Resolution: Fixed
> Mating Collector and Scorer on doc Id orderness
>
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724079#action_12724079
]
Michael McCandless commented on LUCENE-1630:
I'll commit shortly! Thanks Shai
When this thread was focused on Scorers only, I wanted to offer the
following:
* Have a TimeLimitingQuery which will wrap another Query, and delegate all
the calls to it, except queryWeight, which will create TimeLimitingWeight.
* Have a TimeLimitingWeight which will wrap the original query's
Quer
[
https://issues.apache.org/jira/browse/LUCENE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724074#action_12724074
]
Simon Willnauer commented on LUCENE-1717:
-
Regarding buffered delete's RAM usage,
[
https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724055#action_12724055
]
Shai Erera commented on LUCENE-1707:
bq. I'd actually rather not remove the ensureOpen
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724042#action_12724042
]
Uwe Schindler commented on LUCENE-1630:
---
Looks good, this is the correct way to do t
[
https://issues.apache.org/jira/browse/LUCENE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724041#action_12724041
]
Simon Willnauer commented on LUCENE-1717:
-
HA, true! I missed that. Nevermind!
I d
[
https://issues.apache.org/jira/browse/LUCENE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-1717:
Attachment: BufferedDeletes_beautification.patch
> IndexWriter does not properly account f
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-1630:
---
Attachment: LUCENE-1630-2.patch
Very small patch, just one class ... I can't believe it's me :)
> M
[
https://issues.apache.org/jira/browse/LUCENE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724039#action_12724039
]
Michael McCandless commented on LUCENE-1717:
deletesInRAM is in fact cleared,
On Thu, Jun 25, 2009 at 7:13 AM, Simon
Willnauer wrote:
> Yonik, did that mail went to the wrong mailing-list?!
> Seems like you aimed to send to a solr list.
Whoops... excuse me while I get another cup of coffee ;-)
-Yonik
http://www.lucidimagination.com
Yonik, did that mail went to the wrong mailing-list?!
Seems like you aimed to send to a solr list.
simon
On Thu, Jun 25, 2009 at 1:10 PM, Yonik Seeley wrote:
> For the next release cycle (presumably 1.5?) I think we should really
> try to stick to released versions of Lucene, and not use dev/trun
[
https://issues.apache.org/jira/browse/LUCENE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724032#action_12724032
]
Simon Willnauer commented on LUCENE-1717:
-
bq. But we default that to unlimited (m
For the next release cycle (presumably 1.5?) I think we should really
try to stick to released versions of Lucene, and not use dev/trunk
versions.
Early in Solr's lifetime, Lucene trunk was more stable (APIs changed
little, even on non-released versions), and Lucene releases were few
and far betwee
[
https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724024#action_12724024
]
Michael McCandless commented on LUCENE-1716:
OK that sounds like a good plan;
[
https://issues.apache.org/jira/browse/LUCENE-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-1715.
Resolution: Fixed
Thanks Brian!
> DirectoryIndexReader finalize() holding TermInf
[
https://issues.apache.org/jira/browse/LUCENE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless reassigned LUCENE-1705:
--
Assignee: Michael McCandless
> Add deleteAllDocuments() method to IndexWriter
[
https://issues.apache.org/jira/browse/LUCENE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1705:
---
Attachment: LUCENE-1705.patch
Patch looks good Tim!
I added another test case (for
[
https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724016#action_12724016
]
Shai Erera commented on LUCENE-1716:
I was afraid of that ... I think we should just d
[
https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724014#action_12724014
]
Michael McCandless commented on LUCENE-1716:
I'm hitting a failure here:
{code
[
https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless reassigned LUCENE-1716:
--
Assignee: Michael McCandless
> Adding norms, properties indexing and writer.in
[
https://issues.apache.org/jira/browse/LUCENE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724010#action_12724010
]
Michael McCandless commented on LUCENE-1717:
Sorry, you are correct -- that's
[
https://issues.apache.org/jira/browse/LUCENE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724007#action_12724007
]
Simon Willnauer commented on LUCENE-1717:
-
Maybe I miss something but IndexWriter#
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724006#action_12724006
]
Michael McCandless commented on LUCENE-1630:
bq. For these Tokenizers the cost
IndexReader.setTermInfosIndexDivisor doesn't carry over to reopened readers
---
Key: LUCENE-1718
URL: https://issues.apache.org/jira/browse/LUCENE-1718
Project: Lucene - Java
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724003#action_12724003
]
Uwe Schindler commented on LUCENE-1630:
---
bq. Whoa, powerful! But this sounds like a
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723998#action_12723998
]
Michael McCandless commented on LUCENE-1630:
That sounds like the right approa
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723996#action_12723996
]
Shai Erera commented on LUCENE-1630:
Previously creaetWeight() threw UOE, and I've cha
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723995#action_12723995
]
Michael McCandless commented on LUCENE-1630:
bq. With my newest TokenStream im
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723989#action_12723989
]
Uwe Schindler commented on LUCENE-1630:
---
{quote}
EG, we could have the default impl
[
https://issues.apache.org/jira/browse/LUCENE-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1461:
--
Attachment: LUCENE-1461.patch
Updated patch. It now changes the includeUpper/Lower behaviour t
IndexWriter does not properly account for the RAM consumed by pending deletes
-
Key: LUCENE-1717
URL: https://issues.apache.org/jira/browse/LUCENE-1717
Project: Lucene - Java
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless reopened LUCENE-1630:
SOLR-940 is hitting an exception due to the addition of QueryWeight:
because we've add
82 matches
Mail list logo
