Re: Plugins using removed Guava APIs

2021-10-02 Thread Jim Klimov
On October 2, 2021 10:33:47 PM UTC, Basil Crow wrote: >With a new LTS release around the corner, I would like to set a target >for the merge and release of the Guava upgrade (i.e., >jenkinsci/jenkins#5707 / jenkinsci/jep#375 / JENKINS-65988). > >The plugin BOM test suite is passing against the

Re: Plugins using removed Guava APIs

2021-10-02 Thread Basil Crow
With a new LTS release around the corner, I would like to set a target for the merge and release of the Guava upgrade (i.e., jenkinsci/jenkins#5707 / jenkinsci/jep#375 / JENKINS-65988). The plugin BOM test suite is passing against the incremental from jenkinsci/jenkins#5707 as of today. I also

Re: Plugins using removed Guava APIs

2021-09-17 Thread Basil Crow
Thanks to everyone who has reviewed PRs, merged PRs, and shipped releases. As the Jira epic shows, the majority of plugins have been prepared, with a small number of critical PRs still awaiting merge and an even smaller number still awaiting release. These should trickle in over the coming weeks.

Re: Plugins using removed Guava APIs

2021-08-22 Thread Olivier Lamy
On Sun, 22 Aug 2021 at 10:28, Basil Crow wrote: > On Sat, Aug 7, 2021 at 12:12 PM Basil Crow wrote: > > > > There are at least 25 additional plugins with confirmed Guava > > regressions that must be prepared and released. Some of them have > > significant adoption. I have enumerated them in

Re: Plugins using removed Guava APIs

2021-08-21 Thread Basil Crow
On Sat, Aug 7, 2021 at 12:12 PM Basil Crow wrote: > > There are at least 25 additional plugins with confirmed Guava > regressions that must be prepared and released. Some of them have > significant adoption. I have enumerated them in this epic: > > https://issues.jenkins.io/browse/JENKINS-65988

Re: Plugins using removed Guava APIs

2021-08-13 Thread Tim Jacomb
Bom is now passing with the guava change https://github.com/jenkinsci/bom/pull/423 Just one change that's using an incremental currently and needs a release, which should be done soon-ish I believe: https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/147 Thanks Tim On Tue, 10 Aug 2021

Re: Plugins using removed Guava APIs

2021-08-10 Thread James Nord
Thanks Basil, The operations center ones are released in lock step with a new LTS version, so I wouldn't worry too much about regressions there. We have internal tickets to track all the work (we had previously focused on the OSS part as we knew it would take longer due to not being

Re: Plugins using removed Guava APIs

2021-08-08 Thread Basil Crow
Eight CloudBees proprietary plugins appear to require preparation for the Guava upgrade, at least in the latest released versions. I have included my notes below. It would be helpful if a CloudBees employee could prepare these plugins for the Guava upgrade and release new versions. --- CloudBees

Re: Plugins using removed Guava APIs

2021-08-07 Thread Basil Crow
Thanks to everyone who has been contributing to this effort, a number of plugins have been prepared for the Guava update and released: - Active Directory - Audit Trail - Blue Ocean (in alpha) - Gearman - Git client - HTTP Request - JUnit - Lockable Resources - Node Label Parameter - Pipeline:

Re: Plugins using removed Guava APIs

2021-05-10 Thread 'Cyrille Le Clerc' via Jenkins Developers
Hello, I couldn't find the source code of the cloudfoundry-bosh-cli . This plugin can be ignored as it it completely outdated, the BOSH CLI it integrates with has been replaced a long time ago by a BOSH CLI v2. Cyrille On Sunday, May 9, 2021 at 9:40:34 PM UTC+2 m...@basilcrow.com wrote: > I

Re: Plugins using removed Guava APIs

2021-05-09 Thread Basil Crow
I found that we can easily remove Guava usages from SSH Build Agents and Node Label Parameter as well: https://github.com/jenkinsci/ssh-slaves-plugin/pull/228 https://github.com/jenkinsci/nodelabelparameter-plugin/pull/28 -- You received this message because you are subscribed to the Google

Re: Plugins using removed Guava APIs

2021-05-09 Thread Basil Crow
On Thu, May 6, 2021 at 7:39 PM Basil Crow wrote: > > com/google/common/base/Objects#firstNonNull > - blueocean-pipeline-api-impl > - blueocean-pipeline-scm-api > - ec2-fleet > - gearman-plugin > - github > - jclouds-jenkins > - jira I opened PRs for a few of these:

Re: Plugins using removed Guava APIs

2021-05-09 Thread Basil Crow
On Thu, May 6, 2021 at 7:39 PM Basil Crow wrote: > > com/google/common/collect/Ranges > - audit-trail > - elastest > - http_request > - logstash > - scm-httpclient I opened PRs for a few of these: https://github.com/jenkinsci/http-request-plugin/pull/63

Re: Plugins using removed Guava APIs

2021-05-09 Thread 'Fritz Elfert' via Jenkins Developers
On 07.05.21 04:39, Basil Crow wrote: I started looking into which plugins use classes or methods from Guava 11 that have been removed in Guava 30. There is plenty of low-hanging fruit if anyone is interested in contributing by rewriting these usages. The list below is far from exhaustive, but

Re: Plugins using removed Guava APIs

2021-05-07 Thread James Nord
> > I merged usage in plugins this morning, so unless you need it released in > some way you shouldn't need that > Many thanks Tim! On Fri, 7 May 2021 at 16:08, Tim Jacomb wrote: > > remember is uses a PR not master of usage in plugins so it will find > usage in libraries too! > > I merged

Re: Plugins using removed Guava APIs

2021-05-07 Thread Tim Jacomb
> remember is uses a PR not master of usage in plugins so it will find usage in libraries too! I merged usage in plugins this morning, so unless you need it released in some way you shouldn't need that On Fri, 7 May 2021 at 16:07, Basil Crow wrote: > Thank you for sharing this! I posted PRs

Re: Plugins using removed Guava APIs

2021-05-07 Thread Basil Crow
Thank you for sharing this! I posted PRs for Timestamper and Lockable Resources: https://github.com/jenkinsci/timestamper-plugin/pull/116 https://github.com/jenkinsci/lockable-resources-plugin/pull/242 > I am wondering how best we should co-ordinate this work? I suggest writing some developer

Re: Plugins using removed Guava APIs

2021-05-07 Thread jn...@cloudbees.com
> Hopefully it's easy to generate your list again, is there a script? > I see you used usage in plugins :) I have a parameterized job I can kick off internally (the main bit being the list of things to pass "usage-in-plugins" which was created from the rev-api report.) attached these if anyone

Re: Plugins using removed Guava APIs

2021-05-07 Thread Tim Jacomb
I see you used usage in plugins :) On Fri, 7 May 2021 at 11:14, Tim Jacomb wrote: > FTR I've removed guava in all maintained azure plugins today (except > azure-ad, needs a follow up to move to caffeine cache) > > Hopefully it's easy to generate your list again, is there a script? > > On Fri, 7

Re: Plugins using removed Guava APIs

2021-05-07 Thread Tim Jacomb
FTR I've removed guava in all maintained azure plugins today (except azure-ad, needs a follow up to move to caffeine cache) Hopefully it's easy to generate your list again, is there a script? On Fri, 7 May 2021 at 11:09, jn...@cloudbees.com wrote: > HI Basil, > > Apologies I said I was going

Re: Plugins using removed Guava APIs

2021-05-07 Thread Olivier Lamy
blueocean is WIP https://github.com/jenkinsci/blueocean-plugin/pull/2163 (please don't create separate PR) On Fri, 7 May 2021 at 12:40, Basil Crow wrote: > I started looking into which plugins use classes or methods from Guava > 11 that have been removed in Guava 30. There is plenty of

Re: Plugins using removed Guava APIs

2021-05-07 Thread Tim Jacomb
scm-api done in https://github.com/jenkinsci/scm-api-plugin/pull/85 not released On Fri, 7 May 2021 at 03:40, Basil Crow wrote: > I started looking into which plugins use classes or methods from Guava > 11 that have been removed in Guava 30. There is plenty of low-hanging > fruit if anyone is

Plugins using removed Guava APIs

2021-05-06 Thread Basil Crow
I started looking into which plugins use classes or methods from Guava 11 that have been removed in Guava 30. There is plenty of low-hanging fruit if anyone is interested in contributing by rewriting these usages. The list below is far from exhaustive, but it's a start. If you maintain one of